Compare commits

..

225 commits

Author SHA1 Message Date
Fedora Release Engineering
0baf939494 Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild 2026-01-16 03:23:57 +00:00
Michal Srb
fb86abde3b a-a-save-container-data: validate input
Resolves: CVE-2025-12744

Signed-off-by: Michal Srb <michal@redhat.com>
2025-12-04 20:32:21 +01:00
Michal Srb
b36cf8c499 Update to 2.17.7
Signed-off-by: Michal Srb <michal@redhat.com>
2025-10-02 10:36:26 +02:00
Python Maint
ba57e0bbb5 Rebuilt for Python 3.14.0rc3 bytecode 2025-09-19 12:06:17 +02:00
Python Maint
54bdc1243f Rebuilt for Python 3.14.0rc2 bytecode 2025-08-15 12:37:49 +02:00
Adam Williamson
026c727cd2 Bump release 2025-08-01 10:49:36 -07:00
Adam Williamson
3e192a597d Obsolete fros packages
fros was recently retired:
https://src.fedoraproject.org/rpms/fros/c/1d5c887
it was added to comps to support abrt-desktop:
https://pagure.io/fedora-comps/c/e845f70
so it seems most appropriate to have abrt obsolete it, if we
don't just use obsolete-packages.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2025-07-25 14:27:51 -07:00
Fedora Release Engineering
ea69665c75 Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild 2025-07-23 16:42:37 +00:00
Python Maint
b8a18969b7 Rebuilt for Python 3.14 2025-06-03 15:33:02 +02:00
Zbigniew Jędrzejewski-Szmek
3063be65d9 Add sysusers.d config file to allow rpm to create users/groups automatically 2025-01-23 17:02:44 +01:00
Fedora Release Engineering
c76a737f5a Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild 2025-01-16 10:29:17 +00:00
David Abdurachmanov
67fc5aa756 Disable Requires on kexec-tools for riscv64
kexec is supported for riscv64 on the kernel side, but the tooling side
is not yet upstreamed. Status is unknown.

See recent failed kexec-tools builds on riscv64 here:
http://fedora.riscv.rocks/koji/packageinfo?packageID=17577

Signed-off-by: David Abdurachmanov <davidlt@rivosinc.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
2024-12-02 09:59:50 +00:00
Neal Gompa
1bb8628644 Drop container handler (rhbz#2295150) 2024-09-11 12:56:30 +02:00
Michal Srb
d48adf4500 Update to upstream release 2.17.6
Signed-off-by: Michal Srb <michal@redhat.com>
2024-09-01 15:24:09 +02:00
Fedora Release Engineering
e5b49f4be8 Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild 2024-07-17 16:31:08 +00:00
Zbigniew Jędrzejewski-Szmek
66812b6c92 Drop call to marshalparser
This is now done automatically by add-determinism:
https://fedoraproject.org/wiki/Changes/ReproduciblePackageBuilds
2024-06-18 13:04:35 +02:00
Python Maint
af451300aa Rebuilt for Python 3.13 2024-06-09 02:46:55 +02:00
Michal Srb
202231f9cb Update to 2.17.5
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-19 19:59:39 +01:00
Michal Srb
e8f18508da Update to upstream release 2.17.4
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-12 22:59:07 +01:00
Michal Srb
58c69f3384 Update spec file
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-05 22:35:28 +01:00
Michal Srb
7fea67f0ed Update to upstream release 2.17.2
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-04 23:45:24 +01:00
Fedora Release Engineering
7eebe59cc3 Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild 2024-01-22 22:34:46 +00:00
Fedora Release Engineering
f1adb64577 Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild 2024-01-19 12:03:02 +00:00
Fedora Release Engineering
32054b4681 Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-07-19 12:49:45 +00:00
Python Maint
bbc9c5edc4 Rebuilt for Python 3.12 2023-07-01 11:44:59 +02:00
Michal Srb
e76a84e22d Update to upstream release 2.17.1
Signed-off-by: Michal Srb <michal@redhat.com>
2023-06-30 13:29:27 +02:00
Python Maint
7073ad4346 Rebuilt for Python 3.12 2023-06-28 19:02:20 +02:00
Matěj Grabovský
1f0eac990d Update to upstream release 2.17.0
Signed-off-by: Matěj Grabovský <mgrabovs@redhat.com>
2023-05-22 11:38:48 +02:00
Michal Srb
e65ab2c3e6 Update to upstream release 2.16.1
Signed-off-by: Michal Srb <michal@redhat.com>
2023-03-30 11:37:17 +02:00
Matěj Grabovský
8c7bdb1523 Use SPDX format for license field
See [the wiki][1] for details.

[1]: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
2023-02-02 15:54:58 +01:00
Fedora Release Engineering
e73a64df97 Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-01-18 21:19:42 +00:00
Michal Srb
50a321fe1d Update to upstream release 2.16.0
Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-24 18:27:21 +02:00
Michal Srb
a20ba81e1d abrt-journal: First seek the journal tail and then set filters
Resolves: rhbz#2128662

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-19 15:41:54 +02:00
Michal Srb
c8a122775e applet: Update GLib constant name
This fixes FTBFS in F37+

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:59:26 +02:00
Michal Srb
4f63977e6d Adjust gating.yaml for non-Rawhide release
Fedora CI still doesn't run the generic tests
for non-Rawhide releases :/

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:44:21 +02:00
Michal Srb
534292e248 abrt-journal: call sd_journal_get_fd() right after sd_journal_open()
Resolves: rhbz#2128662

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:43:01 +02:00
Fedora Release Engineering
d3f14892f8 Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2022-07-20 20:22:13 +00:00
Michal Srb
1e992dd7d9 Fix FTBFS
Resolves: rhbz#2093924

Signed-off-by: Michal Srb <michal@redhat.com>
2022-06-16 13:24:42 +02:00
Python Maint
f144023834 Rebuilt for Python 3.11 2022-06-15 18:15:40 +02:00
Michal Srb
3f24d62289 Update to 2.15.1
Signed-off-by: Michal Srb <michal@redhat.com>
2022-03-10 21:48:33 +01:00
Fedora Release Engineering
f9fd407b73 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2022-01-19 20:51:29 +00:00
Matěj Grabovský
fcc2f68d2d Rebuild for testing 2022-01-19 14:54:57 +01:00
Matěj Grabovský
15bea33e03 tests: Add one more conflicting package 2022-01-19 12:27:20 +01:00
Matěj Grabovský
0302f37126 New upstream release 2.15.0 2022-01-17 19:27:36 +01:00
Miro Hrončok
88895e18b5 Fix issues with conflicting multilib packages 2022-01-12 16:24:16 +01:00
Matěj Grabovský
1c9f6e51cf Bump release for rebuild 2022-01-06 15:10:12 +01:00
Matěj Grabovský
810fcb1911 Do not install conflicting packages in test 2022-01-06 14:56:23 +01:00
Matěj Grabovský
1b8bae307a Rebuild for satyr 0.39 2021-12-22 11:22:22 +01:00
Matěj Grabovský
7c6ec28dde Backport Python lazy loading patch (rhbz#2007664) 2021-09-27 12:34:36 +02:00
Fedora Release Engineering
d99ab08e76 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-07-21 17:11:34 +00:00
Fedora Release Engineering
e3d620d8fc - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-07-21 12:16:28 +00:00
Björn Esser
1d49502fa7
Rebuild for versioned symbols in json-c 2021-07-10 11:51:13 +02:00
Python Maint
4f59333992 Rebuilt for Python 3.10 2021-06-07 17:17:41 +02:00
Michal Fabik
61c2c079e0 Bump release to rebuild in new side tag
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-06-04 15:02:12 +02:00
Python Maint
f99a7f835a Rebuilt for Python 3.10 2021-06-04 11:19:26 +02:00
Michal Fabik
a4e0effc61 Rebuild against libreport-2.15.2
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-06-02 20:59:37 +02:00
Michal Fabik
094983af73 New upstream release 2.14.6
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-05-25 12:52:10 +02:00
Michal Fabik
81ec67df39 Merge #8 Add simple smoke test 2021-05-05 09:42:57 +00:00
Sérgio M. Basto
26627dbec3 Add dependency on python3-systemd
commit 566e2eaacb21e07a8301c3e16408924c46045ad9
Author: Matěj Grabovský <mgrabovs@redhat.com>
Date:   Wed Jan 13 12:16:57 2021 +0100

    spec: Add dependency on python3-systemd

    abrt-action-check-oops-for-hw-error from the abrt-addon-vmcore package
    imports systemd.journal but the python3-systemd package is not declared
    as a dependency, which causes the script to crash if python3-systemd is
    not installed on the system.

    This commit fixes this by adding the formal dependency in the spec file.

    Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1914170
2021-05-01 20:29:26 +01:00
Sérgio M. Basto
126031c321 Obsoletes abrt-plugin-sosreport, to fix upgrade path 2021-04-30 22:41:16 +01:00
Michal Fabik
a1c9e8ff22 Add simple smoke test 2021-03-09 12:23:00 +01:00
Zbigniew Jędrzejewski-Szmek
074ab8b76c Rebuilt for updated systemd-rpm-macros
See https://pagure.io/fesco/issue/2583.
2021-03-02 16:14:14 +01:00
Michal Židek
7e13959917 gating: Add gating.yaml 2021-02-17 13:58:09 +01:00
Fedora Release Engineering
dacf4e649a - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-01-25 23:44:28 +00:00
Michal Fabik
003b0187a1 New upstream release 2.14.5
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-12-01 15:21:38 +01:00
Miro Hrončok
82eb0a22c3 Use autoreconf in %build instead of plain autoconf
This way, when stuff is fixed in automake, the source tarball does not need
to be re-generated in upstream to use the fix.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1897489
2020-11-13 11:17:17 +01:00
Matěj Grabovský
511e6ce6d4 Add upstream patch for an invalid read bug 2020-10-13 11:11:22 +02:00
Matěj Grabovský
1ab9d3859f Add patch for #1881745 2020-09-24 10:07:28 +02:00
Michal Fabik
00422605f4 spec: Add Provides to Obsoletes
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-24 09:38:50 +02:00
Michal Fabik
3de7b9d0b7 New upstream release 2.14.4
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-21 11:47:18 +02:00
Michal Fabik
5e37f50192 New upstream release 2.14.3
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-21 11:47:15 +02:00
Adam Williamson
92ab2eb5b3 Rebuild for libreport soname bump 2020-08-13 16:42:48 -07:00
Ernestas Kulik
935456c7d9 Add patch for #1860903 2020-07-28 16:28:09 +02:00
Fedora Release Engineering
d8a4ccc6c2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-07-27 11:40:43 +00:00
Miro Hrončok
a2bcded0dc Rebuilt for Python 3.9 2020-05-24 09:41:56 +02:00
Ernestas Kulik
18305b2c50 Add fix for #1836190 2020-05-21 16:21:26 +02:00
Michal Fabik
438b4b73c7 New upstream release 2.14.2
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-05-12 10:11:37 +02:00
Ernestas Kulik
9f7a213711 Bump libreport dependency 2020-04-25 11:12:34 +02:00
Michal Fabik
bf7b8afe4a New upstream release 2.14.1
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-04-24 18:15:58 +02:00
Björn Esser
61c6c411a8 Rebuild (json-c) 2020-04-22 00:01:43 +02:00
Ernestas Kulik
e161563d64 Bump libreport dependency 2020-02-07 10:52:02 +01:00
Ernestas Kulik
400b28eb78 Sync spec changes from upstream 2020-02-07 09:32:24 +01:00
Ernestas Kulik
c84c5d2738 Update to 2.14.0 2020-02-07 08:45:18 +01:00
Igor Raits
5f74b5e407
Backport few more patches to fix compatibility with new libreport
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 08:00:55 +01:00
Igor Raits
10288b9c6d
Add patch to fix build with new libreport
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 07:41:21 +01:00
Igor Raits
2bb52e3881
Rebuild for satyr 0.30
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 07:25:47 +01:00
Martin Kutlak
68a77d6ad6 Fix typo in spec file
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-31 10:44:31 +01:00
Martin Kutlak
8f4c491a4b Add patch for possibly unitialized variable
Removed comments after endifs.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-31 10:42:41 +01:00
Martin Kutlak
c7d2242d98 patch: Fix build failure with gcc -fno-common
Resolves: rhbz#1795820

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-30 17:10:50 +01:00
Fedora Release Engineering
4d76ca5e3a - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-01-28 11:08:18 +00:00
Ernestas Kulik
0c014bfd3a Bump release
Oops.
2020-01-14 14:01:49 +01:00
Ernestas Kulik
507c1e9e86 Drop scriptlets for abrt-ccpp.service
It’s been dropped, no use in triggering disabling or restarting. The
preset has had abrt-ccpp replaced with abrt-journal-core forever now as
well, so let’s just do it.
2020-01-14 13:58:06 +01:00
Matěj Grabovský
cbad6eeeab Use correct paths for installed Python modules
This patch is pulled from upstream.
2019-10-16 14:02:50 +02:00
Matěj Grabovský
ac861159ca New upstream release 2.13.0
Signed-off-by: Matěj Grabovský <mgrabovs@redhat.com>
2019-10-11 16:32:47 +02:00
Miro Hrončok
f182793f33 Rebuilt for Python 3.8.0rc1 (#1748018) 2019-10-03 13:50:11 +02:00
Miro Hrončok
9e6bef580f Rebuilt for Python 3.8 2019-08-17 18:45:15 +02:00
Ernestas Kulik
df2a70c73b Update to 2.12.2
Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-08-01 14:31:16 +02:00
Fedora Release Engineering
3e5d6a98ef - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-07-24 17:28:02 +00:00
Martin Kutlak
a2c5fdd9e8 Add patch to fix failing a-a-list-dsos on rawhide
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2019-07-12 17:36:43 +02:00
Martin Kutlak
6b11b1ff26 New upstream release version 2.12.1
* Remove gen-version from spec
- This is upstream script to generate version. This is not needed in dist-git.

[2.12.1]
Added
- Require dbus-tools for dbus-send command.

Changed
- ABRT won't process crashes coming from unpackaged applications by default.
- Completely removed support for Python2.
- Update new ABRT icon.
- retrace-client defaults to https.
- Updated man pages.
- Removed configurations from /usr/share/abrt.
- Removed provides for abrt-python packages.

Fixed
- Gracefully handle exceptions comming from abrt-action-generate-machine-id.
- Gracefully handle exceptions comming from abrt-action-install-debuginfo.
- Use correct name of environment variable for retrace-server.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2019-07-03 17:54:51 +02:00
Igor Gnatenko
f9e6665820
Rebuild for RPM 4.15
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-06-11 00:13:16 +02:00
Igor Gnatenko
17aa2db63d
Rebuild for RPM 4.15
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-06-10 17:41:59 +02:00
Miro Hrončok
1ee4720bca BR git explicitly, it is used in %prep
Previously, it was pulled in transitively,
that is no longer true.

  Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.k6RazT
  ...
  + /usr/bin/git init -q
  /var/tmp/rpm-tmp.k6RazT: line 42: /usr/bin/git: No such file or directory
  error: Bad exit status from /var/tmp/rpm-tmp.k6RazT (%prep)
2019-04-04 15:45:29 +02:00
Ernestas Kulik
67f63a5ca4 Bump release
Forgot to do that, too.

Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-05 16:49:11 +01:00
Ernestas Kulik
5dfc50845c Bump dependencies
Forgot to do that the first time.

Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-05 16:47:56 +01:00
Ernestas Kulik
c7b20eb399 Update to 2.12.0
Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-04 14:33:29 +01:00
Fedora Release Engineering
ebf644594c - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-01-31 12:53:03 +00:00
Igor Gnatenko
eadff202bc
Remove obsolete scriptlets
References: https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-01-27 12:37:15 +01:00
Matej Marusak
9d7d233bf9 Bump up release
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-12 12:41:33 +01:00
Matej Marusak
8086e64036 Fix use after free in applet
Fixes BZ#1665521

Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-12 12:39:07 +01:00
Matej Marusak
509bd67e3d Include forgotten macro
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 15:13:11 +01:00
Matej Marusak
895d076624 Update to work with new glib
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 14:46:39 +01:00
Matej Marusak
50039757c0 New upstream release
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 12:00:40 +01:00
Martin Kutlak
8dd747fded Remove omitted patches
Forgot to remove these in 92d1203917

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2018-10-08 15:31:11 +02:00
Martin Kutlak
92d1203917 New upstream release 2.11.0
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2018-10-08 15:20:06 +02:00
Adam Williamson
bcfb1b554d Backport several bugfix commits, inc. gdb bt generation fail
Generation of gdb backtraces in 2.10.10 is entirely broken. As
I was backporting that fix, I saw three other bug fix commits
that looked significant, so backported those too. One is needed
for the package to build at all (the g_type_class_add_private
replacement).
2018-09-15 15:14:00 -07:00
Igor Gnatenko
d26d504519
%{python_sitearch} → %{python2_sitearch}
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-07-30 00:22:30 +02:00
Igor Gnatenko
c6814312f9
%{python_sitelib} → %{python2_sitelib}
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-07-29 23:12:01 +02:00
Fedora Release Engineering
4ac8f5f7a9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-07-12 19:56:23 +00:00
Jason Tibbitts
a09a33c9f5 Remove needless use of %defattr 2018-07-10 00:09:12 -05:00
Miro Hrončok
3c2253dc6d Rebuilt for Python 3.7 2018-06-18 18:17:04 +02:00
Miro Hrončok
042464a929 Set PYTHON to python3 during install
...to avoid ambiguous python invocation

Fixes a FTBFS https://bugzilla.redhat.com/show_bug.cgi?id=1589314
2018-06-08 18:22:35 +02:00
Matej Marusak
dcab69a1fb New version 2.10.10
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2018-05-31 11:10:41 +02:00
Matej Habrnal
2c14e84f08 abrt do not require python2 if "with python3"
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-10 13:16:29 +02:00
Matej Habrnal
81b08b87c0 abrt-addon-ccpp do not require python2 if "with python3"
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-09 10:18:59 +02:00
Matej Habrnal
437b080e9a drop python2-abrt-addon requires
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-03 10:56:51 +02:00
Matej Habrnal
c9a0a107d9 Fix python requires in spec file
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-04-27 13:25:04 +02:00
Matej Habrnal
4f98a322c2 New upstream release 2.10.9
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-04-27 13:13:39 +02:00
Björn Esser
648b4c8601
Rebuilt for libjson-c.so.4 (json-c v0.13.1) on fc28 2018-03-27 10:11:14 +02:00
Matej Habrnal
fa6bf827b2 New version 2.10.8
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-03-21 11:52:41 +01:00
Björn Esser
22482fb18b
Rebuilt for libjson-c.so.4 (json-c v0.13.1) 2018-03-06 15:14:36 +01:00
Matej Habrnal
dc422cf7ed New version 2.10.7
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-02-26 15:27:37 +01:00
Matej Habrnal
e06dcb57e7 New version 2.10.6
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-02-21 16:34:57 +01:00
Igor Gnatenko
6b7ef25742 Remove BuildRoot definition
None of currently supported distributions need that.
It was needed last for EL5 which is EOL now

Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-13 23:00:48 +01:00
Igor Gnatenko
7b19a66f3c
Escape macros in %changelog
Reference: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/Y2ZUKK2B7T2IKXPMODNF6HB2O5T5TS6H/
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-09 09:04:06 +01:00
Fedora Release Engineering
09e4addde4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-02-07 01:46:08 +00:00
Igor Gnatenko
4684ea4866 Remove obsolete scriptlets
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-01-05 23:23:42 +01:00
Iryna Shcherbina
d663542b40 Fix ambiguous Python 2 dependency declarations 2017-12-11 14:39:41 +01:00
Björn Esser
37ad20102e
Rebuilt for libjson-c.so.3 2017-12-10 23:04:55 +01:00
Julius Milan
85802ca9d7 New version 2.10.5
Signed-off-by: Julius Milan <jmilan@redhat.com>
2017-11-02 19:54:22 +01:00
Martin Kutlak
a074333d28 Drop GPG check patch for unsigned packages
Rawhide packages are signed.
https://fedoraproject.org/wiki/Releases/Rawhide

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-09-27 10:21:34 +02:00
Martin Kutlak
6a0f0e431a Fix log renaming to log_warning
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-08-30 14:35:12 +02:00
Matej Habrnal
d2918af2e6 New version 2.10.4
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-08-28 13:06:51 +02:00
Zbigniew Jędrzejewski-Szmek
49b1bc1549 Fix %_isa and add some missing Provides 2017-08-19 18:39:14 -04:00
Zbigniew Jędrzejewski-Szmek
afd3ea3bea Finish renaming of python binary packages
I messed up previous commit, sorry.
2017-08-19 10:17:11 -04:00
Zbigniew Jędrzejewski-Szmek
f36c5ca8dc Rename python binary packages 2017-08-19 07:14:33 -04:00
Igor Gnatenko
2fe9ae6400 Hacks for RPM 4.14 support
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-11 12:27:27 +02:00
Igor Gnatenko
baf8fefda7 Rebuilt after RPM update (№ 3)
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-11 10:39:26 +02:00
Igor Gnatenko
9b73a80599 Rebuilt for RPM soname bump
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-10 22:06:39 +02:00
Igor Gnatenko
248ea8cdf4 Rebuilt for RPM soname bump
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-10 20:19:43 +02:00
Fedora Release Engineering
5349e70f0a - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild 2017-08-02 17:21:56 +00:00
Fedora Release Engineering
7ef5a567fa - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild 2017-07-26 02:31:58 +00:00
Martin Kutlak
7de0bef650 Fix sources
I accidently commited wrong sources file in commit 253f3b.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-06-16 10:14:02 +02:00
Martin Kutlak
253f3b5e24 New version 2.10.3
Resolves: #1452160, #1444924, #1437956

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-06-15 17:51:01 +02:00
Matej Habrnal
e8a62759b3 abrt-desktop shouldn't require gdb but gdb-headless
abrt-desktop required gdb which which pulls in gcc among other things.

Resolves: #1452336

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-05-19 10:17:53 +02:00
Matej Habrnal
a170e2f896 create /var/lib/abrt because of abrt-migration
abrt-addon-ccpp has to create /var/lib/abrt because
abrt-migration file is placed here.

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-04-27 10:33:50 +02:00
Matej Habrnal
3c50298685 New version 2.10.2
Resolves: #1439821

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-04-25 13:04:41 +02:00
Matej Habrnal
ba27e114c2 New version 2.10.1
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-03-16 12:50:11 +01:00
Fedora Release Engineering
d5ced8a4cf - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild 2017-02-10 05:41:51 +00:00
Igor Gnatenko
bdca143d24 Rebuild for xmlrpc-c
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-01-21 14:49:59 +01:00
Matej Habrnal
345ed6c98e Allow rpm to be optional at build time and bug fixes
Resolves #1413637, #1413451

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-01-18 10:53:54 +01:00
Matej Habrnal
540f6e7795 New version 2.10.0
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-01-03 12:56:21 +01:00
Miro Hrončok
a96f20b524 Rebuild for Python 3.6 2016-12-19 18:20:36 +01:00
Jakub Filak
21561ba82c New upstream release 2.9.0
Signed-off-by: Jakub Filak <jfilak@redhat.com>
2016-09-10 07:33:25 +02:00
Fedora Release Engineering
c649b7d724 - https://fedoraproject.org/wiki/Changes/Automatic_Provides_for_Python_RPM_Packages 2016-07-19 06:29:40 +00:00
Matej Habrnal
e2f4733fc4 New upstream release 2.8.2
Resolves #1357264

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-07-18 12:14:41 +02:00
Matej Habrnal
168feccb11 New upstream release 2.8.1
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-05-25 09:48:30 +02:00
Matej Habrnal
cd3efeaff4 Fix broken pipe error in a-a-install-debuginfo
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-04-11 09:50:01 +02:00
Matej Habrnal
a22abdb1f3 python3 addon: workaround a bug in traceback
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-03-07 15:33:46 +01:00
Matej Habrnal
ba94a9992a blacklist Firefox's plugin-container and turn off compat cores
Resolves: #1308840
2016-02-23 16:05:36 +01:00
Matej Habrnal
04b13c6fc9 drop %e from the core_pattern
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-02-10 10:43:04 +01:00
Matej Habrnal
ba52311fcb New version 2.8.0
Resolves: #1304310
2016-02-03 15:05:21 +01:00
Matej Habrnal
ee087b960d New version 2.7.2
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-02-02 14:31:00 +01:00
Jakub Filak
61650c58f2 New upstream release 2.7.1
CVE-2015-5273, CVE-2015-5287

Resolves: #1262252, #1284557
2015-11-23 17:52:30 +01:00
Zbigniew Jędrzejewski-Szmek
55488e54c7 Update requires on python-argcomplete 2015-11-14 15:00:41 -05:00
Jakub Filak
46dc322c41 Rebuilt for Python3.5 rebuild 2015-11-06 11:06:27 +01:00
Jakub Filak
820caf519c Fix broken problem details in abrt-cli/gnome-abrt 2015-10-28 00:34:04 +01:00
Matej Habrnal
52400fcf42 New version 2.7.0
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-10-15 16:37:31 +02:00
Matej Habrnal
58ac8d6e9a bodhi: fix a segfault when testing an os-release opt for 'rawhide'
and actualize the abrt-bodhi man page

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-09-15 12:55:38 +02:00
Matej Habrnal
ef5d23d3b1 Bug fixes
- introduce bodhi2 to abrt-bodhi
- don't start reporting of not-reportable problems
- add hawkey to BRs of abrt-bodhi
- add bash on the package blacklist

Resolves #1250379

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-08-26 16:52:35 +02:00
Matej Habrnal
b52e1a767a Fix bugs in a-auto-reporting, dbus, a-hook-ccpp and abrt-cli
Correct usage of abrt-gdb-exploitable.

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-08-17 09:51:23 +02:00
Jakub Filak
a6a1fceb2c Add python3-augeas to Requires 2015-07-29 17:49:11 +02:00
Jakub Filak
d01f0fa520 Rebuild for rpmlib
https://lists.fedoraproject.org/pipermail/devel/2015-July/212672.html
2015-07-28 16:14:28 +02:00
Matej Habrnal
66b169ccf2 Fixes related to transition to Python 3 and fix in abrt-merge-pstoreoops
Resolves #1246459

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-07-24 14:58:43 +02:00
Matej Habrnal
207cb13ae3 Use gettext instead of lgettext in all python scripts
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-07-22 18:18:18 +02:00
Jakub Filak
9705d07480 New upstream release 2.6.2 2015-07-20 15:22:55 +02:00
Matej Habrnal
071dfeb34c New upstream release 2.6.1
Resolves #1217901
2015-07-07 16:45:39 +02:00
Dennis Gilmore
9d664f2339 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild 2015-06-16 23:33:34 +00:00
Jakub Filak
a8bf279ba2 New upstream release 2.6.0 2015-06-10 08:32:19 +02:00
Matej Habrnal
34dad7f6af Automatic reporting from GSettings, Spelling/grammar fixes and another fixes
Resolves: #1217901

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-05-20 16:00:35 +02:00
Jakub Filak
b72e3399f7 Remove a no longer needed posttrans scriptlet
The scriptlet was making a copy of 'analyzer' file to 'type' file,
because there was no 'type' file long time ago, a new version
started requiring that element, thus we had to add a scriptlet
creating that problem element for the problems detected by older
versions of abrt (prior abrt-2.5.0, contents of analyzer was the same as
contents of type).
2015-04-13 11:44:16 +02:00
Jakub Filak
91cb6cb2c1 New upstream release 2.5.1 2015-04-09 09:12:18 +02:00
Jakub Filak
bc96715ec7 applet: fix notifications at startup 2015-03-20 06:51:21 +01:00
Jakub Filak
f986ffa0b7 New upstream release 2.5.0 2015-03-18 10:47:20 +01:00
Jakub Filak
6d542d86f0 New upstream release 2.4.0 2015-02-23 06:47:04 +01:00
Jakub Filak
181e4a81c9 Upstream git snapshot 2014-11-07 15:58:43 +01:00
Jakub Filak
1c1276f729 fix a bug in koops journald dumper 2014-10-14 12:33:39 +02:00
Jakub Filak
a355adb48f applet: show package, c-n: skip non-interactive 2014-10-13 10:50:41 +02:00
Jakub Filak
ceaa3bf1ae fix console-notifications breaking login 2014-10-09 17:05:10 +02:00
Jakub Filak
98d5ba2974 New upstream release 2.3.0 2014-10-09 12:38:47 +02:00
Jakub Filak
5cd8f8ac40 disable addon-vmcore on AArch64 2014-10-02 08:07:51 +02:00
Jakub Filak
55686befa2 upstream git snapshot
Resolves: #1141485
2014-10-01 16:41:18 +02:00
Jakub Filak
a1e92b0ca0 remove depency on crash 2014-09-11 16:39:10 +02:00
Jakub Filak
6313c5efdb Pre-release update 2014-09-01 09:20:09 +02:00
Peter Robinson
7a1e149f2d - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild 2014-08-15 19:54:31 +00:00
Jakub Filak
f4e24995ef systemd-journal koops, python exceptions without traceback 2014-07-16 15:39:33 +02:00
Jakub Filak
540b10b023 Don't use native unwinder on arm 2014-07-16 08:35:30 +02:00
Jakub Filak
44c60b82f1 Use native unwinder 2014-07-14 12:33:45 +02:00
Jakub Filak
529a992263 New upstream release 2.2.2
Resolves: #1105316
2014-07-08 13:35:48 +02:00
Jakub Filak
3c88c48e11 Deprecated GTK3 API, GDB auto-load files
Resolves: #1105940
2014-06-10 14:02:35 +02:00
Dennis Gilmore
041a3f6838 - Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild 2014-06-06 19:00:14 -05:00
Kalev Lember
0476bec4e8 Rebuilt for https://fedoraproject.org/wiki/Changes/Python_3.4 2014-05-27 21:02:36 +02:00
Jakub Filak
4fa16be75c Fix invalid dbus policy file 2014-05-06 15:34:43 +02:00
Jakub Filak
86cae0cb5d Fix desktop centric polkit policy file 2014-05-06 13:08:27 +02:00
Jakub Filak
ffb34b1eea New upstream release 2.2.1 2014-04-22 13:32:35 +02:00
Jakub Filak
637d5dc4ff New upstream release 2.2.0 2014-03-06 14:22:22 +01:00
Jakub Filak
265f0b768d Binary python modules in sitearch, upload-watch consuming too much of CPU 2014-02-10 15:04:43 +01:00
Jakub Filak
694a48b58e New upstream release 2.1.12 2014-01-30 16:47:38 +01:00
Jakub Filak
995b9a8c20 New upstream release 2.1.11
Signed-off-by: Jakub Filak <jfilak@redhat.com>
2014-01-09 09:58:30 +01:00
Jakub Filak
826fd374c3 New upstream release 2.1.10
Resolves: #812204, #1005762
2013-12-11 17:18:41 +01:00
Denys Vlasenko
cb53a4ad19 specfile: remove no longer needed copying from old dump directory to new one.
Related to rhbz#971869.

Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Acked-by: Jakub Filak <jfilak@redhat.com>
2013-11-06 13:51:22 +01:00
Jakub Filak
7d9993a382 New upstream release 2.1.9 2013-10-27 18:54:33 +01:00
Jakub Filak
332ed5e2cc New upstream release 2.1.8
And also remove unused patches

Resolves: #812204
2013-10-09 14:05:51 +02:00
Jakub Filak
348130428e remove rhel GPG keys patch which is no more necessary
https://github.com/abrt/abrt/issues/686
2013-09-13 15:49:19 +02:00
Jakub Filak
7622c62c17 New upstream release 2.1.7
Resolves: #994009
2013-09-12 11:44:46 +02:00
37 changed files with 1570 additions and 3599 deletions

1
.fmf/version Normal file
View file

@ -0,0 +1 @@
1

50
.gitignore vendored
View file

@ -37,3 +37,53 @@ abrt-1.1.13.tar.gz
/abrt-2.2.0.tar.gz
/abrt-2.2.1.tar.gz
/abrt-2.2.2.tar.gz
/abrt-2.3.0.tar.gz
/abrt-2.4.0.tar.gz
/abrt-2.5.0.tar.gz
/abrt-2.5.1.tar.gz
/abrt-2.6.0.tar.gz
/abrt-2.6.1.tar.gz
/abrt-2.6.2.tar.gz
/abrt-2.7.0.tar.gz
/abrt-2.7.1.tar.gz
/abrt-2.7.2.tar.gz
/abrt-2.8.0.tar.gz
/abrt-2.8.1.tar.gz
/abrt-2.8.2.tar.gz
/abrt-2.9.0.tar.gz
/abrt-2.10.0.tar.gz
/abrt-2.10.1.tar.gz
/abrt-2.10.2.tar.gz
/abrt-2.10.3.tar.gz
/abrt-2.10.4.tar.gz
/abrt-2.10.5.tar.gz
/abrt-2.10.6.tar.gz
/abrt-2.10.7.tar.gz
/abrt-2.10.8.tar.gz
/abrt-2.10.9.tar.gz
/abrt-2.10.10.tar.gz
/abrt-2.11.0.tar.gz
/abrt-2.11.1.tar.gz
/abrt-2.12.0.tar.gz
/abrt-2.12.1.tar.gz
/abrt-2.12.2.tar.gz
/abrt-2.13.0.tar.gz
/abrt-2.14.0.tar.gz
/abrt-2.14.1.tar.gz
/abrt-2.14.2.tar.gz
/abrt-2.14.3.tar.gz
/abrt-2.14.4.tar.gz
/abrt-2.14.5.tar.gz
/abrt-2.14.6.tar.gz
/abrt-2.15.0.tar.gz
/abrt-2.15.1.tar.gz
/abrt-2.16.0.tar.gz
/abrt-2.16.1.tar.gz
/abrt-2.17.0.tar.gz
/abrt-2.17.1.tar.gz
/abrt-2.17.2.tar.gz
/abrt-2.17.4.tar.gz
/abrt-2.17.5.tar.gz
/abrt-2.17.6.tar.gz
/abrt-2.17.7.tar.gz
/abrt-2.17.8.tar.gz

View file

@ -1,40 +0,0 @@
From d402628b64b0102803481f53e9e88d63ded56c08 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 9 Jul 2014 17:55:36 +0200
Subject: [PATCH] python: support exceptions without traceback
e.g. SyntaxError (python-2.7.5-13.fc20, python-2.7.7-2.fc21)
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/abrt_exception_handler.py.in | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/src/hooks/abrt_exception_handler.py.in b/src/hooks/abrt_exception_handler.py.in
index cb32e14..fa4f34f 100644
--- a/src/hooks/abrt_exception_handler.py.in
+++ b/src/hooks/abrt_exception_handler.py.in
@@ -55,12 +55,14 @@ def write_dump(tb_text, tb):
executable = sys.argv[0]
dso_list = None
- try:
- import rpm
- dso_list = get_dso_list(tb)
- except ImportError as imperr:
- syslog("RPM module not available, cannot query RPM db for package "\
- "names")
+ # Trace back is None in case of SyntaxError exception.
+ if tb:
+ try:
+ import rpm
+ dso_list = get_dso_list(tb)
+ except ImportError as imperr:
+ syslog("RPM module not available, cannot query RPM db for package "\
+ "names")
# Open ABRT daemon's socket and write data to it
try:
--
1.9.3

View file

@ -1,28 +0,0 @@
From fb44241a05dd55bbb07041f0f07671c68b1e88df Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 18 Jul 2014 13:50:42 +0200
Subject: [PATCH] xml: fix a typo in analyze_CCpp
Resolves rhbz#1120767
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/analyze_CCpp.xml.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/plugins/analyze_CCpp.xml.in b/src/plugins/analyze_CCpp.xml.in
index bdd81eb..c3da3a3 100644
--- a/src/plugins/analyze_CCpp.xml.in
+++ b/src/plugins/analyze_CCpp.xml.in
@@ -2,7 +2,7 @@
<event>
<name>Analyze C/C++ Crash</name>
<_description>Send core dump to remote retrace server for analysis or perform local analysis if the remote analysis fails</_description>
- <_long-description>Uploads coredump to a server, which generates backtrace and returns it. If user doens't want to upload his coredump to anywhere the event performs local analysis. Local analysis is run event if remote analysis fails.
+ <_long-description>Uploads coredump to a server, which generates backtrace and returns it. If user doesn't want to upload his coredump to anywhere the event performs local analysis. Local analysis is run event if remote analysis fails.
Pros: no need for debuginfo downloads. Retrace server's database of debuginfos is more complete. Retrace server may generate better backtraces.
Cons: coredump you upload contains all the data from the crashed program, including your private data, if any.
</_long-description>
--
1.9.3

View file

@ -1,185 +0,0 @@
From 251153d32f9007af4960463121110b3b0b88fc8d Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 22 Jul 2014 16:13:25 +0200
Subject: [PATCH] gettext: fix the initialization in python scripts
ABRT scripts cannot import and use _ symbol from reportclient because
reporclient's _ is bound to 'libreport' package.
Related to rhbz#1087880
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
po/POTFILES.in | 2 ++
src/daemon/abrt-handle-upload.in | 26 ++++++++++++++++++++++++--
src/plugins/abrt-action-analyze-vmcore.in | 25 ++++++++++++++++++++++++-
src/plugins/abrt-action-install-debuginfo.in | 2 +-
src/plugins/abrt-action-ureport | 25 +++++++++++++++++++++++--
5 files changed, 74 insertions(+), 6 deletions(-)
diff --git a/po/POTFILES.in b/po/POTFILES.in
index ff9b97a..e3f917b 100644
--- a/po/POTFILES.in
+++ b/po/POTFILES.in
@@ -14,6 +14,7 @@ src/daemon/abrtd.c
src/daemon/abrt-handle-event.c
src/daemon/abrt-upload-watch.c
src/daemon/abrt-auto-reporting.c
+src/daemon/abrt-handle-upload.in
src/lib/abrt_conf.c
src/lib/hooklib.c
src/lib/problem_api.c
@@ -32,6 +33,7 @@ src/plugins/abrt-action-generate-core-backtrace.c
src/plugins/abrt-action-install-debuginfo.in
src/plugins/abrt-action-perform-ccpp-analysis.in
src/plugins/abrt-action-trim-files.c
+src/plugins/abrt-action-ureport
src/plugins/abrt-gdb-exploitable
src/plugins/abrt-watch-log.c
src/plugins/abrt-dump-oops.c
diff --git a/src/daemon/abrt-handle-upload.in b/src/daemon/abrt-handle-upload.in
index 084170e..dbc4534 100755
--- a/src/daemon/abrt-handle-upload.in
+++ b/src/daemon/abrt-handle-upload.in
@@ -11,7 +11,29 @@ import tempfile
import shutil
import datetime
-from reportclient import _, set_verbosity, error_msg_and_die, error_msg, log
+from reportclient import set_verbosity, error_msg_and_die, error_msg, log
+
+GETTEXT_PROGNAME = "abrt"
+import locale
+import gettext
+
+_ = lambda x: gettext.lgettext(x)
+
+def init_gettext():
+ try:
+ locale.setlocale(locale.LC_ALL, "")
+ except locale.Error:
+ os.environ['LC_ALL'] = 'C'
+ locale.setlocale(locale.LC_ALL, "")
+ # Defeat "AttributeError: 'module' object has no attribute 'nl_langinfo'"
+ try:
+ gettext.bind_textdomain_codeset(GETTEXT_PROGNAME, locale.nl_langinfo(locale.CODESET))
+ except AttributeError:
+ pass
+ gettext.bindtextdomain(GETTEXT_PROGNAME, '/usr/share/locale')
+ gettext.textdomain(GETTEXT_PROGNAME)
+
+
import problem
def write_str_to(filename, s):
@@ -32,7 +54,7 @@ if __name__ == "__main__":
sys.exit(die_exitcode)
# localization
- #init_gettext() - done by reportclient module init
+ init_gettext()
verbose = 0
ABRT_VERBOSE = os.getenv("ABRT_VERBOSE")
diff --git a/src/plugins/abrt-action-analyze-vmcore.in b/src/plugins/abrt-action-analyze-vmcore.in
index 11ad846..c08af80 100644
--- a/src/plugins/abrt-action-analyze-vmcore.in
+++ b/src/plugins/abrt-action-analyze-vmcore.in
@@ -8,7 +8,28 @@ import sys
import getopt
from subprocess import Popen, PIPE
-from reportclient import _, verbose, set_verbosity, error_msg_and_die, error_msg
+from reportclient import verbose, set_verbosity, error_msg_and_die, error_msg
+
+GETTEXT_PROGNAME = "abrt"
+import locale
+import gettext
+
+_ = lambda x: gettext.lgettext(x)
+
+def init_gettext():
+ try:
+ locale.setlocale(locale.LC_ALL, "")
+ except locale.Error:
+ os.environ['LC_ALL'] = 'C'
+ locale.setlocale(locale.LC_ALL, "")
+ # Defeat "AttributeError: 'module' object has no attribute 'nl_langinfo'"
+ try:
+ gettext.bind_textdomain_codeset(GETTEXT_PROGNAME, locale.nl_langinfo(locale.CODESET))
+ except AttributeError:
+ pass
+ gettext.bindtextdomain(GETTEXT_PROGNAME, '/usr/share/locale')
+ gettext.textdomain(GETTEXT_PROGNAME)
+
PROGNAME = "abrt-action-analyze-vmcore"
@@ -26,6 +47,8 @@ if __name__ == "__main__":
tmpdir = ""
vmcore = ""
+ init_gettext()
+
help_text = _("Usage: {0} [-v[v]] [--core=VMCORE]").format(PROGNAME)
try:
opts, args = getopt.getopt(sys.argv[1:], "hvd", ["help", "core="])
diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index 5fd3110..f46d1b2 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -11,7 +11,7 @@ import errno
import getopt
import reportclient
from subprocess import Popen, PIPE
-from reportclient import _, verbose, log, log1, log2, set_verbosity, error_msg_and_die, error_msg
+from reportclient import verbose, log, log1, log2, set_verbosity, error_msg_and_die, error_msg
import time
from reportclient.debuginfo import DebugInfoDownload, filter_installed_debuginfos, build_ids_to_path, clean_up
import problem
diff --git a/src/plugins/abrt-action-ureport b/src/plugins/abrt-action-ureport
index 0f6de03..1abe7b3 100755
--- a/src/plugins/abrt-action-ureport
+++ b/src/plugins/abrt-action-ureport
@@ -10,7 +10,28 @@ import os
import getopt
from report import dd_opendir, DD_FAIL_QUIETLY_ENOENT, run_event_state
-from reportclient import _, set_verbosity, error_msg_and_die, error_msg, log1, log
+from reportclient import set_verbosity, error_msg_and_die, error_msg, log1, log
+
+GETTEXT_PROGNAME = "abrt"
+import locale
+import gettext
+
+_ = lambda x: gettext.lgettext(x)
+
+def init_gettext():
+ try:
+ locale.setlocale(locale.LC_ALL, "")
+ except locale.Error:
+ os.environ['LC_ALL'] = 'C'
+ locale.setlocale(locale.LC_ALL, "")
+ # Defeat "AttributeError: 'module' object has no attribute 'nl_langinfo'"
+ try:
+ gettext.bind_textdomain_codeset(GETTEXT_PROGNAME, locale.nl_langinfo(locale.CODESET))
+ except AttributeError:
+ pass
+ gettext.bindtextdomain(GETTEXT_PROGNAME, '/usr/share/locale')
+ gettext.textdomain(GETTEXT_PROGNAME)
+
def spawn_and_wait(prog):
try:
@@ -45,7 +66,7 @@ def run_event(event_name, dump_dir_name):
if __name__ == "__main__":
# localization
- #init_gettext() - done by reportclient module init
+ init_gettext()
verbose = 0
ABRT_VERBOSE = os.getenv("ABRT_VERBOSE")
--
1.9.3

View file

@ -1,35 +0,0 @@
From 093ac1dc74fd848fb45959f4b03bca01a054e7c0 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 12 Aug 2014 14:13:25 +0200
Subject: [PATCH] Revert "Support handling crashes in lxc containers"
This reverts commit 4ab9fbe1a6b7889a0cd59b1406e8789d52171fd2.
Michal Toman <mtoman@redhat.com> (2014-07-16):
While this adds support for containers that have ABRT installed inside
(unfortunately I am not aware of any at this moment), it completely
breaks the behavior for standard chroots that people are actually using
(especially koji + mock).
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/abrt-install-ccpp-hook.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hooks/abrt-install-ccpp-hook.in b/src/hooks/abrt-install-ccpp-hook.in
index 3939b15..aa01231 100755
--- a/src/hooks/abrt-install-ccpp-hook.in
+++ b/src/hooks/abrt-install-ccpp-hook.in
@@ -9,7 +9,7 @@ verbose=false
PATTERN_FILE="/proc/sys/kernel/core_pattern"
SAVED_PATTERN_DIR="@VAR_RUN@/abrt"
SAVED_PATTERN_FILE="@VAR_RUN@/abrt/saved_core_pattern"
-HOOK_BIN="/usr/sbin/chroot /proc/%P/root @libexecdir@/abrt-hook-ccpp"
+HOOK_BIN="@libexecdir@/abrt-hook-ccpp"
# Must match percent_specifiers[] order in abrt-hook-ccpp.c:
PATTERN="|$HOOK_BIN %s %c %p %u %g %t %e"
# Same, but with bogus "executable name" parameter
--
1.9.3

View file

@ -1,34 +0,0 @@
From 9ada4ca561c6f81600f6002d7c672ce9959bd78f Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 1 Aug 2014 16:13:35 +0200
Subject: [PATCH] koops: fix a use-after-free bug uncoverd by coverity
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-action-analyze-oops.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/plugins/abrt-action-analyze-oops.c b/src/plugins/abrt-action-analyze-oops.c
index 1e94e43..f74ebcb 100644
--- a/src/plugins/abrt-action-analyze-oops.c
+++ b/src/plugins/abrt-action-analyze-oops.c
@@ -62,7 +62,6 @@ int main(int argc, char **argv)
char *oops = dd_load_text(dd, FILENAME_BACKTRACE);
char hash_str[SHA1_RESULT_LEN*2 + 1];
int bad = koops_hash_str(hash_str, oops);
- free(oops);
if (bad)
{
error_msg("Can't find a meaningful backtrace for hashing in '%s'", dump_dir_name);
@@ -96,6 +95,8 @@ int main(int argc, char **argv)
}
}
+ free(oops);
+
if (!bad)
{
dd_save_text(dd, FILENAME_UUID, hash_str);
--
1.9.3

View file

@ -1,42 +0,0 @@
From 9f9c0e5ad48f8ff3dd719f76903b38fe3f86c689 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 26 Aug 2014 20:37:34 +0200
Subject: [PATCH] a-a-s-p-d: add firefox on the package blacklist
And drop the path to plugins-container from the path blacklist because:
- the path belongs to firefox package
- the path is invalid, the correct path is:
/usr/lib(64)/firefox/plugin-container
Resolves rhbz#1132018
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt-action-save-package-data.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/daemon/abrt-action-save-package-data.conf b/src/daemon/abrt-action-save-package-data.conf
index 3d35bb6..cac3c7c 100644
--- a/src/daemon/abrt-action-save-package-data.conf
+++ b/src/daemon/abrt-action-save-package-data.conf
@@ -7,7 +7,7 @@ OpenGPGCheck = yes
# Blacklisted packages
#
-BlackList = nspluginwrapper, valgrind, strace, mono-core
+BlackList = nspluginwrapper, valgrind, strace, mono-core, firefox
# Process crashes in executables which do not belong to any package?
#
@@ -15,7 +15,7 @@ ProcessUnpackaged = no
# Blacklisted executable paths (shell patterns)
#
-BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer, /usr/lib/xulrunner-*/plugin-container
+BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer
# interpreters names
Interpreters = python2, python2.7, python, python3, python3.3, perl, perl5.16.2
--
1.9.3

View file

@ -1,39 +0,0 @@
From ebf1fc2fc34a182fbe0cb4a99d4a07f1e72925dd Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 26 Aug 2014 23:57:46 +0200
Subject: [PATCH] a-h-event: don't spam system logs
Don't print messages about invalid dump directories so many times.
Every dump directory has at leas 4 post-create events and after end of
each of these events abrt-handle-event tries to find duplicates. It
means 4x opens every dump directory, so it prints 4 lines for a single
invalid dump directory.
This patch dissables the error messages in the default log mode.
Related to rhbz#1133674
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt-handle-event.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/src/daemon/abrt-handle-event.c b/src/daemon/abrt-handle-event.c
index 7100171..a65f86e 100644
--- a/src/daemon/abrt-handle-event.c
+++ b/src/daemon/abrt-handle-event.c
@@ -282,7 +282,11 @@ static int is_crash_a_dup(const char *dump_dir_name, void *param)
if (strcmp(dump_dir_name, dump_dir_name2) == 0)
goto next; /* we are never a dup of ourself */
+ int sv_logmode = logmode;
+ /* Silently ignore any error in the silent log level. */
+ logmode = g_verbose == 0 ? 0 : sv_logmode;
dd = dd_opendir(dump_dir_name2, /*flags:*/ DD_FAIL_QUIETLY_ENOENT | DD_OPEN_READONLY);
+ logmode = sv_logmode;
if (!dd)
goto next;
--
1.9.3

View file

@ -1,53 +0,0 @@
From 2d29ecb0067dad7f5abf7b469dde84484b1a79ed Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 27 Aug 2014 08:45:24 +0200
Subject: [PATCH] a-a-s-p-data: reduce amount of error messages
Read each GPG key only once. The GPG key dirs may contain many symlinks
and if their target cannot be read, then we print an error message for
every symlink pointing to the unreadable file. What's worse, the error
messages show a path to the target, so users see several identical
messages in the system logs.
Related to rhbz#1133674
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt-action-save-package-data.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/src/daemon/abrt-action-save-package-data.c b/src/daemon/abrt-action-save-package-data.c
index 6dbcfc2..cc86327 100644
--- a/src/daemon/abrt-action-save-package-data.c
+++ b/src/daemon/abrt-action-save-package-data.c
@@ -91,16 +91,22 @@ static void load_gpg_keys(void)
if (strcmp(gpg_keys_dir, "") != 0)
{
log_debug("Reading gpg keys from '%s'", gpg_keys_dir);
+ GHashTable *done_set = g_hash_table_new(g_str_hash, g_str_equal);
GList *gpg_files = get_file_list(gpg_keys_dir, NULL /* we don't care about the file ext */);
- GList *tmp_gpp_files = gpg_files;
- while (tmp_gpp_files)
+ for (GList *iter = gpg_files; iter; iter = g_list_next(iter))
{
- log_debug("Loading gpg key '%s'", fo_get_fullpath((file_obj_t *)tmp_gpp_files->data));
- settings_setOpenGPGPublicKeys = g_list_append(settings_setOpenGPGPublicKeys, xstrdup(fo_get_fullpath((file_obj_t *)(tmp_gpp_files->data)) ));
- tmp_gpp_files = g_list_next(tmp_gpp_files);
+ const char *key_path = fo_get_fullpath((file_obj_t *)iter->data);
+
+ if (g_hash_table_contains(done_set, key_path))
+ continue;
+
+ g_hash_table_insert(done_set, (gpointer)key_path, NULL);
+ log_debug("Loading gpg key '%s'", key_path);
+ settings_setOpenGPGPublicKeys = g_list_append(settings_setOpenGPGPublicKeys, xstrdup(key_path));
}
g_list_free_full(gpg_files, (GDestroyNotify)free_file_obj);
+ g_hash_table_destroy(done_set);
}
}
--
1.9.3

View file

@ -1,32 +0,0 @@
From 92a1237a3ece2b9cfbd8293b372e2f7a1b60b3d6 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 27 Aug 2014 08:52:39 +0200
Subject: [PATCH] dbus: don't ignore errors in verbose logging modes
Ignoring of errors even in higher levels of verbosity makes debugging
really hard.
Related to rhbz#1133674
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/lib/problem_api.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/lib/problem_api.c b/src/lib/problem_api.c
index c2b4b1c..07707db 100644
--- a/src/lib/problem_api.c
+++ b/src/lib/problem_api.c
@@ -53,7 +53,8 @@ int for_each_problem_in_dir(const char *path,
* when we raced with wizard.
*/
int sv_logmode = logmode;
- logmode = 0;
+ /* Silently ignore errors only in the silent log level. */
+ logmode = g_verbose == 0 ? 0: sv_logmode;
struct dump_dir *dd = dd_opendir(full_name, DD_OPEN_READONLY | DD_FAIL_QUIETLY_EACCES | DD_DONT_WAIT_FOR_LOCK);
logmode = sv_logmode;
if (dd)
--
1.9.3

View file

@ -1,60 +0,0 @@
From 03c64e1439baf60426b002ecb1b7052a426d348e Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 27 Aug 2014 09:30:54 +0200
Subject: [PATCH] logging: less log messages for duplicates
Related to rhbz#1133674
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt-handle-event.c | 4 ++--
src/daemon/abrt-server.c | 5 ++---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/daemon/abrt-handle-event.c b/src/daemon/abrt-handle-event.c
index a65f86e..2ed88db 100644
--- a/src/daemon/abrt-handle-event.c
+++ b/src/daemon/abrt-handle-event.c
@@ -142,7 +142,7 @@ static int dup_uuid_compare(const struct dump_dir *dd)
free(dd_uuid);
if (!different)
- log("Duplicate: UUID");
+ log_notice("Duplicate: UUID");
return !different;
}
@@ -197,7 +197,7 @@ static int dup_corebt_compare(const struct dump_dir *dd)
free(dd_corebt);
if (isdup)
- log("Duplicate: core backtrace");
+ log_notice("Duplicate: core backtrace");
return isdup;
}
diff --git a/src/daemon/abrt-server.c b/src/daemon/abrt-server.c
index 307b41b..9951468 100644
--- a/src/daemon/abrt-server.c
+++ b/src/daemon/abrt-server.c
@@ -194,15 +194,14 @@ static int run_post_create(const char *dirname)
strbuf_append_str(cmd_output, raw);
char *msg = cmd_output->buf;
- /* Hmm, DUP_OF_DIR: ends up in syslog. move log() into 'else'? */
- log("%s", msg);
-
if (child_is_post_create
&& prefixcmp(msg, "DUP_OF_DIR: ") == 0
) {
free(dup_of_dir);
dup_of_dir = xstrdup(msg + strlen("DUP_OF_DIR: "));
}
+ else
+ log("%s", msg);
strbuf_clear(cmd_output);
/* jump to next line */
--
1.9.3

View file

@ -1,26 +0,0 @@
From cecdd6d7af7988d9f86c98f301b15fdee349e403 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 28 Aug 2014 15:02:38 +0200
Subject: [PATCH] retrace: respect Bugzilla event preferences
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/analyze_RetraceServer.xml.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/plugins/analyze_RetraceServer.xml.in b/src/plugins/analyze_RetraceServer.xml.in
index e437cac..db2cd6e 100644
--- a/src/plugins/analyze_RetraceServer.xml.in
+++ b/src/plugins/analyze_RetraceServer.xml.in
@@ -10,6 +10,8 @@
<gui-review-elements>no</gui-review-elements>
<sending-sensitive-data>yes</sending-sensitive-data>
<options>
+ <import-event-options event="report_Bugzilla"/>
+
<option type="text" name="RETRACE_SERVER_URL">
<_label>Retrace server URL</_label>
<default-value>retrace.fedoraproject.org</default-value>
--
1.9.3

View file

@ -1,115 +0,0 @@
From 87b450235e38a4d00f3a4b008229fe02debec26f Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Mon, 8 Sep 2014 13:27:56 +0200
Subject: [PATCH] cli: make consistent commands in abrt-cli
Add abbreviations to the client's parametres.
Related to rhbz#1066501
---
doc/abrt-cli.txt | 2 +-
src/cli/abrt-cli.c | 20 +++++++++++---------
src/cli/builtin-cmd.h | 2 +-
src/cli/rm.c | 2 +-
4 files changed, 14 insertions(+), 12 deletions(-)
diff --git a/doc/abrt-cli.txt b/doc/abrt-cli.txt
index 792e781..1c95655 100644
--- a/doc/abrt-cli.txt
+++ b/doc/abrt-cli.txt
@@ -9,7 +9,7 @@ SYNOPSIS
--------
'abrt-cli' list [-vdf] [DIR]...
-'abrt-cli' rm [-v] DIR...
+'abrt-cli' remove [-v] DIR...
'abrt-cli' report [-v] DIR...
diff --git a/src/cli/abrt-cli.c b/src/cli/abrt-cli.c
index a95b8bf..c04c132 100644
--- a/src/cli/abrt-cli.c
+++ b/src/cli/abrt-cli.c
@@ -20,14 +20,15 @@
#include "libabrt.h"
#include "builtin-cmd.h"
-#define USAGE_OPTS_WIDTH 12
+#define USAGE_OPTS_WIDTH 16
#define USAGE_GAP 2
/* TODO: add --pager(default) and --no-pager */
-#define CMD(NAME, help) { #NAME, cmd_##NAME , (help) }
+#define CMD(NAME, ABBREV, help) { #NAME, ABBREV, cmd_##NAME , (help) }
struct cmd_struct {
const char *cmd;
+ const char *abbrev;
int (*fn)(int, const char **);
const char *help;
};
@@ -41,6 +42,7 @@ static void list_cmds_help(const struct cmd_struct *commands)
pos = fprintf(stderr, " ");
pos += fprintf(stderr, "%s", p->cmd);
+ pos += fprintf(stderr, ", %s", p->abbrev);
if (pos <= USAGE_OPTS_WIDTH)
pad = USAGE_OPTS_WIDTH - pos;
@@ -110,7 +112,7 @@ static void handle_internal_command(int argc, const char **argv,
for (const struct cmd_struct *p = commands; p->cmd; ++p)
{
- if (strcmp(p->cmd, cmd) != 0)
+ if (strcmp(p->cmd, cmd) != 0 && strcmp(p->abbrev, cmd) != 0)
continue;
exit(p->fn(argc, argv));
@@ -143,12 +145,12 @@ int main(int argc, const char **argv)
);
const struct cmd_struct commands[] = {
- CMD(list, _("List problems [in DIRs]")),
- CMD(rm, _("Remove problem directory DIR")),
- CMD(report, _("Analyze and report problem data in DIR")),
- CMD(info, _("Print information about DIR")),
- CMD(status, _("Print the count of the recent crashes")),
- {NULL, NULL, NULL}
+ CMD(list, "ls", _("List problems [in DIRs]")),
+ CMD(remove, "rm", _("Remove problem directory DIR")),
+ CMD(report, "e",_("Analyze and report problem data in DIR")),
+ CMD(info, "i", _("Print information about DIR")),
+ CMD(status, "st",_("Print the count of the recent crashes")),
+ {NULL, NULL, NULL, NULL}
};
migrate_to_xdg_dirs();
diff --git a/src/cli/builtin-cmd.h b/src/cli/builtin-cmd.h
index 491760b..18588e1 100644
--- a/src/cli/builtin-cmd.h
+++ b/src/cli/builtin-cmd.h
@@ -21,7 +21,7 @@
#define _BUILTIN_CMD_H_
extern int cmd_list(int argc, const char **argv);
-extern int cmd_rm(int argc, const char **argv);
+extern int cmd_remove(int argc, const char **argv);
extern int cmd_report(int argc, const char **argv);
extern int cmd_info(int argc, const char **argv);
extern int cmd_status(int argc, const char **argv);
diff --git a/src/cli/rm.c b/src/cli/rm.c
index 8f185a4..fe458ff 100644
--- a/src/cli/rm.c
+++ b/src/cli/rm.c
@@ -25,7 +25,7 @@
* add -q, --quite
*/
-int cmd_rm(int argc, const char **argv)
+int cmd_remove(int argc, const char **argv)
{
const char *program_usage_string = _(
"& rm [options] DIR..."
--
1.9.3

View file

@ -1,70 +0,0 @@
From 2d19dcd4dd4f937e48fb1e4ebd440ac99754d68a Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Mon, 15 Sep 2014 08:40:05 +0200
Subject: [PATCH] cli: robustize abrt-console-notification.sh
- don't show any notifications without a terminal connected to stdout
- don't continue without writable $HOME directory
- forward all error messages to /dev/null
Resolves rhbz#1141485
Related to rhbz#1139001
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 30 ++++++++++++++++++++++++------
1 file changed, 24 insertions(+), 6 deletions(-)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 937abb0..0090747 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -1,21 +1,39 @@
+# If shell is not connect to a terminal, exit immediately, because this script
+# should print out ABRT's status and it is senseless to continue without
+# terminal.
+tty -s || exit 0
+
+# If $HOME is not set, a non human user is logging in to shell but this script
+# should provide information to human users, therefore exiting immediately
+# without showing the notification.
+if [ -z "$HOME" ]; then
+ exit 0
+fi
+
+if [ -z "$ABRT_DEBUG_LOG" ]; then
+ ABRT_DEBUG_LOG="/dev/null"
+fi
+
LPATHDIR="$HOME/.cache/abrt"
SINCEFILE="$LPATHDIR/lastnotification"
if [ ! -f "$LPATHDIR" ]; then
- mkdir -p "$LPATHDIR"
+ # It might happen that user doesn't have write access on his home.
+ mkdir -p "$LPATHDIR" &> "$ABRT_DEBUG_LOG" || exit 0
fi
-TMPPATH=`mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> /dev/null`
+TMPPATH=`mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> "$ABRT_DEBUG_LOG"`
SINCE=0
if [ -f "$SINCEFILE" ]; then
- SINCE=`cat $SINCEFILE 2> /dev/null`
+ SINCE=`cat $SINCEFILE 2> "$ABRT_DEBUG_LOG"`
fi
# always update the lastnotification
if [ -f "$TMPPATH" ]; then
- date +%s > "$TMPPATH"
- mv -f "$TMPPATH" "$SINCEFILE"
+ # Be quite in case of errors and don't scare users by strange error messages.
+ date +%s > "$TMPPATH" 2> "$ABRT_DEBUG_LOG"
+ mv -f "$TMPPATH" "$SINCEFILE" &> "$ABRT_DEBUG_LOG"
fi
-abrt-cli status --since="$SINCE" 2> /dev/null
+abrt-cli status --since="$SINCE" 2> "$ABRT_DEBUG_LOG"
--
1.9.3

View file

@ -1,98 +0,0 @@
From b38e21eac482e85de1f0b09d0ec7187844c1a19d Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Mon, 15 Sep 2014 11:44:02 +0200
Subject: [PATCH] retrace-client: humanize sizes
G_FORMAT_SIZE_IEC_UNITS
use IEC (base 1024) units with "KiB"-style suffixes. IEC units should
only be used for reporting things with a strong "power of 2" basis, like
RAM sizes or RAID stripe sizes. Network and storage sizes should be
reported in the normal SI units.
Fixes #844
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-retrace-client.c | 36 +++++++++++++++++++++++-------------
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/src/plugins/abrt-retrace-client.c b/src/plugins/abrt-retrace-client.c
index 60bbbc2..0b67773 100644
--- a/src/plugins/abrt-retrace-client.c
+++ b/src/plugins/abrt-retrace-client.c
@@ -511,10 +511,16 @@ static int create(bool delete_temp_archive,
if (unpacked_size > settings->max_unpacked_size)
{
alert_crash_too_large();
- error_msg_and_die(_("The size of your crash is %lld bytes, "
+
+ /* Leaking size and max_size in hope the memory will be released in
+ * error_msg_and_die() */
+ gchar *size = g_format_size_full(unpacked_size, G_FORMAT_SIZE_IEC_UNITS);
+ gchar *max_size = g_format_size_full(settings->max_unpacked_size, G_FORMAT_SIZE_IEC_UNITS);
+
+ error_msg_and_die(_("The size of your crash is %s, "
"but the retrace server only accepts "
- "crashes smaller or equal to %lld bytes."),
- unpacked_size, settings->max_unpacked_size);
+ "crashes smaller or equal to %s."),
+ size, max_size);
}
if (settings->supported_formats)
@@ -610,14 +616,19 @@ static int create(bool delete_temp_archive,
/* Get the file size. */
fstat(tempfd, &file_stat);
+ gchar *human_size = g_format_size_full((long long)file_stat.st_size, G_FORMAT_SIZE_IEC_UNITS);
if ((long long)file_stat.st_size > settings->max_packed_size)
{
alert_crash_too_large();
- error_msg_and_die(_("The size of your archive is %lld bytes, "
+
+ /* Leaking human_size and max_size in hope the memory will be released in
+ * error_msg_and_die() */
+ gchar *max_size = g_format_size_full(settings->max_packed_size, G_FORMAT_SIZE_IEC_UNITS);
+
+ error_msg_and_die(_("The size of your archive is %s, "
"but the retrace server only accepts "
- "archives smaller or equal %lld bytes."),
- (long long)file_stat.st_size,
- settings->max_packed_size);
+ "archives smaller or equal to %s."),
+ human_size, max_size);
}
free_settings(settings);
@@ -626,8 +637,8 @@ static int create(bool delete_temp_archive,
if (size_mb > 8) /* 8 MB - should be configurable */
{
- char *question = xasprintf(_("You are going to upload %d megabytes. "
- "Continue?"), size_mb);
+ char *question = xasprintf(_("You are going to upload %s. "
+ "Continue?"), human_size);
int response = ask_yes_no(question);
free(question);
@@ -669,13 +680,12 @@ static int create(bool delete_temp_archive,
if (delay)
{
- if (size_mb > 1)
- printf(_("Uploading %d megabytes\n"), size_mb);
- else
- printf(_("Uploading %lld bytes\n"), (long long)file_stat.st_size);
+ printf(_("Uploading %s\n"), human_size);
fflush(stdout);
}
+ g_free(human_size);
+
strbuf_free(http_request);
int result = 0;
int i;
--
1.9.3

View file

@ -1,47 +0,0 @@
From a1f14b2e4585981a4cf6408509412bcfacbd9ea8 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Thu, 18 Sep 2014 15:02:01 +0200
Subject: [PATCH] dbus: fixed abrt-dbus memory leaks
Fixed memory leaks in abrt-dbus (method FindProblemByElementInTimeRange).
This method leaks memory if fuzzing on org.freedesktop.problems interface.
Related to rhbz#1015473
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/dbus/abrt-dbus.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/src/dbus/abrt-dbus.c b/src/dbus/abrt-dbus.c
index 0350dee..308a9af 100644
--- a/src/dbus/abrt-dbus.c
+++ b/src/dbus/abrt-dbus.c
@@ -685,13 +685,17 @@ static void handle_method_call(GDBusConnection *connection,
if (g_strcmp0(method_name, "FindProblemByElementInTimeRange") == 0)
{
- const char *element;
- const char *value;
- long timestamp_from;
- long timestamp_to;
- bool all;
-
- g_variant_get(parameters, "(ssxxb)", &element, &value, &timestamp_from, &timestamp_to, &all);
+ const gchar *element;
+ const gchar *value;
+ glong timestamp_from;
+ glong timestamp_to;
+ gboolean all;
+
+ g_variant_get_child(parameters, 0, "&s", &element);
+ g_variant_get_child(parameters, 1, "&s", &value);
+ g_variant_get_child(parameters, 2, "x", &timestamp_from);
+ g_variant_get_child(parameters, 3, "x", &timestamp_to);
+ g_variant_get_child(parameters, 4, "b", &all);
if (all && polkit_check_authorization_dname(caller, "org.freedesktop.problems.getall") == PolkitYes)
caller_uid = 0;
--
1.9.3

View file

@ -1,58 +0,0 @@
From 783a85a5161335f6722e132cc6fcb030054766e7 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 1 Oct 2014 17:14:50 +0200
Subject: [PATCH] applet: confirm ignoring of notifications
and fix a bug in abrt-action-notify
Related to rhbz#1084031
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/applet/applet.c | 16 +++++++++++++---
src/plugins/abrt-action-notify | 2 +-
2 files changed, 14 insertions(+), 4 deletions(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index 27c5fad..1618d8c 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -667,9 +667,19 @@ static void action_ignore(NotifyNotification *notification, gchar *action, gpoin
{
problem_info_t *pi = (problem_info_t *)user_data;
- log_debug("Ignoring problem '%s'", problem_info_get_dir(pi));
-
- ignored_problems_add_problem_data(g_ignore_set, pi->problem_data);
+ const char *const message = _(
+ "You are going to mute notifications of a particular problem. " \
+ "You will never see a notification bubble for this problem again, " \
+ "however, ABRT will be detecting it and you will be able " \
+ "to report it from ABRT GUI." \
+ "\n\n" \
+ "Do you want to continue?");
+
+ if (run_ask_yes_no_yesforever_dialog("AskIgnoreForever", message, NULL))
+ {
+ log_debug("Ignoring problem '%s'", problem_info_get_dir(pi));
+ ignored_problems_add_problem_data(g_ignore_set, pi->problem_data);
+ }
GError *err = NULL;
notify_notification_close(notification, &err);
diff --git a/src/plugins/abrt-action-notify b/src/plugins/abrt-action-notify
index cbabf74..8b8f38e 100644
--- a/src/plugins/abrt-action-notify
+++ b/src/plugins/abrt-action-notify
@@ -99,7 +99,7 @@ def emit_crash_dbus_signal(problem_data):
# member is a Boolean flag which is True if the element is required
arguments = ((FILENAME_PACKAGE, True), (CD_DUMPDIR, True),
(FILENAME_UID, False), (FILENAME_UUID, False),
- (FILENAME_PACKAGE, False))
+ (FILENAME_DUPHASH, False))
for elem in arguments:
itm = problem_data.get(elem[0])
--
1.9.3

View file

@ -1,49 +0,0 @@
From 05bf4d55d0316f6048b327399cef0db941db29e8 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Mon, 15 Sep 2014 13:43:10 +0200
Subject: [PATCH] cli: use portable syntax in abrt-console-notification
Thanks Dominic Cleal
Resolves rhbz#1141485
Related to rhbz#1139001
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 0090747..849273c 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -19,21 +19,21 @@ SINCEFILE="$LPATHDIR/lastnotification"
if [ ! -f "$LPATHDIR" ]; then
# It might happen that user doesn't have write access on his home.
- mkdir -p "$LPATHDIR" &> "$ABRT_DEBUG_LOG" || exit 0
+ mkdir -p "$LPATHDIR" >"$ABRT_DEBUG_LOG" 2>&1 || exit 0
fi
TMPPATH=`mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> "$ABRT_DEBUG_LOG"`
SINCE=0
if [ -f "$SINCEFILE" ]; then
- SINCE=`cat $SINCEFILE 2> "$ABRT_DEBUG_LOG"`
+ SINCE=`cat $SINCEFILE 2>"$ABRT_DEBUG_LOG"`
fi
# always update the lastnotification
if [ -f "$TMPPATH" ]; then
# Be quite in case of errors and don't scare users by strange error messages.
- date +%s > "$TMPPATH" 2> "$ABRT_DEBUG_LOG"
- mv -f "$TMPPATH" "$SINCEFILE" &> "$ABRT_DEBUG_LOG"
+ date +%s > "$TMPPATH" 2>"$ABRT_DEBUG_LOG"
+ mv -f "$TMPPATH" "$SINCEFILE" >"$ABRT_DEBUG_LOG" 2>&1
fi
-abrt-cli status --since="$SINCE" 2> "$ABRT_DEBUG_LOG"
+abrt-cli status --since="$SINCE" 2>"$ABRT_DEBUG_LOG"
--
1.9.3

View file

@ -1,48 +0,0 @@
From a8f12ee8aa40d9ff05004bf6661ab442ad161202 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 9 Oct 2014 16:28:12 +0200
Subject: [PATCH] console-notifications: use return instead of exit
Thanks Ray Strode [halfline] <rstrode@redhat.com>
Related to rhbz#1150169
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 849273c..38de7bb 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -1,13 +1,13 @@
-# If shell is not connect to a terminal, exit immediately, because this script
+# If shell is not connect to a terminal, return immediately, because this script
# should print out ABRT's status and it is senseless to continue without
# terminal.
-tty -s || exit 0
+tty -s || return 0
# If $HOME is not set, a non human user is logging in to shell but this script
-# should provide information to human users, therefore exiting immediately
+# should provide information to human users, therefore returning immediately
# without showing the notification.
if [ -z "$HOME" ]; then
- exit 0
+ return 0
fi
if [ -z "$ABRT_DEBUG_LOG" ]; then
@@ -19,7 +19,7 @@ SINCEFILE="$LPATHDIR/lastnotification"
if [ ! -f "$LPATHDIR" ]; then
# It might happen that user doesn't have write access on his home.
- mkdir -p "$LPATHDIR" >"$ABRT_DEBUG_LOG" 2>&1 || exit 0
+ mkdir -p "$LPATHDIR" >"$ABRT_DEBUG_LOG" 2>&1 || return 0
fi
TMPPATH=`mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> "$ABRT_DEBUG_LOG"`
--
1.9.3

View file

@ -1,28 +0,0 @@
From f5066db720d371604c8c1c42225a193602e72c84 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 10 Oct 2014 11:18:51 +0200
Subject: [PATCH] applet: don't show duphash instead of component
Related to rhbz#1084031
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/applet/applet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index 1618d8c..1da90fd 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -1327,7 +1327,7 @@ static void Crash(DBusMessage* signal)
if (duphash != NULL && duphash[0] != '\0')
problem_data_add_text_noteditable(pi->problem_data, FILENAME_DUPHASH, duphash);
if (package_name != NULL && package_name[0] != '\0')
- problem_data_add_text_noteditable(pi->problem_data, FILENAME_COMPONENT, duphash);
+ problem_data_add_text_noteditable(pi->problem_data, FILENAME_COMPONENT, package_name);
pi->foreign = foreign_problem;
show_problem_notification(pi, flags);
}
--
1.9.3

View file

@ -1,30 +0,0 @@
From caffc34bd6eada503ec0b8231dbecbfa5652eedd Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Sat, 11 Oct 2014 00:05:07 +0200
Subject: [PATCH] console-notifications: skip non-interactive shells
Related to rhbz#1141485
Related to rhbz#1139001
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 38de7bb..976dfc3 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -3,6 +3,9 @@
# terminal.
tty -s || return 0
+# Skip all for noninteractive shells for the same reason as above.
+[ -z "$PS1" ] && return 0
+
# If $HOME is not set, a non human user is logging in to shell but this script
# should provide information to human users, therefore returning immediately
# without showing the notification.
--
1.9.3

View file

@ -1,102 +0,0 @@
From 0f0a1c1b58b73bfa0b7449bc59a580dc321dba8b Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 15 Oct 2014 13:33:51 +0200
Subject: [PATCH] make ABRT quieter
Related: #1048384, #1147664
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrtd.c | 7 +++++--
src/hooks/abrt-hook-ccpp.c | 10 +++++-----
src/plugins/abrt-action-generate-core-backtrace.c | 2 +-
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/daemon/abrtd.c b/src/daemon/abrtd.c
index b8426dd..cce49eb 100644
--- a/src/daemon/abrtd.c
+++ b/src/daemon/abrtd.c
@@ -626,7 +626,7 @@ int main(int argc, char** argv)
s_signal_pipe_write = s_signal_pipe[1];
/* Enter the event loop */
- log("Init complete, entering main loop");
+ log_debug("Init complete, entering main loop");
run_main_loop(pMainloop);
cleanup:
@@ -652,7 +652,10 @@ int main(int argc, char** argv)
/* Exiting */
if (s_sig_caught && s_sig_caught != SIGALRM && s_sig_caught != SIGCHLD)
{
- error_msg("Got signal %d, exiting", s_sig_caught);
+ /* We use TERM to stop abrtd, so not printing out error message. */
+ if (s_sig_caught != SIGTERM)
+ error_msg("Got signal %d, exiting", s_sig_caught);
+
signal(s_sig_caught, SIG_DFL);
raise(s_sig_caught);
}
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
index 8e141d4..6f471e9 100644
--- a/src/hooks/abrt-hook-ccpp.c
+++ b/src/hooks/abrt-hook-ccpp.c
@@ -184,13 +184,13 @@ static char* get_executable(pid_t pid, int *fd_p)
if (deleted > executable && strcmp(deleted, " (deleted)") == 0)
{
*deleted = '\0';
- log("File '%s' seems to be deleted", executable);
+ log_info("File '%s' seems to be deleted", executable);
}
/* find and cut off prelink suffixes from the path */
char *prelink = executable + strlen(executable) - strlen(".#prelink#.XXXXXX");
if (prelink > executable && strncmp(prelink, ".#prelink#.", strlen(".#prelink#.")) == 0)
{
- log("File '%s' seems to be a prelink temporary file", executable);
+ log_info("File '%s' seems to be a prelink temporary file", executable);
*prelink = '\0';
}
return executable;
@@ -649,7 +649,7 @@ int main(int argc, char** argv)
* but it does not log file name */
error_msg_and_die("Error saving '%s'", path);
}
- log("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
+ log_notice("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
return 0;
}
@@ -836,7 +836,7 @@ int main(int argc, char** argv)
strcpy(path, newpath);
free(newpath);
- log("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
+ log_notice("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
notify_new_path(path);
@@ -874,7 +874,7 @@ int main(int argc, char** argv)
unlink(core_basename);
return 1;
}
- log("Saved core dump of pid %lu to %s (%llu bytes)", (long)pid, full_core_basename, (long long)core_size);
+ log_notice("Saved core dump of pid %lu to %s (%llu bytes)", (long)pid, full_core_basename, (long long)core_size);
}
return 0;
diff --git a/src/plugins/abrt-action-generate-core-backtrace.c b/src/plugins/abrt-action-generate-core-backtrace.c
index a992a5b..791af83 100644
--- a/src/plugins/abrt-action-generate-core-backtrace.c
+++ b/src/plugins/abrt-action-generate-core-backtrace.c
@@ -61,7 +61,7 @@ int main(int argc, char **argv)
sr_debug_parser = true;
/* Let user know what's going on */
- log(_("Generating core_backtrace"));
+ log_notice(_("Generating core_backtrace"));
char *error_message = NULL;
bool success;
--
1.9.3

View file

@ -1,128 +0,0 @@
From 9604d1b52843a3939fcee440b5c3ec6efd0ce9df Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 21 Oct 2014 14:57:10 +0200
Subject: [PATCH] applet: ensure writable dump directory before reporting
Related to rhbz#1084027
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/applet/applet.c | 62 ++++++++++++++++++++++++++++++++++-------------------
1 file changed, 40 insertions(+), 22 deletions(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index 1da90fd..f73ad74 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -303,6 +303,7 @@ typedef struct problem_info {
bool incomplete;
bool reported;
bool was_announced;
+ bool is_writable;
} problem_info_t;
static void push_to_deferred_queue(problem_info_t *pi)
@@ -320,6 +321,36 @@ static void problem_info_set_dir(problem_info_t *pi, const char *dir)
problem_data_add_text_noteditable(pi->problem_data, CD_DUMPDIR, dir);
}
+static bool problem_info_ensure_writable(problem_info_t *pi)
+{
+ if (pi->is_writable)
+ return true;
+
+ /* chown the directory in any case, because kernel oopses are not foreign */
+ /* but their dump directories are not writable without chowning them or */
+ /* stealing them. The stealing is deprecated as it breaks the local */
+ /* duplicate search and root cannot see them */
+ const int res = chown_dir_over_dbus(problem_info_get_dir(pi));
+ if (pi->foreign && res != 0)
+ {
+ error_msg(_("Can't take ownership of '%s'"), problem_info_get_dir(pi));
+ return false;
+ }
+ pi->foreign = false;
+
+ struct dump_dir *dd = open_directory_for_writing(problem_info_get_dir(pi), /* don't ask */ NULL);
+ if (!dd)
+ {
+ error_msg(_("Can't open directory for writing '%s'"), problem_info_get_dir(pi));
+ return false;
+ }
+
+ problem_info_set_dir(pi, dd->dd_dirname);
+ pi->is_writable = true;
+ dd_close(dd);
+ return true;
+}
+
static problem_info_t *problem_info_new(const char *dir)
{
problem_info_t *pi = xzalloc(sizeof(*pi));
@@ -606,8 +637,13 @@ static pid_t spawn_event_handler_child(const char *dump_dir_name, const char *ev
return child;
}
-static void run_report_from_applet(const char *dirname)
+static void run_report_from_applet(problem_info_t *pi)
{
+ if (!problem_info_ensure_writable(pi))
+ return;
+
+ const char *dirname = problem_info_get_dir(pi);
+
fflush(NULL); /* paranoia */
pid_t pid = fork();
if (pid < 0)
@@ -645,7 +681,7 @@ static void action_report(NotifyNotification *notification, gchar *action, gpoin
{
if (strcmp(A_REPORT_REPORT, action) == 0)
{
- run_report_from_applet(problem_info_get_dir(pi));
+ run_report_from_applet(pi);
problem_info_free(pi);
}
else
@@ -1114,7 +1150,7 @@ static gboolean handle_event_output_cb(GIOChannel *gio, GIOCondition condition,
if (pi->known || !(state->flags & REPORT_UNKNOWN_PROBLEM_IMMEDIATELY))
notify_problem(pi);
else
- run_report_from_applet(problem_info_get_dir(pi));
+ run_report_from_applet(pi);
}
else
{
@@ -1175,29 +1211,11 @@ static void export_event_configuration(const char *event_name)
static void run_event_async(problem_info_t *pi, const char *event_name, int flags)
{
- /* chown the directory in any case, because kernel oopses are not foreign */
- /* but their dump directories are not writable without chowning them or */
- /* stealing them. The stealing is deprecated as it breaks the local */
- /* duplicate search and root cannot see them */
- const int res = chown_dir_over_dbus(problem_info_get_dir(pi));
- if (pi->foreign && res != 0)
+ if (!problem_info_ensure_writable(pi))
{
- error_msg(_("Can't take ownership of '%s'"), problem_info_get_dir(pi));
problem_info_free(pi);
return;
}
- pi->foreign = false;
-
- struct dump_dir *dd = open_directory_for_writing(problem_info_get_dir(pi), /* don't ask */ NULL);
- if (!dd)
- {
- error_msg(_("Can't open directory for writing '%s'"), problem_info_get_dir(pi));
- problem_info_free(pi);
- return;
- }
-
- problem_info_set_dir(pi, dd->dd_dirname);
- dd_close(dd);
export_event_configuration(event_name);
--
1.9.3

View file

@ -1,26 +0,0 @@
From 196a13cf2265ffdac293975a676c2ff16fedf2ba Mon Sep 17 00:00:00 2001
From: Martin Milata <mmilata@redhat.com>
Date: Mon, 24 Nov 2014 17:43:02 +0100
Subject: [PATCH] Remove garbage from ccpp_event.conf
Signed-off-by: Martin Milata <mmilata@redhat.com>
---
src/plugins/ccpp_event.conf | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/plugins/ccpp_event.conf b/src/plugins/ccpp_event.conf
index 9fbe760..96e7891 100644
--- a/src/plugins/ccpp_event.conf
+++ b/src/plugins/ccpp_event.conf
@@ -16,8 +16,6 @@ EVENT=post-create analyzer=CCpp
fi
# Try generating backtrace, if it fails we can still use
# the hash generated by abrt-action-analyze-c
- ##satyr migration:
- #satyr abrt-create-core-stacktrace "$DUMP_DIR"
abrt-action-generate-core-backtrace
# Run GDB plugin to see if crash looks exploitable
abrt-action-analyze-vulnerability
--
1.9.3

View file

@ -1,31 +0,0 @@
From 15a068e4bbef7da966a8f753277fce065e50d7e4 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 25 Nov 2014 15:54:15 +0100
Subject: [PATCH] python: load the configuration from correct file
Python2 exception handler has its configuration stored in python.conf
file.
Related: rhbz#1166633
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/abrt_exception_handler.py.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hooks/abrt_exception_handler.py.in b/src/hooks/abrt_exception_handler.py.in
index fa4f34f..8412e5f 100644
--- a/src/hooks/abrt_exception_handler.py.in
+++ b/src/hooks/abrt_exception_handler.py.in
@@ -177,7 +177,7 @@ def require_abs_path():
import problem
try:
- conf = problem.load_plugin_conf_file("python3.conf")
+ conf = problem.load_plugin_conf_file("python.conf")
except OsError:
return False
--
1.9.3

View file

@ -1,41 +0,0 @@
From 684a5fcce536e628c339119accd04d42e1f27152 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 27 Nov 2014 12:45:04 +0100
Subject: [PATCH] vmcore: catch IOErrors and OSErrors
Perhaps some temporary data cleaner removed problem directory while the hook
was still using in.
Resolves: rhbz#1077241
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/abrt_harvest_vmcore.py.in | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/src/hooks/abrt_harvest_vmcore.py.in b/src/hooks/abrt_harvest_vmcore.py.in
index 17e2be8..c6a7e6b 100644
--- a/src/hooks/abrt_harvest_vmcore.py.in
+++ b/src/hooks/abrt_harvest_vmcore.py.in
@@ -272,8 +272,16 @@ def harvest_vmcore():
except OSError:
sys.stderr.write("Unable to delete '%s'. Ignoring\n" % f_full)
- # Let abrtd know what type of problem it is:
- create_abrtd_info(destdirnew)
+ try:
+ # Let abrtd know what type of problem it is:
+ create_abrtd_info(destdirnew)
+ except EnvironmentError as ex:
+ sys.stderr.write("Unable to create problem directory info: " + str(ex))
+ try:
+ shutil.rmtree(destdirnew)
+ except Exception as ex:
+ sys.stderr.write("Unable to remove incomplete problem directory: " + str(ex))
+ continue
# chown -R 0:0
change_owner_rec(destdirnew)
--
1.9.3

View file

@ -1,43 +0,0 @@
From d92ce50f162e0e4defeb99a5cf35941b382ba3d7 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 27 Nov 2014 14:30:48 +0100
Subject: [PATCH] vmcore: remove original vmcore file in the last step
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/abrt_harvest_vmcore.py.in | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/hooks/abrt_harvest_vmcore.py.in b/src/hooks/abrt_harvest_vmcore.py.in
index c6a7e6b..256f8f1 100644
--- a/src/hooks/abrt_harvest_vmcore.py.in
+++ b/src/hooks/abrt_harvest_vmcore.py.in
@@ -266,12 +266,6 @@ def harvest_vmcore():
shutil.rmtree(destdirnew)
continue
- if copyvmcore == 'no':
- try:
- shutil.rmtree(f_full)
- except OSError:
- sys.stderr.write("Unable to delete '%s'. Ignoring\n" % f_full)
-
try:
# Let abrtd know what type of problem it is:
create_abrtd_info(destdirnew)
@@ -291,6 +285,12 @@ def harvest_vmcore():
# Get rid of the .new suffix
shutil.move(destdirnew, destdir)
+ if copyvmcore == 'no':
+ try:
+ shutil.rmtree(f_full)
+ except OSError:
+ sys.stderr.write("Unable to delete '%s'. Ignoring\n" % f_full)
+
problem.notify_new_path(destdir)
--
1.9.3

View file

@ -1,25 +0,0 @@
From cf01ca8b589d66d975fc3b1525b58df466411c22 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 20 Jan 2015 15:12:05 +0100
Subject: [PATCH] console-notifications: add timeout
Related to #898
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 976dfc3..a98f164 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -39,4 +39,4 @@ if [ -f "$TMPPATH" ]; then
mv -f "$TMPPATH" "$SINCEFILE" >"$ABRT_DEBUG_LOG" 2>&1
fi
-abrt-cli status --since="$SINCE" 2>"$ABRT_DEBUG_LOG"
+timeout 10s abrt-cli status --since="$SINCE" 2>"$ABRT_DEBUG_LOG" || echo "'abrt-cli status' timed out"
--
1.9.3

View file

@ -1,29 +0,0 @@
From eeb63b2105786e63a75cac69311408908c8ecf28 Mon Sep 17 00:00:00 2001
From: Gregory Collins <greg@gregorycollins.net>
Date: Tue, 20 Jan 2015 18:39:42 -0800
Subject: [PATCH] Don't slurp unbounded amounts of data when invoking
journalctl. Fixes #887.
---
src/plugins/ccpp_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/ccpp_event.conf b/src/plugins/ccpp_event.conf
index 96e7891..985e80d 100644
--- a/src/plugins/ccpp_event.conf
+++ b/src/plugins/ccpp_event.conf
@@ -38,9 +38,9 @@ EVENT=post-create analyzer=CCpp
else
uid=`cat uid` &&
log="[System Logs]:\n" &&
- log=$log`journalctl -b --system | grep -F -e "$base_executable" | tail -99` &&
+ log=$log`journalctl -b --since=-3m --system | grep -F -e "$base_executable" | tail -99` &&
log=$log"\n[User Logs]:\n" &&
- log=$log`journalctl _UID="$uid" -b | grep -F -e "$base_executable" | tail -99` &&
+ log=$log`journalctl _UID="$uid" -b --since=-3m | grep -F -e "$base_executable" | tail -99` &&
log=`echo -e "$log"`
fi
if test -n "$log"; then
--
1.9.3

View file

@ -1,29 +0,0 @@
From 5ac45a9f799a83e8e7756fbb613adc0e7570a1a5 Mon Sep 17 00:00:00 2001
From: Gregory Collins <greg@gregorycollins.net>
Date: Wed, 21 Jan 2015 04:38:58 +0100
Subject: [PATCH] Rewrite journalctl invocations: replace grep/tail pipeline
with journalctl builtins.
---
src/plugins/ccpp_event.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/ccpp_event.conf b/src/plugins/ccpp_event.conf
index 985e80d..894c7eb 100644
--- a/src/plugins/ccpp_event.conf
+++ b/src/plugins/ccpp_event.conf
@@ -38,9 +38,9 @@ EVENT=post-create analyzer=CCpp
else
uid=`cat uid` &&
log="[System Logs]:\n" &&
- log=$log`journalctl -b --since=-3m --system | grep -F -e "$base_executable" | tail -99` &&
+ log=$log`journalctl -b --since=-3m --system -n 99 _COMM="$base_executable"` &&
log=$log"\n[User Logs]:\n" &&
- log=$log`journalctl _UID="$uid" -b --since=-3m | grep -F -e "$base_executable" | tail -99` &&
+ log=$log`journalctl -b --since=-3m -n 99 _COMM="$base_executable" _UID="$uid"` &&
log=`echo -e "$log"`
fi
if test -n "$log"; then
--
1.9.3

View file

@ -1,25 +0,0 @@
From 414ac716c6d3d93c01687bf2a5592caedff35c0d Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Wed, 21 Jan 2015 15:37:27 +0100
Subject: [PATCH] applet: Fix typo in "cuurent"
---
src/applet/applet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index f73ad74..1c3865c 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -488,7 +488,7 @@ static void new_dir_exists(GList **new_dirs)
* DIR2 - Current dir list has new element. IOW: new dir exists!
* Advance only current dirlist ptr.
* DIR3 - Only old list has element. Advance only old ptr.
- * DIR4 ==== - Old list ended, cuurent one didn't. New dir exists!
+ * DIR4 ==== - Old list ended, current one didn't. New dir exists!
* ====
*/
GList *l1 = dirlist = g_list_sort(dirlist, (GCompareFunc)strcmp);
--
1.9.3

View file

@ -1,34 +0,0 @@
From 5edb4efdf25cc8b79b8d5b0b2c58001381aa5f17 Mon Sep 17 00:00:00 2001
From: Bastien Nocera <hadess@hadess.net>
Date: Wed, 21 Jan 2015 16:53:37 +0100
Subject: [PATCH] applet: Fix typo in "Oterwise"
---
src/applet/applet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index 1c3865c..ae11fac 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -588,7 +588,7 @@ static void fork_exec_gui(const char *problem_id)
record_dirs:
/* Scan dirs and save new $XDG_CACHE_HOME/abrt/applet_dirlist.
- * (Oterwise, after a crash, next time applet is started,
+ * (Otherwise, after a crash, next time applet is started,
* it will show alert icon even if we did click on it
* "in previous life"). We ignore function return value.
*/
@@ -769,7 +769,7 @@ static void on_notify_close(NotifyNotification *notification, gpointer user_data
g_object_unref(notification);
/* Scan dirs and save new $XDG_CACHE_HOME/abrt/applet_dirlist.
- * (Oterwise, after a crash, next time applet is started,
+ * (Otherwise, after a crash, next time applet is started,
* it will show alert icon even if we did click on it
* "in previous life"). We ignore finction return value.
*/
--
1.9.3

3461
abrt.spec

File diff suppressed because it is too large Load diff

15
gating.yaml Normal file
View file

@ -0,0 +1,15 @@
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_testing
subject_type: koji_build
rules:
- !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_stable
subject_type: koji_build
rules:
- !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}

View file

@ -1 +1 @@
5133980911a7d841d073c61a75a490a1 abrt-2.2.2.tar.gz
SHA512 (abrt-2.17.8.tar.gz) = 90b74229412e0186bfa109ee940a60c9f3c0f7ce8c1216acad6f05619a1bb591e7f0bae87363143a05034312c9f14fe5ace341b84f680780ceb93a1e624705b3

10
tests/smoke.fmf Normal file
View file

@ -0,0 +1,10 @@
summary: Basic smoke test for abrt
prepare:
how: install
# Do not attempt to install conflicting subpackages.
exclude:
- abrt-atomic
- abrt-java-connector-container
- python3-abrt-container-addon
execute:
script: abrt-action-notify --help