Compare commits

...
Sign in to create a new pull request.

195 commits

Author SHA1 Message Date
Fedora Release Engineering
0baf939494 Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild 2026-01-16 03:23:57 +00:00
Michal Srb
fb86abde3b a-a-save-container-data: validate input
Resolves: CVE-2025-12744

Signed-off-by: Michal Srb <michal@redhat.com>
2025-12-04 20:32:21 +01:00
Michal Srb
b36cf8c499 Update to 2.17.7
Signed-off-by: Michal Srb <michal@redhat.com>
2025-10-02 10:36:26 +02:00
Python Maint
ba57e0bbb5 Rebuilt for Python 3.14.0rc3 bytecode 2025-09-19 12:06:17 +02:00
Python Maint
54bdc1243f Rebuilt for Python 3.14.0rc2 bytecode 2025-08-15 12:37:49 +02:00
Adam Williamson
026c727cd2 Bump release 2025-08-01 10:49:36 -07:00
Adam Williamson
3e192a597d Obsolete fros packages
fros was recently retired:
https://src.fedoraproject.org/rpms/fros/c/1d5c887
it was added to comps to support abrt-desktop:
https://pagure.io/fedora-comps/c/e845f70
so it seems most appropriate to have abrt obsolete it, if we
don't just use obsolete-packages.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2025-07-25 14:27:51 -07:00
Fedora Release Engineering
ea69665c75 Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild 2025-07-23 16:42:37 +00:00
Python Maint
b8a18969b7 Rebuilt for Python 3.14 2025-06-03 15:33:02 +02:00
Zbigniew Jędrzejewski-Szmek
3063be65d9 Add sysusers.d config file to allow rpm to create users/groups automatically 2025-01-23 17:02:44 +01:00
Fedora Release Engineering
c76a737f5a Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild 2025-01-16 10:29:17 +00:00
David Abdurachmanov
67fc5aa756 Disable Requires on kexec-tools for riscv64
kexec is supported for riscv64 on the kernel side, but the tooling side
is not yet upstreamed. Status is unknown.

See recent failed kexec-tools builds on riscv64 here:
http://fedora.riscv.rocks/koji/packageinfo?packageID=17577

Signed-off-by: David Abdurachmanov <davidlt@rivosinc.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
2024-12-02 09:59:50 +00:00
Neal Gompa
1bb8628644 Drop container handler (rhbz#2295150) 2024-09-11 12:56:30 +02:00
Michal Srb
d48adf4500 Update to upstream release 2.17.6
Signed-off-by: Michal Srb <michal@redhat.com>
2024-09-01 15:24:09 +02:00
Fedora Release Engineering
e5b49f4be8 Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild 2024-07-17 16:31:08 +00:00
Zbigniew Jędrzejewski-Szmek
66812b6c92 Drop call to marshalparser
This is now done automatically by add-determinism:
https://fedoraproject.org/wiki/Changes/ReproduciblePackageBuilds
2024-06-18 13:04:35 +02:00
Python Maint
af451300aa Rebuilt for Python 3.13 2024-06-09 02:46:55 +02:00
Michal Srb
202231f9cb Update to 2.17.5
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-19 19:59:39 +01:00
Michal Srb
e8f18508da Update to upstream release 2.17.4
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-12 22:59:07 +01:00
Michal Srb
58c69f3384 Update spec file
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-05 22:35:28 +01:00
Michal Srb
7fea67f0ed Update to upstream release 2.17.2
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-04 23:45:24 +01:00
Fedora Release Engineering
7eebe59cc3 Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild 2024-01-22 22:34:46 +00:00
Fedora Release Engineering
f1adb64577 Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild 2024-01-19 12:03:02 +00:00
Fedora Release Engineering
32054b4681 Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-07-19 12:49:45 +00:00
Python Maint
bbc9c5edc4 Rebuilt for Python 3.12 2023-07-01 11:44:59 +02:00
Michal Srb
e76a84e22d Update to upstream release 2.17.1
Signed-off-by: Michal Srb <michal@redhat.com>
2023-06-30 13:29:27 +02:00
Python Maint
7073ad4346 Rebuilt for Python 3.12 2023-06-28 19:02:20 +02:00
Matěj Grabovský
1f0eac990d Update to upstream release 2.17.0
Signed-off-by: Matěj Grabovský <mgrabovs@redhat.com>
2023-05-22 11:38:48 +02:00
Michal Srb
e65ab2c3e6 Update to upstream release 2.16.1
Signed-off-by: Michal Srb <michal@redhat.com>
2023-03-30 11:37:17 +02:00
Matěj Grabovský
8c7bdb1523 Use SPDX format for license field
See [the wiki][1] for details.

[1]: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
2023-02-02 15:54:58 +01:00
Fedora Release Engineering
e73a64df97 Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-01-18 21:19:42 +00:00
Michal Srb
50a321fe1d Update to upstream release 2.16.0
Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-24 18:27:21 +02:00
Michal Srb
a20ba81e1d abrt-journal: First seek the journal tail and then set filters
Resolves: rhbz#2128662

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-19 15:41:54 +02:00
Michal Srb
c8a122775e applet: Update GLib constant name
This fixes FTBFS in F37+

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:59:26 +02:00
Michal Srb
4f63977e6d Adjust gating.yaml for non-Rawhide release
Fedora CI still doesn't run the generic tests
for non-Rawhide releases :/

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:44:21 +02:00
Michal Srb
534292e248 abrt-journal: call sd_journal_get_fd() right after sd_journal_open()
Resolves: rhbz#2128662

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:43:01 +02:00
Fedora Release Engineering
d3f14892f8 Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2022-07-20 20:22:13 +00:00
Michal Srb
1e992dd7d9 Fix FTBFS
Resolves: rhbz#2093924

Signed-off-by: Michal Srb <michal@redhat.com>
2022-06-16 13:24:42 +02:00
Python Maint
f144023834 Rebuilt for Python 3.11 2022-06-15 18:15:40 +02:00
Michal Srb
3f24d62289 Update to 2.15.1
Signed-off-by: Michal Srb <michal@redhat.com>
2022-03-10 21:48:33 +01:00
Fedora Release Engineering
f9fd407b73 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2022-01-19 20:51:29 +00:00
Matěj Grabovský
fcc2f68d2d Rebuild for testing 2022-01-19 14:54:57 +01:00
Matěj Grabovský
15bea33e03 tests: Add one more conflicting package 2022-01-19 12:27:20 +01:00
Matěj Grabovský
0302f37126 New upstream release 2.15.0 2022-01-17 19:27:36 +01:00
Miro Hrončok
88895e18b5 Fix issues with conflicting multilib packages 2022-01-12 16:24:16 +01:00
Matěj Grabovský
1c9f6e51cf Bump release for rebuild 2022-01-06 15:10:12 +01:00
Matěj Grabovský
810fcb1911 Do not install conflicting packages in test 2022-01-06 14:56:23 +01:00
Matěj Grabovský
1b8bae307a Rebuild for satyr 0.39 2021-12-22 11:22:22 +01:00
Matěj Grabovský
7c6ec28dde Backport Python lazy loading patch (rhbz#2007664) 2021-09-27 12:34:36 +02:00
Fedora Release Engineering
d99ab08e76 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-07-21 17:11:34 +00:00
Fedora Release Engineering
e3d620d8fc - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-07-21 12:16:28 +00:00
Björn Esser
1d49502fa7
Rebuild for versioned symbols in json-c 2021-07-10 11:51:13 +02:00
Python Maint
4f59333992 Rebuilt for Python 3.10 2021-06-07 17:17:41 +02:00
Michal Fabik
61c2c079e0 Bump release to rebuild in new side tag
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-06-04 15:02:12 +02:00
Python Maint
f99a7f835a Rebuilt for Python 3.10 2021-06-04 11:19:26 +02:00
Michal Fabik
a4e0effc61 Rebuild against libreport-2.15.2
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-06-02 20:59:37 +02:00
Michal Fabik
094983af73 New upstream release 2.14.6
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-05-25 12:52:10 +02:00
Michal Fabik
81ec67df39 Merge #8 Add simple smoke test 2021-05-05 09:42:57 +00:00
Sérgio M. Basto
26627dbec3 Add dependency on python3-systemd
commit 566e2eaacb21e07a8301c3e16408924c46045ad9
Author: Matěj Grabovský <mgrabovs@redhat.com>
Date:   Wed Jan 13 12:16:57 2021 +0100

    spec: Add dependency on python3-systemd

    abrt-action-check-oops-for-hw-error from the abrt-addon-vmcore package
    imports systemd.journal but the python3-systemd package is not declared
    as a dependency, which causes the script to crash if python3-systemd is
    not installed on the system.

    This commit fixes this by adding the formal dependency in the spec file.

    Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1914170
2021-05-01 20:29:26 +01:00
Sérgio M. Basto
126031c321 Obsoletes abrt-plugin-sosreport, to fix upgrade path 2021-04-30 22:41:16 +01:00
Michal Fabik
a1c9e8ff22 Add simple smoke test 2021-03-09 12:23:00 +01:00
Zbigniew Jędrzejewski-Szmek
074ab8b76c Rebuilt for updated systemd-rpm-macros
See https://pagure.io/fesco/issue/2583.
2021-03-02 16:14:14 +01:00
Michal Židek
7e13959917 gating: Add gating.yaml 2021-02-17 13:58:09 +01:00
Fedora Release Engineering
dacf4e649a - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-01-25 23:44:28 +00:00
Michal Fabik
003b0187a1 New upstream release 2.14.5
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-12-01 15:21:38 +01:00
Miro Hrončok
82eb0a22c3 Use autoreconf in %build instead of plain autoconf
This way, when stuff is fixed in automake, the source tarball does not need
to be re-generated in upstream to use the fix.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1897489
2020-11-13 11:17:17 +01:00
Matěj Grabovský
511e6ce6d4 Add upstream patch for an invalid read bug 2020-10-13 11:11:22 +02:00
Matěj Grabovský
1ab9d3859f Add patch for #1881745 2020-09-24 10:07:28 +02:00
Michal Fabik
00422605f4 spec: Add Provides to Obsoletes
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-24 09:38:50 +02:00
Michal Fabik
3de7b9d0b7 New upstream release 2.14.4
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-21 11:47:18 +02:00
Michal Fabik
5e37f50192 New upstream release 2.14.3
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-21 11:47:15 +02:00
Adam Williamson
92ab2eb5b3 Rebuild for libreport soname bump 2020-08-13 16:42:48 -07:00
Ernestas Kulik
935456c7d9 Add patch for #1860903 2020-07-28 16:28:09 +02:00
Fedora Release Engineering
d8a4ccc6c2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-07-27 11:40:43 +00:00
Miro Hrončok
a2bcded0dc Rebuilt for Python 3.9 2020-05-24 09:41:56 +02:00
Ernestas Kulik
18305b2c50 Add fix for #1836190 2020-05-21 16:21:26 +02:00
Michal Fabik
438b4b73c7 New upstream release 2.14.2
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-05-12 10:11:37 +02:00
Ernestas Kulik
9f7a213711 Bump libreport dependency 2020-04-25 11:12:34 +02:00
Michal Fabik
bf7b8afe4a New upstream release 2.14.1
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-04-24 18:15:58 +02:00
Björn Esser
61c6c411a8 Rebuild (json-c) 2020-04-22 00:01:43 +02:00
Ernestas Kulik
e161563d64 Bump libreport dependency 2020-02-07 10:52:02 +01:00
Ernestas Kulik
400b28eb78 Sync spec changes from upstream 2020-02-07 09:32:24 +01:00
Ernestas Kulik
c84c5d2738 Update to 2.14.0 2020-02-07 08:45:18 +01:00
Igor Raits
5f74b5e407
Backport few more patches to fix compatibility with new libreport
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 08:00:55 +01:00
Igor Raits
10288b9c6d
Add patch to fix build with new libreport
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 07:41:21 +01:00
Igor Raits
2bb52e3881
Rebuild for satyr 0.30
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 07:25:47 +01:00
Martin Kutlak
68a77d6ad6 Fix typo in spec file
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-31 10:44:31 +01:00
Martin Kutlak
8f4c491a4b Add patch for possibly unitialized variable
Removed comments after endifs.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-31 10:42:41 +01:00
Martin Kutlak
c7d2242d98 patch: Fix build failure with gcc -fno-common
Resolves: rhbz#1795820

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-30 17:10:50 +01:00
Fedora Release Engineering
4d76ca5e3a - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-01-28 11:08:18 +00:00
Ernestas Kulik
0c014bfd3a Bump release
Oops.
2020-01-14 14:01:49 +01:00
Ernestas Kulik
507c1e9e86 Drop scriptlets for abrt-ccpp.service
It’s been dropped, no use in triggering disabling or restarting. The
preset has had abrt-ccpp replaced with abrt-journal-core forever now as
well, so let’s just do it.
2020-01-14 13:58:06 +01:00
Matěj Grabovský
cbad6eeeab Use correct paths for installed Python modules
This patch is pulled from upstream.
2019-10-16 14:02:50 +02:00
Matěj Grabovský
ac861159ca New upstream release 2.13.0
Signed-off-by: Matěj Grabovský <mgrabovs@redhat.com>
2019-10-11 16:32:47 +02:00
Miro Hrončok
f182793f33 Rebuilt for Python 3.8.0rc1 (#1748018) 2019-10-03 13:50:11 +02:00
Miro Hrončok
9e6bef580f Rebuilt for Python 3.8 2019-08-17 18:45:15 +02:00
Ernestas Kulik
df2a70c73b Update to 2.12.2
Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-08-01 14:31:16 +02:00
Fedora Release Engineering
3e5d6a98ef - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-07-24 17:28:02 +00:00
Martin Kutlak
a2c5fdd9e8 Add patch to fix failing a-a-list-dsos on rawhide
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2019-07-12 17:36:43 +02:00
Martin Kutlak
6b11b1ff26 New upstream release version 2.12.1
* Remove gen-version from spec
- This is upstream script to generate version. This is not needed in dist-git.

[2.12.1]
Added
- Require dbus-tools for dbus-send command.

Changed
- ABRT won't process crashes coming from unpackaged applications by default.
- Completely removed support for Python2.
- Update new ABRT icon.
- retrace-client defaults to https.
- Updated man pages.
- Removed configurations from /usr/share/abrt.
- Removed provides for abrt-python packages.

Fixed
- Gracefully handle exceptions comming from abrt-action-generate-machine-id.
- Gracefully handle exceptions comming from abrt-action-install-debuginfo.
- Use correct name of environment variable for retrace-server.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2019-07-03 17:54:51 +02:00
Igor Gnatenko
f9e6665820
Rebuild for RPM 4.15
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-06-11 00:13:16 +02:00
Igor Gnatenko
17aa2db63d
Rebuild for RPM 4.15
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-06-10 17:41:59 +02:00
Miro Hrončok
1ee4720bca BR git explicitly, it is used in %prep
Previously, it was pulled in transitively,
that is no longer true.

  Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.k6RazT
  ...
  + /usr/bin/git init -q
  /var/tmp/rpm-tmp.k6RazT: line 42: /usr/bin/git: No such file or directory
  error: Bad exit status from /var/tmp/rpm-tmp.k6RazT (%prep)
2019-04-04 15:45:29 +02:00
Ernestas Kulik
67f63a5ca4 Bump release
Forgot to do that, too.

Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-05 16:49:11 +01:00
Ernestas Kulik
5dfc50845c Bump dependencies
Forgot to do that the first time.

Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-05 16:47:56 +01:00
Ernestas Kulik
c7b20eb399 Update to 2.12.0
Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-04 14:33:29 +01:00
Fedora Release Engineering
ebf644594c - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-01-31 12:53:03 +00:00
Igor Gnatenko
eadff202bc
Remove obsolete scriptlets
References: https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-01-27 12:37:15 +01:00
Matej Marusak
9d7d233bf9 Bump up release
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-12 12:41:33 +01:00
Matej Marusak
8086e64036 Fix use after free in applet
Fixes BZ#1665521

Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-12 12:39:07 +01:00
Matej Marusak
509bd67e3d Include forgotten macro
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 15:13:11 +01:00
Matej Marusak
895d076624 Update to work with new glib
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 14:46:39 +01:00
Matej Marusak
50039757c0 New upstream release
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 12:00:40 +01:00
Martin Kutlak
8dd747fded Remove omitted patches
Forgot to remove these in 92d1203917

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2018-10-08 15:31:11 +02:00
Martin Kutlak
92d1203917 New upstream release 2.11.0
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2018-10-08 15:20:06 +02:00
Adam Williamson
bcfb1b554d Backport several bugfix commits, inc. gdb bt generation fail
Generation of gdb backtraces in 2.10.10 is entirely broken. As
I was backporting that fix, I saw three other bug fix commits
that looked significant, so backported those too. One is needed
for the package to build at all (the g_type_class_add_private
replacement).
2018-09-15 15:14:00 -07:00
Igor Gnatenko
d26d504519
%{python_sitearch} → %{python2_sitearch}
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-07-30 00:22:30 +02:00
Igor Gnatenko
c6814312f9
%{python_sitelib} → %{python2_sitelib}
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-07-29 23:12:01 +02:00
Fedora Release Engineering
4ac8f5f7a9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-07-12 19:56:23 +00:00
Jason Tibbitts
a09a33c9f5 Remove needless use of %defattr 2018-07-10 00:09:12 -05:00
Miro Hrončok
3c2253dc6d Rebuilt for Python 3.7 2018-06-18 18:17:04 +02:00
Miro Hrončok
042464a929 Set PYTHON to python3 during install
...to avoid ambiguous python invocation

Fixes a FTBFS https://bugzilla.redhat.com/show_bug.cgi?id=1589314
2018-06-08 18:22:35 +02:00
Matej Marusak
dcab69a1fb New version 2.10.10
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2018-05-31 11:10:41 +02:00
Matej Habrnal
2c14e84f08 abrt do not require python2 if "with python3"
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-10 13:16:29 +02:00
Matej Habrnal
81b08b87c0 abrt-addon-ccpp do not require python2 if "with python3"
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-09 10:18:59 +02:00
Matej Habrnal
437b080e9a drop python2-abrt-addon requires
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-03 10:56:51 +02:00
Matej Habrnal
c9a0a107d9 Fix python requires in spec file
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-04-27 13:25:04 +02:00
Matej Habrnal
4f98a322c2 New upstream release 2.10.9
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-04-27 13:13:39 +02:00
Björn Esser
648b4c8601
Rebuilt for libjson-c.so.4 (json-c v0.13.1) on fc28 2018-03-27 10:11:14 +02:00
Matej Habrnal
fa6bf827b2 New version 2.10.8
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-03-21 11:52:41 +01:00
Björn Esser
22482fb18b
Rebuilt for libjson-c.so.4 (json-c v0.13.1) 2018-03-06 15:14:36 +01:00
Matej Habrnal
dc422cf7ed New version 2.10.7
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-02-26 15:27:37 +01:00
Matej Habrnal
e06dcb57e7 New version 2.10.6
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-02-21 16:34:57 +01:00
Igor Gnatenko
6b7ef25742 Remove BuildRoot definition
None of currently supported distributions need that.
It was needed last for EL5 which is EOL now

Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-13 23:00:48 +01:00
Igor Gnatenko
7b19a66f3c
Escape macros in %changelog
Reference: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/Y2ZUKK2B7T2IKXPMODNF6HB2O5T5TS6H/
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-09 09:04:06 +01:00
Fedora Release Engineering
09e4addde4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-02-07 01:46:08 +00:00
Igor Gnatenko
4684ea4866 Remove obsolete scriptlets
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-01-05 23:23:42 +01:00
Iryna Shcherbina
d663542b40 Fix ambiguous Python 2 dependency declarations 2017-12-11 14:39:41 +01:00
Björn Esser
37ad20102e
Rebuilt for libjson-c.so.3 2017-12-10 23:04:55 +01:00
Julius Milan
85802ca9d7 New version 2.10.5
Signed-off-by: Julius Milan <jmilan@redhat.com>
2017-11-02 19:54:22 +01:00
Martin Kutlak
a074333d28 Drop GPG check patch for unsigned packages
Rawhide packages are signed.
https://fedoraproject.org/wiki/Releases/Rawhide

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-09-27 10:21:34 +02:00
Martin Kutlak
6a0f0e431a Fix log renaming to log_warning
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-08-30 14:35:12 +02:00
Matej Habrnal
d2918af2e6 New version 2.10.4
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-08-28 13:06:51 +02:00
Zbigniew Jędrzejewski-Szmek
49b1bc1549 Fix %_isa and add some missing Provides 2017-08-19 18:39:14 -04:00
Zbigniew Jędrzejewski-Szmek
afd3ea3bea Finish renaming of python binary packages
I messed up previous commit, sorry.
2017-08-19 10:17:11 -04:00
Zbigniew Jędrzejewski-Szmek
f36c5ca8dc Rename python binary packages 2017-08-19 07:14:33 -04:00
Igor Gnatenko
2fe9ae6400 Hacks for RPM 4.14 support
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-11 12:27:27 +02:00
Igor Gnatenko
baf8fefda7 Rebuilt after RPM update (№ 3)
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-11 10:39:26 +02:00
Igor Gnatenko
9b73a80599 Rebuilt for RPM soname bump
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-10 22:06:39 +02:00
Igor Gnatenko
248ea8cdf4 Rebuilt for RPM soname bump
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-10 20:19:43 +02:00
Fedora Release Engineering
5349e70f0a - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild 2017-08-02 17:21:56 +00:00
Fedora Release Engineering
7ef5a567fa - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild 2017-07-26 02:31:58 +00:00
Martin Kutlak
7de0bef650 Fix sources
I accidently commited wrong sources file in commit 253f3b.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-06-16 10:14:02 +02:00
Martin Kutlak
253f3b5e24 New version 2.10.3
Resolves: #1452160, #1444924, #1437956

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-06-15 17:51:01 +02:00
Matej Habrnal
e8a62759b3 abrt-desktop shouldn't require gdb but gdb-headless
abrt-desktop required gdb which which pulls in gcc among other things.

Resolves: #1452336

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-05-19 10:17:53 +02:00
Matej Habrnal
a170e2f896 create /var/lib/abrt because of abrt-migration
abrt-addon-ccpp has to create /var/lib/abrt because
abrt-migration file is placed here.

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-04-27 10:33:50 +02:00
Matej Habrnal
3c50298685 New version 2.10.2
Resolves: #1439821

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-04-25 13:04:41 +02:00
Matej Habrnal
ba27e114c2 New version 2.10.1
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-03-16 12:50:11 +01:00
Fedora Release Engineering
d5ced8a4cf - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild 2017-02-10 05:41:51 +00:00
Igor Gnatenko
bdca143d24 Rebuild for xmlrpc-c
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-01-21 14:49:59 +01:00
Matej Habrnal
345ed6c98e Allow rpm to be optional at build time and bug fixes
Resolves #1413637, #1413451

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-01-18 10:53:54 +01:00
Matej Habrnal
540f6e7795 New version 2.10.0
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-01-03 12:56:21 +01:00
Miro Hrončok
a96f20b524 Rebuild for Python 3.6 2016-12-19 18:20:36 +01:00
Jakub Filak
21561ba82c New upstream release 2.9.0
Signed-off-by: Jakub Filak <jfilak@redhat.com>
2016-09-10 07:33:25 +02:00
Fedora Release Engineering
c649b7d724 - https://fedoraproject.org/wiki/Changes/Automatic_Provides_for_Python_RPM_Packages 2016-07-19 06:29:40 +00:00
Matej Habrnal
e2f4733fc4 New upstream release 2.8.2
Resolves #1357264

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-07-18 12:14:41 +02:00
Matej Habrnal
168feccb11 New upstream release 2.8.1
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-05-25 09:48:30 +02:00
Matej Habrnal
cd3efeaff4 Fix broken pipe error in a-a-install-debuginfo
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-04-11 09:50:01 +02:00
Matej Habrnal
a22abdb1f3 python3 addon: workaround a bug in traceback
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-03-07 15:33:46 +01:00
Matej Habrnal
ba94a9992a blacklist Firefox's plugin-container and turn off compat cores
Resolves: #1308840
2016-02-23 16:05:36 +01:00
Matej Habrnal
04b13c6fc9 drop %e from the core_pattern
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-02-10 10:43:04 +01:00
Matej Habrnal
ba52311fcb New version 2.8.0
Resolves: #1304310
2016-02-03 15:05:21 +01:00
Matej Habrnal
ee087b960d New version 2.7.2
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-02-02 14:31:00 +01:00
Jakub Filak
61650c58f2 New upstream release 2.7.1
CVE-2015-5273, CVE-2015-5287

Resolves: #1262252, #1284557
2015-11-23 17:52:30 +01:00
Zbigniew Jędrzejewski-Szmek
55488e54c7 Update requires on python-argcomplete 2015-11-14 15:00:41 -05:00
Jakub Filak
46dc322c41 Rebuilt for Python3.5 rebuild 2015-11-06 11:06:27 +01:00
Jakub Filak
820caf519c Fix broken problem details in abrt-cli/gnome-abrt 2015-10-28 00:34:04 +01:00
Matej Habrnal
52400fcf42 New version 2.7.0
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-10-15 16:37:31 +02:00
Matej Habrnal
58ac8d6e9a bodhi: fix a segfault when testing an os-release opt for 'rawhide'
and actualize the abrt-bodhi man page

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-09-15 12:55:38 +02:00
Matej Habrnal
ef5d23d3b1 Bug fixes
- introduce bodhi2 to abrt-bodhi
- don't start reporting of not-reportable problems
- add hawkey to BRs of abrt-bodhi
- add bash on the package blacklist

Resolves #1250379

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-08-26 16:52:35 +02:00
Matej Habrnal
b52e1a767a Fix bugs in a-auto-reporting, dbus, a-hook-ccpp and abrt-cli
Correct usage of abrt-gdb-exploitable.

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-08-17 09:51:23 +02:00
Jakub Filak
a6a1fceb2c Add python3-augeas to Requires 2015-07-29 17:49:11 +02:00
Jakub Filak
d01f0fa520 Rebuild for rpmlib
https://lists.fedoraproject.org/pipermail/devel/2015-July/212672.html
2015-07-28 16:14:28 +02:00
Matej Habrnal
66b169ccf2 Fixes related to transition to Python 3 and fix in abrt-merge-pstoreoops
Resolves #1246459

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-07-24 14:58:43 +02:00
Matej Habrnal
207cb13ae3 Use gettext instead of lgettext in all python scripts
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-07-22 18:18:18 +02:00
Jakub Filak
9705d07480 New upstream release 2.6.2 2015-07-20 15:22:55 +02:00
Matej Habrnal
071dfeb34c New upstream release 2.6.1
Resolves #1217901
2015-07-07 16:45:39 +02:00
Dennis Gilmore
9d664f2339 - Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild 2015-06-16 23:33:34 +00:00
Jakub Filak
a8bf279ba2 New upstream release 2.6.0 2015-06-10 08:32:19 +02:00
Matej Habrnal
34dad7f6af Automatic reporting from GSettings, Spelling/grammar fixes and another fixes
Resolves: #1217901

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-05-20 16:00:35 +02:00
Jakub Filak
b72e3399f7 Remove a no longer needed posttrans scriptlet
The scriptlet was making a copy of 'analyzer' file to 'type' file,
because there was no 'type' file long time ago, a new version
started requiring that element, thus we had to add a scriptlet
creating that problem element for the problems detected by older
versions of abrt (prior abrt-2.5.0, contents of analyzer was the same as
contents of type).
2015-04-13 11:44:16 +02:00
Jakub Filak
91cb6cb2c1 New upstream release 2.5.1 2015-04-09 09:12:18 +02:00
Jakub Filak
bc96715ec7 applet: fix notifications at startup 2015-03-20 06:51:21 +01:00
Jakub Filak
f986ffa0b7 New upstream release 2.5.0 2015-03-18 10:47:20 +01:00
Jakub Filak
6d542d86f0 New upstream release 2.4.0 2015-02-23 06:47:04 +01:00
22 changed files with 1559 additions and 162492 deletions

1
.fmf/version Normal file
View file

@ -0,0 +1 @@
1

49
.gitignore vendored
View file

@ -38,3 +38,52 @@ abrt-1.1.13.tar.gz
/abrt-2.2.1.tar.gz
/abrt-2.2.2.tar.gz
/abrt-2.3.0.tar.gz
/abrt-2.4.0.tar.gz
/abrt-2.5.0.tar.gz
/abrt-2.5.1.tar.gz
/abrt-2.6.0.tar.gz
/abrt-2.6.1.tar.gz
/abrt-2.6.2.tar.gz
/abrt-2.7.0.tar.gz
/abrt-2.7.1.tar.gz
/abrt-2.7.2.tar.gz
/abrt-2.8.0.tar.gz
/abrt-2.8.1.tar.gz
/abrt-2.8.2.tar.gz
/abrt-2.9.0.tar.gz
/abrt-2.10.0.tar.gz
/abrt-2.10.1.tar.gz
/abrt-2.10.2.tar.gz
/abrt-2.10.3.tar.gz
/abrt-2.10.4.tar.gz
/abrt-2.10.5.tar.gz
/abrt-2.10.6.tar.gz
/abrt-2.10.7.tar.gz
/abrt-2.10.8.tar.gz
/abrt-2.10.9.tar.gz
/abrt-2.10.10.tar.gz
/abrt-2.11.0.tar.gz
/abrt-2.11.1.tar.gz
/abrt-2.12.0.tar.gz
/abrt-2.12.1.tar.gz
/abrt-2.12.2.tar.gz
/abrt-2.13.0.tar.gz
/abrt-2.14.0.tar.gz
/abrt-2.14.1.tar.gz
/abrt-2.14.2.tar.gz
/abrt-2.14.3.tar.gz
/abrt-2.14.4.tar.gz
/abrt-2.14.5.tar.gz
/abrt-2.14.6.tar.gz
/abrt-2.15.0.tar.gz
/abrt-2.15.1.tar.gz
/abrt-2.16.0.tar.gz
/abrt-2.16.1.tar.gz
/abrt-2.17.0.tar.gz
/abrt-2.17.1.tar.gz
/abrt-2.17.2.tar.gz
/abrt-2.17.4.tar.gz
/abrt-2.17.5.tar.gz
/abrt-2.17.6.tar.gz
/abrt-2.17.7.tar.gz
/abrt-2.17.8.tar.gz

File diff suppressed because it is too large Load diff

View file

@ -1,48 +0,0 @@
From b7332b068c11ec16c190472684334944abb3607b Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 9 Oct 2014 16:28:12 +0200
Subject: [PATCH] console-notifications: use return instead of exit
Thanks Ray Strode [halfline] <rstrode@redhat.com>
Related to rhbz#1150169
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 849273c..38de7bb 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -1,13 +1,13 @@
-# If shell is not connect to a terminal, exit immediately, because this script
+# If shell is not connect to a terminal, return immediately, because this script
# should print out ABRT's status and it is senseless to continue without
# terminal.
-tty -s || exit 0
+tty -s || return 0
# If $HOME is not set, a non human user is logging in to shell but this script
-# should provide information to human users, therefore exiting immediately
+# should provide information to human users, therefore returning immediately
# without showing the notification.
if [ -z "$HOME" ]; then
- exit 0
+ return 0
fi
if [ -z "$ABRT_DEBUG_LOG" ]; then
@@ -19,7 +19,7 @@ SINCEFILE="$LPATHDIR/lastnotification"
if [ ! -f "$LPATHDIR" ]; then
# It might happen that user doesn't have write access on his home.
- mkdir -p "$LPATHDIR" >"$ABRT_DEBUG_LOG" 2>&1 || exit 0
+ mkdir -p "$LPATHDIR" >"$ABRT_DEBUG_LOG" 2>&1 || return 0
fi
TMPPATH=`mktemp --tmpdir="$LPATHDIR" lastnotification.XXXXXXXX 2> "$ABRT_DEBUG_LOG"`
--
2.1.0

View file

@ -1,85 +0,0 @@
From 9ef1d95f9556db4fdf02b283e1602b9e63b693c8 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 9 Oct 2014 10:24:42 +0200
Subject: [PATCH] ureport: attach contact email if configured
Related to rhbz#1150389
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-action-ureport | 35 ++++++++++++++++++++++++++++++++---
1 file changed, 32 insertions(+), 3 deletions(-)
diff --git a/src/plugins/abrt-action-ureport b/src/plugins/abrt-action-ureport
index 1abe7b3..df5f3d3 100755
--- a/src/plugins/abrt-action-ureport
+++ b/src/plugins/abrt-action-ureport
@@ -8,6 +8,7 @@
import sys
import os
import getopt
+import augeas
from report import dd_opendir, DD_FAIL_QUIETLY_ENOENT, run_event_state
from reportclient import set_verbosity, error_msg_and_die, error_msg, log1, log
@@ -33,12 +34,30 @@ def init_gettext():
gettext.textdomain(GETTEXT_PROGNAME)
-def spawn_and_wait(prog):
+def get_augeas(module, file_path):
+ """
+ A function for efficient configuration of Augeas.
+ Augeas modules are placed in /usr/share/augeas/lenses/dist
+ """
+
+ aug_obj = augeas.Augeas(flags=augeas.Augeas.NO_MODL_AUTOLOAD)
+ aug_obj.set("/augeas/load/{0}/lens".format(module), "{0}.lns".format(module))
+ aug_obj.set("/augeas/load/{0}/incl".format(module), file_path)
+ aug_obj.load()
+ return aug_obj
+
+
+def spawn_and_wait(prog, args=None):
+ if args is None:
+ args = [prog]
+ else:
+ args.insert(0, prog)
+
try:
- return os.spawnlp(os.P_WAIT, prog, prog)
+ return os.spawnvpe(os.P_WAIT, prog, args, os.environ)
except OSError as err:
error_msg(_("Unable to start '%s', error message was: '%s'"),
- prog, err)
+ " ".join(args), err)
return -1
def try_parse_number(dd, filename):
@@ -92,6 +111,7 @@ if __name__ == "__main__":
verbose += 1
set_verbosity(verbose)
+ os.environ["ABRT_VERBOSE"] = str(verbose)
# getcwd might fail if cwd was deleted
try:
@@ -159,6 +179,15 @@ if __name__ == "__main__":
log(_("Adding you to CC List of the existing bugzilla bug"))
run_event("watch_Bugzilla", dirname)
+ email = os.getenv("uReport_ContactEmail")
+ if not email:
+ augeas = get_augeas("libreport", "/etc/libreport/plugins/ureport.conf")
+ email = augeas.get("/files/etc/libreport/plugins/ureport.conf/ContactEmail")
+
+ if email:
+ log1("Attaching ContactEmail: " + email)
+ spawn_and_wait("reporter-ureport", ["-A", "-E"])
+
sys.exit(exitcode)
else:
error_msg_and_die(_("reporter-ureport failed with exit code %d" % exitcode))
--
2.1.0

View file

@ -1,28 +0,0 @@
From ad9e9d1609fd9e1365bf558f15c62ecb21304911 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 10 Oct 2014 11:18:51 +0200
Subject: [PATCH] applet: don't show duphash instead of component
Related to rhbz#1084031
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/applet/applet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index 0ae8c72..90c5b0d 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -1331,7 +1331,7 @@ static void Crash(DBusMessage* signal)
if (duphash != NULL && duphash[0] != '\0')
problem_data_add_text_noteditable(pi->problem_data, FILENAME_DUPHASH, duphash);
if (package_name != NULL && package_name[0] != '\0')
- problem_data_add_text_noteditable(pi->problem_data, FILENAME_COMPONENT, duphash);
+ problem_data_add_text_noteditable(pi->problem_data, FILENAME_COMPONENT, package_name);
pi->foreign = foreign_problem;
show_problem_notification(pi, flags);
}
--
2.1.0

View file

@ -1,30 +0,0 @@
From ab46bc9d85331fca923853353663c0ce0edc3716 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Sat, 11 Oct 2014 00:05:07 +0200
Subject: [PATCH] console-notifications: skip non-interactive shells
Related to rhbz#1141485
Related to rhbz#1139001
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index 38de7bb..976dfc3 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -3,6 +3,9 @@
# terminal.
tty -s || return 0
+# Skip all for noninteractive shells for the same reason as above.
+[ -z "$PS1" ] && return 0
+
# If $HOME is not set, a non human user is logging in to shell but this script
# should provide information to human users, therefore returning immediately
# without showing the notification.
--
2.1.0

View file

@ -1,158 +0,0 @@
From 2e74ca0f15d6d25568f5af1cc9cd30b4b01aa849 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 14 Oct 2014 03:15:28 +0200
Subject: [PATCH] journal-oops: use the length result of sd_journal_get_data()
journald doesn't guarantee NULL terminated strings returned from
sd_journal_get_data(). It usually works but not always.
This patch fixes the issue by using the length of field data instead of
assuming that string is NULL terminated.
Resolves: #1141549
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-dump-journal-oops.c | 13 ++++++-----
src/plugins/abrt-journal.c | 43 ++++++++++++++++++++++--------------
src/plugins/abrt-journal.h | 8 ++++---
3 files changed, 40 insertions(+), 24 deletions(-)
diff --git a/src/plugins/abrt-dump-journal-oops.c b/src/plugins/abrt-dump-journal-oops.c
index 3f1f419..0ff9fe0 100644
--- a/src/plugins/abrt-dump-journal-oops.c
+++ b/src/plugins/abrt-dump-journal-oops.c
@@ -38,8 +38,8 @@ static GList* abrt_journal_extract_kernel_oops(abrt_journal_t *journal)
do
{
- const char *line = NULL;
- if (abrt_journal_get_log_line(journal, &line) < 0)
+ char *line = abrt_journal_get_log_line(journal);
+ if (line == NULL)
error_msg_and_die(_("Cannot read journal data."));
if (lines_info_count == lines_info_size)
@@ -48,10 +48,13 @@ static GList* abrt_journal_extract_kernel_oops(abrt_journal_t *journal)
lines_info = xrealloc(lines_info, lines_info_size * sizeof(lines_info[0]));
}
- lines_info[lines_info_count].level = koops_line_skip_level(&line);
- koops_line_skip_jiffies(&line);
+ char *orig_line = line;
+ lines_info[lines_info_count].level = koops_line_skip_level((const char **)&line);
+ koops_line_skip_jiffies((const char **)&line);
- lines_info[lines_info_count].ptr = xstrdup(line);
+ memmove(orig_line, line, strlen(line) + 1);
+
+ lines_info[lines_info_count].ptr = orig_line;
++lines_info_count;
}
diff --git a/src/plugins/abrt-journal.c b/src/plugins/abrt-journal.c
index 89c8393..e0ae159 100644
--- a/src/plugins/abrt-journal.c
+++ b/src/plugins/abrt-journal.c
@@ -23,6 +23,12 @@
#include <systemd/sd-journal.h>
+/*
+ * http://www.freedesktop.org/software/systemd/man/sd_journal_get_data.html
+ * sd_journal_set_data_threshold() : This threshold defaults to 64K by default.
+ */
+#define JOURNALD_MAX_FIELD_SIZE (64*1024)
+
struct abrt_journal
{
@@ -84,33 +90,38 @@ int abrt_journal_get_field(abrt_journal_t *journal, const char *field, const voi
return 0;
}
-int abrt_journal_get_string_field(abrt_journal_t *journal, const char *field, const char **value)
+char *abrt_journal_get_string_field(abrt_journal_t *journal, const char *field, char *value)
{
- size_t value_len;
- const int r = abrt_journal_get_field(journal, field, (const void **)value, &value_len);
+ size_t data_len;
+ const char *data;
+ const int r = abrt_journal_get_field(journal, field, (const void **)&data, &data_len);
if (r < 0)
{
- return r;
+ log_notice("Cannot read journal data");
+ return NULL;
}
const size_t pfx_len = strlen(field) + 1;
- if (value_len < pfx_len)
+ if (data_len < pfx_len)
{
error_msg("Invalid data format from journal: field data are not prefixed with field name");
- return -EBADMSG;
+ return NULL;
}
- *value += pfx_len;
- return 0;
+ const size_t len = data_len - pfx_len;
+ if (value == NULL)
+ return xstrndup(data + pfx_len, len);
+ /*else*/
+
+ strncpy(value, data + pfx_len, len);
+ /* journal data are not NULL terminated strings, so terminate the string */
+ value[len] = '\0';
+ return value;
}
-int abrt_journal_get_log_line(abrt_journal_t *journal, const char **line)
+char *abrt_journal_get_log_line(abrt_journal_t *journal)
{
- const int r = abrt_journal_get_string_field(journal, "MESSAGE", line);
- if (r < 0)
- log_notice("Cannot read journal data. Exiting");
-
- return r;
+ return abrt_journal_get_string_field(journal, "MESSAGE", NULL);
}
int abrt_journal_get_cursor(abrt_journal_t *journal, char **cursor)
@@ -272,9 +283,9 @@ void abrt_journal_watch_notify_strings(abrt_journal_watch_t *watch, void *data)
{
struct abrt_journal_watch_notify_strings *conf = (struct abrt_journal_watch_notify_strings *)data;
- const char *message = NULL;
+ char message[JOURNALD_MAX_FIELD_SIZE + 1];
- if (abrt_journal_get_string_field(abrt_journal_watch_get_journal(watch), "MESSAGE", &message) < 0)
+ if (abrt_journal_get_string_field(abrt_journal_watch_get_journal(watch), "MESSAGE", (char *)message) == NULL)
error_msg_and_die("Cannot read journal data.");
GList *cur = conf->strings;
diff --git a/src/plugins/abrt-journal.h b/src/plugins/abrt-journal.h
index 219cf60..d509d96 100644
--- a/src/plugins/abrt-journal.h
+++ b/src/plugins/abrt-journal.h
@@ -40,11 +40,13 @@ int abrt_journal_get_field(abrt_journal_t *journal,
const void **value,
size_t *value_len);
-int abrt_journal_get_string_field(abrt_journal_t *journal,
+/* Returns allocated memory if value is NULL; otherwise makes copy of journald
+ * field to memory pointed by value arg. */
+char *abrt_journal_get_string_field(abrt_journal_t *journal,
const char *field,
- const char **value);
+ char *value);
-int abrt_journal_get_log_line(abrt_journal_t *journal, const char **line);
+char *abrt_journal_get_log_line(abrt_journal_t *journal);
int abrt_journal_get_cursor(abrt_journal_t *journal, char **cursor);
--
2.1.0

View file

@ -1,102 +0,0 @@
From 105aab5e018efa7d68e06ff648d0dc9e434e20d2 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 15 Oct 2014 13:33:51 +0200
Subject: [PATCH] make ABRT quieter
Related: #1048384, #1147664
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrtd.c | 7 +++++--
src/hooks/abrt-hook-ccpp.c | 10 +++++-----
src/plugins/abrt-action-generate-core-backtrace.c | 2 +-
3 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/src/daemon/abrtd.c b/src/daemon/abrtd.c
index b8426dd..cce49eb 100644
--- a/src/daemon/abrtd.c
+++ b/src/daemon/abrtd.c
@@ -626,7 +626,7 @@ int main(int argc, char** argv)
s_signal_pipe_write = s_signal_pipe[1];
/* Enter the event loop */
- log("Init complete, entering main loop");
+ log_debug("Init complete, entering main loop");
run_main_loop(pMainloop);
cleanup:
@@ -652,7 +652,10 @@ int main(int argc, char** argv)
/* Exiting */
if (s_sig_caught && s_sig_caught != SIGALRM && s_sig_caught != SIGCHLD)
{
- error_msg("Got signal %d, exiting", s_sig_caught);
+ /* We use TERM to stop abrtd, so not printing out error message. */
+ if (s_sig_caught != SIGTERM)
+ error_msg("Got signal %d, exiting", s_sig_caught);
+
signal(s_sig_caught, SIG_DFL);
raise(s_sig_caught);
}
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
index 8e141d4..6f471e9 100644
--- a/src/hooks/abrt-hook-ccpp.c
+++ b/src/hooks/abrt-hook-ccpp.c
@@ -184,13 +184,13 @@ static char* get_executable(pid_t pid, int *fd_p)
if (deleted > executable && strcmp(deleted, " (deleted)") == 0)
{
*deleted = '\0';
- log("File '%s' seems to be deleted", executable);
+ log_info("File '%s' seems to be deleted", executable);
}
/* find and cut off prelink suffixes from the path */
char *prelink = executable + strlen(executable) - strlen(".#prelink#.XXXXXX");
if (prelink > executable && strncmp(prelink, ".#prelink#.", strlen(".#prelink#.")) == 0)
{
- log("File '%s' seems to be a prelink temporary file", executable);
+ log_info("File '%s' seems to be a prelink temporary file", executable);
*prelink = '\0';
}
return executable;
@@ -649,7 +649,7 @@ int main(int argc, char** argv)
* but it does not log file name */
error_msg_and_die("Error saving '%s'", path);
}
- log("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
+ log_notice("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
return 0;
}
@@ -836,7 +836,7 @@ int main(int argc, char** argv)
strcpy(path, newpath);
free(newpath);
- log("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
+ log_notice("Saved core dump of pid %lu (%s) to %s (%llu bytes)", (long)pid, executable, path, (long long)core_size);
notify_new_path(path);
@@ -874,7 +874,7 @@ int main(int argc, char** argv)
unlink(core_basename);
return 1;
}
- log("Saved core dump of pid %lu to %s (%llu bytes)", (long)pid, full_core_basename, (long long)core_size);
+ log_notice("Saved core dump of pid %lu to %s (%llu bytes)", (long)pid, full_core_basename, (long long)core_size);
}
return 0;
diff --git a/src/plugins/abrt-action-generate-core-backtrace.c b/src/plugins/abrt-action-generate-core-backtrace.c
index a992a5b..791af83 100644
--- a/src/plugins/abrt-action-generate-core-backtrace.c
+++ b/src/plugins/abrt-action-generate-core-backtrace.c
@@ -61,7 +61,7 @@ int main(int argc, char **argv)
sr_debug_parser = true;
/* Let user know what's going on */
- log(_("Generating core_backtrace"));
+ log_notice(_("Generating core_backtrace"));
char *error_message = NULL;
bool success;
--
2.1.0

View file

@ -1,128 +0,0 @@
From 0a0f129a6622fd7099de8cec6a1d95a4189a91d1 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 21 Oct 2014 14:57:10 +0200
Subject: [PATCH] applet: ensure writable dump directory before reporting
Related to rhbz#1084027
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/applet/applet.c | 62 ++++++++++++++++++++++++++++++++++-------------------
1 file changed, 40 insertions(+), 22 deletions(-)
diff --git a/src/applet/applet.c b/src/applet/applet.c
index 90c5b0d..644da60 100644
--- a/src/applet/applet.c
+++ b/src/applet/applet.c
@@ -307,6 +307,7 @@ typedef struct problem_info {
bool incomplete;
bool reported;
bool was_announced;
+ bool is_writable;
} problem_info_t;
static void push_to_deferred_queue(problem_info_t *pi)
@@ -324,6 +325,36 @@ static void problem_info_set_dir(problem_info_t *pi, const char *dir)
problem_data_add_text_noteditable(pi->problem_data, CD_DUMPDIR, dir);
}
+static bool problem_info_ensure_writable(problem_info_t *pi)
+{
+ if (pi->is_writable)
+ return true;
+
+ /* chown the directory in any case, because kernel oopses are not foreign */
+ /* but their dump directories are not writable without chowning them or */
+ /* stealing them. The stealing is deprecated as it breaks the local */
+ /* duplicate search and root cannot see them */
+ const int res = chown_dir_over_dbus(problem_info_get_dir(pi));
+ if (pi->foreign && res != 0)
+ {
+ error_msg(_("Can't take ownership of '%s'"), problem_info_get_dir(pi));
+ return false;
+ }
+ pi->foreign = false;
+
+ struct dump_dir *dd = open_directory_for_writing(problem_info_get_dir(pi), /* don't ask */ NULL);
+ if (!dd)
+ {
+ error_msg(_("Can't open directory for writing '%s'"), problem_info_get_dir(pi));
+ return false;
+ }
+
+ problem_info_set_dir(pi, dd->dd_dirname);
+ pi->is_writable = true;
+ dd_close(dd);
+ return true;
+}
+
static problem_info_t *problem_info_new(const char *dir)
{
problem_info_t *pi = xzalloc(sizeof(*pi));
@@ -610,8 +641,13 @@ static pid_t spawn_event_handler_child(const char *dump_dir_name, const char *ev
return child;
}
-static void run_report_from_applet(const char *dirname)
+static void run_report_from_applet(problem_info_t *pi)
{
+ if (!problem_info_ensure_writable(pi))
+ return;
+
+ const char *dirname = problem_info_get_dir(pi);
+
fflush(NULL); /* paranoia */
pid_t pid = fork();
if (pid < 0)
@@ -649,7 +685,7 @@ static void action_report(NotifyNotification *notification, gchar *action, gpoin
{
if (strcmp(A_REPORT_REPORT, action) == 0)
{
- run_report_from_applet(problem_info_get_dir(pi));
+ run_report_from_applet(pi);
problem_info_free(pi);
}
else
@@ -1118,7 +1154,7 @@ static gboolean handle_event_output_cb(GIOChannel *gio, GIOCondition condition,
if (pi->known || !(state->flags & REPORT_UNKNOWN_PROBLEM_IMMEDIATELY))
notify_problem(pi);
else
- run_report_from_applet(problem_info_get_dir(pi));
+ run_report_from_applet(pi);
}
else
{
@@ -1179,29 +1215,11 @@ static void export_event_configuration(const char *event_name)
static void run_event_async(problem_info_t *pi, const char *event_name, int flags)
{
- /* chown the directory in any case, because kernel oopses are not foreign */
- /* but their dump directories are not writable without chowning them or */
- /* stealing them. The stealing is deprecated as it breaks the local */
- /* duplicate search and root cannot see them */
- const int res = chown_dir_over_dbus(problem_info_get_dir(pi));
- if (pi->foreign && res != 0)
+ if (!problem_info_ensure_writable(pi))
{
- error_msg(_("Can't take ownership of '%s'"), problem_info_get_dir(pi));
problem_info_free(pi);
return;
}
- pi->foreign = false;
-
- struct dump_dir *dd = open_directory_for_writing(problem_info_get_dir(pi), /* don't ask */ NULL);
- if (!dd)
- {
- error_msg(_("Can't open directory for writing '%s'"), problem_info_get_dir(pi));
- problem_info_free(pi);
- return;
- }
-
- problem_info_set_dir(pi, dd->dd_dirname);
- dd_close(dd);
export_event_configuration(event_name);
--
2.1.0

View file

@ -1,42 +0,0 @@
From 2fa193aba3cb1dd630faa65385a92e11d92806d1 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 26 Aug 2014 20:37:34 +0200
Subject: [PATCH] a-a-s-p-d: add firefox on the package blacklist
And drop the path to plugins-container from the path blacklist because:
- the path belongs to firefox package
- the path is invalid, the correct path is:
/usr/lib(64)/firefox/plugin-container
Resolves rhbz#1132018
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt-action-save-package-data.conf | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/daemon/abrt-action-save-package-data.conf b/src/daemon/abrt-action-save-package-data.conf
index 3d35bb6..cac3c7c 100644
--- a/src/daemon/abrt-action-save-package-data.conf
+++ b/src/daemon/abrt-action-save-package-data.conf
@@ -7,7 +7,7 @@ OpenGPGCheck = yes
# Blacklisted packages
#
-BlackList = nspluginwrapper, valgrind, strace, mono-core
+BlackList = nspluginwrapper, valgrind, strace, mono-core, firefox
# Process crashes in executables which do not belong to any package?
#
@@ -15,7 +15,7 @@ ProcessUnpackaged = no
# Blacklisted executable paths (shell patterns)
#
-BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer, /usr/lib/xulrunner-*/plugin-container
+BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer
# interpreters names
Interpreters = python2, python2.7, python, python3, python3.3, perl, perl5.16.2
--
2.1.0

View file

@ -1,212 +0,0 @@
From aa503cf6722fffa2dbf3d400a4e2bbeac2f78d65 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 23 Oct 2014 16:37:14 +0200
Subject: [PATCH] a-a-g-machine-id: add systemd's machine id
The dmidecode based algorithm may not work on all architectures.
man machine-id
Related to rhbz#1140044
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-action-generate-machine-id | 165 ++++++++++++++++++++++++++--
1 file changed, 153 insertions(+), 12 deletions(-)
diff --git a/src/plugins/abrt-action-generate-machine-id b/src/plugins/abrt-action-generate-machine-id
index 0aea787..b2de822 100644
--- a/src/plugins/abrt-action-generate-machine-id
+++ b/src/plugins/abrt-action-generate-machine-id
@@ -1,14 +1,47 @@
#!/usr/bin/python
+
+## Copyright (C) 2014 ABRT team <abrt-devel-list@redhat.com>
+## Copyright (C) 2014 Red Hat, Inc.
+
+## This program is free software; you can redistribute it and/or modify
+## it under the terms of the GNU General Public License as published by
+## the Free Software Foundation; either version 2 of the License, or
+## (at your option) any later version.
+
+## This program is distributed in the hope that it will be useful,
+## but WITHOUT ANY WARRANTY; without even the implied warranty of
+## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+## GNU General Public License for more details.
+
+## You should have received a copy of the GNU General Public License
+## along with this program; if not, write to the Free Software
+## Foundation, Inc., 51 Franklin Street, Suite 500, Boston, MA 02110-1335 USA
+
+"""This module provides algorithms for generating Machine IDs.
+"""
+
+import sys
from argparse import ArgumentParser
+import logging
-import dmidecode
import hashlib
+def generate_machine_id_dmidecode():
+ """Generate a machine_id based off dmidecode fields
-# Generate a machine_id based off dmidecode fields
-def generate_machine_id():
- dmixml = dmidecode.dmidecodeXML()
+ The function generates the same result as sosreport-uploader
+
+ Returns a machine ID as string or throws RuntimeException
+
+ """
+ try:
+ import dmidecode
+ except ImportError as ex:
+ raise RuntimeError("Could not import dmidecode module: {0}"
+ .format(str(ex)))
+
+ dmixml = dmidecode.dmidecodeXML()
# Fetch all DMI data into a libxml2.xmlDoc object
dmixml.SetResultType(dmidecode.DMIXML_DOC)
xmldoc = dmixml.QuerySection('all')
@@ -38,20 +71,128 @@ def generate_machine_id():
return machine_id.hexdigest()
-if __name__ == "__main__":
- CMDARGS = ArgumentParser(description = "Generate a machine_id based off dmidecode fields")
- CMDARGS.add_argument('-o', '--output', type=str, help='Output file')
+def generate_machine_id_systemd():
+ """Generate a machine_id equals to a one generated by systemd
+
+ This function returns contents of /etc/machine-id
+
+ Returns a machine ID as string or throws RuntimeException.
+
+ """
+
+ try:
+ with open('/etc/machine-id', 'r') as midf:
+ return "".join((l.strip() for l in midf))
+ except IOError as ex:
+ raise RuntimeError("Could not use systemd's machine-id: {0}"
+ .format(str(ex)))
+
+
+GENERATORS = { 'sosreport_uploader-dmidecode' : generate_machine_id_dmidecode,
+ 'systemd' : generate_machine_id_systemd }
+
+
+def generate_machine_id(generators):
+ """Generates all requested machine id with all required generators
+
+ Keyword arguments:
+ generators -- a list of generator names
+
+ Returns a dictionary where keys are generators and associated values are
+ products of those generators.
+
+ """
+
+ ids = {}
+ workers = GENERATORS
+ for sd in generators:
+ try:
+ ids[sd] = workers[sd]()
+ except RuntimeError as ex:
+ logging.error("Machine-ID generator '{0}' failed: {1}"
+ .format(sd, ex.message))
+
+ return ids
+
+
+def print_result(ids, outfile, prefixed):
+ """Writes a dictionary of machine ids to a file
+
+ Each dictionary entry is written on a single line and the last line does
+ not have new line character. The new line character is omitted as it is a
+ common approach in ABRT.
+
+ Keyword arguments:
+ ids -- a dictionary [generator name: machine ids]
+ outfile -- output file
+ prefixed -- use 'generator name=' prefix or not
+ """
+
+ fmt = '{0}={1}' if prefixed else '{1}'
+
+ items_iter = ids.iteritems()
+ try:
+ sd, mid = items_iter.next()
+ outfile.write(fmt.format(sd, mid))
+ except StopIteration:
+ return
+
+ fmt = '\n' + fmt
+ for sd, mid in items_iter:
+ outfile.write(fmt.format(sd,mid))
+
+
+def print_generators(outfile=None):
+ """Prints requested generators
+
+ Keyword arguments:
+ outfile -- output file (default: sys.stdout)
+
+ """
+ if outfile is None:
+ outfile = sys.stdout
+
+ for sd in GENERATORS.iterkeys():
+ outfile.write("{0}\n".format(sd))
+
+
+if __name__ == '__main__':
+ CMDARGS = ArgumentParser(description = "Generate a machine_id")
+ CMDARGS.add_argument('-o', '--output', type=str,
+ help="Output file")
+ CMDARGS.add_argument('-g', '--generators', nargs='+', type=str,
+ help="Use given generators only")
+ CMDARGS.add_argument('-l', '--list-generators', action='store_true',
+ default=False, help="Print out a list of usable generators")
+ CMDARGS.add_argument('-n', '--noprefix', action='store_true',
+ default=False, help="Do not use generator name as prefix for IDs")
OPTIONS = CMDARGS.parse_args()
ARGS = vars(OPTIONS)
- machineid = generate_machine_id()
+ logging.basicConfig(format='%(message)s')
+
+ if ARGS['list_generators']:
+ print_generators()
+ sys.exit(0)
+
+ requested_generators = None
+ if ARGS['generators']:
+ requested_generators = ARGS['generators']
+ else:
+ requested_generators = GENERATORS.keys()
+
+ machineids = generate_machine_id(requested_generators)
if ARGS['output']:
try:
- with open(ARGS['output'], 'w') as outfile:
- outfile.write(machineid)
+ with open(ARGS['output'], 'w') as fout:
+ print_result(machineids, fout, not ARGS['noprefix'])
except IOError as ex:
- print ex
+ logging.error("Could not open output file: {0}".format(str(ex)))
+ sys.exit(1)
else:
- print machineid
+ print_result(machineids, sys.stdout, not ARGS['noprefix'])
+ sys.stdout.write('\n')
+
+ sys.exit(len(requested_generators) - len(machineids.keys()))
--
2.1.0

View file

@ -1,34 +0,0 @@
From 35e52c1820a84da2623a7cf4c71baf9fa6f2e12e Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 24 Oct 2014 15:50:02 +0200
Subject: [PATCH] a-a-g-machine-id: suppress its failures in abrt_event.conf
If an event script exits with a non-zero code, abrtd deletes entire dump
directory.
Failures of a-a-g-machine-id must not lead to the deletion of a dump
directory.
Related to rhbz#1140044
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt_event.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/daemon/abrt_event.conf b/src/daemon/abrt_event.conf
index 4597627..3322a81 100644
--- a/src/daemon/abrt_event.conf
+++ b/src/daemon/abrt_event.conf
@@ -92,7 +92,7 @@ EVENT=post-create runlevel=
# Example: if you want to include *machineid* in dump directories:
#EVENT=post-create
- /usr/libexec/abrt-action-generate-machine-id -o $DUMP_DIR/machineid
+ /usr/libexec/abrt-action-generate-machine-id -o $DUMP_DIR/machineid || :
# Example:
# if you want to upload data immediately at the moment of a crash to
--
2.1.0

View file

@ -1,59 +0,0 @@
From 301fe7c65ba4431833ad8a9df7a4366eda889682 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 31 Oct 2014 23:00:10 +0100
Subject: [PATCH] a-a-g-machine-id: omit trailing new-line for one-liners only
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-action-generate-machine-id | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/src/plugins/abrt-action-generate-machine-id b/src/plugins/abrt-action-generate-machine-id
index b2de822..6f43258 100644
--- a/src/plugins/abrt-action-generate-machine-id
+++ b/src/plugins/abrt-action-generate-machine-id
@@ -118,9 +118,9 @@ def generate_machine_id(generators):
def print_result(ids, outfile, prefixed):
"""Writes a dictionary of machine ids to a file
- Each dictionary entry is written on a single line and the last line does
- not have new line character. The new line character is omitted as it is a
- common approach in ABRT.
+ Each dictionary entry is written on a single line. The function does not
+ print trailing new-line if the dictionary contains only one item as it is
+ common format of one-liners placed in a dump directory.
Keyword arguments:
ids -- a dictionary [generator name: machine ids]
@@ -130,15 +130,10 @@ def print_result(ids, outfile, prefixed):
fmt = '{0}={1}' if prefixed else '{1}'
- items_iter = ids.iteritems()
- try:
- sd, mid = items_iter.next()
- outfile.write(fmt.format(sd, mid))
- except StopIteration:
- return
+ if len(ids) > 1:
+ fmt += '\n'
- fmt = '\n' + fmt
- for sd, mid in items_iter:
+ for sd, mid in ids.iteritems():
outfile.write(fmt.format(sd,mid))
@@ -193,6 +188,8 @@ if __name__ == '__main__':
sys.exit(1)
else:
print_result(machineids, sys.stdout, not ARGS['noprefix'])
- sys.stdout.write('\n')
+ # print_results() omits new-line for one-liners
+ if len(machineids) == 1:
+ sys.stdout.write('\n')
sys.exit(len(requested_generators) - len(machineids.keys()))
--
2.1.0

View file

@ -1,31 +0,0 @@
From 77fd4057c1364edc7a1815b73bb980229c8b9d65 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 31 Oct 2014 23:01:07 +0100
Subject: [PATCH] a-a-g-machine-id: do not print any error from the event
handler
It is expected that dmidecode-less systems will print an error message
related to the fact that dmidecode doesn't work, hence forwarding of
STDOUT and STDERR to 'event_log' file.
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt_event.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/daemon/abrt_event.conf b/src/daemon/abrt_event.conf
index 3322a81..feb02a3 100644
--- a/src/daemon/abrt_event.conf
+++ b/src/daemon/abrt_event.conf
@@ -92,7 +92,7 @@ EVENT=post-create runlevel=
# Example: if you want to include *machineid* in dump directories:
#EVENT=post-create
- /usr/libexec/abrt-action-generate-machine-id -o $DUMP_DIR/machineid || :
+ /usr/libexec/abrt-action-generate-machine-id -o $DUMP_DIR/machineid >>event_log 2>&1 || :
# Example:
# if you want to upload data immediately at the moment of a crash to
--
2.1.0

View file

@ -1,34 +0,0 @@
From f5e65811d450c9117fa036bd82d161e5f936d5a0 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 31 Oct 2014 23:02:57 +0100
Subject: [PATCH] sos: use all valuable plugins
This commit mirrors the state of rhel7
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/daemon/abrt_event.conf | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/daemon/abrt_event.conf b/src/daemon/abrt_event.conf
index feb02a3..1153cc0 100644
--- a/src/daemon/abrt_event.conf
+++ b/src/daemon/abrt_event.conf
@@ -69,11 +69,13 @@ EVENT=post-create runlevel=
# if you would rather perform this collection later):
#EVENT=post-create
nice sosreport --tmp-dir "$DUMP_DIR" --batch \
- --only=anaconda --only=bootloader --only=devicemapper \
+ --only=anaconda --only=boot --only=devicemapper \
--only=filesys --only=hardware --only=kernel --only=libraries \
--only=memory --only=networking --only=nfsserver --only=pam \
--only=process --only=rpm -k rpm.rpmva=off --only=ssh \
--only=startup --only=yum --only=general --only=x11 \
+ --only=cups --only=logs --only=grub2 --only=cron --only=pci \
+ --only=auditd --only=selinux --only=lvm2 --only=sar \
>sosreport.log 2>&1 \
&& {
rm sosreport.log
--
2.1.0

View file

@ -1,58 +0,0 @@
From 1fc0e782d56af4df3f21560929176a09103923ad Mon Sep 17 00:00:00 2001
From: Martin Milata <mmilata@redhat.com>
Date: Tue, 4 Nov 2014 16:51:24 +0100
Subject: [PATCH] koops: improve 'reason' text for page faults
Current : 'general protection fault: 4000 [#1] SMP'
Improved: 'general protection fault in i915_gem_do_execbuffer'
Resolves rhbz#998887.
Signed-off-by: Martin Milata <mmilata@redhat.com>
---
src/plugins/oops-utils.c | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/src/plugins/oops-utils.c b/src/plugins/oops-utils.c
index 9e2355e..ea6c639 100644
--- a/src/plugins/oops-utils.c
+++ b/src/plugins/oops-utils.c
@@ -12,6 +12,8 @@
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
+#include <satyr/stacktrace.h>
+
#include "oops-utils.h"
#include "libabrt.h"
@@ -242,8 +244,24 @@ void abrt_oops_save_data_in_dump_dir(struct dump_dir *dd, char *oops, const char
// TODO: add "Kernel oops: " prefix, so that all oopses have recognizable FILENAME_REASON?
// kernel oops 1st line may look quite puzzling otherwise...
- strchrnul(second_line, '\n')[0] = '\0';
- dd_save_text(dd, FILENAME_REASON, second_line);
+ char *reason_pretty = NULL;
+ char *error = NULL;
+ struct sr_stacktrace *trace = sr_stacktrace_parse(SR_REPORT_KERNELOOPS, second_line, &error);
+ if (trace)
+ {
+ reason_pretty = sr_stacktrace_get_reason(trace);
+ sr_stacktrace_free(trace);
+ }
+ else
+ free(error);
+
+ if (reason_pretty)
+ {
+ dd_save_text(dd, FILENAME_REASON, reason_pretty);
+ free(reason_pretty);
+ }
+ else
+ dd_save_text(dd, FILENAME_REASON, second_line);
}
int abrt_oops_signaled_sleep(int seconds)
--
2.1.0

3541
abrt.spec

File diff suppressed because it is too large Load diff

View file

@ -1,26 +0,0 @@
From 1ef034096efe367af85f568bc982af969124003b Mon Sep 17 00:00:00 2001
From: rpm-build <rpm-build>
Date: Mon, 10 Feb 2014 09:39:07 +0100
Subject: [PATCH] disable OpenGPGCheck in Fedora Rawhide
Packages in Fedora Rawhide are not signed.
---
src/daemon/abrt-action-save-package-data.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/daemon/abrt-action-save-package-data.conf b/src/daemon/abrt-action-save-package-data.conf
index 3d35bb6..e3f724a 100644
--- a/src/daemon/abrt-action-save-package-data.conf
+++ b/src/daemon/abrt-action-save-package-data.conf
@@ -3,7 +3,7 @@
# the list of public keys used to check the signature is
# in the file gpg_keys
#
-OpenGPGCheck = yes
+OpenGPGCheck = no
# Blacklisted packages
#
--
1.8.3.1

15
gating.yaml Normal file
View file

@ -0,0 +1,15 @@
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_testing
subject_type: koji_build
rules:
- !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_stable
subject_type: koji_build
rules:
- !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}

View file

@ -1 +1 @@
faa666301f4512723486300212cd7e58 abrt-2.3.0.tar.gz
SHA512 (abrt-2.17.8.tar.gz) = 90b74229412e0186bfa109ee940a60c9f3c0f7ce8c1216acad6f05619a1bb591e7f0bae87363143a05034312c9f14fe5ace341b84f680780ceb93a1e624705b3

10
tests/smoke.fmf Normal file
View file

@ -0,0 +1,10 @@
summary: Basic smoke test for abrt
prepare:
how: install
# Do not attempt to install conflicting subpackages.
exclude:
- abrt-atomic
- abrt-java-connector-container
- python3-abrt-container-addon
execute:
script: abrt-action-notify --help