Compare commits

..

186 commits

Author SHA1 Message Date
Fedora Release Engineering
0baf939494 Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild 2026-01-16 03:23:57 +00:00
Michal Srb
fb86abde3b a-a-save-container-data: validate input
Resolves: CVE-2025-12744

Signed-off-by: Michal Srb <michal@redhat.com>
2025-12-04 20:32:21 +01:00
Michal Srb
b36cf8c499 Update to 2.17.7
Signed-off-by: Michal Srb <michal@redhat.com>
2025-10-02 10:36:26 +02:00
Python Maint
ba57e0bbb5 Rebuilt for Python 3.14.0rc3 bytecode 2025-09-19 12:06:17 +02:00
Python Maint
54bdc1243f Rebuilt for Python 3.14.0rc2 bytecode 2025-08-15 12:37:49 +02:00
Adam Williamson
026c727cd2 Bump release 2025-08-01 10:49:36 -07:00
Adam Williamson
3e192a597d Obsolete fros packages
fros was recently retired:
https://src.fedoraproject.org/rpms/fros/c/1d5c887
it was added to comps to support abrt-desktop:
https://pagure.io/fedora-comps/c/e845f70
so it seems most appropriate to have abrt obsolete it, if we
don't just use obsolete-packages.

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2025-07-25 14:27:51 -07:00
Fedora Release Engineering
ea69665c75 Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild 2025-07-23 16:42:37 +00:00
Python Maint
b8a18969b7 Rebuilt for Python 3.14 2025-06-03 15:33:02 +02:00
Zbigniew Jędrzejewski-Szmek
3063be65d9 Add sysusers.d config file to allow rpm to create users/groups automatically 2025-01-23 17:02:44 +01:00
Fedora Release Engineering
c76a737f5a Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild 2025-01-16 10:29:17 +00:00
David Abdurachmanov
67fc5aa756 Disable Requires on kexec-tools for riscv64
kexec is supported for riscv64 on the kernel side, but the tooling side
is not yet upstreamed. Status is unknown.

See recent failed kexec-tools builds on riscv64 here:
http://fedora.riscv.rocks/koji/packageinfo?packageID=17577

Signed-off-by: David Abdurachmanov <davidlt@rivosinc.com>
Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
2024-12-02 09:59:50 +00:00
Neal Gompa
1bb8628644 Drop container handler (rhbz#2295150) 2024-09-11 12:56:30 +02:00
Michal Srb
d48adf4500 Update to upstream release 2.17.6
Signed-off-by: Michal Srb <michal@redhat.com>
2024-09-01 15:24:09 +02:00
Fedora Release Engineering
e5b49f4be8 Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild 2024-07-17 16:31:08 +00:00
Zbigniew Jędrzejewski-Szmek
66812b6c92 Drop call to marshalparser
This is now done automatically by add-determinism:
https://fedoraproject.org/wiki/Changes/ReproduciblePackageBuilds
2024-06-18 13:04:35 +02:00
Python Maint
af451300aa Rebuilt for Python 3.13 2024-06-09 02:46:55 +02:00
Michal Srb
202231f9cb Update to 2.17.5
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-19 19:59:39 +01:00
Michal Srb
e8f18508da Update to upstream release 2.17.4
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-12 22:59:07 +01:00
Michal Srb
58c69f3384 Update spec file
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-05 22:35:28 +01:00
Michal Srb
7fea67f0ed Update to upstream release 2.17.2
Signed-off-by: Michal Srb <michal@redhat.com>
2024-02-04 23:45:24 +01:00
Fedora Release Engineering
7eebe59cc3 Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild 2024-01-22 22:34:46 +00:00
Fedora Release Engineering
f1adb64577 Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild 2024-01-19 12:03:02 +00:00
Fedora Release Engineering
32054b4681 Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-07-19 12:49:45 +00:00
Python Maint
bbc9c5edc4 Rebuilt for Python 3.12 2023-07-01 11:44:59 +02:00
Michal Srb
e76a84e22d Update to upstream release 2.17.1
Signed-off-by: Michal Srb <michal@redhat.com>
2023-06-30 13:29:27 +02:00
Python Maint
7073ad4346 Rebuilt for Python 3.12 2023-06-28 19:02:20 +02:00
Matěj Grabovský
1f0eac990d Update to upstream release 2.17.0
Signed-off-by: Matěj Grabovský <mgrabovs@redhat.com>
2023-05-22 11:38:48 +02:00
Michal Srb
e65ab2c3e6 Update to upstream release 2.16.1
Signed-off-by: Michal Srb <michal@redhat.com>
2023-03-30 11:37:17 +02:00
Matěj Grabovský
8c7bdb1523 Use SPDX format for license field
See [the wiki][1] for details.

[1]: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1
2023-02-02 15:54:58 +01:00
Fedora Release Engineering
e73a64df97 Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2023-01-18 21:19:42 +00:00
Michal Srb
50a321fe1d Update to upstream release 2.16.0
Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-24 18:27:21 +02:00
Michal Srb
a20ba81e1d abrt-journal: First seek the journal tail and then set filters
Resolves: rhbz#2128662

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-19 15:41:54 +02:00
Michal Srb
c8a122775e applet: Update GLib constant name
This fixes FTBFS in F37+

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:59:26 +02:00
Michal Srb
4f63977e6d Adjust gating.yaml for non-Rawhide release
Fedora CI still doesn't run the generic tests
for non-Rawhide releases :/

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:44:21 +02:00
Michal Srb
534292e248 abrt-journal: call sd_journal_get_fd() right after sd_journal_open()
Resolves: rhbz#2128662

Signed-off-by: Michal Srb <michal@redhat.com>
2022-10-12 09:43:01 +02:00
Fedora Release Engineering
d3f14892f8 Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2022-07-20 20:22:13 +00:00
Michal Srb
1e992dd7d9 Fix FTBFS
Resolves: rhbz#2093924

Signed-off-by: Michal Srb <michal@redhat.com>
2022-06-16 13:24:42 +02:00
Python Maint
f144023834 Rebuilt for Python 3.11 2022-06-15 18:15:40 +02:00
Michal Srb
3f24d62289 Update to 2.15.1
Signed-off-by: Michal Srb <michal@redhat.com>
2022-03-10 21:48:33 +01:00
Fedora Release Engineering
f9fd407b73 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2022-01-19 20:51:29 +00:00
Matěj Grabovský
fcc2f68d2d Rebuild for testing 2022-01-19 14:54:57 +01:00
Matěj Grabovský
15bea33e03 tests: Add one more conflicting package 2022-01-19 12:27:20 +01:00
Matěj Grabovský
0302f37126 New upstream release 2.15.0 2022-01-17 19:27:36 +01:00
Miro Hrončok
88895e18b5 Fix issues with conflicting multilib packages 2022-01-12 16:24:16 +01:00
Matěj Grabovský
1c9f6e51cf Bump release for rebuild 2022-01-06 15:10:12 +01:00
Matěj Grabovský
810fcb1911 Do not install conflicting packages in test 2022-01-06 14:56:23 +01:00
Matěj Grabovský
1b8bae307a Rebuild for satyr 0.39 2021-12-22 11:22:22 +01:00
Matěj Grabovský
7c6ec28dde Backport Python lazy loading patch (rhbz#2007664) 2021-09-27 12:34:36 +02:00
Fedora Release Engineering
d99ab08e76 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-07-21 17:11:34 +00:00
Fedora Release Engineering
e3d620d8fc - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-07-21 12:16:28 +00:00
Björn Esser
1d49502fa7
Rebuild for versioned symbols in json-c 2021-07-10 11:51:13 +02:00
Python Maint
4f59333992 Rebuilt for Python 3.10 2021-06-07 17:17:41 +02:00
Michal Fabik
61c2c079e0 Bump release to rebuild in new side tag
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-06-04 15:02:12 +02:00
Python Maint
f99a7f835a Rebuilt for Python 3.10 2021-06-04 11:19:26 +02:00
Michal Fabik
a4e0effc61 Rebuild against libreport-2.15.2
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-06-02 20:59:37 +02:00
Michal Fabik
094983af73 New upstream release 2.14.6
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2021-05-25 12:52:10 +02:00
Michal Fabik
81ec67df39 Merge #8 Add simple smoke test 2021-05-05 09:42:57 +00:00
Sérgio M. Basto
26627dbec3 Add dependency on python3-systemd
commit 566e2eaacb21e07a8301c3e16408924c46045ad9
Author: Matěj Grabovský <mgrabovs@redhat.com>
Date:   Wed Jan 13 12:16:57 2021 +0100

    spec: Add dependency on python3-systemd

    abrt-action-check-oops-for-hw-error from the abrt-addon-vmcore package
    imports systemd.journal but the python3-systemd package is not declared
    as a dependency, which causes the script to crash if python3-systemd is
    not installed on the system.

    This commit fixes this by adding the formal dependency in the spec file.

    Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1914170
2021-05-01 20:29:26 +01:00
Sérgio M. Basto
126031c321 Obsoletes abrt-plugin-sosreport, to fix upgrade path 2021-04-30 22:41:16 +01:00
Michal Fabik
a1c9e8ff22 Add simple smoke test 2021-03-09 12:23:00 +01:00
Zbigniew Jędrzejewski-Szmek
074ab8b76c Rebuilt for updated systemd-rpm-macros
See https://pagure.io/fesco/issue/2583.
2021-03-02 16:14:14 +01:00
Michal Židek
7e13959917 gating: Add gating.yaml 2021-02-17 13:58:09 +01:00
Fedora Release Engineering
dacf4e649a - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2021-01-25 23:44:28 +00:00
Michal Fabik
003b0187a1 New upstream release 2.14.5
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-12-01 15:21:38 +01:00
Miro Hrončok
82eb0a22c3 Use autoreconf in %build instead of plain autoconf
This way, when stuff is fixed in automake, the source tarball does not need
to be re-generated in upstream to use the fix.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1897489
2020-11-13 11:17:17 +01:00
Matěj Grabovský
511e6ce6d4 Add upstream patch for an invalid read bug 2020-10-13 11:11:22 +02:00
Matěj Grabovský
1ab9d3859f Add patch for #1881745 2020-09-24 10:07:28 +02:00
Michal Fabik
00422605f4 spec: Add Provides to Obsoletes
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-24 09:38:50 +02:00
Michal Fabik
3de7b9d0b7 New upstream release 2.14.4
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-21 11:47:18 +02:00
Michal Fabik
5e37f50192 New upstream release 2.14.3
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-08-21 11:47:15 +02:00
Adam Williamson
92ab2eb5b3 Rebuild for libreport soname bump 2020-08-13 16:42:48 -07:00
Ernestas Kulik
935456c7d9 Add patch for #1860903 2020-07-28 16:28:09 +02:00
Fedora Release Engineering
d8a4ccc6c2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-07-27 11:40:43 +00:00
Miro Hrončok
a2bcded0dc Rebuilt for Python 3.9 2020-05-24 09:41:56 +02:00
Ernestas Kulik
18305b2c50 Add fix for #1836190 2020-05-21 16:21:26 +02:00
Michal Fabik
438b4b73c7 New upstream release 2.14.2
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-05-12 10:11:37 +02:00
Ernestas Kulik
9f7a213711 Bump libreport dependency 2020-04-25 11:12:34 +02:00
Michal Fabik
bf7b8afe4a New upstream release 2.14.1
Signed-off-by: Michal Fabik <mfabik@redhat.com>
2020-04-24 18:15:58 +02:00
Björn Esser
61c6c411a8 Rebuild (json-c) 2020-04-22 00:01:43 +02:00
Ernestas Kulik
e161563d64 Bump libreport dependency 2020-02-07 10:52:02 +01:00
Ernestas Kulik
400b28eb78 Sync spec changes from upstream 2020-02-07 09:32:24 +01:00
Ernestas Kulik
c84c5d2738 Update to 2.14.0 2020-02-07 08:45:18 +01:00
Igor Raits
5f74b5e407
Backport few more patches to fix compatibility with new libreport
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 08:00:55 +01:00
Igor Raits
10288b9c6d
Add patch to fix build with new libreport
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 07:41:21 +01:00
Igor Raits
2bb52e3881
Rebuild for satyr 0.30
Signed-off-by: Igor Raits <ignatenkobrain@fedoraproject.org>
2020-02-07 07:25:47 +01:00
Martin Kutlak
68a77d6ad6 Fix typo in spec file
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-31 10:44:31 +01:00
Martin Kutlak
8f4c491a4b Add patch for possibly unitialized variable
Removed comments after endifs.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-31 10:42:41 +01:00
Martin Kutlak
c7d2242d98 patch: Fix build failure with gcc -fno-common
Resolves: rhbz#1795820

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2020-01-30 17:10:50 +01:00
Fedora Release Engineering
4d76ca5e3a - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2020-01-28 11:08:18 +00:00
Ernestas Kulik
0c014bfd3a Bump release
Oops.
2020-01-14 14:01:49 +01:00
Ernestas Kulik
507c1e9e86 Drop scriptlets for abrt-ccpp.service
It’s been dropped, no use in triggering disabling or restarting. The
preset has had abrt-ccpp replaced with abrt-journal-core forever now as
well, so let’s just do it.
2020-01-14 13:58:06 +01:00
Matěj Grabovský
cbad6eeeab Use correct paths for installed Python modules
This patch is pulled from upstream.
2019-10-16 14:02:50 +02:00
Matěj Grabovský
ac861159ca New upstream release 2.13.0
Signed-off-by: Matěj Grabovský <mgrabovs@redhat.com>
2019-10-11 16:32:47 +02:00
Miro Hrončok
f182793f33 Rebuilt for Python 3.8.0rc1 (#1748018) 2019-10-03 13:50:11 +02:00
Miro Hrončok
9e6bef580f Rebuilt for Python 3.8 2019-08-17 18:45:15 +02:00
Ernestas Kulik
df2a70c73b Update to 2.12.2
Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-08-01 14:31:16 +02:00
Fedora Release Engineering
3e5d6a98ef - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-07-24 17:28:02 +00:00
Martin Kutlak
a2c5fdd9e8 Add patch to fix failing a-a-list-dsos on rawhide
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2019-07-12 17:36:43 +02:00
Martin Kutlak
6b11b1ff26 New upstream release version 2.12.1
* Remove gen-version from spec
- This is upstream script to generate version. This is not needed in dist-git.

[2.12.1]
Added
- Require dbus-tools for dbus-send command.

Changed
- ABRT won't process crashes coming from unpackaged applications by default.
- Completely removed support for Python2.
- Update new ABRT icon.
- retrace-client defaults to https.
- Updated man pages.
- Removed configurations from /usr/share/abrt.
- Removed provides for abrt-python packages.

Fixed
- Gracefully handle exceptions comming from abrt-action-generate-machine-id.
- Gracefully handle exceptions comming from abrt-action-install-debuginfo.
- Use correct name of environment variable for retrace-server.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2019-07-03 17:54:51 +02:00
Igor Gnatenko
f9e6665820
Rebuild for RPM 4.15
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-06-11 00:13:16 +02:00
Igor Gnatenko
17aa2db63d
Rebuild for RPM 4.15
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-06-10 17:41:59 +02:00
Miro Hrončok
1ee4720bca BR git explicitly, it is used in %prep
Previously, it was pulled in transitively,
that is no longer true.

  Executing(%prep): /bin/sh -e /var/tmp/rpm-tmp.k6RazT
  ...
  + /usr/bin/git init -q
  /var/tmp/rpm-tmp.k6RazT: line 42: /usr/bin/git: No such file or directory
  error: Bad exit status from /var/tmp/rpm-tmp.k6RazT (%prep)
2019-04-04 15:45:29 +02:00
Ernestas Kulik
67f63a5ca4 Bump release
Forgot to do that, too.

Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-05 16:49:11 +01:00
Ernestas Kulik
5dfc50845c Bump dependencies
Forgot to do that the first time.

Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-05 16:47:56 +01:00
Ernestas Kulik
c7b20eb399 Update to 2.12.0
Signed-off-by: Ernestas Kulik <ekulik@redhat.com>
2019-02-04 14:33:29 +01:00
Fedora Release Engineering
ebf644594c - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2019-01-31 12:53:03 +00:00
Igor Gnatenko
eadff202bc
Remove obsolete scriptlets
References: https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2019-01-27 12:37:15 +01:00
Matej Marusak
9d7d233bf9 Bump up release
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-12 12:41:33 +01:00
Matej Marusak
8086e64036 Fix use after free in applet
Fixes BZ#1665521

Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-12 12:39:07 +01:00
Matej Marusak
509bd67e3d Include forgotten macro
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 15:13:11 +01:00
Matej Marusak
895d076624 Update to work with new glib
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 14:46:39 +01:00
Matej Marusak
50039757c0 New upstream release
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2019-01-08 12:00:40 +01:00
Martin Kutlak
8dd747fded Remove omitted patches
Forgot to remove these in 92d1203917

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2018-10-08 15:31:11 +02:00
Martin Kutlak
92d1203917 New upstream release 2.11.0
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2018-10-08 15:20:06 +02:00
Adam Williamson
bcfb1b554d Backport several bugfix commits, inc. gdb bt generation fail
Generation of gdb backtraces in 2.10.10 is entirely broken. As
I was backporting that fix, I saw three other bug fix commits
that looked significant, so backported those too. One is needed
for the package to build at all (the g_type_class_add_private
replacement).
2018-09-15 15:14:00 -07:00
Igor Gnatenko
d26d504519
%{python_sitearch} → %{python2_sitearch}
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-07-30 00:22:30 +02:00
Igor Gnatenko
c6814312f9
%{python_sitelib} → %{python2_sitelib}
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-07-29 23:12:01 +02:00
Fedora Release Engineering
4ac8f5f7a9 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-07-12 19:56:23 +00:00
Jason Tibbitts
a09a33c9f5 Remove needless use of %defattr 2018-07-10 00:09:12 -05:00
Miro Hrončok
3c2253dc6d Rebuilt for Python 3.7 2018-06-18 18:17:04 +02:00
Miro Hrončok
042464a929 Set PYTHON to python3 during install
...to avoid ambiguous python invocation

Fixes a FTBFS https://bugzilla.redhat.com/show_bug.cgi?id=1589314
2018-06-08 18:22:35 +02:00
Matej Marusak
dcab69a1fb New version 2.10.10
Signed-off-by: Matej Marusak <mmarusak@redhat.com>
2018-05-31 11:10:41 +02:00
Matej Habrnal
2c14e84f08 abrt do not require python2 if "with python3"
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-10 13:16:29 +02:00
Matej Habrnal
81b08b87c0 abrt-addon-ccpp do not require python2 if "with python3"
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-09 10:18:59 +02:00
Matej Habrnal
437b080e9a drop python2-abrt-addon requires
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-05-03 10:56:51 +02:00
Matej Habrnal
c9a0a107d9 Fix python requires in spec file
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-04-27 13:25:04 +02:00
Matej Habrnal
4f98a322c2 New upstream release 2.10.9
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-04-27 13:13:39 +02:00
Björn Esser
648b4c8601
Rebuilt for libjson-c.so.4 (json-c v0.13.1) on fc28 2018-03-27 10:11:14 +02:00
Matej Habrnal
fa6bf827b2 New version 2.10.8
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-03-21 11:52:41 +01:00
Björn Esser
22482fb18b
Rebuilt for libjson-c.so.4 (json-c v0.13.1) 2018-03-06 15:14:36 +01:00
Matej Habrnal
dc422cf7ed New version 2.10.7
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-02-26 15:27:37 +01:00
Matej Habrnal
e06dcb57e7 New version 2.10.6
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2018-02-21 16:34:57 +01:00
Igor Gnatenko
6b7ef25742 Remove BuildRoot definition
None of currently supported distributions need that.
It was needed last for EL5 which is EOL now

Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-13 23:00:48 +01:00
Igor Gnatenko
7b19a66f3c
Escape macros in %changelog
Reference: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/Y2ZUKK2B7T2IKXPMODNF6HB2O5T5TS6H/
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-02-09 09:04:06 +01:00
Fedora Release Engineering
09e4addde4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild
Signed-off-by: Fedora Release Engineering <releng@fedoraproject.org>
2018-02-07 01:46:08 +00:00
Igor Gnatenko
4684ea4866 Remove obsolete scriptlets
Signed-off-by: Igor Gnatenko <ignatenkobrain@fedoraproject.org>
2018-01-05 23:23:42 +01:00
Iryna Shcherbina
d663542b40 Fix ambiguous Python 2 dependency declarations 2017-12-11 14:39:41 +01:00
Björn Esser
37ad20102e
Rebuilt for libjson-c.so.3 2017-12-10 23:04:55 +01:00
Julius Milan
85802ca9d7 New version 2.10.5
Signed-off-by: Julius Milan <jmilan@redhat.com>
2017-11-02 19:54:22 +01:00
Martin Kutlak
a074333d28 Drop GPG check patch for unsigned packages
Rawhide packages are signed.
https://fedoraproject.org/wiki/Releases/Rawhide

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-09-27 10:21:34 +02:00
Martin Kutlak
6a0f0e431a Fix log renaming to log_warning
Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-08-30 14:35:12 +02:00
Matej Habrnal
d2918af2e6 New version 2.10.4
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-08-28 13:06:51 +02:00
Zbigniew Jędrzejewski-Szmek
49b1bc1549 Fix %_isa and add some missing Provides 2017-08-19 18:39:14 -04:00
Zbigniew Jędrzejewski-Szmek
afd3ea3bea Finish renaming of python binary packages
I messed up previous commit, sorry.
2017-08-19 10:17:11 -04:00
Zbigniew Jędrzejewski-Szmek
f36c5ca8dc Rename python binary packages 2017-08-19 07:14:33 -04:00
Igor Gnatenko
2fe9ae6400 Hacks for RPM 4.14 support
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-11 12:27:27 +02:00
Igor Gnatenko
baf8fefda7 Rebuilt after RPM update (№ 3)
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-11 10:39:26 +02:00
Igor Gnatenko
9b73a80599 Rebuilt for RPM soname bump
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-10 22:06:39 +02:00
Igor Gnatenko
248ea8cdf4 Rebuilt for RPM soname bump
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-08-10 20:19:43 +02:00
Fedora Release Engineering
5349e70f0a - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild 2017-08-02 17:21:56 +00:00
Fedora Release Engineering
7ef5a567fa - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild 2017-07-26 02:31:58 +00:00
Martin Kutlak
7de0bef650 Fix sources
I accidently commited wrong sources file in commit 253f3b.

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-06-16 10:14:02 +02:00
Martin Kutlak
253f3b5e24 New version 2.10.3
Resolves: #1452160, #1444924, #1437956

Signed-off-by: Martin Kutlak <mkutlak@redhat.com>
2017-06-15 17:51:01 +02:00
Matej Habrnal
e8a62759b3 abrt-desktop shouldn't require gdb but gdb-headless
abrt-desktop required gdb which which pulls in gcc among other things.

Resolves: #1452336

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-05-19 10:17:53 +02:00
Matej Habrnal
a170e2f896 create /var/lib/abrt because of abrt-migration
abrt-addon-ccpp has to create /var/lib/abrt because
abrt-migration file is placed here.

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-04-27 10:33:50 +02:00
Matej Habrnal
3c50298685 New version 2.10.2
Resolves: #1439821

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-04-25 13:04:41 +02:00
Matej Habrnal
ba27e114c2 New version 2.10.1
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-03-16 12:50:11 +01:00
Fedora Release Engineering
d5ced8a4cf - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild 2017-02-10 05:41:51 +00:00
Igor Gnatenko
bdca143d24 Rebuild for xmlrpc-c
Signed-off-by: Igor Gnatenko <ignatenko@redhat.com>
2017-01-21 14:49:59 +01:00
Matej Habrnal
345ed6c98e Allow rpm to be optional at build time and bug fixes
Resolves #1413637, #1413451

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-01-18 10:53:54 +01:00
Matej Habrnal
540f6e7795 New version 2.10.0
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2017-01-03 12:56:21 +01:00
Miro Hrončok
a96f20b524 Rebuild for Python 3.6 2016-12-19 18:20:36 +01:00
Jakub Filak
21561ba82c New upstream release 2.9.0
Signed-off-by: Jakub Filak <jfilak@redhat.com>
2016-09-10 07:33:25 +02:00
Fedora Release Engineering
c649b7d724 - https://fedoraproject.org/wiki/Changes/Automatic_Provides_for_Python_RPM_Packages 2016-07-19 06:29:40 +00:00
Matej Habrnal
e2f4733fc4 New upstream release 2.8.2
Resolves #1357264

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-07-18 12:14:41 +02:00
Matej Habrnal
168feccb11 New upstream release 2.8.1
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-05-25 09:48:30 +02:00
Matej Habrnal
cd3efeaff4 Fix broken pipe error in a-a-install-debuginfo
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-04-11 09:50:01 +02:00
Matej Habrnal
a22abdb1f3 python3 addon: workaround a bug in traceback
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-03-07 15:33:46 +01:00
Matej Habrnal
ba94a9992a blacklist Firefox's plugin-container and turn off compat cores
Resolves: #1308840
2016-02-23 16:05:36 +01:00
Matej Habrnal
04b13c6fc9 drop %e from the core_pattern
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-02-10 10:43:04 +01:00
Matej Habrnal
ba52311fcb New version 2.8.0
Resolves: #1304310
2016-02-03 15:05:21 +01:00
Matej Habrnal
ee087b960d New version 2.7.2
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2016-02-02 14:31:00 +01:00
Jakub Filak
61650c58f2 New upstream release 2.7.1
CVE-2015-5273, CVE-2015-5287

Resolves: #1262252, #1284557
2015-11-23 17:52:30 +01:00
Zbigniew Jędrzejewski-Szmek
55488e54c7 Update requires on python-argcomplete 2015-11-14 15:00:41 -05:00
Jakub Filak
46dc322c41 Rebuilt for Python3.5 rebuild 2015-11-06 11:06:27 +01:00
Jakub Filak
820caf519c Fix broken problem details in abrt-cli/gnome-abrt 2015-10-28 00:34:04 +01:00
Matej Habrnal
52400fcf42 New version 2.7.0
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-10-15 16:37:31 +02:00
Matej Habrnal
58ac8d6e9a bodhi: fix a segfault when testing an os-release opt for 'rawhide'
and actualize the abrt-bodhi man page

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-09-15 12:55:38 +02:00
Matej Habrnal
ef5d23d3b1 Bug fixes
- introduce bodhi2 to abrt-bodhi
- don't start reporting of not-reportable problems
- add hawkey to BRs of abrt-bodhi
- add bash on the package blacklist

Resolves #1250379

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-08-26 16:52:35 +02:00
Matej Habrnal
b52e1a767a Fix bugs in a-auto-reporting, dbus, a-hook-ccpp and abrt-cli
Correct usage of abrt-gdb-exploitable.

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-08-17 09:51:23 +02:00
Jakub Filak
a6a1fceb2c Add python3-augeas to Requires 2015-07-29 17:49:11 +02:00
Jakub Filak
d01f0fa520 Rebuild for rpmlib
https://lists.fedoraproject.org/pipermail/devel/2015-July/212672.html
2015-07-28 16:14:28 +02:00
Matej Habrnal
66b169ccf2 Fixes related to transition to Python 3 and fix in abrt-merge-pstoreoops
Resolves #1246459

Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-07-24 14:58:43 +02:00
Matej Habrnal
207cb13ae3 Use gettext instead of lgettext in all python scripts
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
2015-07-22 18:18:18 +02:00
Jakub Filak
9705d07480 New upstream release 2.6.2 2015-07-20 15:22:55 +02:00
29 changed files with 1412 additions and 125671 deletions

1
.fmf/version Normal file
View file

@ -0,0 +1 @@
1

41
.gitignore vendored
View file

@ -46,3 +46,44 @@ abrt-1.1.13.tar.gz
/abrt-2.6.2.tar.gz
/abrt-2.7.0.tar.gz
/abrt-2.7.1.tar.gz
/abrt-2.7.2.tar.gz
/abrt-2.8.0.tar.gz
/abrt-2.8.1.tar.gz
/abrt-2.8.2.tar.gz
/abrt-2.9.0.tar.gz
/abrt-2.10.0.tar.gz
/abrt-2.10.1.tar.gz
/abrt-2.10.2.tar.gz
/abrt-2.10.3.tar.gz
/abrt-2.10.4.tar.gz
/abrt-2.10.5.tar.gz
/abrt-2.10.6.tar.gz
/abrt-2.10.7.tar.gz
/abrt-2.10.8.tar.gz
/abrt-2.10.9.tar.gz
/abrt-2.10.10.tar.gz
/abrt-2.11.0.tar.gz
/abrt-2.11.1.tar.gz
/abrt-2.12.0.tar.gz
/abrt-2.12.1.tar.gz
/abrt-2.12.2.tar.gz
/abrt-2.13.0.tar.gz
/abrt-2.14.0.tar.gz
/abrt-2.14.1.tar.gz
/abrt-2.14.2.tar.gz
/abrt-2.14.3.tar.gz
/abrt-2.14.4.tar.gz
/abrt-2.14.5.tar.gz
/abrt-2.14.6.tar.gz
/abrt-2.15.0.tar.gz
/abrt-2.15.1.tar.gz
/abrt-2.16.0.tar.gz
/abrt-2.16.1.tar.gz
/abrt-2.17.0.tar.gz
/abrt-2.17.1.tar.gz
/abrt-2.17.2.tar.gz
/abrt-2.17.4.tar.gz
/abrt-2.17.5.tar.gz
/abrt-2.17.6.tar.gz
/abrt-2.17.7.tar.gz
/abrt-2.17.8.tar.gz

View file

@ -1,99 +0,0 @@
From 51531e9ea72af09571688a20f00e55cad5fe9c3a Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 9 Feb 2016 17:55:29 +0100
Subject: [PATCH] ccpp: drop %e from the core_pattern
The argument is no longer need and it must be placed either at the end
of the command or enclosed with '' as it can contain white space.
Threads can have an arbitrary name:
man 3 pthread_setname_np
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/abrt-hook-ccpp.c | 16 ++++++++--------
src/hooks/abrt-install-ccpp-hook.in | 12 +-----------
2 files changed, 9 insertions(+), 19 deletions(-)
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
index 8f1b813..dfe9526 100644
--- a/src/hooks/abrt-hook-ccpp.c
+++ b/src/hooks/abrt-hook-ccpp.c
@@ -143,9 +143,9 @@ static struct dump_dir *dd;
* %u - uid
* %g - gid
* %t - UNIX time of dump
- * %e - executable filename
- * %i - crash thread tid
* %P - global pid
+ * %I - crash thread tid
+ * %e - executable filename (can contain white spaces)
* %% - output one "%"
*/
/* Hook must be installed with exactly the same sequence of %c specifiers.
@@ -661,9 +661,9 @@ int main(int argc, char** argv)
if (argc < 8)
{
- /* percent specifier: %s %c %p %u %g %t %e %P %i*/
- /* argv: [0] [1] [2] [3] [4] [5] [6] [7] [8] [9]*/
- error_msg_and_die("Usage: %s SIGNO CORE_SIZE_LIMIT PID UID GID TIME BINARY_NAME GLOBAL_PID [TID]", argv[0]);
+ /* percent specifier: %s %c %p %u %g %t %P %T */
+ /* argv: [0] [1] [2] [3] [4] [5] [6] [7] [8] */
+ error_msg_and_die("Usage: %s SIGNO CORE_SIZE_LIMIT PID UID GID TIME GLOBAL_PID GLOBAL_TID", argv[0]);
}
/* Not needed on 2.6.30.
@@ -704,8 +704,8 @@ int main(int argc, char** argv)
/* set to max possible >0 value */
ulimit_c = ~((off_t)1 << (sizeof(off_t)*8-1));
}
- const char *global_pid_str = argv[8];
- pid_t pid = xatoi_positive(argv[8]);
+ const char *global_pid_str = argv[7];
+ pid_t pid = xatoi_positive(argv[7]);
user_pwd = get_cwd(pid); /* may be NULL on error */
log_notice("user_pwd:'%s'", user_pwd);
@@ -867,7 +867,7 @@ int main(int argc, char** argv)
signal_no, signame, "dumping core");
pid_t tid = -1;
- const char *tid_str = argv[9];
+ const char *tid_str = argv[8];
if (tid_str)
{
tid = xatoi_positive(tid_str);
diff --git a/src/hooks/abrt-install-ccpp-hook.in b/src/hooks/abrt-install-ccpp-hook.in
index 707c57d..660c209 100755
--- a/src/hooks/abrt-install-ccpp-hook.in
+++ b/src/hooks/abrt-install-ccpp-hook.in
@@ -11,9 +11,7 @@ SAVED_PATTERN_DIR="@VAR_RUN@/abrt"
SAVED_PATTERN_FILE="@VAR_RUN@/abrt/saved_core_pattern"
HOOK_BIN="@libexecdir@/abrt-hook-ccpp"
# Must match percent_specifiers[] order in abrt-hook-ccpp.c:
-PATTERN="|$HOOK_BIN %s %c %p %u %g %t %e %P %I"
-# Same, but with bogus "executable name" parameter
-PATTERN1="|$HOOK_BIN %s %c %p %u %g %t e %P %I"
+PATTERN="|$HOOK_BIN %s %c %p %u %g %t %P %I"
# core_pipe_limit specifies how many dump_helpers can run at the same time
# 0 - means unlimited, but it's not guaranteed that /proc/<pid> of crashing
@@ -39,14 +37,6 @@ start() {
cur=`cat "$PATTERN_FILE"`
cur_first=`printf "%s" "$cur" | sed 's/ .*//'`
- # Is there a %e (executable name) in old pattern anywhere?
- if test x"${cur#*%e}" = x"${cur}"; then
- # No. Can use PATTERN with less risk of overflow
- # on expansion (executable names can be LONG).
- # Overflow would cause kernel to abort coredump. BAD.
- PATTERN="$PATTERN1"
- fi
-
$verbose && printf "cur:'%s'\n" "$cur"
# Is it already installed?
if test x"$cur_first" != x"|$HOOK_BIN"; then # no
--
2.5.0

File diff suppressed because it is too large Load diff

View file

@ -1,26 +0,0 @@
From 0a918dd4d1aee2a90de212f932c01081c73791cd Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 11 Feb 2016 15:26:27 +0100
Subject: [PATCH] translations: add missing new line
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
po/km.po | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/po/km.po b/po/km.po
index 84bb1b1..ab7a684 100644
--- a/po/km.po
+++ b/po/km.po
@@ -137,7 +137,7 @@ msgid ""
"\n"
"Applet which notifies user when new problems are detected by ABRT\n"
msgstr ""
-"Applet ដែលបានជូនដំណឹងអ្នកប្រើនៅពេលដែលមានបញ្ហាថ្មីត្រូវបានរកឃើញដោយ ABRT"
+"Applet ដែលបានជូនដំណឹងអ្នកប្រើនៅពេលដែលមានបញ្ហាថ្មីត្រូវបានរកឃើញដោយ ABRT\n"
#: ../src/configuration-gui/abrt-config-widget.c:483
msgid ""
--
2.5.0

View file

@ -1,25 +0,0 @@
From 7dca143dd91229e0dad78bcdead6748ecf27cbd3 Mon Sep 17 00:00:00 2001
From: Yuri Chornoivan <yurchor@ukr.net>
Date: Fri, 12 Feb 2016 22:51:18 +0200
Subject: [PATCH] Fix minor typo: possition -> position
---
src/plugins/abrt-dump-journal-xorg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/plugins/abrt-dump-journal-xorg.c b/src/plugins/abrt-dump-journal-xorg.c
index 87dfe13..1ede56f 100644
--- a/src/plugins/abrt-dump-journal-xorg.c
+++ b/src/plugins/abrt-dump-journal-xorg.c
@@ -147,7 +147,7 @@ int main(int argc, char *argv[])
"-c and -e options conflicts because both specifies the first read message.\n"
"\n"
"-e is useful only for -f because the following of journal starts by reading \n"
- "the entire journal if the last seen possition is not available.\n"
+ "the entire journal if the last seen position is not available.\n"
"\n"
"The last seen position is saved in %s\n"
"\n"
--
2.5.0

View file

@ -1,33 +0,0 @@
From a136d0c7b8aa72e7cf60e1255504191f1e9ac800 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Tue, 16 Feb 2016 10:53:06 +0100
Subject: [PATCH] a-a-save-package-data: blacklist
/usr/lib(64)/firefox/plugin-container
/usr/lib(64)/firefox/plugin-container is a sandbox/launcher for Firefox
plug-ins. When it crases Firefox loads it again so we don't want those crashes
reported.
Related to: rhbz#1308840
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/daemon/abrt-action-save-package-data.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/daemon/abrt-action-save-package-data.conf b/src/daemon/abrt-action-save-package-data.conf
index 58f5061..f3a808f 100644
--- a/src/daemon/abrt-action-save-package-data.conf
+++ b/src/daemon/abrt-action-save-package-data.conf
@@ -15,7 +15,7 @@ ProcessUnpackaged = yes
# Blacklisted executable paths (shell patterns)
#
-BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer
+BlackListedPaths = /usr/share/doc/*, */example*, /usr/bin/nspluginviewer, /usr/lib*/firefox/plugin-container
# interpreters names
Interpreters = python2, python2.7, python, python3, python3.3, python3.4, python3.5, perl, perl5.16.2
--
2.5.0

View file

@ -1,85 +0,0 @@
From 715fcfb5d83faa29f8d221d0e2d800b08261810a Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Tue, 8 Mar 2016 16:42:31 +0100
Subject: [PATCH] a-a-install-debuginfo: make tmpdir variable global
Function clean_up() has one required parameter tmpdir.
Without this commit clean_up() function raises an exception because it was
called without the parameter.
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/plugins/abrt-action-install-debuginfo.in | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index f70ebcd..7818ffd 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -20,7 +20,8 @@ import problem
RETURN_OK = 0
# serious problem, should be logged somewhere
RETURN_FAILURE = 2
-
+# path to tmp directory has to be global because of clean_up()
+TMPDIR = None
GETTEXT_PROGNAME = "abrt"
import locale
@@ -43,11 +44,11 @@ def init_gettext():
gettext.textdomain(GETTEXT_PROGNAME)
def sigterm_handler(signum, frame):
- clean_up()
+ clean_up(TMPDIR)
exit(RETURN_OK)
def sigint_handler(signum, frame):
- clean_up()
+ clean_up(TMPDIR)
print("\n{0}".format(_("Exiting on user command")))
sys.stdout.flush()
# ??! without "sys.", I am getting segv!
@@ -63,7 +64,6 @@ if __name__ == "__main__":
fbuild_ids = "build_ids"
cachedirs = []
size_mb = 4096
- tmpdir = None
keeprpms = False
noninteractive = False
b_ids = []
@@ -135,7 +135,7 @@ if __name__ == "__main__":
except:
pass
elif opt == "--tmpdir":
- tmpdir = arg
+ TMPDIR = arg
elif opt == "--keeprpms":
keeprpms = True
# --exact takes precendece over --ids
@@ -159,11 +159,11 @@ if __name__ == "__main__":
if not cachedirs:
cachedirs = ["/var/cache/abrt-di"]
- if not tmpdir:
+ if not TMPDIR:
# security people prefer temp subdirs in app's private dir, like /var/run/abrt
# and we switched to /tmp but Fedora feature tmp-on-tmpfs appeared, hence we must
# not use /tmp for potential big data anymore
- tmpdir = "@LARGE_DATA_TMP_DIR@/abrt-tmp-debuginfo-%s.%u" % (time.strftime("%Y-%m-%d-%H:%M:%S"), os.getpid())
+ TMPDIR = "@LARGE_DATA_TMP_DIR@/abrt-tmp-debuginfo-%s.%u" % (time.strftime("%Y-%m-%d-%H:%M:%S"), os.getpid())
if missing == None:
@@ -235,7 +235,7 @@ if __name__ == "__main__":
sys.exit(RETURN_FAILURE)
# TODO: should we pass keep_rpms=keeprpms to DebugInfoDownload here??
- downloader = download_class(cache=cachedirs[0], tmp=tmpdir,
+ downloader = download_class(cache=cachedirs[0], tmp=TMPDIR,
noninteractive=noninteractive,
repo_pattern=repo_pattern)
try:
--
2.5.5

View file

@ -1,49 +0,0 @@
From a999c2e9c25a46ffeff0c67ad9b9177d640a4b87 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Tue, 8 Mar 2016 16:45:36 +0100
Subject: [PATCH] a-a-install-debuginfo: fix BrokenPipe error
While debug info is downloading and stop button is pressed the BrokenPipe
error appears.
If the stop button is pressed, gui wizard sends SIGTERM to all
processes with the same group ID so abrt-action-install-debuginfo got SIGTERM
as well. It has its own SIGTERM handler which calls clean_up() function and it
takes a while before the tool is terminated.
abrt-action-install-debuginfo tries to write some messages to the closed socket
during the clean_up process and it raises a BrokenPipe exception. We must
ensure that no message will be printed after SIGTERM is recieved.
Related to: #1255259
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/plugins/abrt-action-install-debuginfo.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index 7818ffd..e4a7dfd 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -44,7 +44,7 @@ def init_gettext():
gettext.textdomain(GETTEXT_PROGNAME)
def sigterm_handler(signum, frame):
- clean_up(TMPDIR)
+ clean_up(TMPDIR, silent=True)
exit(RETURN_OK)
def sigint_handler(signum, frame):
@@ -241,6 +241,9 @@ if __name__ == "__main__":
try:
result = downloader.download(missing, download_exact_files=exact_fls)
except Exception as ex:
+ if ex.errno == errno.EPIPE:
+ clean_up(TMPDIR, silent=True)
+ exit(RETURN_FAILURE)
error_msg_and_die("Can't download debuginfos: %s", ex)
if exact_fls:
--
2.5.5

View file

@ -1,282 +0,0 @@
From 92c847ef13cd721a37187c5878a05b54df48114a Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Sat, 20 Feb 2016 08:27:32 +0100
Subject: [PATCH] Add basic documentation
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
CONTRIBUTING.md | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
INSTALL | 7 -----
INSTALL.md | 56 ++++++++++++++++++++++++++++++++++
Makefile.am | 2 ++
README | 11 -------
README.md | 48 +++++++++++++++++++++++++++++
6 files changed, 200 insertions(+), 18 deletions(-)
create mode 100644 CONTRIBUTING.md
delete mode 100644 INSTALL
create mode 100644 INSTALL.md
delete mode 100644 README
create mode 100644 README.md
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
new file mode 100644
index 0000000..4b27138
--- /dev/null
+++ b/CONTRIBUTING.md
@@ -0,0 +1,94 @@
+# Contributing to ABRT
+
+Adopted from http://www.contribution-guide.org/
+
+BSD, Copyright (c) 2015 Jeff Forcier
+
+## Submitting bugs
+
+### Due diligence
+
+Before submitting a bug, please do the following:
+
+* Perform **basic troubleshooting** steps:
+
+ * **Make sure you're on the latest version.** If you're not on the most
+ recent version, your problem may have been solved already! Upgrading is
+ always the best first step.
+ * **Try older versions.** If you're already *on* the latest release, try
+ rolling back a few minor versions (e.g. if on 1.7, try 1.5 or 1.6) and
+ see if the problem goes away. This will help the devs narrow down when
+ the problem first arose in the commit log.
+ * **Try switching up dependency versions.** If the software in question has
+ dependencies (other libraries, etc) try upgrading/downgrading those as
+ well.
+
+* **Search the project's bug/issue tracker** to make sure it's not a known issue.
+* If you don't find a pre-existing issue, consider **checking with the mailing
+ list and/or IRC channel** in case the problem is non-bug-related.
+* Consult [README.md](README.md) for links to bugtracker, mailinglist or IRC.
+
+### What to put in your bug report
+
+Make sure your report gets the attention it deserves: bug reports with missing
+information may be ignored or punted back to you, delaying a fix. The below
+constitutes a bare minimum; more info is almost always better:
+
+* **What version of the core programming language interpreter/compiler are you
+ using?** For example, if it's a Python project, are you using Python 2.7.3?
+ Python 3.3.1? PyPy 2.0?
+* **What operating system are you on?** Make sure to include release and distribution.
+* **Which version or versions of the software are you using?** Ideally, you
+ followed the advice above and have ruled out (or verified that the problem
+ exists in) a few different versions.
+* **How can the developers recreate the bug on their end?** If possible,
+ include a copy of your code, the command you used to invoke it, and the full
+ output of your run (if applicable.)
+
+ * A common tactic is to pare down your code until a simple (but still
+ bug-causing) "base case" remains. Not only can this help you identify
+ problems which aren't real bugs, but it means the developer can get to
+ fixing the bug faster.
+
+
+## Contributing changes
+
+It would be the best if you could discuss your plans with us on #abrt or on our
+mailinig list crash-catcher@lists.fedorahosted.org before you spent too much
+energy and time.
+
+Before contributing, please, make yourself familiar with git. You can [try git
+online](https://try.github.io/). Things would be easier for all of us if you do
+your changes on a branch. Use a single commit for every logical reviewable
+change, without unrelated modifications (that will help us if need to revert a
+particular commit). Please avoid adding commits fixing your previous
+commits, do amend or rebase instead.
+
+Every commit must have either comprehensive commit message saying what is being
+changed and why or a link (an issue number on Github) to a bug report where
+this information is available. It is also useful to include notes about
+negative decisions - i.e. why you decided to not do particular things. Please
+bare in mind that other developers might not understand what the original
+problem was.
+
+### Full example
+
+Here's an example workflow for a project `abrt` hosted on Github
+Your username is `yourname` and you're submitting a basic bugfix or feature.
+
+* Hit 'fork' on Github, creating e.g. `yourname/abrt`.
+* `git clone git@github.com:yourname/abrt`
+* `cd abrt`
+* `git checkout -b foo_the_bars` to create new local branch named foo_the_bars
+* Hack, hack, hack
+* Run `make check`
+* `git status`
+* `git add`
+* `git commit -s -m "Foo the bars"`
+* `git push -u origin HEAD` to create foo_the_bars branch in your fork
+* Visit your fork at Github and click handy "Pull request" button.
+* In the description field, write down issue number (if submitting code fixing
+ an existing issue) or describe the issue + your fix (if submitting a wholly
+ new bugfix).
+* Hit 'submit'! And please be patient - the maintainers will get to you when
+ they can.
diff --git a/INSTALL b/INSTALL
deleted file mode 100644
index 799a4a6..0000000
--- a/INSTALL
+++ /dev/null
@@ -1,7 +0,0 @@
-How to install
-==============
-
-1. autogen.sh
-2. ./configure
-3. make
-4. make install
diff --git a/INSTALL.md b/INSTALL.md
new file mode 100644
index 0000000..96d42c4
--- /dev/null
+++ b/INSTALL.md
@@ -0,0 +1,56 @@
+# How to install
+
+### Development dependencies
+
+Build dependencies can be listed by:
+
+ $ ./autogen.sh sysdeps
+
+or installed by:
+
+ $ ./autogen.sh sysdeps --install
+
+The dependency installer gets the data from [the rpm spec file](abrt.spec.in)
+
+### Building from sources
+
+When you have all dependencies installed run the following commands:
+
+ $ ./autogen.sh --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --sharedstatedir=/var/lib
+
+ $ make
+
+or if you want to debug ABRT run:
+
+ $ CFLAGS="-g -g3 -ggdb -ggdb3 -O0" ./autogen.sh --prefix=/usr \
+ --sysconfdir=/etc \
+ --localstatedir=/var \
+ --sharedstatedir=/var/lib \
+ --enable-debug
+
+ $ make
+
+### Checking
+
+ABRT uses [Autotest](http://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Using-Autotest.html)
+to validate source codes. Run the test by:
+
+ $ make check
+
+If you want to search for memory issues, build ABRT with debug options and then
+run:
+
+ $ make maintainer-check
+
+### Installing
+
+If you need an rpm package, run:
+
+ $ make rpm
+
+otherwise run:
+
+ $ make install
diff --git a/Makefile.am b/Makefile.am
index 01b8a97..e528c93 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -36,6 +36,8 @@ EXTRA_DIST = doc/coding-style abrt.spec.in abrt.pc.in \
abrt-version asciidoc.conf init-scripts/* $(TESTSUITE_FILES) \
augeas/test_abrt.aug
+dist_doc_DATA = README.md
+
pkgconfigdir = $(libdir)/pkgconfig
pkgconfig_DATA = abrt.pc
diff --git a/README b/README
deleted file mode 100644
index 26cbbcb..0000000
--- a/README
+++ /dev/null
@@ -1,11 +0,0 @@
-These sources are in early stages. They are changing every day :-)...
-Anyway, patches are welcome.
-
-** Using Valgrind
-
-When running ABRT under memcheck, GLib's environment variables should
-be set to turn off glib's memory optimization, so valgrind is not
-confused:
-
-G_SLICE=always-malloc G_DEBUG=gc-friendly valgrind --tool=memcheck \
- --leak-check=full abrtd -dvvv
diff --git a/README.md b/README.md
new file mode 100644
index 0000000..e58a499
--- /dev/null
+++ b/README.md
@@ -0,0 +1,48 @@
+# ABRT
+
+**A set of tools to help users detect and report application crashes.**
+
+### About
+
+Its main purpose is to ease the process of reporting an issue and finding a
+solution.
+
+The solution in this context might be a bugzilla ticket, knowledge base article
+or a suggestion to update a package to a version containing a fix.
+
+### Documentation
+
+Every ABRT program and configuration file has a man page describing it. It is
+also possible to [read the ABRT documentation](http://abrt.readthedocs.org/)
+online. For contributors and developers, there are also [wiki
+pages](https://github.com/abrt/abrt/wiki) describing some topics to deeper
+technical details.
+
+### Development
+
+ * IRC Channel: #abrt on FreeNode
+ * [Mailing List](https://lists.fedorahosted.org/admin/lists/crash-catcher.lists.fedorahosted.org/)
+ * [Bug Reports and RFEs](https://github.com/abrt/abrt/issues)
+ * [Contributing to ABRT](CONTRIBUTING.md)
+ * [Install and run ABRT](INSTALL.md)
+
+
+### Running
+
+ABRT consist of several services and many small utilities. While The utilities
+can be successfully run from the source directories after build, the services
+often uses the utilities to do actions and expect the utilities installed in
+the system directories. Hence to run the services, it is recommended to install
+ABRT first and run them as system services. The instructions how to build
+and install ABRT can be found in [INSTALL.md](INSTALL.md)
+
+### Technologies
+
+* [libreport](https://github.com/abrt/libreport) - problem data format, reporting
+* [satyr](https://github.com/abrt/satyr) - backtrace processing, micro-reports
+* [Python3](https://www.python.org/)
+* [GLib2](https://developer.gnome.org/glib/)
+* [Gtk3](https://developer.gnome.org/gtk3)
+* [D-Bus](https://www.freedesktop.org/wiki/Software/dbus/)
+* [SELinux](https://github.com/SELinuxProject/selinux/wiki)
+* [systemd](https://www.freedesktop.org/wiki/Software/systemd/)
--
2.5.5

View file

@ -1,350 +0,0 @@
From 193f2898d9bf3c7f971d2e37a846b61857e7eb77 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 5 Apr 2016 15:09:39 +0200
Subject: [PATCH] Merge a-a-save-kernel-data with a-a-save-package-data
I forgot to do this while working on commit
650822d0d2438825515c0e41f06cd9fb77a18334
I do not think creating another tool doing almost the same thing was a
good idea. I believe we must keep relevant bits together and not to
spread functionality among myriads of tools just because someone do not
want to code in C.
I failed to find any justification for creating
'abrt-action-save-kernel-data' instead of teaching
'abrt-action-save-package-data' to do that job:
130dee46d601f3af6bb196d99a5c911335506adf
This commit changes contents of 'package' file from 'kernel' to
'kernel-$version' string. It should not break anything as I could not
find any justification for the 'kernel' string except the original
author's believe it should be like that (probably because of efficiency).
Just for the record, we do not need the version in 'package' file
because the version is already included in 'kernel' file.
This commit enables GPGCheck and ProcessUnpackaged options for
Kerneloopses and VMcores.
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
doc/Makefile.am | 1 -
doc/abrt-action-save-kernel-data.txt | 33 -------------
src/daemon/abrt-action-save-package-data.c | 63 ++++++++++++++++--------
src/plugins/Makefile.am | 2 -
src/plugins/abrt-action-save-kernel-data | 78 ------------------------------
src/plugins/koops_event.conf | 3 +-
src/plugins/vmcore_event.conf | 2 +-
7 files changed, 46 insertions(+), 136 deletions(-)
delete mode 100644 doc/abrt-action-save-kernel-data.txt
delete mode 100755 src/plugins/abrt-action-save-kernel-data
diff --git a/doc/Makefile.am b/doc/Makefile.am
index d3184c4..4a5d94c 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -32,7 +32,6 @@ MAN1_TXT += abrt-merge-pstoreoops.txt
MAN1_TXT += abrt-server.txt
MAN1_TXT += abrt-cli.txt
MAN1_TXT += abrt-action-save-package-data.txt
-MAN1_TXT += abrt-action-save-kernel-data.txt
MAN1_TXT += abrt-install-ccpp-hook.txt
MAN1_TXT += abrt-action-analyze-ccpp-local.txt
MAN1_TXT += abrt-watch-log.txt
diff --git a/doc/abrt-action-save-kernel-data.txt b/doc/abrt-action-save-kernel-data.txt
deleted file mode 100644
index f82fa35..0000000
--- a/doc/abrt-action-save-kernel-data.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-abrt-action-save-kernel-data(1)
-================================
-
-NAME
-----
-abrt-action-save-kernel-data - Creates uReport mandatory files for kernel oopses.
-
-SYNOPSIS
---------
-'abrt-action-save-kernel-data'
-
-DESCRIPTION
------------
-The tool reads problem directory DIR. It analyzes contents of 'kernel' element,
-checks database of installed packages, and creates new elements
-'pkg_name', 'pkg_arch', 'pkg_version', 'pkg_release'.
-
-These files are required by reporter-ureporter (mandatory in uReport).
-
-Integration with ABRT events
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-This tool can be used as an ABRT reporter. Example
-fragment for /etc/libreport/report_event.conf:
-
-------------
-# Determine in which package/component the crash happened (if not yet done):
-EVENT=post-create analyzer=Kerneloops
- abrt-action-save-kernel-data
-------------
-
-AUTHORS
--------
-* ABRT team
diff --git a/src/daemon/abrt-action-save-package-data.c b/src/daemon/abrt-action-save-package-data.c
index 72c9878..6f8c80d 100644
--- a/src/daemon/abrt-action-save-package-data.c
+++ b/src/daemon/abrt-action-save-package-data.c
@@ -217,14 +217,7 @@ static int SavePackageDescriptionToDebugDump(const char *dump_dir_name, const ch
return 1;
char *type = dd_load_text(dd, FILENAME_TYPE);
- if (!strcmp(type, "Kerneloops"))
- {
- dd_save_text(dd, FILENAME_PACKAGE, "kernel");
- dd_save_text(dd, FILENAME_COMPONENT, "kernel");
- dd_close(dd);
- free(type);
- return 0;
- }
+ bool kernel_oops = !strcmp(type, "Kerneloops") || !strcmp(type, "vmcore");
free(type);
char *cmdline = NULL;
@@ -233,12 +226,32 @@ static int SavePackageDescriptionToDebugDump(const char *dump_dir_name, const ch
char *package_short_name = NULL;
struct pkg_envra *pkg_name = NULL;
char *component = NULL;
+ char *kernel = NULL;
int error = 1;
/* note: "goto ret" statements below free all the above variables,
* but they don't dd_close(dd) */
- cmdline = dd_load_text_ext(dd, FILENAME_CMDLINE, DD_FAIL_QUIETLY_ENOENT);
- executable = dd_load_text(dd, FILENAME_EXECUTABLE);
+ if (kernel_oops)
+ {
+ kernel = dd_load_text(dd, FILENAME_KERNEL);
+ if (!kernel)
+ {
+ log("File 'kernel' containing kernel version not "
+ "found in current directory");
+ goto ret;
+ }
+ /* Trim trailing white-spaces. */
+ strchrnul(kernel, ' ')[0] = '\0';
+
+ log_info("Looking for kernel package");
+ executable = xasprintf("/boot/vmlinuz-%s", kernel);
+ }
+ else
+ {
+ cmdline = dd_load_text_ext(dd, FILENAME_CMDLINE, DD_FAIL_QUIETLY_ENOENT);
+ executable = dd_load_text(dd, FILENAME_EXECUTABLE);
+ }
+
/* Do not implicitly query rpm database in process's root dir, if
* ExploreChroots is disabled. */
@@ -249,8 +262,12 @@ static int SavePackageDescriptionToDebugDump(const char *dump_dir_name, const ch
/* Close dd while we query package database. It can take some time,
* don't want to keep dd locked longer than necessary */
dd_close(dd);
+ dd = NULL;
- if (is_path_blacklisted(executable))
+ /* The check for kernel_oops is there because it could be an unexpected
+ * behaviour. If one wants to ignore kernel oops, she/he should disable
+ * the corresponding services. */
+ if (!kernel_oops && is_path_blacklisted(executable))
{
log("Blacklisted executable '%s'", executable);
goto ret; /* return 1 (failure) */
@@ -265,13 +282,17 @@ static int SavePackageDescriptionToDebugDump(const char *dump_dir_name, const ch
"proceeding without packaging information", executable);
goto ret0; /* no error */
}
- log("Executable '%s' doesn't belong to any package"
- " and ProcessUnpackaged is set to 'no'",
- executable
- );
+ if (kernel_oops)
+ log("Can't find kernel package corresponding to '%s'", kernel);
+ else
+ log("Executable '%s' doesn't belong to any package"
+ " and ProcessUnpackaged is set to 'no'", executable);
goto ret; /* return 1 (failure) */
}
+ if (kernel_oops)
+ goto skip_interperter;
+
/* Check well-known interpreter names */
const char *basename = strrchr(executable, '/');
if (basename)
@@ -314,11 +335,14 @@ static int SavePackageDescriptionToDebugDump(const char *dump_dir_name, const ch
pkg_name = script_pkg;
}
+skip_interperter:
package_short_name = xasprintf("%s", pkg_name->p_name);
log_info("Package:'%s' short:'%s'", pkg_name->p_nvr, package_short_name);
-
- if (g_list_find_custom(settings_setBlackListedPkgs, package_short_name, (GCompareFunc)g_strcmp0))
+ /* The check for kernel_oops is there because it could be an unexpected
+ * behaviour. If one wants to ignore kernel oops, she/he should disable
+ * the corresponding services. */
+ if (!kernel_oops && g_list_find_custom(settings_setBlackListedPkgs, package_short_name, (GCompareFunc)g_strcmp0))
{
log("Blacklisted package '%s'", package_short_name);
goto ret; /* return 1 (failure) */
@@ -358,11 +382,12 @@ static int SavePackageDescriptionToDebugDump(const char *dump_dir_name, const ch
if (component)
dd_save_text(dd, FILENAME_COMPONENT, component);
- dd_close(dd);
-
ret0:
error = 0;
ret:
+ if (dd)
+ dd_close(dd);
+
free(cmdline);
free(executable);
free(rootdir);
diff --git a/src/plugins/Makefile.am b/src/plugins/Makefile.am
index 005cc9d..2c9028b 100644
--- a/src/plugins/Makefile.am
+++ b/src/plugins/Makefile.am
@@ -6,7 +6,6 @@ bin_SCRIPTS = \
abrt-action-analyze-vulnerability \
abrt-action-list-dsos \
abrt-action-perform-ccpp-analysis \
- abrt-action-save-kernel-data \
abrt-action-analyze-ccpp-local \
abrt-action-notify
@@ -101,7 +100,6 @@ EXTRA_DIST = \
analyze_RetraceServer.xml.in \
abrt-action-analyze-core.in \
abrt-action-generate-machine-id \
- abrt-action-save-kernel-data \
abrt-action-ureport \
abrt-gdb-exploitable \
https-utils.h \
diff --git a/src/plugins/abrt-action-save-kernel-data b/src/plugins/abrt-action-save-kernel-data
deleted file mode 100755
index f8b18f0..0000000
--- a/src/plugins/abrt-action-save-kernel-data
+++ /dev/null
@@ -1,78 +0,0 @@
-#!/bin/bash
-#
-# Save pkg_{name, arch, version, release} for kernel oopses.
-#
-# These files are required by reporter-ureporter (mandatory
-# in uReport).
-#
-
-function print_usage
-{
- echo "Usage: abrt-action-save-package-data [OPTION]"
- echo ""
- echo " -r, --root ROOT use ROOT as top level directory"
- echo " -h, --help Show this help message"
-}
-
-ROOT="/"
-
-while [ $# -gt 0 ];
-do
- case "$1" in
- "-r"|"--root")
- if [ -z "$2" ]; then
- >&2
- echo "$1: requires argument"
- print_usage
- exit 1
- fi
-
- ROOT=$2
- shift
- ;;
-
- "-h"|"--help")
- echo "Save pkg_{name, arch, version, release} for kernel oopses."
- echo ""
- echo "These files are required by reporter-ureporter (mandatory"
- echo "in uReport)."
-
- print_usage
- exit 0
- ;;
-
- *)
- >&2
- echo "$1: unknown option"
- echo
- print_usage
- exit 1
- ;;
- esac
-
- shift
-done
-
-if [ ! -f kernel ]; then
- echo "File 'kernel' containing kernel version not found in current directory"
- exit 1
-fi
-
-echo "Looking for kernel package"
-kernel_version="$( sed 's/ .*//' kernel )"
-
-package="$( rpm --root $ROOT -qf "/boot/vmlinuz-$kernel_version" )"
-if [ $? != 0 ]; then
- echo "Can't find kernel package corresponding to '$kernel_version'"
- echo "Can't record package version data (pkg_version, pkg_release, ...)."
- exit 1
-fi
-
-echo "Kernel package $package found"
-rpm --root $ROOT -q --qf "%{name}\n" "$package" > pkg_name
-rpm --root $ROOT -q --qf "%{arch}\n" "$package" > pkg_arch
-rpm --root $ROOT -q --qf "%{version}\n" "$package" > pkg_version
-rpm --root $ROOT -q --qf "%{release}\n" "$package" > pkg_release
-epoch="$( rpm --root $ROOT -q --qf "%{epoch}" "$package" )"
-test "$epoch" = "(none)" && epoch=0
-echo "$epoch" > pkg_epoch
diff --git a/src/plugins/koops_event.conf b/src/plugins/koops_event.conf
index df7e446..f273ba2 100644
--- a/src/plugins/koops_event.conf
+++ b/src/plugins/koops_event.conf
@@ -16,8 +16,7 @@ EVENT=post-create type=Kerneloops remote!=1
if test ! -f uuid -a ! -f duphash; then
abrt-action-analyze-oops || exit 1
fi
- } &&
- abrt-action-save-kernel-data
+ }
# If you want behavior similar to one provided by kerneloops daemon
diff --git a/src/plugins/vmcore_event.conf b/src/plugins/vmcore_event.conf
index ae4dc9f..61bc9d1 100644
--- a/src/plugins/vmcore_event.conf
+++ b/src/plugins/vmcore_event.conf
@@ -34,7 +34,7 @@ EVENT=post-create type=vmcore remote!=1
# analyze
EVENT=analyze_VMcore type=vmcore
abrt-action-analyze-oops &&
- abrt-action-save-kernel-data
+ abrt-action-save-package-data
# If you want behavior similar to one provided by kerneloops daemon
# distributed by kerneloops.org - that is, if you want
--
2.7.4

View file

@ -1,28 +0,0 @@
From 293f42b82ef4ac23b8d5327d32697f7308c3f76b Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 26 Apr 2016 08:18:36 +0200
Subject: [PATCH] a-retrace-client: format security
https://github.com/pld-linux/abrt/blob/d3f5b5cc7b5d86f4a4912d980a99d4c90024440d/format_security.patch
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-retrace-client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/plugins/abrt-retrace-client.c b/src/plugins/abrt-retrace-client.c
index 540cdc9..ae5ef83 100644
--- a/src/plugins/abrt-retrace-client.c
+++ b/src/plugins/abrt-retrace-client.c
@@ -760,7 +760,7 @@ static int create(bool delete_temp_archive,
if (response_code == 500 || response_code == 507)
{
alert_server_error(cfg.url);
- error_msg_and_die(http_body);
+ error_msg_and_die("%s", http_body);
}
else if (response_code == 403)
{
--
2.7.4

View file

@ -1,25 +0,0 @@
From 553bd2b7842a1f23510f4083b7a4762396381edb Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Tue, 26 Apr 2016 08:24:13 +0200
Subject: [PATCH] a-console-notification: do not leak variables
https://github.com/pld-linux/abrt/blob/adb4721f7f60f7c00f7f5e4f5f382207636140f3/profile.sh.patch
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/cli/abrt-console-notification.sh | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/cli/abrt-console-notification.sh b/src/cli/abrt-console-notification.sh
index a98f164..f1a79ff 100755
--- a/src/cli/abrt-console-notification.sh
+++ b/src/cli/abrt-console-notification.sh
@@ -40,3 +40,5 @@ if [ -f "$TMPPATH" ]; then
fi
timeout 10s abrt-cli status --since="$SINCE" 2>"$ABRT_DEBUG_LOG" || echo "'abrt-cli status' timed out"
+
+unset ABRT_DEBUG_LOG LPATHDIR SINCEFILE TMPPATH SINCE
--
2.7.4

View file

@ -1,64 +0,0 @@
From 16a8cbb75b69c36b7858004d605c24edc6806763 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 27 Apr 2016 09:36:10 +0200
Subject: [PATCH] a-a-install-debuginfo: correct handling of DebuginfoLocation
DebuginfoLocation is a list of colon separated file systemd paths, where
the first path is a directory for storing downloaded debuginfo data.
Related #1135
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/hooks/CCpp.conf | 10 +++++++++-
src/plugins/abrt-action-install-debuginfo.in | 6 ++++--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/src/hooks/CCpp.conf b/src/hooks/CCpp.conf
index 025189a..2466aff 100644
--- a/src/hooks/CCpp.conf
+++ b/src/hooks/CCpp.conf
@@ -31,7 +31,15 @@ SaveFullCore = yes
# Used for debugging the hook
#VerboseLog = 2
-# Specify where you want to store debuginfos (default: /var/cache/abrt-di)
+# Specify directories where ABRT should look for non-system debuginfos.
+#
+# Add a colon separated list of file system paths.
+#
+# Beware the first path in the list is used by ABRT to save downloaded
+# debuginfos, therefore the first path in the list must be _writable_, the
+# rest of the list can be read-only.
+#
+# (default: /var/cache/abrt-di)
#
#DebuginfoLocation = /var/cache/abrt-di
diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index e4a7dfd..ad7a8d3 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -100,7 +100,9 @@ if __name__ == "__main__":
" -y Noninteractive, assume 'Yes' to all questions\n"
" --ids Default: build_ids\n"
" --tmpdir Default: @LARGE_DATA_TMP_DIR@/abrt-tmp-debuginfo-RANDOM_SUFFIX\n"
- " --cache Default: /var/cache/abrt-di\n"
+ " --cache Colon separated list of directories. The first one is used for\n"
+ " saving installed debuginfos.\n"
+ " Default: /var/cache/abrt-dir\n"
" --size_mb Default: 4096\n"
" --pkgmgr Default: PackageManager from CCpp.conf or 'dnf'\n"
" -e,--exact Download only specified files\n"
@@ -155,7 +157,7 @@ if __name__ == "__main__":
except OSError as ex:
print(ex)
else:
- cachedirs = conf.get("DebuginfoLocation", None)
+ cachedirs = conf.get("DebuginfoLocation", None).split(":")
if not cachedirs:
cachedirs = ["/var/cache/abrt-di"]
--
2.7.4

View file

@ -1,74 +0,0 @@
From 9cfcc3a1417e8d7730312ecd4f3d16a01cffe5ef Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Fri, 29 Apr 2016 13:29:56 +0200
Subject: [PATCH] doc: improve documentation of AllowedGroups, AllowedUsers and
IgnoredPaths
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
doc/abrt-CCpp.conf.txt | 10 ++++++----
src/hooks/CCpp.conf | 14 +++++++++++---
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/doc/abrt-CCpp.conf.txt b/doc/abrt-CCpp.conf.txt
index b05aefc..bcefc4d 100644
--- a/doc/abrt-CCpp.conf.txt
+++ b/doc/abrt-CCpp.conf.txt
@@ -42,18 +42,20 @@ SaveFullCore = 'yes' / 'no' ...::
Default is 'yes'.
IgnoredPaths = /path/to/ignore/*, */another/ignored/path* ...::
- ABRT will ignore crashes in executables whose absolute path matches one of
- specified patterns.
+ ABRT will ignore crashes in executables whose absolute path matches
+ any of the glob patterns listed in the comma separated list.
-AllowedUsers = root, ...::
+AllowedUsers = root, wheel, ...::
ABRT will process only crashes of either allowed users 'AllowedUsers' or
users who are members of allowed group 'AllowedGroups'. If no allowed users
nor allowed group are specified ABRT will process crashes of all users.
+ 'AllowedUsers' is a comma separated list.
-AllowedGroups = root, ...::
+AllowedGroups = root, wheel, ...::
ABRT will process only crashes of either allowed users 'AllowedUsers' or
users who are members of allowed group 'AllowedGroups'. If no allowed users
nor allowed group are specified ABRT will process crashes of all users.
+ 'AllowedGroups' is a comma separated list.
VerboseLog = NUM::
Used to make the hook more verbose
diff --git a/src/hooks/CCpp.conf b/src/hooks/CCpp.conf
index 2466aff..82c6b78 100644
--- a/src/hooks/CCpp.conf
+++ b/src/hooks/CCpp.conf
@@ -58,14 +58,22 @@ SaveFullCore = yes
#
# StandaloneHook = yes
-# ABRT will ignore crashes in executables whose absolute path matches one of
-# specified patterns.
+# ABRT will ignore crashes in executables whose absolute path matches
+# one of any of the glob patterns listed in the comma separated list.
+#
+# For example:
+# IgnoredPaths = /path/to/ignore/*, */another/ignored/path*
#
#IgnoredPaths =
# ABRT will process only crashes of either allowed users or users who are
# members of allowed group. If no allowed users nor allowed group are specified
-# ABRT will process crashes of all users.
+# ABRT will process crashes of all users. Both AllowedUsers and AllowedGroups
+# are a comma sepparated list.
+#
+# For example:
+# AllowedUsers = root, wheel, ...
+# AllowedGroups = root, wheel, ...
#
#AllowedUsers =
#AllowedGroups =
--
2.7.4

View file

@ -1,39 +0,0 @@
From ec20077b4a1ddc3fbd7c3d91c10712f15e312777 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Fri, 13 May 2016 13:31:35 +0200
Subject: [PATCH] a-a-install-debuginfo: do not try to split None
Bug introduced in commit bb653b71a9261c0b58a9256761bf034b24c2e1ad
Related #1135
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/plugins/abrt-action-install-debuginfo.in | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index ad7a8d3..a3ef3da 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -152,15 +152,14 @@ if __name__ == "__main__":
set_verbosity(verbose)
if not cachedirs:
+ cachedirs = ["/var/cache/abrt-di"]
try:
conf = problem.load_plugin_conf_file("CCpp.conf")
except OSError as ex:
print(ex)
else:
- cachedirs = conf.get("DebuginfoLocation", None).split(":")
+ cachedirs = conf.get("DebuginfoLocation", cachedirs[0]).split(":")
- if not cachedirs:
- cachedirs = ["/var/cache/abrt-di"]
if not TMPDIR:
# security people prefer temp subdirs in app's private dir, like /var/run/abrt
# and we switched to /tmp but Fedora feature tmp-on-tmpfs appeared, hence we must
--
2.7.4

View file

@ -1,57 +0,0 @@
From 8b0a7a0c8dd7df477c3408298aa1f7126799da65 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Tue, 17 May 2016 12:13:00 +0200
Subject: [PATCH] a-dump-journal-xorg: add '_COMM=gnome-shell' to journal
filter
'/usr/bin/Xwayland' crashes from gnome-shell are logged to journal with
'_COMM=gnome-shell'.
In case ABRT cannot get executable from journal backtrace (path to binary file
containting substring "bin/X") the default one /usr/bin/X(org) is used instead.
It means if wayland crashes and /usr/bin/Xwayland is not mentioned in
backtrace, the executable is /usr/bin/X(org) even it is a wayland crash.
Tried to figure out how to find out if it is a wayland or xorg crash with
wayland guys on irc and they said there is no easy and reasonable way how to
achieve this.
Because the /usr/bin/Xwayland and the /usr/bin/Xorg executable are placed under
the same xorg-x11-server bugzilla component I decided no to change the default
executable. Also all wayland backtraces I've seen contained /usr/bin/Xwayland
executable so the right executable was used.
Related to: #1336618
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/plugins/xorg-utils.c | 2 +-
src/plugins/xorg.conf | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/xorg-utils.c b/src/plugins/xorg-utils.c
index 8f121f8..6039acd 100644
--- a/src/plugins/xorg-utils.c
+++ b/src/plugins/xorg-utils.c
@@ -21,7 +21,7 @@
*/
#define IGNORE_RESULT(func_call) do { if (func_call) /* nothing */; } while (0)
-#define DEFAULT_XORG_CRASH_REASON "Xorg server crashed"
+#define DEFAULT_XORG_CRASH_REASON "Display server crashed"
int abrt_xorg_signaled_sleep(int seconds)
{
diff --git a/src/plugins/xorg.conf b/src/plugins/xorg.conf
index 28f3ee1..8834e23 100644
--- a/src/plugins/xorg.conf
+++ b/src/plugins/xorg.conf
@@ -4,4 +4,4 @@
BlacklistedXorgModules = nvidia, fglrx, vboxvideo
# List of filters which is used for searching Xorg crashes in jounral
-JournalFilters = _COMM=gdm-x-session
+JournalFilters = _COMM=gdm-x-session, _COMM=gnome-shell
--
2.7.4

View file

@ -1,38 +0,0 @@
From 19863406cee41c1f806397173d04701b21e65478 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Fri, 20 May 2016 15:50:05 +0200
Subject: [PATCH] a-dump-journal-xorg: allow *libexec/X* to be executable
element
Analyzed lot of xorg backtraces extracted from journal by ABRT and figured out
almost all crashes are from '/usr/libexec/Xorg' executable but default
executable /usr/bin/X(org) is wrongly used instead.
The rest of backtaces contain the substring 'bin/X' hence the
executable is determined right.
Allow executable element with "libexec/X" substring should limit using the
default executable wrongly.
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/plugins/xorg-utils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/plugins/xorg-utils.c b/src/plugins/xorg-utils.c
index 6039acd..a8dfc51 100644
--- a/src/plugins/xorg-utils.c
+++ b/src/plugins/xorg-utils.c
@@ -224,8 +224,8 @@ struct xorg_crash_info *process_xorg_bt(char *(*get_next_line)(void *), void *da
char *filename_end = skip_non_whitespace(filename);
char sv = *filename_end;
*filename_end = '\0';
- /* Does it look like "[/usr]/[s]bin/Xfoo"? */
- if (strstr(filename, "bin/X"))
+ /* Does it look like "[/usr]/[s]bin/Xfoo" or [/usr]/libexec/Xfoo"? */
+ if (strstr(filename, "bin/X") || strstr(filename, "libexec/X"))
exe = xstrdup(filename);
*filename_end = sv;
}
--
2.7.4

View file

@ -1,48 +0,0 @@
From 5c011b291a65f88036884bf388859e68fe7162a9 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Thu, 26 May 2016 10:15:07 +0200
Subject: [PATCH] abrt-hook-ccpp: save get_fsuid() return values in int
variables
int because get_fsuid() returns negative values in case of error
Revealed by coverity.
Related to: #1337186
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/hooks/abrt-hook-ccpp.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
index dfe9526..10f137b 100644
--- a/src/hooks/abrt-hook-ccpp.c
+++ b/src/hooks/abrt-hook-ccpp.c
@@ -725,7 +725,8 @@ int main(int argc, char** argv)
char *proc_pid_status = xmalloc_xopen_read_close(path, /*maxsz:*/ NULL);
uid_t fsuid = uid;
- uid_t tmp_fsuid = get_fsuid(proc_pid_status);
+ /* int because get_fsuid() returns negative values in case of error */
+ int tmp_fsuid = get_fsuid(proc_pid_status);
if (tmp_fsuid < 0)
{
error_msg_ignore_crash(pid_str, NULL, (long unsigned)uid, signal_no,
@@ -742,12 +743,12 @@ int main(int argc, char** argv)
}
int suid_policy = dump_suid_policy();
- if (tmp_fsuid != uid)
+ if ((uid_t)tmp_fsuid != uid)
{
/* use root for suided apps unless it's explicitly set to UNSAFE */
fsuid = 0;
if (suid_policy == DUMP_SUID_UNSAFE)
- fsuid = tmp_fsuid;
+ fsuid = (uid_t)tmp_fsuid;
else
{
g_user_core_flags = O_EXCL;
--
2.7.4

View file

@ -1,65 +0,0 @@
From f55250179f7ca74ae0a80ec0c4f6cf3bb341b5df Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Wed, 25 May 2016 13:35:28 +0200
Subject: [PATCH] koops: do not assume version has 3 levels
Correct commit 9023d77ad5539433146b59e5ac80e3cefcb20cf7
Some ancient kernel versions have 4 levels. This commit allows version
string to have any level equal or greater than 3. The first 3 levels
must be numbers and the rest can be almost anything - it just must
follow the logical structure of levels (i.e. dot something dot
something) - this should allow a git hash in the version string.
In order to eliminate possible false positives introduced by the
flexibility of version levels the commit adds checks for
the prefixes ' ', '(' or 'kernel-' and the suffix ' #' or ') #'.
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
src/lib/kernel.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/src/lib/kernel.c b/src/lib/kernel.c
index dde3d28..720dc7d 100644
--- a/src/lib/kernel.c
+++ b/src/lib/kernel.c
@@ -571,7 +571,10 @@ char *koops_extract_version(const char *linepointer)
|| strstr(linepointer, "REGS")
|| strstr(linepointer, "EFLAGS")
) {
- const char *regexp = "([0-9]+\\.[0-9]+\\.[0-9]+-[^ \\)]+)[ \\)]";
+ /* "(4.7.0-2.x86_64.fc25) #" */
+ /* " 4.7.0-2.x86_64.fc25 #" */
+ /* " 2.6.3.4.5-2.x86_64.fc22 #" */
+ const char *regexp = "([ \\(]|kernel-)([0-9]+\\.[0-9]+\\.[0-9]+(\\.[^.-]+)*-[^ \\)]+)\\)? #";
regex_t re;
int r = regcomp(&re, regexp, REG_EXTENDED);
if (r != 0)
@@ -582,8 +585,8 @@ char *koops_extract_version(const char *linepointer)
return NULL;
}
- regmatch_t matchptr[2];
- r = regexec(&re, linepointer, 2, matchptr, 0);
+ regmatch_t matchptr[3];
+ r = regexec(&re, linepointer, sizeof(matchptr)/sizeof(matchptr[0]), matchptr, 0);
if (r != 0)
{
if (r != REG_NOMATCH)
@@ -602,7 +605,11 @@ char *koops_extract_version(const char *linepointer)
return NULL;
}
- char *ret = xstrndup(linepointer + matchptr[1].rm_so, matchptr[1].rm_eo - matchptr[1].rm_so);
+ /* 0: entire string */
+ /* 1: version prefix */
+ /* 2: version string */
+ const regmatch_t *const ver = matchptr + 2;
+ char *ret = xstrndup(linepointer + ver->rm_so, ver->rm_eo - ver->rm_so);
regfree(&re);
return ret;
--
2.7.4

View file

@ -1,39 +0,0 @@
From a2bdf944c8855dd53b4df5f6829442f9f2f6bd14 Mon Sep 17 00:00:00 2001
From: Matej Habrnal <mhabrnal@redhat.com>
Date: Wed, 8 Jun 2016 17:50:18 +0200
Subject: [PATCH] a-a-install-debuginfo: Exception may not have an argument
errno
Also BrokenPipe error can appear even in download_class(), moving it to try
block.
Related to #1343826, #1343664
Signed-off-by: Matej Habrnal <mhabrnal@redhat.com>
---
src/plugins/abrt-action-install-debuginfo.in | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/plugins/abrt-action-install-debuginfo.in b/src/plugins/abrt-action-install-debuginfo.in
index a3ef3da..be45bc6 100644
--- a/src/plugins/abrt-action-install-debuginfo.in
+++ b/src/plugins/abrt-action-install-debuginfo.in
@@ -236,12 +236,12 @@ if __name__ == "__main__":
sys.exit(RETURN_FAILURE)
# TODO: should we pass keep_rpms=keeprpms to DebugInfoDownload here??
- downloader = download_class(cache=cachedirs[0], tmp=TMPDIR,
+ try:
+ downloader = download_class(cache=cachedirs[0], tmp=TMPDIR,
noninteractive=noninteractive,
repo_pattern=repo_pattern)
- try:
result = downloader.download(missing, download_exact_files=exact_fls)
- except Exception as ex:
+ except OSError as ex:
if ex.errno == errno.EPIPE:
clean_up(TMPDIR, silent=True)
exit(RETURN_FAILURE)
--
2.7.4

View file

@ -1,91 +0,0 @@
From 57c975dfda165098502cdb9e2525bc7877301a12 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Mon, 13 Jun 2016 09:43:21 +0200
Subject: [PATCH] vmcore: fix finding partitions by UUID and LABEL
In kdump.conf fs partition can be specified by UUID or LABEL but mtab
uses only file system node path. Hence, we need to translate the ID to
its node path.
Related: rhbz#1147053
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
configure.ac | 2 ++
src/hooks/Makefile.am | 1 +
src/hooks/abrt_harvest_vmcore.py.in | 27 +++++++++++++++++++++++++++
3 files changed, 30 insertions(+)
diff --git a/configure.ac b/configure.ac
index 98e2564..8e13524 100644
--- a/configure.ac
+++ b/configure.ac
@@ -263,6 +263,8 @@ AC_ARG_ENABLE(doxygen-docs,
[enable_doxygen_docs=no]
)
+AC_PATH_PROG([BLKID], [BLKID], [/usr/sbin/blkid], [$PATH:/usr/sbin:/sbin])
+
# Doxygen Documentation
AC_PATH_PROG(DOXYGEN, doxygen, no)
diff --git a/src/hooks/Makefile.am b/src/hooks/Makefile.am
index bf68994..c0255d9 100644
--- a/src/hooks/Makefile.am
+++ b/src/hooks/Makefile.am
@@ -119,6 +119,7 @@ abrt-install-ccpp-hook: abrt-install-ccpp-hook.in
abrt-harvest-vmcore: abrt_harvest_vmcore.py.in
sed -e s,\@CONF_DIR\@,\$(CONF_DIR)\,g \
-e s,\@DEFAULT_DUMP_LOCATION\@,$(DEFAULT_DUMP_LOCATION),g \
+ -e s,\@BLKID\@,$(BLKID),g \
$< >$@
abrt-harvest-pstoreoops: abrt-harvest-pstoreoops.in
diff --git a/src/hooks/abrt_harvest_vmcore.py.in b/src/hooks/abrt_harvest_vmcore.py.in
index 61a6e57..ab976dc 100644
--- a/src/hooks/abrt_harvest_vmcore.py.in
+++ b/src/hooks/abrt_harvest_vmcore.py.in
@@ -13,6 +13,7 @@ import shutil
import time
import hashlib
import augeas
+from subprocess import Popen, PIPE
import problem
import report
@@ -38,6 +39,32 @@ def get_mount_point(part_id):
part_id - device node, label or uuid
"""
+ idtypes = {"UUID=":"-U", "PARTUUID=":"-U", "LABEL=":"-L", "PARTLABEL=":"-L"}
+
+ for typ, switch in idtypes.items():
+ if not part_id.startswith(typ):
+ continue
+
+ idf = part_id[len(typ):]
+ try:
+ proc = Popen(["@BLKID@", switch, idf], stdout=PIPE, stderr=PIPE)
+ out, err = proc.communicate()
+ if err:
+ sys.stderr.write("Failed 'blkid {0} {1}': {2}\n"
+ .format(switch, idf, err))
+ sys.exit(1)
+ if not out:
+ sys.stderr.write("No results from 'blkid {0} {1}'\n"
+ .format(switch, idf))
+ sys.exit(1)
+
+ part_id = out.decode().strip()
+ break
+ except OSError as ex:
+ sys.stderr.write("Cannot run 'blkid {0} {1}': {2}\n"
+ .format(switch, idf, str(ex)))
+ sys.exit(1)
+
# look up the identifier in /etc/mtab
result = get_augeas("Fstab", "/etc/mtab").get("/files/etc/mtab/*"
"[spec=\"" + part_id + "\"]/file")
--
2.7.4

View file

@ -1,130 +0,0 @@
From 0fcf4fdd56970ca333f36d7fcfda2d6ecb14c8f2 Mon Sep 17 00:00:00 2001
From: Jakub Filak <jfilak@redhat.com>
Date: Thu, 16 Jun 2016 14:21:28 +0200
Subject: [PATCH] vmcore: use findmnt to get mountpoint
findmnt solves both problems:
* UUID=/LABEL=
* different device links
Related: rhbz#1147053
Signed-off-by: Jakub Filak <jfilak@redhat.com>
---
configure.ac | 2 +-
src/hooks/Makefile.am | 2 +-
src/hooks/abrt_harvest_vmcore.py.in | 59 ++++++++++++++-----------------------
3 files changed, 24 insertions(+), 39 deletions(-)
diff --git a/configure.ac b/configure.ac
index 8e13524..98fbebc 100644
--- a/configure.ac
+++ b/configure.ac
@@ -263,7 +263,7 @@ AC_ARG_ENABLE(doxygen-docs,
[enable_doxygen_docs=no]
)
-AC_PATH_PROG([BLKID], [BLKID], [/usr/sbin/blkid], [$PATH:/usr/sbin:/sbin])
+AC_PATH_PROG([FINDMNT], [findmnt], [/usr/bin/findmnt], [$PATH:/usr/sbin:/sbin])
# Doxygen Documentation
diff --git a/src/hooks/Makefile.am b/src/hooks/Makefile.am
index c0255d9..8e73bdc 100644
--- a/src/hooks/Makefile.am
+++ b/src/hooks/Makefile.am
@@ -119,7 +119,7 @@ abrt-install-ccpp-hook: abrt-install-ccpp-hook.in
abrt-harvest-vmcore: abrt_harvest_vmcore.py.in
sed -e s,\@CONF_DIR\@,\$(CONF_DIR)\,g \
-e s,\@DEFAULT_DUMP_LOCATION\@,$(DEFAULT_DUMP_LOCATION),g \
- -e s,\@BLKID\@,$(BLKID),g \
+ -e s,\@FINDMNT\@,$(FINDMNT),g \
$< >$@
abrt-harvest-pstoreoops: abrt-harvest-pstoreoops.in
diff --git a/src/hooks/abrt_harvest_vmcore.py.in b/src/hooks/abrt_harvest_vmcore.py.in
index ab976dc..1cceea7 100644
--- a/src/hooks/abrt_harvest_vmcore.py.in
+++ b/src/hooks/abrt_harvest_vmcore.py.in
@@ -19,6 +19,12 @@ import problem
import report
+def errx(message, code=1):
+ sys.stderr.write(message)
+ sys.stderr.write("\n")
+ sys.stderr.flush()
+ sys.exit(code)
+
def get_augeas(module, file_path):
"""
A function for efficient configuration of Augeas.
@@ -33,49 +39,28 @@ def get_augeas(module, file_path):
def get_mount_point(part_id):
"""
- A function used to look up a mount point in mtab using
- the provided identifier.
+ A function used to look up a mount point of the provided identifier
+ using 'findmnt' system utility.
part_id - device node, label or uuid
"""
- idtypes = {"UUID=":"-U", "PARTUUID=":"-U", "LABEL=":"-L", "PARTLABEL=":"-L"}
-
- for typ, switch in idtypes.items():
- if not part_id.startswith(typ):
- continue
-
- idf = part_id[len(typ):]
- try:
- proc = Popen(["@BLKID@", switch, idf], stdout=PIPE, stderr=PIPE)
- out, err = proc.communicate()
- if err:
- sys.stderr.write("Failed 'blkid {0} {1}': {2}\n"
- .format(switch, idf, err))
- sys.exit(1)
- if not out:
- sys.stderr.write("No results from 'blkid {0} {1}'\n"
- .format(switch, idf))
- sys.exit(1)
-
- part_id = out.decode().strip()
- break
- except OSError as ex:
- sys.stderr.write("Cannot run 'blkid {0} {1}': {2}\n"
- .format(switch, idf, str(ex)))
- sys.exit(1)
+ try:
+ proc = Popen(["@FINDMNT@", "--noheadings", "--first-only", "--raw",
+ "--evaluate", "--output", "TARGET", part_id],
+ stdout=PIPE, stderr=PIPE)
+ out, err = proc.communicate()
+ if err:
+ errx("Error finding mountpoint of '{0}': {1}"
+ .format(devpath, err.decode()))
+
+ result = out.decode().strip()
+ if proc.returncode != 0 or not result:
+ errx("Cannot find mountpoint of '{0}'".format(part_id))
- # look up the identifier in /etc/mtab
- result = get_augeas("Fstab", "/etc/mtab").get("/files/etc/mtab/*"
- "[spec=\"" + part_id + "\"]/file")
- if result:
return result
- else:
- # identifier not in the table
- sys.stderr.write("Error: Cannot access partition '" + part_id +
- "', mount point not found in /etc/mtab!\n")
- sys.exit(1)
-
+ except OSError as ex:
+ errx("Cannot run 'findmnt': {1}".format(str(ex)))
def parse_kdump():
"""
--
2.7.4

View file

@ -1,28 +0,0 @@
From 5122aef69fb303022609dc6ca53a11e30842ad6e Mon Sep 17 00:00:00 2001
From: Wes Lindauer <wesley.lindauer@gmail.com>
Date: Wed, 13 Jul 2016 16:20:51 -0400
Subject: [PATCH] abrt-hook-ccpp: Fix mismatching argument
The calling code in abrt-install-ccpp-hook was passing in --test-config.
This was only working due to the misuse of strcmp, so it was accepting
any string other than --config-test.
---
src/hooks/abrt-hook-ccpp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/hooks/abrt-hook-ccpp.c b/src/hooks/abrt-hook-ccpp.c
index 10f137b..9e82ff9 100644
--- a/src/hooks/abrt-hook-ccpp.c
+++ b/src/hooks/abrt-hook-ccpp.c
@@ -656,7 +656,7 @@ int main(int argc, char** argv)
free_map_string(settings);
}
- if (argc == 2 && strcmp(argv[1], "--config-test"))
+ if (argc == 2 && !strcmp(argv[1], "--test-config"))
return test_configuration(setting_SaveFullCore, setting_CreateCoreBacktrace);
if (argc < 8)
--
2.7.4

File diff suppressed because it is too large Load diff

3572
abrt.spec

File diff suppressed because it is too large Load diff

15
gating.yaml Normal file
View file

@ -0,0 +1,15 @@
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_testing
subject_type: koji_build
rules:
- !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}
--- !Policy
product_versions:
- fedora-*
decision_context: bodhi_update_push_stable
subject_type: koji_build
rules:
- !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}

View file

@ -1 +1 @@
ab0744ee52a36c0d647ae1af9a356090 abrt-2.8.0.tar.gz
SHA512 (abrt-2.17.8.tar.gz) = 90b74229412e0186bfa109ee940a60c9f3c0f7ce8c1216acad6f05619a1bb591e7f0bae87363143a05034312c9f14fe5ace341b84f680780ceb93a1e624705b3

10
tests/smoke.fmf Normal file
View file

@ -0,0 +1,10 @@
summary: Basic smoke test for abrt
prepare:
how: install
# Do not attempt to install conflicting subpackages.
exclude:
- abrt-atomic
- abrt-java-connector-container
- python3-abrt-container-addon
execute:
script: abrt-action-notify --help