38 lines
1.2 KiB
Diff
38 lines
1.2 KiB
Diff
From 2bbe75fe0bc87ab4c1e16c5a18c6200224391629 Mon Sep 17 00:00:00 2001
|
|
From: Nicole Patricia Mazzuca <nicole@streganil.no>
|
|
Date: Fri, 9 May 2025 09:32:21 +0200
|
|
Subject: [PATCH aerc] open: fix opening text/html messages
|
|
|
|
This fixes a bug introduced in 93bec0de8ed5ab3d6b1f01026fe2ef20fa154329:
|
|
aerc started using `path.Base(<part>)`, which returns `"."` on an empty
|
|
path, but still checked for `""` two lines later.
|
|
|
|
On macOS, the result is that aerc attempts to open the directory:
|
|
|
|
```
|
|
open /var/folders/vn/hs0zvdsx3vq6svvry8s1bnym0000gn/T/aerc-4229266673: is a directory
|
|
```
|
|
|
|
Signed-off-by: Nicole Patricia Mazzuca <nicole@streganil.no>
|
|
Acked-by: Robin Jarry <robin@jarry.cc>
|
|
---
|
|
|
|
commands/msgview/open.go | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/commands/msgview/open.go b/commands/msgview/open.go
|
|
index a6e43cb8da5f..7c770d4a90b7 100644
|
|
--- a/commands/msgview/open.go
|
|
+++ b/commands/msgview/open.go
|
|
@@ -59,7 +59,7 @@ func (o Open) Execute(args []string) error {
|
|
}
|
|
filename := path.Base(part.FileName())
|
|
var tmpFile *os.File
|
|
- if filename == "" {
|
|
+ if filename == "." {
|
|
extension := ""
|
|
if exts, _ := mime.ExtensionsByType(mimeType); len(exts) > 0 {
|
|
extension = exts[0]
|
|
--
|
|
2.49.0
|
|
|