From ea8fffd2986ff6ee80f3f727d6481f11c877457a Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 21 Jul 2021 12:24:45 +0000 Subject: [PATCH 01/23] - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild Signed-off-by: Fedora Release Engineering From 1631f83835fb4e72c3bf8859f95f2e0dff869a0f Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 21 Jul 2021 17:20:04 +0000 Subject: [PATCH 02/23] - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index a40426d..fcbb4d5 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 35%{?dist} +Release: 36%{?dist} Summary: Apple Filing Protocol client # by default build with the fuse module @@ -105,6 +105,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %changelog +* Wed Jul 21 2021 Fedora Release Engineering - 0.8.1-36 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + * Mon Apr 26 2021 Michal Ambroz - 0.8.1-35 - modernize spec, push the bugfix to active branches From f3d7f8100094ad33fb823d7db7e3fbe30c689d20 Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Mon, 15 Nov 2021 11:37:21 +0000 Subject: [PATCH 03/23] aarch64 - allow standard paths in rpath check --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index fcbb4d5..988ffad 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -3,6 +3,7 @@ Version: 0.8.1 Release: 36%{?dist} Summary: Apple Filing Protocol client + # by default build with the fuse module # rpmbuild --rebuild afpfs-ng.src.rpm --without fuse %bcond_without fuse @@ -46,7 +47,6 @@ Requires: %{name} = %{version} %description devel Library for dynamic linking and header files of afpfs-ng. - %prep %autosetup -p 1 @@ -64,6 +64,9 @@ make %{?_smp_mflags} %install +%ifarch aarch64 + export QA_RPATHS=1 +%endif make install DESTDIR=%{buildroot} install -d %{buildroot}%{_includedir}/afpfs-ng cp -p include/* %{buildroot}%{_includedir}/afpfs-ng From 8c43961472c0dd72ed7b9ba2a9e276219a2a0394 Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Mon, 15 Nov 2021 12:07:30 +0000 Subject: [PATCH 04/23] adding comment --- afpfs-ng.spec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 988ffad..ea4d757 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -64,9 +64,12 @@ make %{?_smp_mflags} %install +# setting RPATH for aarch64 ends-up bit different than for other platforms +# https://bugzilla.redhat.com/show_bug.cgi?id=1987362 %ifarch aarch64 export QA_RPATHS=1 %endif + make install DESTDIR=%{buildroot} install -d %{buildroot}%{_includedir}/afpfs-ng cp -p include/* %{buildroot}%{_includedir}/afpfs-ng From 386755bce67fd6f77abb68c572b09cb9d1f04c88 Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Thu, 18 Nov 2021 08:50:37 +0000 Subject: [PATCH 05/23] update the embedded libtool --- afpfs-ng.spec | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index ea4d757..0ce122c 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 36%{?dist} +Release: 37%{?dist} Summary: Apple Filing Protocol client @@ -19,9 +19,12 @@ Patch2: afpfs-ng-0.8.1-formatsec.patch Patch3: afpfs-ng-0.8.1-longoptions.patch %{?with_fuse:BuildRequires: fuse-devel} -BuildRequires: gcc +BuildRequires: gcc BuildRequires: libgcrypt-devel gmp-devel readline-devel BuildRequires: make +BuildRequires: libtool +BuildRequires: autoconf + %description A command line client to access files exported from Mac OS system via @@ -49,7 +52,8 @@ Library for dynamic linking and header files of afpfs-ng. %prep %autosetup -p 1 - +libtoolize +autoreconf %build # make would rebuild the autoconf infrastructure due to the following: @@ -64,12 +68,6 @@ make %{?_smp_mflags} %install -# setting RPATH for aarch64 ends-up bit different than for other platforms -# https://bugzilla.redhat.com/show_bug.cgi?id=1987362 -%ifarch aarch64 - export QA_RPATHS=1 -%endif - make install DESTDIR=%{buildroot} install -d %{buildroot}%{_includedir}/afpfs-ng cp -p include/* %{buildroot}%{_includedir}/afpfs-ng @@ -111,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %changelog +* Wed Nov 17 2021 Michal Ambroz - 0.8.1-37 +- update embedded libtool (ltmain.sh) + * Wed Jul 21 2021 Fedora Release Engineering - 0.8.1-36 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild From 2acdcb90672bbae12fdbd33a34f696f3772d308b Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 19 Jan 2022 21:00:19 +0000 Subject: [PATCH 06/23] - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 0ce122c..b5f00be 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 37%{?dist} +Release: 38%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %changelog +* Wed Jan 19 2022 Fedora Release Engineering - 0.8.1-38 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + * Wed Nov 17 2021 Michal Ambroz - 0.8.1-37 - update embedded libtool (ltmain.sh) From d05d8abe32005ad1ce76f74a10f42f10a8f0c0fd Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 20 Jul 2022 20:31:21 +0000 Subject: [PATCH 07/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index b5f00be..f8e22c3 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 38%{?dist} +Release: 39%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %changelog +* Wed Jul 20 2022 Fedora Release Engineering - 0.8.1-39 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + * Wed Jan 19 2022 Fedora Release Engineering - 0.8.1-38 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild From 2014cb6054341e44156241ff94a71820bcc90955 Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Mon, 24 Oct 2022 14:29:32 +0200 Subject: [PATCH 08/23] cosmetics --- afpfs-ng.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index f8e22c3..0726769 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -85,7 +85,7 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_mandir}/man1/afpcmd.1* %{_mandir}/man1/afpgetstatus.1* %{_libdir}/libafpclient.so.* -%exclude %{_libdir}/*.la +# %%exclude %%{_libdir}/*.la %doc AUTHORS ChangeLog docs/README docs/performance docs/FEATURES.txt docs/REPORTING-BUGS.txt From 4396979d2215e37334fa5a6b380187af7b6f43bf Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Tue, 25 Oct 2022 11:30:36 +0200 Subject: [PATCH 09/23] delete explicitly the libtool .la file --- afpfs-ng.spec | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 0726769..6667004 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 39%{?dist} +Release: 40%{?dist} Summary: Apple Filing Protocol client @@ -68,10 +68,11 @@ make %{?_smp_mflags} %install -make install DESTDIR=%{buildroot} +%make_install install -d %{buildroot}%{_includedir}/afpfs-ng cp -p include/* %{buildroot}%{_includedir}/afpfs-ng - +# libtool .la file works different in different versions of libtool, should not be packaged +[ -f %{buildroot}%{_libdir}/libafpclient.la ] && rm -f %{buildroot}%{_libdir}/libafpclient.la %if ( 0%{?rhel} && 0%{?rhel} <= 7 ) %ldconfig_scriptlets @@ -85,7 +86,6 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_mandir}/man1/afpcmd.1* %{_mandir}/man1/afpgetstatus.1* %{_libdir}/libafpclient.so.* -# %%exclude %%{_libdir}/*.la %doc AUTHORS ChangeLog docs/README docs/performance docs/FEATURES.txt docs/REPORTING-BUGS.txt @@ -107,8 +107,10 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_includedir}/afpfs-ng %{_libdir}/*.so - %changelog +* Tue Oct 25 2022 Michal Ambroz - 0.8.1-40 +- remove the libafpclient.la libtool file + * Wed Jul 20 2022 Fedora Release Engineering - 0.8.1-39 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild From c7c078c518ca6afca30f3ebef65293a3fb86aaaf Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Wed, 21 Dec 2022 14:26:40 +0100 Subject: [PATCH 10/23] Port to C99 Related to: --- afpfs-ng-c99.patch | 164 +++++++++++++++++++++++++++++++++++++++++++++ afpfs-ng.spec | 6 +- 2 files changed, 169 insertions(+), 1 deletion(-) create mode 100644 afpfs-ng-c99.patch diff --git a/afpfs-ng-c99.patch b/afpfs-ng-c99.patch new file mode 100644 index 0000000..ea7c282 --- /dev/null +++ b/afpfs-ng-c99.patch @@ -0,0 +1,164 @@ +Add additional #include directives for more function prototypes, +to avoid implicit function declarations. Declare appledouble_write, +cmdline_afp_setup_client in the appropriate header files. + +These changes expose an argument type mismatch in the function +appledouble_truncate, in the calls to remove_opened_fork. This may +or may have not worked before, depending on how the ABI implements +passing this struct by value. + +The use of basename in start_afpfsd is suspect; this should probaby use +dirname instead. + +Submitted upstream: + +diff --git a/cmdline/cmdline_afp.h b/cmdline/cmdline_afp.h +index ebdf357fc952972c..e0ec4570f69b71ec 100644 +--- a/cmdline/cmdline_afp.h ++++ b/cmdline/cmdline_afp.h +@@ -28,5 +28,6 @@ int com_disconnect(char * arg); + void cmdline_afp_exit(void); + + int cmdline_afp_setup(int recursive, char * url_string); ++void cmdline_afp_setup_client(void); + + #endif +diff --git a/cmdline/cmdline_main.c b/cmdline/cmdline_main.c +index ffb39ebacb8f262c..deccf8a4cc342bf0 100644 +--- a/cmdline/cmdline_main.c ++++ b/cmdline/cmdline_main.c +@@ -17,6 +17,7 @@ + #include + #include + #include ++#include "afp.h" + #include "cmdline_afp.h" + #include "cmdline_testafp.h" + +diff --git a/fuse/client.c b/fuse/client.c +index d19e9efb2dcb60b7..beceaa5594a89b80 100644 +--- a/fuse/client.c ++++ b/fuse/client.c +@@ -10,6 +10,7 @@ + #include + #include + #include ++#include + + #include "config.h" + #include +diff --git a/fuse/daemon.c b/fuse/daemon.c +index 8b3b8d9146633518..abf6c02e390142b2 100644 +--- a/fuse/daemon.c ++++ b/fuse/daemon.c +@@ -23,6 +23,8 @@ + #include + #include + ++#include ++ + #include "afp.h" + + #include "dsi.h" +diff --git a/lib/dsi.c b/lib/dsi.c +index 8a469794542ec447..3fd10fb24c770ca8 100644 +--- a/lib/dsi.c ++++ b/lib/dsi.c +@@ -27,6 +27,7 @@ + #include "libafpclient.h" + #include "afp_internal.h" + #include "afp_replies.h" ++#include "codepage.h" + + /* define this in order to get reams of DSI debugging information */ + #undef DEBUG_DSI +diff --git a/lib/lowlevel.c b/lib/lowlevel.c +index f3b632c2ae2da763..1edc9cdce5cc8429 100644 +--- a/lib/lowlevel.c ++++ b/lib/lowlevel.c +@@ -25,6 +25,8 @@ + #include "utils.h" + #include "did.h" + #include "users.h" ++#include "midlevel.h" ++#include "forklist.h" + + static void set_nonunix_perms(unsigned int * mode, struct afp_file_info *fp) + { +diff --git a/lib/proto_files.c b/lib/proto_files.c +index 933956da6a6d2ce6..d2acd562a2671869 100644 +--- a/lib/proto_files.c ++++ b/lib/proto_files.c +@@ -14,6 +14,7 @@ + #include "dsi_protocol.h" + #include "afp_protocol.h" + #include "afp_internal.h" ++#include "afp_replies.h" + + /* afp_setfileparms, afp_setdirparms and afpsetfiledirparms are all remarkably + similiar. We abstract them to afp-setparms_lowlevel. */ +diff --git a/lib/proto_replyblock.c b/lib/proto_replyblock.c +index f66791614a52ca3d..c59629b24ab83cec 100644 +--- a/lib/proto_replyblock.c ++++ b/lib/proto_replyblock.c +@@ -10,6 +10,7 @@ + #include "afp.h" + #include "utils.h" + #include "afp_internal.h" ++#include "afp_replies.h" + + + /* FIXME: should do bounds checking */ +diff --git a/lib/resource.c b/lib/resource.c +index 6be4a5b1de51fec5..fb39889f0d7702c0 100644 +--- a/lib/resource.c ++++ b/lib/resource.c +@@ -8,6 +8,7 @@ + #include "lowlevel.h" + #include "did.h" + #include "midlevel.h" ++#include "forklist.h" + + #define appledouble ".AppleDouble" + #define finderinfo_string ".finderinfo" +@@ -362,12 +363,12 @@ int appledouble_truncate(struct afp_volume * volume, const char * path, int offs + ret=ll_zero_file(volume,fp.forkid,0); + if (ret<0) { + afp_closefork(volume,fp.forkid); +- remove_opened_fork(volume,fp); ++ remove_opened_fork(volume,&fp); + free(newpath); + return ret; + } + afp_closefork(volume,fp.forkid); +- remove_opened_fork(volume,fp); ++ remove_opened_fork(volume,&fp); + + return 1; + case AFP_META_APPLEDOUBLE: +diff --git a/lib/resource.h b/lib/resource.h +index 6a0d38a6275dd6f5..2efff106c94e6637 100644 +--- a/lib/resource.h ++++ b/lib/resource.h +@@ -31,6 +31,9 @@ int appledouble_read(struct afp_volume * volume, struct afp_file_info *fp, + + int appledouble_close(struct afp_volume * volume, struct afp_file_info * fp); + ++int appledouble_write(struct afp_volume * volume, struct afp_file_info *fp, ++ const char *data, size_t size, off_t offset, size_t *totalwritten); ++ + int appledouble_chmod(struct afp_volume * volume, const char * path, mode_t mode); + + int appledouble_unlink(struct afp_volume * volume, const char *path); +diff --git a/lib/server.c b/lib/server.c +index 977c418efccae88b..93400dd92a4c0af6 100644 +--- a/lib/server.c ++++ b/lib/server.c +@@ -7,6 +7,7 @@ + + #include + #include ++#include + + #include "afp.h" + #include "dsi.h" diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 6667004..24ff8b5 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 40%{?dist} +Release: 41%{?dist} Summary: Apple Filing Protocol client @@ -17,6 +17,7 @@ Patch1: afpfs-ng-0.8.1-pointer.patch # Sent by e-mail to Alex deVries Patch2: afpfs-ng-0.8.1-formatsec.patch Patch3: afpfs-ng-0.8.1-longoptions.patch +Patch4: afpfs-ng-c99.patch %{?with_fuse:BuildRequires: fuse-devel} BuildRequires: gcc @@ -108,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Wed Dec 21 2022 Florian Weimer - 0.8.1-41 +- Port to C99 + * Tue Oct 25 2022 Michal Ambroz - 0.8.1-40 - remove the libafpclient.la libtool file From 360d6f9e18a87422574d8ef90ebd4e624e76b545 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 18 Jan 2023 21:28:47 +0000 Subject: [PATCH 11/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 24ff8b5..5203b95 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 41%{?dist} +Release: 42%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Wed Jan 18 2023 Fedora Release Engineering - 0.8.1-42 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + * Wed Dec 21 2022 Florian Weimer - 0.8.1-41 - Port to C99 From ccdbd66e4a2339b1013fb7f76cf63942ec2e6d30 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 19 Jul 2023 12:59:48 +0000 Subject: [PATCH 12/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 5203b95..06ba6cd 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 42%{?dist} +Release: 43%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Wed Jul 19 2023 Fedora Release Engineering - 0.8.1-43 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + * Wed Jan 18 2023 Fedora Release Engineering - 0.8.1-42 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild From fbb2d5ebaeac53e0cd6902b7e85d6b4ff3948417 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 19 Jan 2024 12:22:30 +0000 Subject: [PATCH 13/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 06ba6cd..9d54352 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 43%{?dist} +Release: 44%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Fri Jan 19 2024 Fedora Release Engineering - 0.8.1-44 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Wed Jul 19 2023 Fedora Release Engineering - 0.8.1-43 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild From f1bfbb43a09d206b024f2bb4aadc49da3898494f Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Mon, 22 Jan 2024 22:45:52 +0000 Subject: [PATCH 14/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 9d54352..00bbd27 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 44%{?dist} +Release: 45%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Mon Jan 22 2024 Fedora Release Engineering - 0.8.1-45 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Fri Jan 19 2024 Fedora Release Engineering - 0.8.1-44 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild From a4c01eaa011a85ac265031a4181bd121c23b8171 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miroslav=20Such=C3=BD?= Date: Mon, 17 Jun 2024 12:23:14 +0200 Subject: [PATCH 15/23] convert GPL+ license to SPDX This is part of https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_4 --- afpfs-ng.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 00bbd27..776f3ac 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 45%{?dist} +Release: 46%{?dist} Summary: Apple Filing Protocol client @@ -9,7 +9,7 @@ Summary: Apple Filing Protocol client %bcond_without fuse -License: GPL+ +License: GPL-1.0-or-later URL: http://alexthepuffin.googlepages.com/home Source0: http://downloads.sourceforge.net/afpfs-ng/%{name}-%{version}.tar.bz2 Patch0: afpfs-ng-0.8.1-overflows.patch @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Mon Jun 17 2024 Miroslav Suchý - 0.8.1-46 +- convert license to SPDX + * Mon Jan 22 2024 Fedora Release Engineering - 0.8.1-45 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild From a55af4e920e7593d672c6620394cca4fb8d335de Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 17 Jul 2024 16:42:07 +0000 Subject: [PATCH 16/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 776f3ac..03c5e5d 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 46%{?dist} +Release: 47%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Wed Jul 17 2024 Fedora Release Engineering - 0.8.1-47 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild + * Mon Jun 17 2024 Miroslav Suchý - 0.8.1-46 - convert license to SPDX From 81f984a1ee0fdfac67ccbd0a0b7f5e3b66bd0cf6 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 16 Jan 2025 10:41:45 +0000 Subject: [PATCH 17/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild --- afpfs-ng.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/afpfs-ng.spec b/afpfs-ng.spec index 03c5e5d..b686810 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 47%{?dist} +Release: 48%{?dist} Summary: Apple Filing Protocol client @@ -109,6 +109,9 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog +* Thu Jan 16 2025 Fedora Release Engineering - 0.8.1-48 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild + * Wed Jul 17 2024 Fedora Release Engineering - 0.8.1-47 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild From efa469c13d2bb0df9cccfd5ed3e1d33aa98caa81 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Tue, 28 Jan 2025 10:53:08 +0100 Subject: [PATCH 18/23] Retired: https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/DRIWVJ7BVL3KVVX5TLC36LJPDMAO72HF/ --- .gitignore | 1 - afpfs-ng-0.8.1-formatsec.patch | 159 ------------------ afpfs-ng-0.8.1-longoptions.patch | 11 -- afpfs-ng-0.8.1-overflows.patch | 28 ---- afpfs-ng-0.8.1-pointer.patch | 280 ------------------------------- afpfs-ng-c99.patch | 164 ------------------ afpfs-ng.spec | 267 ----------------------------- dead.package | 1 + sources | 1 - 9 files changed, 1 insertion(+), 911 deletions(-) delete mode 100644 .gitignore delete mode 100644 afpfs-ng-0.8.1-formatsec.patch delete mode 100644 afpfs-ng-0.8.1-longoptions.patch delete mode 100644 afpfs-ng-0.8.1-overflows.patch delete mode 100644 afpfs-ng-0.8.1-pointer.patch delete mode 100644 afpfs-ng-c99.patch delete mode 100644 afpfs-ng.spec create mode 100644 dead.package delete mode 100644 sources diff --git a/.gitignore b/.gitignore deleted file mode 100644 index ea8ffb1..0000000 --- a/.gitignore +++ /dev/null @@ -1 +0,0 @@ -afpfs-ng-0.8.1.tar.bz2 diff --git a/afpfs-ng-0.8.1-formatsec.patch b/afpfs-ng-0.8.1-formatsec.patch deleted file mode 100644 index 22527b3..0000000 --- a/afpfs-ng-0.8.1-formatsec.patch +++ /dev/null @@ -1,159 +0,0 @@ -From 2c76660566d026d430305231e72c259372de4380 Mon Sep 17 00:00:00 2001 -From: Lubomir Rintel -Date: Wed, 4 Dec 2013 23:17:10 +0100 -Subject: [PATCH] Fix build with -Werror=format-security - -Fedora, starting with version 21, will enable this flag in order to limit -potentially insecure uses of format strings. It is required for format strings -to be constant now. ---- - cmdline/cmdline_afp.c | 4 ++-- - cmdline/cmdline_testafp.c | 12 ++++++------ - fuse/client.c | 5 +---- - fuse/commands.c | 4 ++-- - lib/afp_url.c | 12 ++++++------ - 5 files changed, 17 insertions(+), 20 deletions(-) - -diff --git a/cmdline/cmdline_afp.c b/cmdline/cmdline_afp.c -index 827150b..59f0977 100644 ---- a/cmdline/cmdline_afp.c -+++ b/cmdline/cmdline_afp.c -@@ -828,11 +828,11 @@ int com_status(char * arg) - char text[40960]; - - afp_status_header(text,&len); -- printf(text); -+ printf("%s", text); - - len=40960; - afp_status_server(server,text,&len); -- printf(text); -+ printf("%s", text); - return 0; - } - -diff --git a/cmdline/cmdline_testafp.c b/cmdline/cmdline_testafp.c -index c40f2bd..f887aec 100644 ---- a/cmdline/cmdline_testafp.c -+++ b/cmdline/cmdline_testafp.c -@@ -26,12 +26,12 @@ static int test_one_url(char * url_string, - struct afp_url valid_url; - afp_default_url(&valid_url); - valid_url.protocol=protocol; -- sprintf(valid_url.servername,servername); -- sprintf(valid_url.volumename,volumename); -- sprintf(valid_url.path,path); -- sprintf(valid_url.username,username); -- sprintf(valid_url.password,password); -- sprintf(valid_url.uamname,uamname); -+ snprintf(valid_url.servername,sizeof(valid_url.servername),"%s",servername); -+ snprintf(valid_url.volumename,sizeof(valid_url.volumename),"%s",volumename); -+ snprintf(valid_url.path,sizeof(valid_url.path),"%s",path); -+ snprintf(valid_url.username,sizeof(valid_url.username),"%s",username); -+ snprintf(valid_url.password,sizeof(valid_url.password),"%s",password); -+ snprintf(valid_url.uamname,(valid_url.uamname),"%s",uamname); - valid_url.port=port; - - if (afp_url_validate(url_string,&valid_url)) -diff --git a/fuse/client.c b/fuse/client.c -index f795ca6..d19e9ef 100644 ---- a/fuse/client.c -+++ b/fuse/client.c -@@ -509,7 +509,6 @@ static int prepare_buffer(int argc, char * argv[]) - int read_answer(int sock) { - int len=0, expected_len=0, packetlen; - char incoming_buffer[MAX_CLIENT_RESPONSE]; -- char toprint[MAX_CLIENT_RESPONSE+200]; - struct timeval tv; - fd_set rds,ords; - int ret; -@@ -546,9 +545,7 @@ int read_answer(int sock) { - } - - done: -- memset(toprint,0,MAX_CLIENT_RESPONSE+200); -- snprintf(toprint,MAX_CLIENT_RESPONSE+200,"%s",incoming_buffer+sizeof(*answer)); -- printf(toprint); -+ printf("%.200s",incoming_buffer+sizeof(*answer)); - return ((struct afp_server_response *) incoming_buffer)->result; - - return 0; -diff --git a/fuse/commands.c b/fuse/commands.c -index aa7444d..bb06928 100644 ---- a/fuse/commands.c -+++ b/fuse/commands.c -@@ -163,6 +163,7 @@ static void fuse_log_for_client(void * priv, - len = strlen(c->client_string); - snprintf(c->client_string+len, - MAX_CLIENT_RESPONSE-len, -+ "%s", - message); - } else { - -@@ -468,7 +468,7 @@ static int process_mount(struct fuse_client * c) - volume->mapping=req->map; - afp_detect_mapping(volume); - -- snprintf(volume->mountpoint,255,req->mountpoint); -+ snprintf(volume->mountpoint,255,"%s",req->mountpoint); - - /* Create the new thread and block until we get an answer back */ - { -diff --git a/lib/afp_url.c b/lib/afp_url.c -index 42bac1c..f152d7b 100644 ---- a/lib/afp_url.c -+++ b/lib/afp_url.c -@@ -233,7 +233,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) - } - } - -- snprintf(url->servername,strlen(p)+1,p); -+ snprintf(url->servername,strlen(p)+1,"%s",p); - if (check_servername(url->servername)) { - if (verbose) printf("This isn't a valid servername\n"); - return -1; -@@ -263,7 +263,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) - if ((q=escape_strrchr(p,':',":"))) { - *q='\0'; - q++; -- snprintf(url->password,strlen(q)+1,q); -+ snprintf(url->password,strlen(q)+1,"%s",q); - if (check_password(url->password)) { - if (verbose) printf("This isn't a valid passwd\n"); - return -1; -@@ -276,7 +276,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) - if ((q=strstr(p,";AUTH="))) { - *q='\0'; - q+=6; -- snprintf(url->uamname,strlen(q)+1,q); -+ snprintf(url->uamname,strlen(q)+1,"%s",q); - if (check_uamname(url->uamname)) { - if (verbose) printf("This isn't a valid uamname\n"); - return -1; -@@ -284,7 +284,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) - } - - if (strlen(p)>0) { -- snprintf(url->username,strlen(p)+1,p); -+ snprintf(url->username,strlen(p)+1,"%s",p); - if (check_username(url->username)) { - if (verbose) printf("This isn't a valid username\n"); - return -1;; -@@ -304,12 +304,12 @@ parse_secondpart: - *q='\0'; - q++; - } -- snprintf(url->volumename,strlen(p)+1,p); -+ snprintf(url->volumename,strlen(p)+1,"%s",p); - - - if (q) { - url->path[0]='/'; -- snprintf(url->path+1,strlen(q)+1,q); -+ snprintf(url->path+1,strlen(q)+1,"%s",q); - } - - done: --- -1.8.4.2 - diff --git a/afpfs-ng-0.8.1-longoptions.patch b/afpfs-ng-0.8.1-longoptions.patch deleted file mode 100644 index 883f095..0000000 --- a/afpfs-ng-0.8.1-longoptions.patch +++ /dev/null @@ -1,11 +0,0 @@ -diff -ru afpfs-ng-0.8.1.orig/cmdline/cmdline_main.c afpfs-ng-0.8.1.new/cmdline/cmdline_main.c ---- afpfs-ng-0.8.1.orig/cmdline/cmdline_main.c 2008-02-19 01:54:53.000000000 +0000 -+++ afpfs-ng-0.8.1.new/cmdline/cmdline_main.c 2021-03-12 03:28:59.315715841 +0000 -@@ -387,6 +387,7 @@ - - struct option long_options[] = { - {"recursive",1,0,'r'}, -+ {NULL,0,NULL,0} - }; - char * url = argv[1]; - diff --git a/afpfs-ng-0.8.1-overflows.patch b/afpfs-ng-0.8.1-overflows.patch deleted file mode 100644 index 94399ed..0000000 --- a/afpfs-ng-0.8.1-overflows.patch +++ /dev/null @@ -1,28 +0,0 @@ -Fix possible buffer overflows (given we're copying to storage of AFP_MAX_PATH, -while AFP_MAX_PATH is much smaller than PATH_MAX) - -Lubomir Rintel - ---- afpfs-ng-0.8.1/cmdline/cmdline_afp.c.overflows 2008-10-06 19:21:32.000000000 +0200 -+++ afpfs-ng-0.8.1/cmdline/cmdline_afp.c 2008-10-06 19:13:50.000000000 +0200 -@@ -129,9 +129,9 @@ - { - if (filename[0]!='/') { - if (strlen(curdir)==1) -- snprintf(server_fullname,PATH_MAX,"/%s",filename); -+ snprintf(server_fullname,AFP_MAX_PATH,"/%s",filename); - else -- snprintf(server_fullname,PATH_MAX,"%s/%s",curdir,filename); -+ snprintf(server_fullname,AFP_MAX_PATH,"%s/%s",curdir,filename); - } else { - snprintf(server_fullname,PATH_MAX,"%s",filename); - } -@@ -1217,7 +1217,7 @@ - { - struct passwd * passwd; - -- snprintf(curdir,PATH_MAX,"%s",DEFAULT_DIRECTORY); -+ snprintf(curdir,AFP_MAX_PATH,"%s",DEFAULT_DIRECTORY); - if (init_uams()<0) return -1; - - afp_default_url(&url); diff --git a/afpfs-ng-0.8.1-pointer.patch b/afpfs-ng-0.8.1-pointer.patch deleted file mode 100644 index b47b834..0000000 --- a/afpfs-ng-0.8.1-pointer.patch +++ /dev/null @@ -1,280 +0,0 @@ -diff -up afpfs-ng-0.8.1/cmdline/getstatus.c.pointer afpfs-ng-0.8.1/cmdline/getstatus.c ---- afpfs-ng-0.8.1/cmdline/getstatus.c.pointer 2011-06-14 17:06:35.000000000 +0200 -+++ afpfs-ng-0.8.1/cmdline/getstatus.c 2011-06-14 17:07:25.000000000 +0200 -@@ -1,4 +1,5 @@ - #include -+#include - #include - #include - -diff -up afpfs-ng-0.8.1/fuse/client.c.pointer afpfs-ng-0.8.1/fuse/client.c ---- afpfs-ng-0.8.1/fuse/client.c.pointer 2008-03-08 03:44:16.000000000 +0100 -+++ afpfs-ng-0.8.1/fuse/client.c 2011-06-14 17:02:15.000000000 +0200 -@@ -61,8 +61,9 @@ static int start_afpfsd(void) - snprintf(filename, PATH_MAX, - "/usr/local/bin/%s",AFPFSD_FILENAME); - if (access(filename,X_OK)) { -- snprintf(filename, "/usr/bin/%s", -+ snprintf(filename, sizeof(filename), "/usr/bin/%s", - AFPFSD_FILENAME); -+ filename[sizeof(filename) - 1] = 0; - if (access(filename,X_OK)) { - printf("Could not find server (%s)\n", - filename); -diff -up afpfs-ng-0.8.1/fuse/fuse_int.c.pointer afpfs-ng-0.8.1/fuse/fuse_int.c ---- afpfs-ng-0.8.1/fuse/fuse_int.c.pointer 2008-03-02 06:06:24.000000000 +0100 -+++ afpfs-ng-0.8.1/fuse/fuse_int.c 2011-06-14 17:02:15.000000000 +0200 -@@ -197,7 +197,7 @@ static int fuse_open(const char *path, s - ret = ml_open(volume,path,flags,&fp); - - if (ret==0) -- fi->fh=(void *) fp; -+ fi->fh=(unsigned long) fp; - - return ret; - } -diff -up afpfs-ng-0.8.1/include/afp.h.pointer afpfs-ng-0.8.1/include/afp.h ---- afpfs-ng-0.8.1/include/afp.h.pointer 2008-03-08 17:08:18.000000000 +0100 -+++ afpfs-ng-0.8.1/include/afp.h 2011-06-14 17:02:15.000000000 +0200 -@@ -370,7 +370,7 @@ int afp_unmount_all_volumes(struct afp_s - - int afp_opendt(struct afp_volume *volume, unsigned short * refnum); - --int afp_closedt(struct afp_server * server, unsigned short * refnum); -+int afp_closedt(struct afp_server * server, unsigned short refnum); - - int afp_getcomment(struct afp_volume *volume, unsigned int did, - const char * pathname, struct afp_comment * comment); -diff -up afpfs-ng-0.8.1/include/utils.h.pointer afpfs-ng-0.8.1/include/utils.h ---- afpfs-ng-0.8.1/include/utils.h.pointer 2008-02-18 04:33:58.000000000 +0100 -+++ afpfs-ng-0.8.1/include/utils.h 2011-06-14 17:02:15.000000000 +0200 -@@ -8,8 +8,8 @@ - #define hton64(x) (x) - #define ntoh64(x) (x) - #else /* BYTE_ORDER == BIG_ENDIAN */ --#define hton64(x) ((u_int64_t) (htonl(((x) >> 32) & 0xffffffffLL)) | \ -- (u_int64_t) ((htonl(x) & 0xffffffffLL) << 32)) -+#define hton64(x) ((u_int64_t) (htonl((((unsigned long long)(x)) >> 32) & 0xffffffffLL)) | \ -+ (u_int64_t) ((htonl((unsigned long long)(x)) & 0xffffffffLL) << 32)) - #define ntoh64(x) (hton64(x)) - #endif /* BYTE_ORDER == BIG_ENDIAN */ - -diff -up afpfs-ng-0.8.1/lib/afp_url.c.pointer afpfs-ng-0.8.1/lib/afp_url.c ---- afpfs-ng-0.8.1/lib/afp_url.c.pointer 2008-03-04 21:16:49.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/afp_url.c 2011-06-14 17:02:15.000000000 +0200 -@@ -33,7 +33,7 @@ static int check_port(char * port) - static int check_uamname(const char * uam) - { - char * p; -- for (p=uam;*p;p++) { -+ for (p=(char *)uam;*p;p++) { - if (*p==' ') continue; - if ((*p<'A') || (*p>'z')) return -1; - } -@@ -188,7 +188,7 @@ int afp_parse_url(struct afp_url * url, - return -1; - - } -- if (p==NULL) p=toparse; -+ if (p==NULL) p=(char *)toparse; - - /* Now split on the first / */ - if (sscanf(p,"%[^/]/%[^$]", -diff -up afpfs-ng-0.8.1/lib/did.c.pointer afpfs-ng-0.8.1/lib/did.c ---- afpfs-ng-0.8.1/lib/did.c.pointer 2008-02-18 04:39:17.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/did.c 2011-06-14 17:02:15.000000000 +0200 -@@ -226,7 +226,7 @@ int get_dirid(struct afp_volume * volume - - - /* Go to the end of last known entry */ -- p=path+(p-copy); -+ p=(char *)path+(p-copy); - p2=p; - - while ((p=strchr(p+1,'/'))) { -diff -up afpfs-ng-0.8.1/lib/dsi.c.pointer afpfs-ng-0.8.1/lib/dsi.c ---- afpfs-ng-0.8.1/lib/dsi.c.pointer 2008-02-18 04:53:03.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/dsi.c 2011-06-14 17:02:15.000000000 +0200 -@@ -474,7 +474,7 @@ void dsi_getstatus_reply(struct afp_serv - } - server->flags=ntohs(reply1->flags); - -- p=(void *)((unsigned int) server->incoming_buffer + sizeof(*reply1)); -+ p=(void *)((unsigned long) server->incoming_buffer + sizeof(*reply1)); - p+=copy_from_pascal(server->server_name,p,AFP_SERVER_NAME_LEN)+1; - - /* Now work our way through the variable bits */ -@@ -757,7 +757,7 @@ gotenough: - printf("<<< read() of rest of AFP, %d bytes\n",amount_to_read); - #endif - ret = read(server->fd, (void *) -- (((unsigned int) server->incoming_buffer)+server->data_read), -+ (((unsigned long) server->incoming_buffer)+server->data_read), - amount_to_read); - if (ret<0) return -1; - if (ret==0) { -diff -up afpfs-ng-0.8.1/lib/loop.c.pointer afpfs-ng-0.8.1/lib/loop.c ---- afpfs-ng-0.8.1/lib/loop.c.pointer 2008-02-18 04:40:11.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/loop.c 2011-06-14 17:02:15.000000000 +0200 -@@ -25,7 +25,7 @@ - static unsigned char exit_program=0; - - static pthread_t ending_thread; --static pthread_t main_thread = NULL; -+static pthread_t main_thread = (pthread_t)NULL; - - static int loop_started=0; - static pthread_cond_t loop_started_condition; -diff -up afpfs-ng-0.8.1/lib/lowlevel.c.pointer afpfs-ng-0.8.1/lib/lowlevel.c ---- afpfs-ng-0.8.1/lib/lowlevel.c.pointer 2008-02-20 02:33:17.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/lowlevel.c 2011-06-14 17:02:15.000000000 +0200 -@@ -582,7 +582,7 @@ int ll_getattr(struct afp_volume * volum - if (volume->server->using_version->av_number>=30) - stbuf->st_mode |= fp.unixprivs.permissions; - else -- set_nonunix_perms(stbuf,&fp); -+ set_nonunix_perms(&stbuf->st_mode,&fp); - - stbuf->st_uid=fp.unixprivs.uid; - stbuf->st_gid=fp.unixprivs.gid; -diff -up afpfs-ng-0.8.1/lib/midlevel.c.pointer afpfs-ng-0.8.1/lib/midlevel.c ---- afpfs-ng-0.8.1/lib/midlevel.c.pointer 2008-03-08 17:08:18.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/midlevel.c 2011-06-14 17:02:15.000000000 +0200 -@@ -713,7 +713,7 @@ int ml_write(struct afp_volume * volume, - { - - int ret,err=0; -- int totalwritten = 0; -+ size_t totalwritten = 0; - uint64_t sizetowrite, ignored; - unsigned char flags = 0; - unsigned int max_packet_size=volume->server->tx_quantum; -diff -up afpfs-ng-0.8.1/lib/proto_attr.c.pointer afpfs-ng-0.8.1/lib/proto_attr.c ---- afpfs-ng-0.8.1/lib/proto_attr.c.pointer 2008-01-30 05:37:58.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/proto_attr.c 2011-06-14 17:02:15.000000000 +0200 -@@ -166,7 +166,7 @@ int afp_getextattr(struct afp_volume * v - copy_path(server,p,pathname,strlen(pathname)); - unixpath_to_afppath(server,p); - p2=p+sizeof_path_header(server)+strlen(pathname); -- if (((unsigned int ) p2) & 0x1) p2++; -+ if (((unsigned long) p2) & 0x1) p2++; - req2=(void *) p2; - - req2->len=htons(namelen); -diff -up afpfs-ng-0.8.1/lib/proto_desktop.c.pointer afpfs-ng-0.8.1/lib/proto_desktop.c ---- afpfs-ng-0.8.1/lib/proto_desktop.c.pointer 2008-02-18 04:44:11.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/proto_desktop.c 2011-06-14 17:02:15.000000000 +0200 -@@ -168,7 +168,7 @@ int afp_getcomment_reply(struct afp_serv - return 0; - } - --int afp_closedt(struct afp_server * server, unsigned short * refnum) -+int afp_closedt(struct afp_server * server, unsigned short refnum) - { - struct { - struct dsi_header dsi_header __attribute__((__packed__)); -diff -up afpfs-ng-0.8.1/lib/proto_directory.c.pointer afpfs-ng-0.8.1/lib/proto_directory.c ---- afpfs-ng-0.8.1/lib/proto_directory.c.pointer 2008-02-19 03:39:29.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/proto_directory.c 2011-06-14 17:02:15.000000000 +0200 -@@ -248,6 +248,7 @@ int afp_enumerate_reply(struct afp_serve - - return 0; - } -+ - int afp_enumerateext2_reply(struct afp_server *server, char * buf, unsigned int size, void * other) - { - -@@ -266,8 +267,7 @@ int afp_enumerateext2_reply(struct afp_s - char * p = buf + sizeof(*reply); - int i; - char *max=buf+size; -- struct afp_file_info * filebase = NULL, *filecur=NULL, *new_file=NULL; -- void ** x = other; -+ struct afp_file_info * filebase = NULL, *filecur = NULL, *new_file = NULL, **x = (struct afp_file_info **) other; - - if (reply->dsi_header.return_code.error_code) { - return reply->dsi_header.return_code.error_code; -diff -up afpfs-ng-0.8.1/lib/proto_map.c.pointer afpfs-ng-0.8.1/lib/proto_map.c ---- afpfs-ng-0.8.1/lib/proto_map.c.pointer 2008-01-30 05:37:59.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/proto_map.c 2011-06-14 17:02:15.000000000 +0200 -@@ -122,7 +122,7 @@ int afp_mapid_reply(struct afp_server *s - - if (reply->header.return_code.error_code!=kFPNoErr) return -1; - -- copy_from_pascal_two(name,&reply->name,255); -+ copy_from_pascal_two(name,reply->name,255); - - return 0; - } -diff -up afpfs-ng-0.8.1/lib/proto_session.c.pointer afpfs-ng-0.8.1/lib/proto_session.c ---- afpfs-ng-0.8.1/lib/proto_session.c.pointer 2008-02-18 04:46:19.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/proto_session.c 2011-06-14 17:02:15.000000000 +0200 -@@ -39,7 +39,7 @@ int afp_getsessiontoken(struct afp_serve - switch (type) { - case kLoginWithTimeAndID: - case kReconnWithTimeAndID: { -- uint32_t *p = (void *) (((unsigned int) request)+ -+ uint32_t *p = (void *) (((unsigned long) request)+ - sizeof(*request)); - - offset=sizeof(timestamp); -@@ -63,7 +63,7 @@ int afp_getsessiontoken(struct afp_serve - goto error; - } - -- data=(void *) (((unsigned int) request)+sizeof(*request)+offset); -+ data=(void *) (((unsigned long) request)+sizeof(*request)+offset); - request->idlength=htonl(datalen); - request->pad=0; - request->type=htons(type); -@@ -127,7 +127,7 @@ int afp_disconnectoldsession(struct afp_ - if ((request=malloc(sizeof(*request) + AFP_TOKEN_MAX_LEN))==NULL) - return -1; - -- token_data = request + sizeof(*request); -+ token_data = (char *)request + sizeof(*request); - - request->type=htons(type); - -diff -up afpfs-ng-0.8.1/lib/uams.c.pointer afpfs-ng-0.8.1/lib/uams.c ---- afpfs-ng-0.8.1/lib/uams.c.pointer 2008-01-04 04:52:44.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/uams.c 2011-06-14 17:02:15.000000000 +0200 -@@ -180,7 +180,7 @@ static int cleartxt_login(struct afp_ser - goto cleartxt_fail; - - p += copy_to_pascal(p, username) + 1; -- if ((int)p & 0x1) -+ if ((long)p & 0x1) - len--; - else - p++; -@@ -230,7 +230,7 @@ static int cleartxt_passwd(struct afp_se - goto cleartxt_fail; - - p += copy_to_pascal(p, username) + 1; -- if ((int)p & 0x1) -+ if ((long)p & 0x1) - len--; - else - p++; -@@ -580,7 +580,7 @@ static int dhx_login(struct afp_server * - if (ai == NULL) - goto dhx_noctx_fail; - d += copy_to_pascal(ai, username) + 1; -- if (((int)d) % 2) -+ if (((long)d) % 2) - d++; - else - ai_len--; -diff -up afpfs-ng-0.8.1/lib/utils.c.pointer afpfs-ng-0.8.1/lib/utils.c ---- afpfs-ng-0.8.1/lib/utils.c.pointer 2008-02-18 04:53:37.000000000 +0100 -+++ afpfs-ng-0.8.1/lib/utils.c 2011-06-14 17:02:15.000000000 +0200 -@@ -196,7 +196,7 @@ int invalid_filename(struct afp_server * - maxlen=255; - - -- p=filename+1; -+ p=(char *)filename+1; - while ((q=strchr(p,'/'))) { - if (q>p+maxlen) - return 1; diff --git a/afpfs-ng-c99.patch b/afpfs-ng-c99.patch deleted file mode 100644 index ea7c282..0000000 --- a/afpfs-ng-c99.patch +++ /dev/null @@ -1,164 +0,0 @@ -Add additional #include directives for more function prototypes, -to avoid implicit function declarations. Declare appledouble_write, -cmdline_afp_setup_client in the appropriate header files. - -These changes expose an argument type mismatch in the function -appledouble_truncate, in the calls to remove_opened_fork. This may -or may have not worked before, depending on how the ABI implements -passing this struct by value. - -The use of basename in start_afpfsd is suspect; this should probaby use -dirname instead. - -Submitted upstream: - -diff --git a/cmdline/cmdline_afp.h b/cmdline/cmdline_afp.h -index ebdf357fc952972c..e0ec4570f69b71ec 100644 ---- a/cmdline/cmdline_afp.h -+++ b/cmdline/cmdline_afp.h -@@ -28,5 +28,6 @@ int com_disconnect(char * arg); - void cmdline_afp_exit(void); - - int cmdline_afp_setup(int recursive, char * url_string); -+void cmdline_afp_setup_client(void); - - #endif -diff --git a/cmdline/cmdline_main.c b/cmdline/cmdline_main.c -index ffb39ebacb8f262c..deccf8a4cc342bf0 100644 ---- a/cmdline/cmdline_main.c -+++ b/cmdline/cmdline_main.c -@@ -17,6 +17,7 @@ - #include - #include - #include -+#include "afp.h" - #include "cmdline_afp.h" - #include "cmdline_testafp.h" - -diff --git a/fuse/client.c b/fuse/client.c -index d19e9efb2dcb60b7..beceaa5594a89b80 100644 ---- a/fuse/client.c -+++ b/fuse/client.c -@@ -10,6 +10,7 @@ - #include - #include - #include -+#include - - #include "config.h" - #include -diff --git a/fuse/daemon.c b/fuse/daemon.c -index 8b3b8d9146633518..abf6c02e390142b2 100644 ---- a/fuse/daemon.c -+++ b/fuse/daemon.c -@@ -23,6 +23,8 @@ - #include - #include - -+#include -+ - #include "afp.h" - - #include "dsi.h" -diff --git a/lib/dsi.c b/lib/dsi.c -index 8a469794542ec447..3fd10fb24c770ca8 100644 ---- a/lib/dsi.c -+++ b/lib/dsi.c -@@ -27,6 +27,7 @@ - #include "libafpclient.h" - #include "afp_internal.h" - #include "afp_replies.h" -+#include "codepage.h" - - /* define this in order to get reams of DSI debugging information */ - #undef DEBUG_DSI -diff --git a/lib/lowlevel.c b/lib/lowlevel.c -index f3b632c2ae2da763..1edc9cdce5cc8429 100644 ---- a/lib/lowlevel.c -+++ b/lib/lowlevel.c -@@ -25,6 +25,8 @@ - #include "utils.h" - #include "did.h" - #include "users.h" -+#include "midlevel.h" -+#include "forklist.h" - - static void set_nonunix_perms(unsigned int * mode, struct afp_file_info *fp) - { -diff --git a/lib/proto_files.c b/lib/proto_files.c -index 933956da6a6d2ce6..d2acd562a2671869 100644 ---- a/lib/proto_files.c -+++ b/lib/proto_files.c -@@ -14,6 +14,7 @@ - #include "dsi_protocol.h" - #include "afp_protocol.h" - #include "afp_internal.h" -+#include "afp_replies.h" - - /* afp_setfileparms, afp_setdirparms and afpsetfiledirparms are all remarkably - similiar. We abstract them to afp-setparms_lowlevel. */ -diff --git a/lib/proto_replyblock.c b/lib/proto_replyblock.c -index f66791614a52ca3d..c59629b24ab83cec 100644 ---- a/lib/proto_replyblock.c -+++ b/lib/proto_replyblock.c -@@ -10,6 +10,7 @@ - #include "afp.h" - #include "utils.h" - #include "afp_internal.h" -+#include "afp_replies.h" - - - /* FIXME: should do bounds checking */ -diff --git a/lib/resource.c b/lib/resource.c -index 6be4a5b1de51fec5..fb39889f0d7702c0 100644 ---- a/lib/resource.c -+++ b/lib/resource.c -@@ -8,6 +8,7 @@ - #include "lowlevel.h" - #include "did.h" - #include "midlevel.h" -+#include "forklist.h" - - #define appledouble ".AppleDouble" - #define finderinfo_string ".finderinfo" -@@ -362,12 +363,12 @@ int appledouble_truncate(struct afp_volume * volume, const char * path, int offs - ret=ll_zero_file(volume,fp.forkid,0); - if (ret<0) { - afp_closefork(volume,fp.forkid); -- remove_opened_fork(volume,fp); -+ remove_opened_fork(volume,&fp); - free(newpath); - return ret; - } - afp_closefork(volume,fp.forkid); -- remove_opened_fork(volume,fp); -+ remove_opened_fork(volume,&fp); - - return 1; - case AFP_META_APPLEDOUBLE: -diff --git a/lib/resource.h b/lib/resource.h -index 6a0d38a6275dd6f5..2efff106c94e6637 100644 ---- a/lib/resource.h -+++ b/lib/resource.h -@@ -31,6 +31,9 @@ int appledouble_read(struct afp_volume * volume, struct afp_file_info *fp, - - int appledouble_close(struct afp_volume * volume, struct afp_file_info * fp); - -+int appledouble_write(struct afp_volume * volume, struct afp_file_info *fp, -+ const char *data, size_t size, off_t offset, size_t *totalwritten); -+ - int appledouble_chmod(struct afp_volume * volume, const char * path, mode_t mode); - - int appledouble_unlink(struct afp_volume * volume, const char *path); -diff --git a/lib/server.c b/lib/server.c -index 977c418efccae88b..93400dd92a4c0af6 100644 ---- a/lib/server.c -+++ b/lib/server.c -@@ -7,6 +7,7 @@ - - #include - #include -+#include - - #include "afp.h" - #include "dsi.h" diff --git a/afpfs-ng.spec b/afpfs-ng.spec deleted file mode 100644 index b686810..0000000 --- a/afpfs-ng.spec +++ /dev/null @@ -1,267 +0,0 @@ -Name: afpfs-ng -Version: 0.8.1 -Release: 48%{?dist} -Summary: Apple Filing Protocol client - - -# by default build with the fuse module -# rpmbuild --rebuild afpfs-ng.src.rpm --without fuse -%bcond_without fuse - - -License: GPL-1.0-or-later -URL: http://alexthepuffin.googlepages.com/home -Source0: http://downloads.sourceforge.net/afpfs-ng/%{name}-%{version}.tar.bz2 -Patch0: afpfs-ng-0.8.1-overflows.patch -Patch1: afpfs-ng-0.8.1-pointer.patch -# Sent by e-mail to Alex deVries -Patch2: afpfs-ng-0.8.1-formatsec.patch -Patch3: afpfs-ng-0.8.1-longoptions.patch -Patch4: afpfs-ng-c99.patch - -%{?with_fuse:BuildRequires: fuse-devel} -BuildRequires: gcc -BuildRequires: libgcrypt-devel gmp-devel readline-devel -BuildRequires: make -BuildRequires: libtool -BuildRequires: autoconf - - -%description -A command line client to access files exported from Mac OS system via -Apple Filing Protocol. -%{?with_fuse:The FUSE filesystem module for AFP is in fuse-afp package} - - -%if 0%{?with_fuse} -%package -n fuse-afp -Summary: FUSE driver for AFP filesystem - -%description -n fuse-afp -A FUSE file system server to access files exported from Mac OS system -via AppleTalk or TCP using Apple Filing Protocol. -The command line client for AFP is in fuse-afp package -%endif - - -%package devel -Summary: Development files for afpfs-ng -Requires: %{name} = %{version} - -%description devel -Library for dynamic linking and header files of afpfs-ng. - -%prep -%autosetup -p 1 -libtoolize -autoreconf - -%build -# make would rebuild the autoconf infrastructure due to the following: -# Prerequisite `configure.ac' is newer than target `Makefile.in'. -# Prerequisite `aclocal.m4' is newer than target `Makefile.in'. -# Prerequisite `configure.ac' is newer than target `aclocal.m4'. -touch --reference aclocal.m4 configure.ac Makefile.in - -export CFLAGS="${RPM_OPT_FLAGS} -fcommon" -%configure %{?!with_fuse:--disable-fuse} --disable-static -make %{?_smp_mflags} - - -%install -%make_install -install -d %{buildroot}%{_includedir}/afpfs-ng -cp -p include/* %{buildroot}%{_includedir}/afpfs-ng -# libtool .la file works different in different versions of libtool, should not be packaged -[ -f %{buildroot}%{_libdir}/libafpclient.la ] && rm -f %{buildroot}%{_libdir}/libafpclient.la - -%if ( 0%{?rhel} && 0%{?rhel} <= 7 ) -%ldconfig_scriptlets -%endif - - -%files -%license COPYING -%{_bindir}/afpcmd -%{_bindir}/afpgetstatus -%{_mandir}/man1/afpcmd.1* -%{_mandir}/man1/afpgetstatus.1* -%{_libdir}/libafpclient.so.* -%doc AUTHORS ChangeLog docs/README docs/performance docs/FEATURES.txt docs/REPORTING-BUGS.txt - - -%if 0%{?with_fuse} -%files -n fuse-afp -%license COPYING -%{_bindir}/afp_client -%{_bindir}/afpfs -%{_bindir}/afpfsd -%{_bindir}/mount_afp -%{_mandir}/man1/afp_client.1* -%{_mandir}/man1/afpfsd.1* -%{_mandir}/man1/mount_afp.1* -%doc AUTHORS ChangeLog -%endif - - -%files devel -%{_includedir}/afpfs-ng -%{_libdir}/*.so - -%changelog -* Thu Jan 16 2025 Fedora Release Engineering - 0.8.1-48 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild - -* Wed Jul 17 2024 Fedora Release Engineering - 0.8.1-47 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild - -* Mon Jun 17 2024 Miroslav Suchý - 0.8.1-46 -- convert license to SPDX - -* Mon Jan 22 2024 Fedora Release Engineering - 0.8.1-45 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild - -* Fri Jan 19 2024 Fedora Release Engineering - 0.8.1-44 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild - -* Wed Jul 19 2023 Fedora Release Engineering - 0.8.1-43 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild - -* Wed Jan 18 2023 Fedora Release Engineering - 0.8.1-42 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild - -* Wed Dec 21 2022 Florian Weimer - 0.8.1-41 -- Port to C99 - -* Tue Oct 25 2022 Michal Ambroz - 0.8.1-40 -- remove the libafpclient.la libtool file - -* Wed Jul 20 2022 Fedora Release Engineering - 0.8.1-39 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild - -* Wed Jan 19 2022 Fedora Release Engineering - 0.8.1-38 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild - -* Wed Nov 17 2021 Michal Ambroz - 0.8.1-37 -- update embedded libtool (ltmain.sh) - -* Wed Jul 21 2021 Fedora Release Engineering - 0.8.1-36 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild - -* Mon Apr 26 2021 Michal Ambroz - 0.8.1-35 -- modernize spec, push the bugfix to active branches - -* Fri Mar 12 2021 Michal Ambroz - 0.8.1-34 -- fix issue 1507944 - -* Mon Jan 25 2021 Fedora Release Engineering - 0.8.1-33 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild - -* Fri Jul 31 2020 Fedora Release Engineering - 0.8.1-32 -- Second attempt - Rebuilt for - https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild - -* Mon Jul 27 2020 Fedora Release Engineering - 0.8.1-31 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild - -* Wed Apr 22 2020 Michal Ambroz - 0.8.1-30 -- fix FTBFS - multiple definition of - build legacy code with -fcommon - -* Tue Jan 28 2020 Fedora Release Engineering - 0.8.1-29 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild - -* Wed Jul 24 2019 Fedora Release Engineering - 0.8.1-28 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild - -* Sun Feb 17 2019 Igor Gnatenko - 0.8.1-27 -- Rebuild for readline 8.0 - -* Thu Jan 31 2019 Fedora Release Engineering - 0.8.1-26 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild - -* Thu Jul 12 2018 Fedora Release Engineering - 0.8.1-25 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild - -* Wed Feb 07 2018 Fedora Release Engineering - 0.8.1-24 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild - -* Wed Aug 02 2017 Fedora Release Engineering - 0.8.1-23 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild - -* Wed Jul 26 2017 Fedora Release Engineering - 0.8.1-22 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild - -* Fri Feb 10 2017 Fedora Release Engineering - 0.8.1-21 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild - -* Wed Feb 03 2016 Fedora Release Engineering - 0.8.1-20 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild - -* Tue Jun 16 2015 Fedora Release Engineering - 0.8.1-19 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild - -* Tue Nov 25 2014 - 0.8.1-18 -- Fix mount_afp crash (RHBZ #1165296) - -* Fri Aug 15 2014 Fedora Release Engineering - 0.8.1-17 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild - -* Sat Jun 07 2014 Fedora Release Engineering - 0.8.1-16 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild - -* Tue Apr 22 2014 Tomáš Mráz - 0.8.1-15 -- Rebuild for new libgcrypt - -* Wed Dec 04 2013 Lubomir Rintel - 0.8.1-14 -- Fix build with -Werror=format-security - -* Thu Oct 24 2013 Lubomir Rintel - 0.8.1-13.3 -- Bulk sad and useless attempt at consistent SPEC file formatting - -* Sat Aug 03 2013 Fedora Release Engineering - 0.8.1-12.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild - -* Wed Feb 13 2013 Fedora Release Engineering - 0.8.1-11.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild - -* Wed Jul 18 2012 Fedora Release Engineering - 0.8.1-10.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild - -* Thu Jan 12 2012 Fedora Release Engineering - 0.8.1-9.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild - -* Thu Oct 20 2011 Marcela Mašláňová - 0.8.1-8.3 -- rebuild with new gmp without compat lib - -* Mon Oct 10 2011 Peter Schiffer - 0.8.1-8.2 -- rebuild with new gmp - -* Mon Sep 26 2011 Peter Schiffer - 0.8.1-8.1 -- rebuild with new gmp - -* Mon Jul 4 2011 Jan F. Chadima - 0.8.1-8 -- Repair ponter arithmetic - -* Mon Feb 07 2011 Fedora Release Engineering - 0.8.1-7 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild - -* Thu Sep 17 2009 Peter Lemenkov - 0.8.1-6 -- Rebuild with new fuse - -* Fri Jul 24 2009 Fedora Release Engineering - 0.8.1-5 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild - -* Fri Jul 17 2009 Lubomir Rintel - 0.8.1-4 -- Don't refer to AppleTalk in Summary - -* Tue Jul 14 2009 Lubomir Rintel - 0.8.1-3 -- Fix up license tag - -* Thu Mar 19 2009 Lubomir Rintel - 0.8.1-2 -- Add more include files (Jan F. Chadima) -- Don't needlessly build static library (Stefan Kasal) -- Fix fuse-afp summary (Stefan Kasal) -- Remove redundant license file from -devel (Stefan Kasal) - -* Mon Oct 6 2008 Lubomir Rintel - 0.8.1-1 -- Initial packaging attempt diff --git a/dead.package b/dead.package new file mode 100644 index 0000000..b37fb02 --- /dev/null +++ b/dead.package @@ -0,0 +1 @@ +Retired: https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/DRIWVJ7BVL3KVVX5TLC36LJPDMAO72HF/ diff --git a/sources b/sources deleted file mode 100644 index 4bd856f..0000000 --- a/sources +++ /dev/null @@ -1 +0,0 @@ -1bdd9f8a06e6085ea4cc38ce010ef60b afpfs-ng-0.8.1.tar.bz2 From 64c7827fc24c8ab488338c8e6df8bc03ad725fc7 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 7 Feb 2025 07:42:47 +0000 Subject: [PATCH 19/23] Unretirement Releng Request: https://pagure.io/releng/issue/12566 Signed-off-by: Fedora Release Engineering --- .gitignore | 1 + afpfs-ng-0.8.1-formatsec.patch | 159 ++++++++++++++++++ afpfs-ng-0.8.1-longoptions.patch | 11 ++ afpfs-ng-0.8.1-overflows.patch | 28 ++++ afpfs-ng-0.8.1-pointer.patch | 280 +++++++++++++++++++++++++++++++ afpfs-ng-c99.patch | 164 ++++++++++++++++++ afpfs-ng.spec | 267 +++++++++++++++++++++++++++++ dead.package | 1 - sources | 1 + 9 files changed, 911 insertions(+), 1 deletion(-) create mode 100644 .gitignore create mode 100644 afpfs-ng-0.8.1-formatsec.patch create mode 100644 afpfs-ng-0.8.1-longoptions.patch create mode 100644 afpfs-ng-0.8.1-overflows.patch create mode 100644 afpfs-ng-0.8.1-pointer.patch create mode 100644 afpfs-ng-c99.patch create mode 100644 afpfs-ng.spec delete mode 100644 dead.package create mode 100644 sources diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..ea8ffb1 --- /dev/null +++ b/.gitignore @@ -0,0 +1 @@ +afpfs-ng-0.8.1.tar.bz2 diff --git a/afpfs-ng-0.8.1-formatsec.patch b/afpfs-ng-0.8.1-formatsec.patch new file mode 100644 index 0000000..22527b3 --- /dev/null +++ b/afpfs-ng-0.8.1-formatsec.patch @@ -0,0 +1,159 @@ +From 2c76660566d026d430305231e72c259372de4380 Mon Sep 17 00:00:00 2001 +From: Lubomir Rintel +Date: Wed, 4 Dec 2013 23:17:10 +0100 +Subject: [PATCH] Fix build with -Werror=format-security + +Fedora, starting with version 21, will enable this flag in order to limit +potentially insecure uses of format strings. It is required for format strings +to be constant now. +--- + cmdline/cmdline_afp.c | 4 ++-- + cmdline/cmdline_testafp.c | 12 ++++++------ + fuse/client.c | 5 +---- + fuse/commands.c | 4 ++-- + lib/afp_url.c | 12 ++++++------ + 5 files changed, 17 insertions(+), 20 deletions(-) + +diff --git a/cmdline/cmdline_afp.c b/cmdline/cmdline_afp.c +index 827150b..59f0977 100644 +--- a/cmdline/cmdline_afp.c ++++ b/cmdline/cmdline_afp.c +@@ -828,11 +828,11 @@ int com_status(char * arg) + char text[40960]; + + afp_status_header(text,&len); +- printf(text); ++ printf("%s", text); + + len=40960; + afp_status_server(server,text,&len); +- printf(text); ++ printf("%s", text); + return 0; + } + +diff --git a/cmdline/cmdline_testafp.c b/cmdline/cmdline_testafp.c +index c40f2bd..f887aec 100644 +--- a/cmdline/cmdline_testafp.c ++++ b/cmdline/cmdline_testafp.c +@@ -26,12 +26,12 @@ static int test_one_url(char * url_string, + struct afp_url valid_url; + afp_default_url(&valid_url); + valid_url.protocol=protocol; +- sprintf(valid_url.servername,servername); +- sprintf(valid_url.volumename,volumename); +- sprintf(valid_url.path,path); +- sprintf(valid_url.username,username); +- sprintf(valid_url.password,password); +- sprintf(valid_url.uamname,uamname); ++ snprintf(valid_url.servername,sizeof(valid_url.servername),"%s",servername); ++ snprintf(valid_url.volumename,sizeof(valid_url.volumename),"%s",volumename); ++ snprintf(valid_url.path,sizeof(valid_url.path),"%s",path); ++ snprintf(valid_url.username,sizeof(valid_url.username),"%s",username); ++ snprintf(valid_url.password,sizeof(valid_url.password),"%s",password); ++ snprintf(valid_url.uamname,(valid_url.uamname),"%s",uamname); + valid_url.port=port; + + if (afp_url_validate(url_string,&valid_url)) +diff --git a/fuse/client.c b/fuse/client.c +index f795ca6..d19e9ef 100644 +--- a/fuse/client.c ++++ b/fuse/client.c +@@ -509,7 +509,6 @@ static int prepare_buffer(int argc, char * argv[]) + int read_answer(int sock) { + int len=0, expected_len=0, packetlen; + char incoming_buffer[MAX_CLIENT_RESPONSE]; +- char toprint[MAX_CLIENT_RESPONSE+200]; + struct timeval tv; + fd_set rds,ords; + int ret; +@@ -546,9 +545,7 @@ int read_answer(int sock) { + } + + done: +- memset(toprint,0,MAX_CLIENT_RESPONSE+200); +- snprintf(toprint,MAX_CLIENT_RESPONSE+200,"%s",incoming_buffer+sizeof(*answer)); +- printf(toprint); ++ printf("%.200s",incoming_buffer+sizeof(*answer)); + return ((struct afp_server_response *) incoming_buffer)->result; + + return 0; +diff --git a/fuse/commands.c b/fuse/commands.c +index aa7444d..bb06928 100644 +--- a/fuse/commands.c ++++ b/fuse/commands.c +@@ -163,6 +163,7 @@ static void fuse_log_for_client(void * priv, + len = strlen(c->client_string); + snprintf(c->client_string+len, + MAX_CLIENT_RESPONSE-len, ++ "%s", + message); + } else { + +@@ -468,7 +468,7 @@ static int process_mount(struct fuse_client * c) + volume->mapping=req->map; + afp_detect_mapping(volume); + +- snprintf(volume->mountpoint,255,req->mountpoint); ++ snprintf(volume->mountpoint,255,"%s",req->mountpoint); + + /* Create the new thread and block until we get an answer back */ + { +diff --git a/lib/afp_url.c b/lib/afp_url.c +index 42bac1c..f152d7b 100644 +--- a/lib/afp_url.c ++++ b/lib/afp_url.c +@@ -233,7 +233,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) + } + } + +- snprintf(url->servername,strlen(p)+1,p); ++ snprintf(url->servername,strlen(p)+1,"%s",p); + if (check_servername(url->servername)) { + if (verbose) printf("This isn't a valid servername\n"); + return -1; +@@ -263,7 +263,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) + if ((q=escape_strrchr(p,':',":"))) { + *q='\0'; + q++; +- snprintf(url->password,strlen(q)+1,q); ++ snprintf(url->password,strlen(q)+1,"%s",q); + if (check_password(url->password)) { + if (verbose) printf("This isn't a valid passwd\n"); + return -1; +@@ -276,7 +276,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) + if ((q=strstr(p,";AUTH="))) { + *q='\0'; + q+=6; +- snprintf(url->uamname,strlen(q)+1,q); ++ snprintf(url->uamname,strlen(q)+1,"%s",q); + if (check_uamname(url->uamname)) { + if (verbose) printf("This isn't a valid uamname\n"); + return -1; +@@ -284,7 +284,7 @@ int afp_parse_url(struct afp_url * url, const char * toparse, int verbose) + } + + if (strlen(p)>0) { +- snprintf(url->username,strlen(p)+1,p); ++ snprintf(url->username,strlen(p)+1,"%s",p); + if (check_username(url->username)) { + if (verbose) printf("This isn't a valid username\n"); + return -1;; +@@ -304,12 +304,12 @@ parse_secondpart: + *q='\0'; + q++; + } +- snprintf(url->volumename,strlen(p)+1,p); ++ snprintf(url->volumename,strlen(p)+1,"%s",p); + + + if (q) { + url->path[0]='/'; +- snprintf(url->path+1,strlen(q)+1,q); ++ snprintf(url->path+1,strlen(q)+1,"%s",q); + } + + done: +-- +1.8.4.2 + diff --git a/afpfs-ng-0.8.1-longoptions.patch b/afpfs-ng-0.8.1-longoptions.patch new file mode 100644 index 0000000..883f095 --- /dev/null +++ b/afpfs-ng-0.8.1-longoptions.patch @@ -0,0 +1,11 @@ +diff -ru afpfs-ng-0.8.1.orig/cmdline/cmdline_main.c afpfs-ng-0.8.1.new/cmdline/cmdline_main.c +--- afpfs-ng-0.8.1.orig/cmdline/cmdline_main.c 2008-02-19 01:54:53.000000000 +0000 ++++ afpfs-ng-0.8.1.new/cmdline/cmdline_main.c 2021-03-12 03:28:59.315715841 +0000 +@@ -387,6 +387,7 @@ + + struct option long_options[] = { + {"recursive",1,0,'r'}, ++ {NULL,0,NULL,0} + }; + char * url = argv[1]; + diff --git a/afpfs-ng-0.8.1-overflows.patch b/afpfs-ng-0.8.1-overflows.patch new file mode 100644 index 0000000..94399ed --- /dev/null +++ b/afpfs-ng-0.8.1-overflows.patch @@ -0,0 +1,28 @@ +Fix possible buffer overflows (given we're copying to storage of AFP_MAX_PATH, +while AFP_MAX_PATH is much smaller than PATH_MAX) + +Lubomir Rintel + +--- afpfs-ng-0.8.1/cmdline/cmdline_afp.c.overflows 2008-10-06 19:21:32.000000000 +0200 ++++ afpfs-ng-0.8.1/cmdline/cmdline_afp.c 2008-10-06 19:13:50.000000000 +0200 +@@ -129,9 +129,9 @@ + { + if (filename[0]!='/') { + if (strlen(curdir)==1) +- snprintf(server_fullname,PATH_MAX,"/%s",filename); ++ snprintf(server_fullname,AFP_MAX_PATH,"/%s",filename); + else +- snprintf(server_fullname,PATH_MAX,"%s/%s",curdir,filename); ++ snprintf(server_fullname,AFP_MAX_PATH,"%s/%s",curdir,filename); + } else { + snprintf(server_fullname,PATH_MAX,"%s",filename); + } +@@ -1217,7 +1217,7 @@ + { + struct passwd * passwd; + +- snprintf(curdir,PATH_MAX,"%s",DEFAULT_DIRECTORY); ++ snprintf(curdir,AFP_MAX_PATH,"%s",DEFAULT_DIRECTORY); + if (init_uams()<0) return -1; + + afp_default_url(&url); diff --git a/afpfs-ng-0.8.1-pointer.patch b/afpfs-ng-0.8.1-pointer.patch new file mode 100644 index 0000000..b47b834 --- /dev/null +++ b/afpfs-ng-0.8.1-pointer.patch @@ -0,0 +1,280 @@ +diff -up afpfs-ng-0.8.1/cmdline/getstatus.c.pointer afpfs-ng-0.8.1/cmdline/getstatus.c +--- afpfs-ng-0.8.1/cmdline/getstatus.c.pointer 2011-06-14 17:06:35.000000000 +0200 ++++ afpfs-ng-0.8.1/cmdline/getstatus.c 2011-06-14 17:07:25.000000000 +0200 +@@ -1,4 +1,5 @@ + #include ++#include + #include + #include + +diff -up afpfs-ng-0.8.1/fuse/client.c.pointer afpfs-ng-0.8.1/fuse/client.c +--- afpfs-ng-0.8.1/fuse/client.c.pointer 2008-03-08 03:44:16.000000000 +0100 ++++ afpfs-ng-0.8.1/fuse/client.c 2011-06-14 17:02:15.000000000 +0200 +@@ -61,8 +61,9 @@ static int start_afpfsd(void) + snprintf(filename, PATH_MAX, + "/usr/local/bin/%s",AFPFSD_FILENAME); + if (access(filename,X_OK)) { +- snprintf(filename, "/usr/bin/%s", ++ snprintf(filename, sizeof(filename), "/usr/bin/%s", + AFPFSD_FILENAME); ++ filename[sizeof(filename) - 1] = 0; + if (access(filename,X_OK)) { + printf("Could not find server (%s)\n", + filename); +diff -up afpfs-ng-0.8.1/fuse/fuse_int.c.pointer afpfs-ng-0.8.1/fuse/fuse_int.c +--- afpfs-ng-0.8.1/fuse/fuse_int.c.pointer 2008-03-02 06:06:24.000000000 +0100 ++++ afpfs-ng-0.8.1/fuse/fuse_int.c 2011-06-14 17:02:15.000000000 +0200 +@@ -197,7 +197,7 @@ static int fuse_open(const char *path, s + ret = ml_open(volume,path,flags,&fp); + + if (ret==0) +- fi->fh=(void *) fp; ++ fi->fh=(unsigned long) fp; + + return ret; + } +diff -up afpfs-ng-0.8.1/include/afp.h.pointer afpfs-ng-0.8.1/include/afp.h +--- afpfs-ng-0.8.1/include/afp.h.pointer 2008-03-08 17:08:18.000000000 +0100 ++++ afpfs-ng-0.8.1/include/afp.h 2011-06-14 17:02:15.000000000 +0200 +@@ -370,7 +370,7 @@ int afp_unmount_all_volumes(struct afp_s + + int afp_opendt(struct afp_volume *volume, unsigned short * refnum); + +-int afp_closedt(struct afp_server * server, unsigned short * refnum); ++int afp_closedt(struct afp_server * server, unsigned short refnum); + + int afp_getcomment(struct afp_volume *volume, unsigned int did, + const char * pathname, struct afp_comment * comment); +diff -up afpfs-ng-0.8.1/include/utils.h.pointer afpfs-ng-0.8.1/include/utils.h +--- afpfs-ng-0.8.1/include/utils.h.pointer 2008-02-18 04:33:58.000000000 +0100 ++++ afpfs-ng-0.8.1/include/utils.h 2011-06-14 17:02:15.000000000 +0200 +@@ -8,8 +8,8 @@ + #define hton64(x) (x) + #define ntoh64(x) (x) + #else /* BYTE_ORDER == BIG_ENDIAN */ +-#define hton64(x) ((u_int64_t) (htonl(((x) >> 32) & 0xffffffffLL)) | \ +- (u_int64_t) ((htonl(x) & 0xffffffffLL) << 32)) ++#define hton64(x) ((u_int64_t) (htonl((((unsigned long long)(x)) >> 32) & 0xffffffffLL)) | \ ++ (u_int64_t) ((htonl((unsigned long long)(x)) & 0xffffffffLL) << 32)) + #define ntoh64(x) (hton64(x)) + #endif /* BYTE_ORDER == BIG_ENDIAN */ + +diff -up afpfs-ng-0.8.1/lib/afp_url.c.pointer afpfs-ng-0.8.1/lib/afp_url.c +--- afpfs-ng-0.8.1/lib/afp_url.c.pointer 2008-03-04 21:16:49.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/afp_url.c 2011-06-14 17:02:15.000000000 +0200 +@@ -33,7 +33,7 @@ static int check_port(char * port) + static int check_uamname(const char * uam) + { + char * p; +- for (p=uam;*p;p++) { ++ for (p=(char *)uam;*p;p++) { + if (*p==' ') continue; + if ((*p<'A') || (*p>'z')) return -1; + } +@@ -188,7 +188,7 @@ int afp_parse_url(struct afp_url * url, + return -1; + + } +- if (p==NULL) p=toparse; ++ if (p==NULL) p=(char *)toparse; + + /* Now split on the first / */ + if (sscanf(p,"%[^/]/%[^$]", +diff -up afpfs-ng-0.8.1/lib/did.c.pointer afpfs-ng-0.8.1/lib/did.c +--- afpfs-ng-0.8.1/lib/did.c.pointer 2008-02-18 04:39:17.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/did.c 2011-06-14 17:02:15.000000000 +0200 +@@ -226,7 +226,7 @@ int get_dirid(struct afp_volume * volume + + + /* Go to the end of last known entry */ +- p=path+(p-copy); ++ p=(char *)path+(p-copy); + p2=p; + + while ((p=strchr(p+1,'/'))) { +diff -up afpfs-ng-0.8.1/lib/dsi.c.pointer afpfs-ng-0.8.1/lib/dsi.c +--- afpfs-ng-0.8.1/lib/dsi.c.pointer 2008-02-18 04:53:03.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/dsi.c 2011-06-14 17:02:15.000000000 +0200 +@@ -474,7 +474,7 @@ void dsi_getstatus_reply(struct afp_serv + } + server->flags=ntohs(reply1->flags); + +- p=(void *)((unsigned int) server->incoming_buffer + sizeof(*reply1)); ++ p=(void *)((unsigned long) server->incoming_buffer + sizeof(*reply1)); + p+=copy_from_pascal(server->server_name,p,AFP_SERVER_NAME_LEN)+1; + + /* Now work our way through the variable bits */ +@@ -757,7 +757,7 @@ gotenough: + printf("<<< read() of rest of AFP, %d bytes\n",amount_to_read); + #endif + ret = read(server->fd, (void *) +- (((unsigned int) server->incoming_buffer)+server->data_read), ++ (((unsigned long) server->incoming_buffer)+server->data_read), + amount_to_read); + if (ret<0) return -1; + if (ret==0) { +diff -up afpfs-ng-0.8.1/lib/loop.c.pointer afpfs-ng-0.8.1/lib/loop.c +--- afpfs-ng-0.8.1/lib/loop.c.pointer 2008-02-18 04:40:11.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/loop.c 2011-06-14 17:02:15.000000000 +0200 +@@ -25,7 +25,7 @@ + static unsigned char exit_program=0; + + static pthread_t ending_thread; +-static pthread_t main_thread = NULL; ++static pthread_t main_thread = (pthread_t)NULL; + + static int loop_started=0; + static pthread_cond_t loop_started_condition; +diff -up afpfs-ng-0.8.1/lib/lowlevel.c.pointer afpfs-ng-0.8.1/lib/lowlevel.c +--- afpfs-ng-0.8.1/lib/lowlevel.c.pointer 2008-02-20 02:33:17.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/lowlevel.c 2011-06-14 17:02:15.000000000 +0200 +@@ -582,7 +582,7 @@ int ll_getattr(struct afp_volume * volum + if (volume->server->using_version->av_number>=30) + stbuf->st_mode |= fp.unixprivs.permissions; + else +- set_nonunix_perms(stbuf,&fp); ++ set_nonunix_perms(&stbuf->st_mode,&fp); + + stbuf->st_uid=fp.unixprivs.uid; + stbuf->st_gid=fp.unixprivs.gid; +diff -up afpfs-ng-0.8.1/lib/midlevel.c.pointer afpfs-ng-0.8.1/lib/midlevel.c +--- afpfs-ng-0.8.1/lib/midlevel.c.pointer 2008-03-08 17:08:18.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/midlevel.c 2011-06-14 17:02:15.000000000 +0200 +@@ -713,7 +713,7 @@ int ml_write(struct afp_volume * volume, + { + + int ret,err=0; +- int totalwritten = 0; ++ size_t totalwritten = 0; + uint64_t sizetowrite, ignored; + unsigned char flags = 0; + unsigned int max_packet_size=volume->server->tx_quantum; +diff -up afpfs-ng-0.8.1/lib/proto_attr.c.pointer afpfs-ng-0.8.1/lib/proto_attr.c +--- afpfs-ng-0.8.1/lib/proto_attr.c.pointer 2008-01-30 05:37:58.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/proto_attr.c 2011-06-14 17:02:15.000000000 +0200 +@@ -166,7 +166,7 @@ int afp_getextattr(struct afp_volume * v + copy_path(server,p,pathname,strlen(pathname)); + unixpath_to_afppath(server,p); + p2=p+sizeof_path_header(server)+strlen(pathname); +- if (((unsigned int ) p2) & 0x1) p2++; ++ if (((unsigned long) p2) & 0x1) p2++; + req2=(void *) p2; + + req2->len=htons(namelen); +diff -up afpfs-ng-0.8.1/lib/proto_desktop.c.pointer afpfs-ng-0.8.1/lib/proto_desktop.c +--- afpfs-ng-0.8.1/lib/proto_desktop.c.pointer 2008-02-18 04:44:11.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/proto_desktop.c 2011-06-14 17:02:15.000000000 +0200 +@@ -168,7 +168,7 @@ int afp_getcomment_reply(struct afp_serv + return 0; + } + +-int afp_closedt(struct afp_server * server, unsigned short * refnum) ++int afp_closedt(struct afp_server * server, unsigned short refnum) + { + struct { + struct dsi_header dsi_header __attribute__((__packed__)); +diff -up afpfs-ng-0.8.1/lib/proto_directory.c.pointer afpfs-ng-0.8.1/lib/proto_directory.c +--- afpfs-ng-0.8.1/lib/proto_directory.c.pointer 2008-02-19 03:39:29.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/proto_directory.c 2011-06-14 17:02:15.000000000 +0200 +@@ -248,6 +248,7 @@ int afp_enumerate_reply(struct afp_serve + + return 0; + } ++ + int afp_enumerateext2_reply(struct afp_server *server, char * buf, unsigned int size, void * other) + { + +@@ -266,8 +267,7 @@ int afp_enumerateext2_reply(struct afp_s + char * p = buf + sizeof(*reply); + int i; + char *max=buf+size; +- struct afp_file_info * filebase = NULL, *filecur=NULL, *new_file=NULL; +- void ** x = other; ++ struct afp_file_info * filebase = NULL, *filecur = NULL, *new_file = NULL, **x = (struct afp_file_info **) other; + + if (reply->dsi_header.return_code.error_code) { + return reply->dsi_header.return_code.error_code; +diff -up afpfs-ng-0.8.1/lib/proto_map.c.pointer afpfs-ng-0.8.1/lib/proto_map.c +--- afpfs-ng-0.8.1/lib/proto_map.c.pointer 2008-01-30 05:37:59.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/proto_map.c 2011-06-14 17:02:15.000000000 +0200 +@@ -122,7 +122,7 @@ int afp_mapid_reply(struct afp_server *s + + if (reply->header.return_code.error_code!=kFPNoErr) return -1; + +- copy_from_pascal_two(name,&reply->name,255); ++ copy_from_pascal_two(name,reply->name,255); + + return 0; + } +diff -up afpfs-ng-0.8.1/lib/proto_session.c.pointer afpfs-ng-0.8.1/lib/proto_session.c +--- afpfs-ng-0.8.1/lib/proto_session.c.pointer 2008-02-18 04:46:19.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/proto_session.c 2011-06-14 17:02:15.000000000 +0200 +@@ -39,7 +39,7 @@ int afp_getsessiontoken(struct afp_serve + switch (type) { + case kLoginWithTimeAndID: + case kReconnWithTimeAndID: { +- uint32_t *p = (void *) (((unsigned int) request)+ ++ uint32_t *p = (void *) (((unsigned long) request)+ + sizeof(*request)); + + offset=sizeof(timestamp); +@@ -63,7 +63,7 @@ int afp_getsessiontoken(struct afp_serve + goto error; + } + +- data=(void *) (((unsigned int) request)+sizeof(*request)+offset); ++ data=(void *) (((unsigned long) request)+sizeof(*request)+offset); + request->idlength=htonl(datalen); + request->pad=0; + request->type=htons(type); +@@ -127,7 +127,7 @@ int afp_disconnectoldsession(struct afp_ + if ((request=malloc(sizeof(*request) + AFP_TOKEN_MAX_LEN))==NULL) + return -1; + +- token_data = request + sizeof(*request); ++ token_data = (char *)request + sizeof(*request); + + request->type=htons(type); + +diff -up afpfs-ng-0.8.1/lib/uams.c.pointer afpfs-ng-0.8.1/lib/uams.c +--- afpfs-ng-0.8.1/lib/uams.c.pointer 2008-01-04 04:52:44.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/uams.c 2011-06-14 17:02:15.000000000 +0200 +@@ -180,7 +180,7 @@ static int cleartxt_login(struct afp_ser + goto cleartxt_fail; + + p += copy_to_pascal(p, username) + 1; +- if ((int)p & 0x1) ++ if ((long)p & 0x1) + len--; + else + p++; +@@ -230,7 +230,7 @@ static int cleartxt_passwd(struct afp_se + goto cleartxt_fail; + + p += copy_to_pascal(p, username) + 1; +- if ((int)p & 0x1) ++ if ((long)p & 0x1) + len--; + else + p++; +@@ -580,7 +580,7 @@ static int dhx_login(struct afp_server * + if (ai == NULL) + goto dhx_noctx_fail; + d += copy_to_pascal(ai, username) + 1; +- if (((int)d) % 2) ++ if (((long)d) % 2) + d++; + else + ai_len--; +diff -up afpfs-ng-0.8.1/lib/utils.c.pointer afpfs-ng-0.8.1/lib/utils.c +--- afpfs-ng-0.8.1/lib/utils.c.pointer 2008-02-18 04:53:37.000000000 +0100 ++++ afpfs-ng-0.8.1/lib/utils.c 2011-06-14 17:02:15.000000000 +0200 +@@ -196,7 +196,7 @@ int invalid_filename(struct afp_server * + maxlen=255; + + +- p=filename+1; ++ p=(char *)filename+1; + while ((q=strchr(p,'/'))) { + if (q>p+maxlen) + return 1; diff --git a/afpfs-ng-c99.patch b/afpfs-ng-c99.patch new file mode 100644 index 0000000..ea7c282 --- /dev/null +++ b/afpfs-ng-c99.patch @@ -0,0 +1,164 @@ +Add additional #include directives for more function prototypes, +to avoid implicit function declarations. Declare appledouble_write, +cmdline_afp_setup_client in the appropriate header files. + +These changes expose an argument type mismatch in the function +appledouble_truncate, in the calls to remove_opened_fork. This may +or may have not worked before, depending on how the ABI implements +passing this struct by value. + +The use of basename in start_afpfsd is suspect; this should probaby use +dirname instead. + +Submitted upstream: + +diff --git a/cmdline/cmdline_afp.h b/cmdline/cmdline_afp.h +index ebdf357fc952972c..e0ec4570f69b71ec 100644 +--- a/cmdline/cmdline_afp.h ++++ b/cmdline/cmdline_afp.h +@@ -28,5 +28,6 @@ int com_disconnect(char * arg); + void cmdline_afp_exit(void); + + int cmdline_afp_setup(int recursive, char * url_string); ++void cmdline_afp_setup_client(void); + + #endif +diff --git a/cmdline/cmdline_main.c b/cmdline/cmdline_main.c +index ffb39ebacb8f262c..deccf8a4cc342bf0 100644 +--- a/cmdline/cmdline_main.c ++++ b/cmdline/cmdline_main.c +@@ -17,6 +17,7 @@ + #include + #include + #include ++#include "afp.h" + #include "cmdline_afp.h" + #include "cmdline_testafp.h" + +diff --git a/fuse/client.c b/fuse/client.c +index d19e9efb2dcb60b7..beceaa5594a89b80 100644 +--- a/fuse/client.c ++++ b/fuse/client.c +@@ -10,6 +10,7 @@ + #include + #include + #include ++#include + + #include "config.h" + #include +diff --git a/fuse/daemon.c b/fuse/daemon.c +index 8b3b8d9146633518..abf6c02e390142b2 100644 +--- a/fuse/daemon.c ++++ b/fuse/daemon.c +@@ -23,6 +23,8 @@ + #include + #include + ++#include ++ + #include "afp.h" + + #include "dsi.h" +diff --git a/lib/dsi.c b/lib/dsi.c +index 8a469794542ec447..3fd10fb24c770ca8 100644 +--- a/lib/dsi.c ++++ b/lib/dsi.c +@@ -27,6 +27,7 @@ + #include "libafpclient.h" + #include "afp_internal.h" + #include "afp_replies.h" ++#include "codepage.h" + + /* define this in order to get reams of DSI debugging information */ + #undef DEBUG_DSI +diff --git a/lib/lowlevel.c b/lib/lowlevel.c +index f3b632c2ae2da763..1edc9cdce5cc8429 100644 +--- a/lib/lowlevel.c ++++ b/lib/lowlevel.c +@@ -25,6 +25,8 @@ + #include "utils.h" + #include "did.h" + #include "users.h" ++#include "midlevel.h" ++#include "forklist.h" + + static void set_nonunix_perms(unsigned int * mode, struct afp_file_info *fp) + { +diff --git a/lib/proto_files.c b/lib/proto_files.c +index 933956da6a6d2ce6..d2acd562a2671869 100644 +--- a/lib/proto_files.c ++++ b/lib/proto_files.c +@@ -14,6 +14,7 @@ + #include "dsi_protocol.h" + #include "afp_protocol.h" + #include "afp_internal.h" ++#include "afp_replies.h" + + /* afp_setfileparms, afp_setdirparms and afpsetfiledirparms are all remarkably + similiar. We abstract them to afp-setparms_lowlevel. */ +diff --git a/lib/proto_replyblock.c b/lib/proto_replyblock.c +index f66791614a52ca3d..c59629b24ab83cec 100644 +--- a/lib/proto_replyblock.c ++++ b/lib/proto_replyblock.c +@@ -10,6 +10,7 @@ + #include "afp.h" + #include "utils.h" + #include "afp_internal.h" ++#include "afp_replies.h" + + + /* FIXME: should do bounds checking */ +diff --git a/lib/resource.c b/lib/resource.c +index 6be4a5b1de51fec5..fb39889f0d7702c0 100644 +--- a/lib/resource.c ++++ b/lib/resource.c +@@ -8,6 +8,7 @@ + #include "lowlevel.h" + #include "did.h" + #include "midlevel.h" ++#include "forklist.h" + + #define appledouble ".AppleDouble" + #define finderinfo_string ".finderinfo" +@@ -362,12 +363,12 @@ int appledouble_truncate(struct afp_volume * volume, const char * path, int offs + ret=ll_zero_file(volume,fp.forkid,0); + if (ret<0) { + afp_closefork(volume,fp.forkid); +- remove_opened_fork(volume,fp); ++ remove_opened_fork(volume,&fp); + free(newpath); + return ret; + } + afp_closefork(volume,fp.forkid); +- remove_opened_fork(volume,fp); ++ remove_opened_fork(volume,&fp); + + return 1; + case AFP_META_APPLEDOUBLE: +diff --git a/lib/resource.h b/lib/resource.h +index 6a0d38a6275dd6f5..2efff106c94e6637 100644 +--- a/lib/resource.h ++++ b/lib/resource.h +@@ -31,6 +31,9 @@ int appledouble_read(struct afp_volume * volume, struct afp_file_info *fp, + + int appledouble_close(struct afp_volume * volume, struct afp_file_info * fp); + ++int appledouble_write(struct afp_volume * volume, struct afp_file_info *fp, ++ const char *data, size_t size, off_t offset, size_t *totalwritten); ++ + int appledouble_chmod(struct afp_volume * volume, const char * path, mode_t mode); + + int appledouble_unlink(struct afp_volume * volume, const char *path); +diff --git a/lib/server.c b/lib/server.c +index 977c418efccae88b..93400dd92a4c0af6 100644 +--- a/lib/server.c ++++ b/lib/server.c +@@ -7,6 +7,7 @@ + + #include + #include ++#include + + #include "afp.h" + #include "dsi.h" diff --git a/afpfs-ng.spec b/afpfs-ng.spec new file mode 100644 index 0000000..b686810 --- /dev/null +++ b/afpfs-ng.spec @@ -0,0 +1,267 @@ +Name: afpfs-ng +Version: 0.8.1 +Release: 48%{?dist} +Summary: Apple Filing Protocol client + + +# by default build with the fuse module +# rpmbuild --rebuild afpfs-ng.src.rpm --without fuse +%bcond_without fuse + + +License: GPL-1.0-or-later +URL: http://alexthepuffin.googlepages.com/home +Source0: http://downloads.sourceforge.net/afpfs-ng/%{name}-%{version}.tar.bz2 +Patch0: afpfs-ng-0.8.1-overflows.patch +Patch1: afpfs-ng-0.8.1-pointer.patch +# Sent by e-mail to Alex deVries +Patch2: afpfs-ng-0.8.1-formatsec.patch +Patch3: afpfs-ng-0.8.1-longoptions.patch +Patch4: afpfs-ng-c99.patch + +%{?with_fuse:BuildRequires: fuse-devel} +BuildRequires: gcc +BuildRequires: libgcrypt-devel gmp-devel readline-devel +BuildRequires: make +BuildRequires: libtool +BuildRequires: autoconf + + +%description +A command line client to access files exported from Mac OS system via +Apple Filing Protocol. +%{?with_fuse:The FUSE filesystem module for AFP is in fuse-afp package} + + +%if 0%{?with_fuse} +%package -n fuse-afp +Summary: FUSE driver for AFP filesystem + +%description -n fuse-afp +A FUSE file system server to access files exported from Mac OS system +via AppleTalk or TCP using Apple Filing Protocol. +The command line client for AFP is in fuse-afp package +%endif + + +%package devel +Summary: Development files for afpfs-ng +Requires: %{name} = %{version} + +%description devel +Library for dynamic linking and header files of afpfs-ng. + +%prep +%autosetup -p 1 +libtoolize +autoreconf + +%build +# make would rebuild the autoconf infrastructure due to the following: +# Prerequisite `configure.ac' is newer than target `Makefile.in'. +# Prerequisite `aclocal.m4' is newer than target `Makefile.in'. +# Prerequisite `configure.ac' is newer than target `aclocal.m4'. +touch --reference aclocal.m4 configure.ac Makefile.in + +export CFLAGS="${RPM_OPT_FLAGS} -fcommon" +%configure %{?!with_fuse:--disable-fuse} --disable-static +make %{?_smp_mflags} + + +%install +%make_install +install -d %{buildroot}%{_includedir}/afpfs-ng +cp -p include/* %{buildroot}%{_includedir}/afpfs-ng +# libtool .la file works different in different versions of libtool, should not be packaged +[ -f %{buildroot}%{_libdir}/libafpclient.la ] && rm -f %{buildroot}%{_libdir}/libafpclient.la + +%if ( 0%{?rhel} && 0%{?rhel} <= 7 ) +%ldconfig_scriptlets +%endif + + +%files +%license COPYING +%{_bindir}/afpcmd +%{_bindir}/afpgetstatus +%{_mandir}/man1/afpcmd.1* +%{_mandir}/man1/afpgetstatus.1* +%{_libdir}/libafpclient.so.* +%doc AUTHORS ChangeLog docs/README docs/performance docs/FEATURES.txt docs/REPORTING-BUGS.txt + + +%if 0%{?with_fuse} +%files -n fuse-afp +%license COPYING +%{_bindir}/afp_client +%{_bindir}/afpfs +%{_bindir}/afpfsd +%{_bindir}/mount_afp +%{_mandir}/man1/afp_client.1* +%{_mandir}/man1/afpfsd.1* +%{_mandir}/man1/mount_afp.1* +%doc AUTHORS ChangeLog +%endif + + +%files devel +%{_includedir}/afpfs-ng +%{_libdir}/*.so + +%changelog +* Thu Jan 16 2025 Fedora Release Engineering - 0.8.1-48 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild + +* Wed Jul 17 2024 Fedora Release Engineering - 0.8.1-47 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild + +* Mon Jun 17 2024 Miroslav Suchý - 0.8.1-46 +- convert license to SPDX + +* Mon Jan 22 2024 Fedora Release Engineering - 0.8.1-45 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + +* Fri Jan 19 2024 Fedora Release Engineering - 0.8.1-44 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + +* Wed Jul 19 2023 Fedora Release Engineering - 0.8.1-43 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + +* Wed Jan 18 2023 Fedora Release Engineering - 0.8.1-42 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + +* Wed Dec 21 2022 Florian Weimer - 0.8.1-41 +- Port to C99 + +* Tue Oct 25 2022 Michal Ambroz - 0.8.1-40 +- remove the libafpclient.la libtool file + +* Wed Jul 20 2022 Fedora Release Engineering - 0.8.1-39 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + +* Wed Jan 19 2022 Fedora Release Engineering - 0.8.1-38 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Wed Nov 17 2021 Michal Ambroz - 0.8.1-37 +- update embedded libtool (ltmain.sh) + +* Wed Jul 21 2021 Fedora Release Engineering - 0.8.1-36 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Mon Apr 26 2021 Michal Ambroz - 0.8.1-35 +- modernize spec, push the bugfix to active branches + +* Fri Mar 12 2021 Michal Ambroz - 0.8.1-34 +- fix issue 1507944 + +* Mon Jan 25 2021 Fedora Release Engineering - 0.8.1-33 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Fri Jul 31 2020 Fedora Release Engineering - 0.8.1-32 +- Second attempt - Rebuilt for + https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Jul 27 2020 Fedora Release Engineering - 0.8.1-31 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Wed Apr 22 2020 Michal Ambroz - 0.8.1-30 +- fix FTBFS - multiple definition of - build legacy code with -fcommon + +* Tue Jan 28 2020 Fedora Release Engineering - 0.8.1-29 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Wed Jul 24 2019 Fedora Release Engineering - 0.8.1-28 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Sun Feb 17 2019 Igor Gnatenko - 0.8.1-27 +- Rebuild for readline 8.0 + +* Thu Jan 31 2019 Fedora Release Engineering - 0.8.1-26 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Thu Jul 12 2018 Fedora Release Engineering - 0.8.1-25 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + +* Wed Feb 07 2018 Fedora Release Engineering - 0.8.1-24 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Wed Aug 02 2017 Fedora Release Engineering - 0.8.1-23 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild + +* Wed Jul 26 2017 Fedora Release Engineering - 0.8.1-22 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild + +* Fri Feb 10 2017 Fedora Release Engineering - 0.8.1-21 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild + +* Wed Feb 03 2016 Fedora Release Engineering - 0.8.1-20 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild + +* Tue Jun 16 2015 Fedora Release Engineering - 0.8.1-19 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild + +* Tue Nov 25 2014 - 0.8.1-18 +- Fix mount_afp crash (RHBZ #1165296) + +* Fri Aug 15 2014 Fedora Release Engineering - 0.8.1-17 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild + +* Sat Jun 07 2014 Fedora Release Engineering - 0.8.1-16 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild + +* Tue Apr 22 2014 Tomáš Mráz - 0.8.1-15 +- Rebuild for new libgcrypt + +* Wed Dec 04 2013 Lubomir Rintel - 0.8.1-14 +- Fix build with -Werror=format-security + +* Thu Oct 24 2013 Lubomir Rintel - 0.8.1-13.3 +- Bulk sad and useless attempt at consistent SPEC file formatting + +* Sat Aug 03 2013 Fedora Release Engineering - 0.8.1-12.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild + +* Wed Feb 13 2013 Fedora Release Engineering - 0.8.1-11.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild + +* Wed Jul 18 2012 Fedora Release Engineering - 0.8.1-10.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild + +* Thu Jan 12 2012 Fedora Release Engineering - 0.8.1-9.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild + +* Thu Oct 20 2011 Marcela Mašláňová - 0.8.1-8.3 +- rebuild with new gmp without compat lib + +* Mon Oct 10 2011 Peter Schiffer - 0.8.1-8.2 +- rebuild with new gmp + +* Mon Sep 26 2011 Peter Schiffer - 0.8.1-8.1 +- rebuild with new gmp + +* Mon Jul 4 2011 Jan F. Chadima - 0.8.1-8 +- Repair ponter arithmetic + +* Mon Feb 07 2011 Fedora Release Engineering - 0.8.1-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild + +* Thu Sep 17 2009 Peter Lemenkov - 0.8.1-6 +- Rebuild with new fuse + +* Fri Jul 24 2009 Fedora Release Engineering - 0.8.1-5 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild + +* Fri Jul 17 2009 Lubomir Rintel - 0.8.1-4 +- Don't refer to AppleTalk in Summary + +* Tue Jul 14 2009 Lubomir Rintel - 0.8.1-3 +- Fix up license tag + +* Thu Mar 19 2009 Lubomir Rintel - 0.8.1-2 +- Add more include files (Jan F. Chadima) +- Don't needlessly build static library (Stefan Kasal) +- Fix fuse-afp summary (Stefan Kasal) +- Remove redundant license file from -devel (Stefan Kasal) + +* Mon Oct 6 2008 Lubomir Rintel - 0.8.1-1 +- Initial packaging attempt diff --git a/dead.package b/dead.package deleted file mode 100644 index b37fb02..0000000 --- a/dead.package +++ /dev/null @@ -1 +0,0 @@ -Retired: https://lists.fedoraproject.org/archives/list/devel-announce@lists.fedoraproject.org/thread/DRIWVJ7BVL3KVVX5TLC36LJPDMAO72HF/ diff --git a/sources b/sources new file mode 100644 index 0000000..4bd856f --- /dev/null +++ b/sources @@ -0,0 +1 @@ +1bdd9f8a06e6085ea4cc38ce010ef60b afpfs-ng-0.8.1.tar.bz2 From 02badb24224703ed5e711c95bf86db934932a6fb Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Fri, 7 Feb 2025 12:25:35 +0100 Subject: [PATCH 20/23] adding changelog --- changelog | 147 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 147 insertions(+) create mode 100644 changelog diff --git a/changelog b/changelog new file mode 100644 index 0000000..b96c06b --- /dev/null +++ b/changelog @@ -0,0 +1,147 @@ +* Mon Jan 22 2024 Fedora Release Engineering - 0.8.1-45 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + +* Fri Jan 19 2024 Fedora Release Engineering - 0.8.1-44 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + +* Wed Jul 19 2023 Fedora Release Engineering - 0.8.1-43 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + +* Wed Jan 18 2023 Fedora Release Engineering - 0.8.1-42 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + +* Wed Dec 21 2022 Florian Weimer - 0.8.1-41 +- Port to C99 + +* Tue Oct 25 2022 Michal Ambroz - 0.8.1-40 +- remove the libafpclient.la libtool file + +* Wed Jul 20 2022 Fedora Release Engineering - 0.8.1-39 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + +* Wed Jan 19 2022 Fedora Release Engineering - 0.8.1-38 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + +* Wed Nov 17 2021 Michal Ambroz - 0.8.1-37 +- update embedded libtool (ltmain.sh) + +* Wed Jul 21 2021 Fedora Release Engineering - 0.8.1-36 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + +* Mon Apr 26 2021 Michal Ambroz - 0.8.1-35 +- modernize spec, push the bugfix to active branches + +* Fri Mar 12 2021 Michal Ambroz - 0.8.1-34 +- fix issue 1507944 + +* Mon Jan 25 2021 Fedora Release Engineering - 0.8.1-33 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + +* Fri Jul 31 2020 Fedora Release Engineering - 0.8.1-32 +- Second attempt - Rebuilt for + https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Mon Jul 27 2020 Fedora Release Engineering - 0.8.1-31 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + +* Wed Apr 22 2020 Michal Ambroz - 0.8.1-30 +- fix FTBFS - multiple definition of - build legacy code with -fcommon + +* Tue Jan 28 2020 Fedora Release Engineering - 0.8.1-29 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + +* Wed Jul 24 2019 Fedora Release Engineering - 0.8.1-28 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + +* Sun Feb 17 2019 Igor Gnatenko - 0.8.1-27 +- Rebuild for readline 8.0 + +* Thu Jan 31 2019 Fedora Release Engineering - 0.8.1-26 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + +* Thu Jul 12 2018 Fedora Release Engineering - 0.8.1-25 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + +* Wed Feb 07 2018 Fedora Release Engineering - 0.8.1-24 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + +* Wed Aug 02 2017 Fedora Release Engineering - 0.8.1-23 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild + +* Wed Jul 26 2017 Fedora Release Engineering - 0.8.1-22 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild + +* Fri Feb 10 2017 Fedora Release Engineering - 0.8.1-21 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild + +* Wed Feb 03 2016 Fedora Release Engineering - 0.8.1-20 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild + +* Tue Jun 16 2015 Fedora Release Engineering - 0.8.1-19 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild + +* Tue Nov 25 2014 - 0.8.1-18 +- Fix mount_afp crash (RHBZ #1165296) + +* Fri Aug 15 2014 Fedora Release Engineering - 0.8.1-17 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild + +* Sat Jun 07 2014 Fedora Release Engineering - 0.8.1-16 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild + +* Tue Apr 22 2014 Tomáš Mráz - 0.8.1-15 +- Rebuild for new libgcrypt + +* Wed Dec 04 2013 Lubomir Rintel - 0.8.1-14 +- Fix build with -Werror=format-security + +* Thu Oct 24 2013 Lubomir Rintel - 0.8.1-13.3 +- Bulk sad and useless attempt at consistent SPEC file formatting + +* Sat Aug 03 2013 Fedora Release Engineering - 0.8.1-12.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild + +* Wed Feb 13 2013 Fedora Release Engineering - 0.8.1-11.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild + +* Wed Jul 18 2012 Fedora Release Engineering - 0.8.1-10.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild + +* Thu Jan 12 2012 Fedora Release Engineering - 0.8.1-9.3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild + +* Thu Oct 20 2011 Marcela Mašláňová - 0.8.1-8.3 +- rebuild with new gmp without compat lib + +* Mon Oct 10 2011 Peter Schiffer - 0.8.1-8.2 +- rebuild with new gmp + +* Mon Sep 26 2011 Peter Schiffer - 0.8.1-8.1 +- rebuild with new gmp + +* Mon Jul 4 2011 Jan F. Chadima - 0.8.1-8 +- Repair ponter arithmetic + +* Mon Feb 07 2011 Fedora Release Engineering - 0.8.1-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild + +* Thu Sep 17 2009 Peter Lemenkov - 0.8.1-6 +- Rebuild with new fuse + +* Fri Jul 24 2009 Fedora Release Engineering - 0.8.1-5 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild + +* Fri Jul 17 2009 Lubomir Rintel - 0.8.1-4 +- Don't refer to AppleTalk in Summary + +* Tue Jul 14 2009 Lubomir Rintel - 0.8.1-3 +- Fix up license tag + +* Thu Mar 19 2009 Lubomir Rintel - 0.8.1-2 +- Add more include files (Jan F. Chadima) +- Don't needlessly build static library (Stefan Kasal) +- Fix fuse-afp summary (Stefan Kasal) +- Remove redundant license file from -devel (Stefan Kasal) + +* Mon Oct 6 2008 Lubomir Rintel - 0.8.1-1 +- Initial packaging attempt From d0216f4017b11addaaa0090677e5a33cab2063be Mon Sep 17 00:00:00 2001 From: Michal Ambroz Date: Fri, 7 Feb 2025 12:27:34 +0100 Subject: [PATCH 21/23] rebuild with gcc15 + fedora hardening --- ...s-ng-c99.patch => afpfs-ng-0.8.1-c99.patch | 0 afpfs-ng-0.8.1-pointer2.patch | 109 ++++++++++++ afpfs-ng-0.8.1-tests.patch | 30 ++++ afpfs-ng.spec | 167 +----------------- 4 files changed, 146 insertions(+), 160 deletions(-) rename afpfs-ng-c99.patch => afpfs-ng-0.8.1-c99.patch (100%) create mode 100644 afpfs-ng-0.8.1-pointer2.patch create mode 100644 afpfs-ng-0.8.1-tests.patch diff --git a/afpfs-ng-c99.patch b/afpfs-ng-0.8.1-c99.patch similarity index 100% rename from afpfs-ng-c99.patch rename to afpfs-ng-0.8.1-c99.patch diff --git a/afpfs-ng-0.8.1-pointer2.patch b/afpfs-ng-0.8.1-pointer2.patch new file mode 100644 index 0000000..854c858 --- /dev/null +++ b/afpfs-ng-0.8.1-pointer2.patch @@ -0,0 +1,109 @@ +diff -ru afpfs-ng-0.8.1.orig/lib/loop.c afpfs-ng-0.8.1.new/lib/loop.c +--- afpfs-ng-0.8.1.orig/lib/loop.c 2025-02-06 15:18:29.028488247 +0100 ++++ afpfs-ng-0.8.1.new/lib/loop.c 2025-02-06 15:02:08.261418298 +0100 +@@ -87,7 +87,7 @@ + static int ending=0; + void * just_end_it_now(void * ignore) + { +- if (ending) return; ++ if (ending) return(NULL); + ending=1; + if (libafpclient->forced_ending_hook) + libafpclient->forced_ending_hook(); +diff -ru afpfs-ng-0.8.1.orig/lib/proto_directory.c afpfs-ng-0.8.1.new/lib/proto_directory.c +--- afpfs-ng-0.8.1.orig/lib/proto_directory.c 2025-02-06 15:18:29.030488258 +0100 ++++ afpfs-ng-0.8.1.new/lib/proto_directory.c 2025-02-06 15:17:58.862309936 +0100 +@@ -16,6 +16,19 @@ + #include "dsi_protocol.h" + #include "afp_replies.h" + ++typedef struct reply_entry { ++ uint8_t size; ++ uint8_t isdir; ++}; ++ ++typedef struct ext2_reply_entry { ++ uint16_t size; ++ uint8_t isdir; ++ uint8_t pad; ++}; ++ ++ ++ + int afp_moveandrename(struct afp_volume *volume, + unsigned int src_did, + unsigned int dst_did, +@@ -200,10 +213,7 @@ + uint16_t reqcount; + } __attribute__((__packed__)) * reply = (void *) buf; + +- struct { +- uint8_t size; +- uint8_t isdir; +- } __attribute__((__packed__)) * entry; ++ struct reply_entry __attribute__((__packed__)) * entry; + char * p = buf + sizeof(*reply); + int i; + char *max=buf+size; +@@ -219,7 +229,7 @@ + } + + for (i=0;ireqcount);i++) { +- entry = (void *) p; ++ entry = ( struct reply_entry *) p; + + if (p>max) { + return -1; +@@ -259,11 +269,7 @@ + uint16_t reqcount; + } __attribute__((__packed__)) * reply = (void *) buf; + +- struct { +- uint16_t size; +- uint8_t isdir; +- uint8_t pad; +- } __attribute__((__packed__)) * entry; ++ struct ext2_reply_entry __attribute__((__packed__)) * entry; + char * p = buf + sizeof(*reply); + int i; + char *max=buf+size; +@@ -293,7 +299,7 @@ + filecur=new_file; + } + +- entry = p; ++ entry = ( struct ext2_reply_entry *) p; + + parse_reply_block(server,p+sizeof(*entry), + ntohs(entry->size),entry->isdir, +diff -ru afpfs-ng-0.8.1.orig/lib/uams.c afpfs-ng-0.8.1.new/lib/uams.c +--- afpfs-ng-0.8.1.orig/lib/uams.c 2025-02-06 15:18:29.030488258 +0100 ++++ afpfs-ng-0.8.1.new/lib/uams.c 2025-02-06 15:00:32.383809018 +0100 +@@ -36,7 +36,7 @@ + static int cleartxt_login(struct afp_server *server, char *username, + char *passwd); + static int cleartxt_passwd(struct afp_server *server, char *username, +- char *passwd); ++ char *passwd, char *newpasswd); + #ifdef HAVE_LIBGCRYPT + static int randnum_login(struct afp_server *server, char *username, + char *passwd); +@@ -49,8 +49,7 @@ + static struct afp_uam uam_noauth = + {UAM_NOUSERAUTHENT,"No User Authent",&noauth_login,NULL,NULL}; + static struct afp_uam uam_cleartxt = +- {UAM_CLEARTXTPASSWRD,"Cleartxt Passwrd",&cleartxt_login, +- &cleartxt_passwd,NULL}; ++ {UAM_CLEARTXTPASSWRD,"Cleartxt Passwrd",&cleartxt_login,&cleartxt_passwd,NULL}; + #ifdef HAVE_LIBGCRYPT + static struct afp_uam uam_randnum = + {UAM_RANDNUMEXCHANGE, "Randnum Exchange", &randnum_login,NULL,NULL}; +@@ -219,7 +218,7 @@ + * +------------------+ + */ + static int cleartxt_passwd(struct afp_server *server, +- char *username, char *passwd) { ++ char *username, char *passwd, char *newpasswd) { + + char *p, *ai = NULL; + int len, ret; diff --git a/afpfs-ng-0.8.1-tests.patch b/afpfs-ng-0.8.1-tests.patch new file mode 100644 index 0000000..7381b8d --- /dev/null +++ b/afpfs-ng-0.8.1-tests.patch @@ -0,0 +1,30 @@ +diff -ru afpfs-ng-0.8.1.old/cmdline/cmdline_testafp.c afpfs-ng-0.8.1.new/cmdline/cmdline_testafp.c +--- afpfs-ng-0.8.1.old/cmdline/cmdline_testafp.c 2025-02-06 15:22:10.187795481 +0100 ++++ afpfs-ng-0.8.1.new/cmdline/cmdline_testafp.c 2025-02-06 15:30:13.226751326 +0100 +@@ -31,7 +31,7 @@ + snprintf(valid_url.path,sizeof(valid_url.path),"%s",path); + snprintf(valid_url.username,sizeof(valid_url.username),"%s",username); + snprintf(valid_url.password,sizeof(valid_url.password),"%s",password); +- snprintf(valid_url.uamname,(valid_url.uamname),"%s",uamname); ++ snprintf(valid_url.uamname,sizeof(valid_url.uamname),"%s",uamname); + valid_url.port=port; + + if (afp_url_validate(url_string,&valid_url)) +@@ -42,7 +42,7 @@ + return 0; + } + +-int test_urls(void) ++int test_urls(char * arg) + { + + printf("Testing URL parsing\n"); +diff -ru afpfs-ng-0.8.1.old/cmdline/cmdline_testafp.h afpfs-ng-0.8.1.new/cmdline/cmdline_testafp.h +--- afpfs-ng-0.8.1.old/cmdline/cmdline_testafp.h 2008-01-05 06:00:57.000000000 +0100 ++++ afpfs-ng-0.8.1.new/cmdline/cmdline_testafp.h 2025-02-06 15:30:51.577987329 +0100 +@@ -1,4 +1,4 @@ + #ifndef __CMDLINE_TESTAFP_H_ +-int test_urls(void); ++int test_urls(char * arg); + #endif + diff --git a/afpfs-ng.spec b/afpfs-ng.spec index b686810..1a47802 100644 --- a/afpfs-ng.spec +++ b/afpfs-ng.spec @@ -1,6 +1,6 @@ Name: afpfs-ng Version: 0.8.1 -Release: 48%{?dist} +Release: %autorelease Summary: Apple Filing Protocol client @@ -9,7 +9,7 @@ Summary: Apple Filing Protocol client %bcond_without fuse -License: GPL-1.0-or-later +License: GPL-2.0-or-later URL: http://alexthepuffin.googlepages.com/home Source0: http://downloads.sourceforge.net/afpfs-ng/%{name}-%{version}.tar.bz2 Patch0: afpfs-ng-0.8.1-overflows.patch @@ -17,7 +17,9 @@ Patch1: afpfs-ng-0.8.1-pointer.patch # Sent by e-mail to Alex deVries Patch2: afpfs-ng-0.8.1-formatsec.patch Patch3: afpfs-ng-0.8.1-longoptions.patch -Patch4: afpfs-ng-c99.patch +Patch4: afpfs-ng-0.8.1-c99.patch +Patch5: afpfs-ng-0.8.1-pointer2.patch +Patch6: afpfs-ng-0.8.1-tests.patch %{?with_fuse:BuildRequires: fuse-devel} BuildRequires: gcc @@ -63,7 +65,7 @@ autoreconf # Prerequisite `configure.ac' is newer than target `aclocal.m4'. touch --reference aclocal.m4 configure.ac Makefile.in -export CFLAGS="${RPM_OPT_FLAGS} -fcommon" +export CFLAGS="${RPM_OPT_FLAGS} -fcommon -D NeedFunctionPrototypes" %configure %{?!with_fuse:--disable-fuse} --disable-static make %{?_smp_mflags} @@ -109,159 +111,4 @@ cp -p include/* %{buildroot}%{_includedir}/afpfs-ng %{_libdir}/*.so %changelog -* Thu Jan 16 2025 Fedora Release Engineering - 0.8.1-48 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild - -* Wed Jul 17 2024 Fedora Release Engineering - 0.8.1-47 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild - -* Mon Jun 17 2024 Miroslav Suchý - 0.8.1-46 -- convert license to SPDX - -* Mon Jan 22 2024 Fedora Release Engineering - 0.8.1-45 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild - -* Fri Jan 19 2024 Fedora Release Engineering - 0.8.1-44 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild - -* Wed Jul 19 2023 Fedora Release Engineering - 0.8.1-43 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild - -* Wed Jan 18 2023 Fedora Release Engineering - 0.8.1-42 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild - -* Wed Dec 21 2022 Florian Weimer - 0.8.1-41 -- Port to C99 - -* Tue Oct 25 2022 Michal Ambroz - 0.8.1-40 -- remove the libafpclient.la libtool file - -* Wed Jul 20 2022 Fedora Release Engineering - 0.8.1-39 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild - -* Wed Jan 19 2022 Fedora Release Engineering - 0.8.1-38 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild - -* Wed Nov 17 2021 Michal Ambroz - 0.8.1-37 -- update embedded libtool (ltmain.sh) - -* Wed Jul 21 2021 Fedora Release Engineering - 0.8.1-36 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild - -* Mon Apr 26 2021 Michal Ambroz - 0.8.1-35 -- modernize spec, push the bugfix to active branches - -* Fri Mar 12 2021 Michal Ambroz - 0.8.1-34 -- fix issue 1507944 - -* Mon Jan 25 2021 Fedora Release Engineering - 0.8.1-33 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild - -* Fri Jul 31 2020 Fedora Release Engineering - 0.8.1-32 -- Second attempt - Rebuilt for - https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild - -* Mon Jul 27 2020 Fedora Release Engineering - 0.8.1-31 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild - -* Wed Apr 22 2020 Michal Ambroz - 0.8.1-30 -- fix FTBFS - multiple definition of - build legacy code with -fcommon - -* Tue Jan 28 2020 Fedora Release Engineering - 0.8.1-29 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild - -* Wed Jul 24 2019 Fedora Release Engineering - 0.8.1-28 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild - -* Sun Feb 17 2019 Igor Gnatenko - 0.8.1-27 -- Rebuild for readline 8.0 - -* Thu Jan 31 2019 Fedora Release Engineering - 0.8.1-26 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild - -* Thu Jul 12 2018 Fedora Release Engineering - 0.8.1-25 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild - -* Wed Feb 07 2018 Fedora Release Engineering - 0.8.1-24 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild - -* Wed Aug 02 2017 Fedora Release Engineering - 0.8.1-23 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild - -* Wed Jul 26 2017 Fedora Release Engineering - 0.8.1-22 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild - -* Fri Feb 10 2017 Fedora Release Engineering - 0.8.1-21 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild - -* Wed Feb 03 2016 Fedora Release Engineering - 0.8.1-20 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild - -* Tue Jun 16 2015 Fedora Release Engineering - 0.8.1-19 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild - -* Tue Nov 25 2014 - 0.8.1-18 -- Fix mount_afp crash (RHBZ #1165296) - -* Fri Aug 15 2014 Fedora Release Engineering - 0.8.1-17 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild - -* Sat Jun 07 2014 Fedora Release Engineering - 0.8.1-16 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild - -* Tue Apr 22 2014 Tomáš Mráz - 0.8.1-15 -- Rebuild for new libgcrypt - -* Wed Dec 04 2013 Lubomir Rintel - 0.8.1-14 -- Fix build with -Werror=format-security - -* Thu Oct 24 2013 Lubomir Rintel - 0.8.1-13.3 -- Bulk sad and useless attempt at consistent SPEC file formatting - -* Sat Aug 03 2013 Fedora Release Engineering - 0.8.1-12.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild - -* Wed Feb 13 2013 Fedora Release Engineering - 0.8.1-11.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_19_Mass_Rebuild - -* Wed Jul 18 2012 Fedora Release Engineering - 0.8.1-10.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild - -* Thu Jan 12 2012 Fedora Release Engineering - 0.8.1-9.3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild - -* Thu Oct 20 2011 Marcela Mašláňová - 0.8.1-8.3 -- rebuild with new gmp without compat lib - -* Mon Oct 10 2011 Peter Schiffer - 0.8.1-8.2 -- rebuild with new gmp - -* Mon Sep 26 2011 Peter Schiffer - 0.8.1-8.1 -- rebuild with new gmp - -* Mon Jul 4 2011 Jan F. Chadima - 0.8.1-8 -- Repair ponter arithmetic - -* Mon Feb 07 2011 Fedora Release Engineering - 0.8.1-7 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_15_Mass_Rebuild - -* Thu Sep 17 2009 Peter Lemenkov - 0.8.1-6 -- Rebuild with new fuse - -* Fri Jul 24 2009 Fedora Release Engineering - 0.8.1-5 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_12_Mass_Rebuild - -* Fri Jul 17 2009 Lubomir Rintel - 0.8.1-4 -- Don't refer to AppleTalk in Summary - -* Tue Jul 14 2009 Lubomir Rintel - 0.8.1-3 -- Fix up license tag - -* Thu Mar 19 2009 Lubomir Rintel - 0.8.1-2 -- Add more include files (Jan F. Chadima) -- Don't needlessly build static library (Stefan Kasal) -- Fix fuse-afp summary (Stefan Kasal) -- Remove redundant license file from -devel (Stefan Kasal) - -* Mon Oct 6 2008 Lubomir Rintel - 0.8.1-1 -- Initial packaging attempt +%autochangelog From 74f08aa2b16becda94a11fd5e4bc324922667cfd Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 23 Jul 2025 16:49:06 +0000 Subject: [PATCH 22/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild From 94d03d8b7ab0744574f5f517c39d12ba38ed5fd5 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 16 Jan 2026 03:30:22 +0000 Subject: [PATCH 23/23] Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild