Compare commits

..

7 commits

Author SHA1 Message Date
Adam Williamson
1c2e44fbb1 Backport PR #4125 to fix icon theme problems on KDE 2022-05-19 13:04:10 -07:00
Martin Kolman
01ccc159e1 New version 35.22.2-4
- Do not crash on dangling symlink /etc/resolv.conf (#2019579) (rvykydal)
2022-02-08 18:47:05 +01:00
Martin Kolman
7edc7e5dc6 New version 35.22.2-3
- Show correctly that no admin user is set up (#2015508) (vslavik)
2021-10-25 20:00:17 +02:00
Martin Kolman
b4170415e2 New version 35.22.2-2
Revert "Install kbd-legacy if keyboard layout is "fi" (#1955793) (vponcova)
2021-10-08 22:58:24 +02:00
Martin Kolman
a7b0e4c9b0 New version 35.22.2-1
In installer environment set static, not transient hostname (rvykydal)
Payload should wait for all storage related threads to finish (mkolman)
Set an upper bound to entered sizes (#1992585) (vponcova)
Handle new time zones in GUI after earlier switch to zoneinfo (vslavik)
Do not stretch NTP toggle in GUI (vslavik)
The NTP server dialog without entries shouldn't crash (#2001591) (vponcova)
Set hostname also from ip= static configuration without device (#1988521)
  (rvykydal)
Fix Removed options inst.[product|variant] were subsections (jkonecny)
Cleanup unneeded NFS repo with rd.live.ram parameter (mmatsuya)
2021-09-30 18:47:56 +02:00
Martin Kolman
d2764f5d6d New version 35.22.1-2
- The NTP server dialog without entries shouldn't crash (#2001591) (vponcova)
2021-09-16 15:24:43 +02:00
Martin Kolman
c3997e3075 New version 35.22.1-1
- Adjust configuration options for Fedora 35 (mkolman)
- fsset: Ignore all swap activation errors in turn_on_swap (vtrefny)
- Don't try to use line buffering in binary mode (vponcova)
- Add release notes for NTP dialog change (vslavik)
- Change the NTP server dialog design (vslavik)
- Rename spoke to Root Account (vslavik)
- Don't set default of gpt option at cmdline parsing (cheeselee)
- Change the root password spoke GUI design (vslavik)
- Add release notes for visible warnings from initrd (jkonecny)
- Split NTP dialog to its own glade file (vslavik)
2021-08-24 17:25:26 +02:00
22 changed files with 288 additions and 4102 deletions

View file

@ -1 +0,0 @@
1

195
.gitignore vendored
View file

@ -294,196 +294,5 @@
/anaconda-35.19.tar.bz2
/anaconda-35.20.tar.bz2
/anaconda-35.21.tar.bz2
/anaconda-35.22.tar.bz2
/anaconda-36.1.tar.bz2
/anaconda-36.2.tar.bz2
/anaconda-36.3.tar.bz2
/anaconda-36.4.tar.bz2
/anaconda-36.5.tar.bz2
/anaconda-36.6.tar.bz2
/anaconda-36.7.tar.bz2
/anaconda-36.8.tar.bz2
/anaconda-36.9.tar.bz2
/anaconda-36.10.tar.bz2
/anaconda-36.11.tar.bz2
/anaconda-36.12.tar.bz2
/anaconda-36.13.tar.bz2
/anaconda-36.14.tar.bz2
/anaconda-36.15.tar.bz2
/anaconda-36.16.tar.bz2
/anaconda-37.1.tar.bz2
/anaconda-37.2.tar.bz2
/anaconda-37.3.tar.bz2
/anaconda-37.4.tar.bz2
/anaconda-37.5.tar.bz2
/anaconda-37.6.tar.bz2
/anaconda-37.7.tar.bz2
/anaconda-37.8.tar.bz2
/anaconda-37.9.tar.bz2
/anaconda-37.10.tar.bz2
/anaconda-37.11.tar.bz2
/anaconda-37.12.tar.bz2
/anaconda-38.1.tar.bz2
/anaconda-38.2.tar.bz2
/anaconda-38.3.tar.bz2
/anaconda-38.4.tar.bz2
/anaconda-38.5.tar.bz2
/anaconda-38.6.tar.bz2
/anaconda-38.7.tar.bz2
/anaconda-38.8.tar.bz2
/anaconda-38.9.tar.bz2
/anaconda-38.10.tar.bz2
/anaconda-38.11.tar.bz2
/anaconda-38.12.tar.bz2
/anaconda-38.13.tar.bz2
/anaconda-38.14.tar.bz2
/anaconda-38.15.tar.bz2
/anaconda-38.17.tar.bz2
/anaconda-38.18.tar.bz2
/anaconda-38.19.tar.bz2
/anaconda-38.20.tar.bz2
/anaconda-38.21.tar.bz2
/anaconda-38.22.tar.bz2
/anaconda-38.23.tar.bz2
/anaconda-39.1.tar.bz2
/anaconda-39.2.tar.bz2
/anaconda-39.3.tar.bz2
/anaconda-39.4.tar.bz2
/anaconda-39.5.tar.bz2
/anaconda-39.6.tar.bz2
/anaconda-39.7.tar.bz2
/anaconda-39.8.tar.bz2
/anaconda-39.9.tar.bz2
/anaconda-39.10.tar.bz2
/anaconda-39.11.tar.bz2
/anaconda-39.12.tar.bz2
/anaconda-39.13.tar.bz2
/anaconda-39.14.tar.bz2
/anaconda-39.15.tar.bz2
/anaconda-39.16.tar.bz2
/anaconda-39.17.tar.bz2
/anaconda-39.18.tar.bz2
/anaconda-39.19.tar.bz2
/anaconda-39.20.tar.bz2
/anaconda-39.21.tar.bz2
/anaconda-39.22.tar.bz2
/anaconda-39.23.tar.bz2
/anaconda-39.24.tar.bz2
/anaconda-39.25.tar.bz2
/anaconda-39.26.tar.bz2
/anaconda-39.27.tar.bz2
/anaconda-39.28.tar.bz2
/anaconda-39.29.tar.bz2
/anaconda-39.30.tar.bz2
/anaconda-39.31.tar.bz2
/anaconda-39.32.tar.bz2
/anaconda-39.33.tar.bz2
/anaconda-40.1.tar.bz2
/anaconda-40.2.tar.bz2
/anaconda-40.3.tar.bz2
/anaconda-40.4.tar.bz2
/anaconda-40.5.tar.bz2
/anaconda-40.6.tar.bz2
/anaconda-40.7.tar.bz2
/anaconda-40.8.tar.bz2
/anaconda-40.9.tar.bz2
/anaconda-40.10.tar.bz2
/anaconda-40.11.tar.bz2
/anaconda-40.12.tar.bz2
/anaconda-40.13.tar.bz2
/anaconda-40.15.tar.bz2
/anaconda-40.17.tar.bz2
/anaconda-40.18.tar.bz2
/anaconda-40.20.tar.bz2
/anaconda-40.21.tar.bz2
/anaconda-41.1.tar.bz2
/anaconda-41.2.tar.bz2
/anaconda-41.6.tar.bz2
/anaconda-41.7.tar.bz2
/anaconda-41.9.tar.bz2
/anaconda-41.13.tar.bz2
/anaconda-41.14.tar.bz2
/anaconda-41.15.tar.bz2
/anaconda-41.17.tar.bz2
/anaconda-41.18.tar.bz2
/anaconda-41.19.tar.bz2
/anaconda-41.20.tar.bz2
/anaconda-41.22.tar.bz2
/anaconda-41.23.tar.bz2
/anaconda-41.24.tar.bz2
/anaconda-41.25.tar.bz2
/anaconda-41.26.tar.bz2
/anaconda-41.27.tar.bz2
/anaconda-41.28.tar.bz2
/anaconda-41.29.tar.bz2
/anaconda-41.30.tar.bz2
/anaconda-41.31.tar.bz2
/anaconda-41.32.tar.bz2
/anaconda-42.1.tar.bz2
/anaconda-42.2.tar.bz2
/anaconda-42.3.tar.bz2
/anaconda-42.4.tar.bz2
/anaconda-42.5.tar.bz2
/anaconda-42.6.tar.bz2
/anaconda-42.7.tar.bz2
/anaconda-42.8.tar.bz2
/anaconda-42.9.tar.bz2
/anaconda-42.10.tar.bz2
/anaconda-42.11.tar.bz2
/anaconda-42.12.tar.bz2
/anaconda-42.13.tar.bz2
/anaconda-42.14.tar.bz2
/anaconda-42.15.tar.bz2
/anaconda-42.16.tar.bz2
/anaconda-42.18.tar.bz2
/anaconda-42.20.tar.bz2
/anaconda-42.21.tar.bz2
/anaconda-42.23.tar.bz2
/anaconda-42.24.tar.bz2
/anaconda-42.26.tar.bz2
/anaconda-43.1.tar.bz2
/anaconda-43.5.tar.bz2
/anaconda-43.6.tar.bz2
/anaconda-43.7.tar.bz2
/anaconda-43.8.tar.bz2
/anaconda-43.9.tar.bz2
/anaconda-43.10.tar.bz2
/anaconda-43.11.tar.bz2
/anaconda-43.12.tar.bz2
/anaconda-43.13.tar.bz2
/anaconda-43.14.tar.bz2
/anaconda-43.15.tar.bz2
/anaconda-43.16.tar.bz2
/anaconda-43.17.tar.bz2
/anaconda-43.18.tar.bz2
/anaconda-43.20.tar.bz2
/anaconda-43.21.tar.bz2
/anaconda-43.22.tar.bz2
/anaconda-43.24.tar.bz2
/anaconda-43.25.tar.bz2
/anaconda-43.28.tar.bz2
/anaconda-43.29.tar.bz2
/anaconda-43.30.tar.bz2
/anaconda-43.31.tar.bz2
/anaconda-43.32.tar.bz2
/anaconda-43.33.tar.bz2
/anaconda-43.34.tar.bz2
/anaconda-43.35.tar.bz2
/anaconda-43.36.tar.bz2
/anaconda-43.37.tar.bz2
/anaconda-43.38.tar.bz2
/anaconda-43.39.tar.bz2
/anaconda-43.40.tar.bz2
/anaconda-43.41.tar.bz2
/anaconda-43.44.tar.bz2
/anaconda-43.46.tar.bz2
/anaconda-44.1.tar.bz2
/anaconda-44.2.tar.bz2
/anaconda-44.4.tar.bz2
/anaconda-44.5.tar.bz2
/anaconda-44.6.tar.bz2
/anaconda-44.7.tar.bz2
/anaconda-44.8.tar.bz2
/anaconda-44.9.tar.bz2
/anaconda-44.10.tar.bz2
/anaconda-44.11.tar.bz2
/anaconda-35.22.1.tar.bz2
/anaconda-35.22.2.tar.bz2

View file

@ -1,115 +0,0 @@
# ======================================
# WARNING!
# THIS FILE IS GENERATED FROM A TEMPLATE
# DO NOT EDIT THIS FILE MANUALLY!
# ======================================
# The template is located in: .packit.yml.j2
specfile_path: anaconda.spec
upstream_package_name: anaconda
upstream_tag_template: anaconda-{version}
copy_upstream_release_description: true
downstream_package_name: anaconda
files_to_sync:
- rpmlint.toml
- .packit.yml
srpm_build_deps:
- automake
- autoconf
- autogen
- glib2-devel
- gettext-devel
- python3-polib
- gobject-introspection-devel
- glade-devel
- libxklavier-devel
- libarchive-devel
- rpm-devel
- nss_wrapper
- nodejs-npm
packages:
anaconda-fedora:
specfile_path: anaconda.spec
anaconda-centos:
specfile_path: anaconda.spec
pkg_tool: centpkg
actions:
post-upstream-clone:
- ./autogen.sh
- ./configure
create-archive:
- "make release"
- 'bash -c "ls -1 anaconda-*.tar.bz2"'
jobs:
# Propose downstream (Fedora)
- job: propose_downstream
trigger: release
packages: [anaconda-fedora]
dist_git_branches:
- main
# Tests on PR (Fedora)
- job: tests
trigger: pull_request
packages: [anaconda-fedora]
targets:
- fedora-rawhide
# COPR builds on PR (Fedora)
- job: copr_build
trigger: pull_request
packages: [anaconda-fedora]
targets:
- fedora-rawhide
- fedora-eln
# COPR builds on commit (Fedora): single job with multiple targets (add ELN on main)
- job: copr_build
trigger: commit
packages: [anaconda-fedora]
targets:
- fedora-rawhide
- fedora-eln
branch: main
owner: "@rhinstaller"
project: Anaconda
preserve_project: True
- job: koji_build
trigger: commit
packages: [anaconda-fedora]
sidetag_group: anaconda-releases
dist_git_branches:
- fedora-development
allowed_committers:
- m4rtink
- kkoukiou
- rvykydal
- jkonecny
- packit
allowed_pr_authors:
- m4rtink
- kkoukiou
- rvykydal
- jkonecny
- packit
- job: bodhi_update
trigger: koji_build
packages: [anaconda-fedora]
sidetag_group: anaconda-releases
dependencies:
- anaconda-webui
dist_git_branches:
- fedora-development
allowed_builders:
- m4rtink
- kkoukiou
- rvykydal
- jkonecny
- packit

View file

@ -1,31 +0,0 @@
From b4b09f54b39b288f326b4734c13d27aa710e69d3 Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Mon, 2 Jun 2025 12:28:49 -0700
Subject: [PATCH] Don't pass --no-x11 to gnome-kiosk
This is also gone when mutter is built without X11 support, as
is now the case in Rawhide and ELN, and probably soon in EL 10.
Don't backport this to earlier branches.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
pyanaconda/display.py | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/pyanaconda/display.py b/pyanaconda/display.py
index 25a0e15142..20adcf58ff 100644
--- a/pyanaconda/display.py
+++ b/pyanaconda/display.py
@@ -226,8 +226,7 @@ def do_startup_wl_actions(timeout, headless=False, headless_resolution=None):
argv.extend(["--vt", "6"])
# add the generic GNOME Kiosk invocation
- argv.extend(["gnome-kiosk", "--wayland", "--no-x11",
- "--wayland-display", constants.WAYLAND_SOCKET_NAME])
+ argv.extend(["gnome-kiosk", "--wayland", "--wayland-display", constants.WAYLAND_SOCKET_NAME])
# remote access needs gnome-kiosk to start in headless mode
if headless:
--
2.49.0

View file

@ -1,66 +0,0 @@
From c7dce0445423e7386fdc6998a6a8de50a7a39bca Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Thu, 9 Oct 2025 10:07:01 -0700
Subject: [PATCH] RebootData: don't allow action to be None
Silverblue installs (and probably others where the kickstart data
does not explicitly specify a reboot action) crash, because
the `RebootData` instance's `action` winds up as `None`, since
this is the default value of `self.action` in
`pykickstart.commands.reboot.F23_Reboot`. Trying to translate
this to a DBus structure with `RebootData.to_structure` fails,
because DBus has no concept of `None`.
To avoid this, let's have the setter convert `None` to `-1`, the
same value we use as a default when initializing the instance.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
pyanaconda/modules/common/structures/reboot.py | 5 ++++-
.../modules/runtime/test_module_runtime.py | 10 ++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
diff --git a/pyanaconda/modules/common/structures/reboot.py b/pyanaconda/modules/common/structures/reboot.py
index fd2673b169..cadbfbd01f 100644
--- a/pyanaconda/modules/common/structures/reboot.py
+++ b/pyanaconda/modules/common/structures/reboot.py
@@ -46,7 +46,10 @@ class RebootData(DBusData):
return self._action
@action.setter
- def action(self, value: Int):
+ def action(self, value: Int | None):
+ if value is None:
+ # dbus cannot handle None
+ value = -1
self._action = value
@property
diff --git a/tests/unit_tests/pyanaconda_tests/modules/runtime/test_module_runtime.py b/tests/unit_tests/pyanaconda_tests/modules/runtime/test_module_runtime.py
index 22286e59c1..83d3a123ef 100644
--- a/tests/unit_tests/pyanaconda_tests/modules/runtime/test_module_runtime.py
+++ b/tests/unit_tests/pyanaconda_tests/modules/runtime/test_module_runtime.py
@@ -18,6 +18,7 @@
import unittest
from textwrap import dedent
+from pyanaconda.modules.common.structures.reboot import RebootData
from pyanaconda.modules.runtime.runtime import RuntimeService
from pyanaconda.modules.runtime.runtime_interface import RuntimeInterface
from tests.unit_tests.pyanaconda_tests import check_kickstart_interface
@@ -166,3 +167,12 @@ class RuntimeInterfaceTestCase(unittest.TestCase):
ks_in = "halt --eject\n"
ks_out = "# Halt after installation\nhalt --eject\n"
self._test_kickstart(ks_in, ks_out)
+
+ def test_process_kickstart_with_no_payload(self):
+ """Test all values are ints when reading empty kickstart."""
+ self.interface.ReadKickstart("")
+ assert isinstance(self.module.reboot.action, int)
+ assert isinstance(self.module.reboot.eject, int)
+ assert isinstance(self.module.reboot.kexec, int)
+ # and check we can to_structure it
+ RebootData.to_structure(self.module.reboot)
--
2.51.0

View file

@ -0,0 +1,46 @@
From 427f98963643e7f823f650dab015c80d854aa2d1 Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Thu, 19 May 2022 09:50:17 -0700
Subject: [PATCH] Specify that we want the Adwaita icon theme
Back in 38556e7e in 2016 when anaconda switched from 'gnome'
icon theme, intending to use 'Adwaita' instead, we dropped the
line that specifically declares what theme anaconda wants to
use. Presumably we expected GTK would always pick Adwaita for
us. However, with GTK 3.24.34, this seems to not reliably happen
on KDE. On KDE images, the breeze icon theme is installed, and
it also provides many of the icons anaconda uses. When running
anaconda on a KDE live image with GTK 3.24.34, we're often seeing
the icons from the breeze theme used instead of the icons from
the Adwaita theme. This happened in 4 out of 4 tests on openQA
prod, 3 out of 4 tests on openQA stg, and 5 out of 5 tests I
ran in a VM myself. I then applied this change directly to the
file in the VM and re-tested another 5 times; all 5 times the
right icons were shown.
I'm not sure why this is suddenly a problem with GTK 3.24.34
when it never was before even though both icon themes have been
in KDE for years, but this seems correct anyway. We definitely
want anaconda to use the Adwaita icons, not ones from any other
theme.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
pyanaconda/ui/gui/__init__.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/pyanaconda/ui/gui/__init__.py b/pyanaconda/ui/gui/__init__.py
index d458b66f14..428f30e744 100644
--- a/pyanaconda/ui/gui/__init__.py
+++ b/pyanaconda/ui/gui/__init__.py
@@ -754,6 +754,7 @@ class GraphicalUserInterface(UserInterface):
# Set some program-wide settings.
settings = Gtk.Settings.get_default()
settings.set_property("gtk-font-name", "Cantarell")
+ settings.set_property("gtk-icon-theme-name", "Adwaita")
# Get the path to the application data
data_path = os.environ.get("ANACONDA_DATA", "/usr/share/anaconda")
--
2.36.1

View file

@ -1,139 +0,0 @@
From c6118f65fe3583e1c15c383a8a9c6f5c1989fb22 Mon Sep 17 00:00:00 2001
From: Adam Williamson <awilliam@redhat.com>
Date: Thu, 9 Oct 2025 16:51:15 -0700
Subject: [PATCH] pyanaconda: localization: Indicate ASCII support in
get_keyboard_layouts
It is useful to know whether a given keyboard layout supports
ASCII input or not. Immediately, we want to use this in the
webUI keyboard logic, but it may be useful elsewhere too in
future, e.g. to warn the user if they use the Keyboard spoke
to create a configuration with no layout capable of ASCII input.
Signed-off-by: Adam Williamson <awilliam@redhat.com>
---
pyanaconda/localization.py | 11 +++++++++
.../common/structures/keyboard_layout.py | 10 ++++++++
.../modules/localization/localization.py | 2 ++
.../localization/test_module_localization.py | 23 +++++++++++--------
4 files changed, 36 insertions(+), 10 deletions(-)
diff --git a/pyanaconda/localization.py b/pyanaconda/localization.py
index 73415b2511..08a9343463 100644
--- a/pyanaconda/localization.py
+++ b/pyanaconda/localization.py
@@ -489,6 +489,17 @@ def get_common_keyboard_layouts():
return langtable.list_common_keyboards()
+def layout_supports_ascii(layout):
+ """Return a boolean indicating whether the xkb layout (given as
+ e.g. 'en(us)' or 'fr(oss)' or 'ru') can input ASCII characters.
+
+ :return: True for ASCII capable, False for not
+ :rtype: bool
+ :param str layout: layout descriptor string
+ """
+ return langtable.supports_ascii(layout)
+
+
def get_locale_timezones(locale):
"""Function returning preferred timezones for the given locale.
diff --git a/pyanaconda/modules/common/structures/keyboard_layout.py b/pyanaconda/modules/common/structures/keyboard_layout.py
index b5aacc764b..007e975965 100644
--- a/pyanaconda/modules/common/structures/keyboard_layout.py
+++ b/pyanaconda/modules/common/structures/keyboard_layout.py
@@ -29,6 +29,7 @@ class KeyboardLayout(DBusData):
def __init__(self):
self._layout_id = ""
self._description = ""
+ self._supports_ascii = False
self._is_common = False
self._langs = []
@@ -59,6 +60,15 @@ class KeyboardLayout(DBusData):
def is_common(self, value: bool):
self._is_common = value
+ @property
+ def supports_ascii(self) -> bool:
+ """Return whether the layout is capable of typing ASCII characters."""
+ return self._supports_ascii
+
+ @supports_ascii.setter
+ def supports_ascii(self, value: bool):
+ self._supports_ascii = value
+
@property
def langs(self) -> List[Str]:
"""Return the list of associated languages."""
diff --git a/pyanaconda/modules/localization/localization.py b/pyanaconda/modules/localization/localization.py
index 346a55a1c0..4fb7333ed7 100644
--- a/pyanaconda/modules/localization/localization.py
+++ b/pyanaconda/modules/localization/localization.py
@@ -33,6 +33,7 @@ from pyanaconda.localization import (
get_language_id,
get_language_locales,
get_native_name,
+ layout_supports_ascii,
)
from pyanaconda.modules.common.base import KickstartService
from pyanaconda.modules.common.constants.services import LOCALIZATION
@@ -218,6 +219,7 @@ class LocalizationService(KickstartService):
layout.description = self.get_layout_variant_description(name, with_lang=True, xlated=True)
layout.is_common = name.replace(" ", "") in common_langtable_keyboards and is_common_lang
layout.langs = info.langs
+ layout.supports_ascii = layout_supports_ascii(name.replace(" ", ""))
layouts.append(layout)
return layouts
diff --git a/tests/unit_tests/pyanaconda_tests/modules/localization/test_module_localization.py b/tests/unit_tests/pyanaconda_tests/modules/localization/test_module_localization.py
index 7f6449d3ea..7582df2401 100644
--- a/tests/unit_tests/pyanaconda_tests/modules/localization/test_module_localization.py
+++ b/tests/unit_tests/pyanaconda_tests/modules/localization/test_module_localization.py
@@ -228,28 +228,31 @@ class LocalizationInterfaceTestCase(unittest.TestCase):
normalized_layouts = KeyboardLayout.from_structure_list(layouts)
layouts_expectation = [
- ("ara (olpc)", "Arabic (OLPC)", "Arabic", False),
- ("cz", "Czech", "Czech", False),
- ("de (nodeadkeys)", "German (no dead keys)", "German", True),
- ("es", "Spanish", "Spanish; Castilian", True),
- ("fr (oss)", "French (alt.)", "French", True),
- ("gr", "Greek", "Greek, Modern (1453-); Greek", False),
- ("it", "Italian", "Italian", False),
- ("jp", "Japanese", "Japanese", True),
- ("us", "English (US)", "English", True),
+ ("ara (olpc)", "Arabic (OLPC)", "Arabic", False, True),
+ ("cz", "Czech", "Czech", False, True),
+ ("de (nodeadkeys)", "German (no dead keys)", "German", True, True),
+ ("es", "Spanish", "Spanish; Castilian", True, True),
+ ("fr (oss)", "French (alt.)", "French", True, True),
+ ("gr", "Greek", "Greek, Modern (1453-); Greek", False, False),
+ ("it", "Italian", "Italian", False, True),
+ ("jp", "Japanese", "Japanese", True, True),
+ ("us", "English (US)", "English", True, True),
+ ("ru (dos)", "Russian (DOS)", "Russian", False, False),
]
- for layout_id, description, lang, is_common in layouts_expectation:
+ for layout_id, description, lang, is_common, supports_ascii in layouts_expectation:
layout = KeyboardLayout()
layout.layout_id = layout_id
layout.description = description
layout.is_common = is_common
+ layout.supports_ascii = supports_ascii
layout.langs = [lang]
gen = (normalized_layout for normalized_layout in normalized_layouts if layout.layout_id == normalized_layout.layout_id)
for normalized_layout in gen:
assert layout.description == normalized_layout.description
assert layout.is_common == normalized_layout.is_common
+ assert layout.supports_ascii == normalized_layout.supports_ascii
assert layout.langs == normalized_layout.langs
break
else:
--
2.51.0

View file

@ -0,0 +1,30 @@
From e07d14aef9fa315d5aea6967aa1517b534400731 Mon Sep 17 00:00:00 2001
From: Vendula Poncova <vponcova@redhat.com>
Date: Mon, 20 Sep 2021 12:10:42 +0200
Subject: [PATCH] Revert "Install kbd-legacy if keyboard layout is "fi"
(#1955793)"
This reverts commit b9c33400831024394e351753d7e413643f6a4757.
Resolves: rhbz#2003937
---
pyanaconda/modules/localization/localization.py | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/pyanaconda/modules/localization/localization.py b/pyanaconda/modules/localization/localization.py
index 52015335f69..6a2c8be3ac0 100644
--- a/pyanaconda/modules/localization/localization.py
+++ b/pyanaconda/modules/localization/localization.py
@@ -196,10 +196,8 @@ def collect_requirements(self):
"""
requirements = []
- # Install support for non-ascii keyboard layouts (#1919483)
- # and special case "fi" layout (#1955793)
- if self.vc_keymap and (self.vc_keymap == "fi" or
- not langtable.supports_ascii(self.vc_keymap)):
+ # Install support for non-ascii keyboard layouts (#1919483).
+ if self.vc_keymap and not langtable.supports_ascii(self.vc_keymap):
requirements.append(Requirement.for_package(
package_name="kbd-legacy",
reason="Required to support the '{}' keymap.".format(self.vc_keymap)

View file

@ -0,0 +1,87 @@
From 1e1ee086c980fa8d53320b31e85ec10c81bd5f57 Mon Sep 17 00:00:00 2001
From: Vladimir Slavik <vslavik@redhat.com>
Date: Mon, 25 Oct 2021 13:29:34 +0200
Subject: [PATCH] Show correctly that no admin user is set up
Previously, it was possible to satisfy the conditions just by setting root
password, even if root was locked.
The recent redesign of root spoke made the error more prominent, but the
situation could be recreated even before.
This changes both root and user spoke to signal the incomplete user.
Resolves: rhbz#2015508
---
pyanaconda/ui/gui/spokes/root_password.py | 14 ++++++++++++--
pyanaconda/ui/gui/spokes/user.py | 15 +++++++++++++--
2 files changed, 25 insertions(+), 4 deletions(-)
diff --git a/pyanaconda/ui/gui/spokes/root_password.py b/pyanaconda/ui/gui/spokes/root_password.py
index 8271101316..fa50e30623 100644
--- a/pyanaconda/ui/gui/spokes/root_password.py
+++ b/pyanaconda/ui/gui/spokes/root_password.py
@@ -186,7 +186,10 @@ class PasswordSpoke(FirstbootSpokeMixIn, NormalSpoke, GUISpokeInputCheckHandler)
@property
def mandatory(self):
- """Only mandatory if no admin user has been requested."""
+ """Only mandatory if no admin user has been requested.
+
+ See also doc for the property completed().
+ """
return not self._users_module.CheckAdminUserExists()
def apply(self):
@@ -216,7 +219,14 @@ class PasswordSpoke(FirstbootSpokeMixIn, NormalSpoke, GUISpokeInputCheckHandler)
@property
def completed(self):
- return self._users_module.IsRootPasswordSet
+ """Is the spoke completed?
+
+ For root and user, the mandatory+completed pair is a complicated hack. Having an usable
+ admin user is mandatory, but it is not clear if it should be an unlocked root, or a sudoer.
+ Thus, mandatory on both spokes checks admin user, and complete then checks again: Both the
+ spoke-specific completion condition, as well as existence of an admin.
+ """
+ return self._users_module.IsRootPasswordSet and self._users_module.CheckAdminUserExists()
@property
def sensitive(self):
diff --git a/pyanaconda/ui/gui/spokes/user.py b/pyanaconda/ui/gui/spokes/user.py
index dacc71cff3..b389d72758 100644
--- a/pyanaconda/ui/gui/spokes/user.py
+++ b/pyanaconda/ui/gui/spokes/user.py
@@ -459,7 +459,10 @@ class UserSpoke(FirstbootSpokeMixIn, NormalSpoke, GUISpokeInputCheckHandler):
@property
def mandatory(self):
- """Only mandatory if no admin user has been requested."""
+ """Only mandatory if no admin user has been requested.
+
+ See also doc for the property completed().
+ """
return not self._users_module.CheckAdminUserExists()
def apply(self):
@@ -503,7 +506,15 @@ class UserSpoke(FirstbootSpokeMixIn, NormalSpoke, GUISpokeInputCheckHandler):
@property
def completed(self):
- return bool(get_user_list(self._users_module))
+ """Is the spoke completed?
+
+ For root and user, the mandatory+completed pair is a complicated hack. Having an usable
+ admin user is mandatory, but it is not clear if it should be an unlocked root, or a sudoer.
+ Thus, mandatory on both spokes checks admin user, and complete then checks again: Both the
+ spoke-specific completion condition, as well as existence of an admin.
+ """
+ return bool(get_user_list(self._users_module)) \
+ and self._users_module.CheckAdminUserExists()
def on_password_required_toggled(self, togglebutton=None, data=None):
"""Called by Gtk callback when the "Use password" check
--
2.31.1

View file

@ -0,0 +1,22 @@
From 614aec9fb4bf1c21c5e9769deee4bafb94cd10b1 Mon Sep 17 00:00:00 2001
From: Radek Vykydal <rvykydal@redhat.com>
Date: Fri, 12 Nov 2021 15:09:13 +0100
Subject: [PATCH] Do not crash on dangling symlink /etc/resolv.conf (#2019579)
---
pyanaconda/modules/network/installation.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/modules/network/installation.py b/pyanaconda/modules/network/installation.py
index fe850cb638..6de7ea05c8 100644
--- a/pyanaconda/modules/network/installation.py
+++ b/pyanaconda/modules/network/installation.py
@@ -240,7 +240,7 @@ def _copy_file_to_root(self, root, config_file, overwrite=False, follow_symlinks
if not os.path.isfile(config_file):
return
fpath = os.path.normpath(root + config_file)
- if os.path.isfile(fpath) and not overwrite:
+ if (os.path.isfile(fpath) or os.path.islink(fpath)) and not overwrite:
return
if not os.path.isdir(os.path.dirname(fpath)):
util.mkdirChain(os.path.dirname(fpath))

View file

@ -1,42 +0,0 @@
From d75de3da3648dee474ddea6639e09c071f027232 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= <miro@hroncok.cz>
Date: Sat, 7 Jun 2025 13:44:25 +0200
Subject: [PATCH] Avoid buffer overflow with TIOCGWINSZ
It has 4 bytes, not 2.
On Python 3.14+, the previous version raised SystemError:
>>> from pyanaconda.argument_parsing import get_help_width
...
>>> get_help_width()
Traceback (most recent call last):
File "<python-input-1>", line 1, in <module>
get_help_width()
~~~~~~~~~~~~~~^^
File "/usr/lib64/python3.14/site-packages/pyanaconda/argument_parsing.py", line 68, in get_help_width
data = fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ, '1234')
SystemError: buffer overflow
See https://github.com/python/cpython/commit/c2eaeee3dc3306ca486b0377b07b1a957584b691
Fixes https://bugzilla.redhat.com/2370944
---
pyanaconda/argument_parsing.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/argument_parsing.py b/pyanaconda/argument_parsing.py
index e24f0f1b999..55cf7993625 100644
--- a/pyanaconda/argument_parsing.py
+++ b/pyanaconda/argument_parsing.py
@@ -65,8 +65,8 @@ def get_help_width():
return DEFAULT_HELP_WIDTH
try:
- data = fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ, '1234')
- columns = int(struct.unpack('hh', data)[1])
+ data = fcntl.ioctl(sys.stdout, termios.TIOCGWINSZ, '12345678')
+ columns = int(struct.unpack('hhhh', data)[1])
except (OSError, ValueError) as e:
log.info("Unable to determine terminal width: %s", e)
print("terminal size detection failed, using default width")

View file

@ -1,70 +0,0 @@
From 11b7e782d8de7da49f0b4e650e8fc0c60f69304f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= <miro@hroncok.cz>
Date: Sun, 8 Jun 2025 17:46:29 +0200
Subject: [PATCH] Avoid the multiprocessing forkserver method with dnf
Fixes:
Traceback (most recent call last):
File "/usr/lib64/python3.14/site-packages/pyanaconda/core/threads.py", line 281, in run
threading.Thread.run(self)
~~~~~~~~~~~~~~~~~~~~^^^^^^
File "/usr/lib64/python3.14/threading.py", line 1023, in run
self._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.14/site-packages/pyanaconda/modules/common/task/task.py", line 97, in _thread_run_callback
self._task_run_callback()
~~~~~~~~~~~~~~~~~~~~~~~^^
File "/usr/lib64/python3.14/site-packages/pyanaconda/modules/common/task/task.py", line 110, in _task_run_callback
self._set_result(self.run())
~~~~~~~~^^
File "/usr/lib64/python3.14/site-packages/pyanaconda/modules/payloads/payload/dnf/installation.py", line 281, in run
self._dnf_manager.install_packages(self.report_progress)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.14/site-packages/pyanaconda/modules/payloads/payload/dnf/dnf_manager.py", line 664, in install_packages
process.start()
~~~~~~~~~~~~~^^
File "/usr/lib64/python3.14/multiprocessing/process.py", line 121, in start
self._popen = self._Popen(self)
~~~~~~~~~~~^^^^^^
File "/usr/lib64/python3.14/multiprocessing/context.py", line 224, in _Popen
return _default_context.get_context().Process._Popen(process_obj)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/usr/lib64/python3.14/multiprocessing/context.py", line 300, in _Popen
return Popen(process_obj)
File "/usr/lib64/python3.14/multiprocessing/popen_forkserver.py", line 35, in __init__
super().__init__(process_obj)
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/usr/lib64/python3.14/multiprocessing/popen_fork.py", line 20, in __init__
self._launch(process_obj)
~~~~~~~~~~~~^^^^^^^^^^^^^
File "/usr/lib64/python3.14/multiprocessing/popen_forkserver.py", line 47, in _launch
reduction.dump(process_obj, buf)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
File "/usr/lib64/python3.14/multiprocessing/reduction.py", line 60, in dump
ForkingPickler(file, protocol).dump(obj)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^
TypeError: cannot pickle 'SwigPyObject' object
---
pyanaconda/modules/payloads/payload/dnf/dnf_manager.py | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/pyanaconda/modules/payloads/payload/dnf/dnf_manager.py b/pyanaconda/modules/payloads/payload/dnf/dnf_manager.py
index 925ed73790a..e7c25369912 100644
--- a/pyanaconda/modules/payloads/payload/dnf/dnf_manager.py
+++ b/pyanaconda/modules/payloads/payload/dnf/dnf_manager.py
@@ -652,9 +652,12 @@ def install_packages(self, callback, timeout=20):
:param timeout: a time out of a failed process in seconds
:raise PayloadInstallationError: if the installation fails
"""
- queue = multiprocessing.Queue()
+ # SwigPyObjects are not picklable, so force the fork method
+ # On Python 3.14+, forkserver is the default (and it pickles)
+ context = multiprocessing.get_context(method="fork")
+ queue = context.Queue()
display = TransactionProgress(queue)
- process = multiprocessing.Process(
+ process = context.Process(
target=self._run_transaction,
args=(self._base, display)
)

View file

@ -1,3 +0,0 @@
This repository is maintained by packit.
https://packit.dev/
The file was generated using packit 1.13.0.post1.dev2+g84134016c.

File diff suppressed because it is too large Load diff

View file

@ -1,12 +0,0 @@
summary: Integration tests for anaconda
discover:
how: fmf
filter: 'tag: integration'
execute:
how: tmt
finish:
how: shell
script: command -v journalctl && journalctl -a || true

View file

@ -1,36 +0,0 @@
# The purpose of this file is to overwrite some default config
# of rpmlint, which may not fit our project needs / specification
Filters = [
# Discard no-binary error for anaconda packages which cant be a noarch type
'anaconda.x86_64: E: no-binary',
'anaconda-core-debuginfo.x86_64: E: no-binary',
'anaconda-install-env-deps.x86_64: E: no-binary',
'anaconda-install-img-deps.x86_64: E: no-binary',
# Discard explicite library dependencies
'explicit-lib-dependency flatpak-libs',
'explicit-lib-dependency libblockdev-lvm-dbus',
'explicit-lib-dependency libblockdev-tools',
'explicit-lib-dependency librsvg2',
# Discard warning about binary debug symbols. Those are our helper
# binaries and it is not important for them to be stripped
'unstripped-binary-or-object /usr/libexec/anaconda/dd_extract',
'unstripped-binary-or-object /usr/libexec/anaconda/dd_list',
'unstripped-binary-or-object /usr/lib64/libAnacondaWidgets*',
'unstripped-binary-or-object /usr/lib64/glade/modules/libAnacondaWidgets*',
# Discard symbolic link warnings.
'dangling-symlink /usr/share/anaconda/window-manager/glib-2.0/schemas/org.gnome.*',
'dangling-relative-symlink /usr/lib/.build-id/*',
# Discard missing manual pages error
'no-manual-page-for-binary liveinst',
'no-manual-page-for-binary anaconda-cleanup',
'no-manual-page-for-binary anaconda-disable-nm-ibft-plugin',
'no-manual-page-for-binary anaconda-nm-disable-autocons',
'no-manual-page-for-binary instperf',
'no-manual-page-for-binary instperf',
'no-manual-page-for-binary anaconda',
'no-manual-page-for-binary handle-sshpw',
# Discard missing README / documentation for package
'no-documentation',
# Discard spelling errors for project commonly used words
'spelling-error .* en_US (metapackage|kickstarts|iso|eg|lorax) ',
]

View file

@ -1 +1 @@
SHA512 (anaconda-44.11.tar.bz2) = 30e8c3bde05afefe7cb18ba17d84fc31007e9086932f47136e74e432563786cd577123f7c904bc3ddd5e5c5f6f722dae3cedbc131d5871c06f7829ba632ffaf7
SHA512 (anaconda-35.22.2.tar.bz2) = 19cf30e88ccc32e45da0dd238cacccd5ff9193f9b2eccc611bf3d4d1d9cf3a73a12a92027d4fcb8bfa113b9e6333bec3170793c3dd091215ed21624a53e2b367

View file

@ -1,22 +0,0 @@
summary: Dirinstall test on regular os
contact: Radek Vykydal <rvykydal@redhat.com>
path: /tests/dirinstall
test: ./dirinstall.sh
duration: 1h
tag: [integration]
/text:
summary: Dirinstall test on regular os - text UI
require:
- anaconda
environment:
ANACONDA_UI_MODE: text
/vnc:
summary: Dirinstall test on regular os - vnc UI
enabled: false
require:
- anaconda
- gnome-kiosk
environment:
ANACONDA_UI_MODE: vnc

View file

@ -1,47 +0,0 @@
#!/bin/sh -eux
# Remove webui because it does not support much anything yet
# Possible alternative: rpm -E --nodeps anaconda-webui
dnf remove -y anaconda-webui
# Prepare test work directory
WORK_DIR=$(mktemp -d /var/tmp/dirinstall.XXXXXX)
# Create kickstart
KICKSTART_PATH=${WORK_DIR}/ks.cfg
source ./repositories
TEST_KICKSTART=./ks.dirinstall.cfg
# Dump URLs of installation repositories found in local repositories whose names are configured in 'repositories' file
echo "url --metalink=$(dnf repoinfo $BASE_REPO | grep -e "^ *Metalink *:" | cut -d: -f2- | sed 's/^ *//')" > ${KICKSTART_PATH}
for repo in $REPOS; do
echo "repo --name=$repo --metalink=$(dnf repoinfo $repo | grep "^ *Metalink *:" | cut -d: -f2- | sed 's/^ *//')" >> ${KICKSTART_PATH}
done
cat ${TEST_KICKSTART} >> ${KICKSTART_PATH}
# Log the kickstart
cat ${KICKSTART_PATH}
# Run dirinstall
INSTALL_DIR=${WORK_DIR}/install_dir
mkdir ${INSTALL_DIR}
anaconda --dirinstall ${INSTALL_DIR} --kickstart ${KICKSTART_PATH} --${ANACONDA_UI_MODE} --noninteractive 2>&1
# Remove test work directory
rm -rf ${WORK_DIR}
# Show and remove the logs for this anaconda run
./show_logs.sh

View file

@ -1,12 +0,0 @@
# The repository configuration (url, repo) needs to be added here.
# It varies by the product and version we are running on / testing
lang en_US.UTF-8
keyboard --vckeymap=us --xlayouts='us'
rootpw --plaintext redhat
timezone --utc Europe/Prague
shutdown
%packages
%end

View file

@ -1,12 +0,0 @@
# Names of local repositories whose urls will be used for installation
# Repositories for "Fedora X" needs to be dynamically resolved based on host
if dnf repoinfo --enabled | grep -qe "Repo ID *: rawhide"; then
BASE_REPO="rawhide"
else
BASE_REPO="fedora"
fi
# Additional repositories
REPOS=""
#REPOS="fedora-modular"

View file

@ -1,21 +0,0 @@
#!/bin/sh -x
ls /tmp
LOG_DIR=/tmp
cd ${LOG_DIR}
KS_SCRIPT_LOGS=$(ls ks-script-*.log)
cd -
ANACONDA_LOGS="anaconda.log storage.log packaging.log program.log dbus.log dnf.librepo.log ${KS_SCRIPT_LOGS}"
for log in ${ANACONDA_LOGS} ; do
LOG_PATH=${LOG_DIR}/${log}
if [ -f ${LOG_PATH} ]; then
echo "----------------------- Dumping log file $LOG_PATH:"
cat $LOG_PATH
# clear for the following test
rm $LOG_PATH
fi
done