From ed145aa114fd94cb6e35ee38e294613dd573e0bf Mon Sep 17 00:00:00 2001 From: Jeff Law Date: Fri, 2 Oct 2020 15:41:51 -0600 Subject: [PATCH 1/2] Add -fPIC to compilation flags --- android-file-transfer.spec | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/android-file-transfer.spec b/android-file-transfer.spec index 91e334d..0a438b3 100644 --- a/android-file-transfer.spec +++ b/android-file-transfer.spec @@ -3,7 +3,7 @@ Name: android-file-transfer Version: 3.9 -Release: 6%{?dist} +Release: 7%{?dist} Summary: Reliable Android MTP client with minimalist UI License: LGPLv2+ @@ -38,6 +38,9 @@ Features: %build +# QT requires the main progrma not to perform local symbol binding, +# -fPIC accomplishes that +export CXXFLAGS="-fPIC $RPM_OPT_FLAGS" %cmake -GNinja %cmake_build @@ -65,6 +68,9 @@ appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{name}.appdat %{_datadir}/metainfo/%{name}.appdata.xml %changelog +* Fri Oct 2 2020 Jeff Law - 3.9-7 +- Add -fPIC to compilation flags + * Fri Jul 31 2020 Fedora Release Engineering - 3.9-6 - Second attempt - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild From d5745bdf3f5c616fa0749fafb6eacb3c0caeca0e Mon Sep 17 00:00:00 2001 From: Qiyu Yan Date: Sun, 15 Nov 2020 18:07:52 +0800 Subject: [PATCH 2/2] disable LTO #1894585 --- android-file-transfer.spec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/android-file-transfer.spec b/android-file-transfer.spec index 0a438b3..0ec0dfa 100644 --- a/android-file-transfer.spec +++ b/android-file-transfer.spec @@ -1,9 +1,15 @@ # Force out of source build %undefine __cmake_in_source_build +# Build with lto enabled will lead to crash +# see +# https://bugzilla.redhat.com/show_bug.cgi?id=1894585 +# Disabling lto until upstream fixes this problem +%define _lto_cflags %{nil} + Name: android-file-transfer Version: 3.9 -Release: 7%{?dist} +Release: 8%{?dist} Summary: Reliable Android MTP client with minimalist UI License: LGPLv2+ @@ -68,6 +74,9 @@ appstream-util validate-relax --nonet %{buildroot}%{_metainfodir}/%{name}.appdat %{_datadir}/metainfo/%{name}.appdata.xml %changelog +* Sun Nov 15 18:00:15 CST 2020 Qiyu Yan - 3.9-8 +- disable LTO #1894585 + * Fri Oct 2 2020 Jeff Law - 3.9-7 - Add -fPIC to compilation flags