rpms/coreutils
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix implicit declaration warning in coreutils-getgrouplist.patch

Browse source 
Error: COMPILER_WARNING:
coreutils-8.30/lib/mgetgroups.c: scope_hint: In function 'mgetgroups'
coreutils-8.30/lib/mgetgroups.c:167:11: warning: implicit declaration of function 'xrealloc'; did you mean 'realloc'? [-Wimplicit-function-declaration]
     g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
         ^~~~~~~~
165|       {
166|         max_n_groups = ng;
167|->       g = xrealloc (g, max_n_groups * sizeof (GETGROUPS_T));
168|       }
169|       if (e == -1)
This commit is contained in:
Kamil Dudka 2018-11-07 15:53:11 +01:00
commit ed52fbfec9
2 changed files with 14 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

12
coreutils-getgrouplist.patch
View file

@ -21,7 +21,15 @@ diff --git a/lib/mgetgroups.c b/lib/mgetgroups.c
index 76474c2..0a9d221 100644
--- a/lib/mgetgroups.c
+++ b/lib/mgetgroups.c
@@ -121,9 +121,17 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups)
@@ -31,6 +31,7 @@
#endif
#include "getugroups.h"
+#include "xalloc.h"
#include "xalloc-oversized.h"
/* Work around an incompatibility of OS X 10.11: getgrouplist
@@ -121,9 +122,17 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups)
/* else no username, so fall through and use getgroups. */
#endif
@ -42,7 +50,7 @@ index 76474c2..0a9d221 100644
/* If we failed to count groups because there is no supplemental
group support, then return an array containing just GID.
@@ -145,10 +153,25 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups)
@@ -145,10 +154,25 @@ mgetgroups (char const *username, gid_t gid, gid_t **groups)
if (g == NULL)
return -1;

5
coreutils.spec
View file

@ -1,7 +1,7 @@
Summary: A set of basic GNU tools commonly used in shell scripts
Name: coreutils
Version: 8.30
Release: 5%{?dist}
Release: 6%{?dist}
License: GPLv3+
Group: System Environment/Base
Url: https://www.gnu.org/software/coreutils/
@ -255,6 +255,9 @@ fi
%license COPYING
%changelog
* Wed Nov 07 2018 Kamil Dudka <kdudka@redhat.com> - 8.30-6
- fix implicit declaration warning in coreutils-getgrouplist.patch
* Thu Oct 11 2018 Kamil Dudka <kdudka@redhat.com> - 8.30-5
- fix heap-based buffer overflow in vasnprintf() (CVE-2018-17942)