cppad.spec: fix some lint warnings, explain the rest, advance release number.

.gitignore: Add patterns not automatically included by fedpkg.
This commit is contained in:
Brad Bell 2015-02-01 04:56:12 -07:00
commit e66a20700e
2 changed files with 28 additions and 12 deletions

7
.gitignore vendored
View file

@ -1,3 +1,10 @@
# ignore swap files created by vim editor
*.swp
# ignore rpm files created by fedpkg srpm
*.rpm
# ignore result drectory created by fedpkg mockbuild
results_cppad
# tarballs
cppad-20110101.5.gpl.tgz
cppad-20120101.1.gpl.tgz
/cppad-20130000.0.gpl.tgz

View file

@ -1,15 +1,22 @@
# rpmlint --version
# rpmlint version 1.4 Copyright (C) 1999-2007 Frederic Lepied, Mandriva
# ----------------------------------------------------------------------------
# The comamnds 'rpmlint cppad.spec' and 'fedpkg lint' generate the warning:
#
# rmplint cppad.sped
# cppad.spec: ... W: rpm-buildroot-usage ...
# 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
# search for 'rpm-buildroot-usage' and see comments near there.
# ----------------------------------------------------------------------------
# cppad.spec:71: W: rpm-buildroot-usage
# %%prep includedir=%%{buildroot}%%{_includedir}
#
# See http://comments.gmane.org/gmane.linux.redhat.fedora.devel/144920
# ----------------------------------------------------------------------------
# The command 'fedpkg lint' generates the following warnings:
#
# W: spelling-error Summary(en_US) devel -> delve, devil, revel
# W: spelling-error %%description -l en_US devel -> delve, devil, revel
#
# These uses of devel refer to cppad-devel and hence are not spelling errors.
# ----------------------------------------------------------------------------
Name: cppad
Version: 20150000.4
Release: 1%{?dist}
Release: 2%{?dist}
Summary: C++ Algorithmic Differentiation (AD), %{name}-devel and %{name}-doc
# Only noarch.rpms provided. The user can compile with or without debugging
@ -66,8 +73,6 @@ as a single web page, in both HTML and XML, can be found at that web site.
# Replace cppad_SOURCE_DIR by the system include directory so that
# installed files, instead of local files, are used for testing.
#
# Note this generates rpm-buildroot-usage warning from rpmlint; see
# http://comments.gmane.org/gmane.linux.redhat.fedora.devel/144920
includedir=%{buildroot}%{_includedir}
sed \
-e "s|\(INCLUDE_DIRECTORIES(\).*{cppad_SOURCE_DIR}|\1 SYSTEM $includedir|" \
@ -103,9 +108,9 @@ sed -i.stamp example/example.cpp -f example.sed
# and http://www.coin-or.org/CppAD/Doc/cmake.htm
%build
#
# Cannot use %{_includedir}, or %{_docdir} because they are absolute.
# Cannot use %%{_includedir}, or %%{_docdir} because they are absolute.
# Relative values would be more flexible because they can be combined with
# %{_prefix} to get absolute values.
# %%{_prefix} to get absolute values.
%cmake \
-D CMAKE_VERBOSE_MAKEFILE=0 \
\
@ -148,6 +153,10 @@ rm -rf %{buildroot}
# ----------------------------------------------------------------------------
%changelog
* Sun Feb 01 2015 Brad Bell <bradbell at seanet dot com> - 20150000.4-2
- Fix rmplint warning about macro-in-comment.
- Edit comments at top of about warnings that won't be fixed.
* Sat Jan 31 2015 Brad Bell <bradbell at seanet dot com> - 20150000.4-1
- Advance to version 2015 of cppad.
- Ensure cmake >= 2.8; see https://bugzilla.redhat.com/show_bug.cgi?id=896116