Compare commits

...
Sign in to create a new pull request.

6 commits

Author SHA1 Message Date
Jack Magne
a3fe2dd6ad Xulrunner. 2014-09-09 17:44:56 -07:00
Jack Magne
2a90d0ee6b More xulrunner fun. 2014-09-09 15:11:50 -07:00
Jack Magne
aa71639ebb Fix yet another xulrunner build/run issue. 2014-09-09 14:32:10 -07:00
Jack Magne
cf2c625b10 Fix bogus changelog date. 2014-04-23 16:47:00 -07:00
Jack Magne
b9f088915e Fix for #1090680, Http client doesn't provide standard intro string to server. 2014-04-23 16:17:11 -07:00
Jack Magne
d881d99051 Fixes to adjust for latest xulrunner sdk. 2014-04-17 16:09:23 -07:00
3 changed files with 175 additions and 3 deletions

82
esc-1.1.0-fix18.patch Normal file
View file

@ -0,0 +1,82 @@
diff -up ./esc/src/app/xpcom/Makefile.sdk.fix18 ./esc/src/app/xpcom/Makefile.sdk
--- ./esc/src/app/xpcom/Makefile.sdk.fix18 2014-04-17 11:34:54.889316425 -0700
+++ ./esc/src/app/xpcom/Makefile.sdk 2014-04-17 11:39:32.903840765 -0700
@@ -113,7 +113,7 @@ ifeq ($(OS_ARCH),Linux)
CPPFLAGS += -g -fno-rtti \
-DXPCOM_GLUE_USE_NSPR -fno-exceptions \
-fshort-wchar -fPIC -std=gnu++0x
-GECKO_LD_LIBS=-L$(GECKO_SDK_PATH)/lib -lnssutil3 -lnss3 -lcrmf -lssl3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -L$(GECKO_SDK_PATH)/lib -lxpcomglue_s -lxpcom
+GECKO_LD_LIBS=-L$(GECKO_SDK_PATH)/lib -lnssutil3 -lnss3 -lcrmf -lssl3 -lsmime3 -lplds4 -lplc4 -lnspr4 -lpthread -ldl -L$(GECKO_SDK_PATH)/lib -lxpcomglue_s
endif
ifeq ($(OS_ARCH),WINNT)
@@ -127,7 +127,7 @@ endif
# #include "mozilla-config.h" to each of your .cpp files.
#GECKO_CONFIG_INCLUDE = -include mozilla-config.h
-GECKO_DEFINES = -DXPCOM_GLUE -DMOZILLA_CLIENT
+GECKO_DEFINES = -DMOZILLA_CLIENT
ifdef ESC_VERSION
GECKO_DEFINES += -DESC_VERSION=$(ESC_VERSION)
diff -up ./esc/src/app/xpcom/rhCoolKey.h.fix18 ./esc/src/app/xpcom/rhCoolKey.h
--- ./esc/src/app/xpcom/rhCoolKey.h.fix18 2014-04-17 15:48:24.466170548 -0700
+++ ./esc/src/app/xpcom/rhCoolKey.h 2014-04-17 15:49:25.319409778 -0700
@@ -17,7 +17,7 @@
#ifndef RH_COOLKEY_H
#define RH_COOLKEY_H
-
+#include <mozilla/Char16.h>
#include "rhICoolKey.h"
/*#include "nsIGenericFactory.h" */
#include "mozilla/ModuleUtils.h"
diff -up ./esc/src/app/xpcom/tray/Makefile.sdk.fix18 ./esc/src/app/xpcom/tray/Makefile.sdk
--- ./esc/src/app/xpcom/tray/Makefile.sdk.fix18 2014-04-17 11:24:58.080777558 -0700
+++ ./esc/src/app/xpcom/tray/Makefile.sdk 2014-04-17 11:34:28.394647654 -0700
@@ -167,7 +167,7 @@ endif
# #include "mozilla-config.h" to each of your .cpp files.
#GECKO_CONFIG_INCLUDE = -include mozilla-config.h
-GECKO_DEFINES = -DMOZILLA_CLIENT -DXPCOM_GLUE
+GECKO_DEFINES = -DMOZILLA_CLIENT
NSS_INCLUDE = /usr/include/nss3
NSPR_INCLUDE = /usr/include/nspr4
diff -up ./esc/src/app/xpcom/tray/rhTray.h.fix18 ./esc/src/app/xpcom/tray/rhTray.h
--- ./esc/src/app/xpcom/tray/rhTray.h.fix18 2014-04-17 11:04:33.578085948 -0700
+++ ./esc/src/app/xpcom/tray/rhTray.h 2014-04-17 11:05:10.798620628 -0700
@@ -17,7 +17,7 @@
#ifndef RH_TRAY_H
#define RH_TRAY_H
-
+#include <mozilla/Char16.h>
#include "rhITray.h"
//#include "nsIGenericFactory.h"
//#include mozilla/ModuleUtils.h
diff -up ./esc/src/app/xul/esc/application.ini.fix18 ./esc/src/app/xul/esc/application.ini
--- ./esc/src/app/xul/esc/application.ini.fix18 2014-04-17 15:35:13.854054559 -0700
+++ ./esc/src/app/xul/esc/application.ini 2014-04-17 15:35:45.278661698 -0700
@@ -25,11 +25,11 @@ Vendor=RedHat
Name=ESC
;
; This field specifies your application's version. This field is optional.
-Version=1.1.0-19
+Version=1.1.0-23
;
; This field specifies your application's build ID (timestamp). This field is
; required.
-BuildID=0000001019
+BuildID=0000001023
;
; This ID is just an example. Every XUL app ought to have it's own unique ID.
; You can use the microsoft "guidgen" or "uuidgen" tools, or go on
@@ -47,6 +47,6 @@ MinVersion=6.0.0
; application requires. It should be specified if your application uses
; unfrozen interfaces. Specifying 1.8 matches all releases with a version
; prefixed by 1.8 (e.g., 1.8a4, 1.8b, 1.8.2).
-MaxVersion=22.0.0
+MaxVersion=50.0.0
[Shell]

79
esc-1.1.0-fix19.patch Normal file
View file

@ -0,0 +1,79 @@
diff -up ./esc/src/app/xul/esc/application.ini.fix19 ./esc/src/app/xul/esc/application.ini
--- ./esc/src/app/xul/esc/application.ini.fix19 2014-04-23 14:42:02.644058331 -0700
+++ ./esc/src/app/xul/esc/application.ini 2014-04-23 14:42:22.990803962 -0700
@@ -25,11 +25,11 @@ Vendor=RedHat
Name=ESC
;
; This field specifies your application's version. This field is optional.
-Version=1.1.0-23
+Version=1.1.0-24
;
; This field specifies your application's build ID (timestamp). This field is
; required.
-BuildID=0000001023
+BuildID=0000001024
;
; This ID is just an example. Every XUL app ought to have it's own unique ID.
; You can use the microsoft "guidgen" or "uuidgen" tools, or go on
diff -up ./esc/src/lib/NssHttpClient/Util.cpp.fix19 ./esc/src/lib/NssHttpClient/Util.cpp
--- ./esc/src/lib/NssHttpClient/Util.cpp.fix19 2014-04-23 14:40:14.001416551 -0700
+++ ./esc/src/lib/NssHttpClient/Util.cpp 2014-04-23 14:41:19.864593148 -0700
@@ -49,3 +49,26 @@ NSAPI_PUBLIC int Util::ascii2numeric (ch
}
return num;
}
+
+// Remove stray trailing CRLF chars, replace with provided char.
+NSAPI_PUBLIC void Util::stripTrailingCRLF(char *buff, char replaceWith)
+{
+ if(buff == NULL)
+ return;
+
+ if(replaceWith == 0)
+ return;
+
+ int buffLen = strlen(buff);
+
+ if(buffLen == 0)
+ return;
+
+ int buffLenMinusOne = buffLen - 1;
+
+ for(int i = buffLenMinusOne; i >= 0; i--) {
+ if(buff[i] == 0x0d || buff[i] == 0x0a) {
+ buff[i] = replaceWith;
+ }
+ }
+}
diff -up ./esc/src/lib/NssHttpClient/Util.h.fix19 ./esc/src/lib/NssHttpClient/Util.h
--- ./esc/src/lib/NssHttpClient/Util.h.fix19 2014-04-23 14:40:20.020341304 -0700
+++ ./esc/src/lib/NssHttpClient/Util.h 2014-04-23 14:41:30.120464932 -0700
@@ -34,6 +34,7 @@ class Util
~Util();
public:
NSAPI_PUBLIC static int ascii2numeric(char ch);
+ NSAPI_PUBLIC static void stripTrailingCRLF(char *buff, char replaceWith);
/* static char *Buffer2String (Buffer &data);
static Buffer *Str2Buf (const char *s);
static char *URLEncode (Buffer &data);
diff -up ./esc/src/lib/NssHttpClient/request.cpp.fix19 ./esc/src/lib/NssHttpClient/request.cpp
--- ./esc/src/lib/NssHttpClient/request.cpp.fix19 2014-04-23 14:40:27.207251455 -0700
+++ ./esc/src/lib/NssHttpClient/request.cpp 2014-04-23 14:41:38.935354731 -0700
@@ -25,6 +25,7 @@
#include "engine.h"
#include <prlog.h>
#include <time.h>
+#include "Util.h"
PRLogModuleInfo *httpLog = PR_NewLogModule("coolKeyHttpReq");
/**
@@ -283,6 +284,9 @@ PRBool PSHttpRequest::send( PRFileDesc *
if (strlen(_proxy_uri))
path = _proxy_uri;
+ //check for and replace stray line feed chars in path only.
+ Util::stripTrailingCRLF(path,' ');
+
data = PR_smprintf( "%s %s %s\r\n", _method, path,
HttpProtocolToString(_proto) );

View file

@ -1,6 +1,6 @@
Name: esc
Version: 1.1.0
Release: 23%{?dist}
Release: 25%{?dist}
Summary: Enterprise Security Client Smart Card Client
License: GPL+
URL: http://directory.fedora.redhat.com/wiki/CoolKey
@ -33,13 +33,15 @@ Patch14: esc-1.1.0-fix14.patch
Patch15: esc-1.1.0-fix15.patch
Patch16: esc-1.1.0-fix16.patch
Patch17: esc-1.1.0-fix17.patch
Patch18: esc-1.1.0-fix18.patch
Patch19: esc-1.1.0-fix19.patch
BuildRequires: doxygen fontconfig-devel freetype-devel >= 2.1
BuildRequires: glib2-devel libIDL-devel atk-devel gtk2-devel libjpeg-devel
BuildRequires: pango-devel libpng-devel pkgconfig zlib-devel
BuildRequires: nspr-devel nss-devel
BuildRequires: autoconf213 libX11-devel libXt-devel
BuildRequires: xulrunner xulrunner-devel
BuildRequires: xulrunner-devel <= 27.0
BuildRequires: pcsc-lite-devel coolkey-devel
BuildRequires: desktop-file-utils zip binutils libnotify-devel
@ -69,7 +71,7 @@ AutoReqProv: 0
%define escxuldir src/app/xul/esc
%define escxulchromeicons %{escxuldir}/chrome/icons/default
%define escdaemon escd
%define geckoversion 22.0
%define geckoversion 27.0
Source0: http://pki.fedoraproject.org/pki/sources/%name/%{escname}.tar.bz2
Source1: http://pki.fedoraproject.org/pki/sources/%name/esc
@ -104,6 +106,8 @@ cryptographic smartcards.
%patch15 -p1 -b .fix15
%patch16 -p1 -b .fix16
%patch17 -p1 -b .fix17
%patch18 -p1 -b .fix18
%patch19 -p1 -b .fix19
r=$(uname -r | sed -e 's/\(^[^.]*\.[^.]*\).*/\1/')
[ -f esc/coreconf/Linux$r.mk ] || ln -s Linux3.5.mk esc/coreconf/Linux$r.mk
@ -232,6 +236,13 @@ if [ -x %{_bindir}/gtk-update-icon-cache ]; then
fi
%changelog
* Tue Sep 09 2014 Jack Magne <jmagne@redhat.com>=1.1.0-25
- Adjust spec file only to restrict xulrunner-devel version.
- We have no choice since the latest devel package has no way to install an app.
* Mon Apr 23 2014 Jack Magne <jmagne@redhat.com>=1.1.0-24
- Fix minor http client error.
* Thu Apr 17 2014 Jack Maghe <jmagne@redhat.com>=1.1.0-23
- Appease more xulrunner changes.
* Sat Aug 03 2013 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.1.0-23
- Rebuilt for https://fedoraproject.org/wiki/Fedora_20_Mass_Rebuild