From 8ba515b514c55d95bca01621febd588c47af90ce Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 21 Jul 2022 02:57:56 +0000 Subject: [PATCH 01/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index a32d047..ff40692 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 2.git%{shortcommit0}%{?dist} +Release: 3.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPLv2 URL: http://www.open-fcoe.org @@ -80,6 +80,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Thu Jul 21 2022 Fedora Release Engineering - 1.0.34-3.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + * Fri Feb 04 2022 Chris Leech - 1.0.34-2.gitb233050 - FTBFS: more gcc 12 snprintf truncation issues on 32-bit arch From 5d854e7245993ec5b1736997be1431030d26c886 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 19 Jan 2023 03:14:09 +0000 Subject: [PATCH 02/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index ff40692..0e985d5 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 3.git%{shortcommit0}%{?dist} +Release: 4.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPLv2 URL: http://www.open-fcoe.org @@ -80,6 +80,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Thu Jan 19 2023 Fedora Release Engineering - 1.0.34-4.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + * Thu Jul 21 2022 Fedora Release Engineering - 1.0.34-3.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild From 297dd1dca7fe7bd3f325f3aab6e0e77e037e0bb8 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 19 Jul 2023 19:27:54 +0000 Subject: [PATCH 03/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index 0e985d5..3ea7c16 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 4.git%{shortcommit0}%{?dist} +Release: 5.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPLv2 URL: http://www.open-fcoe.org @@ -80,6 +80,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Wed Jul 19 2023 Fedora Release Engineering - 1.0.34-5.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + * Thu Jan 19 2023 Fedora Release Engineering - 1.0.34-4.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild From 028510839f20f11ac7addda937e7bbae8815791c Mon Sep 17 00:00:00 2001 From: Yaakov Selkowitz Date: Wed, 12 Jul 2023 20:34:32 -0400 Subject: [PATCH 04/12] Drop i686 build This package fails with a compiler error on i686 only, but there should be no need for an i686 build at this point: https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval --- fcoe-utils.spec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index 3ea7c16..bea6cd6 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -29,6 +29,9 @@ Requires(postun): systemd Patch1: 0001-fcoemon-add-snprintf-string-precision-modifiers-in-f.patch +# https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval +ExcludeArch: %{ix86} + %description Fibre Channel over Ethernet utilities fcoeadm - command line tool for configuring FCoE interfaces From 8f53992b0f469d00871123a8cb020cefd6ce9d4e Mon Sep 17 00:00:00 2001 From: Chris Leech Date: Mon, 30 Oct 2023 13:33:46 -0700 Subject: [PATCH 05/12] use SPDX in license tag --- fcoe-utils.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index bea6cd6..e14e61c 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,9 +7,9 @@ Name: fcoe-utils Version: 1.0.34 -Release: 5.git%{shortcommit0}%{?dist} +Release: 6.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities -License: GPLv2 +License: GPL-2.0-only URL: http://www.open-fcoe.org Source0: https://github.com/openSUSE/fcoe-utils/archive/%{commit0}.tar.gz#/%{name}-%{version}-%{shortcommit0}.tar.gz ExcludeArch: ppc s390 @@ -83,6 +83,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Mon Oct 30 2023 Chris Leech - 1.0.34-6.gitb233050 +- use SPDX in license tag + * Wed Jul 19 2023 Fedora Release Engineering - 1.0.34-5.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild From 5ac2d8057f7d62e55315fe8300aa176dd0dd11d1 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 19 Jan 2024 19:03:15 +0000 Subject: [PATCH 06/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index e14e61c..59d9771 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 6.git%{shortcommit0}%{?dist} +Release: 7.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -83,6 +83,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Fri Jan 19 2024 Fedora Release Engineering - 1.0.34-7.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Mon Oct 30 2023 Chris Leech - 1.0.34-6.gitb233050 - use SPDX in license tag From 106e662e895a3b5edf7bb2158fabc2886b21dd09 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 24 Jan 2024 11:21:49 +0000 Subject: [PATCH 07/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index 59d9771..e0ad9a4 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 7.git%{shortcommit0}%{?dist} +Release: 8.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -83,6 +83,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Wed Jan 24 2024 Fedora Release Engineering - 1.0.34-8.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Fri Jan 19 2024 Fedora Release Engineering - 1.0.34-7.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild From 3132bf66ab0c821be58f3081df9a73ae27d7c0ee Mon Sep 17 00:00:00 2001 From: Stephen Gallagher Date: Tue, 6 Feb 2024 21:23:00 -0500 Subject: [PATCH 08/12] FTBFS: Don't attempt to memcpy() zero bytes Signed-off-by: Stephen Gallagher --- 0002-Don-t-attempt-to-memcpy-zero-bytes.patch | 34 +++++++++++++++++++ fcoe-utils.spec | 8 ++++- 2 files changed, 41 insertions(+), 1 deletion(-) create mode 100644 0002-Don-t-attempt-to-memcpy-zero-bytes.patch diff --git a/0002-Don-t-attempt-to-memcpy-zero-bytes.patch b/0002-Don-t-attempt-to-memcpy-zero-bytes.patch new file mode 100644 index 0000000..fa45a14 --- /dev/null +++ b/0002-Don-t-attempt-to-memcpy-zero-bytes.patch @@ -0,0 +1,34 @@ +From 78a5e2e17bba531b41101ca036a5bb1a0d5caca5 Mon Sep 17 00:00:00 2001 +From: Stephen Gallagher +Date: Tue, 6 Feb 2024 21:15:33 -0500 +Subject: [PATCH 2/2] Don't attempt to memcpy() zero bytes + +add_rtattr_nest() is called in several places in the code. As part of +its operation, it calls add_rtattr(nm type, NULL, 0) which results in +NULL and 0 being passed to memcpy(). This fails with -Werror=nonnull +on recent GCC. + +Signed-off-by: Stephen Gallagher +--- + lib/rtnetlink.c | 5 ++++- + 1 file changed, 4 insertions(+), 1 deletion(-) + +diff --git a/lib/rtnetlink.c b/lib/rtnetlink.c +index 3b8413718997568a20752791807b19c1f299955e..faa60d7c12f68af175d223b6c3c3257a982e4f37 100644 +--- a/lib/rtnetlink.c ++++ b/lib/rtnetlink.c +@@ -172,7 +172,10 @@ static void add_rtattr(struct nlmsghdr *n, int type, const void *data, int alen) + + rta->rta_type = type; + rta->rta_len = len; +- memcpy(RTA_DATA(rta), data, alen); ++ if (alen > 0) ++ { ++ memcpy(RTA_DATA(rta), data, alen); ++ } + n->nlmsg_len = NLMSG_ALIGN(n->nlmsg_len) + RTA_ALIGN(len); + } + +-- +2.43.0 + diff --git a/fcoe-utils.spec b/fcoe-utils.spec index e0ad9a4..263df66 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 8.git%{shortcommit0}%{?dist} +Release: 9.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -29,6 +29,9 @@ Requires(postun): systemd Patch1: 0001-fcoemon-add-snprintf-string-precision-modifiers-in-f.patch +# https://github.com/openSUSE/fcoe-utils/pull/25 +Patch2: 0002-Don-t-attempt-to-memcpy-zero-bytes.patch + # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval ExcludeArch: %{ix86} @@ -83,6 +86,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Tue Feb 06 2024 Stephen Gallagher - 1.0.34-9.gitb233050 +- FTBFS: Don't attempt to memcpy() zero bytes + * Wed Jan 24 2024 Fedora Release Engineering - 1.0.34-8.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild From 66071c86d6d6f156815160a8d2502023e9d1cb98 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 17 Jul 2024 22:55:13 +0000 Subject: [PATCH 09/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index 263df66..4c46ba5 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 9.git%{shortcommit0}%{?dist} +Release: 10.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -86,6 +86,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Wed Jul 17 2024 Fedora Release Engineering - 1.0.34-10.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild + * Tue Feb 06 2024 Stephen Gallagher - 1.0.34-9.gitb233050 - FTBFS: Don't attempt to memcpy() zero bytes From a5b0bf8780e55b58cab05aec95c6bb68821c7143 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 16 Jan 2025 18:02:04 +0000 Subject: [PATCH 10/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index 4c46ba5..dd01c07 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 10.git%{shortcommit0}%{?dist} +Release: 11.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -86,6 +86,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Thu Jan 16 2025 Fedora Release Engineering - 1.0.34-11.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild + * Wed Jul 17 2024 Fedora Release Engineering - 1.0.34-10.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild From 03250fc98889f227ae59499b342938d959f0531b Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 23 Jul 2025 20:24:20 +0000 Subject: [PATCH 11/12] Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild --- fcoe-utils.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fcoe-utils.spec b/fcoe-utils.spec index dd01c07..e5dc173 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 11.git%{shortcommit0}%{?dist} +Release: 12.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -86,6 +86,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Wed Jul 23 2025 Fedora Release Engineering - 1.0.34-12.gitb233050 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild + * Thu Jan 16 2025 Fedora Release Engineering - 1.0.34-11.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild From 5f395717891c031fb15e694d9f428cc982815622 Mon Sep 17 00:00:00 2001 From: Chris Leech Date: Tue, 6 Jan 2026 16:25:57 -0800 Subject: [PATCH 12/12] FTBFS: GCC 16 -Werror=discarded-qualifiers Signed-off-by: Chris Leech --- ...iscards-const-qualifier-from-pointer.patch | 44 +++++++++++++++++++ fcoe-utils.spec | 7 ++- 2 files changed, 50 insertions(+), 1 deletion(-) create mode 100644 0003-initialization-discards-const-qualifier-from-pointer.patch diff --git a/0003-initialization-discards-const-qualifier-from-pointer.patch b/0003-initialization-discards-const-qualifier-from-pointer.patch new file mode 100644 index 0000000..39fc30e --- /dev/null +++ b/0003-initialization-discards-const-qualifier-from-pointer.patch @@ -0,0 +1,44 @@ +From dfadd3fd53860a8f44871e479bf602a2fa3bae53 Mon Sep 17 00:00:00 2001 +From: Chris Leech +Date: Tue, 6 Jan 2026 16:20:49 -0800 +Subject: [PATCH 1/1] =?UTF-8?q?initialization=20discards=20=E2=80=98const?= + =?UTF-8?q?=E2=80=99=20qualifier=20from=20pointer=20target=20type?= +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Signed-off-by: Chris Leech +--- + lib/fcoe_utils.c | 2 +- + lib/sysfs_hba.c | 2 +- + 2 files changed, 2 insertions(+), 2 deletions(-) + +diff --git a/lib/fcoe_utils.c b/lib/fcoe_utils.c +index 4d13dd7ecf9..5ea713679a5 100644 +--- a/lib/fcoe_utils.c ++++ b/lib/fcoe_utils.c +@@ -161,7 +161,7 @@ int fcoe_checkdir(char *dir) + */ + char *get_ifname_from_symbolic_name(const char *symbolic_name) + { +- char *last_space = strrchr(symbolic_name, ' '); ++ const char *last_space = strrchr(symbolic_name, ' '); + + if (!last_space || strlen(last_space) == 1) + return NULL; +diff --git a/lib/sysfs_hba.c b/lib/sysfs_hba.c +index 381f335d7ea..302ce634954 100644 +--- a/lib/sysfs_hba.c ++++ b/lib/sysfs_hba.c +@@ -441,7 +441,7 @@ char *get_pci_dev_from_netdev(const char *netdev) + free(path); + if (ret == -1) { + char realdev[256]; +- char *subif; ++ const char *subif; + size_t len; + + subif = strchr(netdev, '.'); +-- +2.52.0 + diff --git a/fcoe-utils.spec b/fcoe-utils.spec index e5dc173..1794653 100644 --- a/fcoe-utils.spec +++ b/fcoe-utils.spec @@ -7,7 +7,7 @@ Name: fcoe-utils Version: 1.0.34 -Release: 12.git%{shortcommit0}%{?dist} +Release: 13.git%{shortcommit0}%{?dist} Summary: Fibre Channel over Ethernet utilities License: GPL-2.0-only URL: http://www.open-fcoe.org @@ -32,6 +32,8 @@ Patch1: 0001-fcoemon-add-snprintf-string-precision-modifiers-in-f.patch # https://github.com/openSUSE/fcoe-utils/pull/25 Patch2: 0002-Don-t-attempt-to-memcpy-zero-bytes.patch +Patch3: 0003-initialization-discards-const-qualifier-from-pointer.patch + # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval ExcludeArch: %{ix86} @@ -86,6 +88,9 @@ done %{_libexecdir}/fcoe/ %changelog +* Wed Jan 07 2026 Chris Leech - 1.0.34-13.gitb233050 +- FTBFS: GCC 16 -Werror=discarded-qualifiers + * Wed Jul 23 2025 Fedora Release Engineering - 1.0.34-12.gitb233050 - Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild