From 2aaba31e49828daaa9b74c33073666fcff5a55ad Mon Sep 17 00:00:00 2001 From: Josh Boyer Date: Mon, 18 May 2015 13:17:08 -0400 Subject: [PATCH] Fix incorrect bandwidth on some Chicony webcams --- kernel.spec | 7 ++++ ...-incorrect-bandwidth-with-Chicony-de.patch | 35 +++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100644 v4l-uvcvideo-Fix-incorrect-bandwidth-with-Chicony-de.patch diff --git a/kernel.spec b/kernel.spec index 401b09e59..ca4455aa4 100644 --- a/kernel.spec +++ b/kernel.spec @@ -655,6 +655,8 @@ Patch26201: ovl-don-t-remove-non-empty-opaque-directory.patch #rhbz 1220118 Patch26202: 0001-media-media-Fix-regression-in-some-more-dib0700-base.patch +Patch26203: v4l-uvcvideo-Fix-incorrect-bandwidth-with-Chicony-de.patch + # END OF PATCH DEFINITIONS %endif @@ -1424,6 +1426,8 @@ ApplyPatch ovl-don-t-remove-non-empty-opaque-directory.patch #rhbz 1220118 ApplyPatch 0001-media-media-Fix-regression-in-some-more-dib0700-base.patch +ApplyPatch v4l-uvcvideo-Fix-incorrect-bandwidth-with-Chicony-de.patch + # END OF PATCH APPLICATIONS %endif @@ -2274,6 +2278,9 @@ fi # # %changelog +* Mon May 18 2015 Josh Boyer +- Fix incorrect bandwidth on some Chicony webcams + * Mon May 18 2015 Justin M. Forbes - 4.0.4-300 - Linux v4.0.4 diff --git a/v4l-uvcvideo-Fix-incorrect-bandwidth-with-Chicony-de.patch b/v4l-uvcvideo-Fix-incorrect-bandwidth-with-Chicony-de.patch new file mode 100644 index 000000000..77b2abb84 --- /dev/null +++ b/v4l-uvcvideo-Fix-incorrect-bandwidth-with-Chicony-de.patch @@ -0,0 +1,35 @@ +From: Laurent Pinchart +Date: Mon, 18 May 2015 10:53:48 +0300 +Subject: [PATCH] v4l: uvcvideo: Fix incorrect bandwidth with Chicony device + 04f2:b50b + +The "TOSHIBA Web Camera - 5M" Chicony device (04f2:b50b) seems to +compute the bandwidth on 16 bits and erroneously sign-extend it to +32 bits, resulting in a huge bandwidth value. Detect and fix that +condition by setting the 16 MSBs to 0 when they're all equal to 1. + +Reported-by: Hans de Goede +Signed-off-by: Laurent Pinchart +--- + drivers/media/usb/uvc/uvc_video.c | 8 ++++++++ + 1 file changed, 8 insertions(+) + +diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c +index 20ccc9d315dc..f839654ea436 100644 +--- a/drivers/media/usb/uvc/uvc_video.c ++++ b/drivers/media/usb/uvc/uvc_video.c +@@ -119,6 +119,14 @@ static void uvc_fixup_video_ctrl(struct uvc_streaming *stream, + ctrl->dwMaxVideoFrameSize = + frame->dwMaxVideoFrameBufferSize; + ++ /* The "TOSHIBA Web Camera - 5M" Chicony device (04f2:b50b) seems to ++ * compute the bandwidth on 16 bits and erroneously sign-extend it to ++ * 32 bits, resulting in a huge bandwidth value. Detect and fix that ++ * condition by setting the 16 MSBs to 0 when they're all equal to 1. ++ */ ++ if ((ctrl->dwMaxPayloadTransferSize & 0xffff0000) == 0xffff0000) ++ ctrl->dwMaxPayloadTransferSize &= ~0xffff0000; ++ + if (!(format->flags & UVC_FMT_FLAG_COMPRESSED) && + stream->dev->quirks & UVC_QUIRK_FIX_BANDWIDTH && + stream->intf->num_altsetting > 1) {