From b474e6c42146a783938107bee3bff8e19043aeab Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Thu, 13 Aug 2020 18:47:04 +0200 Subject: [PATCH 01/20] New upstream release 2.14.0 Signed-off-by: Michal Fabik --- .gitignore | 1 + libreport.spec | 131 +++++++++++++------------------------------------ sources | 2 +- 3 files changed, 35 insertions(+), 99 deletions(-) diff --git a/.gitignore b/.gitignore index ebda8c9..23c2ea8 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3 +12,4 @@ /libreport-2.12.0.tar.gz /libreport-2.13.0.tar.gz /libreport-2.13.1.tar.gz +/libreport-2.14.0.tar.gz diff --git a/libreport.spec b/libreport.spec index 4c4c9a8..f7fe467 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.13.1 -Release: 4%{?dist} +Version: 2.14.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -49,23 +49,25 @@ BuildRequires: glibc-all-langpacks BuildRequires: xmlrpc-c-devel %endif BuildRequires: doxygen -BuildRequires: systemd-devel +BuildRequires: systemd-devel%{?_isa} BuildRequires: augeas-devel BuildRequires: augeas -BuildRequires: xz -BuildRequires: lz4 +BuildRequires: libarchive-devel%{?_isa} Requires: libreport-filesystem = %{version}-%{release} -Requires: satyr >= 0.24 -Requires: glib2 >= %{glib_ver} -Requires: xz -Requires: lz4 -Requires: nettle +Requires: satyr%{?_isa} >= 0.24 +Requires: glib2%{?_isa} >= %{glib_ver} +Requires: libarchive%{?_isa} +Requires: nettle%{?_isa} # Required for the temporary modularity hack, see below %if 0%{?_module_build} BuildRequires: sed %endif +Obsoletes: %{name}-compat < 2.13.2 +Obsoletes: %{name}-plugin-rhtsupport < 2.13.2 +Obsoletes: %{name}-rhel < 2.13.2 + %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -224,25 +226,6 @@ Requires: python3-subscription-manager-rhsm %description plugin-ureport Uploads micro-report to abrt server -%package plugin-rhtsupport -Summary: %{name}'s RHTSupport plugin -Requires: %{name} = %{version}-%{release} -Requires: libreport-web = %{version}-%{release} - -%description plugin-rhtsupport -Plugin to report bugs into RH support system. - -%if %{with bugzilla} -%package compat -Summary: %{name}'s compat layer for obsoleted 'report' package -Requires: libreport = %{version}-%{release} -Requires: %{name}-plugin-bugzilla = %{version}-%{release} -Requires: %{name}-plugin-rhtsupport = %{version}-%{release} - -%description compat -Provides 'report' command-line tool. -%endif - %package plugin-reportuploader Summary: %{name}'s reportuploader plugin Requires: %{name} = %{version}-%{release} @@ -263,16 +246,6 @@ install this package and you're done. %endif %if 0%{?rhel} -%package rhel -Summary: Default configuration for reporting bugs via Red Hat infrastructure -Requires: %{name} = %{version}-%{release} -Requires: %{name}-plugin-ureport - -%description rhel -Default configuration for reporting bugs via Red Hat infrastructure -used to easily configure the reporting process for Red Hat systems. Just -install this package and you're done. - %package rhel-bugzilla Summary: Default configuration for reporting bugs to Red Hat Bugzilla Requires: %{name} = %{version}-%{release} @@ -300,9 +273,7 @@ package and you're done. Summary: Default configuration for reporting anaconda bugs Requires: %{name} = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -%if 0%{?rhel} -Requires: libreport-plugin-rhtsupport = %{version}-%{release} -%else +%if ! 0%{?rhel} Requires: libreport-plugin-bugzilla = %{version}-%{release} %endif @@ -320,9 +291,6 @@ autoconf %configure \ %if %{without bugzilla} --without-bugzilla \ -%endif -%if 0%{?rhel} - --enable-import-rhtsupport-cert \ %endif --enable-doxygen-docs \ --disable-silent-rules @@ -375,16 +343,7 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaFedora.xml # Remove unwanted RHEL specific workflow configuration files %if 0%{!?rhel:1} -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELCCpp.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELKerneloops.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELPython.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELvmcore.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELxorg.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELLibreport.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELJava.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELJavaScript.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_uReport.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaRHEL.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaRHELBugzilla.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaCCpp.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaKerneloops.xml @@ -402,11 +361,8 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataxorg.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataLibreport.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataJava.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataJavaScript.xml -rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel.conf -rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_uReport.conf rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel_bugzilla.conf -rm -f %{buildroot}%{_mandir}/man5/report_rhel.conf.5 rm -f %{buildroot}%{_mandir}/man5/report_uReport.conf.5 rm -f %{buildroot}%{_mandir}/man5/report_rhel_bugzilla.conf.5 %endif @@ -635,26 +591,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/events.d/centos_report_event.conf %{_mandir}/man5/centos_report_event.conf.5.gz -%files plugin-rhtsupport -%config(noreplace) %{_sysconfdir}/libreport/plugins/rhtsupport.conf -%{_datadir}/%{name}/conf.d/plugins/rhtsupport.conf -%{_datadir}/%{name}/events/report_RHTSupport.xml -%{_datadir}/%{name}/events/report_RHTSupport_AddData.xml -%if 0%{?rhel} -%attr(600,root,root)%{_sysconfdir}/%{name}/cert-api.access.redhat.com.pem -%endif -%config(noreplace) %{_sysconfdir}/libreport/events.d/rhtsupport_event.conf -%{_mandir}/man1/reporter-rhtsupport.1.gz -%{_mandir}/man5/rhtsupport.conf.5.* -%{_mandir}/man5/rhtsupport_event.conf.5.* -%{_bindir}/reporter-rhtsupport - -%if %{with bugzilla} -%files compat -%{_bindir}/report -%{_mandir}/man1/report.1.gz -%endif - %files plugin-reportuploader %{_mandir}/man*/reporter-upload.* %{_mandir}/man5/uploader_event.conf.5.* @@ -687,27 +623,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %if 0%{?rhel} -%files rhel -%{_datadir}/%{name}/workflows/workflow_RHELCCpp.xml -%{_datadir}/%{name}/workflows/workflow_RHELKerneloops.xml -%{_datadir}/%{name}/workflows/workflow_RHELPython.xml -%{_datadir}/%{name}/workflows/workflow_RHELvmcore.xml -%{_datadir}/%{name}/workflows/workflow_RHELxorg.xml -%{_datadir}/%{name}/workflows/workflow_RHELLibreport.xml -%{_datadir}/%{name}/workflows/workflow_RHELJava.xml -%{_datadir}/%{name}/workflows/workflow_RHELJavaScript.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataCCpp.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataJava.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataKerneloops.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataLibreport.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataPython.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDatavmcore.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataxorg.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataJavaScript.xml -%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel.conf -%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf -%{_mandir}/man5/report_rhel.conf.5.* - %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml %{_datadir}/%{name}/workflows/workflow_RHELBugzillaKerneloops.xml @@ -744,6 +659,26 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Aug 13 2020 Michal Fabik 2.14.0-1 +- forbidden_words: Add potentially sensitive env vars +- lib: Add version script for libreport +- lib: compress: Use libarchive +- Replace various utility functions with stock GLib ones +- gtk,lib: Update symbol list +- dd: Update dd_get_owner to handle error return values +- dirsize: Don't pick .lock'd dirs for deletion +- setgid instead of setuid the abrt-action-install-debuginfo-to-abrt-cache +- Various coding style improvements +- Various memory management fixes +- lib: Check for errors when opening files +- gtk-helpers: Check return value +- doc: Exclude more files with --without-bugzilla +- lib: Don’t use external executables for decompression +- lib: Decommission libreport_list_free_with_free +- Drop Red Hat Customer Portal reporter +- ureport: Drop Strata integration +- lib: Remove creates-items tag parsing in event definitions + * Fri Aug 07 2020 Peter Robinson - 2.13.1-4 - Bump to fix upgrade path diff --git a/sources b/sources index 36fbd1b..38afa93 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.13.1.tar.gz) = fc3db46ee6885053387b86e682f9ed1908d050149a5d820b40444b7db413af89afdcd6abef780179c5ca968ea036f3ae245884414b94d426547e58a89b8bbb65 +SHA512 (libreport-2.14.0.tar.gz) = aa56b994c97b07596a7022d156ffaa7733aa9db94b743ffeb031810f5aaae4f0ebfa62d9d66dff60f224e91ddfd2794278830d6ceab5ab2582e055ade329eee4 From 94b7fe094d8de2f02ac0cf15e06836ecb95f4d15 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Mon, 17 Aug 2020 14:38:09 +0200 Subject: [PATCH 02/20] spec: Drop %{?_isa} from BuildRequires https://github.com/abrt/libreport/issues/661 Signed-off-by: Michal Fabik --- libreport.spec | 6 +++--- sources | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libreport.spec b/libreport.spec index f7fe467..103e5bd 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -49,10 +49,10 @@ BuildRequires: glibc-all-langpacks BuildRequires: xmlrpc-c-devel %endif BuildRequires: doxygen -BuildRequires: systemd-devel%{?_isa} +BuildRequires: systemd-devel BuildRequires: augeas-devel BuildRequires: augeas -BuildRequires: libarchive-devel%{?_isa} +BuildRequires: libarchive-devel Requires: libreport-filesystem = %{version}-%{release} Requires: satyr%{?_isa} >= 0.24 Requires: glib2%{?_isa} >= %{glib_ver} diff --git a/sources b/sources index 38afa93..c9ad10a 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.14.0.tar.gz) = aa56b994c97b07596a7022d156ffaa7733aa9db94b743ffeb031810f5aaae4f0ebfa62d9d66dff60f224e91ddfd2794278830d6ceab5ab2582e055ade329eee4 +SHA512 (libreport-2.14.0.tar.gz) = 6bc428a2d91b22f2df1abc9326c131e91e5e7be78ca64ad6533ff8246fa02df9a975360686811d29fd66210206a4e4ee5dc9faf2c9b23eccab7ca0ec07c3d43c From 0cbd768d8f7b273f0179b2025ea7ae38275bafd9 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Tue, 18 Aug 2020 16:09:22 +0200 Subject: [PATCH 03/20] Bump release to rebuild in side tag Signed-off-by: Michal Fabik --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 103e5bd..84961cc 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz From 97c8c7e3358529d2d2909be23a89d7c475ed1da1 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Wed, 26 Aug 2020 14:51:23 +0200 Subject: [PATCH 04/20] Bump release to rebuild in new side tag Signed-off-by: Michal Fabik --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 84961cc..f5fcc6e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -659,6 +659,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Aug 26 2020 Michal Fabik 2.14.0-4 +- Bump release to rebuild in new side tag + * Thu Aug 13 2020 Michal Fabik 2.14.0-1 - forbidden_words: Add potentially sensitive env vars - lib: Add version script for libreport From 63354d5c0dcb3c870fe797c69df210eaa07d4602 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Tue, 1 Sep 2020 08:57:14 +0200 Subject: [PATCH 05/20] Add patches with upstream fixes --- ...ui-wizard-gtk-wizard-Remove-variable.patch | 39 +++++++++++++++ ...d-gtk-wizard-Fix-invalid-memory-read.patch | 49 +++++++++++++++++++ libreport.spec | 8 ++- 3 files changed, 95 insertions(+), 1 deletion(-) create mode 100644 0001-gui-wizard-gtk-wizard-Remove-variable.patch create mode 100644 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch diff --git a/0001-gui-wizard-gtk-wizard-Remove-variable.patch b/0001-gui-wizard-gtk-wizard-Remove-variable.patch new file mode 100644 index 0000000..9537db0 --- /dev/null +++ b/0001-gui-wizard-gtk-wizard-Remove-variable.patch @@ -0,0 +1,39 @@ +From 1c646a2948d287368ec1a82b444e8175ebfbf5b9 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Tue, 25 Aug 2020 15:05:31 +0300 +Subject: [PATCH] gui-wizard-gtk: wizard: Remove variable + +cmd_output is no longer used since +440bcfa8526d50f122ec14e19f2bf2aa336f61e7 and trying to call +g_string_free() on it results in a critical warning. +--- + src/gui-wizard-gtk/wizard.c | 6 ------ + 1 file changed, 6 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 44900448..a4d7caa0 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -231,8 +231,6 @@ typedef struct + + static page_obj_t pages[NUM_PAGES]; + +-static GString *cmd_output = NULL; +- + /* Utility functions */ + + static void clear_warnings(void); +@@ -1667,10 +1665,6 @@ static gboolean consume_cmd_output(GIOChannel *source, GIOCondition condition, g + log_notice("done running event on '%s': %d", g_dump_dir_name, retval); + append_to_textview(g_tv_event_log, "\n"); + +- /* Free child output buffer */ +- g_string_free(cmd_output, TRUE); +- cmd_output = NULL; +- + /* Hide spinner and stop btn */ + gtk_widget_hide(GTK_WIDGET(g_spinner_event_log)); + gtk_widget_hide(g_btn_stop); +-- +2.28.0 + diff --git a/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch b/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch new file mode 100644 index 0000000..ed46b09 --- /dev/null +++ b/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch @@ -0,0 +1,49 @@ +From 85b687098bcedb67285ab787b8bd506d328c34e0 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Tue, 25 Aug 2020 15:17:54 +0300 +Subject: [PATCH] gui-wizard-gtk: wizard: Fix invalid memory read +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +This partially reverts 7aba6e53bbfeedaacd95bbaa5e0c5e325a3e6a8d, which +results in “event” being inappropriately freed before a “goto” statement +is executed and the value stored in “g_event_selected” is read. +--- + src/gui-wizard-gtk/wizard.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index a4d7caa0..3e69a513 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -2635,7 +2635,7 @@ static gint select_next_page_no(gint current_page_no) + + log_info("%s: Looking for next event to process", __func__); + /* (note: this frees and sets to NULL g_event_selected) */ +- g_autofree char *event = setup_next_processed_event(&g_auto_event_list); ++ char *event = setup_next_processed_event(&g_auto_event_list); + if (!event) + { + current_page_no = PAGENO_EVENT_PROGRESS - 1; +@@ -2644,6 +2644,8 @@ static gint select_next_page_no(gint current_page_no) + + if (!get_sensitive_data_permission(event)) + { ++ free(event); ++ + cancel_processing(g_lbl_event_log, /* default message */ NULL, TERMINATE_NOFLAGS); + current_page_no = PAGENO_EVENT_PROGRESS - 1; + goto again; +@@ -2659,6 +2661,8 @@ static gint select_next_page_no(gint current_page_no) + + if (libreport_get_global_stop_on_not_reportable()) + { ++ free(event); ++ + cancel_processing(g_lbl_event_log, msg, TERMINATE_NOFLAGS); + current_page_no = PAGENO_EVENT_PROGRESS - 1; + goto again; +-- +2.28.0 + diff --git a/libreport.spec b/libreport.spec index f5fcc6e..784b7dc 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,11 +15,14 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 4%{?dist} +Release: 5%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch +Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -659,6 +662,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Sep 1 2020 - Ernestas Kulik - 2.14.0-5 +- Add upstream fixes for memory management + * Wed Aug 26 2020 Michal Fabik 2.14.0-4 - Bump release to rebuild in new side tag From 8e8caa23f36ee943125bbacb0a17928c03730d11 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Wed, 2 Sep 2020 15:23:27 +0200 Subject: [PATCH 06/20] Bump release to rebuild in new side tag Signed-off-by: Michal Fabik --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 784b7dc..482d5ed 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -662,6 +662,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Sep 02 2020 Michal Fabik 2.14.0-6 +- Bump release to rebuild in new side tag + * Tue Sep 1 2020 - Ernestas Kulik - 2.14.0-5 - Add upstream fixes for memory management From d6e9593b5e2616a31909864b99d9bfbcf99d3c2e Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Wed, 9 Sep 2020 11:12:30 +0200 Subject: [PATCH 07/20] Bump release to rebuild gnome-abrt Resolves rhbz#1876015 Signed-off-by: Michal Fabik --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 482d5ed..ea66d1f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 6%{?dist} +Release: 7%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -662,6 +662,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Sep 09 2020 Michal Fabik 2.14.0-7 +- Bump release to rebuild gnome-abrt + * Wed Sep 02 2020 Michal Fabik 2.14.0-6 - Bump release to rebuild in new side tag From cc7ebfb09ba7a336730e3c8058e9cdd5e5fe2880 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Mon, 14 Sep 2020 10:49:03 +0200 Subject: [PATCH 08/20] Bump release to rebuild reportd Signed-off-by: Michal Fabik --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index ea66d1f..31ba4f9 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 7%{?dist} +Release: 8%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -662,6 +662,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Mon 14 2020 Michal Fabik 2.14.0-8 +- Bump release to rebuild reportd + * Wed Sep 09 2020 Michal Fabik 2.14.0-7 - Bump release to rebuild gnome-abrt From 8dc7148d3e29750bed1cef9d979ca87b8c5ae60d Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Mon, 14 Sep 2020 13:43:48 +0200 Subject: [PATCH 09/20] spec: Fix typo in changelog date Signed-off-by: Michal Fabik --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 31ba4f9..075cc15 100644 --- a/libreport.spec +++ b/libreport.spec @@ -662,7 +662,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog -* Wed Mon 14 2020 Michal Fabik 2.14.0-8 +* Mon Sep 14 2020 Michal Fabik 2.14.0-8 - Bump release to rebuild reportd * Wed Sep 09 2020 Michal Fabik 2.14.0-7 From b33ffa6bd854806b477d2ebf648aac5e4c29e357 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 25 Sep 2020 19:34:08 +0200 Subject: [PATCH 10/20] Add patch for #1882319 --- ...zard-gtk-Fix-a-double-free-condition.patch | 53 +++++++++++++++++++ libreport.spec | 6 ++- 2 files changed, 58 insertions(+), 1 deletion(-) create mode 100644 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch diff --git a/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch b/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch new file mode 100644 index 0000000..c000d30 --- /dev/null +++ b/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch @@ -0,0 +1,53 @@ +From ce557c0fb309184a9a8fc38a76404324d94803b0 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Fri, 25 Sep 2020 19:23:51 +0200 +Subject: [PATCH] gui-wizard-gtk: Fix a double free condition + +We may only free `log_msg` in `update_command_run_log()` if it is the +result of the call to `g_strdup_printf()`, otherwise the caller takes +care of it. + +Partially reverts 7aba6e53. + +Resolves rhbz#1882319 +--- + src/gui-wizard-gtk/wizard.c | 12 +++++++++--- + 1 file changed, 9 insertions(+), 3 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 8a4486f2..a532c633 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -1385,7 +1385,7 @@ static void cancel_processing(GtkLabel *status_label, const char *message, int t + pango_attr_list_unref(list); + } + +-static void update_command_run_log(const char* message, struct analyze_event_data *evd) ++static void update_command_run_log(char *message, struct analyze_event_data *evd) + { + const bool it_is_a_dot = (message[0] == '.' && message[1] == '\0'); + +@@ -1393,12 +1393,18 @@ static void update_command_run_log(const char* message, struct analyze_event_dat + gtk_label_set_text(g_lbl_event_log, message); + + /* Don't append new line behind single dot */ +- g_autofree const char *log_msg = it_is_a_dot ? message : g_strdup_printf("%s\n", message); ++ char *log_msg = it_is_a_dot ? message : g_strdup_printf("%s\n", message); + append_to_textview(g_tv_event_log, log_msg); + save_to_event_log(evd, log_msg); ++ ++ if (log_msg != message) ++ { ++ /* We assume message is managed by the caller. */ ++ free(log_msg); ++ } + } + +-static void run_event_gtk_error(const char *error_line, void *param) ++static void run_event_gtk_error(char *error_line, void *param) + { + update_command_run_log(error_line, (struct analyze_event_data *)param); + } +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 075cc15..f41fff2 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,13 +15,14 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 8%{?dist} +Release: 9%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch +Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -662,6 +663,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Sep 25 2020 Matěj Grabovský - 2.14.0-9 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882319 + * Mon Sep 14 2020 Michal Fabik 2.14.0-8 - Bump release to rebuild reportd From d2219647283d4b6fda4c2a344d1ed96c155acabd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Sun, 27 Sep 2020 20:51:04 +0200 Subject: [PATCH 11/20] Add patch for #1882950 --- ...d-gtk-Fix-a-segfault-and-memory-leak.patch | 66 +++++++++++++++++++ libreport.spec | 6 +- 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch diff --git a/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch b/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch new file mode 100644 index 0000000..2b38feb --- /dev/null +++ b/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch @@ -0,0 +1,66 @@ +From cb2ab9a8b2e1dbc89e100aedc432c29a16246e84 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Sun, 27 Sep 2020 20:45:32 +0200 +Subject: [PATCH] gui-wizard-gtk: Fix a segfault and memory leak + +Only `arg[1]` has to be freed in `tv_details_row_activated()`, as +`arg[0]` is allocated statically. + +In `search_item_to_list_store_item()`, `tmp` gets overwritten with a new +value for every call to `gtk_text_buffer_get_text()`, so we need to free +the allocated memory continuously. + +Partially reverts 7aba6e53. + +Resolves rhbz#1882950 +--- + src/gui-wizard-gtk/wizard.c | 9 +++++++-- + 1 file changed, 7 insertions(+), 2 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index a532c633..775b709f 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -707,7 +707,7 @@ static void tv_details_row_activated( + return; + + gint exitcode; +- g_autofree gchar *arg[3]; ++ gchar *arg[3]; + arg[0] = (char *) "xdg-open"; + arg[1] = g_build_filename(g_dump_dir_name ? g_dump_dir_name : "", item_name, NULL); + arg[2] = NULL; +@@ -751,6 +751,8 @@ static void tv_details_row_activated( + gtk_widget_destroy(scrolled); + gtk_widget_destroy(dialog); + } ++ ++ g_free(arg[1]); + } + + /* static gboolean tv_details_select_cursor_row( +@@ -2126,17 +2128,20 @@ static void search_item_to_list_store_item(GtkListStore *store, GtkTreeIter *new + gtk_text_iter_backward_char(end); + } + +- g_autofree gchar *tmp = gtk_text_buffer_get_text(word->buffer, beg, &(word->start), ++ gchar *tmp = gtk_text_buffer_get_text(word->buffer, beg, &(word->start), + /*don't include hidden chars*/FALSE); + g_autofree gchar *prefix = g_markup_escape_text(tmp, /*NULL terminated string*/-1); ++ g_free(tmp); + + tmp = gtk_text_buffer_get_text(word->buffer, &(word->start), &(word->end), + /*don't include hidden chars*/FALSE); + g_autofree gchar *text = g_markup_escape_text(tmp, /*NULL terminated string*/-1); ++ g_free(tmp); + + tmp = gtk_text_buffer_get_text(word->buffer, &(word->end), end, + /*don't include hidden chars*/FALSE); + g_autofree gchar *suffix = g_markup_escape_text(tmp, /*NULL terminated string*/-1); ++ g_clear_pointer(&tmp, g_free); + + char *content = g_strdup_printf("%s%s%s", prefix, text, suffix); + +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index f41fff2..62cf646 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 9%{?dist} +Release: 10%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -23,6 +23,7 @@ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.ta Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch +Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -663,6 +664,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Sep 27 2020 Matěj Grabovský - 2.14.0-10 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882950 + * Fri Sep 25 2020 Matěj Grabovský - 2.14.0-9 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882319 From 79fb8f95bb5af7b2b375d6a3bfd60a94ca0d65d5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Tue, 29 Sep 2020 16:15:42 +0200 Subject: [PATCH 12/20] Add upstream patches for memory management Add patch for rhbz#1883337 and rhbz#1883410. --- 0005-gui-wizard-gtk-Fix-segfault.patch | 66 +++++++++++++++++++ ...l-autofree-pointers-before-returning.patch | 40 +++++++++++ libreport.spec | 8 ++- 3 files changed, 113 insertions(+), 1 deletion(-) create mode 100644 0005-gui-wizard-gtk-Fix-segfault.patch create mode 100644 0006-event_config-Null-autofree-pointers-before-returning.patch diff --git a/0005-gui-wizard-gtk-Fix-segfault.patch b/0005-gui-wizard-gtk-Fix-segfault.patch new file mode 100644 index 0000000..29d65ae --- /dev/null +++ b/0005-gui-wizard-gtk-Fix-segfault.patch @@ -0,0 +1,66 @@ +From 1a22f30187163ce288b14e55a80539353a38b7be Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Tue, 29 Sep 2020 14:16:00 +0200 +Subject: [PATCH 1/2] gui-wizard-gtk: Fix segfault + +Since show_error_as_msgbox() is specified as the custom logging handler +(via setting libreport_g_custom_logger), it will get called if an error +occurs in libreport_save_user_settings(). However, at that point, +g_wnd_assistant has already been destroyed, which leads to an invalid +read in show_error_as_msgbox(). + +This change unsets the custom logging handler after the GUI is destroyed +and adds an assertion in show_error_as_msgbox() checking that +g_wnd_assistant is not a null pointer. + +Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1883337 +--- + src/gui-wizard-gtk/main.c | 6 ++++-- + src/gui-wizard-gtk/wizard.c | 2 ++ + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/src/gui-wizard-gtk/main.c b/src/gui-wizard-gtk/main.c +index e111948c..f094c5fb 100644 +--- a/src/gui-wizard-gtk/main.c ++++ b/src/gui-wizard-gtk/main.c +@@ -125,6 +125,7 @@ int main(int argc, char **argv) + /* List of events specified on the command line. */ + GList *user_event_list = NULL; + const char *prgname = "abrt"; ++ int ret = 0; + abrt_init(argv); + + /* I18n */ +@@ -217,13 +218,14 @@ int main(int argc, char **argv) + g_signal_connect(app, "startup", G_CALLBACK(startup_wizard), NULL); + + /* Enter main loop */ +- g_application_run(G_APPLICATION(app), argc, argv); ++ ret = g_application_run(G_APPLICATION(app), argc, argv); + g_object_unref(app); ++ libreport_g_custom_logger = NULL; + + if (opts & OPT_d) + delete_dump_dir_possibly_using_abrtd(g_dump_dir_name); + + libreport_save_user_settings(); + +- return 0; ++ return ret; + } +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 775b709f..c4a0b4c0 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -360,6 +360,8 @@ struct dump_dir *wizard_open_directory_for_writing(const char *dump_dir_name) + + void show_error_as_msgbox(const char *msg) + { ++ g_return_if_fail(g_wnd_assistant != NULL); ++ + GtkWidget *dialog = gtk_message_dialog_new(GTK_WINDOW(g_wnd_assistant), + GTK_DIALOG_DESTROY_WITH_PARENT, + GTK_MESSAGE_WARNING, +-- +2.26.2 + diff --git a/0006-event_config-Null-autofree-pointers-before-returning.patch b/0006-event_config-Null-autofree-pointers-before-returning.patch new file mode 100644 index 0000000..ed3a26f --- /dev/null +++ b/0006-event_config-Null-autofree-pointers-before-returning.patch @@ -0,0 +1,40 @@ +From 41b6477bdeaa82c647db2f1c2ba1132c77b365ed Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Tue, 29 Sep 2020 14:43:15 +0200 +Subject: [PATCH 2/2] event_config: Null autofree pointers before returning + +The pointers to strings in the function check_problem_rating_usability() +need to be nullified before the function returns as they are declared +for auto-cleanup. + +This change fixes a double-free condition in which the returned strings +were attempted to be freed again in the caller, +is_backtrace_rating_usable(). + +Bug was introduced in 05e9c9273. + +Resolves rhbz#1883410 +--- + src/lib/event_config.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/src/lib/event_config.c b/src/lib/event_config.c +index c8053b7c..01e91efe 100644 +--- a/src/lib/event_config.c ++++ b/src/lib/event_config.c +@@ -541,10 +541,10 @@ bool check_problem_rating_usability(const event_config_t *cfg, + + finish: + if (description) +- *description = tmp_desc; ++ *description = g_steal_pointer(&tmp_desc); + + if (detail) +- *detail = tmp_detail; ++ *detail = g_steal_pointer(&tmp_detail); + + return result; + } +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 62cf646..3c24abb 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 10%{?dist} +Release: 11%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -24,6 +24,8 @@ Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch +Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch +Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -664,6 +666,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Sep 29 2020 Matěj Grabovský - 2.14.0-11 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883337 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883410 + * Sun Sep 27 2020 Matěj Grabovský - 2.14.0-10 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882950 From 234a63a9955e1e9a14d8a0d43a5938a38f3d5749 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 9 Oct 2020 10:30:49 +0200 Subject: [PATCH 13/20] Add patch for #1882328 --- ...wizard-gtk-Don-t-autofree-URL-string.patch | 34 +++++++++++++++++++ libreport.spec | 6 +++- 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch diff --git a/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch b/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch new file mode 100644 index 0000000..b28d183 --- /dev/null +++ b/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch @@ -0,0 +1,34 @@ +From 9b6d40905c21b476c58e9f9a908ddb32a0a56a18 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Tue, 29 Sep 2020 19:14:05 +0200 +Subject: [PATCH] gui-wizard-gtk: Don't autofree URL string + +g_object_set_data() does not (and cannot) copy the data passed to it, so +once url is freed, a subsequent access to the 'url' tag leads to an +invalid read and segfault. + +Bug was introduced in df386b097. + +Resolves rhbz#1882328 +--- + src/gui-wizard-gtk/wizard.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 0af19587..ba1998df 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -462,8 +462,8 @@ static void append_to_textview(GtkTextView *tv, const char *str) + GtkTextTag *tag; + tag = gtk_text_buffer_create_tag(tb, NULL, "foreground", "blue", + "underline", PANGO_UNDERLINE_SINGLE, NULL); +- g_autofree char *url = g_strndup(t->start, t->len); +- g_object_set_data(G_OBJECT(tag), "url", url); ++ char *url = g_strndup(t->start, t->len); ++ g_object_set_data_full(G_OBJECT(tag), "url", url, g_free); + + gtk_text_buffer_insert_with_tags(tb, &text_iter, url, -1, tag, NULL); + +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 3c24abb..8610556 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 11%{?dist} +Release: 12%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -26,6 +26,7 @@ Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch +Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -666,6 +667,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Oct 09 2020 Matěj Grabovský - 2.14.0-12 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882328 + * Tue Sep 29 2020 Matěj Grabovský - 2.14.0-11 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883337 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883410 From 4ea809a817f12d082608610c228ae4f29b9c1c70 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Tue, 3 Nov 2020 16:36:34 +0100 Subject: [PATCH 14/20] Add patch for #1893595 --- 0008-rhbz-Fix-a-double-free-condition.patch | 48 +++++++++++++++++++++ libreport.spec | 6 ++- 2 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 0008-rhbz-Fix-a-double-free-condition.patch diff --git a/0008-rhbz-Fix-a-double-free-condition.patch b/0008-rhbz-Fix-a-double-free-condition.patch new file mode 100644 index 0000000..4180663 --- /dev/null +++ b/0008-rhbz-Fix-a-double-free-condition.patch @@ -0,0 +1,48 @@ +From 9cdf0f9123ee39c7cb32a276371b2fd95f0df5ac Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Mon, 2 Nov 2020 11:45:23 +0100 +Subject: [PATCH] rhbz: Fix a double-free condition + +The `cc` string must not be freed after the variable goes out of scope +since it's appended to `cc_list`. (`g_list_append()` does not copy its +input.) We only need to free the last string in the loop, which is an +empty string. + +The bug was introduced in 7aba6e53. + +Resolves rhbz#1893595 +--- + src/plugins/rhbz.c | 8 +++++--- + 1 file changed, 5 insertions(+), 3 deletions(-) + +diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c +index 8a2ded79..e0d7a091 100644 +--- a/src/plugins/rhbz.c ++++ b/src/plugins/rhbz.c +@@ -406,18 +406,20 @@ GList *rhbz_bug_cc(xmlrpc_value* result_xml) + if (!item) + continue; + +- g_autofree const char* cc = NULL; +- xmlrpc_read_string(&env, item, &cc); ++ char *cc = NULL; ++ xmlrpc_read_string(&env, item, (const char **)&cc); + xmlrpc_DECREF(item); + if (env.fault_occurred) + abrt_xmlrpc_die(&env); + + if (*cc != '\0') + { +- cc_list = g_list_append(cc_list, (char*)cc); ++ cc_list = g_list_append(cc_list, cc); + log_debug("member on cc is %s", cc); + continue; + } ++ ++ free(cc); + } + xmlrpc_DECREF(cc_member); + return cc_list; +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 8610556..788eec7 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 12%{?dist} +Release: 13%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -27,6 +27,7 @@ Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch +Patch7: 0008-rhbz-Fix-a-double-free-condition.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -667,6 +668,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Nov 03 2020 Matěj Grabovský - 2.14.0-13 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1893595 + * Fri Oct 09 2020 Matěj Grabovský - 2.14.0-12 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882328 From 85ad98dcf61b1b3a48aeb22502c7179028acd2a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Dec 2020 12:29:09 +0100 Subject: [PATCH 15/20] Port upstream API patch Port an addition in libreport Python API from upstream in order to hotfix interoperability with abrt. The commit in question: https://github.com/abrt/libreport/commit/cbb6b43038f0d88b28197ba905ba9324c0602945 Resolves rhbz#1906405 --- ...d-getter-for-package-count-to-downlo.patch | 28 +++++++++++++++++++ libreport.spec | 6 +++- 2 files changed, 33 insertions(+), 1 deletion(-) create mode 100644 0009-client-python-Add-getter-for-package-count-to-downlo.patch diff --git a/0009-client-python-Add-getter-for-package-count-to-downlo.patch b/0009-client-python-Add-getter-for-package-count-to-downlo.patch new file mode 100644 index 0000000..6fa6ee4 --- /dev/null +++ b/0009-client-python-Add-getter-for-package-count-to-downlo.patch @@ -0,0 +1,28 @@ +From cbb6b43038f0d88b28197ba905ba9324c0602945 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Thu, 3 Sep 2020 15:05:23 +0200 +Subject: [PATCH] client-python: Add getter for package count to downloader + +Add a new method get_package_count() to the DebugInfoDownload class +which returns the number of packages that will be downloaded. +--- + src/client-python/reportclient/debuginfo.py | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/src/client-python/reportclient/debuginfo.py b/src/client-python/reportclient/debuginfo.py +index cb318e8a..eeb2be30 100644 +--- a/src/client-python/reportclient/debuginfo.py ++++ b/src/client-python/reportclient/debuginfo.py +@@ -242,6 +242,9 @@ class DebugInfoDownload(object): + def get_install_size(self): + return self.installed_size + ++ def get_package_count(self): ++ return len(self.package_files_dict) ++ + def mute_stdout(self): + """ + Links sys.stdout with /dev/null and saves the old stdout +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 788eec7..f95cf38 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 13%{?dist} +Release: 14%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -28,6 +28,7 @@ Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch Patch7: 0008-rhbz-Fix-a-double-free-condition.patch +Patch8: 0009-client-python-Add-getter-for-package-count-to-downlo.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -668,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Dec 11 2020 Matěj Grabovský - 2.14.0-14 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1906405 + * Tue Nov 03 2020 Matěj Grabovský - 2.14.0-13 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1893595 From 34f8340238d9690ce1085782e9aa82ef7de0d144 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Dec 2020 15:30:46 +0100 Subject: [PATCH 16/20] Fix date in changelog --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index f95cf38..1defe12 100644 --- a/libreport.spec +++ b/libreport.spec @@ -669,7 +669,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog -* Tue Dec 11 2020 Matěj Grabovský - 2.14.0-14 +* Fri Dec 11 2020 Matěj Grabovský - 2.14.0-14 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1906405 * Tue Nov 03 2020 Matěj Grabovský - 2.14.0-13 From 30099dc2b3b283b8493d12ec8e7503063ac0b780 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Dec 2020 15:44:16 +0100 Subject: [PATCH 17/20] Bump release for rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 1defe12..fbfcd88 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 14%{?dist} +Release: 15%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Dec 11 2020 Matěj Grabovský - 2.14.0-15 +- Bump release for rebuild + * Fri Dec 11 2020 Matěj Grabovský - 2.14.0-14 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1906405 From ad31fccc9781d9173cb61b386068bb1bf35d7ab3 Mon Sep 17 00:00:00 2001 From: Packit Service Date: Tue, 4 May 2021 18:00:24 +0000 Subject: [PATCH 18/20] [packit] 2.15.1 upstream release Upstream tag: 2.15.1 Upstream commit: 5e65d4e4 Signed-off-by: Packit Service --- .gitignore | 1 + .packit.yml | 17 ++++++++++++ README.packit | 3 +++ libreport.spec | 72 +++++++++++++++++++++++++++----------------------- sources | 2 +- 5 files changed, 61 insertions(+), 34 deletions(-) create mode 100644 .packit.yml create mode 100644 README.packit diff --git a/.gitignore b/.gitignore index 23c2ea8..0af2d9c 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,4 @@ /libreport-2.13.0.tar.gz /libreport-2.13.1.tar.gz /libreport-2.14.0.tar.gz +/libreport-2.15.1.tar.gz diff --git a/.packit.yml b/.packit.yml new file mode 100644 index 0000000..b82be50 --- /dev/null +++ b/.packit.yml @@ -0,0 +1,17 @@ +specfile_path: libreport.spec +synced_files: + - .packit.yml + - libreport.spec +upstream_package_name: libreport +upstream_project_url: https://github.com/abrt/libreport +downstream_package_name: libreport +jobs: +- job: propose_downstream + trigger: release + metadata: + dist_git_branch: fedora-all +- job: copr_build + trigger: pull_request + metadata: + targets: + - fedora-all diff --git a/README.packit b/README.packit new file mode 100644 index 0000000..056cacc --- /dev/null +++ b/README.packit @@ -0,0 +1,3 @@ +This repository is maintained by packit. +https://packit.dev/ +The file was generated using packit 0.29.0. diff --git a/libreport.spec b/libreport.spec index fbfcd88..5ceb8a3 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,22 +14,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.14.0 -Release: 15%{?dist} +Version: 2.15.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - -Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch -Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch -Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch -Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch -Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch -Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch -Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch -Patch7: 0008-rhbz-Fix-a-double-free-condition.patch -Patch8: 0009-client-python-Add-getter-for-package-count-to-downlo.patch - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -37,9 +26,9 @@ BuildRequires: desktop-file-utils BuildRequires: python3-devel BuildRequires: gettext BuildRequires: libxml2-devel -BuildRequires: libtar-devel BuildRequires: intltool BuildRequires: libtool +BuildRequires: make BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto @@ -191,7 +180,7 @@ The simple reporter plugin which writes a report to the systemd journal. %package plugin-mailx Summary: %{name}'s mailx reporter plugin Requires: %{name} = %{version}-%{release} -Requires: mailx +Requires: /usr/bin/mailx %description plugin-mailx The simple reporter plugin which sends a report via mailx to a specified @@ -229,9 +218,6 @@ Summary: %{name}'s micro report plugin BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} -%if 0%{?rhel} -Requires: python3-subscription-manager-rhsm -%endif %description plugin-ureport Uploads micro-report to abrt server @@ -244,7 +230,7 @@ Requires: libreport-web = %{version}-%{release} %description plugin-reportuploader Plugin to report bugs into anonymous FTP site associated with ticketing system. -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?eln} %package fedora Summary: Default configuration for reporting bugs via Fedora infrastructure Requires: %{name} = %{version}-%{release} @@ -255,7 +241,7 @@ used to easily configure the reporting process for Fedora systems. Just install this package and you're done. %endif -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %package rhel-bugzilla Summary: Default configuration for reporting bugs to Red Hat Bugzilla Requires: %{name} = %{version}-%{release} @@ -283,7 +269,7 @@ package and you're done. Summary: Default configuration for reporting anaconda bugs Requires: %{name} = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -%if ! 0%{?rhel} +%if ! 0%{?rhel} || 0%{?eln} Requires: libreport-plugin-bugzilla = %{version}-%{release} %endif @@ -293,10 +279,10 @@ data over ftp/scp... %endif %prep -%autosetup -S git +%autosetup %build -autoconf +./autogen.sh %configure \ %if %{without bugzilla} @@ -311,7 +297,7 @@ autoconf %make_install \ %if %{with python3} PYTHON=%{__python3} \ -%endif # with python3 +%endif mandir=%{_mandir} %find_lang %{name} @@ -336,7 +322,7 @@ mkdir -p %{buildroot}/%{_datadir}/%{name}/workflows/ rm -f %{buildroot}/%{_infodir}/dir # Remove unwanted Fedora specific workflow configuration files -%if 0%{!?fedora:1} +%if ! 0%{?fedora} && ! 0%{?eln} rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_FedoraCCpp.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_FedoraKerneloops.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_FedoraPython.xml @@ -352,7 +338,7 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaFedora.xml %endif # Remove unwanted RHEL specific workflow configuration files -%if 0%{!?rhel:1} +%if ! 0%{?rhel} || 0%{?eln} rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_uReport.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaRHELBugzilla.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaCCpp.xml @@ -412,12 +398,14 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/%{name}/report_event.conf %config(noreplace) %{_sysconfdir}/%{name}/forbidden_words.conf %config(noreplace) %{_sysconfdir}/%{name}/ignored_words.conf +%config(noreplace) %{_sysconfdir}/%{name}/ignored_elements.conf %{_datadir}/%{name}/conf.d/libreport.conf %{_libdir}/libreport.so.* %{_mandir}/man5/libreport.conf.5* %{_mandir}/man5/report_event.conf.5* %{_mandir}/man5/forbidden_words.conf.5* %{_mandir}/man5/ignored_words.conf.5* +%{_mandir}/man5/ignored_elements.conf.5* # filesystem package owns /usr/share/augeas/lenses directory %{_datadir}/augeas/lenses/libreport.aug @@ -535,7 +523,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man1/reporter-ureport.1.gz %{_mandir}/man5/ureport.conf.5.gz %{_datadir}/%{name}/events/report_uReport.xml -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_datadir}/%{name}/workflows/workflow_uReport.xml %{_mandir}/man5/report_uReport.conf.5.* @@ -617,7 +605,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/events/report_Uploader.conf %{_mandir}/man5/report_Uploader.conf.5.* -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?eln} %files fedora %{_datadir}/%{name}/workflows/workflow_FedoraCCpp.xml %{_datadir}/%{name}/workflows/workflow_FedoraKerneloops.xml @@ -632,7 +620,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/report_fedora.conf.5.* %endif -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml %{_datadir}/%{name}/workflows/workflow_RHELBugzillaKerneloops.xml @@ -651,12 +639,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %if %{with bugzilla} %files anaconda -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?eln} %{_datadir}/%{name}/workflows/workflow_AnacondaFedora.xml %endif -%if 0%{?rhel} -%{_datadir}/%{name}/workflows/workflow_AnacondaRHEL.xml -%endif %{_datadir}/%{name}/workflows/workflow_AnacondaUpload.xml %config(noreplace) %{_sysconfdir}/libreport/workflows.d/anaconda_event.conf %config(noreplace) %{_sysconfdir}/libreport/events.d/bugzilla_anaconda_event.conf @@ -669,6 +654,27 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue May 04 2021 Packit Service - 2.15.1-1 +- Release version 2.15.1-1 (Michal Fabik) +- ureport: Strange usage of tmp variable (Michal Židek) +- steal_directory: Silence a warning (Michal Židek) +- dump_dir: Use g_free and re-init to NULL (Michal Židek) +- dump_dir: Use g_free instead of free (Michal Židek) +- dirsize: No need to check for NULL (Michal Židek) +- dirsize: Bad checks for NULL (Michal Židek) +- gui-wizard-gtk: Possible double free (Michal Židek) +- gui-wizard-gtk: Check if EXCLUDE_FROM_REPORT is set (Michal Židek) +- gui-wizard-gtk: Improve docs and add missing free (Michal Židek) +- cli: Address of local auto-variable assigned to a function parameter (Michal Židek) +- gtk-helpers: Add missing g_strfreev() (Michal Židek) +- cli: Add missing g_free call (Michal Židek) +- gitignore: Drop misleading comment (Michal Fabik) +- spec: Sync upstream with distgit (Michal Fabik) +- changelog: Add missing link to changes in 2.15.0 (Matěj Grabovský) +- spec: Make plugin-mailx depend on /usr/bin/mailx (Matěj Grabovský) +- Add support for excluding whole elements from search for sensitive words (Michal Srb) +- ignored_words: add more "key" variations (Michal Srb) + * Fri Dec 11 2020 Matěj Grabovský - 2.14.0-15 - Bump release for rebuild diff --git a/sources b/sources index c9ad10a..6f8a882 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.14.0.tar.gz) = 6bc428a2d91b22f2df1abc9326c131e91e5e7be78ca64ad6533ff8246fa02df9a975360686811d29fd66210206a4e4ee5dc9faf2c9b23eccab7ca0ec07c3d43c +SHA512 (libreport-2.15.1.tar.gz) = 70f947690173a0afa57981c9755a18bdd0ad44c888c00713de74624296b81ff25203d5dda5d5c57eac85da4a1631585184b77715c7adf6688b469e32d4113cf4 From d8c89a95cea6a187e55761fc6cee99cd7b347bfc Mon Sep 17 00:00:00 2001 From: Packit Service Date: Tue, 1 Jun 2021 11:59:41 +0000 Subject: [PATCH 19/20] [packit] 2.15.2 upstream release Upstream tag: 2.15.2 Upstream commit: 3474c03d Signed-off-by: Packit Service --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 11 ++++++++--- sources | 2 +- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 0af2d9c..88f39e4 100644 --- a/.gitignore +++ b/.gitignore @@ -14,3 +14,4 @@ /libreport-2.13.1.tar.gz /libreport-2.14.0.tar.gz /libreport-2.15.1.tar.gz +/libreport-2.15.2.tar.gz diff --git a/README.packit b/README.packit index 056cacc..8ede8cd 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.29.0. +The file was generated using packit 0.31.0. diff --git a/libreport.spec b/libreport.spec index 5ceb8a3..7608d7c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.15.1 +Version: 2.15.2 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -36,7 +36,6 @@ BuildRequires: newt-devel BuildRequires: libproxy-devel BuildRequires: satyr-devel >= 0.24 BuildRequires: glib2-devel >= %{glib_ver} -BuildRequires: nettle-devel BuildRequires: git-core %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 @@ -56,7 +55,6 @@ Requires: libreport-filesystem = %{version}-%{release} Requires: satyr%{?_isa} >= 0.24 Requires: glib2%{?_isa} >= %{glib_ver} Requires: libarchive%{?_isa} -Requires: nettle%{?_isa} # Required for the temporary modularity hack, see below %if 0%{?_module_build} @@ -654,6 +652,13 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Jun 01 2021 Packit Service - 2.15.2-1 +- Release version 2.15.2-1 (Michal Fabik) +- binhex: Remove unused API (Matěj Grabovský) +- lib: Use GLib for computing SHA-1 digests (Matěj Grabovský) +- run_event: Improve memory management (Matěj Grabovský) +- gtk: Fix segfault (Matěj Grabovský) + * Tue May 04 2021 Packit Service - 2.15.1-1 - Release version 2.15.1-1 (Michal Fabik) - ureport: Strange usage of tmp variable (Michal Židek) diff --git a/sources b/sources index 6f8a882..c9ba4ce 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.15.1.tar.gz) = 70f947690173a0afa57981c9755a18bdd0ad44c888c00713de74624296b81ff25203d5dda5d5c57eac85da4a1631585184b77715c7adf6688b469e32d4113cf4 +SHA512 (libreport-2.15.2.tar.gz) = c98003325fa70d674177c9f602a7f121815a9675701ee780ad8908ed69862f2c69be65c7483fd3f017ba299dda51ba304f0908c771c9d97cb5bba057e3a9c5dc From 1fc3c42ceeb470b8957151ed81572dcc5360a7d2 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Fri, 4 Jun 2021 14:01:59 +0200 Subject: [PATCH 20/20] Bump release to rebuild in new side tag Signed-off-by: Michal Fabik --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 7608d7c..c9a2fef 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz