From 8d46b6047d9649610dcd0ef0ade1f723dd3e03a0 Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Mon, 8 Oct 2018 14:02:19 +0200 Subject: [PATCH 01/13] New upstream release 2.9.6 Signed-off-by: Martin Kutlak --- .gitignore | 1 + ...t-use-python3-to-get-consumerCertDir.patch | 31 ------------------- libreport.spec | 24 ++++++++++++-- sources | 2 +- 4 files changed, 23 insertions(+), 35 deletions(-) delete mode 100644 0001-ureport-use-python3-to-get-consumerCertDir.patch diff --git a/.gitignore b/.gitignore index 0465349..5f80a43 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ /libreport-2.9.3.tar.gz /libreport-2.9.4.tar.gz /libreport-2.9.5.tar.gz +/libreport-2.9.6.tar.gz diff --git a/0001-ureport-use-python3-to-get-consumerCertDir.patch b/0001-ureport-use-python3-to-get-consumerCertDir.patch deleted file mode 100644 index e6fe7a6..0000000 --- a/0001-ureport-use-python3-to-get-consumerCertDir.patch +++ /dev/null @@ -1,31 +0,0 @@ -From 8c00a86dddaf240d4a836a5e278190bcc51b0b66 Mon Sep 17 00:00:00 2001 -From: Matej Habrnal -Date: Mon, 18 Jun 2018 14:51:23 +0200 -Subject: [PATCH] ureport: use python3 to get consumerCertDir - -Related to #1592073 - -Signed-off-by: Matej Habrnal ---- - src/lib/ureport.c | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/src/lib/ureport.c b/src/lib/ureport.c -index c32c948a..d2045f0f 100644 ---- a/src/lib/ureport.c -+++ b/src/lib/ureport.c -@@ -81,9 +81,10 @@ rhsm_config_get_consumer_cert_dir(void) - return xstrdup(result); - - result = run_in_shell_and_save_output(0, -- "python -c \"from rhsm.config import initConfig; print(initConfig().get('rhsm', 'consumerCertDir'))\"", -+ "python3 -c \"from rhsm.config import initConfig; print(initConfig().get('rhsm', 'consumerCertDir'))\"", - NULL, NULL); - -+ - /* run_in_shell_and_save_output always returns non-NULL */ - if (result[0] != '/') - goto error; --- -2.17.0 - diff --git a/libreport.spec b/libreport.spec index 65b387d..7e420b4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -28,13 +28,12 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.5 -Release: 4%{?dist} +Version: 2.9.6 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0001: 0001-ureport-use-python3-to-get-consumerCertDir.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -91,6 +90,7 @@ to different bug targets like Bugzilla, ftp, trac, etc... %package filesystem Summary: Filesystem layout for libreport +BuildArch: noarch %description filesystem Filesystem layout for libreport @@ -258,7 +258,12 @@ BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} %if 0%{?rhel} +%if %{with python2} Requires: python-rhsm +%endif # with python2 +%if %{with python3} +Requires: python3-subscription-manager-rhsm +%endif # with python3 %endif %description plugin-ureport @@ -816,6 +821,19 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Oct 8 2018 Martin Kutlak 2.9.6-1 +- Fix majority of bugs found by Coverity Scan. +- Remove option to screencast problems +- tests: Adjust format of truncated backtrace for python and core +- gui: Replace deprecated g_type_class_add_private +- potfiles: fix issue in POTFILES.in +- lib: fix a SEGV in list_possible_events() +- ureport: use python3 to get consumerCertDir +- r-mailx: Add comment explaining expected values in config +- reporter-mailx: Remove double quotes from config +- spec: Make libreport-filesystem subpackage noarch +- spec: drop dependency on python-rhsm + * Fri Jul 13 2018 Fedora Release Engineering - 2.9.5-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild diff --git a/sources b/sources index 182b3ff..c7b0301 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.5.tar.gz) = 160dcbd9dd1653dde4f2a0dd6ab8c07b7e8ae0bc906b5c586df4e9c3b99a392959f6cac9218632587eb077e6d294a43fb2f221f0845e927728970db2fe323a54 +SHA512 (libreport-2.9.6.tar.gz) = b1b8c1fc706f7b78cb5b1c8cfac783771fafd840fad4129c88ab3284957b595152315d3b6ed5c3aec9bb50b6c8f023c59246091338a6f199704fde3bf17384ef From 130c5d858046acde9c721404fb8b6d27777feb4f Mon Sep 17 00:00:00 2001 From: Matej Marusak Date: Fri, 7 Dec 2018 09:53:32 +0100 Subject: [PATCH 02/13] New upstream release 2.9.7 Signed-off-by: Matej Marusak --- .gitignore | 1 + libreport.spec | 21 ++++++++++++++++++++- sources | 2 +- 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 5f80a43..ffae115 100644 --- a/.gitignore +++ b/.gitignore @@ -2,3 +2,4 @@ /libreport-2.9.4.tar.gz /libreport-2.9.5.tar.gz /libreport-2.9.6.tar.gz +/libreport-2.9.7.tar.gz diff --git a/libreport.spec b/libreport.spec index 7e420b4..782d6fe 100644 --- a/libreport.spec +++ b/libreport.spec @@ -28,7 +28,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.6 +Version: 2.9.7 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -821,6 +821,25 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Dec 07 2018 Matej Marusak 2.9.7-1 +- reportclient: Search for required packages recursively +- event_config: Modify unusable backtrace message +- reportclient: Find and download required debuginfo packages +- lib: Explicitly do not use DST +- autogen: List make in sysdeps command +- lib: Seek beginning of mountinfo file +- report-client: Find debuginfos in own method +- lib: Add a null guard +- gui-wizard-gtk: Require GTK+ 3.10 +- gui-wizard-gtk: Don’t set GtkButton:xalign +- gui-wizard-gtk: Replace use of GtkTable +- gui-wizard-gtk: Show warnings inline on progress page +- gui-wizard-gtk: Remove unused size group +- gui-wizard-gtk: Replace Gtk{H,V}Box with GtkBox +- gui-wizard-gtk: Remove unneeded windows +- gtk-helpers: config_dialog: Hide tree view header +- augeas: Use generic augeas modules + * Mon Oct 8 2018 Martin Kutlak 2.9.6-1 - Fix majority of bugs found by Coverity Scan. - Remove option to screencast problems diff --git a/sources b/sources index c7b0301..9749b3c 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.6.tar.gz) = b1b8c1fc706f7b78cb5b1c8cfac783771fafd840fad4129c88ab3284957b595152315d3b6ed5c3aec9bb50b6c8f023c59246091338a6f199704fde3bf17384ef +SHA512 (libreport-2.9.7.tar.gz) = 8e92470ada204236ae4540145ba7f750814c74b0f5858d25ec797f06d4daeb9fc40996b609a33e154072a45624513d7dbd4027587708ffbfb2f40b0687b16ac3 From 16e367ac40993dfdcf0196f4e1fdb775bd3782c8 Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Mon, 7 Jan 2019 09:50:20 +0100 Subject: [PATCH 03/13] Replace nomail flag with minor_update Send Bugzilla updates as minor_update. Related: rhbz#1660157 Signed-off-by: Martin Kutlak --- ...eplace-nomail-flag-with-minor_update.patch | 232 ++++++++++++++++++ libreport.spec | 8 +- 2 files changed, 239 insertions(+), 1 deletion(-) create mode 100644 0001-rhbz-Replace-nomail-flag-with-minor_update.patch diff --git a/0001-rhbz-Replace-nomail-flag-with-minor_update.patch b/0001-rhbz-Replace-nomail-flag-with-minor_update.patch new file mode 100644 index 0000000..6ab8dce --- /dev/null +++ b/0001-rhbz-Replace-nomail-flag-with-minor_update.patch @@ -0,0 +1,232 @@ +From 569bf0e3fed698e93b8e098bf6a0bb2f773aed6a Mon Sep 17 00:00:00 2001 +From: Martin Kutlak +Date: Fri, 4 Jan 2019 12:26:28 +0100 +Subject: [PATCH] rhbz: Replace nomail flag with minor_update + +In Bugzilla v5.0 nomail flag is replaced with minor_update. [1] +Because we still use the old nomail flag emails are being sent for every added attachment/comment. + +Related: rhbz#1660157 +Closes: abrt/abrt#1346 + +See also: +- https://partner-bugzilla.redhat.com/docs/en/html/integrating/api/Bugzilla/WebService/Bug.html?highlight=minor_update + +[1] https://bugzilla.redhat.com/show_bug.cgi?id=1655829 + +Signed-off-by: Martin Kutlak +--- + src/plugins/reporter-bugzilla.c | 12 +++++----- + src/plugins/rhbz.c | 41 ++++++++++++++++++--------------- + src/plugins/rhbz.h | 4 ++-- + 3 files changed, 30 insertions(+), 27 deletions(-) + +diff --git a/src/plugins/reporter-bugzilla.c b/src/plugins/reporter-bugzilla.c +index d4d03f8e..c12e00d1 100644 +--- a/src/plugins/reporter-bugzilla.c ++++ b/src/plugins/reporter-bugzilla.c +@@ -35,7 +35,7 @@ int attach_text_item(struct abrt_xmlrpc *ax, const char *bug_id, + log_debug("attaching '%s' as text", item_name); + int r = rhbz_attach_blob(ax, bug_id, + item_name, item->content, strlen(item->content), +- RHBZ_NOMAIL_NOTIFY ++ RHBZ_MINOR_UPDATE + ); + return (r == 0); + } +@@ -63,7 +63,7 @@ int attach_file_item(struct abrt_xmlrpc *ax, const char *bug_id, + return 0; + } + log_debug("attaching '%s' as file", item_name); +- int flag = RHBZ_NOMAIL_NOTIFY; ++ int flag = RHBZ_MINOR_UPDATE; + if (!(item->flags & CD_FLAG_BIGTXT)) + flag |= RHBZ_BINARY_ATTACHMENT; + int r = rhbz_attach_fd(ax, bug_id, item_name, fd, flag); +@@ -793,7 +793,7 @@ int main(int argc, char **argv) + if (reported_to && reported_to->url) + { + log_warning(_("Adding External URL to bug %i"), new_id); +- rhbz_set_url(client, new_id, reported_to->url, RHBZ_NOMAIL_NOTIFY); ++ rhbz_set_url(client, new_id, reported_to->url, RHBZ_MINOR_UPDATE); + free_report_result(reported_to); + } + } +@@ -821,7 +821,7 @@ int main(int argc, char **argv) + if (existing_id >= 0) + { + log_warning(_("Closing bug %i as duplicate of bug %i"), new_id, existing_id); +- rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_NOMAIL_NOTIFY); ++ rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_MINOR_UPDATE); + } + + goto log_out; +@@ -876,7 +876,7 @@ int main(int argc, char **argv) + && !g_list_find_custom(bz->bi_cc_list, rhbz.b_login, (GCompareFunc)g_strcmp0) + ) { + log_warning(_("Adding %s to CC list"), rhbz.b_login); +- rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_NOMAIL_NOTIFY); ++ rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_MINOR_UPDATE); + } + + /* Add comment and bt */ +@@ -911,7 +911,7 @@ int main(int argc, char **argv) + sprintf(bug_id_str, "%i", bz->bi_id); + log_warning(_("Attaching better backtrace")); + rhbz_attach_blob(client, bug_id_str, FILENAME_BACKTRACE, bt, strlen(bt), +- RHBZ_NOMAIL_NOTIFY); ++ RHBZ_MINOR_UPDATE); + } + } + else +diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c +index 680527d7..cb6505ea 100644 +--- a/src/plugins/rhbz.c ++++ b/src/plugins/rhbz.c +@@ -605,7 +605,7 @@ int rhbz_new_bug(struct abrt_xmlrpc *ax, + return new_bug_id; + } + +-/* suppress mail notify by {s:i} (nomail:1) (driven by flag) */ ++/* suppress mail notify by {s:i} (minor_update:1) (driven by flag) */ + int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, + const char *filename, const char *data, int data_len, int flags) + { +@@ -620,7 +620,7 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, + + char *fn = xasprintf("File: %s", filename); + xmlrpc_value* result; +- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ int minor_update = !!IS_MINOR_UPDATE(flags); + + /* http://www.bugzilla.org/docs/4.2/en/html/api/Bugzilla/WebService/Bug.html#add_attachment + * +@@ -640,10 +640,11 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, + */ + "data", data, (size_t)data_len, + +- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 +- * and version 4.4.rc1.b02 ++ /* If set to true, this is considered a minor update and no mail is sent to users who do not want ++ * minor update emails. If current user is not in the minor_update_group, this parameter is simply ++ * ignored. + */ +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + + free(fn); +@@ -737,25 +738,25 @@ struct bug_info *rhbz_find_origin_bug_closed_duplicate(struct abrt_xmlrpc *ax, + return bi_tmp; + } + +-/* suppress mail notify by {s:i} (nomail:1) */ ++/* suppress mail notify by {s:i} (minor_update:1) */ + void rhbz_mail_to_cc(struct abrt_xmlrpc *ax, int bug_id, const char *mail, int flags) + { + func_entry(); + + xmlrpc_value *result; +- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ int minor_update = !!IS_MINOR_UPDATE(flags); + #if 0 /* Obsolete API */ + result = abrt_xmlrpc_call(ax, "Bug.update", "({s:i,s:{s:(s),s:i}})", + "ids", bug_id, + "updates", "add_cc", mail, +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + #endif + /* Bugzilla 4.0+ uses this API: */ + result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:{s:(s),s:i}}", + "ids", bug_id, + "cc", "add", mail, +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + if (result) + xmlrpc_DECREF(result); +@@ -786,12 +787,12 @@ void rhbz_add_comment(struct abrt_xmlrpc *ax, int bug_id, const char *comment, + func_entry(); + + int private = !!IS_PRIVATE(flags); +- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ int minor_update = !!IS_MINOR_UPDATE(flags); + + xmlrpc_value *result; + result = abrt_xmlrpc_call(ax, "Bug.add_comment", "{s:i,s:s,s:b,s:i}", + "id", bug_id, "comment", comment, +- "private", private, "nomail", nomail_notify); ++ "private", private, "minor_update", minor_update); + + if (result) + xmlrpc_DECREF(result); +@@ -801,15 +802,16 @@ void rhbz_set_url(struct abrt_xmlrpc *ax, int bug_id, const char *url, int flags + { + func_entry(); + +- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ const int minor_update = !!IS_MINOR_UPDATE(flags); + xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:i}", + "ids", bug_id, + "url", url, + +- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 +- * and version 4.4.rc1.b02 ++ /* If set to true, this is considered a minor update and no mail is sent to users who do not want ++ * minor update emails. If current user is not in the minor_update_group, this parameter is simply ++ * ignored. + */ +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + + if (result) +@@ -822,17 +824,18 @@ void rhbz_close_as_duplicate(struct abrt_xmlrpc *ax, int bug_id, + { + func_entry(); + +- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ const int minor_update = !!IS_MINOR_UPDATE(flags); + xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:s,s:i,s:i}", + "ids", bug_id, + "status", "CLOSED", + "resolution", "DUPLICATE", + "dupe_of", duplicate_bug, + +- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 +- * and version 4.4.rc1.b02 ++ /* If set to true, this is considered a minor update and no mail is sent to users who do not want ++ * minor update emails. If current user is not in the minor_update_group, this parameter is simply ++ * ignored. + */ +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + + if (result) +diff --git a/src/plugins/rhbz.h b/src/plugins/rhbz.h +index 86632a35..3990eda0 100644 +--- a/src/plugins/rhbz.h ++++ b/src/plugins/rhbz.h +@@ -36,7 +36,7 @@ enum { + RHBZ_MANDATORY_MEMB = (1 << 0), + RHBZ_READ_STR = (1 << 1), + RHBZ_READ_INT = (1 << 2), +- RHBZ_NOMAIL_NOTIFY = (1 << 3), ++ RHBZ_MINOR_UPDATE = (1 << 3), + RHBZ_PRIVATE = (1 << 4), + RHBZ_BINARY_ATTACHMENT = (1 << 5), + }; +@@ -44,7 +44,7 @@ enum { + #define IS_MANDATORY(flags) ((flags) & RHBZ_MANDATORY_MEMB) + #define IS_READ_STR(flags) ((flags) & RHBZ_READ_STR) + #define IS_READ_INT(flags) ((flags) & RHBZ_READ_INT) +-#define IS_NOMAIL_NOTIFY(flags) ((flags) & RHBZ_NOMAIL_NOTIFY) ++#define IS_MINOR_UPDATE(flags) ((flags) & RHBZ_MINOR_UPDATE) + #define IS_PRIVATE(flags) ((flags) & RHBZ_PRIVATE) + + struct bug_info { +-- +2.17.2 + diff --git a/libreport.spec b/libreport.spec index 782d6fe..503714f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,12 +29,15 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.7 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0001: 0001-rhbz-Replace-nomail-flag-with-minor_update.patch + + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -821,6 +824,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jan 07 2019 Martin Kutlak 2.9.7-2 +- rhbz: Replace nomail flag with minor_update + * Fri Dec 07 2018 Matej Marusak 2.9.7-1 - reportclient: Search for required packages recursively - event_config: Modify unusable backtrace message From 18cb5b955c2563a22472153b631c1f4f96ab8a37 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Mon, 4 Feb 2019 13:24:58 +0100 Subject: [PATCH 04/13] Update to 2.10.0 Signed-off-by: Ernestas Kulik --- .gitignore | 1 + ...eplace-nomail-flag-with-minor_update.patch | 232 ------------------ autogen.sh | 70 ------ libreport.spec | 21 +- sources | 2 +- 5 files changed, 15 insertions(+), 311 deletions(-) delete mode 100644 0001-rhbz-Replace-nomail-flag-with-minor_update.patch delete mode 100755 autogen.sh diff --git a/.gitignore b/.gitignore index ffae115..50a2b87 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ /libreport-2.9.5.tar.gz /libreport-2.9.6.tar.gz /libreport-2.9.7.tar.gz +/libreport-2.10.0.tar.gz diff --git a/0001-rhbz-Replace-nomail-flag-with-minor_update.patch b/0001-rhbz-Replace-nomail-flag-with-minor_update.patch deleted file mode 100644 index 6ab8dce..0000000 --- a/0001-rhbz-Replace-nomail-flag-with-minor_update.patch +++ /dev/null @@ -1,232 +0,0 @@ -From 569bf0e3fed698e93b8e098bf6a0bb2f773aed6a Mon Sep 17 00:00:00 2001 -From: Martin Kutlak -Date: Fri, 4 Jan 2019 12:26:28 +0100 -Subject: [PATCH] rhbz: Replace nomail flag with minor_update - -In Bugzilla v5.0 nomail flag is replaced with minor_update. [1] -Because we still use the old nomail flag emails are being sent for every added attachment/comment. - -Related: rhbz#1660157 -Closes: abrt/abrt#1346 - -See also: -- https://partner-bugzilla.redhat.com/docs/en/html/integrating/api/Bugzilla/WebService/Bug.html?highlight=minor_update - -[1] https://bugzilla.redhat.com/show_bug.cgi?id=1655829 - -Signed-off-by: Martin Kutlak ---- - src/plugins/reporter-bugzilla.c | 12 +++++----- - src/plugins/rhbz.c | 41 ++++++++++++++++++--------------- - src/plugins/rhbz.h | 4 ++-- - 3 files changed, 30 insertions(+), 27 deletions(-) - -diff --git a/src/plugins/reporter-bugzilla.c b/src/plugins/reporter-bugzilla.c -index d4d03f8e..c12e00d1 100644 ---- a/src/plugins/reporter-bugzilla.c -+++ b/src/plugins/reporter-bugzilla.c -@@ -35,7 +35,7 @@ int attach_text_item(struct abrt_xmlrpc *ax, const char *bug_id, - log_debug("attaching '%s' as text", item_name); - int r = rhbz_attach_blob(ax, bug_id, - item_name, item->content, strlen(item->content), -- RHBZ_NOMAIL_NOTIFY -+ RHBZ_MINOR_UPDATE - ); - return (r == 0); - } -@@ -63,7 +63,7 @@ int attach_file_item(struct abrt_xmlrpc *ax, const char *bug_id, - return 0; - } - log_debug("attaching '%s' as file", item_name); -- int flag = RHBZ_NOMAIL_NOTIFY; -+ int flag = RHBZ_MINOR_UPDATE; - if (!(item->flags & CD_FLAG_BIGTXT)) - flag |= RHBZ_BINARY_ATTACHMENT; - int r = rhbz_attach_fd(ax, bug_id, item_name, fd, flag); -@@ -793,7 +793,7 @@ int main(int argc, char **argv) - if (reported_to && reported_to->url) - { - log_warning(_("Adding External URL to bug %i"), new_id); -- rhbz_set_url(client, new_id, reported_to->url, RHBZ_NOMAIL_NOTIFY); -+ rhbz_set_url(client, new_id, reported_to->url, RHBZ_MINOR_UPDATE); - free_report_result(reported_to); - } - } -@@ -821,7 +821,7 @@ int main(int argc, char **argv) - if (existing_id >= 0) - { - log_warning(_("Closing bug %i as duplicate of bug %i"), new_id, existing_id); -- rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_NOMAIL_NOTIFY); -+ rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_MINOR_UPDATE); - } - - goto log_out; -@@ -876,7 +876,7 @@ int main(int argc, char **argv) - && !g_list_find_custom(bz->bi_cc_list, rhbz.b_login, (GCompareFunc)g_strcmp0) - ) { - log_warning(_("Adding %s to CC list"), rhbz.b_login); -- rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_NOMAIL_NOTIFY); -+ rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_MINOR_UPDATE); - } - - /* Add comment and bt */ -@@ -911,7 +911,7 @@ int main(int argc, char **argv) - sprintf(bug_id_str, "%i", bz->bi_id); - log_warning(_("Attaching better backtrace")); - rhbz_attach_blob(client, bug_id_str, FILENAME_BACKTRACE, bt, strlen(bt), -- RHBZ_NOMAIL_NOTIFY); -+ RHBZ_MINOR_UPDATE); - } - } - else -diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c -index 680527d7..cb6505ea 100644 ---- a/src/plugins/rhbz.c -+++ b/src/plugins/rhbz.c -@@ -605,7 +605,7 @@ int rhbz_new_bug(struct abrt_xmlrpc *ax, - return new_bug_id; - } - --/* suppress mail notify by {s:i} (nomail:1) (driven by flag) */ -+/* suppress mail notify by {s:i} (minor_update:1) (driven by flag) */ - int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, - const char *filename, const char *data, int data_len, int flags) - { -@@ -620,7 +620,7 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, - - char *fn = xasprintf("File: %s", filename); - xmlrpc_value* result; -- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ int minor_update = !!IS_MINOR_UPDATE(flags); - - /* http://www.bugzilla.org/docs/4.2/en/html/api/Bugzilla/WebService/Bug.html#add_attachment - * -@@ -640,10 +640,11 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, - */ - "data", data, (size_t)data_len, - -- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 -- * and version 4.4.rc1.b02 -+ /* If set to true, this is considered a minor update and no mail is sent to users who do not want -+ * minor update emails. If current user is not in the minor_update_group, this parameter is simply -+ * ignored. - */ -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - - free(fn); -@@ -737,25 +738,25 @@ struct bug_info *rhbz_find_origin_bug_closed_duplicate(struct abrt_xmlrpc *ax, - return bi_tmp; - } - --/* suppress mail notify by {s:i} (nomail:1) */ -+/* suppress mail notify by {s:i} (minor_update:1) */ - void rhbz_mail_to_cc(struct abrt_xmlrpc *ax, int bug_id, const char *mail, int flags) - { - func_entry(); - - xmlrpc_value *result; -- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ int minor_update = !!IS_MINOR_UPDATE(flags); - #if 0 /* Obsolete API */ - result = abrt_xmlrpc_call(ax, "Bug.update", "({s:i,s:{s:(s),s:i}})", - "ids", bug_id, - "updates", "add_cc", mail, -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - #endif - /* Bugzilla 4.0+ uses this API: */ - result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:{s:(s),s:i}}", - "ids", bug_id, - "cc", "add", mail, -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - if (result) - xmlrpc_DECREF(result); -@@ -786,12 +787,12 @@ void rhbz_add_comment(struct abrt_xmlrpc *ax, int bug_id, const char *comment, - func_entry(); - - int private = !!IS_PRIVATE(flags); -- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ int minor_update = !!IS_MINOR_UPDATE(flags); - - xmlrpc_value *result; - result = abrt_xmlrpc_call(ax, "Bug.add_comment", "{s:i,s:s,s:b,s:i}", - "id", bug_id, "comment", comment, -- "private", private, "nomail", nomail_notify); -+ "private", private, "minor_update", minor_update); - - if (result) - xmlrpc_DECREF(result); -@@ -801,15 +802,16 @@ void rhbz_set_url(struct abrt_xmlrpc *ax, int bug_id, const char *url, int flags - { - func_entry(); - -- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ const int minor_update = !!IS_MINOR_UPDATE(flags); - xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:i}", - "ids", bug_id, - "url", url, - -- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 -- * and version 4.4.rc1.b02 -+ /* If set to true, this is considered a minor update and no mail is sent to users who do not want -+ * minor update emails. If current user is not in the minor_update_group, this parameter is simply -+ * ignored. - */ -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - - if (result) -@@ -822,17 +824,18 @@ void rhbz_close_as_duplicate(struct abrt_xmlrpc *ax, int bug_id, - { - func_entry(); - -- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ const int minor_update = !!IS_MINOR_UPDATE(flags); - xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:s,s:i,s:i}", - "ids", bug_id, - "status", "CLOSED", - "resolution", "DUPLICATE", - "dupe_of", duplicate_bug, - -- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 -- * and version 4.4.rc1.b02 -+ /* If set to true, this is considered a minor update and no mail is sent to users who do not want -+ * minor update emails. If current user is not in the minor_update_group, this parameter is simply -+ * ignored. - */ -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - - if (result) -diff --git a/src/plugins/rhbz.h b/src/plugins/rhbz.h -index 86632a35..3990eda0 100644 ---- a/src/plugins/rhbz.h -+++ b/src/plugins/rhbz.h -@@ -36,7 +36,7 @@ enum { - RHBZ_MANDATORY_MEMB = (1 << 0), - RHBZ_READ_STR = (1 << 1), - RHBZ_READ_INT = (1 << 2), -- RHBZ_NOMAIL_NOTIFY = (1 << 3), -+ RHBZ_MINOR_UPDATE = (1 << 3), - RHBZ_PRIVATE = (1 << 4), - RHBZ_BINARY_ATTACHMENT = (1 << 5), - }; -@@ -44,7 +44,7 @@ enum { - #define IS_MANDATORY(flags) ((flags) & RHBZ_MANDATORY_MEMB) - #define IS_READ_STR(flags) ((flags) & RHBZ_READ_STR) - #define IS_READ_INT(flags) ((flags) & RHBZ_READ_INT) --#define IS_NOMAIL_NOTIFY(flags) ((flags) & RHBZ_NOMAIL_NOTIFY) -+#define IS_MINOR_UPDATE(flags) ((flags) & RHBZ_MINOR_UPDATE) - #define IS_PRIVATE(flags) ((flags) & RHBZ_PRIVATE) - - struct bug_info { --- -2.17.2 - diff --git a/autogen.sh b/autogen.sh deleted file mode 100755 index c6e1729..0000000 --- a/autogen.sh +++ /dev/null @@ -1,70 +0,0 @@ -#! /bin/sh - -print_help() -{ -cat << EOH -Prepares the source tree for configuration - -Usage: - autogen.sh [sydeps [--install]] - -Options: - - sysdeps prints out all dependencies - --install install all dependencies ('sudo yum install \$DEPS') - -EOH -} - -build_depslist() -{ - DEPS_LIST=`grep "^\(Build\)\?Requires:" *.spec.in | grep -v "%{name}" | tr -s " " | tr "," "\n" | cut -f2 -d " " | grep -v "^libreport" | sort -u | tr "\n" " "` -} - -case "$1" in - "--help"|"-h") - print_help - exit 0 - ;; - "sysdeps") - build_depslist - - if [ "$2" == "--install" ]; then - set -x verbose - sudo yum install $DEPS_LIST - set +x verbose - else - echo $DEPS_LIST - fi - exit 0 - ;; - *) - echo "Running gen-version" - ./gen-version - - mkdir -p m4 - echo "Creating m4/aclocal.m4 ..." - test -r m4/aclocal.m4 || touch m4/aclocal.m4 - - echo "Running autopoint" - autopoint --force || exit 1 - - echo "Running intltoolize..." - intltoolize --force --copy --automake || exit 1 - - echo "Running aclocal..." - aclocal || exit 1 - - echo "Running libtoolize..." - libtoolize || exit 1 - - echo "Running autoheader..." - autoheader || return 1 - - echo "Running autoconf..." - autoconf --force || exit 1 - - echo "Running automake..." - automake --add-missing --force --copy || exit 1 - ;; -esac diff --git a/libreport.spec b/libreport.spec index 503714f..c5335d3 100644 --- a/libreport.spec +++ b/libreport.spec @@ -10,7 +10,7 @@ %define libjson_devel json-c-devel %endif -%define glib_ver 2.43 +%define glib_ver 2.43.4 %if 0%{?fedora} || 0%{?rhel} > 7 # Enable python3 build by default @@ -28,16 +28,13 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.7 -Release: 2%{?dist} +Version: 2.10.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0001: 0001-rhbz-Replace-nomail-flag-with-minor_update.patch - - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -367,9 +364,11 @@ data over ftp/scp... %autosetup -S git %build -autoconf +./gen-version +autoreconf -if +intltoolize --automake -c -f -CFLAGS="%{optflags} -Werror" %configure \ +%configure \ %if %{without python2} --without-python2 \ %endif # with python2 @@ -552,6 +551,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/problem_details_widget.h %{_includedir}/libreport/problem_details_dialog.h %{_includedir}/libreport/problem_utils.h +%{_includedir}/libreport/report_result.h %{_includedir}/libreport/ureport.h %{_includedir}/libreport/reporters.h %{_includedir}/libreport/global_configuration.h @@ -824,6 +824,11 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sat Feb 02 2019 Ernestas Kulik - 2.10.0-1 +- Update to 2.10.0 +- Bump GLib dependency +- Mirror commands run in autogen.sh + * Mon Jan 07 2019 Martin Kutlak 2.9.7-2 - rhbz: Replace nomail flag with minor_update diff --git a/sources b/sources index 9749b3c..948e33d 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.7.tar.gz) = 8e92470ada204236ae4540145ba7f750814c74b0f5858d25ec797f06d4daeb9fc40996b609a33e154072a45624513d7dbd4027587708ffbfb2f40b0687b16ac3 +SHA512 (libreport-2.10.0.tar.gz) = 978ea442d82b75abf80b2075f540cb05c5577387a9221f2070c9695c4546d36169738d223f5e903d0b774b7e1566a6111c55a6bb51a0822ad1676095f067c45b From 6325326bdba683ba5dabf124b9da19aa0098deb4 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Tue, 23 Apr 2019 08:34:18 +0200 Subject: [PATCH 05/13] Add patch to add workflow field when saving FAF response Needed to make one Cockpit test pass. Signed-off-by: Ernestas Kulik --- ...rt-workflow-when-saving-server-respo.patch | 44 +++++++++++++++++++ libreport.spec | 6 ++- 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch diff --git a/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch b/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch new file mode 100644 index 0000000..a09575b --- /dev/null +++ b/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch @@ -0,0 +1,44 @@ +From f2d98e0ee81037f18e50c06e409def19e791c2f2 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Wed, 17 Apr 2019 13:24:19 +0200 +Subject: [PATCH] lib: ureport: Export workflow when saving server response + +Oversight from 779b16202c3fe990f6ecda17085c436899340e12. + +Signed-off-by: Ernestas Kulik +--- + src/lib/ureport.c | 18 +++++++++++++++++- + 1 file changed, 17 insertions(+), 1 deletion(-) + +diff --git a/src/lib/ureport.c b/src/lib/ureport.c +index cc18aefd..a5953244 100644 +--- a/src/lib/ureport.c ++++ b/src/lib/ureport.c +@@ -680,7 +680,23 @@ ureport_server_response_save_in_dump_dir(struct ureport_server_response *resp, + if (resp->urr_reported_to_list) + { + for (GList *e = resp->urr_reported_to_list; e; e = g_list_next(e)) +- add_reported_to(dd, e->data); ++ { ++ char *workflow; ++ ++ workflow = getenv("LIBREPORT_WORKFLOW"); ++ if (NULL == workflow) ++ { ++ add_reported_to(dd, e->data); ++ } ++ else ++ { ++ g_autofree char *line = NULL; ++ ++ line = g_strdup_printf("%s WORKFLOW=%s", (const char *)e->data, workflow); ++ ++ add_reported_to(dd, line); ++ } ++ } + } + + if (resp->urr_solution) +-- +2.21.0 + diff --git a/libreport.spec b/libreport.spec index c5335d3..f24ad76 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,11 +29,12 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.10.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0: 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -824,6 +825,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Apr 23 2019 Ernestas Kulik - 2.10.0-2 +- Add patch to fix workflow fields not being added to reported_to when μReport response comes with a Bugzilla URL + * Sat Feb 02 2019 Ernestas Kulik - 2.10.0-1 - Update to 2.10.0 - Bump GLib dependency From 3f2c165bbed0ecd16e14eb6751b714544f48345e Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Wed, 3 Jul 2019 12:44:33 +0200 Subject: [PATCH 06/13] New upstream release 2.10.1 * Remove gen-version from spec - This is upstream script to generate version. This is not needed in dist-git. [2.10.1] - 2019-07-03 Changed - Clearer warnings about missing report elements. - Export workflow when saving server response. - uReport workflow moved to plugin-ureport subpackage. - Refined composition of error messages during problem reporting. Fixed - Fixed dump dir lock up in case of delete failure. Signed-off-by: Martin Kutlak --- .gitignore | 1 + ...rt-workflow-when-saving-server-respo.patch | 44 ------------------- libreport.spec | 38 ++++++++++++---- sources | 2 +- 4 files changed, 32 insertions(+), 53 deletions(-) delete mode 100644 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch diff --git a/.gitignore b/.gitignore index 50a2b87..7c0c165 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ /libreport-2.9.6.tar.gz /libreport-2.9.7.tar.gz /libreport-2.10.0.tar.gz +/libreport-2.10.1.tar.gz diff --git a/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch b/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch deleted file mode 100644 index a09575b..0000000 --- a/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch +++ /dev/null @@ -1,44 +0,0 @@ -From f2d98e0ee81037f18e50c06e409def19e791c2f2 Mon Sep 17 00:00:00 2001 -From: Ernestas Kulik -Date: Wed, 17 Apr 2019 13:24:19 +0200 -Subject: [PATCH] lib: ureport: Export workflow when saving server response - -Oversight from 779b16202c3fe990f6ecda17085c436899340e12. - -Signed-off-by: Ernestas Kulik ---- - src/lib/ureport.c | 18 +++++++++++++++++- - 1 file changed, 17 insertions(+), 1 deletion(-) - -diff --git a/src/lib/ureport.c b/src/lib/ureport.c -index cc18aefd..a5953244 100644 ---- a/src/lib/ureport.c -+++ b/src/lib/ureport.c -@@ -680,7 +680,23 @@ ureport_server_response_save_in_dump_dir(struct ureport_server_response *resp, - if (resp->urr_reported_to_list) - { - for (GList *e = resp->urr_reported_to_list; e; e = g_list_next(e)) -- add_reported_to(dd, e->data); -+ { -+ char *workflow; -+ -+ workflow = getenv("LIBREPORT_WORKFLOW"); -+ if (NULL == workflow) -+ { -+ add_reported_to(dd, e->data); -+ } -+ else -+ { -+ g_autofree char *line = NULL; -+ -+ line = g_strdup_printf("%s WORKFLOW=%s", (const char *)e->data, workflow); -+ -+ add_reported_to(dd, line); -+ } -+ } - } - - if (resp->urr_solution) --- -2.21.0 - diff --git a/libreport.spec b/libreport.spec index f24ad76..e71c531 100644 --- a/libreport.spec +++ b/libreport.spec @@ -28,14 +28,12 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.10.0 -Release: 2%{?dist} +Version: 2.10.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0: 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -312,6 +310,7 @@ install this package and you're done. %package rhel Summary: Default configuration for reporting bugs via Red Hat infrastructure Requires: %{name} = %{version}-%{release} +Requires: %{name}-plugin-ureport %description rhel Default configuration for reporting bugs via Red Hat infrastructure @@ -365,7 +364,6 @@ data over ftp/scp... %autosetup -S git %build -./gen-version autoreconf -if intltoolize --automake -c -f @@ -652,6 +650,11 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/ureport.conf.5.gz %{_datadir}/%{name}/events/report_uReport.xml %{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.ureport.xml +%if 0%{?rhel} +%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf +%{_datadir}/%{name}/workflows/workflow_uReport.xml +%{_mandir}/man5/report_uReport.conf.5.* +%endif %if %{with bugzilla} %files plugin-bugzilla @@ -782,12 +785,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_datadir}/%{name}/workflows/workflow_RHELAddDatavmcore.xml %{_datadir}/%{name}/workflows/workflow_RHELAddDataxorg.xml %{_datadir}/%{name}/workflows/workflow_RHELAddDataJavaScript.xml -%{_datadir}/%{name}/workflows/workflow_uReport.xml %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel.conf %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf -%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_mandir}/man5/report_rhel.conf.5.* -%{_mandir}/man5/report_uReport.conf.5.* %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml @@ -825,6 +825,28 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Jul 03 2019 Martin Kutlak 2.10.1-1 +- doc: Makefile.am: Use correct path for --conf-file +- lib: copy_file_recursive: Use GLib abstractions +- gui-wizard-gtk: Fix fix +- cli: run-command: Replace use of vfork() with fork() +- plugins: rhbz: Don’t call strlen() on attachment data +- Check for empty fmt_file name when printing error msgs +- cli: Unpack command-line argument parsing logic +- lib: event_config: Remove pointless assignment +- gui-wizard-gtk: Fix never-read assignment +- lib: xatonum: Check string parameters +- Rework and refine composition of error messages +- Add clearer warnings about missing report elements specified in format files +- Move uReport workflow to plugin-ureport subpackage +- lib: ureport: Export workflow when saving server response +- lib: dump_dir: Clean up on failure in dd_delete() +- Use #ifdef to check whether macros are defined +- autogen.sh: Use autoreconf +- autogen.sh: Allow skipping running configure +- tests: forbidden_words: Don’t hardcode sysconfdir +- Makefile.am: Use correct locale when getting date + * Tue Apr 23 2019 Ernestas Kulik - 2.10.0-2 - Add patch to fix workflow fields not being added to reported_to when μReport response comes with a Bugzilla URL diff --git a/sources b/sources index 948e33d..8632440 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.10.0.tar.gz) = 978ea442d82b75abf80b2075f540cb05c5577387a9221f2070c9695c4546d36169738d223f5e903d0b774b7e1566a6111c55a6bb51a0822ad1676095f067c45b +SHA512 (libreport-2.10.1.tar.gz) = 9c110b7a5f0e3803d12b7ea05eaf47b3a37592612f0107ed7e6604168d283a09bf3d08b805b415ec90772498062b742814cbf86a8b9ea0f4cc5ff774a77d9671 From dd6428a7b6e316274d643802f5fa189c9cf603c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Oct 2019 15:08:34 +0200 Subject: [PATCH 07/13] New upstream release 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + libreport.spec | 108 ++++++++++++++++--------------------------------- sources | 2 +- 3 files changed, 37 insertions(+), 74 deletions(-) diff --git a/.gitignore b/.gitignore index 7c0c165..adce7e2 100644 --- a/.gitignore +++ b/.gitignore @@ -5,3 +5,4 @@ /libreport-2.9.7.tar.gz /libreport-2.10.0.tar.gz /libreport-2.10.1.tar.gz +/libreport-2.11.0.tar.gz diff --git a/libreport.spec b/libreport.spec index e71c531..bce12c1 100644 --- a/libreport.spec +++ b/libreport.spec @@ -12,38 +12,18 @@ %define glib_ver 2.43.4 -%if 0%{?fedora} || 0%{?rhel} > 7 -# Enable python3 build by default -%bcond_without python3 -%else -%bcond_with python3 -%endif - -%if 0%{?rhel} > 7 || 0%{?fedora} > 28 -# Disable python2 build by default -%bcond_with python2 -%else -%bcond_without python2 -%endif - Summary: Generic library for reporting various problems Name: libreport -Version: 2.10.1 +Version: 2.11.0 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel BuildRequires: desktop-file-utils -%if %{with python2} -BuildRequires: python2-devel -%endif # with python2 -%if %{with python3} BuildRequires: python3-devel -%endif # with python3 BuildRequires: gettext BuildRequires: libxml2-devel BuildRequires: libtar-devel @@ -115,22 +95,6 @@ Requires: libreport-web = %{version}-%{release} %description web-devel Development headers for libreport-web -%if %{with python2} -%package -n python2-libreport -Summary: Python bindings for report-libs -Requires: libreport = %{version}-%{release} -Requires: python2-dnf -%{?python_provide:%python_provide python2-libreport} -# Remove before F30 -Provides: %{name}-python = %{version}-%{release} -Provides: %{name}-python%{?_isa} = %{version}-%{release} -Obsoletes: %{name}-python < %{version}-%{release} - -%description -n python2-libreport -Python bindings for report-libs. -%endif # with python2 - -%if %{with python3} %package -n python3-libreport Summary: Python 3 bindings for report-libs %if 0%{?_module_build} @@ -146,14 +110,9 @@ Requires: libreport = %{version}-%{release} %endif Requires: python3-dnf %{?python_provide:%python_provide python3-libreport} -# Remove before F30 -Provides: %{name}-python3 = %{version}-%{release} -Provides: %{name}-python3%{?_isa} = %{version}-%{release} -Obsoletes: %{name}-python3 < %{version}-%{release} %description -n python3-libreport Python 3 bindings for report-libs. -%endif # with python3 %package cli Summary: %{name}'s command line interface @@ -177,7 +136,6 @@ bugs Summary: GTK front-end for libreport Requires: libreport = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -Requires: fros >= 1.0 Provides: report-gtk = 0:0.23-1 Obsoletes: report-gtk < 0:0.23-1 @@ -257,12 +215,7 @@ BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} %if 0%{?rhel} -%if %{with python2} -Requires: python-rhsm -%endif # with python2 -%if %{with python3} Requires: python3-subscription-manager-rhsm -%endif # with python3 %endif %description plugin-ureport @@ -364,16 +317,9 @@ data over ftp/scp... %autosetup -S git %build -autoreconf -if -intltoolize --automake -c -f +autoconf -%configure \ -%if %{without python2} - --without-python2 \ -%endif # with python2 -%if %{without python3} - --without-python3 \ -%endif # with python3 +CFLAGS="%{optflags} -Werror" %configure \ %if %{without bugzilla} --without-bugzilla \ %endif @@ -543,6 +489,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/problem_data.h %{_includedir}/libreport/problem_report.h %{_includedir}/libreport/report.h +%{_includedir}/libreport/report_result.h %{_includedir}/libreport/run_event.h %{_includedir}/libreport/file_obj.h %{_includedir}/libreport/config_item_info.h @@ -550,7 +497,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/problem_details_widget.h %{_includedir}/libreport/problem_details_dialog.h %{_includedir}/libreport/problem_utils.h -%{_includedir}/libreport/report_result.h %{_includedir}/libreport/ureport.h %{_includedir}/libreport/reporters.h %{_includedir}/libreport/global_configuration.h @@ -572,17 +518,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/libreport_curl.h %{_libdir}/pkgconfig/libreport-web.pc -%if %{with python2} -%files -n python2-libreport -%{python2_sitearch}/report/ -%{python2_sitearch}/reportclient/ -%endif # with python2 - -%if %{with python3} %files -n python3-libreport %{python3_sitearch}/report/ %{python3_sitearch}/reportclient/ -%endif # with python3 %files cli %{_bindir}/report-cli @@ -595,9 +533,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %files gtk %{_bindir}/report-gtk %{_libdir}/libreport-gtk.so.* -%config(noreplace) %{_sysconfdir}/libreport/events.d/emergencyanalysis_event.conf -%{_mandir}/man5/emergencyanalysis_event.conf.5.* -%{_datadir}/%{name}/events/report_EmergencyAnalysis.xml %{_mandir}/man1/report-gtk.1.gz %files gtk-devel @@ -631,7 +566,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/plugins/mailx.conf %{_datadir}/%{name}/conf.d/plugins/mailx.conf %{_datadir}/%{name}/events/report_Mailx.xml -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.mailx.xml %{_datadir}/%{name}/workflows/workflow_Mailx.xml %{_datadir}/%{name}/workflows/workflow_MailxCCpp.xml %config(noreplace) %{_sysconfdir}/libreport/events.d/mailx_event.conf @@ -649,7 +583,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man1/reporter-ureport.1.gz %{_mandir}/man5/ureport.conf.5.gz %{_datadir}/%{name}/events/report_uReport.xml -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.ureport.xml %if 0%{?rhel} %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_datadir}/%{name}/workflows/workflow_uReport.xml @@ -663,12 +596,12 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_format.conf %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_formatdup.conf %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_format_analyzer_libreport.conf +%config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_formatdup_analyzer_libreport.conf %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_format_kernel.conf %{_datadir}/%{name}/events/report_Bugzilla.xml %{_datadir}/%{name}/events/watch_Bugzilla.xml %config(noreplace) %{_sysconfdir}/libreport/events/report_Bugzilla.conf %config(noreplace) %{_sysconfdir}/libreport/events.d/bugzilla_event.conf -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.bugzilla.xml # FIXME: remove with the old gui %{_mandir}/man1/reporter-bugzilla.1.gz %{_mandir}/man5/report_Bugzilla.conf.5.* @@ -677,6 +610,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/bugzilla_format.conf.5.* %{_mandir}/man5/bugzilla_formatdup.conf.5.* %{_mandir}/man5/bugzilla_format_analyzer_libreport.conf.5.* +%{_mandir}/man5/bugzilla_formatdup_analyzer_libreport.conf.5.* %{_mandir}/man5/bugzilla_format_kernel.conf.5.* %{_bindir}/reporter-bugzilla %endif @@ -720,7 +654,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_datadir}/%{name}/conf.d/plugins/rhtsupport.conf %{_datadir}/%{name}/events/report_RHTSupport.xml %{_datadir}/%{name}/events/report_RHTSupport_AddData.xml -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.rhtsupport.xml %if 0%{?rhel} %attr(600,root,root)%{_sysconfdir}/%{name}/cert-api.access.redhat.com.pem %endif @@ -825,6 +758,35 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Oct 11 2019 Matěj Grabovský 2.11.0-1 +- Remove option for emergency analysis/reporting +- tests: proc_helpers: Fix call to errx() +- plugins: bugzilla: Add format file for libreport duplicates +- dbus: Remove interface introspection files +- lib: Don't warn if a configuration key is missing +- gtk: Handle event wildcards in command line options +- gtk: Better handling of workflows with wildcarded events +- lib: Remove unused arguments of prepare_commands +- lib: Reintroduce error logging in event XML parser +- cli: Continue running even if some events have no commands +- cli: Expand event name wildcards +- lib: Expand wildcards in workflow XML parser +- lib: Add a function to expand wildcards in event names +- style: Simplify code; fix typos in comments +- gitignore: Update with missing and renamed generated files +- dirsize: Skip dirs in which sosreport is being generated +- tests: Fix Python tests being skipped unconditionally +- Remove Python 2 support + +* Thu Oct 03 2019 Miro Hrončok - 2.10.1-4 +- Rebuilt for Python 3.8.0rc1 (#1748018) + +* Sat Aug 17 2019 Miro Hrončok - 2.10.1-3 +- Rebuilt for Python 3.8 + +* Thu Jul 25 2019 Fedora Release Engineering - 2.10.1-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + * Wed Jul 03 2019 Martin Kutlak 2.10.1-1 - doc: Makefile.am: Use correct path for --conf-file - lib: copy_file_recursive: Use GLib abstractions diff --git a/sources b/sources index 8632440..c84495f 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.10.1.tar.gz) = 9c110b7a5f0e3803d12b7ea05eaf47b3a37592612f0107ed7e6604168d283a09bf3d08b805b415ec90772498062b742814cbf86a8b9ea0f4cc5ff774a77d9671 +SHA512 (libreport-2.11.0.tar.gz) = 6ca2e6d8f9e1c8fc09ab4eabc2cb7277be38eeda7982724e346fe830a67162bf6e49f1d420336df3924ffba70e06a7f92dc2a6e41cdad332603315b5f6684143 From 3694df79402e0e5739489df5b4653b92a68aa0c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 16 Oct 2019 11:02:05 +0200 Subject: [PATCH 08/13] New upstream release 2.11.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + libreport.spec | 5 ++++- sources | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index adce7e2..bf8161e 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,4 @@ /libreport-2.10.0.tar.gz /libreport-2.10.1.tar.gz /libreport-2.11.0.tar.gz +/libreport-2.11.1.tar.gz diff --git a/libreport.spec b/libreport.spec index bce12c1..dc10f18 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.0 +Version: 2.11.1 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -758,6 +758,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Oct 16 2019 Matěj Grabovský 2.11.1-1 +- gtk: Fix a double-free condition + * Fri Oct 11 2019 Matěj Grabovský 2.11.0-1 - Remove option for emergency analysis/reporting - tests: proc_helpers: Fix call to errx() diff --git a/sources b/sources index c84495f..5694e78 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.0.tar.gz) = 6ca2e6d8f9e1c8fc09ab4eabc2cb7277be38eeda7982724e346fe830a67162bf6e49f1d420336df3924ffba70e06a7f92dc2a6e41cdad332603315b5f6684143 +SHA512 (libreport-2.11.1.tar.gz) = cf9d91dddb769c5b2f196e44d2af5cd96d9713208eaf1627403825ed1ab4e5e4db7c0d496529c72408b1445c279f263e774df6264431f2ae7274062f5975d740 From 3eb8cec4e7a161754c6615d15df9c563457b2ace Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 23 Oct 2019 13:57:28 +0200 Subject: [PATCH 09/13] New upstream release 2.11.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + libreport.spec | 9 ++++++++- sources | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index bf8161e..299ee3c 100644 --- a/.gitignore +++ b/.gitignore @@ -7,3 +7,4 @@ /libreport-2.10.1.tar.gz /libreport-2.11.0.tar.gz /libreport-2.11.1.tar.gz +/libreport-2.11.2.tar.gz diff --git a/libreport.spec b/libreport.spec index dc10f18..f9581af 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.1 +Version: 2.11.2 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -758,6 +758,13 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Oct 23 2019 Matěj Grabovský 2.11.2-1 +- gtk: Improve memory management +- gtk: Prevent memory leak +- lib: Eliminate GLib inefficiency +- gtk,style: Minor style consistency fixes +- workflows: Correct name of post_report event + * Wed Oct 16 2019 Matěj Grabovský 2.11.1-1 - gtk: Fix a double-free condition diff --git a/sources b/sources index 5694e78..67d70da 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.1.tar.gz) = cf9d91dddb769c5b2f196e44d2af5cd96d9713208eaf1627403825ed1ab4e5e4db7c0d496529c72408b1445c279f263e774df6264431f2ae7274062f5975d740 +SHA512 (libreport-2.11.2.tar.gz) = 26181aab66b2ef28399086553edb0e331e35706b2526ea659699c9f330422a1731125133d68b925010fefbe08502535cffbd1d570c708eaecfebf0451d8492bd From 4636b2975ffea213b8e5b337ad4bae1b7f9adb8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 23 Oct 2019 14:00:22 +0200 Subject: [PATCH 10/13] Keep providing libreport-python3 It's not yet phased out in Fedora 29 and initial-setup depends on it. --- libreport.spec | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/libreport.spec b/libreport.spec index f9581af..41f3d4d 100644 --- a/libreport.spec +++ b/libreport.spec @@ -110,6 +110,10 @@ Requires: libreport = %{version}-%{release} %endif Requires: python3-dnf %{?python_provide:%python_provide python3-libreport} +# Remove before F30 +Provides: %{name}-python3 = %{version}-%{release} +Provides: %{name}-python3%{?_isa} = %{version}-%{release} +Obsoletes: %{name}-python3 < %{version}-%{release} %description -n python3-libreport Python 3 bindings for report-libs. From fbe22313ec4114cfaf8877be1703881ad579b43c Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Mon, 11 Nov 2019 11:21:51 +0100 Subject: [PATCH 11/13] Add patch to fix a double-free https://github.com/abrt/libreport/commit/36c5e90469b36cb0724f45447ae923a6d6ccf348 Signed-off-by: Ernestas Kulik --- ...gtk-Fix-another-possible-double-free.patch | 38 +++++++++++++++++++ libreport.spec | 7 +++- 2 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 0001-gtk-Fix-another-possible-double-free.patch diff --git a/0001-gtk-Fix-another-possible-double-free.patch b/0001-gtk-Fix-another-possible-double-free.patch new file mode 100644 index 0000000..2bd966d --- /dev/null +++ b/0001-gtk-Fix-another-possible-double-free.patch @@ -0,0 +1,38 @@ +From 36c5e90469b36cb0724f45447ae923a6d6ccf348 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Fri, 25 Oct 2019 12:37:44 +0200 +Subject: [PATCH] gtk: Fix another possible double-free + +The object should only be freed if we're in the cleanup phase, i.e. only +in the if-branch of the condition. + +This one was introduced in dc281652. +--- + src/gui-wizard-gtk/wizard.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 4b840bac..ec8bb68b 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -2518,7 +2518,7 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, + while (valid) + { + g_autofree char *text = NULL; +- g_autofree search_item_t *word = NULL; ++ search_item_t *word = NULL; + + gtk_tree_model_get(GTK_TREE_MODEL(g_ls_sensitive_list), &iter, + SEARCH_COLUMN_TEXT, &text, +@@ -2533,6 +2533,8 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, + + if (word == g_current_highlighted_word) + g_current_highlighted_word = NULL; ++ ++ free(word); + } + else + { +-- +2.23.0 + diff --git a/libreport.spec b/libreport.spec index 41f3d4d..7768528 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.11.2 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -63,6 +63,8 @@ Requires: lz4 BuildRequires: sed %endif +Patch0: 0001-gtk-Fix-another-possible-double-free.patch + %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -762,6 +764,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Nov 11 2019 Ernestas Kulik - 2.11.2-2 +- Add patch to fix a double-free + * Wed Oct 23 2019 Matěj Grabovský 2.11.2-1 - gtk: Improve memory management - gtk: Prevent memory leak From 8b3633598227fe33027f53f6f47ca4424f892b9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 14 Nov 2019 10:44:05 +0100 Subject: [PATCH 12/13] New upstream release 2.11.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + ...gtk-Fix-another-possible-double-free.patch | 38 ------------------- libreport.spec | 21 ++++++++-- sources | 2 +- 4 files changed, 19 insertions(+), 43 deletions(-) delete mode 100644 0001-gtk-Fix-another-possible-double-free.patch diff --git a/.gitignore b/.gitignore index 299ee3c..9ef551f 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,4 @@ /libreport-2.11.0.tar.gz /libreport-2.11.1.tar.gz /libreport-2.11.2.tar.gz +/libreport-2.11.3.tar.gz diff --git a/0001-gtk-Fix-another-possible-double-free.patch b/0001-gtk-Fix-another-possible-double-free.patch deleted file mode 100644 index 2bd966d..0000000 --- a/0001-gtk-Fix-another-possible-double-free.patch +++ /dev/null @@ -1,38 +0,0 @@ -From 36c5e90469b36cb0724f45447ae923a6d6ccf348 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Fri, 25 Oct 2019 12:37:44 +0200 -Subject: [PATCH] gtk: Fix another possible double-free - -The object should only be freed if we're in the cleanup phase, i.e. only -in the if-branch of the condition. - -This one was introduced in dc281652. ---- - src/gui-wizard-gtk/wizard.c | 4 +++- - 1 file changed, 3 insertions(+), 1 deletion(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index 4b840bac..ec8bb68b 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -2518,7 +2518,7 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, - while (valid) - { - g_autofree char *text = NULL; -- g_autofree search_item_t *word = NULL; -+ search_item_t *word = NULL; - - gtk_tree_model_get(GTK_TREE_MODEL(g_ls_sensitive_list), &iter, - SEARCH_COLUMN_TEXT, &text, -@@ -2533,6 +2533,8 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, - - if (word == g_current_highlighted_word) - g_current_highlighted_word = NULL; -+ -+ free(word); - } - else - { --- -2.23.0 - diff --git a/libreport.spec b/libreport.spec index 7768528..a2c4eee 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.2 -Release: 2%{?dist} +Version: 2.11.3 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -63,8 +63,6 @@ Requires: lz4 BuildRequires: sed %endif -Patch0: 0001-gtk-Fix-another-possible-double-free.patch - %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -764,6 +762,21 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Nov 14 2019 Matěj Grabovský 2.11.3-1 +- Remove unused scripts +- gtk: Fix infinite loop crashing the reporting +- gtk: Improve logging +- gtk: Remove page number from page struct +- gtk: Code style adjustments +- Make notebook tabs invisible again +- gui-wizard-gtk: Remove expert mode +- gui-wizard-gtk: Stop allowing overriding UI definitions +- pull-trans: Suggest zanata install +- shellcheck: Iterating over ls output is fragile. Use globs. +- shellcheck: Double quote to prevent globbing and word splitting +- zanata: Use python3 zanata client to pull translations +- gtk: Fix another possible double-free + * Mon Nov 11 2019 Ernestas Kulik - 2.11.2-2 - Add patch to fix a double-free diff --git a/sources b/sources index 67d70da..eb99041 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.2.tar.gz) = 26181aab66b2ef28399086553edb0e331e35706b2526ea659699c9f330422a1731125133d68b925010fefbe08502535cffbd1d570c708eaecfebf0451d8492bd +SHA512 (libreport-2.11.3.tar.gz) = 0dc78c77a94ded2d1be646b0f9481765bf10a865ab28f2a226483f8bc5e43fce20f3612332fdc9cee5adb9f8d9c89b59e9d388e9c60425b9ff5f83c9a50132a1 From 97f36b026e50fa4b3f0408df0b3582234429b261 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 22 Nov 2019 16:18:26 +0100 Subject: [PATCH 13/13] Rebuild for Fedora 29 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index a2c4eee..a6b6089 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.11.3 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -762,6 +762,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Nov 22 2019 Matěj Grabovský - 2.11.3-2 +- Rebuild for Fedora 29 + * Thu Nov 14 2019 Matěj Grabovský 2.11.3-1 - Remove unused scripts - gtk: Fix infinite loop crashing the reporting