From fb2c7feb704b63dd29d56cb77fe6bdb012cd7d78 Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Wed, 15 Mar 2017 15:20:27 +0100 Subject: [PATCH 001/133] New upstream release 2.9.1 Signed-off-by: Matej Habrnal --- libreport.spec | 28 ++++++++++++++++++++++++---- sources | 2 +- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/libreport.spec b/libreport.spec index 28b93a3..0fd468e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -5,11 +5,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.0 -Release: 5%{?dist} +Version: 2.9.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ -Source: https://fedorahosted.org/released/abrt/%{name}-%{version}.tar.gz +Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order @@ -31,7 +31,6 @@ BuildRequires: libxml2-devel BuildRequires: libtar-devel BuildRequires: intltool BuildRequires: libtool -BuildRequires: nss-devel BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto @@ -472,6 +471,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/internal_abrt_dbus.h %{_includedir}/libreport/internal_libreport.h %{_includedir}/libreport/xml_parser.h +%{_includedir}/libreport/helpers %{_libdir}/libreport.so %{_libdir}/libabrt_dbus.so %{_libdir}/pkgconfig/libreport.pc @@ -714,6 +714,26 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Wed Mar 15 2017 Matej Habrnal 2.9.1-1 +- build: do not upload tarball to fedorahosted.org +- spec: do not use fedorahosted.org as source +- build: fix generating list of dependences in autogen.sh +- build: generate new release entries with date +- report-newt: free allocated variables, don't close dd twice +- build: fix scratch-build target +- changelog: reflect the PR +- lib: several bug fixes in parsing of mountinfo +- lib: correctly recognize chroot in container +- lib: declare CONTAINER_ROOTS element name +- lib: add more log wrappers for perror +- reporter-bugzilla: use /etc/os-release for default url +- configure.ac: Remove nss dependency +- spec: include testsuite headers in the devel package +- tests: include testsuite.h in the dist archive +- maint: check pulled .po files for errors +- build: fix bug in changelog generating in release target +- changelog: fix typos + * Fri Feb 10 2017 Fedora Release Engineering - 2.9.0-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild diff --git a/sources b/sources index c42a3c2..b0b969e 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.0.tar.gz) = e53ccdf9bad19a48374b14f1b8057cc3e45af05482950b5c4178bec4b0b3ca8165514ddf89b4fde2b5d20d12d31a2167016b94ca3b76de57414dee0078efc47c +SHA512 (libreport-2.9.1.tar.gz) = 2cffb44fd8da625a9a0613f91ce3d485fe21b0a1f5932f6d6bfbdb4d41337f95c49f525556596aeef2fc3737015151d43250f287dc624f97469f087ff9213bde From 221ea170131bb22329fc88dcaf14eba8eb1d66ab Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Wed, 15 Mar 2017 15:20:27 +0100 Subject: [PATCH 002/133] New upstream release 2.9.1 Signed-off-by: Matej Habrnal --- libreport.spec | 28 ++++++++++++++++++++++++---- sources | 2 +- 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/libreport.spec b/libreport.spec index 28b93a3..0fd468e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -5,11 +5,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.0 -Release: 5%{?dist} +Version: 2.9.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ -Source: https://fedorahosted.org/released/abrt/%{name}-%{version}.tar.gz +Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order @@ -31,7 +31,6 @@ BuildRequires: libxml2-devel BuildRequires: libtar-devel BuildRequires: intltool BuildRequires: libtool -BuildRequires: nss-devel BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto @@ -472,6 +471,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/internal_abrt_dbus.h %{_includedir}/libreport/internal_libreport.h %{_includedir}/libreport/xml_parser.h +%{_includedir}/libreport/helpers %{_libdir}/libreport.so %{_libdir}/libabrt_dbus.so %{_libdir}/pkgconfig/libreport.pc @@ -714,6 +714,26 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Wed Mar 15 2017 Matej Habrnal 2.9.1-1 +- build: do not upload tarball to fedorahosted.org +- spec: do not use fedorahosted.org as source +- build: fix generating list of dependences in autogen.sh +- build: generate new release entries with date +- report-newt: free allocated variables, don't close dd twice +- build: fix scratch-build target +- changelog: reflect the PR +- lib: several bug fixes in parsing of mountinfo +- lib: correctly recognize chroot in container +- lib: declare CONTAINER_ROOTS element name +- lib: add more log wrappers for perror +- reporter-bugzilla: use /etc/os-release for default url +- configure.ac: Remove nss dependency +- spec: include testsuite headers in the devel package +- tests: include testsuite.h in the dist archive +- maint: check pulled .po files for errors +- build: fix bug in changelog generating in release target +- changelog: fix typos + * Fri Feb 10 2017 Fedora Release Engineering - 2.9.0-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild diff --git a/sources b/sources index c42a3c2..b0b969e 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.0.tar.gz) = e53ccdf9bad19a48374b14f1b8057cc3e45af05482950b5c4178bec4b0b3ca8165514ddf89b4fde2b5d20d12d31a2167016b94ca3b76de57414dee0078efc47c +SHA512 (libreport-2.9.1.tar.gz) = 2cffb44fd8da625a9a0613f91ce3d485fe21b0a1f5932f6d6bfbdb4d41337f95c49f525556596aeef2fc3737015151d43250f287dc624f97469f087ff9213bde From 8065018638a29032810f740c8be0bc0e66b3dddb Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Thu, 13 Apr 2017 14:21:58 +0200 Subject: [PATCH 003/133] Fixes and improvements - augeas: trim spaces on eol, around value separator - add journal default entries to reporter-systemd-journal Related to rhbz#1434414 Signed-off-by: Matej Habrnal --- ...spaces-on-eol-around-value-separator.patch | 100 ++++++++++++++++++ ...-journal-add-journal-default-entries.patch | 63 +++++++++++ ...-s-journal-add-count-to-default-logs.patch | 37 +++++++ libreport.spec | 10 +- 4 files changed, 209 insertions(+), 1 deletion(-) create mode 100644 0001-augeas-trim-spaces-on-eol-around-value-separator.patch create mode 100644 0002-reporter-s-journal-add-journal-default-entries.patch create mode 100644 0003-reporter-s-journal-add-count-to-default-logs.patch diff --git a/0001-augeas-trim-spaces-on-eol-around-value-separator.patch b/0001-augeas-trim-spaces-on-eol-around-value-separator.patch new file mode 100644 index 0000000..75e8a49 --- /dev/null +++ b/0001-augeas-trim-spaces-on-eol-around-value-separator.patch @@ -0,0 +1,100 @@ +From bc3149ba31c063d334dd95a21c4214cef11f46da Mon Sep 17 00:00:00 2001 +From: Julius Milan +Date: Wed, 22 Mar 2017 14:10:04 +0100 +Subject: [PATCH] augeas: trim spaces on eol, around value separator + +Resolves abrt/libreport#474 +Related to rhbz#1434414 +--- + augeas/libreport.aug | 19 ++++++++++++------- + augeas/test_libreport.aug | 20 ++++++++++++++++++++ + 2 files changed, 32 insertions(+), 7 deletions(-) + +diff --git a/augeas/libreport.aug b/augeas/libreport.aug +index 483eeaf..46ffb73 100644 +--- a/augeas/libreport.aug ++++ b/augeas/libreport.aug +@@ -2,19 +2,24 @@ module Libreport = + autoload xfm + + (* Define useful primitives *) +- let value_sep = del / ?= ?/ " = " +- let value_to_eol = store /([^ \t\n].*[^ \t\n]|[^ \t\n]?)/ +- let eol = del /\n/ "\n" +- let ident = /[a-zA-Z][a-zA-Z_]+/ ++ let val_sep = del /[ \t]*=[ \t]*/ " = " ++ let val = store /([^ \t\n].*[^ \t\n]|[^ \t\n])/ ++ let eol = del /\n/ "\n" ++ let whitespace_eol = del /[ \t]*\n/ "\n" ++ let ident = /[a-zA-Z][a-zA-Z_]+/ + + (* Define comment *) +- let comment = [ label "#comment" . del /#[ \t]*/ "# " . value_to_eol . eol ] ++ let commented_line = [ label "#comment" . del /#[ \t]*/ "# " . val . eol ] ++ let empty_comment = [ label "#comment" . value "" . del /#[ \t]*/ "# " . eol ] ++ let comment = commented_line | empty_comment + + (* Define empty *) +- let empty = [ del /[ \t]*\n/ "\n" ] ++ let empty = [ del /[ \t]*\n/ "\n" ] + + (* Define option *) +- let option = [ del /[ \t]*/ "" . key ident . value_sep . value_to_eol . eol ] ++ let option_val = [ del /[ \t]*/ "" . key ident . val_sep . val . whitespace_eol ] ++ let option_no_val = [ value "" . del /[ \t]*/ "" . key ident . val_sep . eol ] ++ let option = option_val | option_no_val + + (* Define lens *) + let lns = ( comment | empty | option )* +diff --git a/augeas/test_libreport.aug b/augeas/test_libreport.aug +index 116e97c..3dfbfa6 100644 +--- a/augeas/test_libreport.aug ++++ b/augeas/test_libreport.aug +@@ -16,6 +16,8 @@ Password = + # bugs in selinux-policy component. + # (If you need to add more, the syntax is: \"component[,component...]\") + # ++# ++# + DontMatchComponents = selinux-policy + + # for more info about these settings see: https://github.com/abrt/abrt/wiki/FAQ#creating-private-bugzilla-tickets +@@ -25,6 +27,14 @@ PrivateGroups=private + Whitespace_two=start + Whitespace_three =start + Whitespace_four= start ++ ++AssignmentWhitespace_a =what ++ AssignmentWhitespace_b = an ++AssignmentWhitespace_c= original ++ AssignmentWhitespace_d = idea ++ ++EOLWhitespace_a = nice ++EOLWhitespace_b = nice + " + + test Libreport.lns get conf = +@@ -44,6 +54,8 @@ PrivateGroups=private + { "#comment" = "bugs in selinux-policy component." } + { "#comment" = "(If you need to add more, the syntax is: \"component[,component...]\")" } + { "#comment" = "" } ++ { "#comment" = "" } ++ { "#comment" = "" } + { "DontMatchComponents" = "selinux-policy" } + {} + { "#comment" = "for more info about these settings see: https://github.com/abrt/abrt/wiki/FAQ#creating-private-bugzilla-tickets" } +@@ -53,3 +65,11 @@ PrivateGroups=private + { "Whitespace_two" = "start" } + { "Whitespace_three" = "start" } + { "Whitespace_four" = "start" } ++ {} ++ { "AssignmentWhitespace_a" = "what" } ++ { "AssignmentWhitespace_b" = "an" } ++ { "AssignmentWhitespace_c" = "original" } ++ { "AssignmentWhitespace_d" = "idea" } ++ {} ++ { "EOLWhitespace_a" = "nice" } ++ { "EOLWhitespace_b" = "nice" } +-- +2.9.3 + diff --git a/0002-reporter-s-journal-add-journal-default-entries.patch b/0002-reporter-s-journal-add-journal-default-entries.patch new file mode 100644 index 0000000..745ac09 --- /dev/null +++ b/0002-reporter-s-journal-add-journal-default-entries.patch @@ -0,0 +1,63 @@ +From f97b21d1e1d4bff4e667991997dd78fec3b95159 Mon Sep 17 00:00:00 2001 +From: Matej Habrnal +Date: Tue, 14 Mar 2017 12:55:25 +0100 +Subject: [PATCH] reporter-s-journal: add journal default entries + +This commit adds 3 new fields into journal logs. All of them are in the +NONE dump. + +The new fields are: +PROBLEM_DIR - Represents absolute file system path of problem directory. + The full path is needed because that is the way with which are + problems identified in DBus Problems2API. +PROBLEM_UUID - Represents uuid +PROBLEM_DUPHASH - Represents duphash + +These new fields were needed for ABRT in Cockpit for connecting problems +with journal entries. All three are needed, because the problem directory +might be removed at the time of reading journal but a dupe can be +present there and the dupe can be identified based on DUPHASH or UUID. + +Signed-off-by: Matej Habrnal +--- + src/plugins/reporter-systemd-journal.c | 10 ++++++++++ + 1 file changed, 10 insertions(+) + +diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c +index 8df5ac7..957002b 100644 +--- a/src/plugins/reporter-systemd-journal.c ++++ b/src/plugins/reporter-systemd-journal.c +@@ -102,6 +102,7 @@ static void msg_content_free(msg_content_t *msg_c) + #define BINARY_NAME "binary" + #define SYSLOG_ID "SYSLOG_IDENTIFIER" + #define MESSAGE_ID "MESSAGE_ID" ++#define DUMPDIR_PATH "DIR" + + enum { + DUMP_NONE = 1 << 0, +@@ -122,6 +123,9 @@ static const char *const fields_default[] = { + FILENAME_EXCEPTION_TYPE , + FILENAME_REASON , + FILENAME_CRASH_FUNCTION , ++ DUMPDIR_PATH , ++ FILENAME_UUID , ++ FILENAME_DUPHASH , + NULL + }; + +@@ -302,6 +306,12 @@ int main(int argc, char **argv) + if (binary_name) + problem_data_add_text_noteditable(problem_data, BINARY_NAME, binary_name); + ++ /* add problem dir path into problem data */ ++ char *abspath = realpath(dump_dir_name, NULL); ++ if (abspath) ++ problem_data_add_text_noteditable(problem_data, DUMPDIR_PATH, abspath); ++ free(abspath); ++ + /* crash_function element is neeeded by systemd journal messages, save ??, if it doesn't exist */ + const char *crash_function = problem_data_get_content_or_NULL(problem_data, FILENAME_CRASH_FUNCTION); + if (!crash_function) +-- +2.9.3 + diff --git a/0003-reporter-s-journal-add-count-to-default-logs.patch b/0003-reporter-s-journal-add-count-to-default-logs.patch new file mode 100644 index 0000000..f969d50 --- /dev/null +++ b/0003-reporter-s-journal-add-count-to-default-logs.patch @@ -0,0 +1,37 @@ +From d2b5f09e2757f2585eb1003fdf6db43e58013c19 Mon Sep 17 00:00:00 2001 +From: Matej Marusak +Date: Tue, 21 Mar 2017 09:04:38 +0100 +Subject: [PATCH] reporter-s-journal: add count to default logs + +Field count is available only in FULL dump. There are however two good +reasons why to include this in NONE dump. + +1. It is quite useful to know if this problem occurred first time or is it +problem that happens a lot. + +2. We need it for cockpit integration. If the problem happened more times it +will have multiple logs. By comparing count in the log and real count, we can +know, if this is the last log of the problem. (timestamps do not work ideally +for this, since the time of problem does not equal to the time of the +log - there is some delay) + +Signed-off-by: Matej Marusak +--- + src/plugins/reporter-systemd-journal.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c +index 957002b..d12296e 100644 +--- a/src/plugins/reporter-systemd-journal.c ++++ b/src/plugins/reporter-systemd-journal.c +@@ -126,6 +126,7 @@ static const char *const fields_default[] = { + DUMPDIR_PATH , + FILENAME_UUID , + FILENAME_DUPHASH , ++ FILENAME_COUNT , + NULL + }; + +-- +2.9.3 + diff --git a/libreport.spec b/libreport.spec index 0fd468e..bced734 100644 --- a/libreport.spec +++ b/libreport.spec @@ -6,7 +6,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -14,6 +14,9 @@ Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done +Patch0000: 0001-augeas-trim-spaces-on-eol-around-value-separator.patch +Patch0001: 0002-reporter-s-journal-add-journal-default-entries.patch +Patch0002: 0003-reporter-s-journal-add-count-to-default-logs.patch # git is need for '%%autosetup -S git' which automatically applies all the # patches above. Please, be aware that the patches must be generated @@ -714,6 +717,11 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Thu Apr 13 2017 Matej Habrnal 2.9.1-2 +- add journal default entries to reporter-systemd-journal +- augeas: trim spaces on eol, around value separator +- Resolves: #1434414 + * Wed Mar 15 2017 Matej Habrnal 2.9.1-1 - build: do not upload tarball to fedorahosted.org - spec: do not use fedorahosted.org as source From b730895e1c6c071a493aad90d0b3967ad078e0f3 Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Thu, 13 Apr 2017 14:21:58 +0200 Subject: [PATCH 004/133] Fixes and improvements - augeas: trim spaces on eol, around value separator - add journal default entries to reporter-systemd-journal Signed-off-by: Matej Habrnal --- ...spaces-on-eol-around-value-separator.patch | 100 ++++++++++++++++++ ...-journal-add-journal-default-entries.patch | 63 +++++++++++ ...-s-journal-add-count-to-default-logs.patch | 37 +++++++ libreport.spec | 10 +- 4 files changed, 209 insertions(+), 1 deletion(-) create mode 100644 0001-augeas-trim-spaces-on-eol-around-value-separator.patch create mode 100644 0002-reporter-s-journal-add-journal-default-entries.patch create mode 100644 0003-reporter-s-journal-add-count-to-default-logs.patch diff --git a/0001-augeas-trim-spaces-on-eol-around-value-separator.patch b/0001-augeas-trim-spaces-on-eol-around-value-separator.patch new file mode 100644 index 0000000..75e8a49 --- /dev/null +++ b/0001-augeas-trim-spaces-on-eol-around-value-separator.patch @@ -0,0 +1,100 @@ +From bc3149ba31c063d334dd95a21c4214cef11f46da Mon Sep 17 00:00:00 2001 +From: Julius Milan +Date: Wed, 22 Mar 2017 14:10:04 +0100 +Subject: [PATCH] augeas: trim spaces on eol, around value separator + +Resolves abrt/libreport#474 +Related to rhbz#1434414 +--- + augeas/libreport.aug | 19 ++++++++++++------- + augeas/test_libreport.aug | 20 ++++++++++++++++++++ + 2 files changed, 32 insertions(+), 7 deletions(-) + +diff --git a/augeas/libreport.aug b/augeas/libreport.aug +index 483eeaf..46ffb73 100644 +--- a/augeas/libreport.aug ++++ b/augeas/libreport.aug +@@ -2,19 +2,24 @@ module Libreport = + autoload xfm + + (* Define useful primitives *) +- let value_sep = del / ?= ?/ " = " +- let value_to_eol = store /([^ \t\n].*[^ \t\n]|[^ \t\n]?)/ +- let eol = del /\n/ "\n" +- let ident = /[a-zA-Z][a-zA-Z_]+/ ++ let val_sep = del /[ \t]*=[ \t]*/ " = " ++ let val = store /([^ \t\n].*[^ \t\n]|[^ \t\n])/ ++ let eol = del /\n/ "\n" ++ let whitespace_eol = del /[ \t]*\n/ "\n" ++ let ident = /[a-zA-Z][a-zA-Z_]+/ + + (* Define comment *) +- let comment = [ label "#comment" . del /#[ \t]*/ "# " . value_to_eol . eol ] ++ let commented_line = [ label "#comment" . del /#[ \t]*/ "# " . val . eol ] ++ let empty_comment = [ label "#comment" . value "" . del /#[ \t]*/ "# " . eol ] ++ let comment = commented_line | empty_comment + + (* Define empty *) +- let empty = [ del /[ \t]*\n/ "\n" ] ++ let empty = [ del /[ \t]*\n/ "\n" ] + + (* Define option *) +- let option = [ del /[ \t]*/ "" . key ident . value_sep . value_to_eol . eol ] ++ let option_val = [ del /[ \t]*/ "" . key ident . val_sep . val . whitespace_eol ] ++ let option_no_val = [ value "" . del /[ \t]*/ "" . key ident . val_sep . eol ] ++ let option = option_val | option_no_val + + (* Define lens *) + let lns = ( comment | empty | option )* +diff --git a/augeas/test_libreport.aug b/augeas/test_libreport.aug +index 116e97c..3dfbfa6 100644 +--- a/augeas/test_libreport.aug ++++ b/augeas/test_libreport.aug +@@ -16,6 +16,8 @@ Password = + # bugs in selinux-policy component. + # (If you need to add more, the syntax is: \"component[,component...]\") + # ++# ++# + DontMatchComponents = selinux-policy + + # for more info about these settings see: https://github.com/abrt/abrt/wiki/FAQ#creating-private-bugzilla-tickets +@@ -25,6 +27,14 @@ PrivateGroups=private + Whitespace_two=start + Whitespace_three =start + Whitespace_four= start ++ ++AssignmentWhitespace_a =what ++ AssignmentWhitespace_b = an ++AssignmentWhitespace_c= original ++ AssignmentWhitespace_d = idea ++ ++EOLWhitespace_a = nice ++EOLWhitespace_b = nice + " + + test Libreport.lns get conf = +@@ -44,6 +54,8 @@ PrivateGroups=private + { "#comment" = "bugs in selinux-policy component." } + { "#comment" = "(If you need to add more, the syntax is: \"component[,component...]\")" } + { "#comment" = "" } ++ { "#comment" = "" } ++ { "#comment" = "" } + { "DontMatchComponents" = "selinux-policy" } + {} + { "#comment" = "for more info about these settings see: https://github.com/abrt/abrt/wiki/FAQ#creating-private-bugzilla-tickets" } +@@ -53,3 +65,11 @@ PrivateGroups=private + { "Whitespace_two" = "start" } + { "Whitespace_three" = "start" } + { "Whitespace_four" = "start" } ++ {} ++ { "AssignmentWhitespace_a" = "what" } ++ { "AssignmentWhitespace_b" = "an" } ++ { "AssignmentWhitespace_c" = "original" } ++ { "AssignmentWhitespace_d" = "idea" } ++ {} ++ { "EOLWhitespace_a" = "nice" } ++ { "EOLWhitespace_b" = "nice" } +-- +2.9.3 + diff --git a/0002-reporter-s-journal-add-journal-default-entries.patch b/0002-reporter-s-journal-add-journal-default-entries.patch new file mode 100644 index 0000000..745ac09 --- /dev/null +++ b/0002-reporter-s-journal-add-journal-default-entries.patch @@ -0,0 +1,63 @@ +From f97b21d1e1d4bff4e667991997dd78fec3b95159 Mon Sep 17 00:00:00 2001 +From: Matej Habrnal +Date: Tue, 14 Mar 2017 12:55:25 +0100 +Subject: [PATCH] reporter-s-journal: add journal default entries + +This commit adds 3 new fields into journal logs. All of them are in the +NONE dump. + +The new fields are: +PROBLEM_DIR - Represents absolute file system path of problem directory. + The full path is needed because that is the way with which are + problems identified in DBus Problems2API. +PROBLEM_UUID - Represents uuid +PROBLEM_DUPHASH - Represents duphash + +These new fields were needed for ABRT in Cockpit for connecting problems +with journal entries. All three are needed, because the problem directory +might be removed at the time of reading journal but a dupe can be +present there and the dupe can be identified based on DUPHASH or UUID. + +Signed-off-by: Matej Habrnal +--- + src/plugins/reporter-systemd-journal.c | 10 ++++++++++ + 1 file changed, 10 insertions(+) + +diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c +index 8df5ac7..957002b 100644 +--- a/src/plugins/reporter-systemd-journal.c ++++ b/src/plugins/reporter-systemd-journal.c +@@ -102,6 +102,7 @@ static void msg_content_free(msg_content_t *msg_c) + #define BINARY_NAME "binary" + #define SYSLOG_ID "SYSLOG_IDENTIFIER" + #define MESSAGE_ID "MESSAGE_ID" ++#define DUMPDIR_PATH "DIR" + + enum { + DUMP_NONE = 1 << 0, +@@ -122,6 +123,9 @@ static const char *const fields_default[] = { + FILENAME_EXCEPTION_TYPE , + FILENAME_REASON , + FILENAME_CRASH_FUNCTION , ++ DUMPDIR_PATH , ++ FILENAME_UUID , ++ FILENAME_DUPHASH , + NULL + }; + +@@ -302,6 +306,12 @@ int main(int argc, char **argv) + if (binary_name) + problem_data_add_text_noteditable(problem_data, BINARY_NAME, binary_name); + ++ /* add problem dir path into problem data */ ++ char *abspath = realpath(dump_dir_name, NULL); ++ if (abspath) ++ problem_data_add_text_noteditable(problem_data, DUMPDIR_PATH, abspath); ++ free(abspath); ++ + /* crash_function element is neeeded by systemd journal messages, save ??, if it doesn't exist */ + const char *crash_function = problem_data_get_content_or_NULL(problem_data, FILENAME_CRASH_FUNCTION); + if (!crash_function) +-- +2.9.3 + diff --git a/0003-reporter-s-journal-add-count-to-default-logs.patch b/0003-reporter-s-journal-add-count-to-default-logs.patch new file mode 100644 index 0000000..f969d50 --- /dev/null +++ b/0003-reporter-s-journal-add-count-to-default-logs.patch @@ -0,0 +1,37 @@ +From d2b5f09e2757f2585eb1003fdf6db43e58013c19 Mon Sep 17 00:00:00 2001 +From: Matej Marusak +Date: Tue, 21 Mar 2017 09:04:38 +0100 +Subject: [PATCH] reporter-s-journal: add count to default logs + +Field count is available only in FULL dump. There are however two good +reasons why to include this in NONE dump. + +1. It is quite useful to know if this problem occurred first time or is it +problem that happens a lot. + +2. We need it for cockpit integration. If the problem happened more times it +will have multiple logs. By comparing count in the log and real count, we can +know, if this is the last log of the problem. (timestamps do not work ideally +for this, since the time of problem does not equal to the time of the +log - there is some delay) + +Signed-off-by: Matej Marusak +--- + src/plugins/reporter-systemd-journal.c | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c +index 957002b..d12296e 100644 +--- a/src/plugins/reporter-systemd-journal.c ++++ b/src/plugins/reporter-systemd-journal.c +@@ -126,6 +126,7 @@ static const char *const fields_default[] = { + DUMPDIR_PATH , + FILENAME_UUID , + FILENAME_DUPHASH , ++ FILENAME_COUNT , + NULL + }; + +-- +2.9.3 + diff --git a/libreport.spec b/libreport.spec index 0fd468e..bced734 100644 --- a/libreport.spec +++ b/libreport.spec @@ -6,7 +6,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -14,6 +14,9 @@ Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done +Patch0000: 0001-augeas-trim-spaces-on-eol-around-value-separator.patch +Patch0001: 0002-reporter-s-journal-add-journal-default-entries.patch +Patch0002: 0003-reporter-s-journal-add-count-to-default-logs.patch # git is need for '%%autosetup -S git' which automatically applies all the # patches above. Please, be aware that the patches must be generated @@ -714,6 +717,11 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Thu Apr 13 2017 Matej Habrnal 2.9.1-2 +- add journal default entries to reporter-systemd-journal +- augeas: trim spaces on eol, around value separator +- Resolves: #1434414 + * Wed Mar 15 2017 Matej Habrnal 2.9.1-1 - build: do not upload tarball to fedorahosted.org - spec: do not use fedorahosted.org as source From 3aa06e31171b8ebba678ef930f40bf70016e6176 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0abata?= Date: Mon, 12 Jun 2017 16:58:09 +0200 Subject: [PATCH 005/133] Weaken the python3 bindings base package dependency for modular builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Different parts of libreports are built and shipped with different modules in F26 Boltron, namely modules/shared-userspace and modules/dnf. This allows libreport-python3 from modules/dnf work with libreport from modules/shared-userspace even though they have different dist tags. This only affects modularity builds and shouldn't be needed beyond F26 Boltron. Signed-off-by: Petr Šabata --- libreport.spec | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libreport.spec b/libreport.spec index bced734..e68b9a8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -49,6 +49,12 @@ BuildRequires: augeas-devel BuildRequires: augeas BuildRequires: xz BuildRequires: lz4 + +# Required for the temporary modularity hack, see below +%if 0%{?_module_build} +BuildRequires: sed +%endif + Requires: libreport-filesystem = %{version}-%{release} Requires: satyr >= %{satyr_ver} Requires: xz @@ -103,7 +109,17 @@ Python bindings for report-libs. %package python3 Summary: Python 3 bindings for report-libs +%if 0%{?_module_build} +# This is required for F26 Boltron (the modular release) +# Different parts of libreport are shipped with different +# modules with different dist tags; we need to weaken the +# strict NVR dependency to make it work. Temporary and +# limited to F26 Boltron. +%global distfreerelease %(echo %{release}|sed 's/%{?dist}$//'||echo 0) +Requires: libreport >= %{version}-%{distfreerelease} +%else Requires: libreport = %{version}-%{release} +%endif Requires: dnf %description python3 From ea83325b231f64c575ea104bb698e9d43b80469a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20=C5=A0abata?= Date: Mon, 12 Jun 2017 16:58:09 +0200 Subject: [PATCH 006/133] Weaken the python3 bindings base package dependency for modular builds MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Different parts of libreports are built and shipped with different modules in F26 Boltron, namely modules/shared-userspace and modules/dnf. This allows libreport-python3 from modules/dnf work with libreport from modules/shared-userspace even though they have different dist tags. This only affects modularity builds and shouldn't be needed beyond F26 Boltron. Signed-off-by: Petr Šabata --- libreport.spec | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/libreport.spec b/libreport.spec index bced734..e68b9a8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -49,6 +49,12 @@ BuildRequires: augeas-devel BuildRequires: augeas BuildRequires: xz BuildRequires: lz4 + +# Required for the temporary modularity hack, see below +%if 0%{?_module_build} +BuildRequires: sed +%endif + Requires: libreport-filesystem = %{version}-%{release} Requires: satyr >= %{satyr_ver} Requires: xz @@ -103,7 +109,17 @@ Python bindings for report-libs. %package python3 Summary: Python 3 bindings for report-libs +%if 0%{?_module_build} +# This is required for F26 Boltron (the modular release) +# Different parts of libreport are shipped with different +# modules with different dist tags; we need to weaken the +# strict NVR dependency to make it work. Temporary and +# limited to F26 Boltron. +%global distfreerelease %(echo %{release}|sed 's/%{?dist}$//'||echo 0) +Requires: libreport >= %{version}-%{distfreerelease} +%else Requires: libreport = %{version}-%{release} +%endif Requires: dnf %description python3 From 86ed6a73566efbefdd231db80897d674a3a3a67c Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 26 Jul 2017 19:38:51 +0000 Subject: [PATCH 007/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index e68b9a8..4158bf9 100644 --- a/libreport.spec +++ b/libreport.spec @@ -6,7 +6,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -733,6 +733,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Wed Jul 26 2017 Fedora Release Engineering - 2.9.1-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild + * Thu Apr 13 2017 Matej Habrnal 2.9.1-2 - add journal default entries to reporter-systemd-journal - augeas: trim spaces on eol, around value separator From dc86ec51dddc2045f8ddfe398e50d06cf5409ca0 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 3 Aug 2017 02:11:51 +0000 Subject: [PATCH 008/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 4158bf9..09e0440 100644 --- a/libreport.spec +++ b/libreport.spec @@ -6,7 +6,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -733,6 +733,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Thu Aug 03 2017 Fedora Release Engineering - 2.9.1-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild + * Wed Jul 26 2017 Fedora Release Engineering - 2.9.1-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild From 85752376cb8a823d28c843115a093c446e999f6f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Sat, 19 Aug 2017 09:38:39 -0400 Subject: [PATCH 009/133] Python 2 binary package renamed to python2-libreport --- libreport.spec | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libreport.spec b/libreport.spec index 09e0440..2ddb6d6 100644 --- a/libreport.spec +++ b/libreport.spec @@ -6,7 +6,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 4%{?dist} +Release: 5%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -91,7 +91,11 @@ Requires: libreport-web = %{version}-%{release} %description web-devel Development headers for libreport-web -%package python +%package -n python2-libreport +%{?python_provide:%python_provide python2-libreport} +# Remove before F30 +Provides: %{name}-python%{?_isa} = %{version}-%{release} +Obsoletes: %{name}-python < %{version}-%{release} Summary: Python bindings for report-libs # Is group correct here? - Requires: libreport = %{version}-%{release} @@ -104,7 +108,7 @@ Obsoletes: report < 0:0.23-1 Requires: libreport-plugin-rhtsupport = %{version}-%{release} %endif -%description python +%description -n python2-libreport Python bindings for report-libs. %package python3 @@ -504,7 +508,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/libreport_curl.h %{_libdir}/pkgconfig/libreport-web.pc -%files python +%files -n python2-libreport %{python_sitearch}/report/* %{python_sitearch}/reportclient/* @@ -733,6 +737,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek - 2.9.1-5 +- Python 2 binary package renamed to python2-libreport + See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 + * Thu Aug 03 2017 Fedora Release Engineering - 2.9.1-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild From 292f3030702b9cbd6c50a4d574ed016908aef45d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Sat, 19 Aug 2017 19:08:59 -0400 Subject: [PATCH 010/133] Python 3 binary package renamed to python3-libreport --- libreport.spec | 26 ++++++++++++++++++-------- 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/libreport.spec b/libreport.spec index 2ddb6d6..569eaea 100644 --- a/libreport.spec +++ b/libreport.spec @@ -6,7 +6,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -92,10 +92,6 @@ Requires: libreport-web = %{version}-%{release} Development headers for libreport-web %package -n python2-libreport -%{?python_provide:%python_provide python2-libreport} -# Remove before F30 -Provides: %{name}-python%{?_isa} = %{version}-%{release} -Obsoletes: %{name}-python < %{version}-%{release} Summary: Python bindings for report-libs # Is group correct here? - Requires: libreport = %{version}-%{release} @@ -107,11 +103,16 @@ Obsoletes: report < 0:0.23-1 %if 0%{?rhel} == 6 Requires: libreport-plugin-rhtsupport = %{version}-%{release} %endif +%{?python_provide:%python_provide python2-libreport} +# Remove before F30 +Provides: %{name}-python = %{version}-%{release} +Provides: %{name}-python%{?_isa} = %{version}-%{release} +Obsoletes: %{name}-python < %{version}-%{release} %description -n python2-libreport Python bindings for report-libs. -%package python3 +%package -n python3-libreport Summary: Python 3 bindings for report-libs %if 0%{?_module_build} # This is required for F26 Boltron (the modular release) @@ -125,8 +126,13 @@ Requires: libreport >= %{version}-%{distfreerelease} Requires: libreport = %{version}-%{release} %endif Requires: dnf +%{?python_provide:%python_provide python3-libreport} +# Remove before F30 +Provides: %{name}-python3 = %{version}-%{release} +Provides: %{name}-python3%{?_isa} = %{version}-%{release} +Obsoletes: %{name}-python3 < %{version}-%{release} -%description python3 +%description -n python3-libreport Python 3 bindings for report-libs. %package cli @@ -512,7 +518,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{python_sitearch}/report/* %{python_sitearch}/reportclient/* -%files python3 +%files -n python3-libreport %{python3_sitearch}/report/* %{python3_sitearch}/reportclient/* @@ -737,6 +743,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek - 2.9.1-6 +- Python 3 binary package renamed to python3-libreport +- Missing Provides wihtout %%_isa added in python 2 binary package + * Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek - 2.9.1-5 - Python 2 binary package renamed to python2-libreport See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 From e84543384fa16437be2b9c9a01e9bd66f386398e Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Fri, 25 Aug 2017 13:59:18 +0200 Subject: [PATCH 011/133] New upstream release 2.9.2 Signed-off-by: Matej Habrnal --- ...spaces-on-eol-around-value-separator.patch | 100 ------------------ ...-journal-add-journal-default-entries.patch | 63 ----------- ...-s-journal-add-count-to-default-logs.patch | 37 ------- libreport.spec | 27 +++-- sources | 2 +- 5 files changed, 22 insertions(+), 207 deletions(-) delete mode 100644 0001-augeas-trim-spaces-on-eol-around-value-separator.patch delete mode 100644 0002-reporter-s-journal-add-journal-default-entries.patch delete mode 100644 0003-reporter-s-journal-add-count-to-default-logs.patch diff --git a/0001-augeas-trim-spaces-on-eol-around-value-separator.patch b/0001-augeas-trim-spaces-on-eol-around-value-separator.patch deleted file mode 100644 index 75e8a49..0000000 --- a/0001-augeas-trim-spaces-on-eol-around-value-separator.patch +++ /dev/null @@ -1,100 +0,0 @@ -From bc3149ba31c063d334dd95a21c4214cef11f46da Mon Sep 17 00:00:00 2001 -From: Julius Milan -Date: Wed, 22 Mar 2017 14:10:04 +0100 -Subject: [PATCH] augeas: trim spaces on eol, around value separator - -Resolves abrt/libreport#474 -Related to rhbz#1434414 ---- - augeas/libreport.aug | 19 ++++++++++++------- - augeas/test_libreport.aug | 20 ++++++++++++++++++++ - 2 files changed, 32 insertions(+), 7 deletions(-) - -diff --git a/augeas/libreport.aug b/augeas/libreport.aug -index 483eeaf..46ffb73 100644 ---- a/augeas/libreport.aug -+++ b/augeas/libreport.aug -@@ -2,19 +2,24 @@ module Libreport = - autoload xfm - - (* Define useful primitives *) -- let value_sep = del / ?= ?/ " = " -- let value_to_eol = store /([^ \t\n].*[^ \t\n]|[^ \t\n]?)/ -- let eol = del /\n/ "\n" -- let ident = /[a-zA-Z][a-zA-Z_]+/ -+ let val_sep = del /[ \t]*=[ \t]*/ " = " -+ let val = store /([^ \t\n].*[^ \t\n]|[^ \t\n])/ -+ let eol = del /\n/ "\n" -+ let whitespace_eol = del /[ \t]*\n/ "\n" -+ let ident = /[a-zA-Z][a-zA-Z_]+/ - - (* Define comment *) -- let comment = [ label "#comment" . del /#[ \t]*/ "# " . value_to_eol . eol ] -+ let commented_line = [ label "#comment" . del /#[ \t]*/ "# " . val . eol ] -+ let empty_comment = [ label "#comment" . value "" . del /#[ \t]*/ "# " . eol ] -+ let comment = commented_line | empty_comment - - (* Define empty *) -- let empty = [ del /[ \t]*\n/ "\n" ] -+ let empty = [ del /[ \t]*\n/ "\n" ] - - (* Define option *) -- let option = [ del /[ \t]*/ "" . key ident . value_sep . value_to_eol . eol ] -+ let option_val = [ del /[ \t]*/ "" . key ident . val_sep . val . whitespace_eol ] -+ let option_no_val = [ value "" . del /[ \t]*/ "" . key ident . val_sep . eol ] -+ let option = option_val | option_no_val - - (* Define lens *) - let lns = ( comment | empty | option )* -diff --git a/augeas/test_libreport.aug b/augeas/test_libreport.aug -index 116e97c..3dfbfa6 100644 ---- a/augeas/test_libreport.aug -+++ b/augeas/test_libreport.aug -@@ -16,6 +16,8 @@ Password = - # bugs in selinux-policy component. - # (If you need to add more, the syntax is: \"component[,component...]\") - # -+# -+# - DontMatchComponents = selinux-policy - - # for more info about these settings see: https://github.com/abrt/abrt/wiki/FAQ#creating-private-bugzilla-tickets -@@ -25,6 +27,14 @@ PrivateGroups=private - Whitespace_two=start - Whitespace_three =start - Whitespace_four= start -+ -+AssignmentWhitespace_a =what -+ AssignmentWhitespace_b = an -+AssignmentWhitespace_c= original -+ AssignmentWhitespace_d = idea -+ -+EOLWhitespace_a = nice -+EOLWhitespace_b = nice - " - - test Libreport.lns get conf = -@@ -44,6 +54,8 @@ PrivateGroups=private - { "#comment" = "bugs in selinux-policy component." } - { "#comment" = "(If you need to add more, the syntax is: \"component[,component...]\")" } - { "#comment" = "" } -+ { "#comment" = "" } -+ { "#comment" = "" } - { "DontMatchComponents" = "selinux-policy" } - {} - { "#comment" = "for more info about these settings see: https://github.com/abrt/abrt/wiki/FAQ#creating-private-bugzilla-tickets" } -@@ -53,3 +65,11 @@ PrivateGroups=private - { "Whitespace_two" = "start" } - { "Whitespace_three" = "start" } - { "Whitespace_four" = "start" } -+ {} -+ { "AssignmentWhitespace_a" = "what" } -+ { "AssignmentWhitespace_b" = "an" } -+ { "AssignmentWhitespace_c" = "original" } -+ { "AssignmentWhitespace_d" = "idea" } -+ {} -+ { "EOLWhitespace_a" = "nice" } -+ { "EOLWhitespace_b" = "nice" } --- -2.9.3 - diff --git a/0002-reporter-s-journal-add-journal-default-entries.patch b/0002-reporter-s-journal-add-journal-default-entries.patch deleted file mode 100644 index 745ac09..0000000 --- a/0002-reporter-s-journal-add-journal-default-entries.patch +++ /dev/null @@ -1,63 +0,0 @@ -From f97b21d1e1d4bff4e667991997dd78fec3b95159 Mon Sep 17 00:00:00 2001 -From: Matej Habrnal -Date: Tue, 14 Mar 2017 12:55:25 +0100 -Subject: [PATCH] reporter-s-journal: add journal default entries - -This commit adds 3 new fields into journal logs. All of them are in the -NONE dump. - -The new fields are: -PROBLEM_DIR - Represents absolute file system path of problem directory. - The full path is needed because that is the way with which are - problems identified in DBus Problems2API. -PROBLEM_UUID - Represents uuid -PROBLEM_DUPHASH - Represents duphash - -These new fields were needed for ABRT in Cockpit for connecting problems -with journal entries. All three are needed, because the problem directory -might be removed at the time of reading journal but a dupe can be -present there and the dupe can be identified based on DUPHASH or UUID. - -Signed-off-by: Matej Habrnal ---- - src/plugins/reporter-systemd-journal.c | 10 ++++++++++ - 1 file changed, 10 insertions(+) - -diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c -index 8df5ac7..957002b 100644 ---- a/src/plugins/reporter-systemd-journal.c -+++ b/src/plugins/reporter-systemd-journal.c -@@ -102,6 +102,7 @@ static void msg_content_free(msg_content_t *msg_c) - #define BINARY_NAME "binary" - #define SYSLOG_ID "SYSLOG_IDENTIFIER" - #define MESSAGE_ID "MESSAGE_ID" -+#define DUMPDIR_PATH "DIR" - - enum { - DUMP_NONE = 1 << 0, -@@ -122,6 +123,9 @@ static const char *const fields_default[] = { - FILENAME_EXCEPTION_TYPE , - FILENAME_REASON , - FILENAME_CRASH_FUNCTION , -+ DUMPDIR_PATH , -+ FILENAME_UUID , -+ FILENAME_DUPHASH , - NULL - }; - -@@ -302,6 +306,12 @@ int main(int argc, char **argv) - if (binary_name) - problem_data_add_text_noteditable(problem_data, BINARY_NAME, binary_name); - -+ /* add problem dir path into problem data */ -+ char *abspath = realpath(dump_dir_name, NULL); -+ if (abspath) -+ problem_data_add_text_noteditable(problem_data, DUMPDIR_PATH, abspath); -+ free(abspath); -+ - /* crash_function element is neeeded by systemd journal messages, save ??, if it doesn't exist */ - const char *crash_function = problem_data_get_content_or_NULL(problem_data, FILENAME_CRASH_FUNCTION); - if (!crash_function) --- -2.9.3 - diff --git a/0003-reporter-s-journal-add-count-to-default-logs.patch b/0003-reporter-s-journal-add-count-to-default-logs.patch deleted file mode 100644 index f969d50..0000000 --- a/0003-reporter-s-journal-add-count-to-default-logs.patch +++ /dev/null @@ -1,37 +0,0 @@ -From d2b5f09e2757f2585eb1003fdf6db43e58013c19 Mon Sep 17 00:00:00 2001 -From: Matej Marusak -Date: Tue, 21 Mar 2017 09:04:38 +0100 -Subject: [PATCH] reporter-s-journal: add count to default logs - -Field count is available only in FULL dump. There are however two good -reasons why to include this in NONE dump. - -1. It is quite useful to know if this problem occurred first time or is it -problem that happens a lot. - -2. We need it for cockpit integration. If the problem happened more times it -will have multiple logs. By comparing count in the log and real count, we can -know, if this is the last log of the problem. (timestamps do not work ideally -for this, since the time of problem does not equal to the time of the -log - there is some delay) - -Signed-off-by: Matej Marusak ---- - src/plugins/reporter-systemd-journal.c | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c -index 957002b..d12296e 100644 ---- a/src/plugins/reporter-systemd-journal.c -+++ b/src/plugins/reporter-systemd-journal.c -@@ -126,6 +126,7 @@ static const char *const fields_default[] = { - DUMPDIR_PATH , - FILENAME_UUID , - FILENAME_DUPHASH , -+ FILENAME_COUNT , - NULL - }; - --- -2.9.3 - diff --git a/libreport.spec b/libreport.spec index 569eaea..0332686 100644 --- a/libreport.spec +++ b/libreport.spec @@ -2,11 +2,12 @@ %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %define satyr_ver 0.22 +%define glib_ver 2.43 Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.1 -Release: 6%{?dist} +Version: 2.9.2 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -14,9 +15,6 @@ Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done -Patch0000: 0001-augeas-trim-spaces-on-eol-around-value-separator.patch -Patch0001: 0002-reporter-s-journal-add-journal-default-entries.patch -Patch0002: 0003-reporter-s-journal-add-count-to-default-logs.patch # git is need for '%%autosetup -S git' which automatically applies all the # patches above. Please, be aware that the patches must be generated @@ -40,6 +38,7 @@ BuildRequires: xmlto BuildRequires: newt-devel BuildRequires: libproxy-devel BuildRequires: satyr-devel >= %{satyr_ver} +BuildRequires: glib2-devel >= %{glib_ver} BuildRequires: glibc-all-langpacks BuildRequires: xmlrpc-c-devel @@ -57,6 +56,7 @@ BuildRequires: sed Requires: libreport-filesystem = %{version}-%{release} Requires: satyr >= %{satyr_ver} +Requires: glib2 >= %{glib_ver} Requires: xz Requires: lz4 @@ -451,7 +451,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %files -f %{name}.lang %defattr(-,root,root,-) -%doc README +%doc README.md %license COPYING %config(noreplace) %{_sysconfdir}/%{name}/libreport.conf %config(noreplace) %{_sysconfdir}/%{name}/report_event.conf @@ -743,6 +743,21 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Fri Aug 25 2017 Matej Habrnal 2.9.2-1 +- Translation updates +- logging: rename log() to log_warning() +- reporter-mantisbt: Fix typo in help +- bugzilla: add check if option -d was entered +- dd: extend create_dump_dir to allow set pid in dumpdir name +- wizard: replace deprecated gtk3 functions +- lib: replace hash table with list +- fix newline issue with ask_password +- lib: make cpuinfo files user editable +- reporter-s-journal: add count to default logs +- augeas: trim spaces on eol, around value separator +- reporter-s-journal: add journal default entries +- Resolves: #1481205 + * Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek - 2.9.1-6 - Python 3 binary package renamed to python3-libreport - Missing Provides wihtout %%_isa added in python 2 binary package diff --git a/sources b/sources index b0b969e..8a41c1d 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.1.tar.gz) = 2cffb44fd8da625a9a0613f91ce3d485fe21b0a1f5932f6d6bfbdb4d41337f95c49f525556596aeef2fc3737015151d43250f287dc624f97469f087ff9213bde +SHA512 (libreport-2.9.2.tar.gz) = 2438a9f994a66d2f207d421ddc7bc45be5a803e5527967d8a79a06a5361e935caa106f69883b822664175df561a39bed33a744590bd9341173802972ab942085 From ce22458aef075959aaf89ade2ea23ec46901783d Mon Sep 17 00:00:00 2001 From: Julius Milan Date: Thu, 31 Aug 2017 14:28:26 +0200 Subject: [PATCH 012/133] Fixes and improvements - logging: rename log() to log_warning() - reporter-mantisbt: Fix typo in help - bugzilla: add check if option -d was entered - dd: extend create_dump_dir to allow set pid in dumpdir name - lib: fix to ensure order of login credentials when reporting using abrt-cli - configure.ac: update glib min. version dependency - lib: fix newline issue with ask_password --- ...-fix-newline-issue-with-ask_password.patch | 297 ++++ ...-update-glib-min.-version-dependency.patch | 26 + 0006-lib-replace-hash-table-with-list.patch | 401 +++++ ..._dump_dir-to-allow-set-pid-in-dumpdi.patch | 63 + 0008-augeas-exclude-format-files.patch | 25 + ...la-add-check-if-option-d-was-entered.patch | 66 + 0010-reporter-mantisbt-Fix-typo-in-help.patch | 26 + 0011-logging-rename-log-to-log_warning.patch | 1366 +++++++++++++++++ libreport.spec | 24 +- 9 files changed, 2292 insertions(+), 2 deletions(-) create mode 100644 0004-lib-fix-newline-issue-with-ask_password.patch create mode 100644 0005-configure.ac-update-glib-min.-version-dependency.patch create mode 100644 0006-lib-replace-hash-table-with-list.patch create mode 100644 0007-dd-extend-create_dump_dir-to-allow-set-pid-in-dumpdi.patch create mode 100644 0008-augeas-exclude-format-files.patch create mode 100644 0009-bugzilla-add-check-if-option-d-was-entered.patch create mode 100644 0010-reporter-mantisbt-Fix-typo-in-help.patch create mode 100644 0011-logging-rename-log-to-log_warning.patch diff --git a/0004-lib-fix-newline-issue-with-ask_password.patch b/0004-lib-fix-newline-issue-with-ask_password.patch new file mode 100644 index 0000000..09ec8de --- /dev/null +++ b/0004-lib-fix-newline-issue-with-ask_password.patch @@ -0,0 +1,297 @@ +From 45a5ca011bd0a402cd55bbca950634280e152dea Mon Sep 17 00:00:00 2001 +From: Martin Kutlak +Date: Fri, 7 Apr 2017 10:49:51 +0200 +Subject: [PATCH 04/14] lib: fix newline issue with ask_password + +The newline wasn't printed out because printing characters in terminal was +disabled (ECHO flag unset). After 'ask_password' function call, there would +have to be print function to create newline, otherwise the next message +would show up in the same line. + +ECHONL flag allows to print newline character even if the ECHO flag is disabled. + +Logic for the changes of the flags follows: +Change ECHO flag only when: + - ECHO is set (0) and there was no change (0) previously. + OR + - ECHO is unset (1) and there was a change (1) previously. + +Change ECHONL flag only when: + - ECHONL is unset (1) and there was no change (0) previously. + OR + - ECHONL is set (0) and there was a change (1) previously. + +Also ECHONL needs ICANON flag to be set (It is set by default). + +Signed-off-by: Martin Kutlak +--- + configure.ac | 4 ++ + src/cli/cli-report.c | 3 - + src/lib/client.c | 18 ++++- + src/plugins/reporter-mantisbt.c | 2 - + tests/Makefile.am | 3 +- + tests/client.at | 152 ++++++++++++++++++++++++++++++++++++++++ + tests/testsuite.at | 1 + + 7 files changed, 174 insertions(+), 9 deletions(-) + create mode 100644 tests/client.at + +diff --git a/configure.ac b/configure.ac +index ccefe50..c8745f8 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -239,6 +239,10 @@ PKG_CHECK_MODULES([AUGEAS], [augeas]) + #PKG_CHECK_MODULES([LZ4], [liblz4]) + + ++AC_SEARCH_LIBS([forkpty], [util]) ++AC_REPLACE_FUNCS([forkpty]) ++ ++ + AC_ARG_WITH(newt, + AS_HELP_STRING([--with-newt],[use newt (default is YES)]), + LIBREPORT_PARSE_WITH([newt])) +diff --git a/src/cli/cli-report.c b/src/cli/cli-report.c +index c83dc20..537b194 100644 +--- a/src/cli/cli-report.c ++++ b/src/cli/cli-report.c +@@ -442,9 +442,6 @@ static void ask_for_missing_settings(const char *event_name) + case OPTION_TYPE_PASSWORD: + { + opt->eo_value = ask_password(question); +- /* Newline was not added by pressing Enter because ECHO was +- disabled, so add it now. */ +- puts(""); + break; + } + case OPTION_TYPE_BOOL: +diff --git a/src/lib/client.c b/src/lib/client.c +index 811f33e..8a4e2ad 100644 +--- a/src/lib/client.c ++++ b/src/lib/client.c +@@ -34,14 +34,26 @@ static int is_noninteractive_mode() + int set_echo(int enable) + { + struct termios t; ++ int chvalue = 0; + if (tcgetattr(STDIN_FILENO, &t) < 0) + return 0; + +- /* No change needed? */ +- if (!(t.c_lflag & ECHO) == !enable) ++ /* ECHO flag change if needed */ ++ if ((!(t.c_lflag & ECHO)) == enable) ++ { ++ t.c_lflag ^= ECHO; ++ chvalue = 1; ++ } ++ /* ECHONL flag change if needed */ ++ if ((!(t.c_lflag & ECHONL)) != enable) ++ { ++ t.c_lflag ^= ECHONL; ++ chvalue = 1; ++ } ++ ++ if (!chvalue) + return 0; + +- t.c_lflag ^= ECHO; + if (tcsetattr(STDIN_FILENO, TCSANOW, &t) < 0) + perror_msg_and_die("tcsetattr"); + +diff --git a/src/plugins/reporter-mantisbt.c b/src/plugins/reporter-mantisbt.c +index 5062d32..622af87 100644 +--- a/src/plugins/reporter-mantisbt.c ++++ b/src/plugins/reporter-mantisbt.c +@@ -62,8 +62,6 @@ static char * + ask_mantisbt_password(const char *message) + { + char *password = ask_password(message); +- /* TODO: this should be fixed in ask_password() as other tools have the same problem */ +- putchar('\n'); + if (password == NULL || password[0] == '\0') + { + set_xfunc_error_retval(EXIT_CANCEL_BY_USER); +diff --git a/tests/Makefile.am b/tests/Makefile.am +index df19403..2b8972d 100644 +--- a/tests/Makefile.am ++++ b/tests/Makefile.am +@@ -59,7 +59,8 @@ TESTSUITE_AT = \ + event_config.at \ + proc_helpers.at \ + compress.at \ +- forbidden_words.at ++ forbidden_words.at \ ++ client.at + + TESTSUITE_AT_IN = \ + bugzilla_plugin.at +diff --git a/tests/client.at b/tests/client.at +new file mode 100644 +index 0000000..b643789 +--- /dev/null ++++ b/tests/client.at +@@ -0,0 +1,152 @@ ++# -*- Autotest -*- ++ ++AT_BANNER([Client]) ++ ++## ---------------- ## ++## set_echo ## ++## ---------------- ## ++ ++AT_TESTFUN([set_echo], ++[[ ++#include ++#include "client.h" ++#include "internal_libreport.h" ++#include ++ ++#define ECHO_TEST (!(new_mode.c_lflag & ECHO)) ++#define ECHONL_TEST (!(new_mode.c_lflag & ECHONL)) ++ ++int main (void) ++{ ++ int master_pty; ++ ++ pid_t pid = forkpty(&master_pty, NULL, NULL, NULL); ++ if (pid < 0) { ++ perror_msg_and_die("forkpty failed."); ++ } ++ ++ if (pid == 0) { ++ int check, result, changed; ++ struct termios old_mode, new_mode; ++ assert(isatty(STDIN_FILENO) == 1); ++ ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(check == 0); ++ old_mode = new_mode; ++ ++ new_mode.c_lflag |= ECHO; ++ new_mode.c_lflag &= ~(ECHONL); ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 0; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(check == 0); ++ assert(result != changed); ++ assert(ECHO_TEST == 1); ++ assert(ECHONL_TEST == 0); ++ ++ changed = 1; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(check == 0); ++ assert(result == changed); ++ assert(ECHO_TEST == 0); ++ assert(ECHONL_TEST == 1); ++ ++ new_mode.c_lflag &= ~(ECHO); ++ new_mode.c_lflag |= ECHONL; ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 0; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(result == changed); ++ assert(ECHO_TEST == 1); ++ assert(ECHONL_TEST == 0); ++ ++ new_mode.c_lflag |= ECHO; ++ new_mode.c_lflag &= ~(ECHONL); ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 1; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(result != changed); ++ assert(ECHO_TEST == 0); ++ assert(ECHONL_TEST == 1); ++ ++ new_mode.c_lflag &= ~(ECHO | ECHONL); ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 0; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(result != changed); ++ assert(ECHO_TEST == 1); ++ assert(ECHONL_TEST == 0); ++ ++ new_mode.c_lflag &= ~(ECHO | ECHONL); ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 1; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(check == 0); ++ assert(result == changed); ++ assert(ECHO_TEST == 0); ++ assert(ECHONL_TEST == 1); ++ ++ new_mode.c_lflag |= (ECHO | ECHONL); ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 0; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(check == 0); ++ assert(result != changed); ++ assert(ECHO_TEST == 1); ++ assert(ECHONL_TEST == 0); ++ ++ new_mode.c_lflag |= (ECHO | ECHONL); ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &new_mode); ++ assert(check == 0); ++ ++ changed = 1; ++ result = set_echo(changed); ++ check = tcgetattr(STDIN_FILENO, &new_mode); ++ assert(check == 0); ++ assert(result == changed); ++ assert(ECHO_TEST == 0); ++ assert(ECHONL_TEST == 1); ++ ++ check = tcsetattr(STDIN_FILENO, TCSANOW, &old_mode); ++ assert(check == 0); ++ ++ return 0; ++ } ++ ++ int status; ++ if (safe_waitpid(pid, &status, 0) < 0) { ++ perror_msg_and_die("waitpid failed."); ++ } ++ ++ if (WIFEXITED(status)) { ++ return WEXITSTATUS(status); ++ } ++ else if (WIFSIGNALED(status)) { ++ error_msg_and_die("Killed by signal %d.", WTERMSIG(status)); ++ } ++ else { ++ error_msg_and_die("Test unexpectedly stopped/continued."); ++ } ++ ++ return 0; ++} ++]]) +diff --git a/tests/testsuite.at b/tests/testsuite.at +index a0865b2..45ff6da 100644 +--- a/tests/testsuite.at ++++ b/tests/testsuite.at +@@ -30,3 +30,4 @@ m4_include([bugzilla_plugin.at]) + m4_include([proc_helpers.at]) + m4_include([compress.at]) + m4_include([forbidden_words.at]) ++m4_include([client.at]) +-- +2.9.5 + diff --git a/0005-configure.ac-update-glib-min.-version-dependency.patch b/0005-configure.ac-update-glib-min.-version-dependency.patch new file mode 100644 index 0000000..5d30420 --- /dev/null +++ b/0005-configure.ac-update-glib-min.-version-dependency.patch @@ -0,0 +1,26 @@ +From 864b391f904963296b59fc26142f0dc8b5f34833 Mon Sep 17 00:00:00 2001 +From: Julius Milan +Date: Wed, 26 Apr 2017 11:07:09 +0200 +Subject: [PATCH 05/14] configure.ac: update glib min. version dependency + +Related to rhbz#1445669 +--- + configure.ac | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/configure.ac b/configure.ac +index c8745f8..15c743f 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -224,7 +224,7 @@ AC_SUBST(PYTHON3_LIBS) + AC_SUBST(python3dir, $PYTHON3_DIR) + AC_SUBST(py3execdir, $PYTHON3_EXECDIR) + +-PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.21]) ++PKG_CHECK_MODULES([GLIB], [glib-2.0 >= 2.43]) + PKG_CHECK_MODULES([GOBJECT], [gobject-2.0]) + PKG_CHECK_MODULES([DBUS], [dbus-1]) + PKG_CHECK_MODULES([LIBXML], [libxml-2.0]) +-- +2.9.5 + diff --git a/0006-lib-replace-hash-table-with-list.patch b/0006-lib-replace-hash-table-with-list.patch new file mode 100644 index 0000000..1e578a7 --- /dev/null +++ b/0006-lib-replace-hash-table-with-list.patch @@ -0,0 +1,401 @@ +From f183ccbe0f6e954ec2c9d0e1a1296ac54ff637e5 Mon Sep 17 00:00:00 2001 +From: Martin Kutlak +Date: Tue, 25 Apr 2017 18:20:08 +0200 +Subject: [PATCH 08/14] lib: replace hash table with list + +Order of login credentials wasn't guaranteed, because event options with missing +values were inserted into hash table and then extracted from it. + +I renamed function validate_event as its name was a little bit confusing. The function +returns options that are missing input values and error message should be displayed. + +This fixes abrt/abrt#1231 + +Signed-off-by: Martin Kutlak +--- + src/cli/cli-report.c | 32 ++++++------- + src/gui-wizard-gtk/wizard.c | 4 +- + src/include/event_config.h | 15 +++++- + src/lib/event_config.c | 36 +++++++++++---- + src/report-newt/report-newt.c | 25 +++++----- + tests/event_config.at | 103 ++++++++++++++++++++++++++++++++++++++++++ + 6 files changed, 173 insertions(+), 42 deletions(-) + +diff --git a/src/cli/cli-report.c b/src/cli/cli-report.c +index 537b194..fd14888 100644 +--- a/src/cli/cli-report.c ++++ b/src/cli/cli-report.c +@@ -414,19 +414,17 @@ static void ask_for_missing_settings(const char *event_name) + { + for (int i = 0; i < 3; ++i) + { +- GHashTable *error_table = validate_event(event_name); +- if (!error_table) ++ GList *err_list = NULL, *iter = NULL; ++ err_list = get_options_with_err_msg(event_name); ++ if(!err_list) + return; + + event_config_t *event_config = get_event_config(event_name); + +- GHashTableIter iter; +- char *opt_name, *err_msg; +- g_hash_table_iter_init(&iter, error_table); +- while (g_hash_table_iter_next(&iter, (void**)&opt_name, (void**)&err_msg)) ++ for (iter = err_list; iter; iter = iter->next) + { +- event_option_t *opt = get_event_option_from_list(opt_name, +- event_config->options); ++ invalid_option_t *err_data = (invalid_option_t *)iter->data; ++ event_option_t *opt = get_event_option_from_list(err_data->invopt_name, event_config->options); + + free(opt->eo_value); + opt->eo_value = NULL; +@@ -459,25 +457,27 @@ static void ask_for_missing_settings(const char *event_name) + free(question); + } + +- g_hash_table_destroy(error_table); ++ g_list_free_full(err_list, (GDestroyNotify)free_invalid_options); + +- error_table = validate_event(event_name); +- if (!error_table) ++ err_list = get_options_with_err_msg(event_name); ++ if (!err_list) + return; + + alert(_("Your input is not valid, because of:")); +- g_hash_table_iter_init(&iter, error_table); +- while (g_hash_table_iter_next(&iter, (void**)&opt_name, (void**)&err_msg)) ++ for (iter = err_list; iter; iter = iter -> next) + { +- char *msg = xasprintf(_("Bad value for '%s': %s"), opt_name, err_msg); ++ invalid_option_t *err_data = (invalid_option_t *)iter->data; ++ char *msg = xasprintf(_("Bad value for '%s': %s"), ++ err_data->invopt_name, ++ err_data->invopt_error); + alert(msg); + free(msg); + } + +- g_hash_table_destroy(error_table); ++ g_list_free_full(err_list, (GDestroyNotify)free_invalid_options); + } + +- /* we ask for 3 times and still don't have valid infromation */ ++ /* we ask for 3 times and still don't have valid information */ + error_msg_and_die("Invalid input, exiting."); + } + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index c7136d6..d337805 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -914,10 +914,10 @@ static gint find_by_button(gconstpointer a, gconstpointer button) + + static void check_event_config(const char *event_name) + { +- GHashTable *errors = validate_event(event_name); ++ GList *errors = get_options_with_err_msg(event_name); + if (errors != NULL) + { +- g_hash_table_unref(errors); ++ g_list_free_full(errors, (GDestroyNotify)free_invalid_options); + show_event_config_dialog(event_name, GTK_WINDOW(g_top_most_window)); + update_private_ticket_creation_warning_for_selected_event(); + } +diff --git a/src/include/event_config.h b/src/include/event_config.h +index fdcb3b4..0e0df98 100644 +--- a/src/include/event_config.h ++++ b/src/include/event_config.h +@@ -63,6 +63,17 @@ typedef struct + bool is_advanced; + } event_option_t; + ++/* ++ * struct holds ++ * invopt_name = name of the option with invalid value ++ * invopt_error = string of the error message ++ */ ++typedef struct ++{ ++ char *invopt_name; ++ char *invopt_error; ++} invalid_option_t; ++ + event_option_t *new_event_option(void); + void free_event_option(event_option_t *p); + +@@ -108,6 +119,8 @@ bool ec_restricted_access_enabled(event_config_t *ec); + + void free_event_config(event_config_t *p); + ++invalid_option_t *new_invalid_option(void); ++void free_invalid_options(invalid_option_t* p); + + void load_event_description_from_file(event_config_t *event_config, const char* filename); + +@@ -126,7 +139,7 @@ extern GHashTable *g_event_config_list; // for iterating through entire list o + GList *export_event_config(const char *event_name); + void unexport_event_config(GList *env_list); + +-GHashTable *validate_event(const char *event_name); ++GList *get_options_with_err_msg(const char *event_name); + + /* + * Checks usability of problem's backtrace rating against required rating level +diff --git a/src/lib/event_config.c b/src/lib/event_config.c +index 9c58d00..c5b7b17 100644 +--- a/src/lib/event_config.c ++++ b/src/lib/event_config.c +@@ -22,6 +22,11 @@ + GHashTable *g_event_config_list; + static GHashTable *g_event_config_symlinks; + ++invalid_option_t *new_invalid_option(void) ++{ ++ return xzalloc(sizeof(invalid_option_t)); ++} ++ + event_option_t *new_event_option(void) + { + return xzalloc(sizeof(event_option_t)); +@@ -121,6 +126,15 @@ bool ec_restricted_access_enabled(event_config_t *ec) + return eo->eo_value != NULL && string_to_bool(eo->eo_value); + } + ++void free_invalid_options(invalid_option_t *p) ++{ ++ if (!p) ++ return; ++ free(p->invopt_name); ++ free(p->invopt_error); ++ free(p); ++} ++ + void free_event_option(event_option_t *p) + { + if (!p) +@@ -427,7 +441,7 @@ static char *validate_event_option(event_option_t *opt) + return NULL; + } + +-GHashTable *validate_event(const char *event_name) ++GList *get_options_with_err_msg(const char *event_name) + { + INITIALIZE_LIBREPORT(); + +@@ -435,21 +449,23 @@ GHashTable *validate_event(const char *event_name) + if (!config) + return NULL; + +- GHashTable *errors = g_hash_table_new_full(g_str_hash, g_str_equal, free, free); +- GList *li; ++ GList *iter, *err_list = NULL; + +- for (li = config->options; li; li = li->next) ++ for (iter = config->options; iter; iter = iter->next) + { +- event_option_t *opt = (event_option_t *)li->data; ++ event_option_t *opt = (event_option_t *)iter->data; + char *err = validate_event_option(opt); + if (err) +- g_hash_table_insert(errors, xstrdup(opt->eo_name), err); ++ { ++ invalid_option_t *inv_opt = new_invalid_option(); ++ inv_opt->invopt_name = xstrdup(opt->eo_name); ++ inv_opt->invopt_error = xstrdup(err); ++ err_list = g_list_prepend(err_list, inv_opt); ++ } + } + +- if (g_hash_table_size(errors)) +- return errors; +- +- g_hash_table_destroy(errors); ++ if (err_list != NULL) ++ return g_list_reverse(err_list); + + return NULL; + } +diff --git a/src/report-newt/report-newt.c b/src/report-newt/report-newt.c +index 2427d86..61e279d 100644 +--- a/src/report-newt/report-newt.c ++++ b/src/report-newt/report-newt.c +@@ -93,15 +93,14 @@ static int select_reporters(GArray *reporters) + + static int configure_reporter(struct reporter *r, bool skip_if_valid) + { +- GHashTable *error_table; +- GList *option; ++ GList *error_list, *option; + event_option_t *opt; + bool first = true, cancel = false; + int num_opts, i; + newtComponent text, *options, button_ok, button_cancel, form; + newtGrid grid, ogrid, bgrid; + +- while ((error_table = validate_event(r->name)) || ++ while ((error_list = get_options_with_err_msg(r->name)) || + (!skip_if_valid && first && r->config)) + { + text = newtTextboxReflowed(0, 0, ec_get_screen_name(r->config) ? +@@ -151,19 +150,19 @@ static int configure_reporter(struct reporter *r, bool skip_if_valid) + form = newtForm(NULL, NULL, 0); + newtGridAddComponentsToForm(grid, form, 1); + +- if (!first && error_table) ++ if (!first && error_list) + { +- GHashTableIter iter; +- char *opt_name, *err_msg, buf[4096]; ++ GList *iter; ++ char buf[4096]; + + /* Catenate the error messages */ + buf[0] = '\0'; +- for (g_hash_table_iter_init(&iter, error_table); +- g_hash_table_iter_next(&iter, (void**)&opt_name, (void**)&err_msg); ) ++ for (iter = error_list; iter; iter = iter->next) + { +- opt = get_event_option_from_list(opt_name, r->config->options); ++ invalid_option_t *inv_data = (invalid_option_t *)iter->data; ++ opt = get_event_option_from_list(inv_data->invopt_name, r->config->options); + snprintf(buf + strlen(buf), sizeof (buf) - strlen(buf), "%s: %s\n", +- opt->eo_label ? opt->eo_label : opt->eo_name, err_msg); ++ opt->eo_label ? opt->eo_label : opt->eo_name, inv_data->invopt_error); + } + + newtWinMessage(_("Error"), _("Ok"), buf); +@@ -201,14 +200,14 @@ static int configure_reporter(struct reporter *r, bool skip_if_valid) + + free(options); + +- if (error_table) +- g_hash_table_destroy(error_table); ++ if (error_list) ++ g_list_free_full(error_list,(GDestroyNotify)free_invalid_options); + if (cancel) + break; + first = false; + } + +- return !error_table; ++ return !error_list; + } + + struct log { +diff --git a/tests/event_config.at b/tests/event_config.at +index 5baf000..badca73 100644 +--- a/tests/event_config.at ++++ b/tests/event_config.at +@@ -58,3 +58,106 @@ TS_MAIN + } + TS_RETURN_MAIN + ]]) ++ ++## ------------------------ ## ++## get_options_with_err_msg ## ++## ------------------------ ## ++ ++AT_TESTFUN([get_options_with_err_msg], [[ ++#include "testsuite.h" ++#include "internal_libreport.h" ++ ++event_option_t* create_new_option(const char *n, const char *v, option_type_t t, int ae) ++{ ++ event_option_t *op = new_event_option(); ++ op->eo_name = xstrdup(n); ++ op->eo_value = NULL; ++ if(v != NULL) ++ op->eo_value = xstrdup(v); ++ ++ op->eo_type = t; ++ op->eo_allow_empty = ae; ++ ++ return op; ++} ++ ++TS_MAIN ++{ ++ GList *errors = NULL, *iter = NULL; ++ invalid_option_t *e_op; ++ ++ if (!g_event_config_list) ++ g_event_config_list = g_hash_table_new_full( ++ g_str_hash, g_str_equal, free, (GDestroyNotify) free_event_config ++ ); ++ ++ { ++ event_config_t *evnt = new_event_config("Bugster0"); ++ event_option_t *opt_login = create_new_option("Bugtest_Login", NULL, OPTION_TYPE_TEXT, 0); ++ event_option_t *opt_passwd = create_new_option("Bugtest_Password", NULL, OPTION_TYPE_PASSWORD, 0); ++ event_option_t *opt_url = create_new_option("Bugtest_URL", "bug.test", OPTION_TYPE_TEXT, 0); ++ ++ evnt->options = g_list_append(evnt->options, opt_login); ++ evnt->options = g_list_append(evnt->options, opt_passwd); ++ evnt->options = g_list_append(evnt->options, opt_url); ++ g_hash_table_insert(g_event_config_list, xstrdup("Bugster0"), evnt); ++ ++ errors = get_options_with_err_msg("Bugster0"); ++ e_op = (invalid_option_t *)errors->data; ++ ++ TS_ASSERT_STRING_EQ(e_op->invopt_name, "Bugtest_Login", "Show login first"); ++ ++ iter = g_list_next(errors); ++ e_op = (invalid_option_t *)iter->data; ++ ++ TS_ASSERT_STRING_EQ(e_op->invopt_name, "Bugtest_Password", "Show password second"); ++ TS_ASSERT_PTR_IS_NULL(g_list_next(iter)); ++ ++ g_list_free_full(errors, (GDestroyNotify)free_invalid_options); ++ } ++ ++ { ++ event_config_t *evnt = new_event_config("Bugster1"); ++ event_option_t *opt_login = create_new_option("Bugtest_Login", NULL, OPTION_TYPE_TEXT, 0); ++ event_option_t *opt_passwd = create_new_option("Bugtest_Password", NULL, OPTION_TYPE_PASSWORD, 0); ++ event_option_t *opt_url = create_new_option("Bugtest_URL", "bug.test", OPTION_TYPE_TEXT, 0); ++ ++ evnt->options = g_list_append(evnt->options, opt_passwd); ++ evnt->options = g_list_append(evnt->options, opt_login); ++ evnt->options = g_list_append(evnt->options, opt_url); ++ g_hash_table_insert(g_event_config_list, xstrdup("Bugster1"), evnt); ++ ++ errors = get_options_with_err_msg("Bugster1"); ++ e_op = (invalid_option_t *)errors->data; ++ ++ TS_ASSERT_STRING_EQ(e_op->invopt_name, "Bugtest_Password", "Show password first"); ++ ++ iter = g_list_next(errors); ++ e_op = (invalid_option_t *)iter->data; ++ ++ TS_ASSERT_STRING_EQ(e_op->invopt_name, "Bugtest_Login", "Show login second"); ++ TS_ASSERT_PTR_IS_NULL(g_list_next(iter)); ++ ++ g_list_free_full(errors, (GDestroyNotify)free_invalid_options); ++ } ++ ++ { ++ event_config_t *evnt = new_event_config("Bugster2"); ++ event_option_t *opt_login = create_new_option("Bugtest_Login", "login", OPTION_TYPE_TEXT, 0); ++ event_option_t *opt_passwd = create_new_option("Bugtest_Password", "password", OPTION_TYPE_PASSWORD, 0); ++ event_option_t *opt_url = create_new_option("Bugtest_URL", "bug.test", OPTION_TYPE_TEXT, 0); ++ ++ evnt->options = g_list_append(evnt->options, opt_login); ++ evnt->options = g_list_append(evnt->options, opt_passwd); ++ evnt->options = g_list_append(evnt->options, opt_url); ++ g_hash_table_insert(g_event_config_list, xstrdup("Bugster2"), evnt); ++ ++ errors = get_options_with_err_msg("Bugster2"); ++ ++ TS_ASSERT_PTR_IS_NULL(errors); ++ } ++ ++ free_event_config_data(); ++} ++TS_RETURN_MAIN ++]]) +-- +2.9.5 + diff --git a/0007-dd-extend-create_dump_dir-to-allow-set-pid-in-dumpdi.patch b/0007-dd-extend-create_dump_dir-to-allow-set-pid-in-dumpdi.patch new file mode 100644 index 0000000..8dca206 --- /dev/null +++ b/0007-dd-extend-create_dump_dir-to-allow-set-pid-in-dumpdi.patch @@ -0,0 +1,63 @@ +From 52bc62513f23a7a379ba48dc2895626cf842bb1a Mon Sep 17 00:00:00 2001 +From: Matej Habrnal +Date: Thu, 15 Jun 2017 17:12:53 +0200 +Subject: [PATCH 10/14] dd: extend create_dump_dir to allow set pid in dumpdir + name + +Signed-off-by: Matej Habrnal +--- + src/include/dump_dir.h | 3 +++ + src/lib/create_dump_dir.c | 9 +++++++-- + 2 files changed, 10 insertions(+), 2 deletions(-) + +diff --git a/src/include/dump_dir.h b/src/include/dump_dir.h +index fb3a470..793caf4 100644 +--- a/src/include/dump_dir.h ++++ b/src/include/dump_dir.h +@@ -486,6 +486,9 @@ typedef int (*save_data_call_back)(struct dump_dir *, void *args); + struct dump_dir *create_dump_dir(const char *base_dir_name, const char *type, + uid_t uid, save_data_call_back save_data, void *args); + ++struct dump_dir *create_dump_dir_ext(const char *base_dir_name, const char *type, ++ pid_t pid, uid_t uid, save_data_call_back save_data, void *args); ++ + /* Creates a new archive from the dump directory contents + * + * The dd argument must be opened for reading. +diff --git a/src/lib/create_dump_dir.c b/src/lib/create_dump_dir.c +index 1c6f1fc..d690c78 100644 +--- a/src/lib/create_dump_dir.c ++++ b/src/lib/create_dump_dir.c +@@ -42,7 +42,7 @@ static struct dump_dir *try_dd_create(const char *base_dir_name, const char *dir + return dd; + } + +-struct dump_dir *create_dump_dir(const char *base_dir_name, const char *type, uid_t uid, save_data_call_back save_data, void *args) ++struct dump_dir *create_dump_dir_ext(const char *base_dir_name, const char *type, pid_t pid, uid_t uid, save_data_call_back save_data, void *args) + { + INITIALIZE_LIBREPORT(); + +@@ -59,7 +59,7 @@ struct dump_dir *create_dump_dir(const char *base_dir_name, const char *type, ui + return NULL; + } + +- char *problem_id = xasprintf("%s-%s.%ld-%lu"NEW_PD_SUFFIX, type, iso_date_string(&(tv.tv_sec)), (long)tv.tv_usec, (long)getpid()); ++ char *problem_id = xasprintf("%s-%s.%ld-%lu"NEW_PD_SUFFIX, type, iso_date_string(&(tv.tv_sec)), (long)tv.tv_usec, (long)pid); + + log_info("Saving to %s/%s with uid %d", base_dir_name, problem_id, uid); + +@@ -151,6 +151,11 @@ struct dump_dir *create_dump_dir(const char *base_dir_name, const char *type, ui + return dd; + } + ++struct dump_dir *create_dump_dir(const char *base_dir_name, const char *type, uid_t uid, save_data_call_back save_data, void *args) ++{ ++ return create_dump_dir_ext(base_dir_name, type, getpid(), uid, save_data, args); ++} ++ + int save_problem_data_in_dump_dir(struct dump_dir *dd, problem_data_t *problem_data) + { + INITIALIZE_LIBREPORT(); +-- +2.9.5 + diff --git a/0008-augeas-exclude-format-files.patch b/0008-augeas-exclude-format-files.patch new file mode 100644 index 0000000..2701067 --- /dev/null +++ b/0008-augeas-exclude-format-files.patch @@ -0,0 +1,25 @@ +From d58bbe86686b3a601211f1f6a0186c73a6afc999 Mon Sep 17 00:00:00 2001 +From: Martin Kutlak +Date: Tue, 20 Jun 2017 16:05:58 +0200 +Subject: [PATCH 11/14] augeas: exclude format files + +Signed-off-by: Martin Kutlak +--- + augeas/libreport.aug | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/augeas/libreport.aug b/augeas/libreport.aug +index 46ffb73..dd4252e 100644 +--- a/augeas/libreport.aug ++++ b/augeas/libreport.aug +@@ -31,6 +31,7 @@ module Libreport = + . (incl (Sys.getenv("HOME") . "/.cache/abrt/events/*")) + . (excl "/etc/libreport/plugins/bugzilla_format*") + . (excl "/etc/libreport/plugins/mantisbt_format*") ++ . (excl "/etc/libreport/plugins/catalog*") + . Util.stdexcl + + let xfm = transform lns filter +-- +2.9.5 + diff --git a/0009-bugzilla-add-check-if-option-d-was-entered.patch b/0009-bugzilla-add-check-if-option-d-was-entered.patch new file mode 100644 index 0000000..a198795 --- /dev/null +++ b/0009-bugzilla-add-check-if-option-d-was-entered.patch @@ -0,0 +1,66 @@ +From a6522407b95cf1410ecb33cbf2adff3a3998f686 Mon Sep 17 00:00:00 2001 +From: Martin Kutlak +Date: Thu, 29 Jun 2017 12:10:25 +0200 +Subject: [PATCH 12/14] bugzilla: add check if option -d was entered + +The change from commit 946c522ba702c11b7b336552461747541e714bb7 caused that reporter was ALWAYS trying to read +from problem directory. And because the default value for it is set to ".", +running reporter from outside of problem directory caused errors. + +Signed-off-by: Martin Kutlak +--- + src/plugins/reporter-bugzilla.c | 29 +++++++++++++++++++---------- + 1 file changed, 19 insertions(+), 10 deletions(-) + +diff --git a/src/plugins/reporter-bugzilla.c b/src/plugins/reporter-bugzilla.c +index 7b7fd22..5364cd4 100644 +--- a/src/plugins/reporter-bugzilla.c ++++ b/src/plugins/reporter-bugzilla.c +@@ -334,18 +334,21 @@ int main(int argc, char **argv) + export_abrt_envvars(0); + + map_string_t *settings = new_map_string(); +- problem_data_t *problem_data; ++ problem_data_t *problem_data = NULL; + +- /* pull in some defaults from os-release */ +- problem_data = create_problem_data_for_reporting(dump_dir_name); +- if (!problem_data) +- xfunc_die(); /* create_problem_data_for_reporting already emitted error msg */ +- else ++ if (opts & OPT_d) + { +- map_string_t *osinfo = new_map_string(); +- problem_data_get_osinfo(problem_data, osinfo); +- set_default_settings(osinfo, settings); +- free_map_string(osinfo); ++ /* pull in some defaults from os-release */ ++ problem_data = create_problem_data_for_reporting(dump_dir_name); ++ if (!problem_data) ++ xfunc_die(); /* create_problem_data_for_reporting already emitted error msg */ ++ else ++ { ++ map_string_t *osinfo = new_map_string(); ++ problem_data_get_osinfo(problem_data, osinfo); ++ set_default_settings(osinfo, settings); ++ free_map_string(osinfo); ++ } + } + + { +@@ -554,6 +557,12 @@ int main(int argc, char **argv) + free_report_result(reported_to); + } + ++ if (!(opts & OPT_d)) ++ problem_data = create_problem_data_for_reporting(dump_dir_name); ++ ++ if (!problem_data) ++ xfunc_die(); /* create_problem_data_for_reporting already emitted error msg */ ++ + const char *component = problem_data_get_content_or_die(problem_data, FILENAME_COMPONENT); + const char *duphash = problem_data_get_content_or_NULL(problem_data, FILENAME_DUPHASH); + //COMPAT, remove after 2.1 release +-- +2.9.5 + diff --git a/0010-reporter-mantisbt-Fix-typo-in-help.patch b/0010-reporter-mantisbt-Fix-typo-in-help.patch new file mode 100644 index 0000000..331578f --- /dev/null +++ b/0010-reporter-mantisbt-Fix-typo-in-help.patch @@ -0,0 +1,26 @@ +From f15195d7c317a94405b33102b36e1a8d7dcb214b Mon Sep 17 00:00:00 2001 +From: Matej Marusak +Date: Fri, 14 Jul 2017 08:24:35 +0200 +Subject: [PATCH 13/14] reporter-mantisbt: Fix typo in help + +Signed-off-by: Matej Marusak +--- + src/plugins/reporter-mantisbt.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/plugins/reporter-mantisbt.c b/src/plugins/reporter-mantisbt.c +index 622af87..3705bc7 100644 +--- a/src/plugins/reporter-mantisbt.c ++++ b/src/plugins/reporter-mantisbt.c +@@ -243,7 +243,7 @@ int main(int argc, char **argv) + "\nTRACKER_NAME to URL field. This option is applied only when a new issue is to be" + "\nfiled. The default value is 'ABRT Server'" + "\n" +- "\nIf not specified, CONFFILE defaults to "CONF_DIR"/plugins/mantisb.conf" ++ "\nIf not specified, CONFFILE defaults to "CONF_DIR"/plugins/mantisbt.conf" + "\nIts lines should have 'PARAM = VALUE' format." + "\nRecognized string parameters: MantisbtURL, Login, Password, Project, ProjectVersion." + "\nRecognized boolean parameter (VALUE should be 1/0, yes/no): SSLVerify, CreatePrivate." +-- +2.9.5 + diff --git a/0011-logging-rename-log-to-log_warning.patch b/0011-logging-rename-log-to-log_warning.patch new file mode 100644 index 0000000..af9fa3c --- /dev/null +++ b/0011-logging-rename-log-to-log_warning.patch @@ -0,0 +1,1366 @@ +From 3244d3b944961e5be92bfa98d9ab5da014e6fa22 Mon Sep 17 00:00:00 2001 +From: Matej Habrnal +Date: Tue, 22 Aug 2017 17:06:12 +0200 +Subject: [PATCH 14/14] logging: rename log() to log_warning() + +Renaming log() logging function to log_warning() because +of conflict with log() function from math.h. + +Related to #1481205 + +Signed-off-by: Matej Habrnal +--- + src/client-python/reportclient/__init__.py | 2 +- + src/gtk-helpers/config_dialog.c | 4 +-- + src/gtk-helpers/event_config_dialog.c | 2 +- + src/gtk-helpers/problem_details_widget.c | 4 +-- + src/gtk-helpers/secrets.c | 2 +- + src/gui-wizard-gtk/main.c | 2 +- + src/gui-wizard-gtk/wizard.c | 26 +++++++++--------- + src/include/internal_libreport.h | 10 +++---- + src/lib/abrt_dbus.c | 4 +-- + src/lib/copy_file_recursive.c | 2 +- + src/lib/curl.c | 20 +++++++------- + src/lib/dump_dir.c | 6 ++-- + src/lib/event_config.c | 4 +-- + src/lib/event_xml_parser.c | 8 +++--- + src/lib/glib_support.c | 2 +- + src/lib/parse_options.c | 2 +- + src/lib/problem_data.c | 6 ++-- + src/lib/problem_report.c | 8 +++--- + src/lib/run_event.c | 8 +++--- + src/lib/steal_directory.c | 2 +- + src/lib/workflow_xml_parser.c | 2 +- + src/plugins/mantisbt.c | 2 +- + src/plugins/reporter-bugzilla.c | 36 ++++++++++++------------ + src/plugins/reporter-kerneloops.c | 6 ++-- + src/plugins/reporter-mailx.c | 10 +++---- + src/plugins/reporter-mantisbt.c | 26 +++++++++--------- + src/plugins/reporter-print.c | 2 +- + src/plugins/reporter-rhtsupport-parse.c | 2 +- + src/plugins/reporter-rhtsupport.c | 44 +++++++++++++++--------------- + src/plugins/reporter-systemd-journal.c | 2 +- + src/plugins/reporter-upload.c | 4 +-- + src/plugins/reporter-ureport.c | 4 +-- + src/plugins/rhbz.c | 8 +++--- + tests/glib_helpers.at | 8 +++--- + tests/osrelease.at | 24 ++++++++-------- + 35 files changed, 152 insertions(+), 152 deletions(-) + +diff --git a/src/client-python/reportclient/__init__.py b/src/client-python/reportclient/__init__.py +index ac5ce47..2721f1f 100644 +--- a/src/client-python/reportclient/__init__.py ++++ b/src/client-python/reportclient/__init__.py +@@ -69,7 +69,7 @@ def set_verbosity(verbosity): + os.environ["ABRT_VERBOSE"] = str(verbose) + + +-def log(fmt, *args): ++def log_warning(fmt, *args): + sys.stderr.write("%s\n" % (fmt % args)) + + +diff --git a/src/gtk-helpers/config_dialog.c b/src/gtk-helpers/config_dialog.c +index b65c217..7838ec7 100644 +--- a/src/gtk-helpers/config_dialog.c ++++ b/src/gtk-helpers/config_dialog.c +@@ -88,7 +88,7 @@ int cdialog_run(config_dialog_t *cdialog, const char *name) + { + if (cdialog == NULL || cdialog->dialog == NULL) + { +- log("There is no configurable option for: '%s'", name); ++ log_warning("There is no configurable option for: '%s'", name); + return GTK_RESPONSE_REJECT; + } + +@@ -146,7 +146,7 @@ static void save_value_from_widget(gpointer data, gpointer user_data) + val = gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(ow->widget)) ? "yes" : "no"; + break; + default: +- log("unsupported option type"); ++ log_warning("unsupported option type"); + } + + /* gtk_entry_get_text() returns empty string for empty text value */ +diff --git a/src/gtk-helpers/event_config_dialog.c b/src/gtk-helpers/event_config_dialog.c +index e5ce612..1a5e1ea 100644 +--- a/src/gtk-helpers/event_config_dialog.c ++++ b/src/gtk-helpers/event_config_dialog.c +@@ -181,7 +181,7 @@ static void add_option_to_table(gpointer data, gpointer user_data) + + default: + //option_input = gtk_label_new_justify_left("WTF?"); +- log("unsupported option type"); ++ log_warning("unsupported option type"); + free(option_label); + return; + } +diff --git a/src/gtk-helpers/problem_details_widget.c b/src/gtk-helpers/problem_details_widget.c +index d8d78e9..f0e6c6d 100644 +--- a/src/gtk-helpers/problem_details_widget.c ++++ b/src/gtk-helpers/problem_details_widget.c +@@ -183,7 +183,7 @@ problem_details_widget_add_binary(ProblemDetailsWidget *self, const char *label, + + if (stat(path, &statbuf) != 0) + { +- log("File '%s' does not exist", path); ++ log_warning("File '%s' does not exist", path); + return; + } + +@@ -224,7 +224,7 @@ problem_details_widget_add_problem_item(ProblemDetailsWidget *self, const char * + else if (item->flags & CD_FLAG_BIN) + problem_details_widget_add_binary(self, name, item->content); + else +- log("Unsupported file type"); ++ log_warning("Unsupported file type"); + } + + /* Callback for GHashTable */ +diff --git a/src/gtk-helpers/secrets.c b/src/gtk-helpers/secrets.c +index fdc6616..0f0bb20 100644 +--- a/src/gtk-helpers/secrets.c ++++ b/src/gtk-helpers/secrets.c +@@ -305,7 +305,7 @@ static enum secrets_service_state secrets_service_connect(void) + + if (!g_connection) + { +- log("Failed to open connection to D-Bus session bus: %s", error->message); ++ log_warning("Failed to open connection to D-Bus session bus: %s", error->message); + g_error_free(error); + return SBS_UNAVAILABLE; + } +diff --git a/src/gui-wizard-gtk/main.c b/src/gui-wizard-gtk/main.c +index c47c57a..3ab8eb2 100644 +--- a/src/gui-wizard-gtk/main.c ++++ b/src/gui-wizard-gtk/main.c +@@ -66,7 +66,7 @@ void problem_data_reload_from_dump_dir(void) + new_item->default_by_reporter = 0; + new_item->required_by_reporter = 0; + } +- //log("%s: was ->selected_by_user=%d", __func__, new_item->selected_by_user); ++ //log_warning("%s: was ->selected_by_user=%d", __func__, new_item->selected_by_user); + } + problem_data_free(g_cd); + g_cd = new_cd; +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index d337805..2ec4223 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -307,7 +307,7 @@ static void label_wrapper(GtkWidget *widget, gpointer data_unused) + GtkLabel *label = (GtkLabel*)widget; + gtk_label_set_line_wrap(label, 1); + //const char *txt = gtk_label_get_label(label); +- //log("label '%s' set to wrap", txt); ++ //log_warning("label '%s' set to wrap", txt); + } + } + +@@ -341,7 +341,7 @@ static void wrap_fixer(GtkWidget *widget, gpointer data_unused) + && (gtk_widget_get_margin_bottom(widget) == 0) + #endif + ) { +- //log("label '%s' set to autowrap", txt); ++ //log_warning("label '%s' set to autowrap", txt); + make_label_autowrap_on_resize(label); + return; + } +@@ -864,7 +864,7 @@ static void g_tv_details_checkbox_toggled( + gchar *tree_path, + gpointer user_data_UNUSED) + { +- //log("%s: path:'%s'", __func__, tree_path); ++ //log_warning("%s: path:'%s'", __func__, tree_path); + GtkTreeIter iter; + if (!gtk_tree_model_get_iter_from_string(GTK_TREE_MODEL(g_ls_details), &iter, tree_path)) + return; +@@ -885,7 +885,7 @@ static void g_tv_details_checkbox_toggled( + cur_value = item->default_by_reporter; + else + cur_value = !!(item->selected_by_user + 1); /* map -1,1 to 0,1 */ +- //log("%s: allowed:%d reqd:%d def:%d user:%d cur:%d", __func__, ++ //log_warning("%s: allowed:%d reqd:%d def:%d user:%d cur:%d", __func__, + // item->allowed_by_reporter, + // item->required_by_reporter, + // item->default_by_reporter, +@@ -896,7 +896,7 @@ static void g_tv_details_checkbox_toggled( + { + cur_value = !cur_value; + item->selected_by_user = cur_value * 2 - 1; /* map 0,1 to -1,1 */ +- //log("%s: now ->selected_by_user=%d", __func__, item->selected_by_user); ++ //log_warning("%s: now ->selected_by_user=%d", __func__, item->selected_by_user); + gtk_list_store_set(g_ls_details, &iter, + DETAIL_COLUMN_CHECKBOX, cur_value, + -1); +@@ -1327,7 +1327,7 @@ static void append_item_to_ls_details(gpointer name, gpointer value, gpointer da + static void update_ls_details_checkboxes(const char *event_name) + { + event_config_t *cfg = get_event_config(event_name); +- //log("%s: event:'%s', cfg:'%p'", __func__, g_event_selected, cfg); ++ //log_warning("%s: event:'%s', cfg:'%p'", __func__, g_event_selected, cfg); + GHashTableIter iter; + char *name; + struct problem_item *item; +@@ -1370,7 +1370,7 @@ static void update_ls_details_checkboxes(const char *event_name) + else + cur_value = !!(item->selected_by_user + 1); /* map -1,1 to 0,1 */ + +- //log("%s: '%s' allowed:%d reqd:%d def:%d user:%d", __func__, name, ++ //log_warning("%s: '%s' allowed:%d reqd:%d def:%d user:%d", __func__, name, + // item->allowed_by_reporter, + // item->required_by_reporter, + // item->default_by_reporter, +@@ -1395,7 +1395,7 @@ static void update_ls_details_checkboxes(const char *event_name) + gtk_list_store_set(g_ls_details, &iter, + DETAIL_COLUMN_CHECKBOX, cur_value, + -1); +- //log("%s: changed gtk_list_store_set to %d", __func__, (item->allowed_by_reporter && item->selected_by_user >= 0)); ++ //log_warning("%s: changed gtk_list_store_set to %d", __func__, (item->allowed_by_reporter && item->selected_by_user >= 0)); + break; + } while (gtk_tree_model_iter_next(GTK_TREE_MODEL(g_ls_details), &iter)); + } +@@ -1544,7 +1544,7 @@ static void set_excluded_envvar(void) + } while (gtk_tree_model_iter_next(GTK_TREE_MODEL(g_ls_details), &iter)); + } + char *var = strbuf_free_nobuf(item_list); +- //log("EXCLUDE_FROM_REPORT='%s'", var); ++ //log_warning("EXCLUDE_FROM_REPORT='%s'", var); + if (var) + { + xsetenv("EXCLUDE_FROM_REPORT", var); +@@ -2349,7 +2349,7 @@ static void toggle_eb_comment(void) + switch(reproducible) + { + case -1: +- VERB1 log("Uninitialized 'How reproducible' combobox"); ++ VERB1 log_warning("Uninitialized 'How reproducible' combobox"); + break; + + case PROBLEM_REPRODUCIBLE_UNKNOWN: +@@ -2418,7 +2418,7 @@ static void log_ready_state(void) + buf[i] = ch; + } + buf[NUM_PAGES] = 0; +- log("Completeness:[%s]", buf); ++ log_warning("Completeness:[%s]", buf); + } + #endif + +@@ -3094,7 +3094,7 @@ static gint select_next_page_no(gint current_page_no, gpointer data) + } + else + { +- log("%s", msg); ++ log_warning("%s", msg); + free(msg); + } + } +@@ -3265,7 +3265,7 @@ static void save_edited_one_liner(GtkCellRendererText *renderer, + gchar *new_text, + gpointer user_data) + { +- //log("path:'%s' new_text:'%s'", tree_path, new_text); ++ //log_warning("path:'%s' new_text:'%s'", tree_path, new_text); + + GtkTreeIter iter; + if (!gtk_tree_model_get_iter_from_string(GTK_TREE_MODEL(g_ls_details), &iter, tree_path)) +diff --git a/src/include/internal_libreport.h b/src/include/internal_libreport.h +index c11826c..f243a04 100644 +--- a/src/include/internal_libreport.h ++++ b/src/include/internal_libreport.h +@@ -539,11 +539,11 @@ void set_xfunc_diemode(enum libreport_diemode mode); + /* Verbosity level */ + #define g_verbose libreport_g_verbose + extern int g_verbose; +-/* VERB1 log("what you sometimes want to see, even on a production box") */ ++/* VERB1 log_warning("what you sometimes want to see, even on a production box") */ + #define VERB1 if (g_verbose >= 1) +-/* VERB2 log("debug message, not going into insanely small details") */ ++/* VERB2 log_warning("debug message, not going into insanely small details") */ + #define VERB2 if (g_verbose >= 2) +-/* VERB3 log("lots and lots of details") */ ++/* VERB3 log_warning("lots and lots of details") */ + #define VERB3 if (g_verbose >= 3) + /* there is no level > 3 */ + +@@ -554,9 +554,9 @@ void xfunc_die(void) NORETURN; + #define die_out_of_memory libreport_die_out_of_memory + void die_out_of_memory(void) NORETURN; + +-/* It's a macro, not function, since it collides with log() from math.h */ ++/* It's a macro, not function, since it collides with log_warning() from math.h */ + #undef log +-#define log(...) log_standard(LOG_WARNING, __FILE__, __LINE__, __func__, __VA_ARGS__) ++#define log_warning(...) log_standard(LOG_WARNING, __FILE__, __LINE__, __func__, __VA_ARGS__) + #define log_debug(...) log_standard(LOG_DEBUG, __FILE__, __LINE__, __func__, __VA_ARGS__) + #define log_info(...) log_standard(LOG_INFO, __FILE__, __LINE__, __func__, __VA_ARGS__) + #define log_notice(...) log_standard(LOG_NOTICE, __FILE__, __LINE__, __func__, __VA_ARGS__) +diff --git a/src/lib/abrt_dbus.c b/src/lib/abrt_dbus.c +index 44ead3e..a7391c0 100644 +--- a/src/lib/abrt_dbus.c ++++ b/src/lib/abrt_dbus.c +@@ -134,7 +134,7 @@ int load_charp(DBusMessageIter* iter, const char** val) + return -1; + } + dbus_message_iter_get_basic(iter, val); +-//log("load_charp:'%s'", *val); ++//log_warning("load_charp:'%s'", *val); + return dbus_message_iter_next(iter); + } + +@@ -294,7 +294,7 @@ void attach_dbus_conn_to_glib_main_loop(DBusConnection* conn, + g_dbus_conn = conn; + + //do we need this? why? +-//log("dbus_connection_set_dispatch_status_function"); ++//log_warning("dbus_connection_set_dispatch_status_function"); + // dbus_connection_set_dispatch_status_function(conn, + // dispatch, /* void dispatch(DBusConnection *conn, DBusDispatchStatus new_status, void* data) */ + // NULL, /* data */ +diff --git a/src/lib/copy_file_recursive.c b/src/lib/copy_file_recursive.c +index 6bad978..7c7666e 100644 +--- a/src/lib/copy_file_recursive.c ++++ b/src/lib/copy_file_recursive.c +@@ -143,7 +143,7 @@ int copy_file_recursive(const char *source, const char *dest) + /* Neither dir not regular file: skip */ + + skip: +- log("Skipping '%s'", source); ++ log_warning("Skipping '%s'", source); + ret: + return retval; + } +diff --git a/src/lib/curl.c b/src/lib/curl.c +index 73ca9a0..17cb3e7 100644 +--- a/src/lib/curl.c ++++ b/src/lib/curl.c +@@ -224,7 +224,7 @@ static size_t fread_with_reporting(void *ptr, size_t size, size_t nmemb, void *u + last_t = t; + report_interval *= 2; + off_t sz = fstat_st_size_or_die(fileno(fp)); +- log(_("Uploaded: %llu of %llu kbytes"), ++ log_warning(_("Uploaded: %llu of %llu kbytes"), + (unsigned long long)cur_pos / 1024, + (unsigned long long)sz / 1024); + } +@@ -267,25 +267,25 @@ static int curl_debug(CURL *handle, curl_infotype it, char *buf, size_t bufsize, + switch (it) { + case CURLINFO_TEXT: /* The data is informational text. */ + /* Here eol is always "^J" or "", not printing it */ +- log("curl: %.*s", (int) bufsize, buf); ++ log_warning("curl: %.*s", (int) bufsize, buf); + break; + case CURLINFO_HEADER_IN: /* The data is header (or header-like) data received from the peer. */ +- log("curl rcvd header: '%.*s%s'", (int) bufsize, buf, eol); ++ log_warning("curl rcvd header: '%.*s%s'", (int) bufsize, buf, eol); + break; + case CURLINFO_HEADER_OUT: /* The data is header (or header-like) data sent to the peer. */ +- log("curl sent header: '%.*s%s'", (int) bufsize, buf, eol); ++ log_warning("curl sent header: '%.*s%s'", (int) bufsize, buf, eol); + break; + case CURLINFO_DATA_IN: /* The data is protocol data received from the peer. */ + if (g_verbose >= 3) +- log("curl rcvd data: '%.*s%s'", (int) bufsize, buf, eol); ++ log_warning("curl rcvd data: '%.*s%s'", (int) bufsize, buf, eol); + else +- log("curl rcvd data %u bytes", orig_bufsize); ++ log_warning("curl rcvd data %u bytes", orig_bufsize); + break; + case CURLINFO_DATA_OUT: /* The data is protocol data sent to the peer. */ + if (g_verbose >= 3) +- log("curl sent data: '%.*s%s'", (int) bufsize, buf, eol); ++ log_warning("curl sent data: '%.*s%s'", (int) bufsize, buf, eol); + else +- log("curl sent data %u bytes", orig_bufsize); ++ log_warning("curl sent data %u bytes", orig_bufsize); + break; + default: + break; +@@ -663,7 +663,7 @@ char *upload_file_ext(post_state_t *state, const char *url, const char *filename + + /* Do not include the path part of the URL as it can contain sensitive data + * in case of typos */ +- log(_("Sending %s to %s//%s"), filename, scheme, hostname); ++ log_warning(_("Sending %s to %s//%s"), filename, scheme, hostname); + post(state, + whole_url, + /*content_type:*/ "application/octet-stream", +@@ -716,7 +716,7 @@ char *upload_file_ext(post_state_t *state, const char *url, const char *filename + else + { + /* This ends up a "reporting status message" in abrtd */ +- log(_("Successfully created %s"), whole_url); ++ log_warning(_("Successfully created %s"), whole_url); + } + + close(stdin_bck); +diff --git a/src/lib/dump_dir.c b/src/lib/dump_dir.c +index f08bce7..f509fdc 100644 +--- a/src/lib/dump_dir.c ++++ b/src/lib/dump_dir.c +@@ -358,7 +358,7 @@ int create_symlink_lockfile_at(int dir_fd, const char* lock_file, const char* pi + + if (strcmp(pid_buf, pid) == 0) + { +- log("Lock file '%s' is already locked by us", lock_file); ++ log_warning("Lock file '%s' is already locked by us", lock_file); + errno = EALREADY; + return 0; + } +@@ -368,10 +368,10 @@ int create_symlink_lockfile_at(int dir_fd, const char* lock_file, const char* pi + snprintf(pid_str, sizeof(pid_str), "/proc/%s", pid_buf); + if (access(pid_str, F_OK) == 0) + { +- log("Lock file '%s' is locked by process %s", lock_file, pid_buf); ++ log_warning("Lock file '%s' is locked by process %s", lock_file, pid_buf); + return 0; + } +- log("Lock file '%s' was locked by process %s, but it crashed?", lock_file, pid_buf); ++ log_warning("Lock file '%s' was locked by process %s, but it crashed?", lock_file, pid_buf); + } + /* The file may be deleted by now by other process. Ignore ENOENT */ + if (unlinkat(dir_fd, lock_file, /*only files*/0) != 0 && errno != ENOENT) +diff --git a/src/lib/event_config.c b/src/lib/event_config.c +index c5b7b17..88334db 100644 +--- a/src/lib/event_config.c ++++ b/src/lib/event_config.c +@@ -212,12 +212,12 @@ static void load_config_files(const char *dir_path) + if (elem) + { + opt = elem->data; +- // log("conf: replacing '%s' value:'%s'->'%s'", name, opt->value, value); ++ // log_warning("conf: replacing '%s' value:'%s'->'%s'", name, opt->value, value); + free(opt->eo_value); + } + else + { +- // log("conf: new value %s='%s'", name, value); ++ // log_warning("conf: new value %s='%s'", name, value); + opt = new_event_option(); + opt->eo_name = xstrdup(name); + } +diff --git a/src/lib/event_xml_parser.c b/src/lib/event_xml_parser.c +index c89d896..43b8d4f 100644 +--- a/src/lib/event_xml_parser.c ++++ b/src/lib/event_xml_parser.c +@@ -154,13 +154,13 @@ static void consume_cur_option(struct my_parse_data *parse_data) + opt->eo_value = old_opt->eo_value; + old_opt->eo_value = NULL; + } +- //log("xml: replacing '%s' value:'%s'->'%s'", opt->eo_name, old_opt->eo_value, opt->eo_value); ++ //log_warning("xml: replacing '%s' value:'%s'->'%s'", opt->eo_name, old_opt->eo_value, opt->eo_value); + free_event_option(old_opt); + elem->data = opt; + } + else + { +- //log("xml: new value %s='%s'", opt->eo_name, opt->eo_value); ++ //log_warning("xml: new value %s='%s'", opt->eo_name, opt->eo_value); + event_config->values->options = g_list_append(event_config->values->options, opt); + } + } +@@ -173,7 +173,7 @@ static void start_element(GMarkupParseContext *context, + gpointer user_data, + GError **error) + { +- //log("start: %s", element_name); ++ //log_warning("start: %s", element_name); + + struct my_parse_data *parse_data = user_data; + if (strcmp(element_name, ADV_OPTIONS_ELEMENT) == 0) +@@ -494,7 +494,7 @@ static void text(GMarkupParseContext *context, + ui->ec_minimal_rating = strtol(text_copy, &endptr, 10); + if (errno != 0 || endptr == text_copy || *endptr != '\0') + { +- log("invalid minimal-rating number '%s', set to default 4", text_copy); ++ log_warning("invalid minimal-rating number '%s', set to default 4", text_copy); + ui->ec_minimal_rating = 4; + } + } +diff --git a/src/lib/glib_support.c b/src/lib/glib_support.c +index 2751b0c..a20910b 100644 +--- a/src/lib/glib_support.c ++++ b/src/lib/glib_support.c +@@ -48,7 +48,7 @@ void glib_init(void) + GLIB_MINOR_VERSION, + GLIB_MICRO_VERSION); + if (version_mismatch != NULL) +- log("Running GLib incompatible version: %s", version_mismatch); ++ log_warning("Running GLib incompatible version: %s", version_mismatch); + } + } + +diff --git a/src/lib/parse_options.c b/src/lib/parse_options.c +index 181ed1a..85b3a34 100644 +--- a/src/lib/parse_options.c ++++ b/src/lib/parse_options.c +@@ -180,7 +180,7 @@ unsigned parse_opts(int argc, char **argv, const struct options *opt, + case OPTION_END: + break; + } +- //log("curopt[%d].name:'%s' .has_arg:%d .flag:%p .val:%d", (int)(curopt-longopts), ++ //log_warning("curopt[%d].name:'%s' .has_arg:%d .flag:%p .val:%d", (int)(curopt-longopts), + // curopt->name, curopt->has_arg, curopt->flag, curopt->val); + /* + * getopt_long() thinks that NULL name marks the end of longopts. +diff --git a/src/lib/problem_data.c b/src/lib/problem_data.c +index c8cb944..7793244 100644 +--- a/src/lib/problem_data.c ++++ b/src/lib/problem_data.c +@@ -503,14 +503,14 @@ void problem_data_load_from_dump_dir(problem_data_t *problem_data, struct dump_d + { + if (excluding && is_in_string_list(short_name, (const char *const *)excluding)) + { +- //log("Excluded:'%s'", short_name); ++ //log_warning("Excluded:'%s'", short_name); + goto next; + } + + if (short_name[0] == '#' + || (short_name[0] && short_name[strlen(short_name) - 1] == '~') + ) { +- //log("Excluded (editor backup file):'%s'", short_name); ++ //log_warning("Excluded (editor backup file):'%s'", short_name); + goto next; + } + +@@ -591,7 +591,7 @@ void log_problem_data(problem_data_t *problem_data, const char *pfx) + g_hash_table_iter_init(&iter, problem_data); + while (g_hash_table_iter_next(&iter, (void**)&name, (void**)&value)) + { +- log("%s[%s]:'%s' 0x%x", ++ log_warning("%s[%s]:'%s' 0x%x", + pfx, name, + value->content, + value->flags +diff --git a/src/lib/problem_report.c b/src/lib/problem_report.c +index f5b5ee4..e406ec4 100644 +--- a/src/lib/problem_report.c ++++ b/src/lib/problem_report.c +@@ -483,7 +483,7 @@ append_short_backtrace(struct strbuf *result, problem_data_t *problem_data, bool + + if (!backtrace) + { +- log(_("Can't parse backtrace: %s"), error_msg); ++ log_warning(_("Can't parse backtrace: %s"), error_msg); + free(error_msg); + return 0; + } +@@ -498,7 +498,7 @@ append_short_backtrace(struct strbuf *result, problem_data_t *problem_data, bool + + if (!truncated) + { +- log(_("Can't generate stacktrace description (no crash thread?)")); ++ log_warning(_("Can't generate stacktrace description (no crash thread?)")); + return 0; + } + } +@@ -555,7 +555,7 @@ append_item(struct strbuf *result, const char *item_name, problem_data_t *pd, GL + bool text = (strcmp(item_name+1, "text" ) == 0); + if (!oneline && !multiline && !text) + { +- log("Unknown or unsupported element specifier '%s'", item_name); ++ log_warning("Unknown or unsupported element specifier '%s'", item_name); + return 0; /* "I did not print anything" */ + } + +@@ -665,7 +665,7 @@ get_special_items(const char *item_name, problem_data_t *pd, GList *comment_fmt_ + bool binary = (strcmp(item_name+1, "binary" ) == 0); + if (!oneline && !multiline && !text && !binary) + { +- log("Unknown or unsupported element specifier '%s'", item_name); ++ log_warning("Unknown or unsupported element specifier '%s'", item_name); + return NULL; + } + +diff --git a/src/lib/run_event.c b/src/lib/run_event.c +index b97abea..64c7a30 100644 +--- a/src/lib/run_event.c ++++ b/src/lib/run_event.c +@@ -250,9 +250,9 @@ GList *load_rule_list(GList *rule_list, + } + else if (g_verbose >= 3) + { +- log("Adding '%s'\nwith conditions:", p); ++ log_warning("Adding '%s'\nwith conditions:", p); + for (GList *c = cur_rule->conditions; c != NULL; c = g_list_next(c)) +- log("| %s", (const char *)c->data); ++ log_warning("| %s", (const char *)c->data); + } + + cur_rule->command = xstrdup(p); +@@ -313,7 +313,7 @@ static int regcmp_lines(char *val, const char *regex) + { + regex_t rx; + int r = regcomp(&rx, regex, REG_NOSUB); //TODO: and REG_EXTENDED? +- //log("REGEX:'%s':%d", regex, r); ++ //log_warning("REGEX:'%s':%d", regex, r); + if (r) + { + //char errbuf[256]; +@@ -329,7 +329,7 @@ static int regcmp_lines(char *val, const char *regex) + if (eol) + *eol = '\0'; + r = regexec(&rx, val, 0, NULL, /*eflags:*/ 0); +- //log("REGCMP:'%s':%d", val, r); ++ //log_warning("REGCMP:'%s':%d", val, r); + if (eol) + *eol = '\n'; + if (r == 0 || !eol) +diff --git a/src/lib/steal_directory.c b/src/lib/steal_directory.c +index ed18345..32b5f85 100644 +--- a/src/lib/steal_directory.c ++++ b/src/lib/steal_directory.c +@@ -88,7 +88,7 @@ struct dump_dir *open_directory_for_writing( + if (dd->locked) + return dd; + +- log("'%s' is not writable", dump_dir_name); ++ log_warning("'%s' is not writable", dump_dir_name); + dd_close(dd); + + char *spooldir = concat_path_file(g_get_user_cache_dir(), "abrt/spool"); +diff --git a/src/lib/workflow_xml_parser.c b/src/lib/workflow_xml_parser.c +index bc32be3..9b7c5a5 100644 +--- a/src/lib/workflow_xml_parser.c ++++ b/src/lib/workflow_xml_parser.c +@@ -35,7 +35,7 @@ static void start_element(GMarkupParseContext *context, + gpointer user_data, + GError **error) + { +- //log("start: %s", element_name); ++ //log_warning("start: %s", element_name); + + struct my_parse_data *parse_data = user_data; + if (strcmp(element_name, EVENTS_ELEMENT) == 0) +diff --git a/src/plugins/mantisbt.c b/src/plugins/mantisbt.c +index 803e969..2504f9a 100644 +--- a/src/plugins/mantisbt.c ++++ b/src/plugins/mantisbt.c +@@ -122,7 +122,7 @@ mantisbt_find_origin_bug_closed_duplicate(mantisbt_settings_t *settings, mantisb + if (ii == MAX_HOPS) + error_msg_and_die(_("MantisBT couldn't find parent of issue %d"), info->mii_id); + +- log("Issue %d is a duplicate, using parent issue %d", info_tmp->mii_id, info_tmp->mii_dup_id); ++ log_warning("Issue %d is a duplicate, using parent issue %d", info_tmp->mii_id, info_tmp->mii_dup_id); + int issue_id = info_tmp->mii_dup_id; + + mantisbt_issue_info_free(info_tmp); +diff --git a/src/plugins/reporter-bugzilla.c b/src/plugins/reporter-bugzilla.c +index 5364cd4..514fb65 100644 +--- a/src/plugins/reporter-bugzilla.c ++++ b/src/plugins/reporter-bugzilla.c +@@ -213,7 +213,7 @@ char *ask_bz_password(const char *message) + static + void login(struct abrt_xmlrpc *client, struct bugzilla_struct *rhbz) + { +- log(_("Logging into Bugzilla at %s"), rhbz->b_bugzilla_url); ++ log_warning(_("Logging into Bugzilla at %s"), rhbz->b_bugzilla_url); + while (!rhbz_login(client, rhbz->b_login, rhbz->b_password)) + { + free(rhbz->b_login); +@@ -385,7 +385,7 @@ int main(int argc, char **argv) + + if (abrt_hash) + { +- log(_("Looking for similar problems in bugzilla")); ++ log_warning(_("Looking for similar problems in bugzilla")); + char *hash; + if (prefixcmp(abrt_hash, "abrt_hash:")) + hash = xasprintf("abrt_hash:%s", abrt_hash); +@@ -491,7 +491,7 @@ int main(int argc, char **argv) + + /* won't ever call free on it - it simplifies the code a lot */ + ticket_no = xstrdup(ticket_no + 1); +- log(_("Using Bugzilla ID '%s'"), ticket_no); ++ log_warning(_("Using Bugzilla ID '%s'"), ticket_no); + } + + login(client, &rhbz); +@@ -525,7 +525,7 @@ int main(int argc, char **argv) + } + } + +- log(_("Logging out")); ++ log_warning(_("Logging out")); + rhbz_logout(client); + + #if 0 /* enable if you search for leaks (valgrind etc) */ +@@ -640,7 +640,7 @@ int main(int argc, char **argv) + struct bug_info *bz = NULL; + if (!bug_id) + { +- log(_("Checking for duplicates")); ++ log_warning(_("Checking for duplicates")); + + int existing_id = -1; + int crossver_id = -1; +@@ -716,7 +716,7 @@ int main(int argc, char **argv) + + if (r == 0) + { +- log(_("Logging out")); ++ log_warning(_("Logging out")); + rhbz_logout(client); + + problem_formatter_free(pf); +@@ -732,7 +732,7 @@ int main(int argc, char **argv) + } + + /* Create new bug */ +- log(_("Creating a new bug")); ++ log_warning(_("Creating a new bug")); + + if (existing_id < 0 && crossver_id >= 0) + problem_report_buffer_printf( +@@ -767,7 +767,7 @@ int main(int argc, char **argv) + if (extra != NULL) { + char *email = strtok(extra, "\n"); + while (email != NULL) { +- log(_("Adding extra cc %s to bug report"), email); ++ log_warning(_("Adding extra cc %s to bug report"), email); + rhbz_mail_to_cc(client, new_id, email, /* require mail notify */ 0); + email = strtok(NULL, "\n"); + } +@@ -776,13 +776,13 @@ int main(int argc, char **argv) + + if (reported_to && reported_to->url) + { +- log(_("Adding External URL to bug %i"), new_id); ++ log_warning(_("Adding External URL to bug %i"), new_id); + rhbz_set_url(client, new_id, reported_to->url, RHBZ_NOMAIL_NOTIFY); + free_report_result(reported_to); + } + } + +- log(_("Adding attachments to bug %i"), new_id); ++ log_warning(_("Adding attachments to bug %i"), new_id); + char new_id_str[sizeof(int)*3 + 2]; + sprintf(new_id_str, "%i", new_id); + +@@ -804,7 +804,7 @@ int main(int argc, char **argv) + + if (existing_id >= 0) + { +- log(_("Closing bug %i as duplicate of bug %i"), new_id, existing_id); ++ log_warning(_("Closing bug %i as duplicate of bug %i"), new_id, existing_id); + rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_NOMAIL_NOTIFY); + } + +@@ -816,7 +816,7 @@ int main(int argc, char **argv) + + bz = rhbz_bug_info(client, bug_id); + +- log(_("Bug is already reported: %i"), bz->bi_id); ++ log_warning(_("Bug is already reported: %i"), bz->bi_id); + + /* Follow duplicates */ + if ((strcmp(bz->bi_status, "CLOSED") == 0) +@@ -859,7 +859,7 @@ int main(int argc, char **argv) + if (strcmp(bz->bi_reporter, rhbz.b_login) != 0 + && !g_list_find_custom(bz->bi_cc_list, rhbz.b_login, (GCompareFunc)g_strcmp0) + ) { +- log(_("Adding %s to CC list"), rhbz.b_login); ++ log_warning(_("Adding %s to CC list"), rhbz.b_login); + rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_NOMAIL_NOTIFY); + } + +@@ -880,7 +880,7 @@ int main(int argc, char **argv) + int dup_comment = is_comment_dup(bz->bi_comments, bzcomment); + if (!dup_comment) + { +- log(_("Adding new comment to bug %d"), bz->bi_id); ++ log_warning(_("Adding new comment to bug %d"), bz->bi_id); + rhbz_add_comment(client, bz->bi_id, bzcomment, 0); + + const char *bt = problem_data_get_content_or_NULL(problem_data, FILENAME_BACKTRACE); +@@ -893,23 +893,23 @@ int main(int argc, char **argv) + { + char bug_id_str[sizeof(int)*3 + 2]; + sprintf(bug_id_str, "%i", bz->bi_id); +- log(_("Attaching better backtrace")); ++ log_warning(_("Attaching better backtrace")); + rhbz_attach_blob(client, bug_id_str, FILENAME_BACKTRACE, bt, strlen(bt), + RHBZ_NOMAIL_NOTIFY); + } + } + else +- log(_("Found the same comment in the bug history, not adding a new one")); ++ log_warning(_("Found the same comment in the bug history, not adding a new one")); + + problem_report_free(pr); + problem_formatter_free(pf); + } + + log_out: +- log(_("Logging out")); ++ log_warning(_("Logging out")); + rhbz_logout(client); + +- log(_("Status: %s%s%s %s/show_bug.cgi?id=%u"), ++ log_warning(_("Status: %s%s%s %s/show_bug.cgi?id=%u"), + bz->bi_status, + bz->bi_resolution ? " " : "", + bz->bi_resolution ? bz->bi_resolution : "", +diff --git a/src/plugins/reporter-kerneloops.c b/src/plugins/reporter-kerneloops.c +index 895f755..9e72837 100644 +--- a/src/plugins/reporter-kerneloops.c ++++ b/src/plugins/reporter-kerneloops.c +@@ -26,7 +26,7 @@ static size_t writefunction(void *ptr, size_t size, size_t nmemb, void *stream) + /* + char *c, *c1, *c2; + +- log("received: '%*.*s'", (int)size, (int)size, (char*)ptr); ++ log_warning("received: '%*.*s'", (int)size, (int)size, (char*)ptr); + c = (char*)xzalloc(size + 1); + memcpy(c, ptr, size); + c1 = strstr(c, "201 "); +@@ -102,7 +102,7 @@ static void report_to_kerneloops( + if (!submitURL[0]) + submitURL = "http://oops.kernel.org/submitoops.php"; + +- log(_("Submitting oops report to %s"), submitURL); ++ log_warning(_("Submitting oops report to %s"), submitURL); + + CURLcode ret = http_post_to_kerneloops_site(submitURL, backtrace); + if (ret != CURLE_OK) +@@ -124,7 +124,7 @@ static void report_to_kerneloops( + dd_close(dd); + } + +- log("Kernel oops report was uploaded"); ++ log_warning("Kernel oops report was uploaded"); + } + + int main(int argc, char **argv) +diff --git a/src/plugins/reporter-mailx.c b/src/plugins/reporter-mailx.c +index 2312e4c..05fa1e5 100644 +--- a/src/plugins/reporter-mailx.c ++++ b/src/plugins/reporter-mailx.c +@@ -67,11 +67,11 @@ static void exec_and_feed_input(const char* text, char **args) + + static char** append_str_to_vector(char **vec, unsigned *size_p, const char *str) + { +- //log("old vec: %p", vec); ++ //log_warning("old vec: %p", vec); + unsigned size = *size_p; + vec = (char**) xrealloc(vec, (size+2) * sizeof(vec[0])); + vec[size] = xstrdup(str); +- //log("new vec: %p, added [%d] %p", vec, size, vec[size]); ++ //log_warning("new vec: %p, added [%d] %p", vec, size, vec[size]); + size++; + vec[size] = NULL; + *size_p = size; +@@ -204,9 +204,9 @@ static void create_and_send_email( + putenv((char*)"DEAD=/dev/null"); + + if (flag & RM_FLAG_NOTIFY) +- log(_("Sending a notification email to: %s"), email_to); ++ log_warning(_("Sending a notification email to: %s"), email_to); + else +- log(_("Sending an email...")); ++ log_warning(_("Sending an email...")); + + exec_and_feed_input(dsc, args); + +@@ -231,7 +231,7 @@ static void create_and_send_email( + free(rr.url); + dd_close(dd); + } +- log(_("Email was sent to: %s"), email_to); ++ log_warning(_("Email was sent to: %s"), email_to); + } + + free(email_to); +diff --git a/src/plugins/reporter-mantisbt.c b/src/plugins/reporter-mantisbt.c +index 3705bc7..e8afa7d 100644 +--- a/src/plugins/reporter-mantisbt.c ++++ b/src/plugins/reporter-mantisbt.c +@@ -106,7 +106,7 @@ verify_credentials(mantisbt_settings_t *settings) + { + GList *ids = response_get_main_ids_list(result->mr_body); + if (ids != NULL) +- log("%s", (char *)ids->data); ++ log_warning("%s", (char *)ids->data); + response_values_free(ids); + } + +@@ -337,7 +337,7 @@ int main(int argc, char **argv) + + if (abrt_hash) + { +- log(_("Looking for similar problems in MantisBT")); ++ log_warning(_("Looking for similar problems in MantisBT")); + GList *ids = mantisbt_search_by_abrt_hash(&mbt_settings, abrt_hash); + mantisbt_settings_free(&mbt_settings); + +@@ -380,7 +380,7 @@ int main(int argc, char **argv) + + /* won't ever call free on it - it simplifies the code a lot */ + ticket_no = xstrdup(ticket_no + 1); +- log(_("Using MantisBT ID '%s'"), ticket_no); ++ log_warning(_("Using MantisBT ID '%s'"), ticket_no); + } + + /* Attach files to existing MantisBT issues */ +@@ -388,7 +388,7 @@ int main(int argc, char **argv) + { + const char *path = *argv++; + char *filename = basename(path); +- log(_("Attaching file '%s' to issue %s"), filename, ticket_no); ++ log_warning(_("Attaching file '%s' to issue %s"), filename, ticket_no); + mantisbt_attach_file(&mbt_settings, ticket_no, filename, path); + } + +@@ -483,7 +483,7 @@ int main(int argc, char **argv) + mantisbt_issue_info_t *ii; + if (!bug_id) + { +- log(_("Checking for duplicates")); ++ log_warning(_("Checking for duplicates")); + + int existing_id = -1; + int crossver_id = -1; +@@ -522,7 +522,7 @@ int main(int argc, char **argv) + if (existing_id < 0) + { + /* Create new issue */ +- log(_("Creating a new issue")); ++ log_warning(_("Creating a new issue")); + problem_formatter_t *pf = problem_formatter_new(); + problem_formatter_add_section(pf, PR_SEC_ADDITIONAL_INFO, 0); + +@@ -550,7 +550,7 @@ int main(int argc, char **argv) + + if (reported_to && reported_to->url) + { +- log(_("Adding External URL to issue")); ++ log_warning(_("Adding External URL to issue")); + tracker_url = xstrdup(reported_to->url); + free_report_result(reported_to); + } +@@ -563,7 +563,7 @@ int main(int argc, char **argv) + if (new_id == -1) + return EXIT_FAILURE; + +- log(_("Adding attachments to issue %i"), new_id); ++ log_warning(_("Adding attachments to issue %i"), new_id); + char *new_id_str = xasprintf("%u", new_id); + + for (GList *a = problem_report_get_attachments(pr); a != NULL; a = g_list_next(a)) +@@ -592,7 +592,7 @@ int main(int argc, char **argv) + + ii = mantisbt_get_issue_info(&mbt_settings, bug_id); + +- log(_("Bug is already reported: %i"), ii->mii_id); ++ log_warning(_("Bug is already reported: %i"), ii->mii_id); + + /* Follow duplicates */ + if ((strcmp(ii->mii_status, "closed") == 0) +@@ -629,7 +629,7 @@ int main(int argc, char **argv) + int dup_comment = is_comment_dup(ii->mii_notes, mbtcomment); + if (!dup_comment) + { +- log(_("Adding new comment to issue %d"), ii->mii_id); ++ log_warning(_("Adding new comment to issue %d"), ii->mii_id); + mantisbt_add_issue_note(&mbt_settings, ii->mii_id, mbtcomment); + + const char *bt = problem_data_get_content_or_NULL(problem_data, FILENAME_BACKTRACE); +@@ -642,7 +642,7 @@ int main(int argc, char **argv) + { + char *bug_id_str = xasprintf("%i", ii->mii_id); + +- log(_("Attaching better backtrace")); ++ log_warning(_("Attaching better backtrace")); + + // find unique filename of attachment + char *name = NULL; +@@ -665,14 +665,14 @@ int main(int argc, char **argv) + } + } + else +- log(_("Found the same comment in the issue history, not adding a new one")); ++ log_warning(_("Found the same comment in the issue history, not adding a new one")); + + problem_report_free(pr); + problem_formatter_free(pf); + } + + finish: +- log(_("Status: %s%s%s %s/view.php?id=%u"), ++ log_warning(_("Status: %s%s%s %s/view.php?id=%u"), + ii->mii_status, + ii->mii_resolution ? " " : "", + ii->mii_resolution ? ii->mii_resolution : "", +diff --git a/src/plugins/reporter-print.c b/src/plugins/reporter-print.c +index 90ed4c3..b8701b6 100644 +--- a/src/plugins/reporter-print.c ++++ b/src/plugins/reporter-print.c +@@ -142,7 +142,7 @@ int main(int argc, char **argv) + } + } + const char *format = (open_mode[0] == 'a' ? _("The report was appended to %s") : _("The report was stored to %s")); +- log(format, output_file); ++ log_warning(format, output_file); + free(output_file); + } + +diff --git a/src/plugins/reporter-rhtsupport-parse.c b/src/plugins/reporter-rhtsupport-parse.c +index e7078e9..ab1679d 100644 +--- a/src/plugins/reporter-rhtsupport-parse.c ++++ b/src/plugins/reporter-rhtsupport-parse.c +@@ -39,7 +39,7 @@ static void start_element( + gpointer user_data, + GError **error) + { +- //log("start: %s", element_name); ++ //log_warning("start: %s", element_name); + + struct my_parse_data *parse_data = user_data; + +diff --git a/src/plugins/reporter-rhtsupport.c b/src/plugins/reporter-rhtsupport.c +index 6734519..cbf7c9a 100644 +--- a/src/plugins/reporter-rhtsupport.c ++++ b/src/plugins/reporter-rhtsupport.c +@@ -291,7 +291,7 @@ char *submit_ureport(const char *dump_dir_name, struct ureport_server_config *co + ureport_server_response_save_in_dump_dir(resp, dump_dir_name, conf); + + if (resp->urr_message) +- log("%s", resp->urr_message); ++ log_warning("%s", resp->urr_message); + } + else if (g_verbose > 2) + error_msg(_("Server responded with an error: '%s'"), resp->urr_value); +@@ -321,9 +321,9 @@ bool check_for_hints(const char *url, char **login, char **password, bool ssl_ve + ); + + #if 0 /* testing */ +- log("ERR:%d", result->error); +- log("MSG:'%s'", result->msg); +- log("BODY:'%s'", result->body); ++ log_warning("ERR:%d", result->error); ++ log_warning("MSG:'%s'", result->msg); ++ log_warning("BODY:'%s'", result->body); + result->error = 0; + result->body = xstrdup( + "" +@@ -595,8 +595,8 @@ int main(int argc, char **argv) + error_msg_and_die("Can't attach: problem data in '%s' " + "was not reported to RHTSupport and therefore has no URL", + dump_dir_name); +- //log("URL:'%s'", reported_to->url); +- //log("MSG:'%s'", reported_to->msg); ++ //log_warning("URL:'%s'", reported_to->url); ++ //log_warning("MSG:'%s'", reported_to->msg); + free(url); + url = reported_to->url; + reported_to->url = NULL; +@@ -616,7 +616,7 @@ int main(int argc, char **argv) + /* -t[CASE] FILE: just attach files and exit */ + while (*argv) + { +- log(_("Attaching '%s' to case '%s'"), *argv, url); ++ log_warning(_("Attaching '%s' to case '%s'"), *argv, url); + rhts_result_t *result = attach_file_to_case(url, + login, + password, +@@ -625,8 +625,8 @@ int main(int argc, char **argv) + ); + if (result->error) + error_msg_and_die("%s", result->msg); +- log("Attachment URL:%s", result->url); +- log("File attached successfully"); ++ log_warning("Attachment URL:%s", result->url); ++ log_warning("File attached successfully"); + free_rhts_result(result); + argv++; + } +@@ -653,7 +653,7 @@ int main(int argc, char **argv) + + if (submit_ur) + { +- log(_("Sending ABRT crash statistics data")); ++ log_warning(_("Sending ABRT crash statistics data")); + + bthash = submit_ureport(dump_dir_name, &urconf); + +@@ -794,7 +794,7 @@ int main(int argc, char **argv) + } + + /* Gzipping e.g. 0.5gig coredump takes a while. Let user know what we are doing */ +- log(_("Compressing data")); ++ log_warning(_("Compressing data")); + + struct dump_dir *dd = dd_opendir(dump_dir_name, /*flags:*/ 0); + if (!dd) +@@ -813,12 +813,12 @@ int main(int argc, char **argv) + if (tempfile_size <= QUERY_HINTS_IF_SMALLER_THAN) + { + /* Check for hints and show them if we have something */ +- log(_("Checking for hints")); ++ log_warning(_("Checking for hints")); + if (check_for_hints(base_api_url, &login, &password, ssl_verify, tempfile)) + goto ret; + } + +- log(_("Creating a new case")); ++ log_warning(_("Creating a new case")); + + char *product = NULL; + char *version = NULL; +@@ -878,14 +878,14 @@ int main(int argc, char **argv) + add_reported_to_entry(dd, &rr); + dd_close(dd); + if (result->msg) +- log("%s", result->msg); +- log("URL=%s", result->url); ++ log_warning("%s", result->msg); ++ log_warning("URL=%s", result->url); + } + /* else: error msg was already emitted by dd_opendir */ + + if (bthash) + { +- log(_("Linking ABRT crash statistics record with the case")); ++ log_warning(_("Linking ABRT crash statistics record with the case")); + + /* Make sure we use the current credentials */ + ureport_server_config_set_basic_auth(&urconf, login, password); +@@ -898,7 +898,7 @@ int main(int argc, char **argv) + UREPORT_OPTION_VALUE_FROM_CONF(ursettings, "ContactEmail", email, (const char *)); + if (email != NULL) + { +- log(_("Linking ABRT crash statistics record with contact email: '%s'"), email); ++ log_warning(_("Linking ABRT crash statistics record with contact email: '%s'"), email); + attach_to_ureport(&urconf, bthash, "email", email); + } + +@@ -917,12 +917,12 @@ int main(int argc, char **argv) + if (bigsize != 0 && tempfile_size / (1024*1024) >= bigsize) + { + /* Upload tarball of -d DIR to "big file" FTP */ +- /* log(_("Uploading problem data to '%s'"), bigurl); - upload_file does this */ ++ /* log_warning(_("Uploading problem data to '%s'"), bigurl); - upload_file does this */ + remote_filename = upload_file(bigurl, tempfile); + } + if (remote_filename) + { +- log(_("Adding comment to case '%s'"), url); ++ log_warning(_("Adding comment to case '%s'"), url); + /* + * Do not translate message below - it goes + * to a server where *other people* will read it. +@@ -940,7 +940,7 @@ int main(int argc, char **argv) + else + { + /* Attach the tarball of -d DIR */ +- log(_("Attaching problem data to case '%s'"), url); ++ log_warning(_("Attaching problem data to case '%s'"), url); + INVALID_CREDENTIALS_LOOP(login, password, + result_atch, attach_file_to_case(url, login, password, ssl_verify, tempfile) + ); +@@ -952,11 +952,11 @@ int main(int argc, char **argv) + /* Prepend "Case created" text to whatever error message there is, + * so that user knows that case _was_ created despite error in attaching. + */ +- log("Case created but failed to attach problem data: %s", result_atch->msg); ++ log_warning("Case created but failed to attach problem data: %s", result_atch->msg); + } + else + { +- log("Failed to attach problem data: %s", result_atch->msg); ++ log_warning("Failed to attach problem data: %s", result_atch->msg); + } + } + +diff --git a/src/plugins/reporter-systemd-journal.c b/src/plugins/reporter-systemd-journal.c +index d12296e..16c0f1c 100644 +--- a/src/plugins/reporter-systemd-journal.c ++++ b/src/plugins/reporter-systemd-journal.c +@@ -334,7 +334,7 @@ int main(int argc, char **argv) + /* Debug */ + if (opts & OPT_D) + { +- log("Message: %s\n" ++ log_warning("Message: %s\n" + "\n" + "%s" + "\n" +diff --git a/src/plugins/reporter-upload.c b/src/plugins/reporter-upload.c +index 933cc9c..2bfed19 100644 +--- a/src/plugins/reporter-upload.c ++++ b/src/plugins/reporter-upload.c +@@ -100,7 +100,7 @@ static int create_and_upload_archive( + xfunc_die(); /* error msg is already logged by dd_opendir */ + + /* Compressing e.g. 0.5gig coredump takes a while. Let client know what we are doing */ +- log(_("Compressing data")); ++ log_warning(_("Compressing data")); + if (dd_create_archive(dd, tempfile, (const_string_vector_const_ptr_t)exclude_from_report, 0) != 0) + { + log_error("Can't create temporary file in %s", LARGE_DATA_TMP_DIR); +@@ -117,7 +117,7 @@ static int create_and_upload_archive( + else + { + result = 0; /* success */ +- log(_("Archive is created: '%s'"), tempfile); ++ log_warning(_("Archive is created: '%s'"), tempfile); + *remote_name = tempfile; + tempfile = NULL; + } +diff --git a/src/plugins/reporter-ureport.c b/src/plugins/reporter-ureport.c +index 5534579..cc1cedc 100644 +--- a/src/plugins/reporter-ureport.c ++++ b/src/plugins/reporter-ureport.c +@@ -313,9 +313,9 @@ int main(int argc, char **argv) + /* If a reported problem is not known then emit NEEDMORE */ + if (strcmp("true", response->urr_value) == 0) + { +- log(_("This problem has already been reported.")); ++ log_warning(_("This problem has already been reported.")); + if (response->urr_message) +- log("%s", response->urr_message); ++ log_warning("%s", response->urr_message); + + ret = EXIT_STOP_EVENT_RUN; + } +diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c +index 82e7d21..680527d 100644 +--- a/src/plugins/rhbz.c ++++ b/src/plugins/rhbz.c +@@ -34,8 +34,8 @@ + + //#define DEBUG + #ifdef DEBUG +-#define func_entry() log("-- %s", __func__) +-#define func_entry_str(x) log("-- %s\t%s", __func__, (x)) ++#define func_entry() log_warning("-- %s", __func__) ++#define func_entry_str(x) log_warning("-- %s\t%s", __func__, (x)) + #else + #define func_entry() + #define func_entry_str(x) +@@ -601,7 +601,7 @@ int rhbz_new_bug(struct abrt_xmlrpc *ax, + int new_bug_id = *r; + free(r); + +- log(_("New bug id: %i"), new_bug_id); ++ log_warning(_("New bug id: %i"), new_bug_id); + return new_bug_id; + } + +@@ -723,7 +723,7 @@ struct bug_info *rhbz_find_origin_bug_closed_duplicate(struct abrt_xmlrpc *ax, + if (ii == MAX_HOPS) + error_msg_and_die(_("Bugzilla couldn't find parent of bug %d"), bi->bi_id); + +- log("Bug %d is a duplicate, using parent bug %d", bi_tmp->bi_id, bi_tmp->bi_dup_id); ++ log_warning("Bug %d is a duplicate, using parent bug %d", bi_tmp->bi_id, bi_tmp->bi_dup_id); + int bug_id = bi_tmp->bi_dup_id; + + free_bug_info(bi_tmp); +diff --git a/tests/glib_helpers.at b/tests/glib_helpers.at +index 0dc7f7e..a93142e 100644 +--- a/tests/glib_helpers.at ++++ b/tests/glib_helpers.at +@@ -21,8 +21,8 @@ int test(const char *list, const char *delimiter, const char *strings[]) + int retval = 0; + + while(l != NULL) { +- log("is: '%s'", (char *)l->data); +- log("should be: '%s'", *tmp); ++ log_warning("is: '%s'", (char *)l->data); ++ log_warning("should be: '%s'", *tmp); + retval |= strcmp((char *)l->data, *(tmp++)) != 0; + if (retval) + break; // no need to continue further +@@ -60,8 +60,8 @@ int test(const char *list, const char *strings[]) + int retval = 0; + + while(l != NULL) { +- log("is: '%s'", (char *)l->data); +- log("should be: '%s'", *tmp); ++ log_warning("is: '%s'", (char *)l->data); ++ log_warning("should be: '%s'", *tmp); + retval |= strcmp((char *)l->data, *(tmp++)) != 0; + if (retval) + break; // no need to continue further +diff --git a/tests/osrelease.at b/tests/osrelease.at +index 1dc852c..3692e42 100644 +--- a/tests/osrelease.at ++++ b/tests/osrelease.at +@@ -16,12 +16,12 @@ int test(char ***input) + { + char * release_string = **input; + int retcode = 1; +- log("release: >>%s<<\n", release_string); ++ log_warning("release: >>%s<<\n", release_string); + char *product = NULL; + char *version = NULL; + parse_release_for_bz(release_string, &product, &version); +- log("version: >>%s<<\n", version); +- log("product: >>%s<<\n", product); ++ log_warning("version: >>%s<<\n", version); ++ log_warning("product: >>%s<<\n", product); + + if(version == NULL || (strlen(version) == 0)) + { +@@ -30,17 +30,17 @@ int test(char ***input) + } + + (*input)++; //expected product is +1 in the array +- log("'%s' == '%s'", product, **input); ++ log_warning("'%s' == '%s'", product, **input); + if (strcmp(product, **input) != 0) + goto ret; + + (*input)++; //expected version is +2 in the array +- log("'%s' == '%s'", version, **input); ++ log_warning("'%s' == '%s'", version, **input); + if (strcmp(version, **input) == 0) + retcode = 0; + + ret: +- log("retcode %i\n", retcode); ++ log_warning("retcode %i\n", retcode); + return retcode; + } + +@@ -84,12 +84,12 @@ int test(char ***input) + { + char * release_string = **input; + int retcode = 1; +- log("release: >>%s<<\n", release_string); ++ log_warning("release: >>%s<<\n", release_string); + char *product = NULL; + char *version = NULL; + parse_release_for_rhts(release_string, &product, &version); +- log("version: >>%s<<\n", version); +- log("product: >>%s<<\n", product); ++ log_warning("version: >>%s<<\n", version); ++ log_warning("product: >>%s<<\n", product); + + if(version == NULL || (strlen(version) == 0)) + { +@@ -98,17 +98,17 @@ int test(char ***input) + } + + (*input)++; //expected product is +1 in the array +- log("'%s' == '%s'", product, **input); ++ log_warning("'%s' == '%s'", product, **input); + if (strcmp(product, **input) != 0) + goto ret; + + (*input)++; //expected version is +2 in the array +- log("'%s' == '%s'", version, **input); ++ log_warning("'%s' == '%s'", version, **input); + if (strcmp(version, **input) == 0) + retcode = 0; + + ret: +- log("retcode %i\n", retcode); ++ log_warning("retcode %i\n", retcode); + return retcode; + } + +-- +2.9.5 + diff --git a/libreport.spec b/libreport.spec index e68b9a8..74681be 100644 --- a/libreport.spec +++ b/libreport.spec @@ -2,11 +2,12 @@ %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} %define satyr_ver 0.22 +%define glib_ver 2.43 Summary: Generic library for reporting various problems Name: libreport Version: 2.9.1 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -17,6 +18,14 @@ Source1: autogen.sh Patch0000: 0001-augeas-trim-spaces-on-eol-around-value-separator.patch Patch0001: 0002-reporter-s-journal-add-journal-default-entries.patch Patch0002: 0003-reporter-s-journal-add-count-to-default-logs.patch +Patch0003: 0004-lib-fix-newline-issue-with-ask_password.patch +Patch0004: 0005-configure.ac-update-glib-min.-version-dependency.patch +Patch0005: 0006-lib-replace-hash-table-with-list.patch +Patch0006: 0007-dd-extend-create_dump_dir-to-allow-set-pid-in-dumpdi.patch +Patch0007: 0008-augeas-exclude-format-files.patch +Patch0008: 0009-bugzilla-add-check-if-option-d-was-entered.patch +Patch0009: 0010-reporter-mantisbt-Fix-typo-in-help.patch +Patch0010: 0011-logging-rename-log-to-log_warning.patch # git is need for '%%autosetup -S git' which automatically applies all the # patches above. Please, be aware that the patches must be generated @@ -40,6 +49,7 @@ BuildRequires: xmlto BuildRequires: newt-devel BuildRequires: libproxy-devel BuildRequires: satyr-devel >= %{satyr_ver} +BuildRequires: glib2-devel >= %{glib_ver} BuildRequires: glibc-all-langpacks BuildRequires: xmlrpc-c-devel @@ -57,6 +67,7 @@ BuildRequires: sed Requires: libreport-filesystem = %{version}-%{release} Requires: satyr >= %{satyr_ver} +Requires: glib2 >= %{glib_ver} Requires: xz Requires: lz4 @@ -731,8 +742,17 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/bugzilla_format_anaconda.conf.5.* %{_mandir}/man5/bugzilla_formatdup_anaconda.conf.5.* - %changelog +* Thu Aug 31 2017 Julius Milan 2.9.1-3 +- logging: rename log() to log_warning() +- reporter-mantisbt: Fix typo in help +- bugzilla: add check if option -d was entered +- dd: extend create_dump_dir to allow set pid in dumpdir name +- lib: fix to ensure order of login credentials when reporting using abrt-cli +- configure.ac: update glib min. version dependency +- lib: fix newline issue with ask_password +- Resolves: #1445669, #1481205 + * Thu Apr 13 2017 Matej Habrnal 2.9.1-2 - add journal default entries to reporter-systemd-journal - augeas: trim spaces on eol, around value separator From 5bd628274a25c422c69e0ae8a38669d1ad663c7f Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Wed, 13 Sep 2017 15:13:09 +0200 Subject: [PATCH 013/133] Introduce pid_for_children element from ns Resolves: #1489611 Signed-off-by: Matej Habrnal --- ...ent-python-Do-not-try-to-unlink-None.patch | 32 +++++++ ...uce-pid_for_children-element-from-ns.patch | 88 +++++++++++++++++++ libreport.spec | 10 ++- 3 files changed, 129 insertions(+), 1 deletion(-) create mode 100644 0003-client-python-Do-not-try-to-unlink-None.patch create mode 100644 0004-lib-Introduce-pid_for_children-element-from-ns.patch diff --git a/0003-client-python-Do-not-try-to-unlink-None.patch b/0003-client-python-Do-not-try-to-unlink-None.patch new file mode 100644 index 0000000..0d3604b --- /dev/null +++ b/0003-client-python-Do-not-try-to-unlink-None.patch @@ -0,0 +1,32 @@ +From 60c8ec5f937a28a5ec3d37f5d808c74fc4ef5735 Mon Sep 17 00:00:00 2001 +From: Matej Marusak +Date: Tue, 5 Sep 2017 10:48:31 +0200 +Subject: [PATCH 3/4] client-python: Do not try to unlink None + +Rhbz: #1416277 + +https://github.com/abrt/libreport/blob/master/src/client-python/reportclient/dnfdebuginfo.py#L135 +returns None when downloading fails. + +Signed-off-by: Matej Marusak +--- + src/client-python/reportclient/debuginfo.py | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/client-python/reportclient/debuginfo.py b/src/client-python/reportclient/debuginfo.py +index 0385f716..4390304e 100644 +--- a/src/client-python/reportclient/debuginfo.py ++++ b/src/client-python/reportclient/debuginfo.py +@@ -374,7 +374,8 @@ class DebugInfoDownload(object): + # I observed a zero-length file left on error, + # which prevents cleanup later. Fix it: + try: +- os.unlink(package_full_path) ++ if package_full_path is not None: ++ os.unlink(package_full_path) + except OSError: + pass + print(_("Downloading package {0} failed").format(pkg)) +-- +2.13.5 + diff --git a/0004-lib-Introduce-pid_for_children-element-from-ns.patch b/0004-lib-Introduce-pid_for_children-element-from-ns.patch new file mode 100644 index 0000000..4f6a300 --- /dev/null +++ b/0004-lib-Introduce-pid_for_children-element-from-ns.patch @@ -0,0 +1,88 @@ +From 5fba4820bd501fdaed6c77775808f12166c55399 Mon Sep 17 00:00:00 2001 +From: Matej Marusak +Date: Wed, 13 Sep 2017 08:09:35 +0200 +Subject: [PATCH 4/4] lib: Introduce pid_for_children element from ns + +From namespaces man pages: + +/proc/[pid]/ns/pid_for_children (since Linux 4.12) + This file is a handle for the PID namespace of child processes + created by this process. + +Signed-off-by: Matej Marusak +--- + src/include/internal_libreport.h | 2 +- + tests/proc_helpers.at | 39 ++++++++++++++++++++------------------- + 2 files changed, 21 insertions(+), 20 deletions(-) + +diff --git a/src/include/internal_libreport.h b/src/include/internal_libreport.h +index 3527e0e1..1df4cba3 100644 +--- a/src/include/internal_libreport.h ++++ b/src/include/internal_libreport.h +@@ -747,7 +747,7 @@ int get_env_variable(pid_t pid, const char *name, char **value); + #define PROC_NS_ID_USER 4 + #define PROC_NS_ID_UTS 5 + #define PROC_NS_ID_CGROUP 6 +-static const char * libreport_proc_namespaces[] = { "ipc", "mnt", "net", "pid", "uts", "user", "cgroup" }; ++static const char * libreport_proc_namespaces[] = { "ipc", "mnt", "net", "pid", "uts", "user", "cgroup", "pid_for_children" }; + + struct ns_ids { + ino_t nsi_ids[ARRAY_SIZE(libreport_proc_namespaces)]; +diff --git a/tests/proc_helpers.at b/tests/proc_helpers.at +index 35e9c7a5..4b118f33 100644 +--- a/tests/proc_helpers.at ++++ b/tests/proc_helpers.at +@@ -945,30 +945,31 @@ AT_TESTFUN([dump_namespace_diff], [[ + + void check_file_contents(const char *filename) + { +- static const char *expected; ++ char *expected; + struct stat st; +- if (stat("/proc/self/ns/cgroup", &st) < 0 && errno == ENOENT) { +- expected = "ipc : default\n" +- "mnt : default\n" +- "net : default\n" +- "pid : default\n" +- "uts : default\n" +- "user : default\n" +- "cgroup : unknown\n"; +- } +- else { +- expected = "ipc : default\n" +- "mnt : default\n" +- "net : default\n" +- "pid : default\n" +- "uts : default\n" +- "user : default\n" +- "cgroup : default\n"; +- } ++ ++ char const *pid_for_children = "default"; ++ char const *cgroup = "default"; ++ ++ if (stat("/proc/self/ns/cgroup", &st) < 0 && errno == ENOENT) ++ cgroup = "unknown"; ++ ++ if (stat("/proc/self/ns/pid_for_children", &st) < 0 && errno == ENOENT) ++ pid_for_children = "unknown"; ++ ++ expected = xasprintf("ipc : default\n" ++ "mnt : default\n" ++ "net : default\n" ++ "pid : default\n" ++ "uts : default\n" ++ "user : default\n" ++ "cgroup : %s\n" ++ "pid_for_children : %s\n", cgroup, pid_for_children); + + char *file = xmalloc_xopen_read_close(filename, NULL); + TS_ASSERT_STRING_EQ(file, expected, "Namespaces"); + free(file); ++ free(expected); + } + + TS_MAIN +-- +2.13.5 + diff --git a/libreport.spec b/libreport.spec index 0332686..043b2d4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -7,7 +7,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.2 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -15,6 +15,10 @@ Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done +#Patch0001: 0001-Translation-updates.patch +#Patch0002: 0002-spec-rename-Python-binary-packages.patch +Patch0003: 0003-client-python-Do-not-try-to-unlink-None.patch +Patch0004: 0004-lib-Introduce-pid_for_children-element-from-ns.patch # git is need for '%%autosetup -S git' which automatically applies all the # patches above. Please, be aware that the patches must be generated @@ -743,6 +747,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Wed Sep 13 2017 Matej Habrnal 2.9.2-2 +- Introduce pid_for_children element from ns +- Resolves: #1489611 + * Fri Aug 25 2017 Matej Habrnal 2.9.2-1 - Translation updates - logging: rename log() to log_warning() From b8624863e8340e50f6aad23100e8c85261655f46 Mon Sep 17 00:00:00 2001 From: Julius Milan Date: Thu, 2 Nov 2017 16:45:07 +0100 Subject: [PATCH 014/133] New upstream release 2.9.3 Signed-off-by: Julius Milan --- ...ent-python-Do-not-try-to-unlink-None.patch | 32 - ...uce-pid_for_children-element-from-ns.patch | 88 -- libreport.spec | 911 +----------------- sources | 2 +- 4 files changed, 44 insertions(+), 989 deletions(-) delete mode 100644 0003-client-python-Do-not-try-to-unlink-None.patch delete mode 100644 0004-lib-Introduce-pid_for_children-element-from-ns.patch diff --git a/0003-client-python-Do-not-try-to-unlink-None.patch b/0003-client-python-Do-not-try-to-unlink-None.patch deleted file mode 100644 index 0d3604b..0000000 --- a/0003-client-python-Do-not-try-to-unlink-None.patch +++ /dev/null @@ -1,32 +0,0 @@ -From 60c8ec5f937a28a5ec3d37f5d808c74fc4ef5735 Mon Sep 17 00:00:00 2001 -From: Matej Marusak -Date: Tue, 5 Sep 2017 10:48:31 +0200 -Subject: [PATCH 3/4] client-python: Do not try to unlink None - -Rhbz: #1416277 - -https://github.com/abrt/libreport/blob/master/src/client-python/reportclient/dnfdebuginfo.py#L135 -returns None when downloading fails. - -Signed-off-by: Matej Marusak ---- - src/client-python/reportclient/debuginfo.py | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/src/client-python/reportclient/debuginfo.py b/src/client-python/reportclient/debuginfo.py -index 0385f716..4390304e 100644 ---- a/src/client-python/reportclient/debuginfo.py -+++ b/src/client-python/reportclient/debuginfo.py -@@ -374,7 +374,8 @@ class DebugInfoDownload(object): - # I observed a zero-length file left on error, - # which prevents cleanup later. Fix it: - try: -- os.unlink(package_full_path) -+ if package_full_path is not None: -+ os.unlink(package_full_path) - except OSError: - pass - print(_("Downloading package {0} failed").format(pkg)) --- -2.13.5 - diff --git a/0004-lib-Introduce-pid_for_children-element-from-ns.patch b/0004-lib-Introduce-pid_for_children-element-from-ns.patch deleted file mode 100644 index 4f6a300..0000000 --- a/0004-lib-Introduce-pid_for_children-element-from-ns.patch +++ /dev/null @@ -1,88 +0,0 @@ -From 5fba4820bd501fdaed6c77775808f12166c55399 Mon Sep 17 00:00:00 2001 -From: Matej Marusak -Date: Wed, 13 Sep 2017 08:09:35 +0200 -Subject: [PATCH 4/4] lib: Introduce pid_for_children element from ns - -From namespaces man pages: - -/proc/[pid]/ns/pid_for_children (since Linux 4.12) - This file is a handle for the PID namespace of child processes - created by this process. - -Signed-off-by: Matej Marusak ---- - src/include/internal_libreport.h | 2 +- - tests/proc_helpers.at | 39 ++++++++++++++++++++------------------- - 2 files changed, 21 insertions(+), 20 deletions(-) - -diff --git a/src/include/internal_libreport.h b/src/include/internal_libreport.h -index 3527e0e1..1df4cba3 100644 ---- a/src/include/internal_libreport.h -+++ b/src/include/internal_libreport.h -@@ -747,7 +747,7 @@ int get_env_variable(pid_t pid, const char *name, char **value); - #define PROC_NS_ID_USER 4 - #define PROC_NS_ID_UTS 5 - #define PROC_NS_ID_CGROUP 6 --static const char * libreport_proc_namespaces[] = { "ipc", "mnt", "net", "pid", "uts", "user", "cgroup" }; -+static const char * libreport_proc_namespaces[] = { "ipc", "mnt", "net", "pid", "uts", "user", "cgroup", "pid_for_children" }; - - struct ns_ids { - ino_t nsi_ids[ARRAY_SIZE(libreport_proc_namespaces)]; -diff --git a/tests/proc_helpers.at b/tests/proc_helpers.at -index 35e9c7a5..4b118f33 100644 ---- a/tests/proc_helpers.at -+++ b/tests/proc_helpers.at -@@ -945,30 +945,31 @@ AT_TESTFUN([dump_namespace_diff], [[ - - void check_file_contents(const char *filename) - { -- static const char *expected; -+ char *expected; - struct stat st; -- if (stat("/proc/self/ns/cgroup", &st) < 0 && errno == ENOENT) { -- expected = "ipc : default\n" -- "mnt : default\n" -- "net : default\n" -- "pid : default\n" -- "uts : default\n" -- "user : default\n" -- "cgroup : unknown\n"; -- } -- else { -- expected = "ipc : default\n" -- "mnt : default\n" -- "net : default\n" -- "pid : default\n" -- "uts : default\n" -- "user : default\n" -- "cgroup : default\n"; -- } -+ -+ char const *pid_for_children = "default"; -+ char const *cgroup = "default"; -+ -+ if (stat("/proc/self/ns/cgroup", &st) < 0 && errno == ENOENT) -+ cgroup = "unknown"; -+ -+ if (stat("/proc/self/ns/pid_for_children", &st) < 0 && errno == ENOENT) -+ pid_for_children = "unknown"; -+ -+ expected = xasprintf("ipc : default\n" -+ "mnt : default\n" -+ "net : default\n" -+ "pid : default\n" -+ "uts : default\n" -+ "user : default\n" -+ "cgroup : %s\n" -+ "pid_for_children : %s\n", cgroup, pid_for_children); - - char *file = xmalloc_xopen_read_close(filename, NULL); - TS_ASSERT_STRING_EQ(file, expected, "Namespaces"); - free(file); -+ free(expected); - } - - TS_MAIN --- -2.13.5 - diff --git a/libreport.spec b/libreport.spec index 043b2d4..fe4ecd5 100644 --- a/libreport.spec +++ b/libreport.spec @@ -1,13 +1,13 @@ # platform-dependent %{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} -%define satyr_ver 0.22 +%define satyr_ver 0.24 %define glib_ver 2.43 Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.2 -Release: 2%{?dist} +Version: 2.9.3 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -15,10 +15,6 @@ Source1: autogen.sh # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done -#Patch0001: 0001-Translation-updates.patch -#Patch0002: 0002-spec-rename-Python-binary-packages.patch -Patch0003: 0003-client-python-Do-not-try-to-unlink-None.patch -Patch0004: 0004-lib-Introduce-pid_for_children-element-from-ns.patch # git is need for '%%autosetup -S git' which automatically applies all the # patches above. Please, be aware that the patches must be generated @@ -97,11 +93,8 @@ Development headers for libreport-web %package -n python2-libreport Summary: Python bindings for report-libs -# Is group correct here? - Requires: libreport = %{version}-%{release} -Requires: dnf -Provides: report = 0:0.23-1 -Obsoletes: report < 0:0.23-1 +Requires: python2-dnf # in report the rhtsupport is in the main package, so we need to install it too # report is only in RHEL6, we do not need to carry the dependency to newer RHELs %if 0%{?rhel} == 6 @@ -129,7 +122,7 @@ Requires: libreport >= %{version}-%{distfreerelease} %else Requires: libreport = %{version}-%{release} %endif -Requires: dnf +Requires: python3-dnf %{?python_provide:%python_provide python3-libreport} # Remove before F30 Provides: %{name}-python3 = %{version}-%{release} @@ -409,7 +402,16 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaXorg.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaLibreport.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaJava.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaJavaScript.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataCCpp.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataKerneloops.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataPython.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDatavmcore.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataxorg.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataLibreport.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataJava.xml +rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataJavaScript.xml rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel.conf +rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_uReport.conf rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel_bugzilla.conf rm -f %{buildroot}%{_mandir}/man5/report_rhel.conf.5 @@ -654,6 +656,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/plugins/rhtsupport.conf %{_datadir}/%{name}/conf.d/plugins/rhtsupport.conf %{_datadir}/%{name}/events/report_RHTSupport.xml +%{_datadir}/%{name}/events/report_RHTSupport_AddData.xml %{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.rhtsupport.xml %config(noreplace) %{_sysconfdir}/libreport/events.d/rhtsupport_event.conf %{_mandir}/man1/reporter-rhtsupport.1.gz @@ -706,8 +709,17 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_datadir}/%{name}/workflows/workflow_RHELLibreport.xml %{_datadir}/%{name}/workflows/workflow_RHELJava.xml %{_datadir}/%{name}/workflows/workflow_RHELJavaScript.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataCCpp.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataJava.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataKerneloops.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataLibreport.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataPython.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDatavmcore.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataxorg.xml +%{_datadir}/%{name}/workflows/workflow_RHELAddDataJavaScript.xml %{_datadir}/%{name}/workflows/workflow_uReport.xml %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel.conf +%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_mandir}/man5/report_rhel.conf.5.* %{_mandir}/man5/report_uReport.conf.5.* @@ -747,6 +759,25 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Thu Nov 02 2017 Julius Milan 2.9.3-1 +- Translation updates +- commit to delete +- workflows: fix description in workflow_RHELJavaScript.xml.in +- workflows: add workflow for adding data to existing case +- client-python,report-python: Allow python to be optional at build time +- ignored words: add SYSTEMD_NSS_BYPASS_BUS +- reporter-ureport: add 'ProcessUnpackaged' option +- spec: add workflow for adding data to existing case +- rep-sys-journal: fix in finding executable basename +- remove old obsolete +- Group is not used any more +- remove old changelogs +- requires pythonX-dnf instead of dnf +- doc: fix obsolete doxygen tags & complains +- lib: Introduce pid_for_children element from ns +- client-python: Do not try to unlink None +- spec: rename Python binary packages + * Wed Sep 13 2017 Matej Habrnal 2.9.2-2 - Introduce pid_for_children element from ns - Resolves: #1489611 @@ -959,859 +990,3 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : * Wed Jul 22 2015 Matej Habrnal 2.6.2-2 - Use a dgettext function returning strings instead of bytes - -* Fri Jul 17 2015 Jakub Filak 2.6.2-1 -- avoid starvation in processes concurrently accessing a dump directory -- bugzilla: Add check for extra-cc file - -* Fri Jul 03 2015 Matej Habrnal 2.6.1-1 -- add functionality to use consumer certificate -- improve client.h documentation -- support new dump dir element 'tid' -- reportclient: minor python style fixes -- fix dnf logging -- don't log attempts to load non-existent files -- fix in dialog ask_yes_no_save_result - -* Wed Jun 17 2015 Fedora Release Engineering - 2.6.0-3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_23_Mass_Rebuild - -* Thu Jun 11 2015 Jakub Filak 2.6.0-2 -- remove pygobject3 from Requires of libreport-gtk -- Resolves: #1230420 - -* Tue Jun 09 2015 Jakub Filak 2.6.0-1 -- harden the code against directory traversal, symbolic and hard link attacks -- fix a bug causing that the first value of AlwaysExcludedElements was ignored -- fix missing icon for the "Stop" button icon name -- switch the default dump dir mode to 0640 -- fix races in dump directory handling code -- improve development documentation -- translations updates - -* Wed May 20 2015 Matej Habrnal 2.5.1-2 -- reporter-mantisbt: switch from 'analyzer' to 'type' -- report client: provide cpio log when unpacking fails -- report client: check owner of /var/cache/abrt-di when unpacking fails -- reporter-mantisbt: add event for reporting AVCs -- translations updates -- bugzilla: Spell Bugzilla, not BZ in UI - -* Thu Apr 09 2015 Jakub Filak 2.5.1-1 -- Translation updates -- problem_data: cache problem_item size - -* Sat Mar 21 2015 Jakub Filak 2.5.0-2 -- remove libreport-python from libreport's Requires - -* Wed Mar 18 2015 Jakub Filak 2.5.0-1 -- spec: require dnf instead of yum -- Port reportclient to python3 -- reportclient: introduce DNF debug info downloader -- Python 3 compatibility -- report-python: fix getVersion_fromOSRELEASE -- ignored words: ignore lxqt-openssh-askpass -- spec: don't pull libreport-python with libreport -- Resolves: #1156485, #1168494 - -* Sat Feb 21 2015 Till Maas - 2.4.0-3 -- Rebuilt for Fedora 23 Change - https://fedoraproject.org/wiki/Changes/Harden_all_packages_with_position-independent_code - -* Fri Feb 20 2015 Jakub Filak 2.4.0-2 -- bump required satyr verion - -* Fri Feb 20 2015 Jakub Filak 2.4.0-1 -- introduce reporter-mantisbt -- introduce global configuration -- gui: try to reduce false positive sensitive words -- lib: add Problem Format API -- Resolves: #1168494 - -* Mon Dec 08 2014 Jakub Filak 2.3.0-8 -- fix several python3 incompatibilities -- switch back from FAF2 to FAF - -* Fri Nov 28 2014 Jakub Filak 2.3.0-7 -- anaconda: filter out rootpw lines -- highglit OpenStack related strings -- ureport: do not bother user with the configuration window - -* Thu Nov 13 2014 Jakub Filak 2.3.0-6 -- ureport: do not use 'rhsm' SSL auth by default - -* Thu Nov 06 2014 Jakub Filak 2.3.0-5 -- Prevent duplicate values for CODE_* fields being logged to journal -- ureport and rhtsupport bug fixes -- update Package URL - -* Fri Oct 17 2014 Jakub Filak 2.3.0-4 -- ureport: use FAF2 server - -* Mon Oct 13 2014 Jakub Filak 2.3.0-3 -- ureport: fix a bug in the response parser -- upload: don't ask for password if the env var is empty string - -* Wed Oct 08 2014 Jakub Filak 2.3.0-2 -- Require satyr-0.15 - -* Mon Oct 06 2014 Jakub Filak 2.3.0-1 -- Translation updates -- uploader: correct capitalization of the event name -- uploader: read credentials from environment variables -- uploader: handle access denials and ask for updated credentials -- ureport: polish public API -- bugzilla: add comment to closed bugs too -- corrected man pages -- augeas: exclude bugzilla format configurations -- add new workflows for Uploader, Mailx and Logger -- make_desc: add reason to the list -- lib: use userfriendly order in the make_description -- fix bugzilla bug formating for libreport analyzer -- lib: make_description show not-reportable - -* Tue Sep 09 2014 Jakub Filak 2.2.3-7 -- reporting GUI: allow users to run it multiple times -- Resolves: #1134407 - -* Mon Sep 01 2014 Jakub Filak 2.2.3-6 -- add "Details" button on the screen with comment -- terminate reporting after the emergency analysis -- reduce the amount of log messages -- use symbolic icons -- parse release version from os-release (Python) -- Resolves: #1133549 - -* Tue Aug 19 2014 Jakub Filak 2.2.3-5 -- add the "Repeat" button to the reporting wizard -- a bunch of GUI improvements -- fix a bug in logging causing reporter-ureport to crash - -* Sun Aug 17 2014 Fedora Release Engineering - 2.2.3-4 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_22_Mass_Rebuild - -* Fri Jul 25 2014 Jakub Filak 2.2.3-3 -- fix build with json-c-0.12 - -* Wed Jul 23 2014 Jakub Filak 2.2.3-2 -- reporter-ureport: attach anonymous comment -- gui: close dialogues on Enter key -- gui: support Enter & 2Click in Preferences list -- gui: fix help text for screencasting -- gui: wrap lines for human readable files on Data review page -- gui: select the first item in the configuration list -- gui: make the preferences dialogue modal for parents - -* Tue Jul 08 2014 Jakub Filak 2.2.3-1 -- wizard: Do not highlight sensitive words in user's comment -- bugzilla: show description for all configuration options -- wizard: use a tab for Advanced opts instead of an expander -- mailx: improve notification e-mail format -- configure: Support cross compiling with python3 -- ignored words: add well known SELinux messages -- Resolves: #974746, #1111729, #1111734 - -* Sat Jun 07 2014 Fedora Release Engineering - 2.2.2-5 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild - -* Tue May 27 2014 Kalev Lember - 2.2.2-4 -- Rebuilt for https://fedoraproject.org/wiki/Changes/Python_3.4 - -* Wed Apr 30 2014 Jakub Filak - 2.2.2-3 -- improve User Experience in Anaconda - -* Thu Apr 24 2014 Jakub Filak - 2.2.2-2 -- Bugzilla: pass Bugzilla_token in every XML RPC call - -* Sun Apr 20 2014 Jakub Filak 2.2.2-1 -- stop using deprecated json-c functions -- bugzilla: try to avoid usage of 'private' group -- spec: install ignored_words.conf manual page -- wizard: extended the manual pages -- localization: fix gettext -- wizard: make the custom search case insensitive -- use a better label for the forbidden words button - -* Mon Apr 07 2014 Jakub Filak 2.2.1-2 -- include 'package' in AVC bugzilla bug reports - -* Fri Apr 04 2014 Jakub Filak 2.2.1-1 -- update the list of ignored words -- wizard: introduce the searched words list -- report-gtk: confirm the ask dialogs on 'Enter' -- spec: provide default config for reporter-upload -- Provide default config for reporter-upload -- config: do not export empty environment variables -- spec: byte-compile py files with rpm scripts - -* Wed Mar 05 2014 Jakub Filak 2.2.0-1 -- python: build python api for py3 -- Bugzilla: fedora_contrib_private group ID for the private bugs -- remove invalid bytes from 'sv' strings -- client API: return empty string instead of NULL -- introduce 'watch_Bugzilla' event -- ignored words: add SSH_ASKPASS words -- introduce import-event-options in xml event definitions -- correct name of RH Customer Portal -- Fix typos in error messages -- Translation updates - -* Wed Mar 05 2014 Karsten Hopp 2.1.12-4 -- don't run tests on ppc* until rhbz 1070892 is fixed - -* Tue Feb 18 2014 Jakub Filak 2.1.12-3 -- fix a pair of typos in error messages -- add libpciaccess.so to the list of ignored keywords -- translation updates -- Resolves: #1064209 - -* Mon Feb 10 2014 Jakub Filak 2.1.12-2 -- fix loading of localized strings from XML files -- fix loading of default event configuration files -- provide SYSLOG_FACILITY when logging through journal - -* Thu Jan 30 2014 Jakub Filak 2.1.12-1 -- fix loading of the user list of ignored words -- report-cli: use the Client API for communication to user -- add more forbidden words -- a better message for invalid data in backtrace_rating -- ureport: add support for client-side authentication -- Export plugin config dir in pkg-config -- add Java reporting workflows -- define DBus config interfaces for all plugins -- add a workflow for libreport type problems - -* Wed Jan 8 2014 Peter Robinson 2.1.11-3 -- Don't use deprecated GTK3 API -- Fix unit tests - -* Wed Jan 8 2014 Peter Robinson 2.1.11-2 -- Build latest version on F-21/rawhide -- Fix descriptions - -* Wed Jan 08 2014 Jakub Filak 2.1.11-1 -- Update translations -- add type agnostic functions for map_string_t -- %%description spelling fix. -- update titles of RHTS workflows -- add Anaconda Bugzilla reporting workflows for RHEL -- add Bugzilla reporting workflows for RHEL - -* Wed Dec 11 2013 Jakub Filak 2.1.10-1 -- bugzilla: no extra email notification on URL addition -- Make make_description() output less confusing -- Ensure 'long long unsigned' in printf format args -- make_description: add an option for URLs from reported_to -- add accountsservice into ignored words -- Put back VERBn prefixes for few logging calls -- debuginfo: fix clean_up function call -- augeas: trim spaces arround '=' -- spec: add augeas-devel to build requires -- load/save configuration via augeas -- create augeas lens for libreport -- Fix typo in a string -- spec: install ureport conf file and man page -- Update reporter-ureport manual pages -- ureport: add the configuration file -- anaconda: use workflow in the report-cli event -- report-cli: add support for workflows -- wizard: do not show 'show log' expander if log is empty -- ureport: print the error response body only in verbose mode -- Load a config file from several directories -- Export EXIT_STOP_EVENT_RUN in python modules -- reporter-bugzilla: if adding to existing BZ, clearly flag comment as a dup. -- Fix a small mistake in "Use log_ family instead of VERBn log calls" commit -- ureport: implement attaching of contact email -- Do not load "always editable" files if they are HUGE. Fixes rhbz1010167. -- shorten default Bugzilla bug summary format -- Update translations -- XML parser: keep region specific translation texts -- Resolves: #1009730 - -* Sat Oct 26 2013 Jakub Filak 2.1.9-1 -- rephrase a message for missing configuration -- ask for missing configuration instead of dying -- Client API: introduce non-iteractive mode -- spec: add systemd-devel to BuildRequires -- Use log_ family instead of VERBn log calls -- Add journald support -- Modify logging to use various logging levels -- Include hostname in mailx notification -- enable reporting to Red Hat Support tool for anaconda bugs -- bugzilla: set URL field -- fix an overflow condition in parse time fn for x32 arch -- add a short explanation of private tickets - related rhbz#1011916 -- don't use popup to ask for a private ticket - related rhbz#1011916 - -* Fri Oct 04 2013 Jakub Filak 2.1.8-1 -- disable rhel/fedora workflows for anaconda -- added whitelist for sensitive data - rhbz#1009730 rhbz#896246 -- ureport: always add BTHASH link to a report -- reprot-gtk: underline tab titles with sensitive information -- introduce FILENAME_EXPLOITABLE; related to abrt/abrt#703 - -* Wed Sep 11 2013 Jakub Filak 2.1.7-1 -- Fix problem_item_format() to work properly after 2038 on x32. #691 -- Use proper json-c requirement in libreport-web.pc. -- abrt-cli info: even -s 10 should show one-liners. #690 -- add checks for existing dumpdir items - closes #164 -- Create helper functions for sha1-hashing strings. #694 -- can now use custom repo filters for enabling repos, related abrt/abrt#688 -- add docstrings, remove global variable - related #171 -- fixed exception handling - closes #173 -- added checks for locked dump directory to dd_* functions, closes #133 -- fixed the symlinks handling in get_file_list abrt/abrt#686 -- make the build in the the build directory to not pollute the source tree -- fixed debugInfoDownload so that it can process local repos - closes #48 -- Increase text size limit from 1Mb to 8 MB. rhbz#887570. -- print warning when there is not engough free space for debuginfos, closes #170 -- autogen.sh: improve dependency parser -- ignore directories without type element - rhbz#958968 -- abrt_xmlrpc: increase XML_SIZE_LIMIT to 4 mbytes. rhbz#961520. -- ask user to create a private report if it contains sensitive data - rhbz#960549 -- updated translation rhbz#860555 -- updated transifex url -- do not leak file rhbz#997871 -- in KDE session open URLs in kde-open -- report-gtk: use wrapped text for warning labels -- spec: remove abrt-screencast -- remove obsoleted abrt-screencast -- Fix create_symlink_lockfile() to not emit ENOENT when asked not to. -- do not store potentially big data in /tmp -- New public function create_symlink_lockfile() - -* Mon Jul 29 2013 Jakub Filak 2.1.6-2 -- link with gobject libraries -- use RHTSupport in RHEL workflows - -* Fri Jul 26 2013 Jakub Filak 2.1.6-1 -- add related packages version in emergency event -- replace functions deprecated in Gtk-3.10 with their substitutes -- fixed the bugzilla private group names rhbz#985881 -- workflows: add Anaconda work flow for RHEL -- add missing manual pages for configuration files, binaries and scripts -- added options to create private bz tickets rhbz#803772 -- skip the workflow selection if there is only 1 available closes #167 -- added missing workflows for Fedora rhbz#866027 -- spec: double up percent signs in chagelog entries -- spec: make anaconda package description more generic -- spec: install RHEL anaconda work flow -- spec: added new workflow files rhbz#866027 -- spec: build only workflow subpkg relevant for host's OS -- spec: install all manual pages -- spec: install only documentation files -- spec: drop unnecessary Obsoletes and Provides -- spec: add manual pages to packages -- spec: specify all config files -- spec: replace btparser with satyr -- move non-conf XML files from /etc/libreport/ to /usr/share/libreport/ -- Update satyr support, drop btparser compatibility -- fixed typo in config file related #866027 -- resize the config window upon collapsing Advanced section -- rhbz: test xmlrpc env for errors in abrt_xmlrpc_call_params() -- rhbz: test rhbz_new_bug() return value for errors -- wizard: show accurate messages -- spec: add dependency on fros rhbz#958979 -- use fros instead of hard dependency on recordmydesktop rhbz#958979 - -* Tue Jul 02 2013 Jakub Filak 2.1.5-2 -- reporter-bugzilla: test return values for errors -- Resolves: #980228 - -* Fri Jun 14 2013 Jakub Filak 2.1.5-1 -- make the uploader event available for all report types -- ureport: add conversion from abrt vmcore type to ureport KERNELOOPS type -- fixed relro flags rhbz#812283 -- rhbz: don't pass NULL in platform argument -- add function getting information about dump dir for uid -- anaconda: add proper configuration -- rhbz: do not try to attach empty files -- try to delete dump dirs using abrtd in the first step -- workflow config: use scrollbars instead of enormous window size -- Resolves: #963020 - -* Fri May 10 2013 Jiri Moskovcak 2.1.4-5 -- removed dependency on recordmydesktop rhbz#959475 - -* Mon May 06 2013 Jakub Filak 2.1.4-4 -- create last_occurrence at the time of the first crash - -* Fri May 03 2013 Jakub Filak 2.1.4-2 -- update translation -- reporter-bugzilla: provide version of libreport - -* Mon Apr 29 2013 Jakub Filak 2.1.4-1 -- support /etc/os-release -- added flag to not retry locking the incomplete problem dir -- ureport: save solutions in not-reportable item -- wizard: make value column click-sortable too -- wizard: fix clickability of the item list column header -- wizard: eliminate evd->error_msg member -- wizard: remove a bunch of evd->foo members -- debuginfo downloader should enable repos matching *debug* closes #138 -- Replace "THANKYOU" with EXIT_STOP_EVENT_RUN exit code (70) -- debuginfo downloader: fix DebugInfoDownload::download() error paths. -- report-gtk: handle user cancellation gracefully -- logging: refine errors reporting -- emit a message when searching bugzilla for duplicates closes #151 -- reporter-upload: create tarball with the name based on directory's name -- reporter-rhtsupport: generate archive name from problem dir name -- added report-cli event for anaconda should help with rhbz#950544 -- ss: skip option holding NULL values -- spec: added new event for anaconda reporting rhbz#926916 -- distinguish the event configuration by problem type in the UI closes #149 -- report-gtk: show Next Step btn at workflow start -- curl upload helper: upload data with "application/octet-stream" content type -- reporter-rhtsupport: fix hint query to use correct URL - -* Thu Apr 4 2013 Jiri Moskovcak 2.1.3-2 -- fixed reporting from anaconda -- Resolves: #926916 - -* Wed Mar 27 2013 Jakub Filak 2.1.3-1 -- rhbz: get id of duplicate from correct field -- change the "exited with" message with something less technical closes #143 -- Integration with satyr -- dump_dir_accessible_by_uid(): clear errno if error didn't occur -- reporter-rhtsupport: improve logging -- reporter-rhtsupport: upload file to BigFileURL if it is large -- dd: document used errno values in dump_dir_accessible_by_uid() -- add rhel package with appropriate workflow definitions -- add workflow definitions for RHEL -- improve is_text_file() to not treat valid Unicode as bad_chars -- reporter-rhtsupport: fix double-free error -- reporter-upload: move file upload function to lib/ -- reporter-upload: factor out HTTP PUT upload -- reporter-rhtsupport: skip hints check if uploaded data is really large -- reporter-rhtsupport: make -t[CASE_ID] work without FILEs. Closes #140 -- reporter-rhtsupport: factor out tarball creation -- RHTS support: regularize order of functions and comments -- fread_with_reporting: make progress indicator less noisy -- report-gtk: update excluded elements check boxes before emergency analysis event -- Resolves: #921941 - -* Fri Mar 22 2013 Jakub Filak 2.1.2-2 -- add a patch which fixes a problem with empty archives in emergency analysis - -* Tue Mar 19 2013 Jakub Filak 2.1.2-1 -- always treat os-release as textual related to rhbz#922433 -- is_text_file(): bump allowable non-ASCII chars from 2%% to 10%%. Closes rhbz#922433 -- report-gtk: don't clear warnings after reporting is finished -- report-gtk: show tabs only in verbose expert mode -- report-gtk: prettify the workflow buttons rhbz#917694 -- report-gtk: add a button to report reporting failures -- uReport: do not show URL twice in error output -- uReport: detect missing type field at client side -- uReport: add more explanatory message when upload fails -- uReport: improve messages. Closes #579 -- workflows: a less confusing event name for reporting to Fedora infrastructure -- workflows: correct an event name for reporting to Fedora in anaconda config -- fixed workflow localization closes #137 -- run_event_state: expose children_count in python wrapper -- add the proxy options to the addvanced section of event configurations -- don't suid before running yum related to rhbz#759443 -- update translation -- ss: stop reconnecting to the session bus -- ss: destroy all timeout GSources attached to the main context -- ss: add a timeout to the waiting for the Completed signal -- dd: convert time at lock time -- spawn_next_command: make process group creation optional -- fork_execv_on_steroids: fix close/move order of fds, move getpwuid out of fork -- problem API: generate UUID if is missing instead of DUPHASH -- fix logic of 'Dont ask me again' dialogues (stop returning true for all options) -- make [p]error_msg[_and_die] more fork-in-multithreaded-app safe -- Make forking code paths more robust. -- curl_debug: fix use of "%%.*s" (need to pass an int, not size_t) -- curl_debug: prettify debug output -- Resolves: #871126, #885055, #890778, #901467, #916389, #917684, #917694, #919536, #922433, #923117 - -* Thu Feb 07 2013 Jakub Filak 2.1.1-1 -- move 'reporter-mailx' from post-create event to notify(-dup) event -- reporter-bugzilla: use base64 XMLRPC type for encoded data instead of string type -- ureport: fix extra quoting when reporting error messages -- Resolves: #908210 - -* Tue Feb 05 2013 Jakub Filak 2.1.0-2 -- configure libreport to be in conflict with abrt < 2.1.0 - -* Mon Feb 04 2013 Jakub Filak 2.1.0-1 -- dd: unify error handling in save_binary_file() -- dd_sanitize: don't sanitize symlinks -- rpm: preserve old configuration for 2.0.20-2 -- don't require recordmydesktop on rhel - -* Wed Dec 19 2012 Jiri Moskovcak 2.0.20-1 -- New version 2.0.20 -- updated po files -- add abrt-screencast to POTFILES.in -- added screen casting support to the wizard -- fix memory leaks in workflow code -- report_problem_in_dir(): make LIBREPORT_DEL_DIR work -- add Yes/No dialog saving answer -- refactor: move ask_yes_no_save_result from wizard to libreport-gtk -- added anaconda workflows rhbz#885690 -- report-python: export dd_delete_item too -- report-python: export DD_OPEN_READONLY too -- strtrimch: optimize it a bit -- show only workflows applicable to actual problem directory -- report-gtk: destroy global text cache only once -- change rules for FILENAME_NOT_REPORTABLE to always include trailing period. -- ask for BZ login/BZ pwd if Login attempt failed -- ask for BZ login/BZ password if not provided by conf -- remove new line from ask/ask_password responses -- add ask_yes_no_yesforever() to Python client API -- make client API independent on translation -- run_event: use client functions for the communication callbacks -- clean the workflow buttons when refreshing the event page -- Fix a bug - inverted check for failed rename() call -- wrap the not_reportable label .trac#908 -- don't show events without configuration in preferences .trac#881 -- - implemented saving/loading configuratio for workflows - related to trac#822 -- reporter-bz: add AVC's description added to BZ comment -- add microseconds to dump dir name (problem ID) -- teach reporter-bugzilla to read BZ ID from reported_to element -- teach reporter-bugzilla to add reporter to CC -- introduce a function deleting dd's element -- introduce a function getting no. of Bytes of dd's element -- make event config name immutable -- fixed segv in the last commit -- made struct workflow private related to trac#822 -- don't show the spinner if the problem is not reportable trac#852 -- made the config_item_info structure private -- added workflows trac#822 -- added x,--expert cmdline option to enable expert mode -- switch comment and event selector page -- use get_ and set_ functions to access event_config_t -- reporter-bz: don't return NULL on %%non_existing_item%% - use "" instead -- refactoring the xml and conf loader code related to trac#822 -- reporter-bugzilla: add a --debug option -- reporter-bz: fix a summary line formatting bug -- let logging_callback and post_run_callback members be None -- expose make_run_event_state_forwarding() in Python API -- reporter-bz: change syntax of bugzilla_format_*.conf to require "text::", not "text:" -- reporter-bz: add support for line continuation and simple text in bugzilla_format*.conf - -* Mon Dec 03 2012 Jakub Filak 2.0.19-3 -- add a description of AVC to bugzilla comment 0 - -* Mon Nov 26 2012 Jakub Filak 2.0.19-2 -- fix bugzilla summary formatting -- Resolves: #879846 - -* Wed Nov 14 2012 Jakub Filak 2.0.19-1 -- introduce a new formating feature for Bugzilla plugin -- use gtk_show_uri() instead of own launcher -- update kerneloops urls -- don't force the minimal rating trac#854 -- add support for forwarding of report client requests -- fix i18n in event client communication protocol -- add event name to the error message - can't get secret item -- switch all load_conf_file() calls to use skipKeysWithoutValue=false -- hide the spinner when the event processing is finishes trac#852 -- add a method for loading of configuration of a single event -- unlock secret collection only on meaningful demand -- fix secret item look up for gnome-keyring - -* Thu Nov 01 2012 Jakub Filak 2.0.18-1 -- reporter-bz: tighten up checking that BZ server gave us its version; fix recently broken settings parsing -- reporter-bz: make selinux-policy special case controllable from config file -- reporter-bz: if we create a new bug but cross-version dup exists, add a note -- reporter-bz: make rhbz_search_duphash static, use it more widely - -* Wed Oct 24 2012 Jakub Filak 2.0.17-1 -- update CWD after stealing of a dump directory -- get product/version from system configuration -- shorten bz summary if its length exceeds 255 chars -- add full kerneloops to the uReport -- reporter-bz: require bz version match when searching for dups. Closes rhbz#849833 -- reporter-bz: eliminate bugzilla_struct::b_product - use auto var instead -- Move struct bugzilla_struct to its only user, reporter-bugzilla.c -- reporter-bz: do not needlessly open dd if -f; assorted small fixes -- added relro to reportclient.so and _pyreport.so rhbz#812283 -- bz reporter: include ROOTDIR, OS_RELEASE_IN_ROOTDIR, EXECUTABLE elements -- Fix report-newt segfault -- Resolves: #741647, #812283, #849833, #867118, #869032 - -* Thu Oct 11 2012 Jakub Filak 2.0.16-1 -- expand events from a chain and process expanded events separately -- report-gtk: move selection of event to a right place -- fix a crash while report-gtk startup (use the correct variable) -- wizard: allow "non-reportable" reporting for experts; disallow it for non-experts -- fix typo in function name, remove unnecessary forward declaratioins -- wizard: fix a thinko in last commit (thanks Jakub) -- wizard: check for NON_REPORTABLE file, stop if it exists.FILE -- wizard: remove unnecessary if (1) {...} block. No code changes -- don't update the selected event while processing it -- check D-Bus err name without leaking nor crashing -- ureport: always include offset -- add Makefile target release-fix -- Resolves: #864803, #864803, #863595 - -* Fri Oct 05 2012 Jakub Filak 2.0.15-1 -- remove unnecessary flag from words highlighting functions -- report-gtk: rework forbidden words highlighting -- add xmalloc_fopen_fgetline_fclose helper for reading one-line files -- update GUI before highlighting of forbidden words -- clear warnings after switching to a next page -- tweak conditions in show next forbidden word functions -- reporter-ureport: respect chrooted os_release -- Fix typos. -- rhbz#861679: report-gtk: immediately release dump directory lock -- add a few helpers for reading files as one malloced block - -* Fri Sep 21 2012 Jiri Moskovcak 2.0.14-1 -- added error callback to get notification about download failure rhbz#786640 -- rhbz#767186: show a link to a page describing the ABRT configuration -- spec: silence rpmdiff rhbz#857425 -- don't show the credential in logs rhbz#856960 -- rhbz#852165: warn if adding commands without any rule condition -- rhbz#851855: process ureport server errors correctly -- reporter-bugzilla: fix adding users to CC. (Partially?) closes rhbz#841338 -- Resolves: #786640, #767186, #857425, #856960, #852165, #851855, #841338 - -* Wed Aug 29 2012 Jakub Filak 2.0.13-2 -- increment the release number due to rebuild for F17 package - -* Tue Aug 21 2012 Jakub Filak 2.0.13-1 -- rhbz#741255: don't autodetect executable for sealert reports -- reporter-ureport: save backtrace hash to reported_to -- trac#683: show the description file in bugzilla comment 0 -- trac#684: report-gtk saves only loaded files -- reporter-ureport: allow sending attachments -- event_config_dialog: make it resizable; tweak Uploader hint -- add python binding for problem_data_send_to_abrt -- reporter-ureport: attach bug ID from reported_to -- reporter-ureport: make configurable only URL to a server -- Resolves: #741255 - -* Wed Aug 15 2012 Jakub Filak 2.0.12-5 -- rhbz#741255: don't autodetect executable for sealert reports -- show message from the server for known uReports -- trac#678: reporter-bugzilla: do not attach empty files -- Resolves: #741255 - -* Tue Aug 14 2012 Jakub Filak 2.0.12-4 -- rhbz#846389: generate koops description according to rhbz std template -- trac#556: skip not provided bz bug description template fields -- report-gtk: don't log THANKYOU message -- added internal_libreport.h into POTFILES.in rhbz#801255 -- updated po files -- Resolves: #801255, #846389 - -* Fri Aug 10 2012 Jakub Filak 2.0.12-3 -- wizard: small changes to message texts and one function name -- trac#623: dd_opendir() fails if time file doesn't contain valid time stamp -- trac#660: report-cli asks for premission to send sensitive data -- trac#660: report-gtk asks for permission to send sensitive data -- trac#660: report-gtk: introduce generic ask_yes_no() function for options -- trac#660: add support for sendining-sensitive-data event option -- Do not check for analyzer == "Kerneloops" when appending "TAINTED" msg -- fix leaks in list_possible_events() - -* Tue Aug 7 2012 Jakub Filak 2.0.12-2 -- report-gtk: fixed bug in automatic running of next event -- don't try to delete dump dir which doesn't exist rhbz#799909 -- Resolves: #799909 - -* Fri Aug 3 2012 Jakub Filak 2.0.12-1 -- new upstream release -- trac#642: run the next event if the current one finished without errors -- trac#641: don't allow event chain to continue, if user don't want to steal a directory -- trac#640: report-gtk replaces 'Forward' button with 'Close' button on finished reporting -- Fix bugs uncovered by Coverity. Closes rhbz#809416 -- Resolves: #809416 - -* Tue Jul 31 2012 Jiri Moskovcak 2.0.11-1 -- new upstream release - -* Thu Jul 19 2012 Fedora Release Engineering - 2.0.10-5 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild - -* Fri Jun 01 2012 Jiri Moskovcak 2.0.10-4 -- fixed build on rhel7 - -* Mon May 14 2012 Jiri Moskovcak 2.0.10-3 -- fixed compatibility with bugzilla 4.2 -- Resolved: #820985, #795548 - -* Mon Apr 02 2012 Jiri Moskovcak 2.0.10-2 -- added cgroups filename define - -* Mon Mar 26 2012 Jiri Moskovcak 2.0.10-1 -- updated to latest upstream - -* Mon Jan 23 2012 Dan Horák - 2.0.8-6 -- rebuilt for json-c-0.9-4.fc17 - -* Fri Jan 13 2012 Fedora Release Engineering - 2.0.8-5 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_17_Mass_Rebuild - -* Tue Dec 20 2011 Nikola Pajkovsky 2.0.8-4 -- 768647 - [abrt] libreport-plugin-bugzilla-2.0.8-3.fc16: libreport_xatou: - Process /usr/bin/reporter-bugzilla was killed by signal 11 (SIGSEGV) - -* Fri Dec 09 2011 Jiri Moskovcak 2.0.8-3 -- fixed few crashes in bodhi plugin - -* Thu Dec 08 2011 Jiri Moskovcak 2.0.8-2 -- fixed crash in bodhi plugin -- re-upload better backtrace if available -- fixed dupe finding for selinux -- don't duplicate comments in bugzilla -- fixed problem with empty release - -* Tue Dec 06 2011 Jiri Moskovcak 2.0.8-1 -- new version -- added bodhi plugin rhbz#655783 -- one tab per file on details page rhbz#751833 -- search box search thru all data (should help with privacy) rhbz#748457 -- fixed close button position rhbz#741230 -- rise the attachment limit to 4kb rhbz#712602 -- fixed make check (rpath problem) -- save chnages in editable lines rhbz#710100 -- ignore backup files rhbz#707959 -- added support for proxies rhbz#533652 -- Resolves: 753183 748457 737991 723219 712602 711986 692274 636000 631856 655783 741257 748457 741230 712602 753183 748457 741230 712602 710100 707959 533652 - -* Sat Nov 05 2011 Jiri Moskovcak 2.0.7-2 -- bumped release - -* Fri Nov 04 2011 Jiri Moskovcak 2.0.7-1 -- new version -- added support for bodhi (preview) -- dropped unused patches -- reporter-bugzilla/rhts: add code to prevent duplicate reporting. Closes rhbz#727494 (dvlasenk@redhat.com) -- wizard: search thru all items + tabbed details rhbz#748457 (jmoskovc@redhat.com) -- wizard: add "I don't know what caused this problem" checkbox. Closes rhbz#712508 (dvlasenk@redhat.com) -- reporter-bugzilla: add optional 'Product' parameter. Closes rhbz#665210 (dvlasenk@redhat.com) -- rhbz#728190 - man pages contain suspicious version string (npajkovs@redhat.com) -- reporter-print: expand leading ~/ if present. Closes rhbz#737991 (dvlasenk@redhat.com) -- reporter-rhtsupport: ask rs/problems endpoint before creating new case. (working on rhbz#677052) (dvlasenk@redhat.com) -- reporter-mailx: use Bugzilla's output format. Closes rhbz#717321. (dvlasenk@redhat.com) -- report-newt: add option to display version (rhbz#741590) (mlichvar@redhat.com) -- Resolves: #727494 #748457 #712508 #665210 rhbz#728190 #737991 #677052 #717321 #741590 - -* Fri Oct 07 2011 Nikola Pajkovsky 2.0.6-2 -- refuse reporting when not reportable file exist - -* Mon Oct 03 2011 Jiri Moskovcak 2.0.6-1 -- updated to the latest upstrem -- just a bug fixing release - -* Mon Sep 26 2011 Jiri Moskovcak 2.0.5.982-1 -- re-fix rhbz#730887 -- re-fixed prgname (nice icons in gnome3) rhbz#741231 -- Resolves: #741231 #730887 - -* Thu Sep 22 2011 Jiri Moskovcak 2.0.5-9 -- don't allow sending reports with bad rating rhbz#672023 -- don't allow reporting without duphash rhbz#739182 -- tell users to fill out reports in English rhbz#734037 -- fixed config for kerneloops reporter rhbz#731189 -- Resolves: #672023 #739182 #734037 #731189 - -* Fri Sep 09 2011 Jiri Moskovcak 2.0.5-8 -- allow bugzilla to send binary files -- Related: #733448 - -* Tue Aug 30 2011 Jiri Moskovcak 2.0.5-7 -- added glob support to event xml files -- changed handling of long text files -- added a simple editor as a fallback when no editor is installed (i.e in anaconda) rhbz#728479 -- Resolves: #733448 #728479 - -* Tue Aug 16 2011 Jiri Moskovcak 2.0.5-6 -- improved release parsing rhbz#730887 -- Resolves: #730887 - -* Fri Aug 12 2011 Jiri Moskovcak 2.0.5-5 -- more anaconda fixes -- Resolves: #729537 - -* Tue Aug 02 2011 Jiri Moskovcak 2.0.5-4 -- silent keyring warning rhbz#692433 -- further improvements to Anaconda compatibility - -* Fri Jul 29 2011 Jiri Moskovcak 2.0.5-3 -- enable bugzilla reporter for analyzer=libreport rhbz#725970 -- improved compatibility with anaconda - -* Thu Jul 21 2011 Jiri Moskovcak 2.0.5-2 -- obsolete report in rawhide properly rhbz#723320 -- added button to add attachments -- ignore backup files -- improved support for interactive plugins -- added description text for logger -- added python bindings for interactive plugins -- Resolves: #723320 - -* Mon Jul 18 2011 Jiri Moskovcak 2.0.5-1 -- move reporter plugins from abrt to libreport -- fixed provides/obsolete to properly obsolete report package -- wizard: make more fields editable - -* Mon Jul 11 2011 Jiri Moskovcak 2.0.4-3 -- bump release - -* Mon Jun 27 2011 Jiri Moskovcak 2.0.4-2 -- removed Provides/Obsoletes: report-gtk - -* Mon Jun 20 2011 Jiri Moskovcak 2.0.4-1 -- new upstream release -- cleaned some header files - -* Thu Jun 16 2011 Jiri Moskovcak 2.0.3-1 -- added report-cli -- updated translation - -* Wed Jun 01 2011 Jiri Moskovcak 2.0.2-1 -- initial packaging diff --git a/sources b/sources index 8a41c1d..be9654e 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.2.tar.gz) = 2438a9f994a66d2f207d421ddc7bc45be5a803e5527967d8a79a06a5361e935caa106f69883b822664175df561a39bed33a744590bd9341173802972ab942085 +SHA512 (libreport-2.9.3.tar.gz) = f4cdf6a0ffb18db224f47391e0e8ac26491ac105051ec511e575b10a1ffbbbaa2290827ad27cc622ece5d5291141cf1083dce0d3b778657d309aa8d5d8799473 From 4104372ff44c287feec4a382dcb4f59f70c5a53e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= Date: Sun, 10 Dec 2017 20:25:32 +0100 Subject: [PATCH 015/133] Rebuilt for libjson-c.so.3 Use %%global instead of %%define --- libreport-2.9.3_fix_json-c_013.patch | 25 +++++++++++++++++++++++++ libreport.spec | 23 ++++++++++++++--------- 2 files changed, 39 insertions(+), 9 deletions(-) create mode 100644 libreport-2.9.3_fix_json-c_013.patch diff --git a/libreport-2.9.3_fix_json-c_013.patch b/libreport-2.9.3_fix_json-c_013.patch new file mode 100644 index 0000000..a343bb8 --- /dev/null +++ b/libreport-2.9.3_fix_json-c_013.patch @@ -0,0 +1,25 @@ +From ad6b52edd4c36b413d3bac6cb03f35369dae1d28 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= +Date: Sun, 10 Dec 2017 20:20:21 +0100 +Subject: [PATCH 2/2] Fix build against libjson-c.so.3 + +--- + src/lib/ureport.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/src/lib/ureport.c b/src/lib/ureport.c +index 9e8bbd6..81f0791 100644 +--- a/src/lib/ureport.c ++++ b/src/lib/ureport.c +@@ -609,7 +609,7 @@ ureport_server_response_from_reply(post_state_t *post_state, + + json_object *const json = json_tokener_parse(post_state->body); + +- if (is_error(json)) ++ if (json == NULL) + { + error_msg(_("Unable to parse response from ureport server at '%s'"), config->ur_url); + log_notice("%s", post_state->body); +-- +2.15.1 + diff --git a/libreport.spec b/libreport.spec index fe4ecd5..d538b23 100644 --- a/libreport.spec +++ b/libreport.spec @@ -1,18 +1,19 @@ -# platform-dependent -%{!?python_sitearch: %define python_sitearch %(%{__python} -c "from distutils.sysconfig import get_python_lib; print get_python_lib(1)")} - -%define satyr_ver 0.24 -%define glib_ver 2.43 +%global satyr_ver 0.24 +%global glib_ver 2.43 Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz Source1: autogen.sh +# Needed for libjson-c.so.3*. +# See: https://github.com/json-c/json-c/issues/304 +Patch0: libreport-2.9.3_fix_json-c_013.patch + # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done @@ -328,9 +329,9 @@ data over ftp/scp... # Default '__scm_apply_git' is 'git apply && git commit' but this workflow # doesn't allow us to create a new file within a patch, so we have to use # 'git am' (see /usr/lib/rpm/macros for more details) -%define __scm_apply_git(qp:m:) %{__git} am --exclude src/report-python/libreport-meh-test.py -#%%define __scm_apply_git(qp:m:) %%{__git} am --exclude libreport.spec.in --exclude .gitignore -%autosetup -S git +%global __scm_apply_git(qp:m:) %{__git} am --exclude src/report-python/libreport-meh-test.py +#%%global __scm_apply_git(qp:m:) %%{__git} am --exclude libreport.spec.in --exclude .gitignore +%autosetup -S git -p 1 # koji in f19 has new autotools, so we need to regenerate everything cp %SOURCE1 %_builddir/%{name}-%{version} @@ -759,6 +760,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Sun Dec 10 2017 Björn Esser - 2.9.3-2 +- Rebuilt for libjson-c.so.3 +- Use %%global instead of %%define + * Thu Nov 02 2017 Julius Milan 2.9.3-1 - Translation updates - commit to delete From c8f143d4064cbc3e498f8987d3cda83c2a91d9ef Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Sat, 6 Jan 2018 00:33:31 +0100 Subject: [PATCH 016/133] Remove obsolete scriptlets Signed-off-by: Igor Gnatenko --- libreport.spec | 26 ++++++-------------------- 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/libreport.spec b/libreport.spec index d538b23..249ca90 100644 --- a/libreport.spec +++ b/libreport.spec @@ -4,7 +4,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -430,32 +430,15 @@ make check|| { exit 1 } -%post gtk -/sbin/ldconfig -# update icon cache -touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : - %post -p /sbin/ldconfig - %postun -p /sbin/ldconfig -%postun gtk -/sbin/ldconfig -if [ $1 -eq 0 ] ; then - touch --no-create %{_datadir}/icons/hicolor &>/dev/null - gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : -fi - -%posttrans gtk -gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - +%post gtk -p /sbin/ldconfig +%postun gtk -p /sbin/ldconfig %post web -p /sbin/ldconfig - - %postun web -p /sbin/ldconfig - %files -f %{name}.lang %defattr(-,root,root,-) %doc README.md @@ -760,6 +743,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %changelog +* Fri Jan 05 2018 Igor Gnatenko - 2.9.3-3 +- Remove obsolete scriptlets + * Sun Dec 10 2017 Björn Esser - 2.9.3-2 - Rebuilt for libjson-c.so.3 - Use %%global instead of %%define From 7f57fcb640e81b0508cc4c56ec2dacf9ff17995a Mon Sep 17 00:00:00 2001 From: Iryna Shcherbina Date: Tue, 9 Jan 2018 18:58:32 +0100 Subject: [PATCH 017/133] Update Python 2 dependency declarations to new packaging standards --- libreport.spec | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libreport.spec b/libreport.spec index 249ca90..06877d2 100644 --- a/libreport.spec +++ b/libreport.spec @@ -4,7 +4,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -26,7 +26,7 @@ BuildRequires: dbus-devel BuildRequires: gtk3-devel BuildRequires: curl-devel BuildRequires: desktop-file-utils -BuildRequires: python-devel +BuildRequires: python2-devel BuildRequires: python3-devel BuildRequires: gettext BuildRequires: libxml2-devel @@ -743,6 +743,10 @@ make check|| { %changelog +* Tue Jan 09 2018 Iryna Shcherbina - 2.9.3-4 +- Update Python 2 dependency declarations to new packaging standards + (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3) + * Fri Jan 05 2018 Igor Gnatenko - 2.9.3-3 - Remove obsolete scriptlets From 2c2805e4e0706b6428ab6a4a7a2c89f06724ecb4 Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Sat, 3 Feb 2018 17:19:45 +0100 Subject: [PATCH 018/133] Switch to %ldconfig_scriptlets Signed-off-by: Igor Gnatenko --- libreport.spec | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/libreport.spec b/libreport.spec index 06877d2..beb9268 100644 --- a/libreport.spec +++ b/libreport.spec @@ -4,7 +4,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 4%{?dist} +Release: 5%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -430,14 +430,9 @@ make check|| { exit 1 } -%post -p /sbin/ldconfig -%postun -p /sbin/ldconfig - -%post gtk -p /sbin/ldconfig -%postun gtk -p /sbin/ldconfig - -%post web -p /sbin/ldconfig -%postun web -p /sbin/ldconfig +%ldconfig_scriptlets +%ldconfig_scriptlets gtk +%ldconfig_scriptlets web %files -f %{name}.lang %defattr(-,root,root,-) @@ -743,6 +738,9 @@ make check|| { %changelog +* Sat Feb 03 2018 Igor Gnatenko - 2.9.3-5 +- Switch to %%ldconfig_scriptlets + * Tue Jan 09 2018 Iryna Shcherbina - 2.9.3-4 - Update Python 2 dependency declarations to new packaging standards (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3) From 53b1870f10ad6cd7588a34c2f081630dfd49c7c4 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 7 Feb 2018 23:13:38 +0000 Subject: [PATCH 019/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index beb9268..dce5863 100644 --- a/libreport.spec +++ b/libreport.spec @@ -4,7 +4,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -738,6 +738,9 @@ make check|| { %changelog +* Wed Feb 07 2018 Fedora Release Engineering - 2.9.3-6 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild + * Sat Feb 03 2018 Igor Gnatenko - 2.9.3-5 - Switch to %%ldconfig_scriptlets From 4e7caa2be65fca0699ca738a1967f8cc4a30e21e Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Thu, 1 Mar 2018 11:08:59 +0100 Subject: [PATCH 020/133] Add report and reportclient directories to rpm MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Thanks to Ralf Corsépius Signed-off-by: Matej Habrnal --- libreport.spec | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libreport.spec b/libreport.spec index dce5863..cc2cbba 100644 --- a/libreport.spec +++ b/libreport.spec @@ -4,7 +4,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 6%{?dist} +Release: 7%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -500,12 +500,12 @@ make check|| { %{_libdir}/pkgconfig/libreport-web.pc %files -n python2-libreport -%{python_sitearch}/report/* -%{python_sitearch}/reportclient/* +%{python_sitearch}/report +%{python_sitearch}/reportclient %files -n python3-libreport -%{python3_sitearch}/report/* -%{python3_sitearch}/reportclient/* +%{python3_sitearch}/report +%{python3_sitearch}/reportclient %files cli %{_bindir}/report-cli @@ -738,6 +738,9 @@ make check|| { %changelog +* Thu Mar 01 2018 Matej Habrnal 2.9.3-7 +- Add report and reportclient directories to rpm + * Wed Feb 07 2018 Fedora Release Engineering - 2.9.3-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild From eba2d1c7fa24f51b35af07248180a42b6c4e737e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= Date: Tue, 6 Mar 2018 15:15:39 +0100 Subject: [PATCH 021/133] Rebuilt for libjson-c.so.4 (json-c v0.13.1) --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index cc2cbba..813ab12 100644 --- a/libreport.spec +++ b/libreport.spec @@ -4,7 +4,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.3 -Release: 7%{?dist} +Release: 8%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -738,6 +738,9 @@ make check|| { %changelog +* Tue Mar 06 2018 Björn Esser - 2.9.3-8 +- Rebuilt for libjson-c.so.4 (json-c v0.13.1) + * Thu Mar 01 2018 Matej Habrnal 2.9.3-7 - Add report and reportclient directories to rpm From 59fdf2c79f4384e82ab9237001fdb40199b6195e Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Tue, 27 Mar 2018 18:54:57 +0200 Subject: [PATCH 022/133] New upstream release 2.9.4 Signed-off-by: Martin Kutlak --- libreport-2.9.3_fix_json-c_013.patch | 25 ---------------- libreport.spec | 44 ++++++++++++++++++---------- sources | 2 +- 3 files changed, 29 insertions(+), 42 deletions(-) delete mode 100644 libreport-2.9.3_fix_json-c_013.patch diff --git a/libreport-2.9.3_fix_json-c_013.patch b/libreport-2.9.3_fix_json-c_013.patch deleted file mode 100644 index a343bb8..0000000 --- a/libreport-2.9.3_fix_json-c_013.patch +++ /dev/null @@ -1,25 +0,0 @@ -From ad6b52edd4c36b413d3bac6cb03f35369dae1d28 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= -Date: Sun, 10 Dec 2017 20:20:21 +0100 -Subject: [PATCH 2/2] Fix build against libjson-c.so.3 - ---- - src/lib/ureport.c | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - -diff --git a/src/lib/ureport.c b/src/lib/ureport.c -index 9e8bbd6..81f0791 100644 ---- a/src/lib/ureport.c -+++ b/src/lib/ureport.c -@@ -609,7 +609,7 @@ ureport_server_response_from_reply(post_state_t *post_state, - - json_object *const json = json_tokener_parse(post_state->body); - -- if (is_error(json)) -+ if (json == NULL) - { - error_msg(_("Unable to parse response from ureport server at '%s'"), config->ur_url); - log_notice("%s", post_state->body); --- -2.15.1 - diff --git a/libreport.spec b/libreport.spec index 813ab12..63905a8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -3,16 +3,13 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.3 -Release: 8%{?dist} +Version: 2.9.4 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz Source1: autogen.sh -# Needed for libjson-c.so.3*. -# See: https://github.com/json-c/json-c/issues/304 -Patch0: libreport-2.9.3_fix_json-c_013.patch # git format-patch %%{Version} -N -M --topo-order # i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done @@ -96,11 +93,6 @@ Development headers for libreport-web Summary: Python bindings for report-libs Requires: libreport = %{version}-%{release} Requires: python2-dnf -# in report the rhtsupport is in the main package, so we need to install it too -# report is only in RHEL6, we do not need to carry the dependency to newer RHELs -%if 0%{?rhel} == 6 -Requires: libreport-plugin-rhtsupport = %{version}-%{release} -%endif %{?python_provide:%python_provide python2-libreport} # Remove before F30 Provides: %{name}-python = %{version}-%{release} @@ -340,7 +332,11 @@ cp %SOURCE1 %_builddir/%{name}-%{version} %build # Commented because of deprecated GTK API #CFLAGS="%%{optflags} -Werror" %%configure --disable-silent-rules -CFLAGS="%{optflags}" %configure --enable-doxygen-docs --disable-silent-rules +CFLAGS="%{optflags}" %configure --enable-doxygen-docs \ +%if 0%{?rhel} + --enable-import-rhtsupport-cert \ +%endif + --disable-silent-rules make %{?_smp_mflags} %install @@ -435,7 +431,6 @@ make check|| { %ldconfig_scriptlets web %files -f %{name}.lang -%defattr(-,root,root,-) %doc README.md %license COPYING %config(noreplace) %{_sysconfdir}/%{name}/libreport.conf @@ -457,6 +452,9 @@ make check|| { %dir %{_sysconfdir}/%{name}/events.d/ %dir %{_sysconfdir}/%{name}/events/ %dir %{_sysconfdir}/%{name}/workflows.d/ +%dir %{_datadir}/%{name}/ +%dir %{_datadir}/%{name}/conf.d/ +%dir %{_datadir}/%{name}/conf.d/plugins/ %dir %{_datadir}/%{name}/events/ %dir %{_datadir}/%{name}/workflows/ %dir %{_sysconfdir}/%{name}/plugins/ @@ -500,12 +498,12 @@ make check|| { %{_libdir}/pkgconfig/libreport-web.pc %files -n python2-libreport -%{python_sitearch}/report -%{python_sitearch}/reportclient +%{python_sitearch}/report/ +%{python_sitearch}/reportclient/ %files -n python3-libreport -%{python3_sitearch}/report -%{python3_sitearch}/reportclient +%{python3_sitearch}/report/ +%{python3_sitearch}/reportclient/ %files cli %{_bindir}/report-cli @@ -637,6 +635,9 @@ make check|| { %{_datadir}/%{name}/events/report_RHTSupport.xml %{_datadir}/%{name}/events/report_RHTSupport_AddData.xml %{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.rhtsupport.xml +%if 0%{?rhel} +%attr(600,root,root)%{_sysconfdir}/%{name}/cert-api.access.redhat.com.pem +%endif %config(noreplace) %{_sysconfdir}/libreport/events.d/rhtsupport_event.conf %{_mandir}/man1/reporter-rhtsupport.1.gz %{_mandir}/man5/rhtsupport.conf.5.* @@ -738,6 +739,17 @@ make check|| { %changelog +* Tue Mar 27 2018 Martin Kutlak - 2.9.4-1 +- Translation updates +- ureport: remove json-c is_error() usage +- reporter-rhtsupport: Remove dependency on redhat-access-insights +- reporter-mailx: rely on configured email +- Modernize spec file +- augeas: include local config path +- doc: update to contain newly added user's local config +- reporter-{mantisbt,rhtsupport,bugzilla}: read configuration from user's home +- reporter-bugzilla: ask concrete bz when requiring login + * Tue Mar 06 2018 Björn Esser - 2.9.3-8 - Rebuilt for libjson-c.so.4 (json-c v0.13.1) diff --git a/sources b/sources index be9654e..7bb1428 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.3.tar.gz) = f4cdf6a0ffb18db224f47391e0e8ac26491ac105051ec511e575b10a1ffbbbaa2290827ad27cc622ece5d5291141cf1083dce0d3b778657d309aa8d5d8799473 +SHA512 (libreport-2.9.4.tar.gz) = 060e8d2929397a48f8c213758eff06583afbdc77cdfa186999b35dc545076890f0112b190df635c9681565c4ccbee1be7653a31a702dc612e15703d273d9039f From e398dd4af7c8f3a2a3427ecd0d37e12763f9b807 Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Wed, 25 Apr 2018 12:53:03 +0200 Subject: [PATCH 023/133] New upstream release 2.9.5 Signed-off-by: Matej Habrnal --- .gitignore | 4 +- libreport.spec | 363 ++++++++++++++++++++++++++++--------------------- sources | 2 +- 3 files changed, 210 insertions(+), 159 deletions(-) diff --git a/.gitignore b/.gitignore index bbf2a56..0465349 100644 --- a/.gitignore +++ b/.gitignore @@ -1 +1,3 @@ -/libreport-2.*.tar.gz +/libreport-2.9.3.tar.gz +/libreport-2.9.4.tar.gz +/libreport-2.9.5.tar.gz diff --git a/libreport.spec b/libreport.spec index 63905a8..dd198a6 100644 --- a/libreport.spec +++ b/libreport.spec @@ -1,30 +1,48 @@ -%global satyr_ver 0.24 -%global glib_ver 2.43 +%if 0%{?suse_version} + %bcond_with bugzilla + + %define dbus_devel dbus-1-devel + %define libjson_devel libjson-devel +%else + %bcond_without bugzilla + + %define dbus_devel dbus-devel + %define libjson_devel json-c-devel +%endif + +%define glib_ver 2.43 + +%if 0%{?fedora} || 0%{?rhel} > 7 +# Enable python3 build by default +%bcond_without python3 +%else +%bcond_with python3 +%endif + +%if 0%{?rhel} > 7 || 0%{?fedora} > 28 +# Disable python2 build by default +%bcond_with python2 +%else +%bcond_without python2 +%endif Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.4 +Version: 2.9.5 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Source1: autogen.sh - - -# git format-patch %%{Version} -N -M --topo-order -# i=0; for p in `ls 0*.patch`; do printf "Patch%04d: %s\n" $i $p; ((i++)); done - -# git is need for '%%autosetup -S git' which automatically applies all the -# patches above. Please, be aware that the patches must be generated -# by 'git format-patch' -BuildRequires: git - -BuildRequires: dbus-devel +BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel BuildRequires: desktop-file-utils +%if %{with python2} BuildRequires: python2-devel +%endif # with python2 +%if %{with python3} BuildRequires: python3-devel +%endif # with python3 BuildRequires: gettext BuildRequires: libxml2-devel BuildRequires: libtar-devel @@ -35,29 +53,34 @@ BuildRequires: asciidoc BuildRequires: xmlto BuildRequires: newt-devel BuildRequires: libproxy-devel -BuildRequires: satyr-devel >= %{satyr_ver} +BuildRequires: satyr-devel >= 0.24 BuildRequires: glib2-devel >= %{glib_ver} +%if 0%{?fedora} >= 24 || 0%{?rhel} > 7 +# A test case uses zh_CN locale to verify XML event translations BuildRequires: glibc-all-langpacks +%endif + +%if %{with bugzilla} BuildRequires: xmlrpc-c-devel +%endif BuildRequires: doxygen BuildRequires: systemd-devel BuildRequires: augeas-devel BuildRequires: augeas BuildRequires: xz BuildRequires: lz4 +Requires: libreport-filesystem = %{version}-%{release} +Requires: satyr >= 0.24 +Requires: glib2 >= %{glib_ver} +Requires: xz +Requires: lz4 # Required for the temporary modularity hack, see below %if 0%{?_module_build} BuildRequires: sed %endif -Requires: libreport-filesystem = %{version}-%{release} -Requires: satyr >= %{satyr_ver} -Requires: glib2 >= %{glib_ver} -Requires: xz -Requires: lz4 - %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -89,6 +112,7 @@ Requires: libreport-web = %{version}-%{release} %description web-devel Development headers for libreport-web +%if %{with python2} %package -n python2-libreport Summary: Python bindings for report-libs Requires: libreport = %{version}-%{release} @@ -101,7 +125,9 @@ Obsoletes: %{name}-python < %{version}-%{release} %description -n python2-libreport Python bindings for report-libs. +%endif # with python2 +%if %{with python3} %package -n python3-libreport Summary: Python 3 bindings for report-libs %if 0%{?_module_build} @@ -124,6 +150,7 @@ Obsoletes: %{name}-python3 < %{version}-%{release} %description -n python3-libreport Python 3 bindings for report-libs. +%endif # with python3 %package cli Summary: %{name}'s command line interface @@ -147,7 +174,7 @@ bugs Summary: GTK front-end for libreport Requires: libreport = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -Requires: fros >= 1.1-2 +Requires: fros >= 1.0 Provides: report-gtk = 0:0.23-1 Obsoletes: report-gtk < 0:0.23-1 @@ -194,6 +221,7 @@ Requires: mailx The simple reporter plugin which sends a report via mailx to a specified email address. +%if %{with bugzilla} %package plugin-bugzilla Summary: %{name}'s bugzilla plugin Requires: %{name} = %{version}-%{release} @@ -201,6 +229,7 @@ Requires: libreport-web = %{version}-%{release} %description plugin-bugzilla Plugin to report bugs into the bugzilla. +%endif %package plugin-mantisbt Summary: %{name}'s mantisbt plugin @@ -221,7 +250,7 @@ Workflows to report issues into the CentOS Bug Tracker. %package plugin-ureport Summary: %{name}'s micro report plugin -BuildRequires: json-c-devel +BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} %if 0%{?rhel} @@ -235,13 +264,11 @@ Uploads micro-report to abrt server Summary: %{name}'s RHTSupport plugin Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} -%if 0%{?rhel} -Requires: redhat-access-insights -%endif %description plugin-rhtsupport Plugin to report bugs into RH support system. +%if %{with bugzilla} %package compat Summary: %{name}'s compat layer for obsoleted 'report' package Requires: libreport = %{version}-%{release} @@ -250,6 +277,7 @@ Requires: %{name}-plugin-rhtsupport = %{version}-%{release} %description compat Provides 'report' command-line tool. +%endif %package plugin-reportuploader Summary: %{name}'s reportuploader plugin @@ -302,6 +330,7 @@ to easily configure the reporting process for Red Hat systems. Just install this package and you're done. %endif +%if %{with bugzilla} %package anaconda Summary: Default configuration for reporting anaconda bugs Requires: %{name} = %{version}-%{release} @@ -315,28 +344,30 @@ Requires: libreport-plugin-bugzilla = %{version}-%{release} %description anaconda Default configuration for reporting Anaconda problems or uploading the gathered data over ftp/scp... +%endif %prep -# http://www.rpm.org/wiki/PackagerDocs/Autosetup -# Default '__scm_apply_git' is 'git apply && git commit' but this workflow -# doesn't allow us to create a new file within a patch, so we have to use -# 'git am' (see /usr/lib/rpm/macros for more details) -%global __scm_apply_git(qp:m:) %{__git} am --exclude src/report-python/libreport-meh-test.py -#%%global __scm_apply_git(qp:m:) %%{__git} am --exclude libreport.spec.in --exclude .gitignore -%autosetup -S git -p 1 - -# koji in f19 has new autotools, so we need to regenerate everything -cp %SOURCE1 %_builddir/%{name}-%{version} -./autogen.sh +%setup -q %build -# Commented because of deprecated GTK API -#CFLAGS="%%{optflags} -Werror" %%configure --disable-silent-rules -CFLAGS="%{optflags}" %configure --enable-doxygen-docs \ -%if 0%{?rhel} - --enable-import-rhtsupport-cert \ +autoconf + +CFLAGS="%{optflags} -Werror" %configure \ +%if %{without python2} + --without-python2 \ +%endif # with python2 +%if %{without python3} + --without-python3 \ +%endif # with python3 +%if %{without bugzilla} + --without-bugzilla \ %endif - --disable-silent-rules +%if 0%{?rhel} + --enable-import-rhtsupport-cert \ +%endif + --enable-doxygen-docs \ + --disable-silent-rules + make %{?_smp_mflags} %install @@ -416,8 +447,6 @@ rm -f %{buildroot}%{_mandir}/man5/report_uReport.conf.5 rm -f %{buildroot}%{_mandir}/man5/report_rhel_bugzilla.conf.5 %endif -%clean - %check make check|| { # find and print the logs of failed test @@ -426,9 +455,34 @@ make check|| { exit 1 } -%ldconfig_scriptlets -%ldconfig_scriptlets gtk -%ldconfig_scriptlets web +%if 0%{?fedora} > 27 || 0%{?rhel} > 7 +# ldconfig and gtk-update-icon-cache is not needed +%else +%post gtk +/sbin/ldconfig +# update icon cache +touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : + +%post -p /sbin/ldconfig + +%postun -p /sbin/ldconfig + +%postun gtk +/sbin/ldconfig +if [ $1 -eq 0 ] ; then + touch --no-create %{_datadir}/icons/hicolor &>/dev/null + gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : +fi + +%posttrans gtk +gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : + + +%post web -p /sbin/ldconfig + + +%postun web -p /sbin/ldconfig +%endif %files -f %{name}.lang %doc README.md @@ -497,13 +551,17 @@ make check|| { %{_includedir}/libreport/libreport_curl.h %{_libdir}/pkgconfig/libreport-web.pc +%if %{with python2} %files -n python2-libreport %{python_sitearch}/report/ %{python_sitearch}/reportclient/ +%endif # with python2 +%if %{with python3} %files -n python3-libreport %{python3_sitearch}/report/ %{python3_sitearch}/reportclient/ +%endif # with python3 %files cli %{_bindir}/report-cli @@ -572,6 +630,7 @@ make check|| { %{_datadir}/%{name}/events/report_uReport.xml %{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.ureport.xml +%if %{with bugzilla} %files plugin-bugzilla %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla.conf %{_datadir}/%{name}/conf.d/plugins/bugzilla.conf @@ -594,6 +653,7 @@ make check|| { %{_mandir}/man5/bugzilla_format_analyzer_libreport.conf.5.* %{_mandir}/man5/bugzilla_format_kernel.conf.5.* %{_bindir}/reporter-bugzilla +%endif %files plugin-mantisbt %config(noreplace) %{_sysconfdir}/libreport/plugins/mantisbt.conf @@ -627,7 +687,7 @@ make check|| { %{_mandir}/man5/report_CentOSBugTracker.conf.5.* # report_CentOSBugTracker events are shipped by libreport package %config(noreplace) %{_sysconfdir}/libreport/events.d/centos_report_event.conf -%{_mandir}/man5/centos_report_event.conf.5.* +%{_mandir}/man5/centos_report_event.conf.5.gz %files plugin-rhtsupport %config(noreplace) %{_sysconfdir}/libreport/plugins/rhtsupport.conf @@ -644,9 +704,11 @@ make check|| { %{_mandir}/man5/rhtsupport_event.conf.5.* %{_bindir}/reporter-rhtsupport +%if %{with bugzilla} %files compat %{_bindir}/report %{_mandir}/man1/report.1.gz +%endif %files plugin-reportuploader %{_mandir}/man*/reporter-upload.* @@ -657,9 +719,9 @@ make check|| { %{_datadir}/%{name}/workflows/workflow_Upload.xml %{_datadir}/%{name}/workflows/workflow_UploadCCpp.xml %config(noreplace) %{_sysconfdir}/libreport/plugins/upload.conf +%{_datadir}/%{name}/conf.d/plugins/upload.conf %{_mandir}/man5/upload.conf.5.* %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uploader.conf -%{_datadir}/%{name}/conf.d/plugins/upload.conf %{_mandir}/man5/report_uploader.conf.5.* %config(noreplace) %{_sysconfdir}/libreport/events/report_Uploader.conf %{_mandir}/man5/report_Uploader.conf.5.* @@ -720,6 +782,7 @@ make check|| { %{_datadir}/%{name}/workflows/workflow_AnacondaRHELBugzilla.xml %endif +%if %{with bugzilla} %files anaconda %if 0%{?fedora} %{_datadir}/%{name}/workflows/workflow_AnacondaFedora.xml @@ -736,42 +799,37 @@ make check|| { %{_mandir}/man5/bugzilla_anaconda_event.conf.5.* %{_mandir}/man5/bugzilla_format_anaconda.conf.5.* %{_mandir}/man5/bugzilla_formatdup_anaconda.conf.5.* - +%endif %changelog -* Tue Mar 27 2018 Martin Kutlak - 2.9.4-1 +* Tue Apr 24 2018 Matej Habrnal 2.9.5-1 +- spec: actualize according to downstream +- spec: Conditionalize the Python2 and Python3 +- report-python: fix tests if configure --without-python2 +- autogen: correctly parse buildrequires from spec file + +* Tue Mar 27 2018 Martin Kutlak 2.9.4-1 - Translation updates +- Revert "use /usr/sbin/" - ureport: remove json-c is_error() usage +- ldconfig and gtk-update-icon-cache is not needed in rawhide - reporter-rhtsupport: Remove dependency on redhat-access-insights +- do not expand macro in changelog +- move defattr which match the defaults +- use /usr/sbin/ +- macro python_sitearch is always defined on rhel7+ +- remove rhel6 specific items and accomodate to rhel7+ +- This package uses names with ambiguous `python-` prefix in requirements. +- reporter-{bugzilla,mantisbt,rhtsupport}: fix free - reporter-mailx: rely on configured email -- Modernize spec file +- spec: fix unowned directories - augeas: include local config path - doc: update to contain newly added user's local config -- reporter-{mantisbt,rhtsupport,bugzilla}: read configuration from user's home +- reporter-mantisbt: read configuration from user's home +- reporter-rhtsupport: read configuration from user's home +- reporter-bugzilla: read configuration from user's home - reporter-bugzilla: ask concrete bz when requiring login - -* Tue Mar 06 2018 Björn Esser - 2.9.3-8 -- Rebuilt for libjson-c.so.4 (json-c v0.13.1) - -* Thu Mar 01 2018 Matej Habrnal 2.9.3-7 -- Add report and reportclient directories to rpm - -* Wed Feb 07 2018 Fedora Release Engineering - 2.9.3-6 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild - -* Sat Feb 03 2018 Igor Gnatenko - 2.9.3-5 -- Switch to %%ldconfig_scriptlets - -* Tue Jan 09 2018 Iryna Shcherbina - 2.9.3-4 -- Update Python 2 dependency declarations to new packaging standards - (See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3) - -* Fri Jan 05 2018 Igor Gnatenko - 2.9.3-3 -- Remove obsolete scriptlets - -* Sun Dec 10 2017 Björn Esser - 2.9.3-2 -- Rebuilt for libjson-c.so.3 -- Use %%global instead of %%define +- makefile: fix make release * Thu Nov 02 2017 Julius Milan 2.9.3-1 - Translation updates @@ -792,45 +850,11 @@ make check|| { - client-python: Do not try to unlink None - spec: rename Python binary packages -* Wed Sep 13 2017 Matej Habrnal 2.9.2-2 -- Introduce pid_for_children element from ns -- Resolves: #1489611 - -* Fri Aug 25 2017 Matej Habrnal 2.9.2-1 -- Translation updates -- logging: rename log() to log_warning() -- reporter-mantisbt: Fix typo in help -- bugzilla: add check if option -d was entered -- dd: extend create_dump_dir to allow set pid in dumpdir name -- wizard: replace deprecated gtk3 functions -- lib: replace hash table with list -- fix newline issue with ask_password -- lib: make cpuinfo files user editable -- reporter-s-journal: add count to default logs -- augeas: trim spaces on eol, around value separator -- reporter-s-journal: add journal default entries -- Resolves: #1481205 - -* Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek - 2.9.1-6 -- Python 3 binary package renamed to python3-libreport -- Missing Provides wihtout %%_isa added in python 2 binary package - -* Sat Aug 19 2017 Zbigniew Jędrzejewski-Szmek - 2.9.1-5 -- Python 2 binary package renamed to python2-libreport - See https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3 - -* Thu Aug 03 2017 Fedora Release Engineering - 2.9.1-4 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Binutils_Mass_Rebuild - -* Wed Jul 26 2017 Fedora Release Engineering - 2.9.1-3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_27_Mass_Rebuild - -* Thu Apr 13 2017 Matej Habrnal 2.9.1-2 -- add journal default entries to reporter-systemd-journal -- augeas: trim spaces on eol, around value separator -- Resolves: #1434414 - -* Wed Mar 15 2017 Matej Habrnal 2.9.1-1 +* Thu Mar 16 2017 Matej Habrnal 2.9.1-1 +- build: create tarball in release-* target +- problem_data: fix double const +- wizard: fix error found by -Werror=format-security +- run_event: fix cmp between pointer and zero character - build: do not upload tarball to fedorahosted.org - spec: do not use fedorahosted.org as source - build: fix generating list of dependences in autogen.sh @@ -850,34 +874,38 @@ make check|| { - build: fix bug in changelog generating in release target - changelog: fix typos -* Fri Feb 10 2017 Fedora Release Engineering - 2.9.0-5 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_26_Mass_Rebuild - -* Sat Jan 21 2017 Igor Gnatenko - 2.9.0-4 -- Rebuild for xmlrpc-c - -* Mon Jan 02 2017 Matej Habrnal 2.9.0-3 -- fix minimal satyr version - -* Thu Dec 15 2016 Charalampos Stratakis - 2.9.0-2 -- Rebuild for Python 3.6 - -* Thu Dec 15 2016 Matej Habrnal 2.9.0-1 +* Fri Dec 02 2016 Jakub Filak 2.9.0-1 - Translation updates - build: make the release-* targets smarter - add CHANGELOG.md - reporter-s-journal: enable SYSLOG_IDENTIFIER from env - report-python: add method run_event_on_problem_dir - lib: use lz4 instead of lz4cat +- reportclient: honor ABRT_VERBOSE - tree-wide: introduce 'stop_on_not_reportable' option - client: add support for $releasever to debuginfo +- lib: correct test for own root - workflows: run analyze_BodhiUpdates event on Fedora +- man: fix formating - reporter-systemd-journal: introduce reporter-systemd-journal - problem_data: add function which returns all problem data keys +- include: add exception_type element constant +- spec: changes related to reporter-systemd-journal - problem_report: add normalization of crashed thread - problem_report: make generate report configurable - problem_report: use core_backtrace if there is no backtrace - lib: refuse to parse negative number as unsigned int +- spec: simplify and remove old conditional +- build: add gettext-devel to sysdeps +- dd: add check for validity of new file FD +- build: configure tree for debugging by default +- spec: use %%buildroot macro +- spec: remove defattr which match the defaults +- spec: do not clean buildroot +- spec: remove Groups +- spec: code cleanup +- lib: fix a bug in dealing with errno +- lib: add convenient wrappers for uint in map_string_t - problem_report: ensure C-string null terminator - lib: fix invalid cgroup namespace ID - lib: make die function configurable @@ -887,22 +915,25 @@ make check|| { - problem data: search for sensitive words in more files - dd: add dd_copy_file_at - ignored words: add "systemd-logind" and "hawkey" +- build: reset the default version with each release +- doc: make README more verbose +- tree-wide: produce less messages in NOTICE log lvl - ureport: less confusing logging +- spec: install JavaScript workflows - workflow: add JavaScript workflows - bugzilla: stop including package details * Fri Sep 09 2016 Jakub Filak 2.8.0-1 - lib: fix a memory leak in create_dump_dir fn - rhtsupport: fix a double free of config at exit +- autogen: fix typo in usage help string - debuginfo: dnf API logging workarounds list - lib: don't warn when user word file doesn't exist +- testuite: add test for forbidden_words - lib: be able to define base conf dir at runtime - wizard: use dnf instead of yum in add a screencast note - problem_report: document resevered elements -* Tue Jul 19 2016 Fedora Release Engineering - 2.7.2-2 -- https://fedoraproject.org/wiki/Changes/Automatic_Provides_for_Python_RPM_Packages - * Mon Jul 18 2016 Matej Habrnal 2.7.2-1 - Translation updates - wizard: do not create reproducible if complex_detail == no @@ -913,6 +944,7 @@ make check|| { - build: update searched pkg names for systemd * Wed May 18 2016 Matej Habrnal 2.7.1-1 +- spec: compression updates - lib: add lz4 decompression - lib: avoid the need to link against lzma - all: format security @@ -926,12 +958,20 @@ make check|| { * Fri Apr 08 2016 Matej Habrnal 2.7.0-1 - ignored words: update ignored words +- mailx: introduce debug parameter -D +- mailx: mail formatting: add comment right after %%oneline - mailx: use problem report api to define an emais' content +- lib: remove unused function make_description_bz - augeas: trim spaces before key value +- Revert "xml parser: be more verbose in case xml file cannot be opened" +- xml parser: be more verbose in case xml file cannot be opened - spec: add workflows.d to filesystem package +- makefile: define LANG in release target - mailx: stop creating dead.letter on mailx failures - workflows: add comments to ambiguous functions +- workflows: NULL for the default configuration dir - workflows: publish the function loading configuration +- build: fix build on Fedora24 - augeas: exclude mantisbt format configurations - reporter-mantisbt: add missing '=' to conf file - curl: fix typo Ingoring -> Ignoring @@ -953,54 +993,63 @@ make check|| { - wizard: fix the broken "Show log" widget - wizard: remove the code correcting Bugzilla groups -* Thu Feb 18 2016 Matej Habrnal 2.6.4-3 -- Translation updates -- wizard: fix the broken widget expansion - -* Wed Feb 10 2016 Matej Habrnal 2.6.4-2 -- wizard: fix the broken "Show log" widget -- Resolves: #1303326 - * Tue Feb 02 2016 Matej Habrnal 2.6.4-1 - doc: add option -o and -O into reporter-ureport man page - rhtsupport: use problme report API to create description - bugzilla: make the event configurable - report-gtk: offer users to create private ticket - bugzilla|centos: declare 'restricted access' support +- event config: add support for 'restricted access' +- lib: move CREATE_PRIVATE_TICKET to the global configuration +- dd: dd_delete_item does not die +- dd: add function getting stat of item +- dd: correct handling of TYPE when creating dump directory +- dd: add function computing dump dir file system size +- dd: add function counting number of dd items +- dd: add function copying file descriptor to element - dd: allow 1 and 2 letter long element names +- problem_data: factor out function reading single problem element - formatdup: more universal comment +- dd: make function uid_in_group() public - Refactoring conditional directives that break parts of statements. - bugzilla: actualize man pages - bugzilla: don't report private problem as comment - uploader: move username and password to the advanced options - uploader: allow empty username and password +- spec: add uploader config files and related man page - uploader: add possibility to set SSH keyfiles +- curl: add possibility to configure SSH keys - desktop-utils: deal with Destkop files without command line - ureport: enable attaching of arbitrary values +- update .gitignore - uploader: save remote name in reported_to - curl: return URLs without userinfo - -* Wed Nov 04 2015 Robert Kuska - 2.6.3-2 -- Rebuilt for Python3.5 rebuild +- lib: add function for removing userinfo from URIs +- plugins: port reporters to add_reported_to_entry +- reported_to: add a function formatting reported_to lines +- lib: introduce parser of ISO date strings +- uploader: use shared dd_create_archive function +- dd: add a function for compressing dumpdirs +- problem_report: add examples to the documentation +- client: document environment variables * Thu Oct 15 2015 Matej Habrnal 2.6.3-1 +- wizard: correct comments in save_text_if_changed() +- events: improve example - reporter-bugzilla: add parameter -p -- fix save users changes after reviewing dump dir files +- wizard: fix save users changes after reviewing dump dir files +- dd: make function load_text_file non-static - bugzilla: don't attach build_ids -- rewrite event rule parser +- run_event: rewrite event rule parser +- dd: add convenience wrappers fro loading numbers - ureport: improve curl's error messages +- ureport: use Red Hat Certificate Authority to make rhsm cert trusted - curl: add posibility to use own Certificate Authority cert - -* Tue Sep 15 2015 Matej Habrnal 2.6.2-5 +- spec: add redhat-access-insights to Requires of l-p-rhtsupport - bugzilla: put VARIANT_ID= to Whiteboard - -* Wed Aug 26 2015 Matej Habrnal 2.6.2-4 -- add a helper for HTTP GET +- autogen: use dnf instead of yum to install dependencies - configure: use hex value for dump dir mode - -* Fri Aug 14 2015 Matej Habrnal 2.6.2-3 -- don't warn about missing 'type' if the locking fails -- stop warning about corrupted mandatory files - -* Wed Jul 22 2015 Matej Habrnal 2.6.2-2 +- curl: add a helper for HTTP GET +- dd: don't warn about missing 'type' if the locking fails +- dd: stop warning about corrupted mandatory files - Use a dgettext function returning strings instead of bytes diff --git a/sources b/sources index 7bb1428..182b3ff 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.4.tar.gz) = 060e8d2929397a48f8c213758eff06583afbdc77cdfa186999b35dc545076890f0112b190df635c9681565c4ccbee1be7653a31a702dc612e15703d273d9039f +SHA512 (libreport-2.9.5.tar.gz) = 160dcbd9dd1653dde4f2a0dd6ab8c07b7e8ae0bc906b5c586df4e9c3b99a392959f6cac9218632587eb077e6d294a43fb2f221f0845e927728970db2fe323a54 From 5cfc64eb8fea32732990da63e9315978461a160f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Sat, 16 Jun 2018 15:58:40 +0200 Subject: [PATCH 024/133] Rebuilt for Python 3.7 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index dd198a6..705a65a 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.5 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -802,6 +802,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sat Jun 16 2018 Miro Hrončok - 2.9.5-2 +- Rebuilt for Python 3.7 + * Tue Apr 24 2018 Matej Habrnal 2.9.5-1 - spec: actualize according to downstream - spec: Conditionalize the Python2 and Python3 From 81821dbddb2928b1731d52bfe157d1b731b90642 Mon Sep 17 00:00:00 2001 From: Matej Habrnal Date: Mon, 18 Jun 2018 15:33:07 +0200 Subject: [PATCH 025/133] Make this build without /usr/bin/python Related to #1592073 Signed-off-by: Matej Habrnal --- ...t-use-python3-to-get-consumerCertDir.patch | 31 +++++++++++++++++++ libreport.spec | 24 ++++++++++++-- 2 files changed, 52 insertions(+), 3 deletions(-) create mode 100644 0001-ureport-use-python3-to-get-consumerCertDir.patch diff --git a/0001-ureport-use-python3-to-get-consumerCertDir.patch b/0001-ureport-use-python3-to-get-consumerCertDir.patch new file mode 100644 index 0000000..e6fe7a6 --- /dev/null +++ b/0001-ureport-use-python3-to-get-consumerCertDir.patch @@ -0,0 +1,31 @@ +From 8c00a86dddaf240d4a836a5e278190bcc51b0b66 Mon Sep 17 00:00:00 2001 +From: Matej Habrnal +Date: Mon, 18 Jun 2018 14:51:23 +0200 +Subject: [PATCH] ureport: use python3 to get consumerCertDir + +Related to #1592073 + +Signed-off-by: Matej Habrnal +--- + src/lib/ureport.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/src/lib/ureport.c b/src/lib/ureport.c +index c32c948a..d2045f0f 100644 +--- a/src/lib/ureport.c ++++ b/src/lib/ureport.c +@@ -81,9 +81,10 @@ rhsm_config_get_consumer_cert_dir(void) + return xstrdup(result); + + result = run_in_shell_and_save_output(0, +- "python -c \"from rhsm.config import initConfig; print(initConfig().get('rhsm', 'consumerCertDir'))\"", ++ "python3 -c \"from rhsm.config import initConfig; print(initConfig().get('rhsm', 'consumerCertDir'))\"", + NULL, NULL); + ++ + /* run_in_shell_and_save_output always returns non-NULL */ + if (result[0] != '/') + goto error; +-- +2.17.0 + diff --git a/libreport.spec b/libreport.spec index 705a65a..6109c61 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,10 +29,13 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.5 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz + +Patch0001: 0001-ureport-use-python3-to-get-consumerCertDir.patch + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -55,6 +58,7 @@ BuildRequires: newt-devel BuildRequires: libproxy-devel BuildRequires: satyr-devel >= 0.24 BuildRequires: glib2-devel >= %{glib_ver} +BuildRequires: git %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 # A test case uses zh_CN locale to verify XML event translations @@ -347,7 +351,12 @@ data over ftp/scp... %endif %prep -%setup -q +# http://www.rpm.org/wiki/PackagerDocs/Autosetup +# Default '__scm_apply_git' is 'git apply && git commit' but this workflow +# doesn't allow us to create a new file within a patch, so we have to use +# 'git am' (see /usr/lib/rpm/macros for more details) +%define __scm_apply_git(qp:m:) %{__git} am +%autosetup -S git %build autoconf @@ -371,7 +380,12 @@ CFLAGS="%{optflags} -Werror" %configure \ make %{?_smp_mflags} %install -make install DESTDIR=%{buildroot} mandir=%{_mandir} +make install DESTDIR=%{buildroot} \ +%if %{with python3} + PYTHON=%{__python3} \ +%endif # with python3 + mandir=%{_mandir} + %find_lang %{name} # Remove byte-compiled python files generated by automake. @@ -802,6 +816,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jun 18 2018 Matej Habrnal 2.9.5-3 +- Make this build without /usr/bin/python +- Resolves #1592073 + * Sat Jun 16 2018 Miro Hrončok - 2.9.5-2 - Rebuilt for Python 3.7 From 000be99d336dbaa02c186c75e5ca15bc43bd00b8 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 13 Jul 2018 08:46:04 +0000 Subject: [PATCH 026/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 6109c61..4743388 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.5 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -816,6 +816,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Jul 13 2018 Fedora Release Engineering - 2.9.5-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild + * Mon Jun 18 2018 Matej Habrnal 2.9.5-3 - Make this build without /usr/bin/python - Resolves #1592073 From 911ee9ee8df439f62d1759f437ba04edd5033d9b Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Mon, 30 Jul 2018 00:22:21 +0200 Subject: [PATCH 027/133] =?UTF-8?q?%{python=5Fsitearch}=20=E2=86=92=20%{py?= =?UTF-8?q?thon2=5Fsitearch}?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Igor Gnatenko --- libreport.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libreport.spec b/libreport.spec index 4743388..65b387d 100644 --- a/libreport.spec +++ b/libreport.spec @@ -567,8 +567,8 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %if %{with python2} %files -n python2-libreport -%{python_sitearch}/report/ -%{python_sitearch}/reportclient/ +%{python2_sitearch}/report/ +%{python2_sitearch}/reportclient/ %endif # with python2 %if %{with python3} From 100ee1da4b5556058987f776d0c14c3d5bec058e Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Mon, 8 Oct 2018 14:02:19 +0200 Subject: [PATCH 028/133] New upstream release 2.9.6 Signed-off-by: Martin Kutlak --- .gitignore | 1 + ...t-use-python3-to-get-consumerCertDir.patch | 31 ------------------- libreport.spec | 24 ++++++++++++-- sources | 2 +- 4 files changed, 23 insertions(+), 35 deletions(-) delete mode 100644 0001-ureport-use-python3-to-get-consumerCertDir.patch diff --git a/.gitignore b/.gitignore index 0465349..5f80a43 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ /libreport-2.9.3.tar.gz /libreport-2.9.4.tar.gz /libreport-2.9.5.tar.gz +/libreport-2.9.6.tar.gz diff --git a/0001-ureport-use-python3-to-get-consumerCertDir.patch b/0001-ureport-use-python3-to-get-consumerCertDir.patch deleted file mode 100644 index e6fe7a6..0000000 --- a/0001-ureport-use-python3-to-get-consumerCertDir.patch +++ /dev/null @@ -1,31 +0,0 @@ -From 8c00a86dddaf240d4a836a5e278190bcc51b0b66 Mon Sep 17 00:00:00 2001 -From: Matej Habrnal -Date: Mon, 18 Jun 2018 14:51:23 +0200 -Subject: [PATCH] ureport: use python3 to get consumerCertDir - -Related to #1592073 - -Signed-off-by: Matej Habrnal ---- - src/lib/ureport.c | 3 ++- - 1 file changed, 2 insertions(+), 1 deletion(-) - -diff --git a/src/lib/ureport.c b/src/lib/ureport.c -index c32c948a..d2045f0f 100644 ---- a/src/lib/ureport.c -+++ b/src/lib/ureport.c -@@ -81,9 +81,10 @@ rhsm_config_get_consumer_cert_dir(void) - return xstrdup(result); - - result = run_in_shell_and_save_output(0, -- "python -c \"from rhsm.config import initConfig; print(initConfig().get('rhsm', 'consumerCertDir'))\"", -+ "python3 -c \"from rhsm.config import initConfig; print(initConfig().get('rhsm', 'consumerCertDir'))\"", - NULL, NULL); - -+ - /* run_in_shell_and_save_output always returns non-NULL */ - if (result[0] != '/') - goto error; --- -2.17.0 - diff --git a/libreport.spec b/libreport.spec index 65b387d..7e420b4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -28,13 +28,12 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.5 -Release: 4%{?dist} +Version: 2.9.6 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0001: 0001-ureport-use-python3-to-get-consumerCertDir.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -91,6 +90,7 @@ to different bug targets like Bugzilla, ftp, trac, etc... %package filesystem Summary: Filesystem layout for libreport +BuildArch: noarch %description filesystem Filesystem layout for libreport @@ -258,7 +258,12 @@ BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} %if 0%{?rhel} +%if %{with python2} Requires: python-rhsm +%endif # with python2 +%if %{with python3} +Requires: python3-subscription-manager-rhsm +%endif # with python3 %endif %description plugin-ureport @@ -816,6 +821,19 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Oct 8 2018 Martin Kutlak 2.9.6-1 +- Fix majority of bugs found by Coverity Scan. +- Remove option to screencast problems +- tests: Adjust format of truncated backtrace for python and core +- gui: Replace deprecated g_type_class_add_private +- potfiles: fix issue in POTFILES.in +- lib: fix a SEGV in list_possible_events() +- ureport: use python3 to get consumerCertDir +- r-mailx: Add comment explaining expected values in config +- reporter-mailx: Remove double quotes from config +- spec: Make libreport-filesystem subpackage noarch +- spec: drop dependency on python-rhsm + * Fri Jul 13 2018 Fedora Release Engineering - 2.9.5-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild diff --git a/sources b/sources index 182b3ff..c7b0301 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.5.tar.gz) = 160dcbd9dd1653dde4f2a0dd6ab8c07b7e8ae0bc906b5c586df4e9c3b99a392959f6cac9218632587eb077e6d294a43fb2f221f0845e927728970db2fe323a54 +SHA512 (libreport-2.9.6.tar.gz) = b1b8c1fc706f7b78cb5b1c8cfac783771fafd840fad4129c88ab3284957b595152315d3b6ed5c3aec9bb50b6c8f023c59246091338a6f199704fde3bf17384ef From e159c55882890bd5341dce4234d6181e4c54a770 Mon Sep 17 00:00:00 2001 From: Matej Marusak Date: Fri, 7 Dec 2018 09:53:32 +0100 Subject: [PATCH 029/133] New upstream release 2.9.7 Signed-off-by: Matej Marusak --- .gitignore | 1 + libreport.spec | 21 ++++++++++++++++++++- sources | 2 +- 3 files changed, 22 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 5f80a43..ffae115 100644 --- a/.gitignore +++ b/.gitignore @@ -2,3 +2,4 @@ /libreport-2.9.4.tar.gz /libreport-2.9.5.tar.gz /libreport-2.9.6.tar.gz +/libreport-2.9.7.tar.gz diff --git a/libreport.spec b/libreport.spec index 7e420b4..782d6fe 100644 --- a/libreport.spec +++ b/libreport.spec @@ -28,7 +28,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.6 +Version: 2.9.7 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -821,6 +821,25 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Dec 07 2018 Matej Marusak 2.9.7-1 +- reportclient: Search for required packages recursively +- event_config: Modify unusable backtrace message +- reportclient: Find and download required debuginfo packages +- lib: Explicitly do not use DST +- autogen: List make in sysdeps command +- lib: Seek beginning of mountinfo file +- report-client: Find debuginfos in own method +- lib: Add a null guard +- gui-wizard-gtk: Require GTK+ 3.10 +- gui-wizard-gtk: Don’t set GtkButton:xalign +- gui-wizard-gtk: Replace use of GtkTable +- gui-wizard-gtk: Show warnings inline on progress page +- gui-wizard-gtk: Remove unused size group +- gui-wizard-gtk: Replace Gtk{H,V}Box with GtkBox +- gui-wizard-gtk: Remove unneeded windows +- gtk-helpers: config_dialog: Hide tree view header +- augeas: Use generic augeas modules + * Mon Oct 8 2018 Martin Kutlak 2.9.6-1 - Fix majority of bugs found by Coverity Scan. - Remove option to screencast problems diff --git a/sources b/sources index c7b0301..9749b3c 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.6.tar.gz) = b1b8c1fc706f7b78cb5b1c8cfac783771fafd840fad4129c88ab3284957b595152315d3b6ed5c3aec9bb50b6c8f023c59246091338a6f199704fde3bf17384ef +SHA512 (libreport-2.9.7.tar.gz) = 8e92470ada204236ae4540145ba7f750814c74b0f5858d25ec797f06d4daeb9fc40996b609a33e154072a45624513d7dbd4027587708ffbfb2f40b0687b16ac3 From 46d8661dcb6a88d37b6aa67131c7e33d8d8d77ce Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Mon, 7 Jan 2019 09:50:20 +0100 Subject: [PATCH 030/133] Replace nomail flag with minor_update Send Bugzilla updates as minor_update. Signed-off-by: Martin Kutlak --- ...eplace-nomail-flag-with-minor_update.patch | 232 ++++++++++++++++++ libreport.spec | 8 +- 2 files changed, 239 insertions(+), 1 deletion(-) create mode 100644 0001-rhbz-Replace-nomail-flag-with-minor_update.patch diff --git a/0001-rhbz-Replace-nomail-flag-with-minor_update.patch b/0001-rhbz-Replace-nomail-flag-with-minor_update.patch new file mode 100644 index 0000000..6ab8dce --- /dev/null +++ b/0001-rhbz-Replace-nomail-flag-with-minor_update.patch @@ -0,0 +1,232 @@ +From 569bf0e3fed698e93b8e098bf6a0bb2f773aed6a Mon Sep 17 00:00:00 2001 +From: Martin Kutlak +Date: Fri, 4 Jan 2019 12:26:28 +0100 +Subject: [PATCH] rhbz: Replace nomail flag with minor_update + +In Bugzilla v5.0 nomail flag is replaced with minor_update. [1] +Because we still use the old nomail flag emails are being sent for every added attachment/comment. + +Related: rhbz#1660157 +Closes: abrt/abrt#1346 + +See also: +- https://partner-bugzilla.redhat.com/docs/en/html/integrating/api/Bugzilla/WebService/Bug.html?highlight=minor_update + +[1] https://bugzilla.redhat.com/show_bug.cgi?id=1655829 + +Signed-off-by: Martin Kutlak +--- + src/plugins/reporter-bugzilla.c | 12 +++++----- + src/plugins/rhbz.c | 41 ++++++++++++++++++--------------- + src/plugins/rhbz.h | 4 ++-- + 3 files changed, 30 insertions(+), 27 deletions(-) + +diff --git a/src/plugins/reporter-bugzilla.c b/src/plugins/reporter-bugzilla.c +index d4d03f8e..c12e00d1 100644 +--- a/src/plugins/reporter-bugzilla.c ++++ b/src/plugins/reporter-bugzilla.c +@@ -35,7 +35,7 @@ int attach_text_item(struct abrt_xmlrpc *ax, const char *bug_id, + log_debug("attaching '%s' as text", item_name); + int r = rhbz_attach_blob(ax, bug_id, + item_name, item->content, strlen(item->content), +- RHBZ_NOMAIL_NOTIFY ++ RHBZ_MINOR_UPDATE + ); + return (r == 0); + } +@@ -63,7 +63,7 @@ int attach_file_item(struct abrt_xmlrpc *ax, const char *bug_id, + return 0; + } + log_debug("attaching '%s' as file", item_name); +- int flag = RHBZ_NOMAIL_NOTIFY; ++ int flag = RHBZ_MINOR_UPDATE; + if (!(item->flags & CD_FLAG_BIGTXT)) + flag |= RHBZ_BINARY_ATTACHMENT; + int r = rhbz_attach_fd(ax, bug_id, item_name, fd, flag); +@@ -793,7 +793,7 @@ int main(int argc, char **argv) + if (reported_to && reported_to->url) + { + log_warning(_("Adding External URL to bug %i"), new_id); +- rhbz_set_url(client, new_id, reported_to->url, RHBZ_NOMAIL_NOTIFY); ++ rhbz_set_url(client, new_id, reported_to->url, RHBZ_MINOR_UPDATE); + free_report_result(reported_to); + } + } +@@ -821,7 +821,7 @@ int main(int argc, char **argv) + if (existing_id >= 0) + { + log_warning(_("Closing bug %i as duplicate of bug %i"), new_id, existing_id); +- rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_NOMAIL_NOTIFY); ++ rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_MINOR_UPDATE); + } + + goto log_out; +@@ -876,7 +876,7 @@ int main(int argc, char **argv) + && !g_list_find_custom(bz->bi_cc_list, rhbz.b_login, (GCompareFunc)g_strcmp0) + ) { + log_warning(_("Adding %s to CC list"), rhbz.b_login); +- rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_NOMAIL_NOTIFY); ++ rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_MINOR_UPDATE); + } + + /* Add comment and bt */ +@@ -911,7 +911,7 @@ int main(int argc, char **argv) + sprintf(bug_id_str, "%i", bz->bi_id); + log_warning(_("Attaching better backtrace")); + rhbz_attach_blob(client, bug_id_str, FILENAME_BACKTRACE, bt, strlen(bt), +- RHBZ_NOMAIL_NOTIFY); ++ RHBZ_MINOR_UPDATE); + } + } + else +diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c +index 680527d7..cb6505ea 100644 +--- a/src/plugins/rhbz.c ++++ b/src/plugins/rhbz.c +@@ -605,7 +605,7 @@ int rhbz_new_bug(struct abrt_xmlrpc *ax, + return new_bug_id; + } + +-/* suppress mail notify by {s:i} (nomail:1) (driven by flag) */ ++/* suppress mail notify by {s:i} (minor_update:1) (driven by flag) */ + int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, + const char *filename, const char *data, int data_len, int flags) + { +@@ -620,7 +620,7 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, + + char *fn = xasprintf("File: %s", filename); + xmlrpc_value* result; +- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ int minor_update = !!IS_MINOR_UPDATE(flags); + + /* http://www.bugzilla.org/docs/4.2/en/html/api/Bugzilla/WebService/Bug.html#add_attachment + * +@@ -640,10 +640,11 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, + */ + "data", data, (size_t)data_len, + +- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 +- * and version 4.4.rc1.b02 ++ /* If set to true, this is considered a minor update and no mail is sent to users who do not want ++ * minor update emails. If current user is not in the minor_update_group, this parameter is simply ++ * ignored. + */ +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + + free(fn); +@@ -737,25 +738,25 @@ struct bug_info *rhbz_find_origin_bug_closed_duplicate(struct abrt_xmlrpc *ax, + return bi_tmp; + } + +-/* suppress mail notify by {s:i} (nomail:1) */ ++/* suppress mail notify by {s:i} (minor_update:1) */ + void rhbz_mail_to_cc(struct abrt_xmlrpc *ax, int bug_id, const char *mail, int flags) + { + func_entry(); + + xmlrpc_value *result; +- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ int minor_update = !!IS_MINOR_UPDATE(flags); + #if 0 /* Obsolete API */ + result = abrt_xmlrpc_call(ax, "Bug.update", "({s:i,s:{s:(s),s:i}})", + "ids", bug_id, + "updates", "add_cc", mail, +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + #endif + /* Bugzilla 4.0+ uses this API: */ + result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:{s:(s),s:i}}", + "ids", bug_id, + "cc", "add", mail, +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + if (result) + xmlrpc_DECREF(result); +@@ -786,12 +787,12 @@ void rhbz_add_comment(struct abrt_xmlrpc *ax, int bug_id, const char *comment, + func_entry(); + + int private = !!IS_PRIVATE(flags); +- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ int minor_update = !!IS_MINOR_UPDATE(flags); + + xmlrpc_value *result; + result = abrt_xmlrpc_call(ax, "Bug.add_comment", "{s:i,s:s,s:b,s:i}", + "id", bug_id, "comment", comment, +- "private", private, "nomail", nomail_notify); ++ "private", private, "minor_update", minor_update); + + if (result) + xmlrpc_DECREF(result); +@@ -801,15 +802,16 @@ void rhbz_set_url(struct abrt_xmlrpc *ax, int bug_id, const char *url, int flags + { + func_entry(); + +- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ const int minor_update = !!IS_MINOR_UPDATE(flags); + xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:i}", + "ids", bug_id, + "url", url, + +- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 +- * and version 4.4.rc1.b02 ++ /* If set to true, this is considered a minor update and no mail is sent to users who do not want ++ * minor update emails. If current user is not in the minor_update_group, this parameter is simply ++ * ignored. + */ +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + + if (result) +@@ -822,17 +824,18 @@ void rhbz_close_as_duplicate(struct abrt_xmlrpc *ax, int bug_id, + { + func_entry(); + +- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); ++ const int minor_update = !!IS_MINOR_UPDATE(flags); + xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:s,s:i,s:i}", + "ids", bug_id, + "status", "CLOSED", + "resolution", "DUPLICATE", + "dupe_of", duplicate_bug, + +- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 +- * and version 4.4.rc1.b02 ++ /* If set to true, this is considered a minor update and no mail is sent to users who do not want ++ * minor update emails. If current user is not in the minor_update_group, this parameter is simply ++ * ignored. + */ +- "nomail", nomail_notify ++ "minor_update", minor_update + ); + + if (result) +diff --git a/src/plugins/rhbz.h b/src/plugins/rhbz.h +index 86632a35..3990eda0 100644 +--- a/src/plugins/rhbz.h ++++ b/src/plugins/rhbz.h +@@ -36,7 +36,7 @@ enum { + RHBZ_MANDATORY_MEMB = (1 << 0), + RHBZ_READ_STR = (1 << 1), + RHBZ_READ_INT = (1 << 2), +- RHBZ_NOMAIL_NOTIFY = (1 << 3), ++ RHBZ_MINOR_UPDATE = (1 << 3), + RHBZ_PRIVATE = (1 << 4), + RHBZ_BINARY_ATTACHMENT = (1 << 5), + }; +@@ -44,7 +44,7 @@ enum { + #define IS_MANDATORY(flags) ((flags) & RHBZ_MANDATORY_MEMB) + #define IS_READ_STR(flags) ((flags) & RHBZ_READ_STR) + #define IS_READ_INT(flags) ((flags) & RHBZ_READ_INT) +-#define IS_NOMAIL_NOTIFY(flags) ((flags) & RHBZ_NOMAIL_NOTIFY) ++#define IS_MINOR_UPDATE(flags) ((flags) & RHBZ_MINOR_UPDATE) + #define IS_PRIVATE(flags) ((flags) & RHBZ_PRIVATE) + + struct bug_info { +-- +2.17.2 + diff --git a/libreport.spec b/libreport.spec index 782d6fe..503714f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,12 +29,15 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.7 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0001: 0001-rhbz-Replace-nomail-flag-with-minor_update.patch + + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -821,6 +824,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jan 07 2019 Martin Kutlak 2.9.7-2 +- rhbz: Replace nomail flag with minor_update + * Fri Dec 07 2018 Matej Marusak 2.9.7-1 - reportclient: Search for required packages recursively - event_config: Modify unusable backtrace message From 8f048d7d79423a76cfe75dfddd84cbff44164179 Mon Sep 17 00:00:00 2001 From: Igor Gnatenko Date: Sun, 27 Jan 2019 13:06:38 +0100 Subject: [PATCH 031/133] Remove obsolete scriptlets References: https://fedoraproject.org/wiki/Changes/RemoveObsoleteScriptlets Signed-off-by: Igor Gnatenko --- libreport.spec | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/libreport.spec b/libreport.spec index 503714f..adbd375 100644 --- a/libreport.spec +++ b/libreport.spec @@ -477,20 +477,16 @@ make check|| { exit 1 } -%if 0%{?fedora} > 27 || 0%{?rhel} > 7 -# ldconfig and gtk-update-icon-cache is not needed -%else +%ldconfig_scriptlets +%ldconfig_scriptlets web +%if 0%{?rhel} && 0%{?rhel} <= 7 %post gtk -/sbin/ldconfig +%{?ldconfig} # update icon cache touch --no-create %{_datadir}/icons/hicolor &>/dev/null || : -%post -p /sbin/ldconfig - -%postun -p /sbin/ldconfig - %postun gtk -/sbin/ldconfig +%{?ldconfig} if [ $1 -eq 0 ] ; then touch --no-create %{_datadir}/icons/hicolor &>/dev/null gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : @@ -498,12 +494,6 @@ fi %posttrans gtk gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - - -%post web -p /sbin/ldconfig - - -%postun web -p /sbin/ldconfig %endif %files -f %{name}.lang From 6d42aeee65cd5acbf3524d652ad5d0168982f6bf Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 1 Feb 2019 08:07:23 +0000 Subject: [PATCH 032/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index adbd375..9be2f32 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.9.7 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -814,6 +814,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Feb 01 2019 Fedora Release Engineering - 2.9.7-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild + * Mon Jan 07 2019 Martin Kutlak 2.9.7-2 - rhbz: Replace nomail flag with minor_update From 35ff5f8bde61b9bee2f0cb2e0d7dd7dfa3067c61 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Mon, 4 Feb 2019 13:24:58 +0100 Subject: [PATCH 033/133] Update to 2.10.0 Signed-off-by: Ernestas Kulik --- .gitignore | 1 + ...eplace-nomail-flag-with-minor_update.patch | 232 ------------------ ...dden_words-Don-t-hardcode-sysconfdir.patch | 63 +++++ autogen.sh | 70 ------ libreport.spec | 21 +- sources | 2 +- 6 files changed, 78 insertions(+), 311 deletions(-) delete mode 100644 0001-rhbz-Replace-nomail-flag-with-minor_update.patch create mode 100644 0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch delete mode 100755 autogen.sh diff --git a/.gitignore b/.gitignore index ffae115..50a2b87 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ /libreport-2.9.5.tar.gz /libreport-2.9.6.tar.gz /libreport-2.9.7.tar.gz +/libreport-2.10.0.tar.gz diff --git a/0001-rhbz-Replace-nomail-flag-with-minor_update.patch b/0001-rhbz-Replace-nomail-flag-with-minor_update.patch deleted file mode 100644 index 6ab8dce..0000000 --- a/0001-rhbz-Replace-nomail-flag-with-minor_update.patch +++ /dev/null @@ -1,232 +0,0 @@ -From 569bf0e3fed698e93b8e098bf6a0bb2f773aed6a Mon Sep 17 00:00:00 2001 -From: Martin Kutlak -Date: Fri, 4 Jan 2019 12:26:28 +0100 -Subject: [PATCH] rhbz: Replace nomail flag with minor_update - -In Bugzilla v5.0 nomail flag is replaced with minor_update. [1] -Because we still use the old nomail flag emails are being sent for every added attachment/comment. - -Related: rhbz#1660157 -Closes: abrt/abrt#1346 - -See also: -- https://partner-bugzilla.redhat.com/docs/en/html/integrating/api/Bugzilla/WebService/Bug.html?highlight=minor_update - -[1] https://bugzilla.redhat.com/show_bug.cgi?id=1655829 - -Signed-off-by: Martin Kutlak ---- - src/plugins/reporter-bugzilla.c | 12 +++++----- - src/plugins/rhbz.c | 41 ++++++++++++++++++--------------- - src/plugins/rhbz.h | 4 ++-- - 3 files changed, 30 insertions(+), 27 deletions(-) - -diff --git a/src/plugins/reporter-bugzilla.c b/src/plugins/reporter-bugzilla.c -index d4d03f8e..c12e00d1 100644 ---- a/src/plugins/reporter-bugzilla.c -+++ b/src/plugins/reporter-bugzilla.c -@@ -35,7 +35,7 @@ int attach_text_item(struct abrt_xmlrpc *ax, const char *bug_id, - log_debug("attaching '%s' as text", item_name); - int r = rhbz_attach_blob(ax, bug_id, - item_name, item->content, strlen(item->content), -- RHBZ_NOMAIL_NOTIFY -+ RHBZ_MINOR_UPDATE - ); - return (r == 0); - } -@@ -63,7 +63,7 @@ int attach_file_item(struct abrt_xmlrpc *ax, const char *bug_id, - return 0; - } - log_debug("attaching '%s' as file", item_name); -- int flag = RHBZ_NOMAIL_NOTIFY; -+ int flag = RHBZ_MINOR_UPDATE; - if (!(item->flags & CD_FLAG_BIGTXT)) - flag |= RHBZ_BINARY_ATTACHMENT; - int r = rhbz_attach_fd(ax, bug_id, item_name, fd, flag); -@@ -793,7 +793,7 @@ int main(int argc, char **argv) - if (reported_to && reported_to->url) - { - log_warning(_("Adding External URL to bug %i"), new_id); -- rhbz_set_url(client, new_id, reported_to->url, RHBZ_NOMAIL_NOTIFY); -+ rhbz_set_url(client, new_id, reported_to->url, RHBZ_MINOR_UPDATE); - free_report_result(reported_to); - } - } -@@ -821,7 +821,7 @@ int main(int argc, char **argv) - if (existing_id >= 0) - { - log_warning(_("Closing bug %i as duplicate of bug %i"), new_id, existing_id); -- rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_NOMAIL_NOTIFY); -+ rhbz_close_as_duplicate(client, new_id, existing_id, RHBZ_MINOR_UPDATE); - } - - goto log_out; -@@ -876,7 +876,7 @@ int main(int argc, char **argv) - && !g_list_find_custom(bz->bi_cc_list, rhbz.b_login, (GCompareFunc)g_strcmp0) - ) { - log_warning(_("Adding %s to CC list"), rhbz.b_login); -- rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_NOMAIL_NOTIFY); -+ rhbz_mail_to_cc(client, bz->bi_id, rhbz.b_login, RHBZ_MINOR_UPDATE); - } - - /* Add comment and bt */ -@@ -911,7 +911,7 @@ int main(int argc, char **argv) - sprintf(bug_id_str, "%i", bz->bi_id); - log_warning(_("Attaching better backtrace")); - rhbz_attach_blob(client, bug_id_str, FILENAME_BACKTRACE, bt, strlen(bt), -- RHBZ_NOMAIL_NOTIFY); -+ RHBZ_MINOR_UPDATE); - } - } - else -diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c -index 680527d7..cb6505ea 100644 ---- a/src/plugins/rhbz.c -+++ b/src/plugins/rhbz.c -@@ -605,7 +605,7 @@ int rhbz_new_bug(struct abrt_xmlrpc *ax, - return new_bug_id; - } - --/* suppress mail notify by {s:i} (nomail:1) (driven by flag) */ -+/* suppress mail notify by {s:i} (minor_update:1) (driven by flag) */ - int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, - const char *filename, const char *data, int data_len, int flags) - { -@@ -620,7 +620,7 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, - - char *fn = xasprintf("File: %s", filename); - xmlrpc_value* result; -- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ int minor_update = !!IS_MINOR_UPDATE(flags); - - /* http://www.bugzilla.org/docs/4.2/en/html/api/Bugzilla/WebService/Bug.html#add_attachment - * -@@ -640,10 +640,11 @@ int rhbz_attach_blob(struct abrt_xmlrpc *ax, const char *bug_id, - */ - "data", data, (size_t)data_len, - -- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 -- * and version 4.4.rc1.b02 -+ /* If set to true, this is considered a minor update and no mail is sent to users who do not want -+ * minor update emails. If current user is not in the minor_update_group, this parameter is simply -+ * ignored. - */ -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - - free(fn); -@@ -737,25 +738,25 @@ struct bug_info *rhbz_find_origin_bug_closed_duplicate(struct abrt_xmlrpc *ax, - return bi_tmp; - } - --/* suppress mail notify by {s:i} (nomail:1) */ -+/* suppress mail notify by {s:i} (minor_update:1) */ - void rhbz_mail_to_cc(struct abrt_xmlrpc *ax, int bug_id, const char *mail, int flags) - { - func_entry(); - - xmlrpc_value *result; -- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ int minor_update = !!IS_MINOR_UPDATE(flags); - #if 0 /* Obsolete API */ - result = abrt_xmlrpc_call(ax, "Bug.update", "({s:i,s:{s:(s),s:i}})", - "ids", bug_id, - "updates", "add_cc", mail, -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - #endif - /* Bugzilla 4.0+ uses this API: */ - result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:{s:(s),s:i}}", - "ids", bug_id, - "cc", "add", mail, -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - if (result) - xmlrpc_DECREF(result); -@@ -786,12 +787,12 @@ void rhbz_add_comment(struct abrt_xmlrpc *ax, int bug_id, const char *comment, - func_entry(); - - int private = !!IS_PRIVATE(flags); -- int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ int minor_update = !!IS_MINOR_UPDATE(flags); - - xmlrpc_value *result; - result = abrt_xmlrpc_call(ax, "Bug.add_comment", "{s:i,s:s,s:b,s:i}", - "id", bug_id, "comment", comment, -- "private", private, "nomail", nomail_notify); -+ "private", private, "minor_update", minor_update); - - if (result) - xmlrpc_DECREF(result); -@@ -801,15 +802,16 @@ void rhbz_set_url(struct abrt_xmlrpc *ax, int bug_id, const char *url, int flags - { - func_entry(); - -- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ const int minor_update = !!IS_MINOR_UPDATE(flags); - xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:i}", - "ids", bug_id, - "url", url, - -- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 -- * and version 4.4.rc1.b02 -+ /* If set to true, this is considered a minor update and no mail is sent to users who do not want -+ * minor update emails. If current user is not in the minor_update_group, this parameter is simply -+ * ignored. - */ -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - - if (result) -@@ -822,17 +824,18 @@ void rhbz_close_as_duplicate(struct abrt_xmlrpc *ax, int bug_id, - { - func_entry(); - -- const int nomail_notify = !!IS_NOMAIL_NOTIFY(flags); -+ const int minor_update = !!IS_MINOR_UPDATE(flags); - xmlrpc_value *result = abrt_xmlrpc_call(ax, "Bug.update", "{s:i,s:s,s:s,s:i,s:i}", - "ids", bug_id, - "status", "CLOSED", - "resolution", "DUPLICATE", - "dupe_of", duplicate_bug, - -- /* Undocumented argument but it works with Red Hat Bugzilla version 4.2.4-7 -- * and version 4.4.rc1.b02 -+ /* If set to true, this is considered a minor update and no mail is sent to users who do not want -+ * minor update emails. If current user is not in the minor_update_group, this parameter is simply -+ * ignored. - */ -- "nomail", nomail_notify -+ "minor_update", minor_update - ); - - if (result) -diff --git a/src/plugins/rhbz.h b/src/plugins/rhbz.h -index 86632a35..3990eda0 100644 ---- a/src/plugins/rhbz.h -+++ b/src/plugins/rhbz.h -@@ -36,7 +36,7 @@ enum { - RHBZ_MANDATORY_MEMB = (1 << 0), - RHBZ_READ_STR = (1 << 1), - RHBZ_READ_INT = (1 << 2), -- RHBZ_NOMAIL_NOTIFY = (1 << 3), -+ RHBZ_MINOR_UPDATE = (1 << 3), - RHBZ_PRIVATE = (1 << 4), - RHBZ_BINARY_ATTACHMENT = (1 << 5), - }; -@@ -44,7 +44,7 @@ enum { - #define IS_MANDATORY(flags) ((flags) & RHBZ_MANDATORY_MEMB) - #define IS_READ_STR(flags) ((flags) & RHBZ_READ_STR) - #define IS_READ_INT(flags) ((flags) & RHBZ_READ_INT) --#define IS_NOMAIL_NOTIFY(flags) ((flags) & RHBZ_NOMAIL_NOTIFY) -+#define IS_MINOR_UPDATE(flags) ((flags) & RHBZ_MINOR_UPDATE) - #define IS_PRIVATE(flags) ((flags) & RHBZ_PRIVATE) - - struct bug_info { --- -2.17.2 - diff --git a/0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch b/0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch new file mode 100644 index 0000000..f12969c --- /dev/null +++ b/0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch @@ -0,0 +1,63 @@ +From 7df0987d2373df664cee3014ac0ad94186ac7acb Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Mon, 4 Feb 2019 10:12:04 +0100 +Subject: [PATCH] =?UTF-8?q?tests:=20forbidden=5Fwords:=20Don=E2=80=99t=20h?= + =?UTF-8?q?ardcode=20sysconfdir?= +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +As it may not necessarily be /etc (an example would be rpmbuild, where +it can become /usr/local/etc or somesuch), it would make more sense to +do the same thing libreport does - define $sysconfdir in a macro. + +Signed-off-by: Ernestas Kulik +--- + tests/Makefile.am | 3 +++ + tests/forbidden_words.at | 2 +- + tests/local.at | 2 +- + 3 files changed, 5 insertions(+), 2 deletions(-) + +diff --git a/tests/Makefile.am b/tests/Makefile.am +index 89d5f694..d46d5772 100644 +--- a/tests/Makefile.am ++++ b/tests/Makefile.am +@@ -29,6 +29,9 @@ libreport_include_helpers_HEADERS = \ + helpers/testsuite.h \ + helpers/testsuite_tools.h + ++TESTSUITEFLAGS = \ ++ CPPFLAGS='-DCONF_DIR="$(CONF_DIR)" $(CPPFLAGS)' ++ + TESTSUITE_AT = \ + local.at \ + testsuite.at \ +diff --git a/tests/forbidden_words.at b/tests/forbidden_words.at +index 259ebc1d..a6c0193d 100644 +--- a/tests/forbidden_words.at ++++ b/tests/forbidden_words.at +@@ -34,7 +34,7 @@ TS_MAIN + { + dynamic_words = load_words_from_file("test_ignored.conf"); + } +- TS_ASSERT_STDERR_EQ_END("Can't open /etc/libreport/test_ignored.conf: No such file or directory\n", "User notified about errors!"); ++ TS_ASSERT_STDERR_EQ_END("Can't open " CONF_DIR "/test_ignored.conf: No such file or directory\n", "User notified about errors!"); + + TS_ASSERT_PTR_IS_NOT_NULL(dynamic_words); + +diff --git a/tests/local.at b/tests/local.at +index 00e088ff..3a181239 100644 +--- a/tests/local.at ++++ b/tests/local.at +@@ -6,7 +6,7 @@ + # Compile SOURCES into OUTPUT. If OUTPUT does not contain '.', + # assume that we are linking too; this is a hack. + m4_define([AT_COMPILE], +-[AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS m4_bmatch([$1], [[.]], [], [$LDFLAGS ])-o $1 m4_default([$2], [$1.c])[]m4_bmatch([$1], [[.]], [], [ $LIBS])], ++[AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $CPPFLAGS m4_bmatch([$1], [[.]], [], [$LDFLAGS ])-o $1 m4_default([$2], [$1.c])[]m4_bmatch([$1], [[.]], [], [ $LIBS])], + 0, [ignore], [ignore])]) + + # ------------------------ +-- +2.20.1 + diff --git a/autogen.sh b/autogen.sh deleted file mode 100755 index c6e1729..0000000 --- a/autogen.sh +++ /dev/null @@ -1,70 +0,0 @@ -#! /bin/sh - -print_help() -{ -cat << EOH -Prepares the source tree for configuration - -Usage: - autogen.sh [sydeps [--install]] - -Options: - - sysdeps prints out all dependencies - --install install all dependencies ('sudo yum install \$DEPS') - -EOH -} - -build_depslist() -{ - DEPS_LIST=`grep "^\(Build\)\?Requires:" *.spec.in | grep -v "%{name}" | tr -s " " | tr "," "\n" | cut -f2 -d " " | grep -v "^libreport" | sort -u | tr "\n" " "` -} - -case "$1" in - "--help"|"-h") - print_help - exit 0 - ;; - "sysdeps") - build_depslist - - if [ "$2" == "--install" ]; then - set -x verbose - sudo yum install $DEPS_LIST - set +x verbose - else - echo $DEPS_LIST - fi - exit 0 - ;; - *) - echo "Running gen-version" - ./gen-version - - mkdir -p m4 - echo "Creating m4/aclocal.m4 ..." - test -r m4/aclocal.m4 || touch m4/aclocal.m4 - - echo "Running autopoint" - autopoint --force || exit 1 - - echo "Running intltoolize..." - intltoolize --force --copy --automake || exit 1 - - echo "Running aclocal..." - aclocal || exit 1 - - echo "Running libtoolize..." - libtoolize || exit 1 - - echo "Running autoheader..." - autoheader || return 1 - - echo "Running autoconf..." - autoconf --force || exit 1 - - echo "Running automake..." - automake --add-missing --force --copy || exit 1 - ;; -esac diff --git a/libreport.spec b/libreport.spec index 9be2f32..8703bfa 100644 --- a/libreport.spec +++ b/libreport.spec @@ -10,7 +10,7 @@ %define libjson_devel json-c-devel %endif -%define glib_ver 2.43 +%define glib_ver 2.43.4 %if 0%{?fedora} || 0%{?rhel} > 7 # Enable python3 build by default @@ -28,16 +28,13 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.9.7 -Release: 3%{?dist} +Version: 2.10.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0001: 0001-rhbz-Replace-nomail-flag-with-minor_update.patch - - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -367,9 +364,11 @@ data over ftp/scp... %autosetup -S git %build -autoconf +./gen-version +autoreconf -if +intltoolize --automake -c -f -CFLAGS="%{optflags} -Werror" %configure \ +%configure \ %if %{without python2} --without-python2 \ %endif # with python2 @@ -542,6 +541,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/problem_details_widget.h %{_includedir}/libreport/problem_details_dialog.h %{_includedir}/libreport/problem_utils.h +%{_includedir}/libreport/report_result.h %{_includedir}/libreport/ureport.h %{_includedir}/libreport/reporters.h %{_includedir}/libreport/global_configuration.h @@ -814,6 +814,11 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sat Feb 02 2019 Ernestas Kulik - 2.10.0-1 +- Update to 2.10.0 +- Bump GLib dependency +- Add patch to work around issue with test + * Fri Feb 01 2019 Fedora Release Engineering - 2.9.7-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild diff --git a/sources b/sources index 9749b3c..948e33d 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.9.7.tar.gz) = 8e92470ada204236ae4540145ba7f750814c74b0f5858d25ec797f06d4daeb9fc40996b609a33e154072a45624513d7dbd4027587708ffbfb2f40b0687b16ac3 +SHA512 (libreport-2.10.0.tar.gz) = 978ea442d82b75abf80b2075f540cb05c5577387a9221f2070c9695c4546d36169738d223f5e903d0b774b7e1566a6111c55a6bb51a0822ad1676095f067c45b From 7aed889e6b33049f591d7dcba9735fa5cac75630 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Mon, 4 Feb 2019 13:44:25 +0100 Subject: [PATCH 034/133] Drop unused patch Using %configure takes care of things now. Signed-off-by: Ernestas Kulik --- ...dden_words-Don-t-hardcode-sysconfdir.patch | 63 ------------------- libreport.spec | 5 +- 2 files changed, 4 insertions(+), 64 deletions(-) delete mode 100644 0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch diff --git a/0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch b/0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch deleted file mode 100644 index f12969c..0000000 --- a/0001-tests-forbidden_words-Don-t-hardcode-sysconfdir.patch +++ /dev/null @@ -1,63 +0,0 @@ -From 7df0987d2373df664cee3014ac0ad94186ac7acb Mon Sep 17 00:00:00 2001 -From: Ernestas Kulik -Date: Mon, 4 Feb 2019 10:12:04 +0100 -Subject: [PATCH] =?UTF-8?q?tests:=20forbidden=5Fwords:=20Don=E2=80=99t=20h?= - =?UTF-8?q?ardcode=20sysconfdir?= -MIME-Version: 1.0 -Content-Type: text/plain; charset=UTF-8 -Content-Transfer-Encoding: 8bit - -As it may not necessarily be /etc (an example would be rpmbuild, where -it can become /usr/local/etc or somesuch), it would make more sense to -do the same thing libreport does - define $sysconfdir in a macro. - -Signed-off-by: Ernestas Kulik ---- - tests/Makefile.am | 3 +++ - tests/forbidden_words.at | 2 +- - tests/local.at | 2 +- - 3 files changed, 5 insertions(+), 2 deletions(-) - -diff --git a/tests/Makefile.am b/tests/Makefile.am -index 89d5f694..d46d5772 100644 ---- a/tests/Makefile.am -+++ b/tests/Makefile.am -@@ -29,6 +29,9 @@ libreport_include_helpers_HEADERS = \ - helpers/testsuite.h \ - helpers/testsuite_tools.h - -+TESTSUITEFLAGS = \ -+ CPPFLAGS='-DCONF_DIR="$(CONF_DIR)" $(CPPFLAGS)' -+ - TESTSUITE_AT = \ - local.at \ - testsuite.at \ -diff --git a/tests/forbidden_words.at b/tests/forbidden_words.at -index 259ebc1d..a6c0193d 100644 ---- a/tests/forbidden_words.at -+++ b/tests/forbidden_words.at -@@ -34,7 +34,7 @@ TS_MAIN - { - dynamic_words = load_words_from_file("test_ignored.conf"); - } -- TS_ASSERT_STDERR_EQ_END("Can't open /etc/libreport/test_ignored.conf: No such file or directory\n", "User notified about errors!"); -+ TS_ASSERT_STDERR_EQ_END("Can't open " CONF_DIR "/test_ignored.conf: No such file or directory\n", "User notified about errors!"); - - TS_ASSERT_PTR_IS_NOT_NULL(dynamic_words); - -diff --git a/tests/local.at b/tests/local.at -index 00e088ff..3a181239 100644 ---- a/tests/local.at -+++ b/tests/local.at -@@ -6,7 +6,7 @@ - # Compile SOURCES into OUTPUT. If OUTPUT does not contain '.', - # assume that we are linking too; this is a hack. - m4_define([AT_COMPILE], --[AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS m4_bmatch([$1], [[.]], [], [$LDFLAGS ])-o $1 m4_default([$2], [$1.c])[]m4_bmatch([$1], [[.]], [], [ $LIBS])], -+[AT_CHECK([$LIBTOOL --mode=link $CC $CFLAGS $CPPFLAGS m4_bmatch([$1], [[.]], [], [$LDFLAGS ])-o $1 m4_default([$2], [$1.c])[]m4_bmatch([$1], [[.]], [], [ $LIBS])], - 0, [ignore], [ignore])]) - - # ------------------------ --- -2.20.1 - diff --git a/libreport.spec b/libreport.spec index 8703bfa..321785e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.10.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -814,6 +814,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Feb 04 2019 Ernestas Kulik - 2.10.0-2 +- Remove unused patch + * Sat Feb 02 2019 Ernestas Kulik - 2.10.0-1 - Update to 2.10.0 - Bump GLib dependency From 216f0e95b1a9f96f02894aef977b26d966fbe0cf Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Tue, 23 Apr 2019 08:34:18 +0200 Subject: [PATCH 035/133] Add patch to add workflow field when saving FAF response Needed to make one Cockpit test pass. Signed-off-by: Ernestas Kulik --- ...rt-workflow-when-saving-server-respo.patch | 44 +++++++++++++++++++ libreport.spec | 6 ++- 2 files changed, 49 insertions(+), 1 deletion(-) create mode 100644 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch diff --git a/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch b/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch new file mode 100644 index 0000000..a09575b --- /dev/null +++ b/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch @@ -0,0 +1,44 @@ +From f2d98e0ee81037f18e50c06e409def19e791c2f2 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Wed, 17 Apr 2019 13:24:19 +0200 +Subject: [PATCH] lib: ureport: Export workflow when saving server response + +Oversight from 779b16202c3fe990f6ecda17085c436899340e12. + +Signed-off-by: Ernestas Kulik +--- + src/lib/ureport.c | 18 +++++++++++++++++- + 1 file changed, 17 insertions(+), 1 deletion(-) + +diff --git a/src/lib/ureport.c b/src/lib/ureport.c +index cc18aefd..a5953244 100644 +--- a/src/lib/ureport.c ++++ b/src/lib/ureport.c +@@ -680,7 +680,23 @@ ureport_server_response_save_in_dump_dir(struct ureport_server_response *resp, + if (resp->urr_reported_to_list) + { + for (GList *e = resp->urr_reported_to_list; e; e = g_list_next(e)) +- add_reported_to(dd, e->data); ++ { ++ char *workflow; ++ ++ workflow = getenv("LIBREPORT_WORKFLOW"); ++ if (NULL == workflow) ++ { ++ add_reported_to(dd, e->data); ++ } ++ else ++ { ++ g_autofree char *line = NULL; ++ ++ line = g_strdup_printf("%s WORKFLOW=%s", (const char *)e->data, workflow); ++ ++ add_reported_to(dd, line); ++ } ++ } + } + + if (resp->urr_solution) +-- +2.21.0 + diff --git a/libreport.spec b/libreport.spec index 321785e..82f4170 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,11 +29,12 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.10.0 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0: 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -814,6 +815,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Apr 23 2019 Ernestas Kulik - 2.10.0-3 +- Add patch to fix workflow fields not being added to reported_to when μReport response comes with a Bugzilla URL + * Mon Feb 04 2019 Ernestas Kulik - 2.10.0-2 - Remove unused patch From 7b7c13b2976c721e67277c16e299fc1906894262 Mon Sep 17 00:00:00 2001 From: Martin Kutlak Date: Wed, 3 Jul 2019 12:44:33 +0200 Subject: [PATCH 036/133] New upstream release 2.10.1 * Remove gen-version from spec - This is upstream script to generate version. This is not needed in dist-git. [2.10.1] - 2019-07-03 Changed - Clearer warnings about missing report elements. - Export workflow when saving server response. - uReport workflow moved to plugin-ureport subpackage. - Refined composition of error messages during problem reporting. Fixed - Fixed dump dir lock up in case of delete failure. Signed-off-by: Martin Kutlak --- .gitignore | 1 + ...rt-workflow-when-saving-server-respo.patch | 44 ------------------- libreport.spec | 38 ++++++++++++---- sources | 2 +- 4 files changed, 32 insertions(+), 53 deletions(-) delete mode 100644 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch diff --git a/.gitignore b/.gitignore index 50a2b87..7c0c165 100644 --- a/.gitignore +++ b/.gitignore @@ -4,3 +4,4 @@ /libreport-2.9.6.tar.gz /libreport-2.9.7.tar.gz /libreport-2.10.0.tar.gz +/libreport-2.10.1.tar.gz diff --git a/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch b/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch deleted file mode 100644 index a09575b..0000000 --- a/0001-lib-ureport-Export-workflow-when-saving-server-respo.patch +++ /dev/null @@ -1,44 +0,0 @@ -From f2d98e0ee81037f18e50c06e409def19e791c2f2 Mon Sep 17 00:00:00 2001 -From: Ernestas Kulik -Date: Wed, 17 Apr 2019 13:24:19 +0200 -Subject: [PATCH] lib: ureport: Export workflow when saving server response - -Oversight from 779b16202c3fe990f6ecda17085c436899340e12. - -Signed-off-by: Ernestas Kulik ---- - src/lib/ureport.c | 18 +++++++++++++++++- - 1 file changed, 17 insertions(+), 1 deletion(-) - -diff --git a/src/lib/ureport.c b/src/lib/ureport.c -index cc18aefd..a5953244 100644 ---- a/src/lib/ureport.c -+++ b/src/lib/ureport.c -@@ -680,7 +680,23 @@ ureport_server_response_save_in_dump_dir(struct ureport_server_response *resp, - if (resp->urr_reported_to_list) - { - for (GList *e = resp->urr_reported_to_list; e; e = g_list_next(e)) -- add_reported_to(dd, e->data); -+ { -+ char *workflow; -+ -+ workflow = getenv("LIBREPORT_WORKFLOW"); -+ if (NULL == workflow) -+ { -+ add_reported_to(dd, e->data); -+ } -+ else -+ { -+ g_autofree char *line = NULL; -+ -+ line = g_strdup_printf("%s WORKFLOW=%s", (const char *)e->data, workflow); -+ -+ add_reported_to(dd, line); -+ } -+ } - } - - if (resp->urr_solution) --- -2.21.0 - diff --git a/libreport.spec b/libreport.spec index 82f4170..be51c50 100644 --- a/libreport.spec +++ b/libreport.spec @@ -28,14 +28,12 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.10.0 -Release: 3%{?dist} +Version: 2.10.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0: 0001-lib-ureport-Export-workflow-when-saving-server-respo.patch - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -312,6 +310,7 @@ install this package and you're done. %package rhel Summary: Default configuration for reporting bugs via Red Hat infrastructure Requires: %{name} = %{version}-%{release} +Requires: %{name}-plugin-ureport %description rhel Default configuration for reporting bugs via Red Hat infrastructure @@ -365,7 +364,6 @@ data over ftp/scp... %autosetup -S git %build -./gen-version autoreconf -if intltoolize --automake -c -f @@ -642,6 +640,11 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/ureport.conf.5.gz %{_datadir}/%{name}/events/report_uReport.xml %{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.ureport.xml +%if 0%{?rhel} +%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf +%{_datadir}/%{name}/workflows/workflow_uReport.xml +%{_mandir}/man5/report_uReport.conf.5.* +%endif %if %{with bugzilla} %files plugin-bugzilla @@ -772,12 +775,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_datadir}/%{name}/workflows/workflow_RHELAddDatavmcore.xml %{_datadir}/%{name}/workflows/workflow_RHELAddDataxorg.xml %{_datadir}/%{name}/workflows/workflow_RHELAddDataJavaScript.xml -%{_datadir}/%{name}/workflows/workflow_uReport.xml %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel.conf %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf -%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_mandir}/man5/report_rhel.conf.5.* -%{_mandir}/man5/report_uReport.conf.5.* %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml @@ -815,6 +815,28 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Jul 03 2019 Martin Kutlak 2.10.1-1 +- doc: Makefile.am: Use correct path for --conf-file +- lib: copy_file_recursive: Use GLib abstractions +- gui-wizard-gtk: Fix fix +- cli: run-command: Replace use of vfork() with fork() +- plugins: rhbz: Don’t call strlen() on attachment data +- Check for empty fmt_file name when printing error msgs +- cli: Unpack command-line argument parsing logic +- lib: event_config: Remove pointless assignment +- gui-wizard-gtk: Fix never-read assignment +- lib: xatonum: Check string parameters +- Rework and refine composition of error messages +- Add clearer warnings about missing report elements specified in format files +- Move uReport workflow to plugin-ureport subpackage +- lib: ureport: Export workflow when saving server response +- lib: dump_dir: Clean up on failure in dd_delete() +- Use #ifdef to check whether macros are defined +- autogen.sh: Use autoreconf +- autogen.sh: Allow skipping running configure +- tests: forbidden_words: Don’t hardcode sysconfdir +- Makefile.am: Use correct locale when getting date + * Tue Apr 23 2019 Ernestas Kulik - 2.10.0-3 - Add patch to fix workflow fields not being added to reported_to when μReport response comes with a Bugzilla URL diff --git a/sources b/sources index 948e33d..8632440 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.10.0.tar.gz) = 978ea442d82b75abf80b2075f540cb05c5577387a9221f2070c9695c4546d36169738d223f5e903d0b774b7e1566a6111c55a6bb51a0822ad1676095f067c45b +SHA512 (libreport-2.10.1.tar.gz) = 9c110b7a5f0e3803d12b7ea05eaf47b3a37592612f0107ed7e6604168d283a09bf3d08b805b415ec90772498062b742814cbf86a8b9ea0f4cc5ff774a77d9671 From db8863c3f17ce0565d3e43e9c5cb6c123bdb3419 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 25 Jul 2019 14:16:46 +0000 Subject: [PATCH 037/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index be51c50..8872f1a 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.10.1 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -815,6 +815,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jul 25 2019 Fedora Release Engineering - 2.10.1-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild + * Wed Jul 03 2019 Martin Kutlak 2.10.1-1 - doc: Makefile.am: Use correct path for --conf-file - lib: copy_file_recursive: Use GLib abstractions From 3e1f0487c10d6615bcdefc17383f8d09deef8aac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Sat, 17 Aug 2019 16:51:40 +0200 Subject: [PATCH 038/133] Rebuilt for Python 3.8 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 8872f1a..ed8c58c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.10.1 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -815,6 +815,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sat Aug 17 2019 Miro Hrončok - 2.10.1-3 +- Rebuilt for Python 3.8 + * Thu Jul 25 2019 Fedora Release Engineering - 2.10.1-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild From b657b8c0e986ae0273f63ab28d1ca5eba0a9772c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Thu, 3 Oct 2019 13:56:02 +0200 Subject: [PATCH 039/133] Rebuilt for Python 3.8.0rc1 (#1748018) --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index ed8c58c..32975d4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -29,7 +29,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.10.1 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -815,6 +815,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Oct 03 2019 Miro Hrončok - 2.10.1-4 +- Rebuilt for Python 3.8.0rc1 (#1748018) + * Sat Aug 17 2019 Miro Hrončok - 2.10.1-3 - Rebuilt for Python 3.8 From 7b5261251a8adbc761f535398eafa96c5a88bd84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Oct 2019 15:08:34 +0200 Subject: [PATCH 040/133] New upstream release 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + libreport.spec | 102 ++++++++++++++----------------------------------- sources | 2 +- 3 files changed, 30 insertions(+), 75 deletions(-) diff --git a/.gitignore b/.gitignore index 7c0c165..adce7e2 100644 --- a/.gitignore +++ b/.gitignore @@ -5,3 +5,4 @@ /libreport-2.9.7.tar.gz /libreport-2.10.0.tar.gz /libreport-2.10.1.tar.gz +/libreport-2.11.0.tar.gz diff --git a/libreport.spec b/libreport.spec index 32975d4..9c72078 100644 --- a/libreport.spec +++ b/libreport.spec @@ -12,38 +12,18 @@ %define glib_ver 2.43.4 -%if 0%{?fedora} || 0%{?rhel} > 7 -# Enable python3 build by default -%bcond_without python3 -%else -%bcond_with python3 -%endif - -%if 0%{?rhel} > 7 || 0%{?fedora} > 28 -# Disable python2 build by default -%bcond_with python2 -%else -%bcond_without python2 -%endif - Summary: Generic library for reporting various problems Name: libreport -Version: 2.10.1 -Release: 4%{?dist} +Version: 2.11.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel BuildRequires: desktop-file-utils -%if %{with python2} -BuildRequires: python2-devel -%endif # with python2 -%if %{with python3} BuildRequires: python3-devel -%endif # with python3 BuildRequires: gettext BuildRequires: libxml2-devel BuildRequires: libtar-devel @@ -115,22 +95,6 @@ Requires: libreport-web = %{version}-%{release} %description web-devel Development headers for libreport-web -%if %{with python2} -%package -n python2-libreport -Summary: Python bindings for report-libs -Requires: libreport = %{version}-%{release} -Requires: python2-dnf -%{?python_provide:%python_provide python2-libreport} -# Remove before F30 -Provides: %{name}-python = %{version}-%{release} -Provides: %{name}-python%{?_isa} = %{version}-%{release} -Obsoletes: %{name}-python < %{version}-%{release} - -%description -n python2-libreport -Python bindings for report-libs. -%endif # with python2 - -%if %{with python3} %package -n python3-libreport Summary: Python 3 bindings for report-libs %if 0%{?_module_build} @@ -146,14 +110,9 @@ Requires: libreport = %{version}-%{release} %endif Requires: python3-dnf %{?python_provide:%python_provide python3-libreport} -# Remove before F30 -Provides: %{name}-python3 = %{version}-%{release} -Provides: %{name}-python3%{?_isa} = %{version}-%{release} -Obsoletes: %{name}-python3 < %{version}-%{release} %description -n python3-libreport Python 3 bindings for report-libs. -%endif # with python3 %package cli Summary: %{name}'s command line interface @@ -177,7 +136,6 @@ bugs Summary: GTK front-end for libreport Requires: libreport = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -Requires: fros >= 1.0 Provides: report-gtk = 0:0.23-1 Obsoletes: report-gtk < 0:0.23-1 @@ -257,12 +215,7 @@ BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} %if 0%{?rhel} -%if %{with python2} -Requires: python-rhsm -%endif # with python2 -%if %{with python3} Requires: python3-subscription-manager-rhsm -%endif # with python3 %endif %description plugin-ureport @@ -364,16 +317,9 @@ data over ftp/scp... %autosetup -S git %build -autoreconf -if -intltoolize --automake -c -f +autoconf -%configure \ -%if %{without python2} - --without-python2 \ -%endif # with python2 -%if %{without python3} - --without-python3 \ -%endif # with python3 +CFLAGS="%{optflags} -Werror" %configure \ %if %{without bugzilla} --without-bugzilla \ %endif @@ -492,6 +438,7 @@ fi %posttrans gtk gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : + %endif %files -f %{name}.lang @@ -533,6 +480,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/problem_data.h %{_includedir}/libreport/problem_report.h %{_includedir}/libreport/report.h +%{_includedir}/libreport/report_result.h %{_includedir}/libreport/run_event.h %{_includedir}/libreport/file_obj.h %{_includedir}/libreport/config_item_info.h @@ -540,7 +488,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/problem_details_widget.h %{_includedir}/libreport/problem_details_dialog.h %{_includedir}/libreport/problem_utils.h -%{_includedir}/libreport/report_result.h %{_includedir}/libreport/ureport.h %{_includedir}/libreport/reporters.h %{_includedir}/libreport/global_configuration.h @@ -562,17 +509,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/libreport_curl.h %{_libdir}/pkgconfig/libreport-web.pc -%if %{with python2} -%files -n python2-libreport -%{python2_sitearch}/report/ -%{python2_sitearch}/reportclient/ -%endif # with python2 - -%if %{with python3} %files -n python3-libreport %{python3_sitearch}/report/ %{python3_sitearch}/reportclient/ -%endif # with python3 %files cli %{_bindir}/report-cli @@ -585,9 +524,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %files gtk %{_bindir}/report-gtk %{_libdir}/libreport-gtk.so.* -%config(noreplace) %{_sysconfdir}/libreport/events.d/emergencyanalysis_event.conf -%{_mandir}/man5/emergencyanalysis_event.conf.5.* -%{_datadir}/%{name}/events/report_EmergencyAnalysis.xml %{_mandir}/man1/report-gtk.1.gz %files gtk-devel @@ -621,7 +557,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/plugins/mailx.conf %{_datadir}/%{name}/conf.d/plugins/mailx.conf %{_datadir}/%{name}/events/report_Mailx.xml -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.mailx.xml %{_datadir}/%{name}/workflows/workflow_Mailx.xml %{_datadir}/%{name}/workflows/workflow_MailxCCpp.xml %config(noreplace) %{_sysconfdir}/libreport/events.d/mailx_event.conf @@ -639,7 +574,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man1/reporter-ureport.1.gz %{_mandir}/man5/ureport.conf.5.gz %{_datadir}/%{name}/events/report_uReport.xml -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.ureport.xml %if 0%{?rhel} %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_datadir}/%{name}/workflows/workflow_uReport.xml @@ -653,12 +587,12 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_format.conf %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_formatdup.conf %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_format_analyzer_libreport.conf +%config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_formatdup_analyzer_libreport.conf %config(noreplace) %{_sysconfdir}/libreport/plugins/bugzilla_format_kernel.conf %{_datadir}/%{name}/events/report_Bugzilla.xml %{_datadir}/%{name}/events/watch_Bugzilla.xml %config(noreplace) %{_sysconfdir}/libreport/events/report_Bugzilla.conf %config(noreplace) %{_sysconfdir}/libreport/events.d/bugzilla_event.conf -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.bugzilla.xml # FIXME: remove with the old gui %{_mandir}/man1/reporter-bugzilla.1.gz %{_mandir}/man5/report_Bugzilla.conf.5.* @@ -667,6 +601,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/bugzilla_format.conf.5.* %{_mandir}/man5/bugzilla_formatdup.conf.5.* %{_mandir}/man5/bugzilla_format_analyzer_libreport.conf.5.* +%{_mandir}/man5/bugzilla_formatdup_analyzer_libreport.conf.5.* %{_mandir}/man5/bugzilla_format_kernel.conf.5.* %{_bindir}/reporter-bugzilla %endif @@ -710,7 +645,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_datadir}/%{name}/conf.d/plugins/rhtsupport.conf %{_datadir}/%{name}/events/report_RHTSupport.xml %{_datadir}/%{name}/events/report_RHTSupport_AddData.xml -%{_datadir}/dbus-1/interfaces/com.redhat.problems.configuration.rhtsupport.xml %if 0%{?rhel} %attr(600,root,root)%{_sysconfdir}/%{name}/cert-api.access.redhat.com.pem %endif @@ -815,6 +749,26 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Oct 11 2019 Matěj Grabovský 2.11.0-1 +- Remove option for emergency analysis/reporting +- tests: proc_helpers: Fix call to errx() +- plugins: bugzilla: Add format file for libreport duplicates +- dbus: Remove interface introspection files +- lib: Don't warn if a configuration key is missing +- gtk: Handle event wildcards in command line options +- gtk: Better handling of workflows with wildcarded events +- lib: Remove unused arguments of prepare_commands +- lib: Reintroduce error logging in event XML parser +- cli: Continue running even if some events have no commands +- cli: Expand event name wildcards +- lib: Expand wildcards in workflow XML parser +- lib: Add a function to expand wildcards in event names +- style: Simplify code; fix typos in comments +- gitignore: Update with missing and renamed generated files +- dirsize: Skip dirs in which sosreport is being generated +- tests: Fix Python tests being skipped unconditionally +- Remove Python 2 support + * Thu Oct 03 2019 Miro Hrončok - 2.10.1-4 - Rebuilt for Python 3.8.0rc1 (#1748018) diff --git a/sources b/sources index 8632440..c84495f 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.10.1.tar.gz) = 9c110b7a5f0e3803d12b7ea05eaf47b3a37592612f0107ed7e6604168d283a09bf3d08b805b415ec90772498062b742814cbf86a8b9ea0f4cc5ff774a77d9671 +SHA512 (libreport-2.11.0.tar.gz) = 6ca2e6d8f9e1c8fc09ab4eabc2cb7277be38eeda7982724e346fe830a67162bf6e49f1d420336df3924ffba70e06a7f92dc2a6e41cdad332603315b5f6684143 From b93f63f5e590a9e7900c8080d6e06c2306536a87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 16 Oct 2019 11:02:05 +0200 Subject: [PATCH 041/133] New upstream release 2.11.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + libreport.spec | 5 ++++- sources | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index adce7e2..bf8161e 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,4 @@ /libreport-2.10.0.tar.gz /libreport-2.10.1.tar.gz /libreport-2.11.0.tar.gz +/libreport-2.11.1.tar.gz diff --git a/libreport.spec b/libreport.spec index 9c72078..d5abe7f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.0 +Version: 2.11.1 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -749,6 +749,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Oct 16 2019 Matěj Grabovský 2.11.1-1 +- gtk: Fix a double-free condition + * Fri Oct 11 2019 Matěj Grabovský 2.11.0-1 - Remove option for emergency analysis/reporting - tests: proc_helpers: Fix call to errx() diff --git a/sources b/sources index c84495f..5694e78 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.0.tar.gz) = 6ca2e6d8f9e1c8fc09ab4eabc2cb7277be38eeda7982724e346fe830a67162bf6e49f1d420336df3924ffba70e06a7f92dc2a6e41cdad332603315b5f6684143 +SHA512 (libreport-2.11.1.tar.gz) = cf9d91dddb769c5b2f196e44d2af5cd96d9713208eaf1627403825ed1ab4e5e4db7c0d496529c72408b1445c279f263e774df6264431f2ae7274062f5975d740 From baf3eb10e5558eed300758dd73036f969df5049b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 23 Oct 2019 13:57:28 +0200 Subject: [PATCH 042/133] New upstream release 2.11.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + libreport.spec | 9 ++++++++- sources | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index bf8161e..299ee3c 100644 --- a/.gitignore +++ b/.gitignore @@ -7,3 +7,4 @@ /libreport-2.10.1.tar.gz /libreport-2.11.0.tar.gz /libreport-2.11.1.tar.gz +/libreport-2.11.2.tar.gz diff --git a/libreport.spec b/libreport.spec index d5abe7f..b905057 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.1 +Version: 2.11.2 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -749,6 +749,13 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Oct 23 2019 Matěj Grabovský 2.11.2-1 +- gtk: Improve memory management +- gtk: Prevent memory leak +- lib: Eliminate GLib inefficiency +- gtk,style: Minor style consistency fixes +- workflows: Correct name of post_report event + * Wed Oct 16 2019 Matěj Grabovský 2.11.1-1 - gtk: Fix a double-free condition diff --git a/sources b/sources index 5694e78..67d70da 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.1.tar.gz) = cf9d91dddb769c5b2f196e44d2af5cd96d9713208eaf1627403825ed1ab4e5e4db7c0d496529c72408b1445c279f263e774df6264431f2ae7274062f5975d740 +SHA512 (libreport-2.11.2.tar.gz) = 26181aab66b2ef28399086553edb0e331e35706b2526ea659699c9f330422a1731125133d68b925010fefbe08502535cffbd1d570c708eaecfebf0451d8492bd From d65da2513b5b736649e3bb83ed7d7eeea83ae446 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Mon, 11 Nov 2019 11:21:51 +0100 Subject: [PATCH 043/133] Add patch to fix a double-free https://github.com/abrt/libreport/commit/36c5e90469b36cb0724f45447ae923a6d6ccf348 Signed-off-by: Ernestas Kulik --- ...gtk-Fix-another-possible-double-free.patch | 38 +++++++++++++++++++ libreport.spec | 7 +++- 2 files changed, 44 insertions(+), 1 deletion(-) create mode 100644 0001-gtk-Fix-another-possible-double-free.patch diff --git a/0001-gtk-Fix-another-possible-double-free.patch b/0001-gtk-Fix-another-possible-double-free.patch new file mode 100644 index 0000000..2bd966d --- /dev/null +++ b/0001-gtk-Fix-another-possible-double-free.patch @@ -0,0 +1,38 @@ +From 36c5e90469b36cb0724f45447ae923a6d6ccf348 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Fri, 25 Oct 2019 12:37:44 +0200 +Subject: [PATCH] gtk: Fix another possible double-free + +The object should only be freed if we're in the cleanup phase, i.e. only +in the if-branch of the condition. + +This one was introduced in dc281652. +--- + src/gui-wizard-gtk/wizard.c | 4 +++- + 1 file changed, 3 insertions(+), 1 deletion(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 4b840bac..ec8bb68b 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -2518,7 +2518,7 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, + while (valid) + { + g_autofree char *text = NULL; +- g_autofree search_item_t *word = NULL; ++ search_item_t *word = NULL; + + gtk_tree_model_get(GTK_TREE_MODEL(g_ls_sensitive_list), &iter, + SEARCH_COLUMN_TEXT, &text, +@@ -2533,6 +2533,8 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, + + if (word == g_current_highlighted_word) + g_current_highlighted_word = NULL; ++ ++ free(word); + } + else + { +-- +2.23.0 + diff --git a/libreport.spec b/libreport.spec index b905057..092e5f3 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.11.2 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -63,6 +63,8 @@ Requires: lz4 BuildRequires: sed %endif +Patch0: 0001-gtk-Fix-another-possible-double-free.patch + %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -749,6 +751,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Nov 11 2019 Ernestas Kulik - 2.11.2-2 +- Add patch to fix a double-free + * Wed Oct 23 2019 Matěj Grabovský 2.11.2-1 - gtk: Improve memory management - gtk: Prevent memory leak From 6bf691a3db7ca894d912e4f4ccde742fab5f0f0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 14 Nov 2019 10:44:05 +0100 Subject: [PATCH 044/133] New upstream release 2.11.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Matěj Grabovský --- .gitignore | 1 + ...gtk-Fix-another-possible-double-free.patch | 38 ------------------- libreport.spec | 21 ++++++++-- sources | 2 +- 4 files changed, 19 insertions(+), 43 deletions(-) delete mode 100644 0001-gtk-Fix-another-possible-double-free.patch diff --git a/.gitignore b/.gitignore index 299ee3c..9ef551f 100644 --- a/.gitignore +++ b/.gitignore @@ -8,3 +8,4 @@ /libreport-2.11.0.tar.gz /libreport-2.11.1.tar.gz /libreport-2.11.2.tar.gz +/libreport-2.11.3.tar.gz diff --git a/0001-gtk-Fix-another-possible-double-free.patch b/0001-gtk-Fix-another-possible-double-free.patch deleted file mode 100644 index 2bd966d..0000000 --- a/0001-gtk-Fix-another-possible-double-free.patch +++ /dev/null @@ -1,38 +0,0 @@ -From 36c5e90469b36cb0724f45447ae923a6d6ccf348 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Fri, 25 Oct 2019 12:37:44 +0200 -Subject: [PATCH] gtk: Fix another possible double-free - -The object should only be freed if we're in the cleanup phase, i.e. only -in the if-branch of the condition. - -This one was introduced in dc281652. ---- - src/gui-wizard-gtk/wizard.c | 4 +++- - 1 file changed, 3 insertions(+), 1 deletion(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index 4b840bac..ec8bb68b 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -2518,7 +2518,7 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, - while (valid) - { - g_autofree char *text = NULL; -- g_autofree search_item_t *word = NULL; -+ search_item_t *word = NULL; - - gtk_tree_model_get(GTK_TREE_MODEL(g_ls_sensitive_list), &iter, - SEARCH_COLUMN_TEXT, &text, -@@ -2533,6 +2533,8 @@ static bool highligh_words_in_textview(int page, GtkTextView *tev, GList *words, - - if (word == g_current_highlighted_word) - g_current_highlighted_word = NULL; -+ -+ free(word); - } - else - { --- -2.23.0 - diff --git a/libreport.spec b/libreport.spec index 092e5f3..1f61a76 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.2 -Release: 2%{?dist} +Version: 2.11.3 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -63,8 +63,6 @@ Requires: lz4 BuildRequires: sed %endif -Patch0: 0001-gtk-Fix-another-possible-double-free.patch - %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -751,6 +749,21 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Nov 14 2019 Matěj Grabovský 2.11.3-1 +- Remove unused scripts +- gtk: Fix infinite loop crashing the reporting +- gtk: Improve logging +- gtk: Remove page number from page struct +- gtk: Code style adjustments +- Make notebook tabs invisible again +- gui-wizard-gtk: Remove expert mode +- gui-wizard-gtk: Stop allowing overriding UI definitions +- pull-trans: Suggest zanata install +- shellcheck: Iterating over ls output is fragile. Use globs. +- shellcheck: Double quote to prevent globbing and word splitting +- zanata: Use python3 zanata client to pull translations +- gtk: Fix another possible double-free + * Mon Nov 11 2019 Ernestas Kulik - 2.11.2-2 - Add patch to fix a double-free diff --git a/sources b/sources index 67d70da..eb99041 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.2.tar.gz) = 26181aab66b2ef28399086553edb0e331e35706b2526ea659699c9f330422a1731125133d68b925010fefbe08502535cffbd1d570c708eaecfebf0451d8492bd +SHA512 (libreport-2.11.3.tar.gz) = 0dc78c77a94ded2d1be646b0f9481765bf10a865ab28f2a226483f8bc5e43fce20f3612332fdc9cee5adb9f8d9c89b59e9d388e9c60425b9ff5f83c9a50132a1 From c3955d78ea40ee7e8fb59f1bcc6104c2063e2ccd Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Wed, 29 Jan 2020 10:13:32 +0000 Subject: [PATCH 045/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 1f61a76..ae04aab 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.11.3 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -749,6 +749,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Jan 29 2020 Fedora Release Engineering - 2.11.3-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild + * Thu Nov 14 2019 Matěj Grabovský 2.11.3-1 - Remove unused scripts - gtk: Fix infinite loop crashing the reporting From 84d394ceb80591dbf5a57e84165cfe6ae9651e20 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Thu, 6 Feb 2020 16:46:24 +0100 Subject: [PATCH 046/133] New upstream release 2.12.0 Signed-off-by: Michal Fabik --- .gitignore | 1 + libreport.spec | 26 +++++++++++++++++--------- sources | 2 +- 3 files changed, 19 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index 9ef551f..634b63b 100644 --- a/.gitignore +++ b/.gitignore @@ -9,3 +9,4 @@ /libreport-2.11.1.tar.gz /libreport-2.11.2.tar.gz /libreport-2.11.3.tar.gz +/libreport-2.12.0.tar.gz diff --git a/libreport.spec b/libreport.spec index ae04aab..2eed2a7 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.11.3 -Release: 2%{?dist} +Version: 2.12.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -36,7 +36,7 @@ BuildRequires: newt-devel BuildRequires: libproxy-devel BuildRequires: satyr-devel >= 0.24 BuildRequires: glib2-devel >= %{glib_ver} -BuildRequires: git +BuildRequires: nettle-devel %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 # A test case uses zh_CN locale to verify XML event translations @@ -57,6 +57,7 @@ Requires: satyr >= 0.24 Requires: glib2 >= %{glib_ver} Requires: xz Requires: lz4 +Requires: nettle # Required for the temporary modularity hack, see below %if 0%{?_module_build} @@ -309,12 +310,7 @@ data over ftp/scp... %endif %prep -# http://www.rpm.org/wiki/PackagerDocs/Autosetup -# Default '__scm_apply_git' is 'git apply && git commit' but this workflow -# doesn't allow us to create a new file within a patch, so we have to use -# 'git am' (see /usr/lib/rpm/macros for more details) -%define __scm_apply_git(qp:m:) %{__git} am -%autosetup -S git +%setup -q %build autoconf @@ -749,6 +745,18 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Feb 06 2020 Michal Fabik 2.12.0-1 +- ureport: Allow printf-like data attaching +- plugins: reporter-rhtsupport: Avoid runtime warning +- Update translations +- lib: Don't include Nettle in a public interface +- ureport: Drop HTTP header table +- glib_support: Use g_strsplit +- glib_support: Drop type initialization +- client-python: Drop yumdebuginfo +- lib: Use Nettle for computing SHA-1 digests +- Move augeas lenses to new subdirectory + * Wed Jan 29 2020 Fedora Release Engineering - 2.11.3-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild diff --git a/sources b/sources index eb99041..7a7c9a0 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.11.3.tar.gz) = 0dc78c77a94ded2d1be646b0f9481765bf10a865ab28f2a226483f8bc5e43fce20f3612332fdc9cee5adb9f8d9c89b59e9d388e9c60425b9ff5f83c9a50132a1 +SHA512 (libreport-2.12.0.tar.gz) = e79163db3807c695aba636474441502c5d4f8c38bb6582d133179c324bc66451b89c2d9c7b60d5686bd85db64e6d6193815b07f0a364c23d98f8d1594a5e658f From 55c465af0578cb7737359c3fd4d6b0683f3fec9b Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Fri, 7 Feb 2020 09:12:07 +0100 Subject: [PATCH 047/133] Bump release for rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 2eed2a7..2e750cc 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.12.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -745,6 +745,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Feb 07 2020 Ernestas Kulik - 2.12.0-2 +- Bump release for side tag rebuild + * Thu Feb 06 2020 Michal Fabik 2.12.0-1 - ureport: Allow printf-like data attaching - plugins: reporter-rhtsupport: Avoid runtime warning From 8c80901c1e4a211608b979d2e5121a910937a06e Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Fri, 20 Mar 2020 19:15:11 +0100 Subject: [PATCH 048/133] Add patch for #1815544 --- ...i-wizard-gtk-Wrap-event-log-messages.patch | 32 ++ libreport.spec | 310 +----------------- 2 files changed, 40 insertions(+), 302 deletions(-) create mode 100644 0001-gui-wizard-gtk-Wrap-event-log-messages.patch diff --git a/0001-gui-wizard-gtk-Wrap-event-log-messages.patch b/0001-gui-wizard-gtk-Wrap-event-log-messages.patch new file mode 100644 index 0000000..eda89e9 --- /dev/null +++ b/0001-gui-wizard-gtk-Wrap-event-log-messages.patch @@ -0,0 +1,32 @@ +From 1f14c9fa96937e589354589665eb8c64d6d16d80 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Fri, 20 Mar 2020 18:04:19 +0100 +Subject: [PATCH] gui-wizard-gtk: Wrap event log messages + +Currently, large logs received by abrt-retrace-client may cause +X/Wayland protocol errors due to an overly large buffer being allocated +for GtkTextView. Enabling word wrapping and eliminating horizontal +scrolling seems to prevent that from happening. + +Cf. https://gitlab.gnome.org/GNOME/gtk/issues/1143 + +https://bugzilla.redhat.com/show_bug.cgi?id=1815544 +--- + src/gui-wizard-gtk/wizard.glade | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/src/gui-wizard-gtk/wizard.glade b/src/gui-wizard-gtk/wizard.glade +index e86fc90b..f7782ba2 100644 +--- a/src/gui-wizard-gtk/wizard.glade ++++ b/src/gui-wizard-gtk/wizard.glade +@@ -705,6 +705,7 @@ + True + True + False ++ word + + + +-- +2.25.1 + diff --git a/libreport.spec b/libreport.spec index 2e750cc..c630e35 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,10 +15,12 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.12.0 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0001: 0001-gui-wizard-gtk-Wrap-event-log-messages.patch + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -37,6 +39,7 @@ BuildRequires: libproxy-devel BuildRequires: satyr-devel >= 0.24 BuildRequires: glib2-devel >= %{glib_ver} BuildRequires: nettle-devel +BuildRequires: git-core %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 # A test case uses zh_CN locale to verify XML event translations @@ -310,7 +313,7 @@ data over ftp/scp... %endif %prep -%setup -q +%autosetup -S git %build autoconf @@ -745,6 +748,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Mar 20 2020 Ernestas Kulik - 2.12.0-3 +- Add patch for https://bugzilla.redhat.com/show_bug.cgi?id=1815544 + * Fri Feb 07 2020 Ernestas Kulik - 2.12.0-2 - Bump release for side tag rebuild @@ -852,303 +858,3 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : - Update to 2.10.0 - Bump GLib dependency - Add patch to work around issue with test - -* Fri Feb 01 2019 Fedora Release Engineering - 2.9.7-3 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild - -* Mon Jan 07 2019 Martin Kutlak 2.9.7-2 -- rhbz: Replace nomail flag with minor_update - -* Fri Dec 07 2018 Matej Marusak 2.9.7-1 -- reportclient: Search for required packages recursively -- event_config: Modify unusable backtrace message -- reportclient: Find and download required debuginfo packages -- lib: Explicitly do not use DST -- autogen: List make in sysdeps command -- lib: Seek beginning of mountinfo file -- report-client: Find debuginfos in own method -- lib: Add a null guard -- gui-wizard-gtk: Require GTK+ 3.10 -- gui-wizard-gtk: Don’t set GtkButton:xalign -- gui-wizard-gtk: Replace use of GtkTable -- gui-wizard-gtk: Show warnings inline on progress page -- gui-wizard-gtk: Remove unused size group -- gui-wizard-gtk: Replace Gtk{H,V}Box with GtkBox -- gui-wizard-gtk: Remove unneeded windows -- gtk-helpers: config_dialog: Hide tree view header -- augeas: Use generic augeas modules - -* Mon Oct 8 2018 Martin Kutlak 2.9.6-1 -- Fix majority of bugs found by Coverity Scan. -- Remove option to screencast problems -- tests: Adjust format of truncated backtrace for python and core -- gui: Replace deprecated g_type_class_add_private -- potfiles: fix issue in POTFILES.in -- lib: fix a SEGV in list_possible_events() -- ureport: use python3 to get consumerCertDir -- r-mailx: Add comment explaining expected values in config -- reporter-mailx: Remove double quotes from config -- spec: Make libreport-filesystem subpackage noarch -- spec: drop dependency on python-rhsm - -* Fri Jul 13 2018 Fedora Release Engineering - 2.9.5-4 -- Rebuilt for https://fedoraproject.org/wiki/Fedora_29_Mass_Rebuild - -* Mon Jun 18 2018 Matej Habrnal 2.9.5-3 -- Make this build without /usr/bin/python -- Resolves #1592073 - -* Sat Jun 16 2018 Miro Hrončok - 2.9.5-2 -- Rebuilt for Python 3.7 - -* Tue Apr 24 2018 Matej Habrnal 2.9.5-1 -- spec: actualize according to downstream -- spec: Conditionalize the Python2 and Python3 -- report-python: fix tests if configure --without-python2 -- autogen: correctly parse buildrequires from spec file - -* Tue Mar 27 2018 Martin Kutlak 2.9.4-1 -- Translation updates -- Revert "use /usr/sbin/" -- ureport: remove json-c is_error() usage -- ldconfig and gtk-update-icon-cache is not needed in rawhide -- reporter-rhtsupport: Remove dependency on redhat-access-insights -- do not expand macro in changelog -- move defattr which match the defaults -- use /usr/sbin/ -- macro python_sitearch is always defined on rhel7+ -- remove rhel6 specific items and accomodate to rhel7+ -- This package uses names with ambiguous `python-` prefix in requirements. -- reporter-{bugzilla,mantisbt,rhtsupport}: fix free -- reporter-mailx: rely on configured email -- spec: fix unowned directories -- augeas: include local config path -- doc: update to contain newly added user's local config -- reporter-mantisbt: read configuration from user's home -- reporter-rhtsupport: read configuration from user's home -- reporter-bugzilla: read configuration from user's home -- reporter-bugzilla: ask concrete bz when requiring login -- makefile: fix make release - -* Thu Nov 02 2017 Julius Milan 2.9.3-1 -- Translation updates -- commit to delete -- workflows: fix description in workflow_RHELJavaScript.xml.in -- workflows: add workflow for adding data to existing case -- client-python,report-python: Allow python to be optional at build time -- ignored words: add SYSTEMD_NSS_BYPASS_BUS -- reporter-ureport: add 'ProcessUnpackaged' option -- spec: add workflow for adding data to existing case -- rep-sys-journal: fix in finding executable basename -- remove old obsolete -- Group is not used any more -- remove old changelogs -- requires pythonX-dnf instead of dnf -- doc: fix obsolete doxygen tags & complains -- lib: Introduce pid_for_children element from ns -- client-python: Do not try to unlink None -- spec: rename Python binary packages - -* Thu Mar 16 2017 Matej Habrnal 2.9.1-1 -- build: create tarball in release-* target -- problem_data: fix double const -- wizard: fix error found by -Werror=format-security -- run_event: fix cmp between pointer and zero character -- build: do not upload tarball to fedorahosted.org -- spec: do not use fedorahosted.org as source -- build: fix generating list of dependences in autogen.sh -- build: generate new release entries with date -- report-newt: free allocated variables, don't close dd twice -- build: fix scratch-build target -- changelog: reflect the PR -- lib: several bug fixes in parsing of mountinfo -- lib: correctly recognize chroot in container -- lib: declare CONTAINER_ROOTS element name -- lib: add more log wrappers for perror -- reporter-bugzilla: use /etc/os-release for default url -- configure.ac: Remove nss dependency -- spec: include testsuite headers in the devel package -- tests: include testsuite.h in the dist archive -- maint: check pulled .po files for errors -- build: fix bug in changelog generating in release target -- changelog: fix typos - -* Fri Dec 02 2016 Jakub Filak 2.9.0-1 -- Translation updates -- build: make the release-* targets smarter -- add CHANGELOG.md -- reporter-s-journal: enable SYSLOG_IDENTIFIER from env -- report-python: add method run_event_on_problem_dir -- lib: use lz4 instead of lz4cat -- reportclient: honor ABRT_VERBOSE -- tree-wide: introduce 'stop_on_not_reportable' option -- client: add support for $releasever to debuginfo -- lib: correct test for own root -- workflows: run analyze_BodhiUpdates event on Fedora -- man: fix formating -- reporter-systemd-journal: introduce reporter-systemd-journal -- problem_data: add function which returns all problem data keys -- include: add exception_type element constant -- spec: changes related to reporter-systemd-journal -- problem_report: add normalization of crashed thread -- problem_report: make generate report configurable -- problem_report: use core_backtrace if there is no backtrace -- lib: refuse to parse negative number as unsigned int -- spec: simplify and remove old conditional -- build: add gettext-devel to sysdeps -- dd: add check for validity of new file FD -- build: configure tree for debugging by default -- spec: use %%buildroot macro -- spec: remove defattr which match the defaults -- spec: do not clean buildroot -- spec: remove Groups -- spec: code cleanup -- lib: fix a bug in dealing with errno -- lib: add convenient wrappers for uint in map_string_t -- problem_report: ensure C-string null terminator -- lib: fix invalid cgroup namespace ID -- lib: make die function configurable -- lib: allow using FD of /proc/[pid] instead of pid_t -- dd: add functions for opening dd item -- lib: add xfdopen -- problem data: search for sensitive words in more files -- dd: add dd_copy_file_at -- ignored words: add "systemd-logind" and "hawkey" -- build: reset the default version with each release -- doc: make README more verbose -- tree-wide: produce less messages in NOTICE log lvl -- ureport: less confusing logging -- spec: install JavaScript workflows -- workflow: add JavaScript workflows -- bugzilla: stop including package details - -* Fri Sep 09 2016 Jakub Filak 2.8.0-1 -- lib: fix a memory leak in create_dump_dir fn -- rhtsupport: fix a double free of config at exit -- autogen: fix typo in usage help string -- debuginfo: dnf API logging workarounds list -- lib: don't warn when user word file doesn't exist -- testuite: add test for forbidden_words -- lib: be able to define base conf dir at runtime -- wizard: use dnf instead of yum in add a screencast note -- problem_report: document resevered elements - -* Mon Jul 18 2016 Matej Habrnal 2.7.2-1 -- Translation updates -- wizard: do not create reproducible if complex_detail == no -- include: save_user_settings function declaration isn’t a prototype -- Bugzilla: fix typo in comment don -> don't -- client-python: fix a typo in error check -- dd: do not log missing uid file when creating new dump dir -- build: update searched pkg names for systemd - -* Wed May 18 2016 Matej Habrnal 2.7.1-1 -- spec: compression updates -- lib: add lz4 decompression -- lib: avoid the need to link against lzma -- all: format security -- lib: add cgroup namespace -- dd: introduce functions getting occurrence stamps -- dd: introduce dd_get_env_variable -- lib: add get env variable from a file -- RHTSupport: include count in Support cases -- lib: problem report API check fseek return code -- ignored words: remove 'kwallet_jwakely' which I added wrongly - -* Fri Apr 08 2016 Matej Habrnal 2.7.0-1 -- ignored words: update ignored words -- mailx: introduce debug parameter -D -- mailx: mail formatting: add comment right after %%oneline -- mailx: use problem report api to define an emais' content -- lib: remove unused function make_description_bz -- augeas: trim spaces before key value -- Revert "xml parser: be more verbose in case xml file cannot be opened" -- xml parser: be more verbose in case xml file cannot be opened -- spec: add workflows.d to filesystem package -- makefile: define LANG in release target -- mailx: stop creating dead.letter on mailx failures -- workflows: add comments to ambiguous functions -- workflows: NULL for the default configuration dir -- workflows: publish the function loading configuration -- build: fix build on Fedora24 -- augeas: exclude mantisbt format configurations -- reporter-mantisbt: add missing '=' to conf file -- curl: fix typo Ingoring -> Ignoring -- rhtsupport: attach all dump dir's element to a new case -- rhtsupport: add pkg_vendor, reproducer and reproducible to description -- report client: add silent mode to clean_up() -- doc: add documentation for requires-details attribute -- rhtsupport: Discourage users from reporting in non Red Hat stuff -- rhtsupport: Discourage users from opening one-shot crashes -- report-gtk: Require Reproducer for RHTSupport -- Add workflow for RHEL anonymous report -- spec: add workflow for RHEL anonymous report files -- wizard: fix the broken widget expansion -- dd: add documentation of dd_create_skeleton -- workflow: add extern C to the header file -- Fix minor typos -- Translation updates -- translations: update zanata configuration -- wizard: fix the broken "Show log" widget -- wizard: remove the code correcting Bugzilla groups - -* Tue Feb 02 2016 Matej Habrnal 2.6.4-1 -- doc: add option -o and -O into reporter-ureport man page -- rhtsupport: use problme report API to create description -- bugzilla: make the event configurable -- report-gtk: offer users to create private ticket -- bugzilla|centos: declare 'restricted access' support -- event config: add support for 'restricted access' -- lib: move CREATE_PRIVATE_TICKET to the global configuration -- dd: dd_delete_item does not die -- dd: add function getting stat of item -- dd: correct handling of TYPE when creating dump directory -- dd: add function computing dump dir file system size -- dd: add function counting number of dd items -- dd: add function copying file descriptor to element -- dd: allow 1 and 2 letter long element names -- problem_data: factor out function reading single problem element -- formatdup: more universal comment -- dd: make function uid_in_group() public -- Refactoring conditional directives that break parts of statements. -- bugzilla: actualize man pages -- bugzilla: don't report private problem as comment -- uploader: move username and password to the advanced options -- uploader: allow empty username and password -- spec: add uploader config files and related man page -- uploader: add possibility to set SSH keyfiles -- curl: add possibility to configure SSH keys -- desktop-utils: deal with Destkop files without command line -- ureport: enable attaching of arbitrary values -- update .gitignore -- uploader: save remote name in reported_to -- curl: return URLs without userinfo -- lib: add function for removing userinfo from URIs -- plugins: port reporters to add_reported_to_entry -- reported_to: add a function formatting reported_to lines -- lib: introduce parser of ISO date strings -- uploader: use shared dd_create_archive function -- dd: add a function for compressing dumpdirs -- problem_report: add examples to the documentation -- client: document environment variables - -* Thu Oct 15 2015 Matej Habrnal 2.6.3-1 -- wizard: correct comments in save_text_if_changed() -- events: improve example -- reporter-bugzilla: add parameter -p -- wizard: fix save users changes after reviewing dump dir files -- dd: make function load_text_file non-static -- bugzilla: don't attach build_ids -- run_event: rewrite event rule parser -- dd: add convenience wrappers fro loading numbers -- ureport: improve curl's error messages -- ureport: use Red Hat Certificate Authority to make rhsm cert trusted -- curl: add posibility to use own Certificate Authority cert -- spec: add redhat-access-insights to Requires of l-p-rhtsupport -- bugzilla: put VARIANT_ID= to Whiteboard -- autogen: use dnf instead of yum to install dependencies -- configure: use hex value for dump dir mode -- curl: add a helper for HTTP GET -- dd: don't warn about missing 'type' if the locking fails -- dd: stop warning about corrupted mandatory files -- Use a dgettext function returning strings instead of bytes From a482043152eefa4e328c670395b67a0e595e3fa5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= Date: Tue, 21 Apr 2020 21:43:19 +0200 Subject: [PATCH 049/133] Rebuild (json-c) --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index c630e35..1d7f2d9 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.12.0 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -748,6 +748,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Apr 21 2020 Björn Esser - 2.12.0-4 +- Rebuild (json-c) + * Fri Mar 20 2020 Ernestas Kulik - 2.12.0-3 - Add patch for https://bugzilla.redhat.com/show_bug.cgi?id=1815544 From e66b28d0aa0314fdf02c7ffed44d8595bc1deac6 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Fri, 24 Apr 2020 15:57:05 +0200 Subject: [PATCH 050/133] New upstream release 2.13.0 Signed-off-by: Michal Fabik --- .gitignore | 1 + ...i-wizard-gtk-Wrap-event-log-messages.patch | 32 ------------------- libreport.spec | 8 ++--- sources | 2 +- 4 files changed, 4 insertions(+), 39 deletions(-) delete mode 100644 0001-gui-wizard-gtk-Wrap-event-log-messages.patch diff --git a/.gitignore b/.gitignore index 634b63b..7b7863d 100644 --- a/.gitignore +++ b/.gitignore @@ -10,3 +10,4 @@ /libreport-2.11.2.tar.gz /libreport-2.11.3.tar.gz /libreport-2.12.0.tar.gz +/libreport-2.13.0.tar.gz diff --git a/0001-gui-wizard-gtk-Wrap-event-log-messages.patch b/0001-gui-wizard-gtk-Wrap-event-log-messages.patch deleted file mode 100644 index eda89e9..0000000 --- a/0001-gui-wizard-gtk-Wrap-event-log-messages.patch +++ /dev/null @@ -1,32 +0,0 @@ -From 1f14c9fa96937e589354589665eb8c64d6d16d80 Mon Sep 17 00:00:00 2001 -From: Ernestas Kulik -Date: Fri, 20 Mar 2020 18:04:19 +0100 -Subject: [PATCH] gui-wizard-gtk: Wrap event log messages - -Currently, large logs received by abrt-retrace-client may cause -X/Wayland protocol errors due to an overly large buffer being allocated -for GtkTextView. Enabling word wrapping and eliminating horizontal -scrolling seems to prevent that from happening. - -Cf. https://gitlab.gnome.org/GNOME/gtk/issues/1143 - -https://bugzilla.redhat.com/show_bug.cgi?id=1815544 ---- - src/gui-wizard-gtk/wizard.glade | 1 + - 1 file changed, 1 insertion(+) - -diff --git a/src/gui-wizard-gtk/wizard.glade b/src/gui-wizard-gtk/wizard.glade -index e86fc90b..f7782ba2 100644 ---- a/src/gui-wizard-gtk/wizard.glade -+++ b/src/gui-wizard-gtk/wizard.glade -@@ -705,6 +705,7 @@ - True - True - False -+ word - - - --- -2.25.1 - diff --git a/libreport.spec b/libreport.spec index 1d7f2d9..9da3f8b 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,12 +14,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.12.0 -Release: 4%{?dist} +Version: 2.13.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0001: 0001-gui-wizard-gtk-Wrap-event-log-messages.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -449,7 +448,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/%{name}/ignored_words.conf %{_datadir}/%{name}/conf.d/libreport.conf %{_libdir}/libreport.so.* -%{_libdir}/libabrt_dbus.so.* %{_mandir}/man5/libreport.conf.5* %{_mandir}/man5/report_event.conf.5* %{_mandir}/man5/forbidden_words.conf.5* @@ -491,12 +489,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_includedir}/libreport/reporters.h %{_includedir}/libreport/global_configuration.h # Private api headers: -%{_includedir}/libreport/internal_abrt_dbus.h %{_includedir}/libreport/internal_libreport.h %{_includedir}/libreport/xml_parser.h %{_includedir}/libreport/helpers %{_libdir}/libreport.so -%{_libdir}/libabrt_dbus.so %{_libdir}/pkgconfig/libreport.pc %dir %{_includedir}/libreport diff --git a/sources b/sources index 7a7c9a0..abe8c88 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.12.0.tar.gz) = e79163db3807c695aba636474441502c5d4f8c38bb6582d133179c324bc66451b89c2d9c7b60d5686bd85db64e6d6193815b07f0a364c23d98f8d1594a5e658f +SHA512 (libreport-2.13.0.tar.gz) = 9be3016770304ed3679bc4a7321425628cc5fc1d2927e1a36cbf9d0a743562f1b47c88e511537221276e0d1e04feaeb38de642a862dd8ca63ce7749db73a6f49 From 0ba66a3414ee2caff62cfd4c1c536df038aa5526 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Fri, 24 Apr 2020 16:42:54 +0200 Subject: [PATCH 051/133] Update changelog, bump release to 2.13.0-2 Signed-off-by: Michal Fabik --- libreport.spec | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 9da3f8b..c7c4d1e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.13.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -744,6 +744,15 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Apr 24 2020 Michal Fabik 2.13.0-2 +- Support new "time" and "time_for_children" kernel namespaces +- Remove preprocessor namespacing in favor of function name prefixes +- client-python: Accomodate for multiple debug directories +- gui-wizard-gtk: Wrap event log messages +- lib: Drop D-Bus code +- plugins: reporter-rhtsupport: Drop unused debugging code +- Update translations + * Tue Apr 21 2020 Björn Esser - 2.12.0-4 - Rebuild (json-c) From e77ad01ea9d4be1f01e4a297b5e3538baab619a2 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Mon, 11 May 2020 21:59:46 +0200 Subject: [PATCH 052/133] New upstream release 2.13.1 Signed-off-by: Michal Fabik --- .gitignore | 1 + libreport.spec | 13 ++++++++----- sources | 2 +- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 7b7863d..ebda8c9 100644 --- a/.gitignore +++ b/.gitignore @@ -11,3 +11,4 @@ /libreport-2.11.3.tar.gz /libreport-2.12.0.tar.gz /libreport-2.13.0.tar.gz +/libreport-2.13.1.tar.gz diff --git a/libreport.spec b/libreport.spec index c7c4d1e..30dfedd 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.13.0 -Release: 2%{?dist} +Version: 2.13.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -317,7 +317,7 @@ data over ftp/scp... %build autoconf -CFLAGS="%{optflags} -Werror" %configure \ +%configure \ %if %{without bugzilla} --without-bugzilla \ %endif @@ -327,10 +327,10 @@ CFLAGS="%{optflags} -Werror" %configure \ --enable-doxygen-docs \ --disable-silent-rules -make %{?_smp_mflags} +%make_build %install -make install DESTDIR=%{buildroot} \ +%make_install \ %if %{with python3} PYTHON=%{__python3} \ %endif # with python3 @@ -744,6 +744,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon May 11 2020 Michal Fabik 2.13.1-1 +- Fix broken abrt-vmcore.service due to bad namespacing + * Fri Apr 24 2020 Michal Fabik 2.13.0-2 - Support new "time" and "time_for_children" kernel namespaces - Remove preprocessor namespacing in favor of function name prefixes diff --git a/sources b/sources index abe8c88..36fbd1b 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.13.0.tar.gz) = 9be3016770304ed3679bc4a7321425628cc5fc1d2927e1a36cbf9d0a743562f1b47c88e511537221276e0d1e04feaeb38de642a862dd8ca63ce7749db73a6f49 +SHA512 (libreport-2.13.1.tar.gz) = fc3db46ee6885053387b86e682f9ed1908d050149a5d820b40444b7db413af89afdcd6abef780179c5ca968ea036f3ae245884414b94d426547e58a89b8bbb65 From 79fc4e45b35e41d6ed4eee56844f5609d5214951 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Sun, 24 May 2020 07:50:51 +0200 Subject: [PATCH 053/133] Rebuilt for Python 3.9 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 30dfedd..8119caf 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.13.1 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -744,6 +744,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun May 24 2020 Miro Hrončok - 2.13.1-2 +- Rebuilt for Python 3.9 + * Mon May 11 2020 Michal Fabik 2.13.1-1 - Fix broken abrt-vmcore.service due to bad namespacing From 6d705a2dafd4db671070c01e893f1cc110344c89 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Tue, 28 Jul 2020 05:28:38 +0000 Subject: [PATCH 054/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 8119caf..1da7c1b 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.13.1 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -744,6 +744,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Jul 28 2020 Fedora Release Engineering - 2.13.1-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild + * Sun May 24 2020 Miro Hrončok - 2.13.1-2 - Rebuilt for Python 3.9 From 1fa21e6ed9c9c25094723cda2760dbc2b4e168e4 Mon Sep 17 00:00:00 2001 From: Peter Robinson Date: Fri, 7 Aug 2020 17:23:43 +0100 Subject: [PATCH 055/133] Bump to fix upgrade path --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 1da7c1b..4c4c9a8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.13.1 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -744,6 +744,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Aug 07 2020 Peter Robinson - 2.13.1-4 +- Bump to fix upgrade path + * Tue Jul 28 2020 Fedora Release Engineering - 2.13.1-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild From 246d3174118e03cbb345f1d434f3fbe11864b015 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Thu, 13 Aug 2020 15:59:56 +0200 Subject: [PATCH 056/133] New upstream release 2.14.0 Signed-off-by: Michal Fabik --- .gitignore | 1 + libreport.spec | 129 +++++++++---------------------------------------- sources | 2 +- 3 files changed, 24 insertions(+), 108 deletions(-) diff --git a/.gitignore b/.gitignore index ebda8c9..23c2ea8 100644 --- a/.gitignore +++ b/.gitignore @@ -12,3 +12,4 @@ /libreport-2.12.0.tar.gz /libreport-2.13.0.tar.gz /libreport-2.13.1.tar.gz +/libreport-2.14.0.tar.gz diff --git a/libreport.spec b/libreport.spec index 4c4c9a8..a4b72ee 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,30 +14,30 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.13.1 -Release: 4%{?dist} +Version: 2.14.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz BuildRequires: %{dbus_devel} -BuildRequires: gtk3-devel -BuildRequires: curl-devel +BuildRequires: gtk3-devel%{?_isa} +BuildRequires: curl-devel%{?_isa} BuildRequires: desktop-file-utils BuildRequires: python3-devel BuildRequires: gettext -BuildRequires: libxml2-devel -BuildRequires: libtar-devel +BuildRequires: libxml2-devel%{?_isa} +BuildRequires: libtar-devel%{?_isa} BuildRequires: intltool BuildRequires: libtool BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto -BuildRequires: newt-devel -BuildRequires: libproxy-devel -BuildRequires: satyr-devel >= 0.24 -BuildRequires: glib2-devel >= %{glib_ver} -BuildRequires: nettle-devel +BuildRequires: newt-devel%{?_isa} +BuildRequires: libproxy-devel%{?_isa} +BuildRequires: satyr-devel%{?_isa} >= 0.24 +BuildRequires: glib2-devel%{?_isa} >= %{glib_ver} +BuildRequires: nettle-devel%{?_isa} BuildRequires: git-core %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 @@ -49,23 +49,25 @@ BuildRequires: glibc-all-langpacks BuildRequires: xmlrpc-c-devel %endif BuildRequires: doxygen -BuildRequires: systemd-devel +BuildRequires: systemd-devel%{?_isa} BuildRequires: augeas-devel BuildRequires: augeas -BuildRequires: xz -BuildRequires: lz4 +BuildRequires: libarchive-devel%{?_isa} Requires: libreport-filesystem = %{version}-%{release} -Requires: satyr >= 0.24 -Requires: glib2 >= %{glib_ver} -Requires: xz -Requires: lz4 -Requires: nettle +Requires: satyr%{?_isa} >= 0.24 +Requires: glib2%{?_isa} >= %{glib_ver} +Requires: libarchive%{?_isa} +Requires: nettle%{?_isa} # Required for the temporary modularity hack, see below %if 0%{?_module_build} BuildRequires: sed %endif +Obsoletes: %{name}-compat < 2.13.2 +Obsoletes: %{name}-plugin-rhtsupport < 2.13.2 +Obsoletes: %{name}-rhel < 2.13.2 + %description Libraries providing API for reporting different problems in applications to different bug targets like Bugzilla, ftp, trac, etc... @@ -224,25 +226,6 @@ Requires: python3-subscription-manager-rhsm %description plugin-ureport Uploads micro-report to abrt server -%package plugin-rhtsupport -Summary: %{name}'s RHTSupport plugin -Requires: %{name} = %{version}-%{release} -Requires: libreport-web = %{version}-%{release} - -%description plugin-rhtsupport -Plugin to report bugs into RH support system. - -%if %{with bugzilla} -%package compat -Summary: %{name}'s compat layer for obsoleted 'report' package -Requires: libreport = %{version}-%{release} -Requires: %{name}-plugin-bugzilla = %{version}-%{release} -Requires: %{name}-plugin-rhtsupport = %{version}-%{release} - -%description compat -Provides 'report' command-line tool. -%endif - %package plugin-reportuploader Summary: %{name}'s reportuploader plugin Requires: %{name} = %{version}-%{release} @@ -263,16 +246,6 @@ install this package and you're done. %endif %if 0%{?rhel} -%package rhel -Summary: Default configuration for reporting bugs via Red Hat infrastructure -Requires: %{name} = %{version}-%{release} -Requires: %{name}-plugin-ureport - -%description rhel -Default configuration for reporting bugs via Red Hat infrastructure -used to easily configure the reporting process for Red Hat systems. Just -install this package and you're done. - %package rhel-bugzilla Summary: Default configuration for reporting bugs to Red Hat Bugzilla Requires: %{name} = %{version}-%{release} @@ -300,9 +273,7 @@ package and you're done. Summary: Default configuration for reporting anaconda bugs Requires: %{name} = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -%if 0%{?rhel} -Requires: libreport-plugin-rhtsupport = %{version}-%{release} -%else +%if ! 0%{?rhel} Requires: libreport-plugin-bugzilla = %{version}-%{release} %endif @@ -320,9 +291,6 @@ autoconf %configure \ %if %{without bugzilla} --without-bugzilla \ -%endif -%if 0%{?rhel} - --enable-import-rhtsupport-cert \ %endif --enable-doxygen-docs \ --disable-silent-rules @@ -375,16 +343,7 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaFedora.xml # Remove unwanted RHEL specific workflow configuration files %if 0%{!?rhel:1} -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELCCpp.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELKerneloops.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELPython.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELvmcore.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELxorg.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELLibreport.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELJava.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELJavaScript.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_uReport.xml -rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaRHEL.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaRHELBugzilla.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaCCpp.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaKerneloops.xml @@ -402,11 +361,8 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataxorg.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataLibreport.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataJava.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELAddDataJavaScript.xml -rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel.conf -rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_uReport.conf rm -f %{buildroot}/%{_sysconfdir}/libreport/workflows.d/report_rhel_bugzilla.conf -rm -f %{buildroot}%{_mandir}/man5/report_rhel.conf.5 rm -f %{buildroot}%{_mandir}/man5/report_uReport.conf.5 rm -f %{buildroot}%{_mandir}/man5/report_rhel_bugzilla.conf.5 %endif @@ -635,26 +591,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/events.d/centos_report_event.conf %{_mandir}/man5/centos_report_event.conf.5.gz -%files plugin-rhtsupport -%config(noreplace) %{_sysconfdir}/libreport/plugins/rhtsupport.conf -%{_datadir}/%{name}/conf.d/plugins/rhtsupport.conf -%{_datadir}/%{name}/events/report_RHTSupport.xml -%{_datadir}/%{name}/events/report_RHTSupport_AddData.xml -%if 0%{?rhel} -%attr(600,root,root)%{_sysconfdir}/%{name}/cert-api.access.redhat.com.pem -%endif -%config(noreplace) %{_sysconfdir}/libreport/events.d/rhtsupport_event.conf -%{_mandir}/man1/reporter-rhtsupport.1.gz -%{_mandir}/man5/rhtsupport.conf.5.* -%{_mandir}/man5/rhtsupport_event.conf.5.* -%{_bindir}/reporter-rhtsupport - -%if %{with bugzilla} -%files compat -%{_bindir}/report -%{_mandir}/man1/report.1.gz -%endif - %files plugin-reportuploader %{_mandir}/man*/reporter-upload.* %{_mandir}/man5/uploader_event.conf.5.* @@ -687,27 +623,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %if 0%{?rhel} -%files rhel -%{_datadir}/%{name}/workflows/workflow_RHELCCpp.xml -%{_datadir}/%{name}/workflows/workflow_RHELKerneloops.xml -%{_datadir}/%{name}/workflows/workflow_RHELPython.xml -%{_datadir}/%{name}/workflows/workflow_RHELvmcore.xml -%{_datadir}/%{name}/workflows/workflow_RHELxorg.xml -%{_datadir}/%{name}/workflows/workflow_RHELLibreport.xml -%{_datadir}/%{name}/workflows/workflow_RHELJava.xml -%{_datadir}/%{name}/workflows/workflow_RHELJavaScript.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataCCpp.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataJava.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataKerneloops.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataLibreport.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataPython.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDatavmcore.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataxorg.xml -%{_datadir}/%{name}/workflows/workflow_RHELAddDataJavaScript.xml -%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel.conf -%config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_rhel_add_data.conf -%{_mandir}/man5/report_rhel.conf.5.* - %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml %{_datadir}/%{name}/workflows/workflow_RHELBugzillaKerneloops.xml diff --git a/sources b/sources index 36fbd1b..38afa93 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.13.1.tar.gz) = fc3db46ee6885053387b86e682f9ed1908d050149a5d820b40444b7db413af89afdcd6abef780179c5ca968ea036f3ae245884414b94d426547e58a89b8bbb65 +SHA512 (libreport-2.14.0.tar.gz) = aa56b994c97b07596a7022d156ffaa7733aa9db94b743ffeb031810f5aaae4f0ebfa62d9d66dff60f224e91ddfd2794278830d6ceab5ab2582e055ade329eee4 From 05f31ca481faa17c65687a94d923916c4f15b362 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Thu, 13 Aug 2020 17:54:48 +0200 Subject: [PATCH 057/133] Add changelog to spec Signed-off-by: Michal Fabik --- libreport.spec | 22 +++++++++++++++++++++- 1 file changed, 21 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index a4b72ee..0729e4c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -659,6 +659,26 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Aug 13 2020 Michal Fabik 2.13.1-2 +- forbidden_words: Add potentially sensitive env vars +- lib: Add version script for libreport +- lib: compress: Use libarchive +- Replace various utility functions with stock GLib ones +- gtk,lib: Update symbol list +- dd: Update dd_get_owner to handle error return values +- dirsize: Don't pick .lock'd dirs for deletion +- setgid instead of setuid the abrt-action-install-debuginfo-to-abrt-cache +- Various coding style improvements +- Various memory management fixes +- lib: Check for errors when opening files +- gtk-helpers: Check return value +- doc: Exclude more files with --without-bugzilla +- lib: Don’t use external executables for decompression +- lib: Decommission libreport_list_free_with_free +- Drop Red Hat Customer Portal reporter +- ureport: Drop Strata integration +- lib: Remove creates-items tag parsing in event definitions + * Fri Aug 07 2020 Peter Robinson - 2.13.1-4 - Bump to fix upgrade path From 0ab817ba2cb8c4d70930b0d22c61b16d58130f24 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Thu, 13 Aug 2020 18:51:31 +0200 Subject: [PATCH 058/133] Fix version in spec changelog Signed-off-by: Michal Fabik --- libreport.spec | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libreport.spec b/libreport.spec index 0729e4c..95d3812 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -659,7 +659,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog -* Thu Aug 13 2020 Michal Fabik 2.13.1-2 +* Thu Aug 13 2020 Michal Fabik 2.14.0-3 - forbidden_words: Add potentially sensitive env vars - lib: Add version script for libreport - lib: compress: Use libarchive From 9356e160f095ae900b3c1125af6e43498c533de1 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Mon, 17 Aug 2020 14:14:51 +0200 Subject: [PATCH 059/133] spec: Drop %{?_isa} from BuildRequires https://github.com/abrt/libreport/issues/661 Signed-off-by: Michal Fabik --- libreport.spec | 24 ++++++++++++------------ sources | 2 +- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/libreport.spec b/libreport.spec index 95d3812..7762fb7 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,29 +15,29 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz BuildRequires: %{dbus_devel} -BuildRequires: gtk3-devel%{?_isa} -BuildRequires: curl-devel%{?_isa} +BuildRequires: gtk3-devel +BuildRequires: curl-devel BuildRequires: desktop-file-utils BuildRequires: python3-devel BuildRequires: gettext -BuildRequires: libxml2-devel%{?_isa} -BuildRequires: libtar-devel%{?_isa} +BuildRequires: libxml2-devel +BuildRequires: libtar-devel BuildRequires: intltool BuildRequires: libtool BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto -BuildRequires: newt-devel%{?_isa} -BuildRequires: libproxy-devel%{?_isa} -BuildRequires: satyr-devel%{?_isa} >= 0.24 -BuildRequires: glib2-devel%{?_isa} >= %{glib_ver} -BuildRequires: nettle-devel%{?_isa} +BuildRequires: newt-devel +BuildRequires: libproxy-devel +BuildRequires: satyr-devel >= 0.24 +BuildRequires: glib2-devel >= %{glib_ver} +BuildRequires: nettle-devel BuildRequires: git-core %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 @@ -49,10 +49,10 @@ BuildRequires: glibc-all-langpacks BuildRequires: xmlrpc-c-devel %endif BuildRequires: doxygen -BuildRequires: systemd-devel%{?_isa} +BuildRequires: systemd-devel BuildRequires: augeas-devel BuildRequires: augeas -BuildRequires: libarchive-devel%{?_isa} +BuildRequires: libarchive-devel Requires: libreport-filesystem = %{version}-%{release} Requires: satyr%{?_isa} >= 0.24 Requires: glib2%{?_isa} >= %{glib_ver} diff --git a/sources b/sources index 38afa93..c9ad10a 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.14.0.tar.gz) = aa56b994c97b07596a7022d156ffaa7733aa9db94b743ffeb031810f5aaae4f0ebfa62d9d66dff60f224e91ddfd2794278830d6ceab5ab2582e055ade329eee4 +SHA512 (libreport-2.14.0.tar.gz) = 6bc428a2d91b22f2df1abc9326c131e91e5e7be78ca64ad6533ff8246fa02df9a975360686811d29fd66210206a4e4ee5dc9faf2c9b23eccab7ca0ec07c3d43c From dffb347d31d797195137791e1a3cd68671e57d91 Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Tue, 18 Aug 2020 16:07:34 +0200 Subject: [PATCH 060/133] Bump release to rebuild in side tag Signed-off-by: Michal Fabik --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 7762fb7..501c18c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 4%{?dist} +Release: 5%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz From 5c189cf957361f26b7143c2b2f31edee11c44c2f Mon Sep 17 00:00:00 2001 From: Merlin Mathesius Date: Wed, 19 Aug 2020 14:21:28 -0500 Subject: [PATCH 061/133] Updates so ELN builds in a Fedora-like reporting configuration, even though the %{rhel} macro is set. Signed-off-by: Merlin Mathesius --- libreport.spec | 28 ++++++++++++++++------------ 1 file changed, 16 insertions(+), 12 deletions(-) diff --git a/libreport.spec b/libreport.spec index 501c18c..80daa52 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -219,7 +219,7 @@ Summary: %{name}'s micro report plugin BuildRequires: %{libjson_devel} Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} Requires: python3-subscription-manager-rhsm %endif @@ -234,7 +234,7 @@ Requires: libreport-web = %{version}-%{release} %description plugin-reportuploader Plugin to report bugs into anonymous FTP site associated with ticketing system. -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?eln} %package fedora Summary: Default configuration for reporting bugs via Fedora infrastructure Requires: %{name} = %{version}-%{release} @@ -245,7 +245,7 @@ used to easily configure the reporting process for Fedora systems. Just install this package and you're done. %endif -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %package rhel-bugzilla Summary: Default configuration for reporting bugs to Red Hat Bugzilla Requires: %{name} = %{version}-%{release} @@ -273,7 +273,7 @@ package and you're done. Summary: Default configuration for reporting anaconda bugs Requires: %{name} = %{version}-%{release} Requires: libreport-plugin-reportuploader = %{version}-%{release} -%if ! 0%{?rhel} +%if ! 0%{?rhel} || 0%{?eln} Requires: libreport-plugin-bugzilla = %{version}-%{release} %endif @@ -326,7 +326,7 @@ mkdir -p %{buildroot}/%{_datadir}/%{name}/workflows/ rm -f %{buildroot}/%{_infodir}/dir # Remove unwanted Fedora specific workflow configuration files -%if 0%{!?fedora:1} +%if ! 0%{?fedora} && ! 0%{?eln} rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_FedoraCCpp.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_FedoraKerneloops.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_FedoraPython.xml @@ -342,7 +342,7 @@ rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaFedora.xml %endif # Remove unwanted RHEL specific workflow configuration files -%if 0%{!?rhel:1} +%if ! 0%{?rhel} || 0%{?eln} rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_uReport.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_AnacondaRHELBugzilla.xml rm -f %{buildroot}/%{_datadir}/libreport/workflows/workflow_RHELBugzillaCCpp.xml @@ -525,7 +525,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man1/reporter-ureport.1.gz %{_mandir}/man5/ureport.conf.5.gz %{_datadir}/%{name}/events/report_uReport.xml -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %config(noreplace) %{_sysconfdir}/libreport/workflows.d/report_uReport.conf %{_datadir}/%{name}/workflows/workflow_uReport.xml %{_mandir}/man5/report_uReport.conf.5.* @@ -607,7 +607,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/libreport/events/report_Uploader.conf %{_mandir}/man5/report_Uploader.conf.5.* -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?eln} %files fedora %{_datadir}/%{name}/workflows/workflow_FedoraCCpp.xml %{_datadir}/%{name}/workflows/workflow_FedoraKerneloops.xml @@ -622,7 +622,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/report_fedora.conf.5.* %endif -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml %{_datadir}/%{name}/workflows/workflow_RHELBugzillaKerneloops.xml @@ -641,10 +641,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %if %{with bugzilla} %files anaconda -%if 0%{?fedora} +%if 0%{?fedora} || 0%{?eln} %{_datadir}/%{name}/workflows/workflow_AnacondaFedora.xml %endif -%if 0%{?rhel} +%if 0%{?rhel} && ! 0%{?eln} %{_datadir}/%{name}/workflows/workflow_AnacondaRHEL.xml %endif %{_datadir}/%{name}/workflows/workflow_AnacondaUpload.xml @@ -659,6 +659,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Aug 19 2020 Merlin Mathesius - 2.14.0-6 +- Updates so ELN builds in a Fedora-like reporting configuration, even though + the %%{rhel} macro is set. + * Thu Aug 13 2020 Michal Fabik 2.14.0-3 - forbidden_words: Add potentially sensitive env vars - lib: Add version script for libreport From dff36197153b0cca5fcab6a69c93a64698c32d8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 25 Sep 2020 19:34:08 +0200 Subject: [PATCH 062/133] Add patch for #1882319 --- ...zard-gtk-Fix-a-double-free-condition.patch | 53 +++++++++++++++++++ libreport.spec | 7 ++- 2 files changed, 59 insertions(+), 1 deletion(-) create mode 100644 0001-gui-wizard-gtk-Fix-a-double-free-condition.patch diff --git a/0001-gui-wizard-gtk-Fix-a-double-free-condition.patch b/0001-gui-wizard-gtk-Fix-a-double-free-condition.patch new file mode 100644 index 0000000..c000d30 --- /dev/null +++ b/0001-gui-wizard-gtk-Fix-a-double-free-condition.patch @@ -0,0 +1,53 @@ +From ce557c0fb309184a9a8fc38a76404324d94803b0 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Fri, 25 Sep 2020 19:23:51 +0200 +Subject: [PATCH] gui-wizard-gtk: Fix a double free condition + +We may only free `log_msg` in `update_command_run_log()` if it is the +result of the call to `g_strdup_printf()`, otherwise the caller takes +care of it. + +Partially reverts 7aba6e53. + +Resolves rhbz#1882319 +--- + src/gui-wizard-gtk/wizard.c | 12 +++++++++--- + 1 file changed, 9 insertions(+), 3 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 8a4486f2..a532c633 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -1385,7 +1385,7 @@ static void cancel_processing(GtkLabel *status_label, const char *message, int t + pango_attr_list_unref(list); + } + +-static void update_command_run_log(const char* message, struct analyze_event_data *evd) ++static void update_command_run_log(char *message, struct analyze_event_data *evd) + { + const bool it_is_a_dot = (message[0] == '.' && message[1] == '\0'); + +@@ -1393,12 +1393,18 @@ static void update_command_run_log(const char* message, struct analyze_event_dat + gtk_label_set_text(g_lbl_event_log, message); + + /* Don't append new line behind single dot */ +- g_autofree const char *log_msg = it_is_a_dot ? message : g_strdup_printf("%s\n", message); ++ char *log_msg = it_is_a_dot ? message : g_strdup_printf("%s\n", message); + append_to_textview(g_tv_event_log, log_msg); + save_to_event_log(evd, log_msg); ++ ++ if (log_msg != message) ++ { ++ /* We assume message is managed by the caller. */ ++ free(log_msg); ++ } + } + +-static void run_event_gtk_error(const char *error_line, void *param) ++static void run_event_gtk_error(char *error_line, void *param) + { + update_command_run_log(error_line, (struct analyze_event_data *)param); + } +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 80daa52..09d48c2 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,11 +15,13 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 6%{?dist} +Release: 7%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0: 0001-gui-wizard-gtk-Fix-a-double-free-condition.patch + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -659,6 +661,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Sep 25 2020 Matěj Grabovský - 2.14.0-7 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882319 + * Wed Aug 19 2020 Merlin Mathesius - 2.14.0-6 - Updates so ELN builds in a Fedora-like reporting configuration, even though the %%{rhel} macro is set. From 87befbd9c86f8d8481ddf4b64d71be3f11285044 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Sun, 27 Sep 2020 20:51:04 +0200 Subject: [PATCH 063/133] Add patch for #1882950 --- ...d-gtk-Fix-a-segfault-and-memory-leak.patch | 66 +++++++++++++++++++ libreport.spec | 6 +- 2 files changed, 71 insertions(+), 1 deletion(-) create mode 100644 0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch diff --git a/0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch b/0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch new file mode 100644 index 0000000..2b38feb --- /dev/null +++ b/0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch @@ -0,0 +1,66 @@ +From cb2ab9a8b2e1dbc89e100aedc432c29a16246e84 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Sun, 27 Sep 2020 20:45:32 +0200 +Subject: [PATCH] gui-wizard-gtk: Fix a segfault and memory leak + +Only `arg[1]` has to be freed in `tv_details_row_activated()`, as +`arg[0]` is allocated statically. + +In `search_item_to_list_store_item()`, `tmp` gets overwritten with a new +value for every call to `gtk_text_buffer_get_text()`, so we need to free +the allocated memory continuously. + +Partially reverts 7aba6e53. + +Resolves rhbz#1882950 +--- + src/gui-wizard-gtk/wizard.c | 9 +++++++-- + 1 file changed, 7 insertions(+), 2 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index a532c633..775b709f 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -707,7 +707,7 @@ static void tv_details_row_activated( + return; + + gint exitcode; +- g_autofree gchar *arg[3]; ++ gchar *arg[3]; + arg[0] = (char *) "xdg-open"; + arg[1] = g_build_filename(g_dump_dir_name ? g_dump_dir_name : "", item_name, NULL); + arg[2] = NULL; +@@ -751,6 +751,8 @@ static void tv_details_row_activated( + gtk_widget_destroy(scrolled); + gtk_widget_destroy(dialog); + } ++ ++ g_free(arg[1]); + } + + /* static gboolean tv_details_select_cursor_row( +@@ -2126,17 +2128,20 @@ static void search_item_to_list_store_item(GtkListStore *store, GtkTreeIter *new + gtk_text_iter_backward_char(end); + } + +- g_autofree gchar *tmp = gtk_text_buffer_get_text(word->buffer, beg, &(word->start), ++ gchar *tmp = gtk_text_buffer_get_text(word->buffer, beg, &(word->start), + /*don't include hidden chars*/FALSE); + g_autofree gchar *prefix = g_markup_escape_text(tmp, /*NULL terminated string*/-1); ++ g_free(tmp); + + tmp = gtk_text_buffer_get_text(word->buffer, &(word->start), &(word->end), + /*don't include hidden chars*/FALSE); + g_autofree gchar *text = g_markup_escape_text(tmp, /*NULL terminated string*/-1); ++ g_free(tmp); + + tmp = gtk_text_buffer_get_text(word->buffer, &(word->end), end, + /*don't include hidden chars*/FALSE); + g_autofree gchar *suffix = g_markup_escape_text(tmp, /*NULL terminated string*/-1); ++ g_clear_pointer(&tmp, g_free); + + char *content = g_strdup_printf("%s%s%s", prefix, text, suffix); + +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 09d48c2..c160ab3 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,12 +15,13 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 7%{?dist} +Release: 8%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz Patch0: 0001-gui-wizard-gtk-Fix-a-double-free-condition.patch +Patch1: 0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -661,6 +662,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Sep 27 2020 Matěj Grabovský - 2.14.0-8 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882950 + * Fri Sep 25 2020 Matěj Grabovský - 2.14.0-7 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882319 From e6ffee77b61fd3fea71387fcf225321a987a1830 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Tue, 1 Sep 2020 08:57:14 +0200 Subject: [PATCH 064/133] Add patches with upstream fixes --- ...ui-wizard-gtk-wizard-Remove-variable.patch | 39 +++++++++++++++ ...d-gtk-wizard-Fix-invalid-memory-read.patch | 49 +++++++++++++++++++ ...zard-gtk-Fix-a-double-free-condition.patch | 0 ...d-gtk-Fix-a-segfault-and-memory-leak.patch | 0 libreport.spec | 11 +++-- 5 files changed, 96 insertions(+), 3 deletions(-) create mode 100644 0001-gui-wizard-gtk-wizard-Remove-variable.patch create mode 100644 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch rename 0001-gui-wizard-gtk-Fix-a-double-free-condition.patch => 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch (100%) rename 0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch => 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch (100%) diff --git a/0001-gui-wizard-gtk-wizard-Remove-variable.patch b/0001-gui-wizard-gtk-wizard-Remove-variable.patch new file mode 100644 index 0000000..9537db0 --- /dev/null +++ b/0001-gui-wizard-gtk-wizard-Remove-variable.patch @@ -0,0 +1,39 @@ +From 1c646a2948d287368ec1a82b444e8175ebfbf5b9 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Tue, 25 Aug 2020 15:05:31 +0300 +Subject: [PATCH] gui-wizard-gtk: wizard: Remove variable + +cmd_output is no longer used since +440bcfa8526d50f122ec14e19f2bf2aa336f61e7 and trying to call +g_string_free() on it results in a critical warning. +--- + src/gui-wizard-gtk/wizard.c | 6 ------ + 1 file changed, 6 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 44900448..a4d7caa0 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -231,8 +231,6 @@ typedef struct + + static page_obj_t pages[NUM_PAGES]; + +-static GString *cmd_output = NULL; +- + /* Utility functions */ + + static void clear_warnings(void); +@@ -1667,10 +1665,6 @@ static gboolean consume_cmd_output(GIOChannel *source, GIOCondition condition, g + log_notice("done running event on '%s': %d", g_dump_dir_name, retval); + append_to_textview(g_tv_event_log, "\n"); + +- /* Free child output buffer */ +- g_string_free(cmd_output, TRUE); +- cmd_output = NULL; +- + /* Hide spinner and stop btn */ + gtk_widget_hide(GTK_WIDGET(g_spinner_event_log)); + gtk_widget_hide(g_btn_stop); +-- +2.28.0 + diff --git a/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch b/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch new file mode 100644 index 0000000..ed46b09 --- /dev/null +++ b/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch @@ -0,0 +1,49 @@ +From 85b687098bcedb67285ab787b8bd506d328c34e0 Mon Sep 17 00:00:00 2001 +From: Ernestas Kulik +Date: Tue, 25 Aug 2020 15:17:54 +0300 +Subject: [PATCH] gui-wizard-gtk: wizard: Fix invalid memory read +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +This partially reverts 7aba6e53bbfeedaacd95bbaa5e0c5e325a3e6a8d, which +results in “event” being inappropriately freed before a “goto” statement +is executed and the value stored in “g_event_selected” is read. +--- + src/gui-wizard-gtk/wizard.c | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index a4d7caa0..3e69a513 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -2635,7 +2635,7 @@ static gint select_next_page_no(gint current_page_no) + + log_info("%s: Looking for next event to process", __func__); + /* (note: this frees and sets to NULL g_event_selected) */ +- g_autofree char *event = setup_next_processed_event(&g_auto_event_list); ++ char *event = setup_next_processed_event(&g_auto_event_list); + if (!event) + { + current_page_no = PAGENO_EVENT_PROGRESS - 1; +@@ -2644,6 +2644,8 @@ static gint select_next_page_no(gint current_page_no) + + if (!get_sensitive_data_permission(event)) + { ++ free(event); ++ + cancel_processing(g_lbl_event_log, /* default message */ NULL, TERMINATE_NOFLAGS); + current_page_no = PAGENO_EVENT_PROGRESS - 1; + goto again; +@@ -2659,6 +2661,8 @@ static gint select_next_page_no(gint current_page_no) + + if (libreport_get_global_stop_on_not_reportable()) + { ++ free(event); ++ + cancel_processing(g_lbl_event_log, msg, TERMINATE_NOFLAGS); + current_page_no = PAGENO_EVENT_PROGRESS - 1; + goto again; +-- +2.28.0 + diff --git a/0001-gui-wizard-gtk-Fix-a-double-free-condition.patch b/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch similarity index 100% rename from 0001-gui-wizard-gtk-Fix-a-double-free-condition.patch rename to 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch diff --git a/0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch b/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch similarity index 100% rename from 0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch rename to 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch diff --git a/libreport.spec b/libreport.spec index c160ab3..2d609f8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,13 +15,15 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 8%{?dist} +Release: 9%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0: 0001-gui-wizard-gtk-Fix-a-double-free-condition.patch -Patch1: 0002-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch +Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch +Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch +Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch +Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -662,6 +664,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Sep 27 2020 Matěj Grabovský - 2.14.0-9 +- Add upstream fixes for memory management + * Sun Sep 27 2020 Matěj Grabovský - 2.14.0-8 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882950 From 11466005e02df53d5a468cf094038c0b60928013 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Tue, 29 Sep 2020 16:15:42 +0200 Subject: [PATCH 065/133] Add upstream patches for memory management Add patch for rhbz#1883337 and rhbz#1883410. --- 0005-gui-wizard-gtk-Fix-segfault.patch | 66 +++++++++++++++++++ ...l-autofree-pointers-before-returning.patch | 40 +++++++++++ libreport.spec | 8 ++- 3 files changed, 113 insertions(+), 1 deletion(-) create mode 100644 0005-gui-wizard-gtk-Fix-segfault.patch create mode 100644 0006-event_config-Null-autofree-pointers-before-returning.patch diff --git a/0005-gui-wizard-gtk-Fix-segfault.patch b/0005-gui-wizard-gtk-Fix-segfault.patch new file mode 100644 index 0000000..29d65ae --- /dev/null +++ b/0005-gui-wizard-gtk-Fix-segfault.patch @@ -0,0 +1,66 @@ +From 1a22f30187163ce288b14e55a80539353a38b7be Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Tue, 29 Sep 2020 14:16:00 +0200 +Subject: [PATCH 1/2] gui-wizard-gtk: Fix segfault + +Since show_error_as_msgbox() is specified as the custom logging handler +(via setting libreport_g_custom_logger), it will get called if an error +occurs in libreport_save_user_settings(). However, at that point, +g_wnd_assistant has already been destroyed, which leads to an invalid +read in show_error_as_msgbox(). + +This change unsets the custom logging handler after the GUI is destroyed +and adds an assertion in show_error_as_msgbox() checking that +g_wnd_assistant is not a null pointer. + +Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1883337 +--- + src/gui-wizard-gtk/main.c | 6 ++++-- + src/gui-wizard-gtk/wizard.c | 2 ++ + 2 files changed, 6 insertions(+), 2 deletions(-) + +diff --git a/src/gui-wizard-gtk/main.c b/src/gui-wizard-gtk/main.c +index e111948c..f094c5fb 100644 +--- a/src/gui-wizard-gtk/main.c ++++ b/src/gui-wizard-gtk/main.c +@@ -125,6 +125,7 @@ int main(int argc, char **argv) + /* List of events specified on the command line. */ + GList *user_event_list = NULL; + const char *prgname = "abrt"; ++ int ret = 0; + abrt_init(argv); + + /* I18n */ +@@ -217,13 +218,14 @@ int main(int argc, char **argv) + g_signal_connect(app, "startup", G_CALLBACK(startup_wizard), NULL); + + /* Enter main loop */ +- g_application_run(G_APPLICATION(app), argc, argv); ++ ret = g_application_run(G_APPLICATION(app), argc, argv); + g_object_unref(app); ++ libreport_g_custom_logger = NULL; + + if (opts & OPT_d) + delete_dump_dir_possibly_using_abrtd(g_dump_dir_name); + + libreport_save_user_settings(); + +- return 0; ++ return ret; + } +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 775b709f..c4a0b4c0 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -360,6 +360,8 @@ struct dump_dir *wizard_open_directory_for_writing(const char *dump_dir_name) + + void show_error_as_msgbox(const char *msg) + { ++ g_return_if_fail(g_wnd_assistant != NULL); ++ + GtkWidget *dialog = gtk_message_dialog_new(GTK_WINDOW(g_wnd_assistant), + GTK_DIALOG_DESTROY_WITH_PARENT, + GTK_MESSAGE_WARNING, +-- +2.26.2 + diff --git a/0006-event_config-Null-autofree-pointers-before-returning.patch b/0006-event_config-Null-autofree-pointers-before-returning.patch new file mode 100644 index 0000000..ed3a26f --- /dev/null +++ b/0006-event_config-Null-autofree-pointers-before-returning.patch @@ -0,0 +1,40 @@ +From 41b6477bdeaa82c647db2f1c2ba1132c77b365ed Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Tue, 29 Sep 2020 14:43:15 +0200 +Subject: [PATCH 2/2] event_config: Null autofree pointers before returning + +The pointers to strings in the function check_problem_rating_usability() +need to be nullified before the function returns as they are declared +for auto-cleanup. + +This change fixes a double-free condition in which the returned strings +were attempted to be freed again in the caller, +is_backtrace_rating_usable(). + +Bug was introduced in 05e9c9273. + +Resolves rhbz#1883410 +--- + src/lib/event_config.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/src/lib/event_config.c b/src/lib/event_config.c +index c8053b7c..01e91efe 100644 +--- a/src/lib/event_config.c ++++ b/src/lib/event_config.c +@@ -541,10 +541,10 @@ bool check_problem_rating_usability(const event_config_t *cfg, + + finish: + if (description) +- *description = tmp_desc; ++ *description = g_steal_pointer(&tmp_desc); + + if (detail) +- *detail = tmp_detail; ++ *detail = g_steal_pointer(&tmp_detail); + + return result; + } +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 2d609f8..27d2948 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 9%{?dist} +Release: 10%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -24,6 +24,8 @@ Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch +Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch +Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -664,6 +666,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Sep 29 2020 Matěj Grabovský - 2.14.0-10 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883337 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883410 + * Sun Sep 27 2020 Matěj Grabovský - 2.14.0-9 - Add upstream fixes for memory management From aa4f8872d751f1dae5e6b73da5ecb6441b00b28f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 9 Oct 2020 10:30:49 +0200 Subject: [PATCH 066/133] Add patch for #1882328 --- ...wizard-gtk-Don-t-autofree-URL-string.patch | 34 +++++++++++++++++++ libreport.spec | 6 +++- 2 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch diff --git a/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch b/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch new file mode 100644 index 0000000..b28d183 --- /dev/null +++ b/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch @@ -0,0 +1,34 @@ +From 9b6d40905c21b476c58e9f9a908ddb32a0a56a18 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Tue, 29 Sep 2020 19:14:05 +0200 +Subject: [PATCH] gui-wizard-gtk: Don't autofree URL string + +g_object_set_data() does not (and cannot) copy the data passed to it, so +once url is freed, a subsequent access to the 'url' tag leads to an +invalid read and segfault. + +Bug was introduced in df386b097. + +Resolves rhbz#1882328 +--- + src/gui-wizard-gtk/wizard.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c +index 0af19587..ba1998df 100644 +--- a/src/gui-wizard-gtk/wizard.c ++++ b/src/gui-wizard-gtk/wizard.c +@@ -462,8 +462,8 @@ static void append_to_textview(GtkTextView *tv, const char *str) + GtkTextTag *tag; + tag = gtk_text_buffer_create_tag(tb, NULL, "foreground", "blue", + "underline", PANGO_UNDERLINE_SINGLE, NULL); +- g_autofree char *url = g_strndup(t->start, t->len); +- g_object_set_data(G_OBJECT(tag), "url", url); ++ char *url = g_strndup(t->start, t->len); ++ g_object_set_data_full(G_OBJECT(tag), "url", url, g_free); + + gtk_text_buffer_insert_with_tags(tb, &text_iter, url, -1, tag, NULL); + +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index 27d2948..f17e39f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 10%{?dist} +Release: 11%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -26,6 +26,7 @@ Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch +Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -666,6 +667,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Oct 09 2020 Matěj Grabovský - 2.14.0-11 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882328 + * Tue Sep 29 2020 Matěj Grabovský - 2.14.0-10 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883337 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1883410 From d9b53bd182bd5fc0cd45e39bc17d08a8ae94b6c0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Tue, 3 Nov 2020 16:36:34 +0100 Subject: [PATCH 067/133] Add patch for #1893595 --- 0008-rhbz-Fix-a-double-free-condition.patch | 48 +++++++++++++++++++++ libreport.spec | 6 ++- 2 files changed, 53 insertions(+), 1 deletion(-) create mode 100644 0008-rhbz-Fix-a-double-free-condition.patch diff --git a/0008-rhbz-Fix-a-double-free-condition.patch b/0008-rhbz-Fix-a-double-free-condition.patch new file mode 100644 index 0000000..a25b684 --- /dev/null +++ b/0008-rhbz-Fix-a-double-free-condition.patch @@ -0,0 +1,48 @@ +From 6cd4fa7749b2de7a39b6bf22373b56d1c1be91d1 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Mon, 2 Nov 2020 11:45:23 +0100 +Subject: [PATCH 1/2] rhbz: Fix a double-free condition + +The `cc` string must not be freed after the variable goes out of scope +since it's appended to `cc_list`. (`g_list_append()` does not copy its +input.) We only need to free the last string in the loop, which is an +empty string. + +The bug was introduced in 7aba6e53. + +Resolves rhbz#1893595 +--- + src/plugins/rhbz.c | 8 +++++--- + 1 file changed, 5 insertions(+), 3 deletions(-) + +diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c +index 25d30207..c2855a70 100644 +--- a/src/plugins/rhbz.c ++++ b/src/plugins/rhbz.c +@@ -407,18 +407,20 @@ GList *rhbz_bug_cc(xmlrpc_value* result_xml) + if (!item) + continue; + +- const char* cc = NULL; +- xmlrpc_read_string(&env, item, &cc); ++ char *cc = NULL; ++ xmlrpc_read_string(&env, item, (const char **)&cc); + xmlrpc_DECREF(item); + if (env.fault_occurred) + abrt_xmlrpc_die(&env); + + if (*cc != '\0') + { +- cc_list = g_list_append(cc_list, (char*)cc); ++ cc_list = g_list_append(cc_list, cc); + log_debug("member on cc is %s", cc); + continue; + } ++ ++ free(cc); + } + xmlrpc_DECREF(cc_member); + return cc_list; +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index f17e39f..d233c98 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 11%{?dist} +Release: 12%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -27,6 +27,7 @@ Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch +Patch7: 0008-rhbz-Fix-a-double-free-condition.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel @@ -667,6 +668,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Nov 3 2020 Matěj Grabovský - 2.14.0-12 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1893595 + * Fri Oct 09 2020 Matěj Grabovský - 2.14.0-11 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1882328 From ec078627a67f355221c2d44a175c5bbad37267ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Tue, 3 Nov 2020 16:47:06 +0100 Subject: [PATCH 068/133] Fix patch to apply correctly --- 0008-rhbz-Fix-a-double-free-condition.patch | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/0008-rhbz-Fix-a-double-free-condition.patch b/0008-rhbz-Fix-a-double-free-condition.patch index a25b684..4180663 100644 --- a/0008-rhbz-Fix-a-double-free-condition.patch +++ b/0008-rhbz-Fix-a-double-free-condition.patch @@ -1,7 +1,7 @@ -From 6cd4fa7749b2de7a39b6bf22373b56d1c1be91d1 Mon Sep 17 00:00:00 2001 +From 9cdf0f9123ee39c7cb32a276371b2fd95f0df5ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Mon, 2 Nov 2020 11:45:23 +0100 -Subject: [PATCH 1/2] rhbz: Fix a double-free condition +Subject: [PATCH] rhbz: Fix a double-free condition The `cc` string must not be freed after the variable goes out of scope since it's appended to `cc_list`. (`g_list_append()` does not copy its @@ -16,14 +16,14 @@ Resolves rhbz#1893595 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c -index 25d30207..c2855a70 100644 +index 8a2ded79..e0d7a091 100644 --- a/src/plugins/rhbz.c +++ b/src/plugins/rhbz.c -@@ -407,18 +407,20 @@ GList *rhbz_bug_cc(xmlrpc_value* result_xml) +@@ -406,18 +406,20 @@ GList *rhbz_bug_cc(xmlrpc_value* result_xml) if (!item) continue; -- const char* cc = NULL; +- g_autofree const char* cc = NULL; - xmlrpc_read_string(&env, item, &cc); + char *cc = NULL; + xmlrpc_read_string(&env, item, (const char **)&cc); From 4eeb8e1577a388094f992f5eacaf7b31a6a8ac04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Tue, 3 Nov 2020 17:03:34 +0100 Subject: [PATCH 069/133] Fix date format in spec --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index d233c98..abcb45d 100644 --- a/libreport.spec +++ b/libreport.spec @@ -668,7 +668,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog -* Tue Nov 3 2020 Matěj Grabovský - 2.14.0-12 +* Tue Nov 03 2020 Matěj Grabovský - 2.14.0-12 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1893595 * Fri Oct 09 2020 Matěj Grabovský - 2.14.0-11 From 0cacf21d88d3ee05b5d69fbc70d7215b11ec01a0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= Date: Thu, 5 Nov 2020 15:56:50 +0100 Subject: [PATCH 070/133] Use autoreconf in %build instead of plain autoconf This way, when stuff is fixed in automake, the source tarball does not need to be re-generated in upstream to use the fix. Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1893652 --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index abcb45d..bfac57c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -295,7 +295,7 @@ data over ftp/scp... %autosetup -S git %build -autoconf +autoreconf %configure \ %if %{without bugzilla} From df126de8c30ed3d701abae80524d857f4d490ac6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Dec 2020 12:29:09 +0100 Subject: [PATCH 071/133] Port upstream API patch Port an addition in libreport Python API from upstream in order to hotfix interoperability with abrt. The commit in question: https://github.com/abrt/libreport/commit/cbb6b43038f0d88b28197ba905ba9324c0602945 Resolves rhbz#1906405 --- ...d-getter-for-package-count-to-downlo.patch | 28 +++++++++++++++++++ libreport.spec | 3 +- 2 files changed, 30 insertions(+), 1 deletion(-) create mode 100644 0009-client-python-Add-getter-for-package-count-to-downlo.patch diff --git a/0009-client-python-Add-getter-for-package-count-to-downlo.patch b/0009-client-python-Add-getter-for-package-count-to-downlo.patch new file mode 100644 index 0000000..6fa6ee4 --- /dev/null +++ b/0009-client-python-Add-getter-for-package-count-to-downlo.patch @@ -0,0 +1,28 @@ +From cbb6b43038f0d88b28197ba905ba9324c0602945 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= +Date: Thu, 3 Sep 2020 15:05:23 +0200 +Subject: [PATCH] client-python: Add getter for package count to downloader + +Add a new method get_package_count() to the DebugInfoDownload class +which returns the number of packages that will be downloaded. +--- + src/client-python/reportclient/debuginfo.py | 3 +++ + 1 file changed, 3 insertions(+) + +diff --git a/src/client-python/reportclient/debuginfo.py b/src/client-python/reportclient/debuginfo.py +index cb318e8a..eeb2be30 100644 +--- a/src/client-python/reportclient/debuginfo.py ++++ b/src/client-python/reportclient/debuginfo.py +@@ -242,6 +242,9 @@ class DebugInfoDownload(object): + def get_install_size(self): + return self.installed_size + ++ def get_package_count(self): ++ return len(self.package_files_dict) ++ + def mute_stdout(self): + """ + Links sys.stdout with /dev/null and saves the old stdout +-- +2.26.2 + diff --git a/libreport.spec b/libreport.spec index bfac57c..0a638e3 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 12%{?dist} +Release: 13%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -28,6 +28,7 @@ Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch Patch7: 0008-rhbz-Fix-a-double-free-condition.patch +Patch8: 0009-client-python-Add-getter-for-package-count-to-downlo.patch BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel From 5f51ab9799c2a71fe8cd6c3e1b9fd9e264d5c72f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Fri, 11 Dec 2020 12:32:43 +0100 Subject: [PATCH 072/133] Add changelog entry for new release --- libreport.spec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libreport.spec b/libreport.spec index 0a638e3..637f485 100644 --- a/libreport.spec +++ b/libreport.spec @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Dec 11 2020 Matěj Grabovský - 2.14.0-13 +- Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1906405 + * Tue Nov 03 2020 Matěj Grabovský - 2.14.0-12 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1893595 From 52b033c56c291b0b5a4725b8338250cb7c06da85 Mon Sep 17 00:00:00 2001 From: Tom Stellard Date: Tue, 5 Jan 2021 02:37:28 +0000 Subject: [PATCH 073/133] Add BuildRequires: make https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot --- libreport.spec | 1 + 1 file changed, 1 insertion(+) diff --git a/libreport.spec b/libreport.spec index 637f485..cd4aa5b 100644 --- a/libreport.spec +++ b/libreport.spec @@ -227,6 +227,7 @@ Workflows to report issues into the CentOS Bug Tracker. %package plugin-ureport Summary: %{name}'s micro report plugin BuildRequires: %{libjson_devel} +BuildRequires: make Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} %if 0%{?rhel} && ! 0%{?eln} From 9ab59e2f7c828529e660ea3c02addedfb95445e7 Mon Sep 17 00:00:00 2001 From: Peter Robinson Date: Mon, 18 Jan 2021 10:33:31 +0000 Subject: [PATCH 074/133] Bump rev for upgrades --- libreport.spec | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libreport.spec b/libreport.spec index cd4aa5b..b8e8abd 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 13%{?dist} +Release: 15%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -670,7 +670,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog -* Tue Dec 11 2020 Matěj Grabovský - 2.14.0-13 +* Mon Jan 18 2021 Peter Robinson - 2.14.0-15 +- Bump rev for upgrades + +* Fri Dec 11 2020 Matěj Grabovský - 2.14.0-13 - Add fix for https://bugzilla.redhat.com/show_bug.cgi?id=1906405 * Tue Nov 03 2020 Matěj Grabovský - 2.14.0-12 From 5ab705c31ac76c08684de9addbf208a1e32dd0e3 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Tue, 26 Jan 2021 17:53:13 +0000 Subject: [PATCH 075/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index b8e8abd..b1c3fd1 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 15%{?dist} +Release: 16%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -670,6 +670,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Jan 26 2021 Fedora Release Engineering - 2.14.0-16 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild + * Mon Jan 18 2021 Peter Robinson - 2.14.0-15 - Bump rev for upgrades From 608e5752ddc036cfd4722141b0c6ee80b2dbf41e Mon Sep 17 00:00:00 2001 From: Michal Srb Date: Fri, 29 Jan 2021 14:08:38 +0100 Subject: [PATCH 076/133] Drop AnacondaRHEL workflow reference Signed-off-by: Michal Srb --- libreport.spec | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libreport.spec b/libreport.spec index b1c3fd1..94f54e0 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.14.0 -Release: 16%{?dist} +Release: 17%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -655,9 +655,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %if 0%{?fedora} || 0%{?eln} %{_datadir}/%{name}/workflows/workflow_AnacondaFedora.xml %endif -%if 0%{?rhel} && ! 0%{?eln} -%{_datadir}/%{name}/workflows/workflow_AnacondaRHEL.xml -%endif %{_datadir}/%{name}/workflows/workflow_AnacondaUpload.xml %config(noreplace) %{_sysconfdir}/libreport/workflows.d/anaconda_event.conf %config(noreplace) %{_sysconfdir}/libreport/events.d/bugzilla_anaconda_event.conf @@ -670,6 +667,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Jan 29 2021 Michal Srb - 2.14.0-17 +- Drop AnacondaRHEL workflow reference + * Tue Jan 26 2021 Fedora Release Engineering - 2.14.0-16 - Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild From dd2a474758b36ed5c207870fbfeeeaaa1fa8993e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20=C5=BDidek?= Date: Wed, 3 Feb 2021 13:56:43 +0100 Subject: [PATCH 077/133] gating: Add gating.yml --- gating.yaml | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) create mode 100644 gating.yaml diff --git a/gating.yaml b/gating.yaml new file mode 100644 index 0000000..de03204 --- /dev/null +++ b/gating.yaml @@ -0,0 +1,20 @@ +--- !Policy +product_versions: + - fedora-* +decision_context: bodhi_update_push_testing +subject_type: koji_build +rules: + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpmdeplint.functional} + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpminspect.static-analysis} + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.installability.functional} + +--- !Policy +product_versions: + - fedora-* +decision_context: bodhi_update_push_stable +subject_type: koji_build +rules: + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpmdeplint.functional} + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpminspect.static-analysis} + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.installability.functional} + From 9785cc8667e12ba1253524e369b54eb785f4d36f Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Thu, 4 Mar 2021 14:48:55 +0100 Subject: [PATCH 078/133] Add simple smoke test Build and execute a minimal program using the libreport library --- .fmf/version | 1 + gating.yaml | 2 ++ tests/smoke.fmf | 7 +++++++ tests/smoke.sh | 5 +++++ 4 files changed, 15 insertions(+) create mode 100644 .fmf/version create mode 100644 tests/smoke.fmf create mode 100755 tests/smoke.sh diff --git a/.fmf/version b/.fmf/version new file mode 100644 index 0000000..d00491f --- /dev/null +++ b/.fmf/version @@ -0,0 +1 @@ +1 diff --git a/gating.yaml b/gating.yaml index de03204..9ca798d 100644 --- a/gating.yaml +++ b/gating.yaml @@ -7,6 +7,7 @@ rules: - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpmdeplint.functional} - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpminspect.static-analysis} - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.installability.functional} + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional} --- !Policy product_versions: @@ -17,4 +18,5 @@ rules: - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpmdeplint.functional} - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpminspect.static-analysis} - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.installability.functional} + - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional} diff --git a/tests/smoke.fmf b/tests/smoke.fmf new file mode 100644 index 0000000..c043228 --- /dev/null +++ b/tests/smoke.fmf @@ -0,0 +1,7 @@ +summary: Basic smoke test for libreport +require: gcc +execute: + script: | + test/smoke.sh + report-cli --version + diff --git a/tests/smoke.sh b/tests/smoke.sh new file mode 100755 index 0000000..49f2b53 --- /dev/null +++ b/tests/smoke.sh @@ -0,0 +1,5 @@ +#!/usr/bin/bash + +echo "int main(){libreport_init();}" | gcc -x c -lreport -Wno-implicit-function-declaration - +./a.out +rm -f a.out From edab1b2aabff5d09635af1095dbe3689ce6f3c4f Mon Sep 17 00:00:00 2001 From: Packit Service Date: Tue, 4 May 2021 18:00:44 +0000 Subject: [PATCH 079/133] [packit] 2.15.1 upstream release Upstream tag: 2.15.1 Upstream commit: 5e65d4e4 Signed-off-by: Packit Service --- .gitignore | 1 + .packit.yml | 17 +++++++++++++++++ README.packit | 3 +++ libreport.spec | 52 +++++++++++++++++++++++++++++--------------------- sources | 2 +- 5 files changed, 52 insertions(+), 23 deletions(-) create mode 100644 .packit.yml create mode 100644 README.packit diff --git a/.gitignore b/.gitignore index 23c2ea8..0af2d9c 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,4 @@ /libreport-2.13.0.tar.gz /libreport-2.13.1.tar.gz /libreport-2.14.0.tar.gz +/libreport-2.15.1.tar.gz diff --git a/.packit.yml b/.packit.yml new file mode 100644 index 0000000..b82be50 --- /dev/null +++ b/.packit.yml @@ -0,0 +1,17 @@ +specfile_path: libreport.spec +synced_files: + - .packit.yml + - libreport.spec +upstream_package_name: libreport +upstream_project_url: https://github.com/abrt/libreport +downstream_package_name: libreport +jobs: +- job: propose_downstream + trigger: release + metadata: + dist_git_branch: fedora-all +- job: copr_build + trigger: pull_request + metadata: + targets: + - fedora-all diff --git a/README.packit b/README.packit new file mode 100644 index 0000000..056cacc --- /dev/null +++ b/README.packit @@ -0,0 +1,3 @@ +This repository is maintained by packit. +https://packit.dev/ +The file was generated using packit 0.29.0. diff --git a/libreport.spec b/libreport.spec index 94f54e0..d3cee60 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,22 +14,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.14.0 -Release: 17%{?dist} +Version: 2.15.1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - -Patch0: 0001-gui-wizard-gtk-wizard-Remove-variable.patch -Patch1: 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch -Patch2: 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch -Patch3: 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch -Patch4: 0005-gui-wizard-gtk-Fix-segfault.patch -Patch5: 0006-event_config-Null-autofree-pointers-before-returning.patch -Patch6: 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch -Patch7: 0008-rhbz-Fix-a-double-free-condition.patch -Patch8: 0009-client-python-Add-getter-for-package-count-to-downlo.patch - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -37,9 +26,9 @@ BuildRequires: desktop-file-utils BuildRequires: python3-devel BuildRequires: gettext BuildRequires: libxml2-devel -BuildRequires: libtar-devel BuildRequires: intltool BuildRequires: libtool +BuildRequires: make BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto @@ -191,7 +180,7 @@ The simple reporter plugin which writes a report to the systemd journal. %package plugin-mailx Summary: %{name}'s mailx reporter plugin Requires: %{name} = %{version}-%{release} -Requires: mailx +Requires: /usr/bin/mailx %description plugin-mailx The simple reporter plugin which sends a report via mailx to a specified @@ -227,12 +216,8 @@ Workflows to report issues into the CentOS Bug Tracker. %package plugin-ureport Summary: %{name}'s micro report plugin BuildRequires: %{libjson_devel} -BuildRequires: make Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} -%if 0%{?rhel} && ! 0%{?eln} -Requires: python3-subscription-manager-rhsm -%endif %description plugin-ureport Uploads micro-report to abrt server @@ -294,10 +279,10 @@ data over ftp/scp... %endif %prep -%autosetup -S git +%autosetup %build -autoreconf +./autogen.sh %configure \ %if %{without bugzilla} @@ -312,7 +297,7 @@ autoreconf %make_install \ %if %{with python3} PYTHON=%{__python3} \ -%endif # with python3 +%endif mandir=%{_mandir} %find_lang %{name} @@ -413,12 +398,14 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %config(noreplace) %{_sysconfdir}/%{name}/report_event.conf %config(noreplace) %{_sysconfdir}/%{name}/forbidden_words.conf %config(noreplace) %{_sysconfdir}/%{name}/ignored_words.conf +%config(noreplace) %{_sysconfdir}/%{name}/ignored_elements.conf %{_datadir}/%{name}/conf.d/libreport.conf %{_libdir}/libreport.so.* %{_mandir}/man5/libreport.conf.5* %{_mandir}/man5/report_event.conf.5* %{_mandir}/man5/forbidden_words.conf.5* %{_mandir}/man5/ignored_words.conf.5* +%{_mandir}/man5/ignored_elements.conf.5* # filesystem package owns /usr/share/augeas/lenses directory %{_datadir}/augeas/lenses/libreport.aug @@ -667,6 +654,27 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue May 04 2021 Packit Service - 2.15.1-1 +- Release version 2.15.1-1 (Michal Fabik) +- ureport: Strange usage of tmp variable (Michal Židek) +- steal_directory: Silence a warning (Michal Židek) +- dump_dir: Use g_free and re-init to NULL (Michal Židek) +- dump_dir: Use g_free instead of free (Michal Židek) +- dirsize: No need to check for NULL (Michal Židek) +- dirsize: Bad checks for NULL (Michal Židek) +- gui-wizard-gtk: Possible double free (Michal Židek) +- gui-wizard-gtk: Check if EXCLUDE_FROM_REPORT is set (Michal Židek) +- gui-wizard-gtk: Improve docs and add missing free (Michal Židek) +- cli: Address of local auto-variable assigned to a function parameter (Michal Židek) +- gtk-helpers: Add missing g_strfreev() (Michal Židek) +- cli: Add missing g_free call (Michal Židek) +- gitignore: Drop misleading comment (Michal Fabik) +- spec: Sync upstream with distgit (Michal Fabik) +- changelog: Add missing link to changes in 2.15.0 (Matěj Grabovský) +- spec: Make plugin-mailx depend on /usr/bin/mailx (Matěj Grabovský) +- Add support for excluding whole elements from search for sensitive words (Michal Srb) +- ignored_words: add more "key" variations (Michal Srb) + * Fri Jan 29 2021 Michal Srb - 2.14.0-17 - Drop AnacondaRHEL workflow reference diff --git a/sources b/sources index c9ad10a..6f8a882 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.14.0.tar.gz) = 6bc428a2d91b22f2df1abc9326c131e91e5e7be78ca64ad6533ff8246fa02df9a975360686811d29fd66210206a4e4ee5dc9faf2c9b23eccab7ca0ec07c3d43c +SHA512 (libreport-2.15.1.tar.gz) = 70f947690173a0afa57981c9755a18bdd0ad44c888c00713de74624296b81ff25203d5dda5d5c57eac85da4a1631585184b77715c7adf6688b469e32d4113cf4 From 35e044e3e3d8f22b6e1f3c1cd521dcb13791651d Mon Sep 17 00:00:00 2001 From: Packit Service Date: Tue, 1 Jun 2021 12:00:20 +0000 Subject: [PATCH 080/133] [packit] 2.15.2 upstream release Upstream tag: 2.15.2 Upstream commit: 3474c03d Signed-off-by: Packit Service --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 11 ++++++++--- sources | 2 +- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 0af2d9c..88f39e4 100644 --- a/.gitignore +++ b/.gitignore @@ -14,3 +14,4 @@ /libreport-2.13.1.tar.gz /libreport-2.14.0.tar.gz /libreport-2.15.1.tar.gz +/libreport-2.15.2.tar.gz diff --git a/README.packit b/README.packit index 056cacc..8ede8cd 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.29.0. +The file was generated using packit 0.31.0. diff --git a/libreport.spec b/libreport.spec index d3cee60..5c97472 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.15.1 +Version: 2.15.2 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -36,7 +36,6 @@ BuildRequires: newt-devel BuildRequires: libproxy-devel BuildRequires: satyr-devel >= 0.24 BuildRequires: glib2-devel >= %{glib_ver} -BuildRequires: nettle-devel BuildRequires: git-core %if 0%{?fedora} >= 24 || 0%{?rhel} > 7 @@ -56,7 +55,6 @@ Requires: libreport-filesystem = %{version}-%{release} Requires: satyr%{?_isa} >= 0.24 Requires: glib2%{?_isa} >= %{glib_ver} Requires: libarchive%{?_isa} -Requires: nettle%{?_isa} # Required for the temporary modularity hack, see below %if 0%{?_module_build} @@ -654,6 +652,13 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Tue Jun 01 2021 Packit Service - 2.15.2-1 +- Release version 2.15.2-1 (Michal Fabik) +- binhex: Remove unused API (Matěj Grabovský) +- lib: Use GLib for computing SHA-1 digests (Matěj Grabovský) +- run_event: Improve memory management (Matěj Grabovský) +- gtk: Fix segfault (Matěj Grabovský) + * Tue May 04 2021 Packit Service - 2.15.1-1 - Release version 2.15.1-1 (Michal Fabik) - ureport: Strange usage of tmp variable (Michal Židek) diff --git a/sources b/sources index 6f8a882..c9ba4ce 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.15.1.tar.gz) = 70f947690173a0afa57981c9755a18bdd0ad44c888c00713de74624296b81ff25203d5dda5d5c57eac85da4a1631585184b77715c7adf6688b469e32d4113cf4 +SHA512 (libreport-2.15.2.tar.gz) = c98003325fa70d674177c9f602a7f121815a9675701ee780ad8908ed69862f2c69be65c7483fd3f017ba299dda51ba304f0908c771c9d97cb5bba057e3a9c5dc From be6247841bbc443caea5384790e820e86b810920 Mon Sep 17 00:00:00 2001 From: Python Maint Date: Fri, 4 Jun 2021 10:24:30 +0200 Subject: [PATCH 081/133] Rebuilt for Python 3.10 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 5c97472..bbc3901 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Jun 04 2021 Python Maint - 2.15.2-2 +- Rebuilt for Python 3.10 + * Tue Jun 01 2021 Packit Service - 2.15.2-1 - Release version 2.15.2-1 (Michal Fabik) - binhex: Remove unused API (Matěj Grabovský) From 662f01769c2acf4123e972ffaa419988b6b4009a Mon Sep 17 00:00:00 2001 From: Michal Fabik Date: Fri, 4 Jun 2021 14:42:17 +0200 Subject: [PATCH 082/133] Bump release to rebuild in new side tag Signed-off-by: Michal Fabik --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index bbc3901..7cc5bf1 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz From 9b8956b0f0ad4c1d04df706cfdf971104164aabf Mon Sep 17 00:00:00 2001 From: Python Maint Date: Mon, 7 Jun 2021 17:17:41 +0200 Subject: [PATCH 083/133] Rebuilt for Python 3.10 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 7cc5bf1..bcc4ece 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 3%{?dist} +Release: 4%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jun 07 2021 Python Maint - 2.15.2-4 +- Rebuilt for Python 3.10 + * Fri Jun 04 2021 Python Maint - 2.15.2-2 - Rebuilt for Python 3.10 From 210e3db980825fe765a75105e34bc0dc2c271848 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Esser?= Date: Sat, 10 Jul 2021 11:54:40 +0200 Subject: [PATCH 084/133] Rebuild for versioned symbols in json-c --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index bcc4ece..d4503b1 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 4%{?dist} +Release: 5%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sat Jul 10 2021 Björn Esser - 2.15.2-5 +- Rebuild for versioned symbols in json-c + * Mon Jun 07 2021 Python Maint - 2.15.2-4 - Rebuilt for Python 3.10 From 2086847084ef9ac37c2f83b54e2ae56107fbe9be Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 22 Jul 2021 12:14:53 +0000 Subject: [PATCH 085/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index d4503b1..74cb911 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 5%{?dist} +Release: 6%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jul 22 2021 Fedora Release Engineering - 2.15.2-6 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild + * Sat Jul 10 2021 Björn Esser - 2.15.2-5 - Rebuild for versioned symbols in json-c From a531967da4aaab2bee7526afd23243986010a0a5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 22 Dec 2021 11:22:14 +0100 Subject: [PATCH 086/133] Rebuild for satyr 0.39 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 74cb911..bc5d681 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 6%{?dist} +Release: 7%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Dec 22 2021 Matěj Grabovský - 2.15.2-7 +- Rebuild for satyr 0.39 + * Thu Jul 22 2021 Fedora Release Engineering - 2.15.2-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild From ff73caace9f6bf6009cc3e33206fa5d16af462c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 6 Jan 2022 15:39:44 +0100 Subject: [PATCH 087/133] Do not install conflicting abrt packages in test --- libreport.spec | 5 ++++- tests/smoke.fmf | 6 ++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index bc5d681..266cf96 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 7%{?dist} +Release: 8%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jan 06 2022 Matěj Grabovský - 2.15.2-8 +- Bump release for rebuild + * Wed Dec 22 2021 Matěj Grabovský - 2.15.2-7 - Rebuild for satyr 0.39 diff --git a/tests/smoke.fmf b/tests/smoke.fmf index c043228..1dc5b73 100644 --- a/tests/smoke.fmf +++ b/tests/smoke.fmf @@ -1,5 +1,11 @@ summary: Basic smoke test for libreport require: gcc +prepare: + how: install + # Do not attempt to install conflicting subpackages. + exclude: + - abrt-atomic + - python3-abrt-container-addon execute: script: | test/smoke.sh From a5f24502c1004fc59be6c8e46566547eb7fa2b9b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 6 Jan 2022 17:08:54 +0100 Subject: [PATCH 088/133] Fix broken smoke test --- libreport.spec | 5 ++++- tests/smoke.fmf | 3 +-- tests/smoke.sh | 9 ++++++--- 3 files changed, 11 insertions(+), 6 deletions(-) diff --git a/libreport.spec b/libreport.spec index 266cf96..6337dfb 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 8%{?dist} +Release: 9%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jan 06 2022 Matěj Grabovský - 2.15.2-9 +- Bump release for rebuild + * Thu Jan 06 2022 Matěj Grabovský - 2.15.2-8 - Bump release for rebuild diff --git a/tests/smoke.fmf b/tests/smoke.fmf index 1dc5b73..092c42a 100644 --- a/tests/smoke.fmf +++ b/tests/smoke.fmf @@ -8,6 +8,5 @@ prepare: - python3-abrt-container-addon execute: script: | - test/smoke.sh + tests/smoke.sh report-cli --version - diff --git a/tests/smoke.sh b/tests/smoke.sh index 49f2b53..b43e98d 100755 --- a/tests/smoke.sh +++ b/tests/smoke.sh @@ -1,5 +1,8 @@ #!/usr/bin/bash -echo "int main(){libreport_init();}" | gcc -x c -lreport -Wno-implicit-function-declaration - -./a.out -rm -f a.out +gcc -x c -o smoke_test -lreport -Wno-implicit-function-declaration - < Date: Wed, 12 Jan 2022 14:11:54 +0100 Subject: [PATCH 089/133] Require GCC in test build; adjust test messages --- tests/{smoke.sh => library-smoke.sh} | 3 +++ tests/smoke.fmf | 6 ++++-- 2 files changed, 7 insertions(+), 2 deletions(-) rename tests/{smoke.sh => library-smoke.sh} (66%) diff --git a/tests/smoke.sh b/tests/library-smoke.sh similarity index 66% rename from tests/smoke.sh rename to tests/library-smoke.sh index b43e98d..ed1322f 100755 --- a/tests/smoke.sh +++ b/tests/library-smoke.sh @@ -1,8 +1,11 @@ #!/usr/bin/bash gcc -x c -o smoke_test -lreport -Wno-implicit-function-declaration - < int main(void) { libreport_init(); + printf("libreport initialized OK\n"); + return 0; } EOF ./smoke_test diff --git a/tests/smoke.fmf b/tests/smoke.fmf index 092c42a..150d7b0 100644 --- a/tests/smoke.fmf +++ b/tests/smoke.fmf @@ -1,12 +1,14 @@ summary: Basic smoke test for libreport -require: gcc prepare: how: install # Do not attempt to install conflicting subpackages. exclude: - abrt-atomic - python3-abrt-container-addon + # Prerequisite for smoke testing liblibreport. + package: + - gcc execute: script: | - tests/smoke.sh + tests/library-smoke.sh report-cli --version From b5305fd2362abb544c0b060226dd281917eff005 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 12 Jan 2022 15:23:19 +0100 Subject: [PATCH 090/133] Bump release for rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 6337dfb..8f8e22f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 9%{?dist} +Release: 10%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Jan 12 2022 Matěj Grabovský - 2.15.2-10 +- Bump for rebuild + * Thu Jan 06 2022 Matěj Grabovský - 2.15.2-9 - Bump release for rebuild From de63ffd8d819bc1c7fc791ff7cee4667a8c401d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 13 Jan 2022 13:00:47 +0100 Subject: [PATCH 091/133] Add patch for rhbz#2019402 --- ...ui-wizard-gtk-wizard-Remove-variable.patch | 39 ----------- ...ts-Don-t-use-deprecated-assertEquals.patch | 49 ++++++++++++++ ...d-gtk-wizard-Fix-invalid-memory-read.patch | 49 -------------- ...zard-gtk-Fix-a-double-free-condition.patch | 53 --------------- ...d-gtk-Fix-a-segfault-and-memory-leak.patch | 66 ------------------- 0005-gui-wizard-gtk-Fix-segfault.patch | 66 ------------------- ...l-autofree-pointers-before-returning.patch | 40 ----------- ...wizard-gtk-Don-t-autofree-URL-string.patch | 34 ---------- 0008-rhbz-Fix-a-double-free-condition.patch | 48 -------------- ...d-getter-for-package-count-to-downlo.patch | 28 -------- libreport.spec | 10 ++- 11 files changed, 58 insertions(+), 424 deletions(-) delete mode 100644 0001-gui-wizard-gtk-wizard-Remove-variable.patch create mode 100644 0001-tests-Don-t-use-deprecated-assertEquals.patch delete mode 100644 0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch delete mode 100644 0003-gui-wizard-gtk-Fix-a-double-free-condition.patch delete mode 100644 0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch delete mode 100644 0005-gui-wizard-gtk-Fix-segfault.patch delete mode 100644 0006-event_config-Null-autofree-pointers-before-returning.patch delete mode 100644 0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch delete mode 100644 0008-rhbz-Fix-a-double-free-condition.patch delete mode 100644 0009-client-python-Add-getter-for-package-count-to-downlo.patch diff --git a/0001-gui-wizard-gtk-wizard-Remove-variable.patch b/0001-gui-wizard-gtk-wizard-Remove-variable.patch deleted file mode 100644 index 9537db0..0000000 --- a/0001-gui-wizard-gtk-wizard-Remove-variable.patch +++ /dev/null @@ -1,39 +0,0 @@ -From 1c646a2948d287368ec1a82b444e8175ebfbf5b9 Mon Sep 17 00:00:00 2001 -From: Ernestas Kulik -Date: Tue, 25 Aug 2020 15:05:31 +0300 -Subject: [PATCH] gui-wizard-gtk: wizard: Remove variable - -cmd_output is no longer used since -440bcfa8526d50f122ec14e19f2bf2aa336f61e7 and trying to call -g_string_free() on it results in a critical warning. ---- - src/gui-wizard-gtk/wizard.c | 6 ------ - 1 file changed, 6 deletions(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index 44900448..a4d7caa0 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -231,8 +231,6 @@ typedef struct - - static page_obj_t pages[NUM_PAGES]; - --static GString *cmd_output = NULL; -- - /* Utility functions */ - - static void clear_warnings(void); -@@ -1667,10 +1665,6 @@ static gboolean consume_cmd_output(GIOChannel *source, GIOCondition condition, g - log_notice("done running event on '%s': %d", g_dump_dir_name, retval); - append_to_textview(g_tv_event_log, "\n"); - -- /* Free child output buffer */ -- g_string_free(cmd_output, TRUE); -- cmd_output = NULL; -- - /* Hide spinner and stop btn */ - gtk_widget_hide(GTK_WIDGET(g_spinner_event_log)); - gtk_widget_hide(g_btn_stop); --- -2.28.0 - diff --git a/0001-tests-Don-t-use-deprecated-assertEquals.patch b/0001-tests-Don-t-use-deprecated-assertEquals.patch new file mode 100644 index 0000000..44514fb --- /dev/null +++ b/0001-tests-Don-t-use-deprecated-assertEquals.patch @@ -0,0 +1,49 @@ +From 976d3ffcee73a5d832cb757f2dc39aea21abd2f2 Mon Sep 17 00:00:00 2001 +From: Michal Fabik +Date: Thu, 4 Nov 2021 22:14:08 +0100 +Subject: [PATCH] tests: Don't use deprecated assertEquals + +unittest.assertEquals was deprecated in Python 3.2 and will no longer be +supported in 3.11 + +Resolves: +https://bugzilla.redhat.com/show_bug.cgi?id=2019402 +--- + tests/client_python.at | 10 +++++----- + 1 file changed, 5 insertions(+), 5 deletions(-) + +diff --git a/tests/client_python.at b/tests/client_python.at +index d026ed70..75ec1890 100644 +--- a/tests/client_python.at ++++ b/tests/client_python.at +@@ -35,22 +35,22 @@ class TestReportClientVerbose(unittest.TestCase): + del sys.modules["reportclient"] + + def test_default(self): +- self.assertEquals(self.reportclient.verbose, 0) ++ self.assertEqual(self.reportclient.verbose, 0) + + def test_assign(self): + self.reportclient.set_verbosity(1) +- self.assertEquals(self.reportclient.verbose, 1) +- self.assertEquals(os.environ["ABRT_VERBOSE"], "1") ++ self.assertEqual(self.reportclient.verbose, 1) ++ self.assertEqual(os.environ["ABRT_VERBOSE"], "1") + + def test_load_from_environ(self): + os.environ["ABRT_VERBOSE"] = "2" + reload(self.reportclient) +- self.assertEquals(self.reportclient.verbose, 2) ++ self.assertEqual(self.reportclient.verbose, 2) + + def test_recover_from_invalid_environ(self): + os.environ["ABRT_VERBOSE"] = "foo" + reload(self.reportclient) +- self.assertEquals(self.reportclient.verbose, 0) ++ self.assertEqual(self.reportclient.verbose, 0) + + + if __name__ == "__main__": +-- +2.31.1 + diff --git a/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch b/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch deleted file mode 100644 index ed46b09..0000000 --- a/0002-gui-wizard-gtk-wizard-Fix-invalid-memory-read.patch +++ /dev/null @@ -1,49 +0,0 @@ -From 85b687098bcedb67285ab787b8bd506d328c34e0 Mon Sep 17 00:00:00 2001 -From: Ernestas Kulik -Date: Tue, 25 Aug 2020 15:17:54 +0300 -Subject: [PATCH] gui-wizard-gtk: wizard: Fix invalid memory read -MIME-Version: 1.0 -Content-Type: text/plain; charset=UTF-8 -Content-Transfer-Encoding: 8bit - -This partially reverts 7aba6e53bbfeedaacd95bbaa5e0c5e325a3e6a8d, which -results in “event” being inappropriately freed before a “goto” statement -is executed and the value stored in “g_event_selected” is read. ---- - src/gui-wizard-gtk/wizard.c | 6 +++++- - 1 file changed, 5 insertions(+), 1 deletion(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index a4d7caa0..3e69a513 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -2635,7 +2635,7 @@ static gint select_next_page_no(gint current_page_no) - - log_info("%s: Looking for next event to process", __func__); - /* (note: this frees and sets to NULL g_event_selected) */ -- g_autofree char *event = setup_next_processed_event(&g_auto_event_list); -+ char *event = setup_next_processed_event(&g_auto_event_list); - if (!event) - { - current_page_no = PAGENO_EVENT_PROGRESS - 1; -@@ -2644,6 +2644,8 @@ static gint select_next_page_no(gint current_page_no) - - if (!get_sensitive_data_permission(event)) - { -+ free(event); -+ - cancel_processing(g_lbl_event_log, /* default message */ NULL, TERMINATE_NOFLAGS); - current_page_no = PAGENO_EVENT_PROGRESS - 1; - goto again; -@@ -2659,6 +2661,8 @@ static gint select_next_page_no(gint current_page_no) - - if (libreport_get_global_stop_on_not_reportable()) - { -+ free(event); -+ - cancel_processing(g_lbl_event_log, msg, TERMINATE_NOFLAGS); - current_page_no = PAGENO_EVENT_PROGRESS - 1; - goto again; --- -2.28.0 - diff --git a/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch b/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch deleted file mode 100644 index c000d30..0000000 --- a/0003-gui-wizard-gtk-Fix-a-double-free-condition.patch +++ /dev/null @@ -1,53 +0,0 @@ -From ce557c0fb309184a9a8fc38a76404324d94803b0 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Fri, 25 Sep 2020 19:23:51 +0200 -Subject: [PATCH] gui-wizard-gtk: Fix a double free condition - -We may only free `log_msg` in `update_command_run_log()` if it is the -result of the call to `g_strdup_printf()`, otherwise the caller takes -care of it. - -Partially reverts 7aba6e53. - -Resolves rhbz#1882319 ---- - src/gui-wizard-gtk/wizard.c | 12 +++++++++--- - 1 file changed, 9 insertions(+), 3 deletions(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index 8a4486f2..a532c633 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -1385,7 +1385,7 @@ static void cancel_processing(GtkLabel *status_label, const char *message, int t - pango_attr_list_unref(list); - } - --static void update_command_run_log(const char* message, struct analyze_event_data *evd) -+static void update_command_run_log(char *message, struct analyze_event_data *evd) - { - const bool it_is_a_dot = (message[0] == '.' && message[1] == '\0'); - -@@ -1393,12 +1393,18 @@ static void update_command_run_log(const char* message, struct analyze_event_dat - gtk_label_set_text(g_lbl_event_log, message); - - /* Don't append new line behind single dot */ -- g_autofree const char *log_msg = it_is_a_dot ? message : g_strdup_printf("%s\n", message); -+ char *log_msg = it_is_a_dot ? message : g_strdup_printf("%s\n", message); - append_to_textview(g_tv_event_log, log_msg); - save_to_event_log(evd, log_msg); -+ -+ if (log_msg != message) -+ { -+ /* We assume message is managed by the caller. */ -+ free(log_msg); -+ } - } - --static void run_event_gtk_error(const char *error_line, void *param) -+static void run_event_gtk_error(char *error_line, void *param) - { - update_command_run_log(error_line, (struct analyze_event_data *)param); - } --- -2.26.2 - diff --git a/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch b/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch deleted file mode 100644 index 2b38feb..0000000 --- a/0004-gui-wizard-gtk-Fix-a-segfault-and-memory-leak.patch +++ /dev/null @@ -1,66 +0,0 @@ -From cb2ab9a8b2e1dbc89e100aedc432c29a16246e84 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Sun, 27 Sep 2020 20:45:32 +0200 -Subject: [PATCH] gui-wizard-gtk: Fix a segfault and memory leak - -Only `arg[1]` has to be freed in `tv_details_row_activated()`, as -`arg[0]` is allocated statically. - -In `search_item_to_list_store_item()`, `tmp` gets overwritten with a new -value for every call to `gtk_text_buffer_get_text()`, so we need to free -the allocated memory continuously. - -Partially reverts 7aba6e53. - -Resolves rhbz#1882950 ---- - src/gui-wizard-gtk/wizard.c | 9 +++++++-- - 1 file changed, 7 insertions(+), 2 deletions(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index a532c633..775b709f 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -707,7 +707,7 @@ static void tv_details_row_activated( - return; - - gint exitcode; -- g_autofree gchar *arg[3]; -+ gchar *arg[3]; - arg[0] = (char *) "xdg-open"; - arg[1] = g_build_filename(g_dump_dir_name ? g_dump_dir_name : "", item_name, NULL); - arg[2] = NULL; -@@ -751,6 +751,8 @@ static void tv_details_row_activated( - gtk_widget_destroy(scrolled); - gtk_widget_destroy(dialog); - } -+ -+ g_free(arg[1]); - } - - /* static gboolean tv_details_select_cursor_row( -@@ -2126,17 +2128,20 @@ static void search_item_to_list_store_item(GtkListStore *store, GtkTreeIter *new - gtk_text_iter_backward_char(end); - } - -- g_autofree gchar *tmp = gtk_text_buffer_get_text(word->buffer, beg, &(word->start), -+ gchar *tmp = gtk_text_buffer_get_text(word->buffer, beg, &(word->start), - /*don't include hidden chars*/FALSE); - g_autofree gchar *prefix = g_markup_escape_text(tmp, /*NULL terminated string*/-1); -+ g_free(tmp); - - tmp = gtk_text_buffer_get_text(word->buffer, &(word->start), &(word->end), - /*don't include hidden chars*/FALSE); - g_autofree gchar *text = g_markup_escape_text(tmp, /*NULL terminated string*/-1); -+ g_free(tmp); - - tmp = gtk_text_buffer_get_text(word->buffer, &(word->end), end, - /*don't include hidden chars*/FALSE); - g_autofree gchar *suffix = g_markup_escape_text(tmp, /*NULL terminated string*/-1); -+ g_clear_pointer(&tmp, g_free); - - char *content = g_strdup_printf("%s%s%s", prefix, text, suffix); - --- -2.26.2 - diff --git a/0005-gui-wizard-gtk-Fix-segfault.patch b/0005-gui-wizard-gtk-Fix-segfault.patch deleted file mode 100644 index 29d65ae..0000000 --- a/0005-gui-wizard-gtk-Fix-segfault.patch +++ /dev/null @@ -1,66 +0,0 @@ -From 1a22f30187163ce288b14e55a80539353a38b7be Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Tue, 29 Sep 2020 14:16:00 +0200 -Subject: [PATCH 1/2] gui-wizard-gtk: Fix segfault - -Since show_error_as_msgbox() is specified as the custom logging handler -(via setting libreport_g_custom_logger), it will get called if an error -occurs in libreport_save_user_settings(). However, at that point, -g_wnd_assistant has already been destroyed, which leads to an invalid -read in show_error_as_msgbox(). - -This change unsets the custom logging handler after the GUI is destroyed -and adds an assertion in show_error_as_msgbox() checking that -g_wnd_assistant is not a null pointer. - -Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1883337 ---- - src/gui-wizard-gtk/main.c | 6 ++++-- - src/gui-wizard-gtk/wizard.c | 2 ++ - 2 files changed, 6 insertions(+), 2 deletions(-) - -diff --git a/src/gui-wizard-gtk/main.c b/src/gui-wizard-gtk/main.c -index e111948c..f094c5fb 100644 ---- a/src/gui-wizard-gtk/main.c -+++ b/src/gui-wizard-gtk/main.c -@@ -125,6 +125,7 @@ int main(int argc, char **argv) - /* List of events specified on the command line. */ - GList *user_event_list = NULL; - const char *prgname = "abrt"; -+ int ret = 0; - abrt_init(argv); - - /* I18n */ -@@ -217,13 +218,14 @@ int main(int argc, char **argv) - g_signal_connect(app, "startup", G_CALLBACK(startup_wizard), NULL); - - /* Enter main loop */ -- g_application_run(G_APPLICATION(app), argc, argv); -+ ret = g_application_run(G_APPLICATION(app), argc, argv); - g_object_unref(app); -+ libreport_g_custom_logger = NULL; - - if (opts & OPT_d) - delete_dump_dir_possibly_using_abrtd(g_dump_dir_name); - - libreport_save_user_settings(); - -- return 0; -+ return ret; - } -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index 775b709f..c4a0b4c0 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -360,6 +360,8 @@ struct dump_dir *wizard_open_directory_for_writing(const char *dump_dir_name) - - void show_error_as_msgbox(const char *msg) - { -+ g_return_if_fail(g_wnd_assistant != NULL); -+ - GtkWidget *dialog = gtk_message_dialog_new(GTK_WINDOW(g_wnd_assistant), - GTK_DIALOG_DESTROY_WITH_PARENT, - GTK_MESSAGE_WARNING, --- -2.26.2 - diff --git a/0006-event_config-Null-autofree-pointers-before-returning.patch b/0006-event_config-Null-autofree-pointers-before-returning.patch deleted file mode 100644 index ed3a26f..0000000 --- a/0006-event_config-Null-autofree-pointers-before-returning.patch +++ /dev/null @@ -1,40 +0,0 @@ -From 41b6477bdeaa82c647db2f1c2ba1132c77b365ed Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Tue, 29 Sep 2020 14:43:15 +0200 -Subject: [PATCH 2/2] event_config: Null autofree pointers before returning - -The pointers to strings in the function check_problem_rating_usability() -need to be nullified before the function returns as they are declared -for auto-cleanup. - -This change fixes a double-free condition in which the returned strings -were attempted to be freed again in the caller, -is_backtrace_rating_usable(). - -Bug was introduced in 05e9c9273. - -Resolves rhbz#1883410 ---- - src/lib/event_config.c | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - -diff --git a/src/lib/event_config.c b/src/lib/event_config.c -index c8053b7c..01e91efe 100644 ---- a/src/lib/event_config.c -+++ b/src/lib/event_config.c -@@ -541,10 +541,10 @@ bool check_problem_rating_usability(const event_config_t *cfg, - - finish: - if (description) -- *description = tmp_desc; -+ *description = g_steal_pointer(&tmp_desc); - - if (detail) -- *detail = tmp_detail; -+ *detail = g_steal_pointer(&tmp_detail); - - return result; - } --- -2.26.2 - diff --git a/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch b/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch deleted file mode 100644 index b28d183..0000000 --- a/0007-gui-wizard-gtk-Don-t-autofree-URL-string.patch +++ /dev/null @@ -1,34 +0,0 @@ -From 9b6d40905c21b476c58e9f9a908ddb32a0a56a18 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Tue, 29 Sep 2020 19:14:05 +0200 -Subject: [PATCH] gui-wizard-gtk: Don't autofree URL string - -g_object_set_data() does not (and cannot) copy the data passed to it, so -once url is freed, a subsequent access to the 'url' tag leads to an -invalid read and segfault. - -Bug was introduced in df386b097. - -Resolves rhbz#1882328 ---- - src/gui-wizard-gtk/wizard.c | 4 ++-- - 1 file changed, 2 insertions(+), 2 deletions(-) - -diff --git a/src/gui-wizard-gtk/wizard.c b/src/gui-wizard-gtk/wizard.c -index 0af19587..ba1998df 100644 ---- a/src/gui-wizard-gtk/wizard.c -+++ b/src/gui-wizard-gtk/wizard.c -@@ -462,8 +462,8 @@ static void append_to_textview(GtkTextView *tv, const char *str) - GtkTextTag *tag; - tag = gtk_text_buffer_create_tag(tb, NULL, "foreground", "blue", - "underline", PANGO_UNDERLINE_SINGLE, NULL); -- g_autofree char *url = g_strndup(t->start, t->len); -- g_object_set_data(G_OBJECT(tag), "url", url); -+ char *url = g_strndup(t->start, t->len); -+ g_object_set_data_full(G_OBJECT(tag), "url", url, g_free); - - gtk_text_buffer_insert_with_tags(tb, &text_iter, url, -1, tag, NULL); - --- -2.26.2 - diff --git a/0008-rhbz-Fix-a-double-free-condition.patch b/0008-rhbz-Fix-a-double-free-condition.patch deleted file mode 100644 index 4180663..0000000 --- a/0008-rhbz-Fix-a-double-free-condition.patch +++ /dev/null @@ -1,48 +0,0 @@ -From 9cdf0f9123ee39c7cb32a276371b2fd95f0df5ac Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Mon, 2 Nov 2020 11:45:23 +0100 -Subject: [PATCH] rhbz: Fix a double-free condition - -The `cc` string must not be freed after the variable goes out of scope -since it's appended to `cc_list`. (`g_list_append()` does not copy its -input.) We only need to free the last string in the loop, which is an -empty string. - -The bug was introduced in 7aba6e53. - -Resolves rhbz#1893595 ---- - src/plugins/rhbz.c | 8 +++++--- - 1 file changed, 5 insertions(+), 3 deletions(-) - -diff --git a/src/plugins/rhbz.c b/src/plugins/rhbz.c -index 8a2ded79..e0d7a091 100644 ---- a/src/plugins/rhbz.c -+++ b/src/plugins/rhbz.c -@@ -406,18 +406,20 @@ GList *rhbz_bug_cc(xmlrpc_value* result_xml) - if (!item) - continue; - -- g_autofree const char* cc = NULL; -- xmlrpc_read_string(&env, item, &cc); -+ char *cc = NULL; -+ xmlrpc_read_string(&env, item, (const char **)&cc); - xmlrpc_DECREF(item); - if (env.fault_occurred) - abrt_xmlrpc_die(&env); - - if (*cc != '\0') - { -- cc_list = g_list_append(cc_list, (char*)cc); -+ cc_list = g_list_append(cc_list, cc); - log_debug("member on cc is %s", cc); - continue; - } -+ -+ free(cc); - } - xmlrpc_DECREF(cc_member); - return cc_list; --- -2.26.2 - diff --git a/0009-client-python-Add-getter-for-package-count-to-downlo.patch b/0009-client-python-Add-getter-for-package-count-to-downlo.patch deleted file mode 100644 index 6fa6ee4..0000000 --- a/0009-client-python-Add-getter-for-package-count-to-downlo.patch +++ /dev/null @@ -1,28 +0,0 @@ -From cbb6b43038f0d88b28197ba905ba9324c0602945 Mon Sep 17 00:00:00 2001 -From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= -Date: Thu, 3 Sep 2020 15:05:23 +0200 -Subject: [PATCH] client-python: Add getter for package count to downloader - -Add a new method get_package_count() to the DebugInfoDownload class -which returns the number of packages that will be downloaded. ---- - src/client-python/reportclient/debuginfo.py | 3 +++ - 1 file changed, 3 insertions(+) - -diff --git a/src/client-python/reportclient/debuginfo.py b/src/client-python/reportclient/debuginfo.py -index cb318e8a..eeb2be30 100644 ---- a/src/client-python/reportclient/debuginfo.py -+++ b/src/client-python/reportclient/debuginfo.py -@@ -242,6 +242,9 @@ class DebugInfoDownload(object): - def get_install_size(self): - return self.installed_size - -+ def get_package_count(self): -+ return len(self.package_files_dict) -+ - def mute_stdout(self): - """ - Links sys.stdout with /dev/null and saves the old stdout --- -2.26.2 - diff --git a/libreport.spec b/libreport.spec index 8f8e22f..f633be2 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,10 +15,14 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.15.2 -Release: 10%{?dist} +Release: 11%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz + +# https://bugzilla.redhat.com/show_bug.cgi?id=2019402 +Patch0: 0001-tests-Don-t-use-deprecated-assertEquals.patch + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -652,6 +656,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jan 13 2022 Matěj Grabovský - 2.15.2-11 +- Backport patch for building with Python 3.11 + (https://bugzilla.redhat.com/show_bug.cgi?id=2019402) + * Wed Jan 12 2022 Matěj Grabovský - 2.15.2-10 - Bump for rebuild From 36ac44e99e5ec78e7374ba905ecfbe3c1c6ccb92 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 13 Jan 2022 13:16:48 +0100 Subject: [PATCH 092/133] Fix %autosetup call Strip one path component in patches. --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index f633be2..567f4f7 100644 --- a/libreport.spec +++ b/libreport.spec @@ -281,7 +281,7 @@ data over ftp/scp... %endif %prep -%autosetup +%autosetup -p1 %build ./autogen.sh From dfa3ff2590da210b28f0fe5bbccc0da980087181 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Mon, 17 Jan 2022 19:00:22 +0100 Subject: [PATCH 093/133] New upstream release 2.16.0 --- .gitignore | 1 + ...ts-Don-t-use-deprecated-assertEquals.patch | 49 ------------------- libreport.spec | 23 ++++++--- sources | 2 +- 4 files changed, 17 insertions(+), 58 deletions(-) delete mode 100644 0001-tests-Don-t-use-deprecated-assertEquals.patch diff --git a/.gitignore b/.gitignore index 88f39e4..0add075 100644 --- a/.gitignore +++ b/.gitignore @@ -15,3 +15,4 @@ /libreport-2.14.0.tar.gz /libreport-2.15.1.tar.gz /libreport-2.15.2.tar.gz +/libreport-2.16.0.tar.gz diff --git a/0001-tests-Don-t-use-deprecated-assertEquals.patch b/0001-tests-Don-t-use-deprecated-assertEquals.patch deleted file mode 100644 index 44514fb..0000000 --- a/0001-tests-Don-t-use-deprecated-assertEquals.patch +++ /dev/null @@ -1,49 +0,0 @@ -From 976d3ffcee73a5d832cb757f2dc39aea21abd2f2 Mon Sep 17 00:00:00 2001 -From: Michal Fabik -Date: Thu, 4 Nov 2021 22:14:08 +0100 -Subject: [PATCH] tests: Don't use deprecated assertEquals - -unittest.assertEquals was deprecated in Python 3.2 and will no longer be -supported in 3.11 - -Resolves: -https://bugzilla.redhat.com/show_bug.cgi?id=2019402 ---- - tests/client_python.at | 10 +++++----- - 1 file changed, 5 insertions(+), 5 deletions(-) - -diff --git a/tests/client_python.at b/tests/client_python.at -index d026ed70..75ec1890 100644 ---- a/tests/client_python.at -+++ b/tests/client_python.at -@@ -35,22 +35,22 @@ class TestReportClientVerbose(unittest.TestCase): - del sys.modules["reportclient"] - - def test_default(self): -- self.assertEquals(self.reportclient.verbose, 0) -+ self.assertEqual(self.reportclient.verbose, 0) - - def test_assign(self): - self.reportclient.set_verbosity(1) -- self.assertEquals(self.reportclient.verbose, 1) -- self.assertEquals(os.environ["ABRT_VERBOSE"], "1") -+ self.assertEqual(self.reportclient.verbose, 1) -+ self.assertEqual(os.environ["ABRT_VERBOSE"], "1") - - def test_load_from_environ(self): - os.environ["ABRT_VERBOSE"] = "2" - reload(self.reportclient) -- self.assertEquals(self.reportclient.verbose, 2) -+ self.assertEqual(self.reportclient.verbose, 2) - - def test_recover_from_invalid_environ(self): - os.environ["ABRT_VERBOSE"] = "foo" - reload(self.reportclient) -- self.assertEquals(self.reportclient.verbose, 0) -+ self.assertEqual(self.reportclient.verbose, 0) - - - if __name__ == "__main__": --- -2.31.1 - diff --git a/libreport.spec b/libreport.spec index 567f4f7..bbfe1f8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,15 +14,12 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.15.2 -Release: 11%{?dist} +Version: 2.16.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -# https://bugzilla.redhat.com/show_bug.cgi?id=2019402 -Patch0: 0001-tests-Don-t-use-deprecated-assertEquals.patch - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -37,8 +34,7 @@ BuildRequires: texinfo BuildRequires: asciidoc BuildRequires: xmlto BuildRequires: newt-devel -BuildRequires: libproxy-devel -BuildRequires: satyr-devel >= 0.24 +BuildRequires: satyr-devel >= 0.38 BuildRequires: glib2-devel >= %{glib_ver} BuildRequires: git-core @@ -56,7 +52,7 @@ BuildRequires: augeas-devel BuildRequires: augeas BuildRequires: libarchive-devel Requires: libreport-filesystem = %{version}-%{release} -Requires: satyr%{?_isa} >= 0.24 +Requires: satyr%{?_isa} >= 0.38 Requires: glib2%{?_isa} >= %{glib_ver} Requires: libarchive%{?_isa} @@ -656,6 +652,17 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jan 17 2022 Matěj Grabovský - 2.16.0-1 +- Bump satyr dependency to 0.38 +- Bump libreport library revision to 2:1:0 +- Drop build-time dependency on libproxy-devel +- Drop last reference to global_uuid file +- Don't use deprecated assertEquals() in tests +- Add DEBUGINFOD_URLS environment variable to ignored_words +- rhbz: Retry XML-RPC calls when uploading attachments +- rhbz: Be a little bit more defensive when working with subcomponents +- Update translations + * Thu Jan 13 2022 Matěj Grabovský - 2.15.2-11 - Backport patch for building with Python 3.11 (https://bugzilla.redhat.com/show_bug.cgi?id=2019402) diff --git a/sources b/sources index c9ba4ce..c288796 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.15.2.tar.gz) = c98003325fa70d674177c9f602a7f121815a9675701ee780ad8908ed69862f2c69be65c7483fd3f017ba299dda51ba304f0908c771c9d97cb5bba057e3a9c5dc +SHA512 (libreport-2.16.0.tar.gz) = cbb456bb63b92a255fecb87191160c2e515b4434cbaaa9404fb69f4f78421fe98c4057969f4b6b99e1b52e815d83c483bdbbe606a4bd2e34cf5268769e7bd40f From 246c24ec2f11a21e5e982774b0c5fe88fb034ce7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 19 Jan 2022 12:27:45 +0100 Subject: [PATCH 094/133] tests: Add one more conflicting package --- tests/smoke.fmf | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/smoke.fmf b/tests/smoke.fmf index 150d7b0..e872709 100644 --- a/tests/smoke.fmf +++ b/tests/smoke.fmf @@ -4,6 +4,7 @@ prepare: # Do not attempt to install conflicting subpackages. exclude: - abrt-atomic + - abrt-java-connector-container - python3-abrt-container-addon # Prerequisite for smoke testing liblibreport. package: From c57e81043d978b562c9d37d6aacdd4c3fef0d5d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Wed, 19 Jan 2022 14:26:10 +0100 Subject: [PATCH 095/133] Rebuild for testing --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index bbfe1f8..9503ebf 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.16.0 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Jan 19 2022 Matěj Grabovský - 2.16.0-2 +- Rebuild for testing + * Mon Jan 17 2022 Matěj Grabovský - 2.16.0-1 - Bump satyr dependency to 0.38 - Bump libreport library revision to 2:1:0 From 239f7c7dbeb7e136588f16b8c63f592bdaa08ff8 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 20 Jan 2022 17:07:28 +0000 Subject: [PATCH 096/133] - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 9503ebf..57e01a6 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.16.0 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jan 20 2022 Fedora Release Engineering - 2.16.0-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild + * Wed Jan 19 2022 Matěj Grabovský - 2.16.0-2 - Rebuild for testing From c59a73626cf6fa64f79a762dde304d5286d54e48 Mon Sep 17 00:00:00 2001 From: Michal Srb Date: Mon, 21 Feb 2022 18:50:36 +0100 Subject: [PATCH 097/133] Update to libreport 2.17 What's new: * [reporter-bugzilla] Use API key for authentication Signed-off-by: Michal Srb --- .gitignore | 1 + libreport.spec | 7 +++++-- sources | 1 + 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 0add075..69bd8e0 100644 --- a/.gitignore +++ b/.gitignore @@ -16,3 +16,4 @@ /libreport-2.15.1.tar.gz /libreport-2.15.2.tar.gz /libreport-2.16.0.tar.gz +/libreport-2.17.0.tar.gz diff --git a/libreport.spec b/libreport.spec index 57e01a6..4b11b15 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.16.0 -Release: 3%{?dist} +Version: 2.17.0 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -652,6 +652,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Feb 21 2022 Michal Srb - 2.17.0-1 +- [reporter-bugzilla] Use API key for authentication + * Thu Jan 20 2022 Fedora Release Engineering - 2.16.0-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild diff --git a/sources b/sources index c288796..a783223 100644 --- a/sources +++ b/sources @@ -1 +1,2 @@ SHA512 (libreport-2.16.0.tar.gz) = cbb456bb63b92a255fecb87191160c2e515b4434cbaaa9404fb69f4f78421fe98c4057969f4b6b99e1b52e815d83c483bdbbe606a4bd2e34cf5268769e7bd40f +SHA512 (libreport-2.17.0.tar.gz) = 587f1d4d57845c9f52086c6f2e6c5b9f60cdb4b087719e392286c761b2e86163de72c82aa7dadef0e28ed9b29eec61faa3bcb34a834b9442121273a1fd9da399 From 1daa8aeacbf87d99ae43a1313b6bdfb5de7bf782 Mon Sep 17 00:00:00 2001 From: Packit Service Date: Thu, 10 Mar 2022 17:57:08 +0000 Subject: [PATCH 098/133] [packit] 2.17.1 upstream release Upstream tag: 2.17.1 Upstream commit: 8d6db8b5 Signed-off-by: Packit Service --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 14 +++++++++++--- sources | 3 +-- 4 files changed, 14 insertions(+), 6 deletions(-) diff --git a/.gitignore b/.gitignore index 69bd8e0..6c2fa61 100644 --- a/.gitignore +++ b/.gitignore @@ -17,3 +17,4 @@ /libreport-2.15.2.tar.gz /libreport-2.16.0.tar.gz /libreport-2.17.0.tar.gz +/libreport-2.17.1.tar.gz diff --git a/README.packit b/README.packit index 8ede8cd..5edb610 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.31.0. +The file was generated using packit 0.46.1.dev39+g9d68890. diff --git a/libreport.spec b/libreport.spec index 4b11b15..c9b1908 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,12 +14,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.0 +Version: 2.17.1 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -277,7 +276,7 @@ data over ftp/scp... %endif %prep -%autosetup -p1 +%autosetup %build ./autogen.sh @@ -652,6 +651,15 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Mar 10 2022 Packit Service - 2.17.1-1 +- Release version 2.17.1 (Michal Srb) +- reporter-bugzilla: send API key in HTTP header (Michal Srb) +- tito: Use custom tagger that updates changelog (Matěj Grabovský) +- changelog: Fix link to release diff (Matěj Grabovský) +- reporter-bugzilla: Fix APIKey name (Michal Fabik) +- Update translations (mgrabovsky) +- Add missing va_end (Michal Židek) + * Mon Feb 21 2022 Michal Srb - 2.17.0-1 - [reporter-bugzilla] Use API key for authentication diff --git a/sources b/sources index a783223..493cade 100644 --- a/sources +++ b/sources @@ -1,2 +1 @@ -SHA512 (libreport-2.16.0.tar.gz) = cbb456bb63b92a255fecb87191160c2e515b4434cbaaa9404fb69f4f78421fe98c4057969f4b6b99e1b52e815d83c483bdbbe606a4bd2e34cf5268769e7bd40f -SHA512 (libreport-2.17.0.tar.gz) = 587f1d4d57845c9f52086c6f2e6c5b9f60cdb4b087719e392286c761b2e86163de72c82aa7dadef0e28ed9b29eec61faa3bcb34a834b9442121273a1fd9da399 +SHA512 (libreport-2.17.1.tar.gz) = 35c5031e0a361040153ea45a249613b9f2d2bb38191c6375b197cb797be153f1a4b46480dbfa5fcdd9c5c00b075f84997f6da70c3b59b8b8251fd29a7180bd9b From 5c6a8ff0a64c001e9a30e1559223e4f6bbe0610f Mon Sep 17 00:00:00 2001 From: Python Maint Date: Mon, 13 Jun 2022 16:53:28 +0200 Subject: [PATCH 099/133] Rebuilt for Python 3.11 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index c9b1908..ff681b5 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.1 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -651,6 +651,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jun 13 2022 Python Maint - 2.17.1-2 +- Rebuilt for Python 3.11 + * Thu Mar 10 2022 Packit Service - 2.17.1-1 - Release version 2.17.1 (Michal Srb) - reporter-bugzilla: send API key in HTTP header (Michal Srb) From a60f2d52f55372092ebad898f6ac7d568059b07a Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 21 Jul 2022 18:50:23 +0000 Subject: [PATCH 100/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index ff681b5..ce1876a 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.1 -Release: 2%{?dist} +Release: 3%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -651,6 +651,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jul 21 2022 Fedora Release Engineering - 2.17.1-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild + * Mon Jun 13 2022 Python Maint - 2.17.1-2 - Rebuilt for Python 3.11 From c7bd2e9b60acfaa62ebb6233b75bcd1becd18da4 Mon Sep 17 00:00:00 2001 From: Packit Date: Thu, 18 Aug 2022 09:30:11 +0000 Subject: [PATCH 101/133] [packit] 2.17.2 upstream release Upstream tag: 2.17.2 Upstream commit: ad258430 Signed-off-by: Packit --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 37 +++++++++++++++++++++++++++++++++++-- sources | 2 +- 4 files changed, 38 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 6c2fa61..27735cb 100644 --- a/.gitignore +++ b/.gitignore @@ -18,3 +18,4 @@ /libreport-2.16.0.tar.gz /libreport-2.17.0.tar.gz /libreport-2.17.1.tar.gz +/libreport-2.17.2.tar.gz diff --git a/README.packit b/README.packit index 5edb610..d360133 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.46.1.dev39+g9d68890. +The file was generated using packit 0.57.1.dev6+g0146236. diff --git a/libreport.spec b/libreport.spec index ce1876a..218c820 100644 --- a/libreport.spec +++ b/libreport.spec @@ -12,10 +12,14 @@ %define glib_ver 2.43.4 +%if "x%{?rhbz_product_version}" == "x" + %define rhbz_product_version %(source /etc/os-release; echo ${REDHAT_BUGZILLA_PRODUCT_VERSION}) +%endif + Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.1 -Release: 3%{?dist} +Version: 2.17.2 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -188,6 +192,14 @@ email address. Summary: %{name}'s bugzilla plugin Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} +Requires: python3-libreport = %{version}-%{release} +%if "%{rhbz_product_version}" == "rawhide" +Requires: python3-satyr +Suggests: python3-pytest +Suggests: python3-vcrpy +%endif + + %description plugin-bugzilla Plugin to report bugs into the bugzilla. @@ -458,6 +470,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %files -n python3-libreport %{python3_sitearch}/report/ %{python3_sitearch}/reportclient/ +%{python3_sitearch}/reportclient/internal/ %files cli %{_bindir}/report-cli @@ -550,6 +563,13 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/bugzilla_formatdup_analyzer_libreport.conf.5.* %{_mandir}/man5/bugzilla_format_kernel.conf.5.* %{_bindir}/reporter-bugzilla +%{_bindir}/reporter-bugzilla-python + +%post plugin-bugzilla +%if "%{rhbz_product_version}" == "rawhide" + mv %{_bindir}/reporter-bugzilla-python %{_bindir}/reporter-bugzilla +%endif + %endif %files plugin-mantisbt @@ -651,6 +671,19 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Aug 18 2022 Packit - 2.17.2-1 +- Release version 2.17.2 (Michal Fabik) +- reporter_bugzilla.py: Build, install (Michal Fabik) +- reporter_bugzilla.py: Add tests (Michal Fabik) +- reporter_bugzilla.py: Initial commit (Michal Fabik) +- Update translations (mgrabovsky) +- abrt_xmlrpc: Don't warn about discarded const (Michal Fabik) +- Update translations (mgrabovsky) +- Update translations (mgrabovsky) +- Use conventional lseek arg order (Michal Fabik) +- Update translations (mgrabovsky) +- ignored_words: Ignore more debuginfod URLs (Matěj Grabovský) + * Thu Jul 21 2022 Fedora Release Engineering - 2.17.1-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild diff --git a/sources b/sources index 493cade..ce5eb95 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.1.tar.gz) = 35c5031e0a361040153ea45a249613b9f2d2bb38191c6375b197cb797be153f1a4b46480dbfa5fcdd9c5c00b075f84997f6da70c3b59b8b8251fd29a7180bd9b +SHA512 (libreport-2.17.2.tar.gz) = 66ed414deb630b2af4fbb2dbc01b9026173d53b6342b4e92f9ea632dd01fbc355ce4fb28f67f1ae8ed5eb12f03a7b1ef6516aafc943c100a5b8452ce1c51739f From df1c46211155c4a5ba9a7d723c2faec61ba85794 Mon Sep 17 00:00:00 2001 From: Packit Date: Mon, 12 Sep 2022 12:58:32 +0000 Subject: [PATCH 102/133] [packit] 2.17.3 upstream release Upstream tag: 2.17.3 Upstream commit: 10f44c0e Signed-off-by: Packit --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 16 +++++++++++++--- sources | 2 +- 4 files changed, 16 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 27735cb..3aac0da 100644 --- a/.gitignore +++ b/.gitignore @@ -19,3 +19,4 @@ /libreport-2.17.0.tar.gz /libreport-2.17.1.tar.gz /libreport-2.17.2.tar.gz +/libreport-2.17.3.tar.gz diff --git a/README.packit b/README.packit index d360133..0070ced 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.57.1.dev6+g0146236. +The file was generated using packit 0.59.1.dev24+g41a74ae. diff --git a/libreport.spec b/libreport.spec index 218c820..93f053c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -18,7 +18,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.2 +Version: 2.17.3 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -470,7 +470,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %files -n python3-libreport %{python3_sitearch}/report/ %{python3_sitearch}/reportclient/ -%{python3_sitearch}/reportclient/internal/ %files cli %{_bindir}/report-cli @@ -637,6 +636,7 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/report_fedora.conf.5.* %endif +%if %{with bugzilla} %if 0%{?rhel} && ! 0%{?eln} %files rhel-bugzilla %{_datadir}/%{name}/workflows/workflow_RHELBugzillaCCpp.xml @@ -654,7 +654,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_datadir}/%{name}/workflows/workflow_AnacondaRHELBugzilla.xml %endif -%if %{with bugzilla} %files anaconda %if 0%{?fedora} || 0%{?eln} %{_datadir}/%{name}/workflows/workflow_AnacondaFedora.xml @@ -671,6 +670,17 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Sep 12 2022 Packit - 2.17.3-1 +- Release version 2.17.3 (Michal Fabik) +- Update changelog (Michal Fabik) +- Run autoupdate to get rid of obsolete/deprecated macros (Michal Fabik) +- Makefile: Move README.md to EXTRA_DIST (Michal Fabik) +- Don't build rhel-bugzilla --without-bugzilla (Michal Fabik) +- doc: Make anaconda_event.conf depend on BZ (Michal Fabik) +- Fix build --without-bugzilla (Michal Fabik) +- spec: Don't list files twice (Michal Fabik) +- Update translations (mgrabovsky) + * Thu Aug 18 2022 Packit - 2.17.2-1 - Release version 2.17.2 (Michal Fabik) - reporter_bugzilla.py: Build, install (Michal Fabik) diff --git a/sources b/sources index ce5eb95..41b745f 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.2.tar.gz) = 66ed414deb630b2af4fbb2dbc01b9026173d53b6342b4e92f9ea632dd01fbc355ce4fb28f67f1ae8ed5eb12f03a7b1ef6516aafc943c100a5b8452ce1c51739f +SHA512 (libreport-2.17.3.tar.gz) = 2ffc800772fcc6be78d1acb33f132e532d5a2d074531df6dfff98d0ed48939ac0e57874e55d175a4797082b7acd598b6e1a14e5f7bbe3b8ce0c379e2440628bc From 721c9858b9c52eb639ba9b33ee41b2f3483b397a Mon Sep 17 00:00:00 2001 From: Michal Srb Date: Wed, 14 Sep 2022 08:10:29 +0200 Subject: [PATCH 103/133] Do not list generic tests in gating.yaml These tests are enabled for Rawhide and thus builds can get stuck in gating for non-Rawhide releases. Signed-off-by: Michal Srb --- gating.yaml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gating.yaml b/gating.yaml index 9ca798d..f075ad7 100644 --- a/gating.yaml +++ b/gating.yaml @@ -4,9 +4,6 @@ product_versions: decision_context: bodhi_update_push_testing subject_type: koji_build rules: - - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpmdeplint.functional} - - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpminspect.static-analysis} - - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.installability.functional} - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional} --- !Policy @@ -15,8 +12,4 @@ product_versions: decision_context: bodhi_update_push_stable subject_type: koji_build rules: - - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpmdeplint.functional} - - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.rpminspect.static-analysis} - - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.installability.functional} - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional} - From 9c8cf1e0407eddffa8bbe05ea1d130074c51954a Mon Sep 17 00:00:00 2001 From: Packit Date: Wed, 14 Sep 2022 15:04:21 +0000 Subject: [PATCH 104/133] [packit] 2.17.4 upstream release Upstream tag: 2.17.4 Upstream commit: ed5b9a41 Signed-off-by: Packit --- .gitignore | 1 + libreport.spec | 13 ++++++++++++- sources | 2 +- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index 3aac0da..24df3b8 100644 --- a/.gitignore +++ b/.gitignore @@ -20,3 +20,4 @@ /libreport-2.17.1.tar.gz /libreport-2.17.2.tar.gz /libreport-2.17.3.tar.gz +/libreport-2.17.4.tar.gz diff --git a/libreport.spec b/libreport.spec index 93f053c..e4546f4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -18,7 +18,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.3 +Version: 2.17.4 Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ @@ -670,6 +670,17 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Wed Sep 14 2022 Packit - 2.17.4-1 +- Release version 2.17.4 (Michal Fabik) +- Update changelog (Michal Fabik) +- reporter_bugzilla.py: Don't ask for API key if we already have it (Michal Srb) +- internal/bz_connection.py: Fix "TypeError: 'builtin_function_or_method' object is not subscriptable" (Michal Srb) +- reporter_bugzilla.py: Fix condition (Michal Srb) +- internal/reported_to.py: Prevent possible ValueError if the line is for example empty (Michal Srb) +- reporter_bugzilla.py: Prevent possible KeyError exception (Michal Srb) +- reporter_bugzilla.py: Default value for `b_create_private` is False (Michal Srb) +- reporter_bugzilla.py: Prevent possible KeyError exception (Michal Srb) + * Mon Sep 12 2022 Packit - 2.17.3-1 - Release version 2.17.3 (Michal Fabik) - Update changelog (Michal Fabik) diff --git a/sources b/sources index 41b745f..08e0a4f 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.3.tar.gz) = 2ffc800772fcc6be78d1acb33f132e532d5a2d074531df6dfff98d0ed48939ac0e57874e55d175a4797082b7acd598b6e1a14e5f7bbe3b8ce0c379e2440628bc +SHA512 (libreport-2.17.4.tar.gz) = 71332661396e693ee469f029978df3d1bfc68a2a180913f120c765a5599c41aadcee17f58e428b9cc2a1b0fec565b4d4766169767dbca5141217ecd52051f111 From 0838e282099e65d55e834fbff46a8536aa90acfc Mon Sep 17 00:00:00 2001 From: Packit Date: Mon, 24 Oct 2022 15:22:23 +0000 Subject: [PATCH 105/133] [packit] 2.17.5 upstream release Upstream tag: 2.17.5 Upstream commit: a1aa4b91 Signed-off-by: Packit --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 12 ++++++++++-- sources | 2 +- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 24df3b8..4f163e3 100644 --- a/.gitignore +++ b/.gitignore @@ -21,3 +21,4 @@ /libreport-2.17.2.tar.gz /libreport-2.17.3.tar.gz /libreport-2.17.4.tar.gz +/libreport-2.17.5.tar.gz diff --git a/README.packit b/README.packit index 0070ced..e8857c6 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.59.1.dev24+g41a74ae. +The file was generated using packit 0.60.1.dev6+g9c9b2a8. diff --git a/libreport.spec b/libreport.spec index e4546f4..89d03fc 100644 --- a/libreport.spec +++ b/libreport.spec @@ -18,8 +18,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.4 -Release: 1%{?dist} +Version: 2.17.5 +Release: 1 License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -670,6 +670,14 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Oct 24 2022 Packit - 2.17.5-1 +- Release version 2.17.5 (Michal Srb) +- Update changelog (Michal Srb) +- dump_dir.py: check that the filename doesn't start with "/" (Michal Srb) +- dump_dir.py: Don't pass libreport flags to open() (Michal Srb) +- reporter-bugzilla: Fix exceptions (Michal Srb) +- Update translations (mgrabovsky) + * Wed Sep 14 2022 Packit - 2.17.4-1 - Release version 2.17.4 (Michal Fabik) - Update changelog (Michal Fabik) diff --git a/sources b/sources index 08e0a4f..f7c1ebd 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.4.tar.gz) = 71332661396e693ee469f029978df3d1bfc68a2a180913f120c765a5599c41aadcee17f58e428b9cc2a1b0fec565b4d4766169767dbca5141217ecd52051f111 +SHA512 (libreport-2.17.5.tar.gz) = 3bc676ec80d24c0103ac0dd5150acf13feed65e7d52b4a68168fb6ae788f8b580032a846fc1fa987dcfe5da5678476efd28dde37d81042531f4f27ee4f6da809 From c62536f4fcd71abc2a1618a5369cc5136770c74b Mon Sep 17 00:00:00 2001 From: Michal Srb Date: Mon, 24 Oct 2022 20:26:58 +0200 Subject: [PATCH 106/133] Fix dist-tag Signed-off-by: Michal Srb --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 89d03fc..a09d4ca 100644 --- a/libreport.spec +++ b/libreport.spec @@ -19,7 +19,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.5 -Release: 1 +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -670,6 +670,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Oct 24 2022 Michal Srb - 2.17.5-2 +- Fix dist-tag + * Mon Oct 24 2022 Packit - 2.17.5-1 - Release version 2.17.5 (Michal Srb) - Update changelog (Michal Srb) From 4b1f8f7ca80f5946d94fd45f3e0354530d5afe24 Mon Sep 17 00:00:00 2001 From: Packit Date: Sun, 6 Nov 2022 09:02:57 +0000 Subject: [PATCH 107/133] [packit] 2.17.6 upstream release Upstream tag: 2.17.6 Upstream commit: eb3e41be Signed-off-by: Packit --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 10 ++++++++-- sources | 2 +- 4 files changed, 11 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index 4f163e3..fd4d540 100644 --- a/.gitignore +++ b/.gitignore @@ -22,3 +22,4 @@ /libreport-2.17.3.tar.gz /libreport-2.17.4.tar.gz /libreport-2.17.5.tar.gz +/libreport-2.17.6.tar.gz diff --git a/README.packit b/README.packit index e8857c6..abd0db1 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.60.1.dev6+g9c9b2a8. +The file was generated using packit 0.62.0. diff --git a/libreport.spec b/libreport.spec index a09d4ca..b35a7e9 100644 --- a/libreport.spec +++ b/libreport.spec @@ -18,8 +18,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.5 -Release: 2%{?dist} +Version: 2.17.6 +Release: 1 License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -670,6 +670,12 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Nov 06 2022 Packit - 2.17.6-1 +- Release version 2.17.6 (Michal Srb) +- Update translations (mgrabovsky) +- Update changelog (Michal Srb) +- reporter-bugzilla: Fix TypeError (Michal Srb) + * Mon Oct 24 2022 Michal Srb - 2.17.5-2 - Fix dist-tag diff --git a/sources b/sources index f7c1ebd..246cc3d 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.5.tar.gz) = 3bc676ec80d24c0103ac0dd5150acf13feed65e7d52b4a68168fb6ae788f8b580032a846fc1fa987dcfe5da5678476efd28dde37d81042531f4f27ee4f6da809 +SHA512 (libreport-2.17.6.tar.gz) = 11e1dc12c2e28595eb2984bf18354d314318562ed270801dfbd7adceb92dfc8470e649b5cb1510d64649a034a86a6b583be687ecbb17d417a422c118179ff141 From 4abb72b5a7d3bbe5b9ea63789b2c2d023fc2835e Mon Sep 17 00:00:00 2001 From: Michal Srb Date: Sun, 6 Nov 2022 10:41:42 +0100 Subject: [PATCH 108/133] Fix dist-tag (again) Signed-off-by: Michal Srb --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index b35a7e9..fa2e7e4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -19,7 +19,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.6 -Release: 1 +Release: 1%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz From d1debfa9776c781c7fd631fb8b374099c9410778 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 19 Jan 2023 17:18:43 +0000 Subject: [PATCH 109/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index fa2e7e4..285e09f 100644 --- a/libreport.spec +++ b/libreport.spec @@ -19,7 +19,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.6 -Release: 1%{?dist} +Release: 2%{?dist} License: GPLv2+ URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -670,6 +670,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jan 19 2023 Fedora Release Engineering - 2.17.6-2 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild + * Sun Nov 06 2022 Packit - 2.17.6-1 - Release version 2.17.6 (Michal Srb) - Update translations (mgrabovsky) From 502f8c74123c0a714fcf766ebac6cfd18cd8a791 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mat=C4=9Bj=20Grabovsk=C3=BD?= Date: Thu, 2 Feb 2023 16:09:02 +0100 Subject: [PATCH 110/133] Use SPDX format for license field See [the wiki][1] for details. [1]: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 --- libreport.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 285e09f..44d23a1 100644 --- a/libreport.spec +++ b/libreport.spec @@ -20,7 +20,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.6 Release: 2%{?dist} -License: GPLv2+ +License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz BuildRequires: %{dbus_devel} From d20251d629da22241d9ada5a0b705740548acab6 Mon Sep 17 00:00:00 2001 From: Packit Date: Mon, 20 Feb 2023 15:30:39 +0000 Subject: [PATCH 111/133] [packit] 2.17.7 upstream release Upstream tag: 2.17.7 Upstream commit: d9b4b097 Signed-off-by: Packit --- .gitignore | 1 + .packit.yml | 8 ++++++-- README.packit | 2 +- libreport.spec | 33 ++++++++++++++++++++++----------- sources | 2 +- 5 files changed, 31 insertions(+), 15 deletions(-) diff --git a/.gitignore b/.gitignore index fd4d540..5c6a4b2 100644 --- a/.gitignore +++ b/.gitignore @@ -23,3 +23,4 @@ /libreport-2.17.4.tar.gz /libreport-2.17.5.tar.gz /libreport-2.17.6.tar.gz +/libreport-2.17.7.tar.gz diff --git a/.packit.yml b/.packit.yml index b82be50..115dab4 100644 --- a/.packit.yml +++ b/.packit.yml @@ -1,10 +1,14 @@ specfile_path: libreport.spec synced_files: - - .packit.yml - - libreport.spec +- .packit.yml +- libreport.spec upstream_package_name: libreport upstream_project_url: https://github.com/abrt/libreport downstream_package_name: libreport + +# No extra dependencies are necessary to build the SRPM. +srpm_build_deps: [] + jobs: - job: propose_downstream trigger: release diff --git a/README.packit b/README.packit index abd0db1..1d8463b 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.62.0. +The file was generated using packit 0.67.0.post4+g281a5ac. diff --git a/libreport.spec b/libreport.spec index 44d23a1..861f3f4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -12,14 +12,10 @@ %define glib_ver 2.43.4 -%if "x%{?rhbz_product_version}" == "x" - %define rhbz_product_version %(source /etc/os-release; echo ${REDHAT_BUGZILLA_PRODUCT_VERSION}) -%endif - Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.6 -Release: 2%{?dist} +Version: 2.17.7 +Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -193,7 +189,7 @@ Summary: %{name}'s bugzilla plugin Requires: %{name} = %{version}-%{release} Requires: libreport-web = %{version}-%{release} Requires: python3-libreport = %{version}-%{release} -%if "%{rhbz_product_version}" == "rawhide" +%if 0%{?fedora} >= 38 Requires: python3-satyr Suggests: python3-pytest Suggests: python3-vcrpy @@ -372,6 +368,10 @@ rm -f %{buildroot}%{_mandir}/man5/report_uReport.conf.5 rm -f %{buildroot}%{_mandir}/man5/report_rhel_bugzilla.conf.5 %endif +%if 0%{?fedora} >= 38 + mv %{buildroot}/%{_bindir}/reporter-bugzilla-python %{buildroot}/%{_bindir}/reporter-bugzilla +%endif + %check make check|| { # find and print the logs of failed test @@ -562,11 +562,8 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %{_mandir}/man5/bugzilla_formatdup_analyzer_libreport.conf.5.* %{_mandir}/man5/bugzilla_format_kernel.conf.5.* %{_bindir}/reporter-bugzilla +%if 0%{?fedora} < 38 %{_bindir}/reporter-bugzilla-python - -%post plugin-bugzilla -%if "%{rhbz_product_version}" == "rawhide" - mv %{_bindir}/reporter-bugzilla-python %{_bindir}/reporter-bugzilla %endif %endif @@ -670,6 +667,20 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Feb 20 2023 Packit - 2.17.7-1 +- Release version 2.17.7 (Michal Srb) +- spec: Add disttag (Michal Srb) +- Update changelog (Michal Srb) +- Fix rpm -V issue with missing reporter-bugzilla-python in f38 (Michal Srb) +- Fix TypeError (Michal Srb) +- Update pot file (Matěj Grabovský) +- readme: Add diagram of related projects (Matěj Grabovský) +- Update translations (mgrabovsky) +- Use SPDX format for license field (Matěj Grabovský) +- ignored_words: Add KeyboardInterrupt (Michal Fabik) +- packit: Add dependencies for SRPM build (Matěj Grabovský) +- Update translations (mgrabovsky) + * Thu Jan 19 2023 Fedora Release Engineering - 2.17.6-2 - Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild diff --git a/sources b/sources index 246cc3d..9a03f9d 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.6.tar.gz) = 11e1dc12c2e28595eb2984bf18354d314318562ed270801dfbd7adceb92dfc8470e649b5cb1510d64649a034a86a6b583be687ecbb17d417a422c118179ff141 +SHA512 (libreport-2.17.7.tar.gz) = 38b63d8fcbab64f8ed6f206933f3b35bf7bd687f74c2631af8603f308d6faad0a2478f56b6c116e2ce8650e19332888e2c2380001cf22c30da842c142eb2315b From 7dafb9633a708c5a2b33c0724b4acf0282955485 Mon Sep 17 00:00:00 2001 From: Packit Date: Fri, 3 Mar 2023 09:16:35 +0000 Subject: [PATCH 112/133] [packit] 2.17.8 upstream release Upstream tag: 2.17.8 Upstream commit: 46a99a14 Signed-off-by: Packit --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 9 ++++++++- sources | 2 +- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 5c6a4b2..b7aafde 100644 --- a/.gitignore +++ b/.gitignore @@ -24,3 +24,4 @@ /libreport-2.17.5.tar.gz /libreport-2.17.6.tar.gz /libreport-2.17.7.tar.gz +/libreport-2.17.8.tar.gz diff --git a/README.packit b/README.packit index 1d8463b..2d4b293 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.67.0.post4+g281a5ac. +The file was generated using packit 0.68.0.post15+g49c3920. diff --git a/libreport.spec b/libreport.spec index 861f3f4..78ca323 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.7 +Version: 2.17.8 Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ @@ -667,6 +667,13 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Mar 03 2023 Packit - 2.17.8-1 +- Release version 2.17.8 (Michal Srb) +- Update changelog (Michal Srb) +- reporter-bugzilla: Fix KeyError when HOME env var is not set (Michal Srb) +- Update changelog (Michal Srb) +- reporter-bugzilla: Fix password prompt in client/server mode (Michal Srb) + * Mon Feb 20 2023 Packit - 2.17.7-1 - Release version 2.17.7 (Michal Srb) - spec: Add disttag (Michal Srb) diff --git a/sources b/sources index 9a03f9d..bd8d6e8 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.7.tar.gz) = 38b63d8fcbab64f8ed6f206933f3b35bf7bd687f74c2631af8603f308d6faad0a2478f56b6c116e2ce8650e19332888e2c2380001cf22c30da842c142eb2315b +SHA512 (libreport-2.17.8.tar.gz) = 982126b08b06aea34ad5aef17217f3a84aa73935a277d13db8355ae5ef84a41125993567921e17b76804d3db1a92a0fe18ea4d6f93a5211700fabf442b722688 From d5f31e39bbe41ae421c80a4bfc6b8ef0d5b03545 Mon Sep 17 00:00:00 2001 From: Packit Date: Fri, 24 Mar 2023 08:39:53 +0000 Subject: [PATCH 113/133] [packit] 2.17.9 upstream release Upstream tag: 2.17.9 Upstream commit: 75177dda Signed-off-by: Packit --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 12 +++++++++++- sources | 2 +- 4 files changed, 14 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index b7aafde..7fa113f 100644 --- a/.gitignore +++ b/.gitignore @@ -25,3 +25,4 @@ /libreport-2.17.6.tar.gz /libreport-2.17.7.tar.gz /libreport-2.17.8.tar.gz +/libreport-2.17.9.tar.gz diff --git a/README.packit b/README.packit index 2d4b293..10ab7f2 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.68.0.post15+g49c3920. +The file was generated using packit 0.69.0.post27+g1374cc1. diff --git a/libreport.spec b/libreport.spec index 78ca323..a329b06 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.8 +Version: 2.17.9 Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ @@ -667,6 +667,16 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Mar 24 2023 Packit - 2.17.9-1 +- Release version 2.17.9 (Michal Srb) +- reporter-bugzilla: Fix string interpolation (Matěj Grabovský) +- reporter-bugzilla: Replace flags with just keyword arg (Michal Srb) +- reporter-bugzilla: Make sure that the creator of a bug is always in CC (Michal Srb) +- reporter-bugzilla: Don't fail if reported_to file doesn't exist (Michal Srb) +- reporter-bugzilla: Fix reporting when the bug already exists (Michal Srb) +- use $XDG_CONFIG_HOME to access user's configuration files (Yann Droneaud) +- Update translations (mgrabovsky) + * Fri Mar 03 2023 Packit - 2.17.8-1 - Release version 2.17.8 (Michal Srb) - Update changelog (Michal Srb) diff --git a/sources b/sources index bd8d6e8..378216a 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.8.tar.gz) = 982126b08b06aea34ad5aef17217f3a84aa73935a277d13db8355ae5ef84a41125993567921e17b76804d3db1a92a0fe18ea4d6f93a5211700fabf442b722688 +SHA512 (libreport-2.17.9.tar.gz) = bd8566610aa32d1c71afa1796d7e29f92907b09ff3195a42417f92b0c1599852fb9686c4be7206fc6596a96f84f9767c653d7147c27eaf6e864de0eb4637834d From 08bd6422c3ec7e526cff2036c2f1c0960d279800 Mon Sep 17 00:00:00 2001 From: Packit Date: Thu, 11 May 2023 09:21:48 +0000 Subject: [PATCH 114/133] [packit] 2.17.10 upstream release Upstream tag: 2.17.10 Upstream commit: cf4f0a12 --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 8 +++++++- sources | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 7fa113f..fcf61eb 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,4 @@ /libreport-2.17.7.tar.gz /libreport-2.17.8.tar.gz /libreport-2.17.9.tar.gz +/libreport-2.17.10.tar.gz diff --git a/README.packit b/README.packit index 10ab7f2..c6a9a6c 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.69.0.post27+g1374cc1. +The file was generated using packit 0.75.0.post9+g9ce4c01. diff --git a/libreport.spec b/libreport.spec index a329b06..739005c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.9 +Version: 2.17.10 Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ @@ -667,6 +667,12 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu May 11 2023 Packit - 2.17.10-1 +- Release version 2.17.10 (Matěj Grabovský) +- reporter-upload: Fix a use-after-free error in string handling (Matěj Grabovský) +- Update translations (mgrabovsky) +- Update translations (mgrabovsky) + * Fri Mar 24 2023 Packit - 2.17.9-1 - Release version 2.17.9 (Michal Srb) - reporter-bugzilla: Fix string interpolation (Matěj Grabovský) diff --git a/sources b/sources index 378216a..210d38b 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.9.tar.gz) = bd8566610aa32d1c71afa1796d7e29f92907b09ff3195a42417f92b0c1599852fb9686c4be7206fc6596a96f84f9767c653d7147c27eaf6e864de0eb4637834d +SHA512 (libreport-2.17.10.tar.gz) = 086506aaa530161adea78f9145447843bf330d6344c42c558e9755c2ef6e862530b985c68ea4d9abb021fa2baf14c47de8b09e19e7748c47fe7f3f0a7a9aa0cf From 70c2d78a6e581b347cb7debdde5b654682e103fb Mon Sep 17 00:00:00 2001 From: Python Maint Date: Thu, 15 Jun 2023 14:17:59 +0200 Subject: [PATCH 115/133] Rebuilt for Python 3.12 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 739005c..9c99bed 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.10 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -667,6 +667,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jun 15 2023 Python Maint - 2.17.10-2 +- Rebuilt for Python 3.12 + * Thu May 11 2023 Packit - 2.17.10-1 - Release version 2.17.10 (Matěj Grabovský) - reporter-upload: Fix a use-after-free error in string handling (Matěj Grabovský) From 5e25b02299cbef2e09bc3fe5cc529e423d017ea4 Mon Sep 17 00:00:00 2001 From: Packit Date: Fri, 30 Jun 2023 11:05:18 +0000 Subject: [PATCH 116/133] [packit] 2.17.11 upstream release Upstream tag: 2.17.11 Upstream commit: d58110e1 --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 16 ++++++++++++++-- sources | 2 +- 4 files changed, 17 insertions(+), 4 deletions(-) diff --git a/.gitignore b/.gitignore index fcf61eb..3bd995d 100644 --- a/.gitignore +++ b/.gitignore @@ -27,3 +27,4 @@ /libreport-2.17.8.tar.gz /libreport-2.17.9.tar.gz /libreport-2.17.10.tar.gz +/libreport-2.17.11.tar.gz diff --git a/README.packit b/README.packit index c6a9a6c..101115f 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.75.0.post9+g9ce4c01. +The file was generated using packit 0.77.0.post2+g06f877b. diff --git a/libreport.spec b/libreport.spec index 9c99bed..a4b969e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,8 +14,8 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.10 -Release: 2%{?dist} +Version: 2.17.11 +Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -110,6 +110,8 @@ Requires: libreport >= %{version}-%{distfreerelease} Requires: libreport = %{version}-%{release} %endif Requires: python3-dnf +Requires: python3-requests +Requires: python3-urllib3 %{?python_provide:%python_provide python3-libreport} %description -n python3-libreport @@ -667,6 +669,16 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Jun 30 2023 Packit - 2.17.11-1 +- Release version 2.17.11 (Michal Srb) +- spec: Add missing requires for python3-libreport (Michal Srb) +- Build URL with urllib.parse.urljoin() (Michal Srb) +- Add XDG_ACTIVATION_TOKEN to the list of ignored words (Michal Srb) +- Attachments are minor updates in Bugzilla (Michal Srb) +- Retry Bugzilla search queries with delays (Michal Srb) +- Fix "NameError: name 'ticket' is not defined" exception (Michal Srb) +- Update translations (mgrabovsky) + * Thu Jun 15 2023 Python Maint - 2.17.10-2 - Rebuilt for Python 3.12 diff --git a/sources b/sources index 210d38b..3ccd52a 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.10.tar.gz) = 086506aaa530161adea78f9145447843bf330d6344c42c558e9755c2ef6e862530b985c68ea4d9abb021fa2baf14c47de8b09e19e7748c47fe7f3f0a7a9aa0cf +SHA512 (libreport-2.17.11.tar.gz) = 2bf447b86192c6be44271609a50ddf1c1da2da1d11a9d2af56b0fe81921dc4c933e5fcea6a759804e8ad61afb81ba7e12c7ba273bfc279d2157e0b9f03b3b0f8 From 2b88cb16691c00d62179741fec609d5323b3c5ca Mon Sep 17 00:00:00 2001 From: Python Maint Date: Sat, 1 Jul 2023 11:44:59 +0200 Subject: [PATCH 117/133] Rebuilt for Python 3.12 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index a4b969e..a9c3583 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.11 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sat Jul 01 2023 Python Maint - 2.17.11-2 +- Rebuilt for Python 3.12 + * Fri Jun 30 2023 Packit - 2.17.11-1 - Release version 2.17.11 (Michal Srb) - spec: Add missing requires for python3-libreport (Michal Srb) From d1f5aea9e358aadc68aaa2de63233770be685540 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 20 Jul 2023 11:56:18 +0000 Subject: [PATCH 118/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild Signed-off-by: Fedora Release Engineering --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index a9c3583..d6dcdba 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.11 -Release: 2%{?dist} +Release: 3%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jul 20 2023 Fedora Release Engineering - 2.17.11-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild + * Sat Jul 01 2023 Python Maint - 2.17.11-2 - Rebuilt for Python 3.12 From 3d476b7c77a27fee1f9cc335ac011346964b744d Mon Sep 17 00:00:00 2001 From: Yaakov Selkowitz Date: Tue, 19 Dec 2023 08:22:58 -0500 Subject: [PATCH 119/133] Fix build with libxml2 2.12 https://github.com/abrt/libreport/pull/801 --- 801.patch | 42 ++++++++++++++++++++++++++++++++++++++++++ libreport.spec | 5 ++++- 2 files changed, 46 insertions(+), 1 deletion(-) create mode 100644 801.patch diff --git a/801.patch b/801.patch new file mode 100644 index 0000000..8f784ff --- /dev/null +++ b/801.patch @@ -0,0 +1,42 @@ +From 9be0010e109d307921a049d10078813423227582 Mon Sep 17 00:00:00 2001 +From: Nicolas Iooss +Date: Fri, 15 Dec 2023 18:03:33 +0100 +Subject: [PATCH] Fix compatibility with libxml2 2.12 +MIME-Version: 1.0 +Content-Type: text/plain; charset=UTF-8 +Content-Transfer-Encoding: 8bit + +Since libxml2 2.12, xmlNodePtr is no longer included by libxml/encoding.h. +This leads to build errors such as: + + CC reporter_mantisbt-reporter-mantisbt.o + In file included from reporter-mantisbt.c:22: + mantisbt.h:48:5: error: unknown type name ‘xmlNodePtr’ + 48 | xmlNodePtr sr_root; + | ^~~~~~~~~~ + mantisbt.h:49:5: error: unknown type name ‘xmlNodePtr’ + 49 | xmlNodePtr sr_body; + | ^~~~~~~~~~ + mantisbt.h:50:5: error: unknown type name ‘xmlNodePtr’ + 50 | xmlNodePtr sr_method; + | ^~~~~~~~~~ + +Fix this by including libxml/tree.h. + +Signed-off-by: Nicolas Iooss +--- + src/plugins/mantisbt.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/src/plugins/mantisbt.h b/src/plugins/mantisbt.h +index 1feaf8f88..6979e7244 100644 +--- a/src/plugins/mantisbt.h ++++ b/src/plugins/mantisbt.h +@@ -25,6 +25,7 @@ extern "C" { + #endif + + #include ++#include + #include "problem_report.h" + + #define SOAP_STRING "ns2:string" diff --git a/libreport.spec b/libreport.spec index d6dcdba..972a6f6 100644 --- a/libreport.spec +++ b/libreport.spec @@ -19,6 +19,9 @@ Release: 3%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +# Fix compatibility with libxml2 2.12 +Patch: https://github.com/abrt/%{name}/pull/801.patch + BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -286,7 +289,7 @@ data over ftp/scp... %endif %prep -%autosetup +%autosetup -p1 %build ./autogen.sh From e756ae568d7fb66efeed0cbe74259e35210aab7f Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Sun, 21 Jan 2024 05:11:15 +0000 Subject: [PATCH 120/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 972a6f6..70899a4 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.11 -Release: 3%{?dist} +Release: 4%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -672,6 +672,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Jan 21 2024 Fedora Release Engineering - 2.17.11-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Thu Jul 20 2023 Fedora Release Engineering - 2.17.11-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild From 3265c40aad6548917e7f6de898563d71d17afc0c Mon Sep 17 00:00:00 2001 From: Florian Weimer Date: Sun, 21 Jan 2024 18:57:57 +0100 Subject: [PATCH 121/133] Fix C compatibility issues in tests Related to: --- libreport-c89-2.patch | 46 +++++++++++++++++++++++++++++++++++++++++++ libreport-c89.patch | 28 ++++++++++++++++++++++++++ libreport.spec | 7 ++++++- 3 files changed, 80 insertions(+), 1 deletion(-) create mode 100644 libreport-c89-2.patch create mode 100644 libreport-c89.patch diff --git a/libreport-c89-2.patch b/libreport-c89-2.patch new file mode 100644 index 0000000..7b9b9d6 --- /dev/null +++ b/libreport-c89-2.patch @@ -0,0 +1,46 @@ +problem_item_get_size expects unsigned long * argument in problem_data.at test + +Otherwise, the test fails to build on i686 with GCC 14. + +Submitted upstream: + +diff --git a/tests/problem_data.at b/tests/problem_data.at +index 4d8bf0075c0a8b91..db67a76732d48663 100644 +--- a/tests/problem_data.at ++++ b/tests/problem_data.at +@@ -89,7 +89,7 @@ int main(int argc, char **argv) + struct problem_item *itm = problem_data_add_ext(data, "1", "foo", CD_FLAG_TXT | CD_FLAG_ISNOTEDITABLE, PROBLEM_ITEM_UNINITIALIZED_SIZE); + const size_t old_size = strlen(itm->content); + { +- size_t current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; ++ unsigned long current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; + assert(problem_item_get_size(itm, ¤t_size) == 0); + assert(current_size != PROBLEM_ITEM_UNINITIALIZED_SIZE); + assert(current_size == old_size); +@@ -97,7 +97,7 @@ int main(int argc, char **argv) + { + g_free(itm->content); + itm->content = NULL; +- size_t current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; ++ unsigned long current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; + assert(problem_item_get_size(itm, ¤t_size) == 0); + assert(current_size != PROBLEM_ITEM_UNINITIALIZED_SIZE); + assert(current_size == old_size); +@@ -120,7 +120,7 @@ int main(int argc, char **argv) + struct problem_item *itm = problem_data_add_ext(data, "2", flnm, CD_FLAG_BIN, PROBLEM_ITEM_UNINITIALIZED_SIZE); + + { +- size_t current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; ++ unsigned long current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; + assert(problem_item_get_size(itm, ¤t_size) == 0); + assert(current_size != PROBLEM_ITEM_UNINITIALIZED_SIZE); + assert(current_size == old_size); +@@ -129,7 +129,7 @@ int main(int argc, char **argv) + close(flds); + unlink(flnm); + assert(stat(flnm, &buf) != 0); +- size_t current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; ++ unsigned long current_size = PROBLEM_ITEM_UNINITIALIZED_SIZE; + assert(problem_item_get_size(itm, ¤t_size) == 0); + assert(current_size != PROBLEM_ITEM_UNINITIALIZED_SIZE); + assert(current_size == old_size); diff --git a/libreport-c89.patch b/libreport-c89.patch new file mode 100644 index 0000000..3f1770d --- /dev/null +++ b/libreport-c89.patch @@ -0,0 +1,28 @@ +Remove incorrect casts from tests/string_list.at + +The list_order argument already has the correct pointer type const +char * const * (after array-to-pointer decay). + +Submitted upstream: + +diff --git a/tests/string_list.at b/tests/string_list.at +index 6af162a2f8da3919..2118298da4de0ec3 100644 +--- a/tests/string_list.at ++++ b/tests/string_list.at +@@ -22,13 +22,13 @@ int main(void) + NULL + }; + +- int index = libreport_index_of_string_in_list(FILENAME_REASON, (char**) list_order); ++ int index = libreport_index_of_string_in_list(FILENAME_REASON, list_order); + assert(index == 0); + +- index = libreport_index_of_string_in_list(FILENAME_COUNT, (char**) list_order); ++ index = libreport_index_of_string_in_list(FILENAME_COUNT, list_order); + assert(index == 5); + +- index = libreport_index_of_string_in_list("other", (char**) list_order); ++ index = libreport_index_of_string_in_list("other", list_order); + assert(index < 0); + + return 0; diff --git a/libreport.spec b/libreport.spec index 70899a4..4facbcc 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,10 +15,12 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.11 -Release: 4%{?dist} +Release: 5%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz +Patch0: libreport-c89.patch +Patch1: libreport-c89-2.patch # Fix compatibility with libxml2 2.12 Patch: https://github.com/abrt/%{name}/pull/801.patch @@ -672,6 +674,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Jan 21 2024 Florian Weimer - 2.17.11-5 +- Fix C compatibility issues in tests + * Sun Jan 21 2024 Fedora Release Engineering - 2.17.11-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild From d86ac262fb393eb08bc702d8a7bbf166206d8dd4 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 25 Jan 2024 03:22:25 +0000 Subject: [PATCH 122/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 4facbcc..85fe89c 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.11 -Release: 5%{?dist} +Release: 6%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -674,6 +674,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jan 25 2024 Fedora Release Engineering - 2.17.11-6 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Sun Jan 21 2024 Florian Weimer - 2.17.11-5 - Fix C compatibility issues in tests From 98db5ac07f334d0bd946eecf764a898ad0503c4b Mon Sep 17 00:00:00 2001 From: Packit Date: Sun, 4 Feb 2024 21:41:29 +0000 Subject: [PATCH 123/133] [packit] 2.17.13 upstream release Upstream tag: 2.17.13 Upstream commit: 3edcb9bf --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 15 +++++++-------- sources | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.gitignore b/.gitignore index 3bd995d..b6ebbfc 100644 --- a/.gitignore +++ b/.gitignore @@ -28,3 +28,4 @@ /libreport-2.17.9.tar.gz /libreport-2.17.10.tar.gz /libreport-2.17.11.tar.gz +/libreport-2.17.13.tar.gz diff --git a/README.packit b/README.packit index 101115f..9a6e969 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.77.0.post2+g06f877b. +The file was generated using packit 0.90.0.post1.dev3+g3d9551d2. diff --git a/libreport.spec b/libreport.spec index 85fe89c..508caa8 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,16 +14,11 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.11 -Release: 6%{?dist} +Version: 2.17.13 +Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz -Patch0: libreport-c89.patch -Patch1: libreport-c89-2.patch -# Fix compatibility with libxml2 2.12 -Patch: https://github.com/abrt/%{name}/pull/801.patch - BuildRequires: %{dbus_devel} BuildRequires: gtk3-devel BuildRequires: curl-devel @@ -291,7 +286,7 @@ data over ftp/scp... %endif %prep -%autosetup -p1 +%autosetup %build ./autogen.sh @@ -674,6 +669,10 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Feb 04 2024 Packit - 2.17.13-1 +- Release version 2.17.13 (Michal Srb) +- Exclude coredump archives when creating a bug (Michal Srb) + * Thu Jan 25 2024 Fedora Release Engineering - 2.17.11-6 - Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild diff --git a/sources b/sources index 3ccd52a..6615d9f 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.11.tar.gz) = 2bf447b86192c6be44271609a50ddf1c1da2da1d11a9d2af56b0fe81921dc4c933e5fcea6a759804e8ad61afb81ba7e12c7ba273bfc279d2157e0b9f03b3b0f8 +SHA512 (libreport-2.17.13.tar.gz) = e92abd9f60ee7a1f28dc1f9907aa5103d01c7c80077aafea2277f8d3413601de8e055fba4117fa82bde96e0c9a468b698352f1d90dfb1d9de8e1606595bb4758 From 0456c363514aa7440a74a065b10c8fa6c9739f04 Mon Sep 17 00:00:00 2001 From: Packit Date: Mon, 12 Feb 2024 21:45:09 +0000 Subject: [PATCH 124/133] [packit] 2.17.14 upstream release Upstream tag: 2.17.14 Upstream commit: 95088af1 --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 11 ++++++++++- sources | 2 +- 4 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index b6ebbfc..8c673d7 100644 --- a/.gitignore +++ b/.gitignore @@ -29,3 +29,4 @@ /libreport-2.17.10.tar.gz /libreport-2.17.11.tar.gz /libreport-2.17.13.tar.gz +/libreport-2.17.14.tar.gz diff --git a/README.packit b/README.packit index 9a6e969..3953da0 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.90.0.post1.dev3+g3d9551d2. +The file was generated using packit 0.91.0.post1.dev2+g269d9a5d. diff --git a/libreport.spec b/libreport.spec index 508caa8..f8659c2 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.13 +Version: 2.17.14 Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ @@ -669,6 +669,15 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Feb 12 2024 Packit - 2.17.14-1 +- Release version 2.17.14 (Michal Srb) +- reporter-bugzilla: Reduce number of duplicate bug reports (Michal Srb) +- reporter-bugzilla: Fix config loading (Michal Srb) +- reporter-bugzilla: API key must consist of latin-1 characters (Michal Srb) +- reporter-bugzilla: Fix typo (Michal Srb) +- reporter-bugzilla: Fix creating binary attachments (Michal Srb) +- Update translations (mgrabovsky) + * Sun Feb 04 2024 Packit - 2.17.13-1 - Release version 2.17.13 (Michal Srb) - Exclude coredump archives when creating a bug (Michal Srb) diff --git a/sources b/sources index 6615d9f..c0dd55b 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.13.tar.gz) = e92abd9f60ee7a1f28dc1f9907aa5103d01c7c80077aafea2277f8d3413601de8e055fba4117fa82bde96e0c9a468b698352f1d90dfb1d9de8e1606595bb4758 +SHA512 (libreport-2.17.14.tar.gz) = 90203748e6665d715c2b723d727b94c70ac864f1a3d1e742eab9a0c33e1767d84bc9408183349c7e6d0d019385aae48cc2ff3b3439a115c5cec61493de826a74 From 16c3ff1ff83bc6b4bdc451e79ff23c774f887798 Mon Sep 17 00:00:00 2001 From: Packit Date: Sun, 18 Feb 2024 13:41:20 +0000 Subject: [PATCH 125/133] [packit] 2.17.15 upstream release Upstream tag: 2.17.15 Upstream commit: f6bb06a6 --- .gitignore | 1 + README.packit | 2 +- libreport.spec | 8 +++++++- sources | 2 +- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/.gitignore b/.gitignore index 8c673d7..56386dd 100644 --- a/.gitignore +++ b/.gitignore @@ -30,3 +30,4 @@ /libreport-2.17.11.tar.gz /libreport-2.17.13.tar.gz /libreport-2.17.14.tar.gz +/libreport-2.17.15.tar.gz diff --git a/README.packit b/README.packit index 3953da0..f592284 100644 --- a/README.packit +++ b/README.packit @@ -1,3 +1,3 @@ This repository is maintained by packit. https://packit.dev/ -The file was generated using packit 0.91.0.post1.dev2+g269d9a5d. +The file was generated using packit 0.91.0.post1.dev4+ge6fd4a25. diff --git a/libreport.spec b/libreport.spec index f8659c2..fdba8b1 100644 --- a/libreport.spec +++ b/libreport.spec @@ -14,7 +14,7 @@ Summary: Generic library for reporting various problems Name: libreport -Version: 2.17.14 +Version: 2.17.15 Release: 1%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ @@ -669,6 +669,12 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Sun Feb 18 2024 Packit - 2.17.15-1 +- Release version 2.17.15 (Michal Srb) +- reporter-bugzilla: Make the supplementary bugs easily identifiable (Michal Srb) +- reporter-bugzilla: Fix formatting in the supplementary bugs (Michal Srb) +- reporter-bugzilla: Fix code comment (Michal Srb) + * Mon Feb 12 2024 Packit - 2.17.14-1 - Release version 2.17.14 (Michal Srb) - reporter-bugzilla: Reduce number of duplicate bug reports (Michal Srb) diff --git a/sources b/sources index c0dd55b..3f8648a 100644 --- a/sources +++ b/sources @@ -1 +1 @@ -SHA512 (libreport-2.17.14.tar.gz) = 90203748e6665d715c2b723d727b94c70ac864f1a3d1e742eab9a0c33e1767d84bc9408183349c7e6d0d019385aae48cc2ff3b3439a115c5cec61493de826a74 +SHA512 (libreport-2.17.15.tar.gz) = a4707f5272f037f91b4f4b562d3f0eb165ae7790699714accdd1af40216f37bd40d430a06925b1b7b8ac2d2cf97fd0cc4efded51dc22d21d9ef2abedf796e5fe From 30c54c4b8f3951d963f1b1614aa19910424a8ad4 Mon Sep 17 00:00:00 2001 From: Python Maint Date: Fri, 7 Jun 2024 10:11:07 +0200 Subject: [PATCH 126/133] Rebuilt for Python 3.13 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index fdba8b1..3be7db2 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 1%{?dist} +Release: 2%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Jun 07 2024 Python Maint - 2.17.15-2 +- Rebuilt for Python 3.13 + * Sun Feb 18 2024 Packit - 2.17.15-1 - Release version 2.17.15 (Michal Srb) - reporter-bugzilla: Make the supplementary bugs easily identifiable (Michal Srb) From f12e85e73a813586f7c1f2ad81d17895dd0e3778 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 18 Jul 2024 14:56:06 +0000 Subject: [PATCH 127/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 3be7db2..ee89c88 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 2%{?dist} +Release: 3%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jul 18 2024 Fedora Release Engineering - 2.17.15-3 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild + * Fri Jun 07 2024 Python Maint - 2.17.15-2 - Rebuilt for Python 3.13 From 4c22c90ed7cf7e10990661220290e643c5fa761f Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Fri, 17 Jan 2025 13:23:27 +0000 Subject: [PATCH 128/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index ee89c88..065158a 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 3%{?dist} +Release: 4%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Jan 17 2025 Fedora Release Engineering - 2.17.15-4 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild + * Thu Jul 18 2024 Fedora Release Engineering - 2.17.15-3 - Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild From 98096d701ccf2ea37e4a08d41d37ba1163c49c33 Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Mon, 20 Jan 2025 07:55:41 +0000 Subject: [PATCH 129/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 065158a..570345d 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 4%{?dist} +Release: 5%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jan 20 2025 Fedora Release Engineering - 2.17.15-5 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild + * Fri Jan 17 2025 Fedora Release Engineering - 2.17.15-4 - Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild From 4c7cbd00288f691501286d79178279c7531363bc Mon Sep 17 00:00:00 2001 From: Python Maint Date: Mon, 2 Jun 2025 22:22:16 +0200 Subject: [PATCH 130/133] Rebuilt for Python 3.14 --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 570345d..6bc8159 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 5%{?dist} +Release: 6%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Mon Jun 02 2025 Python Maint - 2.17.15-6 +- Rebuilt for Python 3.14 + * Mon Jan 20 2025 Fedora Release Engineering - 2.17.15-5 - Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild From 87712a5e5a87e879226d23138e9b544d13556e5b Mon Sep 17 00:00:00 2001 From: Fedora Release Engineering Date: Thu, 24 Jul 2025 20:16:10 +0000 Subject: [PATCH 131/133] Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 6bc8159..92fccb9 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 6%{?dist} +Release: 7%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Thu Jul 24 2025 Fedora Release Engineering - 2.17.15-7 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild + * Mon Jun 02 2025 Python Maint - 2.17.15-6 - Rebuilt for Python 3.14 From c77d81af755dbf55949fe43d86bbc2d7747597c6 Mon Sep 17 00:00:00 2001 From: Python Maint Date: Fri, 15 Aug 2025 12:57:01 +0200 Subject: [PATCH 132/133] Rebuilt for Python 3.14.0rc2 bytecode --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index 92fccb9..d3cb4c6 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 7%{?dist} +Release: 8%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Aug 15 2025 Python Maint - 2.17.15-8 +- Rebuilt for Python 3.14.0rc2 bytecode + * Thu Jul 24 2025 Fedora Release Engineering - 2.17.15-7 - Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild From 45da97f63e9145878a74a3c61c1b2b263a77b398 Mon Sep 17 00:00:00 2001 From: Python Maint Date: Fri, 19 Sep 2025 12:27:39 +0200 Subject: [PATCH 133/133] Rebuilt for Python 3.14.0rc3 bytecode --- libreport.spec | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libreport.spec b/libreport.spec index d3cb4c6..a4f068e 100644 --- a/libreport.spec +++ b/libreport.spec @@ -15,7 +15,7 @@ Summary: Generic library for reporting various problems Name: libreport Version: 2.17.15 -Release: 8%{?dist} +Release: 9%{?dist} License: GPL-2.0-or-later URL: https://abrt.readthedocs.org/ Source: https://github.com/abrt/%{name}/archive/%{version}/%{name}-%{version}.tar.gz @@ -669,6 +669,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || : %endif %changelog +* Fri Sep 19 2025 Python Maint - 2.17.15-9 +- Rebuilt for Python 3.14.0rc3 bytecode + * Fri Aug 15 2025 Python Maint - 2.17.15-8 - Rebuilt for Python 3.14.0rc2 bytecode