Fix permissions (#2275532)

Remove mistakenly readded patch for conf.d

.gitignore

@@ -16,3 +16,8 @@ nagios-3.2.1.tar.gz
 /nagioscore-nagios-4.4.2.tar.gz
 /nagioscore-nagios-4.4.3.tar.gz
 /nagioscore-nagios-4.4.5.tar.gz
+/nagioscore-nagios-4.4.6.tar.gz
+/nagioscore-nagios-4.4.7.tar.gz
+/nagioscore-nagios-4.4.8.tar.gz
+/nagioscore-nagios-4.4.9.tar.gz
+/nagioscore-nagios-4.4.14.tar.gz

nagios-0003-Install-config-files-too.patch

@@ -1,7 +1,8 @@
-diff -up ./Makefile.in.install_config ./Makefile.in
---- ./Makefile.in.install_config	2017-04-19 19:11:47.783707415 -0400
-+++ ./Makefile.in	2017-04-19 19:11:47.785707384 -0400
-@@ -377,7 +377,7 @@ dox:
+diff --git a/Makefile.in b/Makefile.in
+index b992ab1e..ef2a797f 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -439,7 +439,7 @@ dox:
  	doxygen doxy.conf
  
  

nagios-0009-fix-localstatedir-for-linux.patch

@@ -264,9 +264,9 @@ diff -up ./startup/default-service.in.fix_localstatedir ./startup/default-servic
  ExecStop=@BIN_KILL@ -s TERM ${MAINPID}
 -ExecStopPost=@BIN_RM@ -f @localstatedir@/rw/nagios.cmd
 +ExecStopPost=@BIN_RM@ -f @localstatedir@/spool/nagios/cmd/nagios.cmd
+ ExecReload=@bindir@/nagios -v @sysconfdir@/nagios.cfg
  ExecReload=@BIN_KILL@ -s HUP ${MAINPID}
  
- [Install]
 diff -up ./t-tap/Makefile.in.fix_localstatedir ./t-tap/Makefile.in
 --- ./t-tap/Makefile.in.fix_localstatedir	2019-01-16 14:24:14.944312569 -0600
 +++ ./t-tap/Makefile.in	2019-01-16 14:24:42.359858604 -0600

nagios-0011-remove-rpmbuild.patch

@@ -1,12 +1,14 @@
-diff -up ./contrib/Makefile.in.remove_rpmbuild ./contrib/Makefile.in
---- ./contrib/Makefile.in.remove_rpmbuild	2019-08-29 18:23:14.113160181 +0000
-+++ ./contrib/Makefile.in	2019-08-29 18:24:20.509445391 +0000
-@@ -85,36 +85,3 @@ $(CGI_O): $(CGI_C)
+diff --git a/contrib/Makefile.in b/contrib/Makefile.in
+index 72e4d4a9..62415152 100644
+--- a/contrib/Makefile.in
++++ b/contrib/Makefile.in
+@@ -84,52 +84,3 @@ $(CGI_O): $(CGI_C)
+ 
  %.cgi : %.c
  	$(CC) $(CFLAGS) $(LDFLAGS) $< $(CGI_O) -o $@
- 
+-
 -##############################################################################
--# rpm making automation for CentOS/RHEL.
+-# making similar EPEL rpm for Fedora/RHEL/CentOS 
 -
 -ifneq ("$(wildcard /etc/redhat-release)","")
 -
@@ -25,16 +27,31 @@ diff -up ./contrib/Makefile.in.remove_rpmbuild ./contrib/Makefile.in
 -    endif
 -endif
 -
--rpm:
+-# Create our own tarball and put ino rpmbuild/SOURCES
+-localsrc-rpm:
 -	# create nagios tar ball.
 -	@(cd ..;rm -f nagios-@VERSION@)
 -	@(cd ..;ln -s . nagios-@VERSION@)
 -	@(cd ..;tar zhcf nagios-@VERSION@.tar.gz --exclude nagios-@VERSION@/nagios-@VERSION@.tar.gz --exclude nagios-@VERSION@/nagios-@VERSION@ --exclude RCS --exclude CVS --exclude build-* --exclude *~ --exclude .git* nagios-@VERSION@/)
 -	@(cd ..;rm -f nagios-@VERSION@)
 -	# build the rpm using rpmbuild from ./rmbuild as topdir
--	@rm -rf rpmbuild && mkdir -p rpmbuild/SOURCES
+-	@rm -rf rpmbuild && mkdir -p ./rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
 -	@cp  ../nagios-@VERSION@.tar.gz rpmbuild/SOURCES/nagios-@VERSION@.tar.gz
--	@rpmbuild -ba --define "_topdir ${PWD}/rpmbuild"   ../nagios.spec
+-	@cp epel-patches/* ./rpmbuild/SOURCES
+-	@rpmbuild -ba --define "_topdir ${PWD}/rpmbuild"   epel-nagios.spec
+-	@cp  rpmbuild/RPMS/$(RPM_ARCH)/*.rpm .
+-	@cp rpmbuild/SRPMS/*.src.rpm .
+-	@ls -l *.rpm
+-
+-# tarball from https://github.com/NagiosEnterprises/nagioscore/releases/download/nagios-%{version}/nagios-%{version}.tar.gz
+-rpm: init-epelrpm  build-epelrpm
 -	@mv rpmbuild/RPMS/$(RPM_ARCH)/*.rpm .
 -	@ls -l *.rpm
+-init-epelrpm: 
+-	# build the rpm using rpmbuild from ./rmbuild as topdir
+-	@rm -rf ./rpmbuild && mkdir -p ./rpmbuild/{BUILD,RPMS,SOURCES,SPECS,SRPMS}
+-	@spectool -C ./rpmbuild/SOURCES -g epel-nagios.spec
+-	@cp epel-patches/* ./rpmbuild/SOURCES
+-build-epelrpm:
+-	@rpmbuild -ba --define "_topdir ${PWD}/rpmbuild"  epel-nagios.spec
 -endif

nagios.spec

@@ -1,11 +1,9 @@
 %global _hardened_build 1
-
-# https://gcc.gnu.org/gcc-10/porting_to.html#common
-# attempt to fix bugzilla 1793909
-%define _legacy_common_support 1
+# Set bootstrap = 1 to build without depending on plugins for localhost monitoring
+%global bootstrap 0
 
 Name:           nagios
-Version:        4.4.5
+Version:        4.4.14
 Release:        3%{?dist}
 
 Summary: Host/service/network monitoring program
@@ -29,9 +27,6 @@ Source14: nagios_epel7.te
 Source15: nagios_epel.fc
 Source16: nagios_epel6.te
 
-# Patch 0 should be a patch that we get from the maint git tree in
-# order to fix any items upstream wanted.
-#Patch0: nagios-0000-git201706.patch
 Patch1: nagios-0001-default-init.patch
 # Sent upstream
 Patch2: nagios-0002-Fix-installation-of-httpd-conf.d-config-file.patch
@@ -39,8 +34,6 @@ Patch3: nagios-0003-Install-config-files-too.patch
 Patch4: nagios-0004-Fix-path-to-CGI-executables.patch
 Patch5: nagios-0005-Fixed-path-to-passwd-file-in-Apache-s-config-file.patch
 Patch6: nagios-0006-Added-several-images-to-the-sample-config-revb.patch
-#Patch7: nagios-0007-Apache-2.4-configuration-fix-for-Fedora-18.patch
-Patch8: nagios-0008-Add-cfg_dir-etc-nagios-conf.d-to-the-main-nagios-con.patch
 Patch9: nagios-0009-fix-localstatedir-for-linux.patch
 ## This has been requested for security groups not wanting to leak
 ## their nagios location.
@@ -51,6 +44,7 @@ Patch12: nagios-0012-fix-spool.patch
 Patch13: nagios-0013-fix-plugin.patch
 Patch14: nagios-0014-fix-uidgid.patch
 
+BuildRequires:  make
 BuildRequires:  doxygen
 BuildRequires:  gcc
 BuildRequires:  gd-devel > 1.8
@@ -68,6 +62,7 @@ BuildRequires:  perl(Test::HTML::Lint)
 %endif
 BuildRequires:  perl(Test::More)
 BuildRequires:  perl(Test::Simple)
+BuildRequires:  openssl-devel
 
 # For up-to-date config.sub and config.guess
 BuildRequires:  libtool
@@ -88,6 +83,18 @@ Requires:       nagios-common
 Requires:       user(nagios)
 Requires:       group(nagios)
 
+# This plugins are required for localhost monitoring
+%if ! 0%{?bootstrap}
+Requires:       nagios-plugins-ping
+Requires:       nagios-plugins-load
+Requires:       nagios-plugins-users
+Requires:       nagios-plugins-http
+Requires:       nagios-plugins-disk
+Requires:       nagios-plugins-ssh
+Requires:       nagios-plugins-swap
+Requires:       nagios-plugins-procs
+%endif
+
 Requires(pre):    group(nagios)
 Requires(pre):    user(nagios)
 %if 0%{?rhel} > 6 || 0%{?fedora} > 20
@@ -162,23 +169,7 @@ Requires:         %name = %version-%release
 Various contributed items used by plugins and other tools.
 
 %prep
-%setup -q -n nagioscore-nagios-%{version}
-
-# patch0 would go here
-%patch1 -p1 -b .fix_el6_init
-%patch2 -p1 -b .fix_httpd_conf_d
-%patch3 -p0 -b .install_config
-%patch4 -p1 -b .fix_path_to_cgi
-%patch5 -p1 -b .fix_path_to_passwd
-%patch6 -p1 -b .more_images
-
-#%patch8 -p1 -b .conf_d
-%patch9 -p1 -b .fix_localstatedir
-%patch10 -p1 -b .remove_3rdparty_links
-%patch11 -p1 -b .remove_rpmbuild
-%patch12 -p1 -b .fix_spool
-%patch13 -p1 -b .fix_plugin
-%patch14 -p1 -b .fix_uidgid
+%autosetup -p1 -n nagioscore-nagios-%{version}
 
 install -p -m 0644 %{SOURCE10} %{SOURCE11} %{SOURCE12} html/images/logos/
 
@@ -217,13 +208,14 @@ install -p -m 0644 %{SOURCE10} %{SOURCE11} %{SOURCE12} html/images/logos/
     --with-template-extinfo \
     --enable-event-broker \
     STRIP=/bin/true
-make %{?_smp_mflags} all
+
+%make_build all
 
 ### Build our documentation
-%{__make} dox
+%make_build dox
 
 ### Apparently contrib does not obey configure !
-%{__make} %{?_smp_mflags} -C contrib
+%make_build -C contrib
 
 
 sed -e "s|/usr/lib/|%{_libdir}/|" %{SOURCE2} > %{name}.htaccess
@@ -243,14 +235,12 @@ cp -p %{SOURCE14} selinux/%{name}_epel.te
 %endif
 cp -p %{SOURCE15} selinux/%{name}_epel.fc
 touch selinux/%{name}_epel.if
-make -f %{_datadir}/selinux/devel/Makefile
+%make_build -f %{_datadir}/selinux/devel/Makefile
 %endif
 
 
 %install
-rm -rf $RPM_BUILD_ROOT
-
-make DESTDIR=%{buildroot} INIT_OPTS="" INSTALL_OPTS="" COMMAND_OPTS="" CGIDIR="%{_libdir}/%{name}/cgi-bin" CFGDIR="%{_sysconfdir}/%{name}" fullinstall
+%make_install INIT_OPTS="" INSTALL_OPTS="" COMMAND_OPTS="" CGIDIR="%{_libdir}/%{name}/cgi-bin" CFGDIR="%{_sysconfdir}/%{name}" fullinstall
 
 # relocated to sbin (Fedora-specific)
 install -d -m 0755 %{buildroot}%{_bindir}
@@ -272,16 +262,16 @@ install -d -m 0755 %{buildroot}%{_libdir}/%{name}/plugins/eventhandlers
 install -d -m 0755 %{buildroot}%{_libdir}/%{name}/plugins/eventhandlers/distributed-monitoring/
 install -d -m 0755 %{buildroot}%{_libdir}/%{name}/plugins/eventhandlers/redundancy-scenario1/
 
-install -d -m 0775 %{buildroot}%{_localstatedir}/spool/%{name}/cmd
-install -d -m 0775 %{buildroot}%{_localstatedir}/run/%{name}
+install -d -m 0755 %{buildroot}%{_localstatedir}/spool/%{name}/cmd
+install -d -m 0755 %{buildroot}%{_localstatedir}/run/%{name}
 
 # Make a run directory
-install -d -m 0775 %{buildroot}%{_localstatedir}/run/%{name}
+install -d -m 0755 %{buildroot}%{_localstatedir}/run/%{name}
 
 # Make logdirs
-install -d -m 0775 %{buildroot}/%{_localstatedir}/log/
-install -d -m 0775 %{buildroot}/%{_localstatedir}/log/%{name}/
-install -d -m 0775 %{buildroot}/%{_localstatedir}/log/%{name}/archives
+install -d -m 0755 %{buildroot}/%{_localstatedir}/log/
+install -d -m 0755 %{buildroot}/%{_localstatedir}/log/%{name}/
+install -d -m 0755 %{buildroot}/%{_localstatedir}/log/%{name}/archives
 
 # Use systemd unit on rhel7 or any supported Fedora
 %if 0%{?rhel} > 6 || 0%{?fedora} > 20
@@ -290,14 +280,17 @@ install -D -m 0644 -p %{SOURCE8} %{buildroot}%{_tmpfilesdir}/%{name}.conf
 
 # Remove SystemV init-script
 rm -f %{buildroot}%{_initrddir}/nagios
+
+# Fix systemd unit file permissions #1676334
+chmod -x %{buildroot}%{_unitdir}/%{name}.service
 %endif
 
 # Fix permissions - FIXME remove this when unneeded
-chmod 755 %{buildroot}%{_sbindir}/nagios
+chmod 755 %{buildroot}%{_sbindir}/nagios %{buildroot}%{_bindir}/nagiostats
 
 # Install documentation
 install -d -m 0755 %{buildroot}%{_datadir}/nagios/html/docs
-%{__cp} -a Documentation/html/* %{buildroot}%{_datadir}/nagios/html/docs
+%{__cp} -r Documentation/html/* %{buildroot}%{_datadir}/nagios/html/docs
 
 %if 0%{?rhel} >5
 # Selinux configs
@@ -305,7 +298,7 @@ install -p -m 644 -D %{name}_epel.pp $RPM_BUILD_ROOT%{_datadir}/selinux/packages
 %endif
 
 ### CONTRIB ITEMS TAKEN FROM UPSTREAM NAGIOS SPEC
-make install -C contrib DESTDIR="%{buildroot}" INSTALL_OPTS=""
+%make_install -C contrib INSTALL_OPTS=""
 install -p -m 644 contrib/eventhandlers/disable_active_service_checks %{buildroot}%{_libdir}/nagios/plugins/eventhandlers/
 install -p -m 644 contrib/eventhandlers/disable_notifications %{buildroot}%{_libdir}/nagios/plugins/eventhandlers/
 install -p -m 644 contrib/eventhandlers/enable_active_service_checks %{buildroot}%{_libdir}/nagios/plugins/eventhandlers/
@@ -319,6 +312,9 @@ install -p -m 644 contrib/eventhandlers/redundancy-scenario1/handle-master-proc-
 
 %{__mv} contrib/README contrib/README.contrib
 
+# Fix permissions #2275532
+chmod -R g-w %{buildroot}%{_datadir}/%{name} %{buildroot}%{_libdir}/%{name} %{buildroot}%{_sysconfdir} %{buildroot}%{_sbindir}
+
 %pre common
 getent group nagios >/dev/null || groupadd -r nagios
 getent passwd nagios >/dev/null || useradd -r -g nagios -d %{_localstatedir}/spool/%{name} -s /sbin/nologin nagios
@@ -432,8 +428,9 @@ fi
 %dir %{_datadir}/%{name}
 %dir %{_datadir}/%{name}/html
 %doc %{_datadir}/%{name}/html/docs
-%doc Changelog INSTALLING LICENSE README.md UPGRADING UpgradeToVersion4.ReadMe UpgradeToVersion4.sh
+%doc Changelog INSTALLING README.md UPGRADING UpgradeToVersion4.ReadMe UpgradeToVersion4.sh
 %doc internet.cfg
+%license LICENSE
 %{_datadir}/%{name}/html/[^cd]*
 %{_datadir}/%{name}/html/contexthelp/
 %{_datadir}/%{name}/html/d3/
@@ -457,11 +454,11 @@ fi
 %attr(0640,root,nagios) %config(noreplace) %{_sysconfdir}/%{name}/private/resource.cfg
 %attr(0640,root,apache) %config(noreplace) %{_sysconfdir}/%{name}/passwd
 %attr(0640,root,apache) %config(noreplace) %{_datadir}/%{name}/html/config.inc.php
-%attr(2775,nagios,nagios) %dir %{_localstatedir}/spool/%{name}/cmd
+%attr(2755,nagios,nagios) %dir %{_localstatedir}/spool/%{name}/cmd
 %attr(0750,nagios,nagios) %dir %{_localstatedir}/run/%{name}
 %attr(0750,nagios,nagios) %dir %{_localstatedir}/log/%{name}
 %attr(0750,nagios,nagios) %dir %{_localstatedir}/log/%{name}/archives
-%attr(0770,nagios,nagios) %dir %{_localstatedir}/spool/%{name}/checkresults
+%attr(0750,nagios,nagios) %dir %{_localstatedir}/spool/%{name}/checkresults
 
 %files common
 %dir %{_sysconfdir}/%{name}
@@ -487,6 +484,33 @@ fi
 %{_libdir}/%{name}/cgi/
 
 %changelog
+* Thu Jan 16 2025 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.14-3
+- Fix permissions (#2275532)
+
+* Thu Jan 16 2025 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.14-2
+- Bump to update
+
+* Fri Jan 05 2024 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.14-1
+- Update to 4.4.14
+
+* Sun Dec 25 2022 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.9-1
+- Update to 4.4.9
+
+* Wed Mar 03 2021 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.6-4
+- Add missing require for nagios-plugins-ping
+- Fix run path
+
+* Sat Feb 27 2021 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.6-3
+- Require plugins needed for localhost monitoring (#1932297)
+
+* Tue Feb 23 2021 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.6-2
+- Fix systemd unit file permissions #1676334
+
+* Sat Feb 20 2021 Guido Aulisi <guido.aulisi@gmail.com> - 4.4.6-1
+- Update to 4.4.6
+- Fix for CVE-2020-13977 #BZ1849087
+- Some spec cleanup
+
 * Tue Feb 18 2020 Stephen Smoogen <smooge@fedoraproject.org> - 4.4.5-3
 - Add change to allow for problems found in mass rebuild and gcc10.
 - Fix BZ#1793909

nagios.tmpfiles.conf

@@ -1 +1 @@
-D /var/run/nagios 0755 nagios nagios -
+D /run/nagios 0755 nagios nagios -

sources

@@ -1 +1 @@
-SHA512 (nagioscore-nagios-4.4.5.tar.gz) = b2b4213dc9087c49a96506f514ec672476763e1ca928bf5de8494a0509b612a4a357989e719820328095489138375c9db292ac3c8129925c323220860e17bc49
+SHA512 (nagioscore-nagios-4.4.14.tar.gz) = 6dfe19887f035f3a3f6774a0f1c515902608934a75b08835fe9a5163812657547c97a20f3df42b89a34cad949eb4b587853b4131718c30703490b11fbee0d0ee