Compare commits

...
Sign in to create a new pull request.

2 commits

Author SHA1 Message Date
Jan Friesse
23ad643230 getifaddrs may return NULL ifa_addr (tt#31)
- Resolves rhbz#696509
2011-04-14 14:01:55 +02:00
Jan Friesse
f9d31474cf Initial import (#656855) 2010-11-25 13:24:49 +01:00
4 changed files with 78 additions and 0 deletions

1
.gitignore vendored
View file

@ -0,0 +1 @@
/omping-0.0.1.tar.gz

View file

@ -0,0 +1,32 @@
From 220749b10250154f95aa05c8b948cbe7015a2daa Mon Sep 17 00:00:00 2001
From: Jan Friesse <jfriesse@redhat.com>
Date: Thu, 14 Apr 2011 13:53:08 +0200
Subject: [PATCH] getifaddrs may return NULL ifa_addr
Such ifa_addr is then dereferenced to find out address family.
Proper check is added now.
Resolves: tt#31
---
addrfunc.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/addrfunc.c b/addrfunc.c
index d6aa3cb..77fac4c 100644
--- a/addrfunc.c
+++ b/addrfunc.c
@@ -260,8 +260,9 @@ af_find_local_ai(const struct ai_list *ai_list, int *ip_ver, struct ifaddrs **if
TAILQ_FOREACH(aip, ai_list, entries) {
for (ai_i = aip->ai; ai_i != NULL; ai_i = ai_i->ai_next) {
for (ifa_i = ifa; ifa_i != NULL; ifa_i = ifa_i->ifa_next) {
- if (ifa_i->ifa_addr->sa_family != AF_INET &&
- ifa_i->ifa_addr->sa_family != AF_INET6) {
+ if (ifa_i->ifa_addr == NULL ||
+ (ifa_i->ifa_addr->sa_family != AF_INET &&
+ ifa_i->ifa_addr->sa_family != AF_INET6)) {
continue ;
}
--
1.7.3.4

44
omping.spec Normal file
View file

@ -0,0 +1,44 @@
Name: omping
Version: 0.0.1
Release: 3%{?dist}
Summary: Utility to test IP multicast functionality
Group: Applications/Internet
License: ISC
URL: http://fedorahosted.org/omping/
Source0: http://fedorahosted.org/releases/o/m/omping/%{name}-%{version}.tar.gz
Patch0: omping-001-getifaddrs-may-return-NULL-ifa_addr.patch
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
%description
Omping (Open Multicast Ping) is tool to test IP multicast functionality
primarily in local network.
%prep
%setup -q
%patch0 -p1
%build
make %{?_smp_mflags} CFLAGS="%{optflags}"
%install
rm -rf %{buildroot}
make DESTDIR="%{buildroot}" PREFIX="%{_prefix}" install
%clean
rm -rf %{buildroot}
%files
%defattr(-,root,root,-)
%doc AUTHORS COPYING
%{_bindir}/%{name}
%{_mandir}/man8/*
%changelog
* Wed Apr 14 2011 Jan Friesse <jfriesse@redhat.com> - 0.0.1-3
- Resolves rhbz#696509
* Wed Nov 24 2010 Jan Friesse <jfriesse@redhat.com> - 0.0.1-2
- Change hard coded prefix path to macro
* Fri Nov 19 2010 Jan Friesse <jfriesse@redhat.com> - 0.0.1-1
- Initial package for Fedora

View file

@ -0,0 +1 @@
9d1c4e66ae6f35b4ace6dbcc94eb66cb omping-0.0.1.tar.gz