7ce90a3638
- Related: rhbz#2323169
The problem this fixes is a bit complex.
It goes like this:
1. %pyproject_buildrequires runs for the first time.
There is no pyproject.toml, only setup.py, so a dependency on setuptools is generated.
A build dependency on wheel is not generated (as it is not needed on Fedora 42+).
2. %pyproject_buildrequires runs again.
There is no pyproject.toml, only setup.py, so it is used.
A build dependency on wheel is still not generated.
A build dependency on ruamel-yaml-clib is generated when building without bootstrap,
as it is a runtime dependency.
Here it comes: setup.py code creates a pyproject.toml file (with a dependency on wheel) 😱
3a. Without bootstrap, dnf installs ruamel-yaml-clib and %%pyproject_buildrequires runs once more.
It uses pyproject.toml (which now exists).
A build dependency on wheel is now generated and %pyproject_buildrequires runs once more,
dnf install wheel.
3b. With bootstrap, this step is skipped as there was no new dependency (on ruamel-yaml-clib) to trigger it.
4. The final (verification) %pyproject_buildrequires round uses pyproject.toml (which now exists).
Without bootstrap, all is fine, no new dependency is generated.
With bootstrap, the wheel dependency is generated for the first time,
but at this point, it fails rpmbuild (because missing dependencies now fail the build).
We see errors like this as a result:
error: Failed build dependencies:
python3dist(wheel) is needed by python-ruamel-yaml-0.18.6-2.fc42~bootstrap.noarch
Considering the wheel dependency is entirely unneeded I proposed removal for upstream.
An alternative solution is to rm -f pyproject.toml
before calling %pyproject_buildrequires in %generate_buildrequires.
But if upstream switches to a proper pyproject.toml, we might not notice that.
79 lines
2.3 KiB
RPMSpec
79 lines
2.3 KiB
RPMSpec
# Breaks the circular dependency with ruamel.yaml.clib.
|
|
%bcond_with bootstrap
|
|
|
|
%global commit 6f41eb6001661917fceb0e88ed0693ae1a7c50f4
|
|
|
|
Name: python-ruamel-yaml
|
|
Version: 0.18.6
|
|
Release: %autorelease
|
|
Summary: YAML 1.2 loader/dumper package for Python
|
|
|
|
# SPDX
|
|
License: MIT
|
|
URL: https://sourceforge.net/projects/ruamel-yaml
|
|
# The PyPI sdist does not contain tests, so we use a snapshot from SourceForge
|
|
Source: https://sourceforge.net/code-snapshots/hg/r/ru/ruamel-yaml/code/ruamel-yaml-code-%{commit}.zip
|
|
|
|
# Adjust setup.py for the removal of deprecated ast classes
|
|
# Fixes build with Python 3.14
|
|
# https://sourceforge.net/p/ruamel-yaml/code/merge-requests/9/
|
|
Patch: 9.patch
|
|
|
|
# Do not specificity build-system.requires on wheel
|
|
# Fixes the bootstrap build (see commit message for details)
|
|
# https://sourceforge.net/p/ruamel-yaml/code/merge-requests/10/
|
|
Patch: 10.patch
|
|
|
|
BuildArch: noarch
|
|
|
|
%global _description %{expand:
|
|
ruamel.yaml is a YAML parser/emitter that supports roundtrip preservation of
|
|
comments, seq/map flow style, and map key order.}
|
|
|
|
%description %{_description}
|
|
|
|
%package -n python3-ruamel-yaml
|
|
Summary: YAML 1.2 loader/dumper package for Python
|
|
|
|
BuildRequires: python3-devel
|
|
BuildRequires: python3-pytest
|
|
|
|
%py_provides python3-ruamel.yaml
|
|
|
|
%description -n python3-ruamel-yaml %{_description}
|
|
|
|
%prep
|
|
%autosetup -n ruamel-yaml-code-%{commit}
|
|
# Upstream upper-bounds the Python interpeter versions with which the C
|
|
# implementation (ruamel.yaml.clib dependency) may be used. Patch this out.
|
|
sed -r -i 's/( and python_version<"[^"]+")(.*ruamel\.yaml\.clib)/\2/' \
|
|
__init__.py
|
|
%if %{with bootstrap}
|
|
sed -r -i 's/^([[:blank:]]*)(.*ruamel\.yaml\.clib)/\1# \2/' __init__.py
|
|
%endif
|
|
|
|
%generate_buildrequires
|
|
%pyproject_buildrequires
|
|
|
|
%build
|
|
%pyproject_wheel
|
|
|
|
%install
|
|
%pyproject_install
|
|
# RFE: Add option for namespace packages to %%pyproject_save_files
|
|
# https://bugzilla.redhat.com/show_bug.cgi?id=1935266
|
|
%pyproject_save_files -l ruamel
|
|
|
|
%check
|
|
%if %{with bootstrap}
|
|
k="${k-}${k+ and }not test_load_cyaml"
|
|
k="${k-}${k+ and }not test_load_cyaml_1_2"
|
|
k="${k-}${k+ and }not test_dump_cyaml_1_2"
|
|
%endif
|
|
%pytest -k "${k-}" _test/test_*.py
|
|
|
|
%files -n python3-ruamel-yaml -f %{pyproject_files}
|
|
%doc README.md
|
|
|
|
%changelog
|
|
%autochangelog
|