39 lines
1.7 KiB
Diff
39 lines
1.7 KiB
Diff
From ffdb2045006640a7994d4e20a18f6d0cae45624e Mon Sep 17 00:00:00 2001
|
|
From: =?UTF-8?q?Miro=20Hron=C4=8Dok?= <miro@hroncok.cz>
|
|
Date: Thu, 12 Feb 2026 12:12:11 +0100
|
|
Subject: [PATCH] GH-144739: Skip test_pyexpat.MemoryProtectionTest based on
|
|
expat compile-time version, not runtime
|
|
|
|
---
|
|
Lib/test/test_pyexpat.py | 4 +++-
|
|
.../next/Tests/2026-02-12-12-12-00.gh-issue-144739.-fx1tN.rst | 3 +++
|
|
2 files changed, 6 insertions(+), 1 deletion(-)
|
|
create mode 100644 Misc/NEWS.d/next/Tests/2026-02-12-12-12-00.gh-issue-144739.-fx1tN.rst
|
|
|
|
diff --git a/Lib/test/test_pyexpat.py b/Lib/test/test_pyexpat.py
|
|
index 042a3bb9df9..1d0d8ceaa7f 100644
|
|
--- a/Lib/test/test_pyexpat.py
|
|
+++ b/Lib/test/test_pyexpat.py
|
|
@@ -1000,7 +1000,9 @@ def test_set_maximum_amplification__fail_for_subparser(self):
|
|
self.assert_root_parser_failure(setter, 123.45)
|
|
|
|
|
|
-@unittest.skipIf(expat.version_info < (2, 7, 2), "requires Expat >= 2.7.2")
|
|
+@unittest.skipIf(not hasattr(expat.XMLParserType,
|
|
+ "SetAllocTrackerMaximumAmplification"),
|
|
+ "requires Python compiled with Expat >= 2.7.2")
|
|
class MemoryProtectionTest(AttackProtectionTestBase, unittest.TestCase):
|
|
|
|
# NOTE: with the default Expat configuration, the billion laughs protection
|
|
diff --git a/Misc/NEWS.d/next/Tests/2026-02-12-12-12-00.gh-issue-144739.-fx1tN.rst b/Misc/NEWS.d/next/Tests/2026-02-12-12-12-00.gh-issue-144739.-fx1tN.rst
|
|
new file mode 100644
|
|
index 00000000000..955ec49ee4f
|
|
--- /dev/null
|
|
+++ b/Misc/NEWS.d/next/Tests/2026-02-12-12-12-00.gh-issue-144739.-fx1tN.rst
|
|
@@ -0,0 +1,3 @@
|
|
+When Python was compiled with system expat older then 2.7.2 but tests run
|
|
+with newer expat, still skip
|
|
+:class:`test.test_pyexpat.MemoryProtectionTest`.
|
|
--
|
|
2.53.0
|
|
|