rpminspect: Don't run annocheck on test binaries

[skip changelog]

.fmf/version

@@ -0,0 +1 @@
+1

.gitignore

@@ -1,225 +1,4 @@
-samba-3.5.4.tar.gz
-samba-3.6.0pre1.tar.gz
-/samba-3.6.0pre2.tar.gz
-/samba-3.6.0pre3.tar.gz
-/samba-3.6.0rc1.tar.gz
-/samba-3.6.0rc2.tar.gz
-/samba-3.6.0rc3.tar.gz
-/samba-3.6.0.tar.gz
-/samba-3.6.1.tar.gz
-/samba-3.6.3.tar.gz
-/samba-3.6.4.tar.gz
-/samba-3.6.5.tar.gz
-/samba-3.6.6.tar.gz
-/samba-3.6.7.tar.gz
-/samba-4.0.0rc1.tar.bz2
-/samba-4.0.0rc2.tar.bz2
-/samba-4.0.0rc3.tar.bz2
-/samba-4.0.0rc4.tar.bz2
-/samba-4.0.0rc5.tar.bz2
-/samba-4.0.0rc6.tar.bz2
-/samba-4.0.0.tar.bz2
-/samba-4.0.1.tar.bz2
-/samba-4.0.2.tar.bz2
-/samba-4.0.3.tar.bz2
-/samba-4.0.4.tar.bz2
-/samba-4.0.5.tar.bz2
-/samba-4.0.6.tar.bz2
-/samba-4.0.7.tar.xz
-/samba-4.1.0rc1.tar.xz
-/samba-4.1.0rc2.tar.xz
-/samba-4.1.0rc3.tar.xz
-/samba-4.1.0rc4.tar.xz
-/samba-4.1.0.tar.xz
-/samba-4.1.1.tar.xz
-/samba-4.1.2.tar.xz
-/samba-4.1.3.tar.xz
-/samba-4.1.4.tar.xz
-/samba-4.1.5.tar.xz
-/samba-4.1.6.tar.xz
-/samba-4.1.8.tar.xz
-/samba-4.1.9.tar.xz
-/samba-4.1.11.tar.gz
-/samba-4.1.11.tar.xz
-/samba-4.1.12.tar.xz
-/samba-4.2.0rc2.tar.xz
-/samba-4.2.0rc3.tar.xz
-/samba-4.2.0rc4.tar.xz
-/samba-4.2.0rc5.tar.xz
-/samba-4.2.0.tar.xz
-/samba-4.2.1.tar.xz
-/samba-4.2.2.tar.xz
-/samba-4.2.3.tar.xz
-/samba-4.3.0rc3.tar.xz
-/samba-4.3.0rc4.tar.xz
-/samba-4.3.0.tar.xz
-/samba-4.3.1.tar.xz
-/samba-4.3.2.tar.xz
-/samba-4.3.3.tar.xz
-/samba-4.3.4.tar.xz
-/samba-4.4.0rc1.tar.xz
-/samba-4.4.0rc2.tar.xz
-/samba-4.4.0rc3.tar.xz
-/samba-4.4.0rc4.tar.xz
-/samba-4.4.0rc5.tar.xz
-/samba-4.4.0.tar.xz
-/samba-4.4.2.tar.xz
-/samba-4.4.3.tar.xz
-/samba-4.4.4.tar.xz
-/samba-4.4.5.tar.xz
-/samba-4.5.0rc1.tar.xz
-/samba-4.5.0rc2.tar.xz
-/samba-4.5.0rc3.tar.xz
-/samba-4.5.0.tar.xz
-/samba-4.5.1.tar.xz
-/samba-4.5.2.tar.xz
-/samba-4.5.3.tar.xz
-/samba-4.6.0rc1.tar.xz
-/samba-4.6.0rc2.tar.xz
-/samba-4.6.0rc2.tar.asc
-/samba-4.6.0rc3.tar.asc
-/samba-4.6.0rc3.tar.xz
-/samba-4.6.0rc4.tar.xz
-/samba-4.6.0rc4.tar.asc
-/samba-4.6.0.tar.asc
-/samba-4.6.0.tar.xz
-/samba-4.6.1.tar.xz
-/samba-4.6.1.tar.asc
-/samba-4.6.2.tar.xz
-/samba-4.6.2.tar.asc
-/samba-4.6.3.tar.xz
-/samba-4.6.3.tar.asc
-/samba-4.6.4.tar.xz
-/samba-4.6.4.tar.asc
-/samba-4.6.5.tar.xz
-/samba-4.6.5.tar.asc
-/samba-4.7.0rc1.tar.xz
-/samba-4.7.0rc1.tar.asc
-/samba-4.7.0rc3.tar.xz
-/samba-4.7.0rc3.tar.asc
-/samba-4.7.0rc5.tar.xz
-/samba-4.7.0rc5.tar.asc
-/samba-4.7.0rc6.tar.xz
-/samba-4.7.0rc6.tar.asc
-/samba-4.7.0.tar.xz
-/samba-4.7.0.tar.asc
-/samba-4.7.1.tar.xz
-/samba-4.7.1.tar.asc
-/samba-4.7.2.tar.xz
-/samba-4.7.2.tar.asc
-/samba-4.7.3.tar.xz
-/samba-4.7.3.tar.asc
-/samba-4.7.4.tar.xz
-/samba-4.7.4.tar.asc
-/samba-4.8.0rc1.tar.xz
-/samba-4.8.0rc1.tar.asc
-/samba-4.8.0rc2.tar.xz
-/samba-4.8.0rc2.tar.asc
-/samba-4.8.0rc3.tar.xz
-/samba-4.8.0rc3.tar.asc
-/samba-4.8.0rc4.tar.xz
-/samba-4.8.0rc4.tar.asc
-/samba-4.8.0.tar.xz
-/samba-4.8.0.tar.asc
-/samba-4.8.1.tar.xz
-/samba-4.8.1.tar.asc
-/samba-4.8.2.tar.xz
-/samba-4.8.2.tar.asc
-/samba-4.8.3.tar.asc
-/samba-4.8.3.tar.xz
-/samba-4.9.0rc1.tar.xz
-/samba-4.9.0rc1.tar.asc
-/samba-4.9.0rc2.tar.xz
-/samba-4.9.0rc2.tar.asc
-/samba-4.9.0rc3.tar.xz
-/samba-4.9.0rc3.tar.asc
-/samba-4.9.0rc4.tar.xz
-/samba-4.9.0rc4.tar.asc
-/samba-4.9.0rc5.tar.asc
-/samba-4.9.0rc5.tar.xz
-/samba-4.9.0.tar.xz
-/samba-4.9.0.tar.asc
-/samba-4.9.1.tar.asc
-/samba-4.9.1.tar.xz
-/samba-4.9.2.tar.xz
-/samba-4.9.2.tar.asc
-/samba-4.9.3.tar.xz
-/samba-4.9.3.tar.asc
-/samba-4.9.4.tar.xz
-/samba-4.9.4.tar.asc
-/samba-4.10.0rc1.tar.xz
-/samba-4.10.0rc1.tar.asc
-/samba-4.10.0rc2.tar.xz
-/samba-4.10.0rc2.tar.asc
-/samba-4.10.0rc3.tar.xz
-/samba-4.10.0rc3.tar.asc
-/samba-4.10.0rc4.tar.xz
-/samba-4.10.0rc4.tar.asc
-/samba-4.10.0.tar.xz
-/samba-4.10.0.tar.asc
-/samba-4.10.1.tar.xz
-/samba-4.10.1.tar.asc
-/samba-4.10.2.tar.xz
-/samba-4.10.2.tar.asc
-/samba-4.10.3.tar.xz
-/samba-4.10.3.tar.asc
-/samba-4.10.4.tar.xz
-/samba-4.10.4.tar.asc
-/samba-4.10.5.tar.xz
-/samba-4.10.5.tar.asc
-/samba-4.10.6.tar.xz
-/samba-4.10.6.tar.asc
-/samba-4.11.0rc1.tar.xz
-/samba-4.11.0rc1.tar.asc
-/samba-4.11.0rc2.tar.xz
-/samba-4.11.0rc2.tar.asc
-/samba-4.11.0rc3.tar.xz
-/samba-4.11.0rc3.tar.asc
-/samba-4.11.0rc4.tar.xz
-/samba-4.11.0rc4.tar.asc
-/samba-4.11.0.tar.xz
-/samba-4.11.0.tar.asc
-/samba-4.11.1.tar.xz
-/samba-4.11.1.tar.asc
-/samba-4.11.2.tar.xz
-/samba-4.11.2.tar.asc
-/samba-4.11.3.tar.xz
-/samba-4.11.3.tar.asc
-/samba-4.11.4.tar.xz
-/samba-4.11.4.tar.asc
-/samba-4.11.5.tar.xz
-/samba-4.11.5.tar.asc
-/samba-4.12.0rc1.tar.xz
-/samba-4.12.0rc1.tar.asc
-/samba-4.12.0rc2.tar.xz
-/samba-4.12.0rc2.tar.asc
-/samba-4.12.0rc3.tar.xz
-/samba-4.12.0rc3.tar.asc
-/samba-4.12.0rc4.tar.xz
-/samba-4.12.0rc4.tar.asc
-/samba-4.12.0.tar.xz
-/samba-4.12.0.tar.asc
-/samba-4.12.1.tar.xz
-/samba-4.12.1.tar.asc
-/samba-4.12.2.tar.xz
-/samba-4.12.2.tar.asc
-/samba-4.12.3.tar.xz
-/samba-4.12.3.tar.asc
-/samba-4.12.4.tar.xz
-/samba-4.12.4.tar.asc
-/samba-4.12.5.tar.xz
-/samba-4.12.5.tar.asc
-/samba-4.13.0rc1.tar.xz
-/samba-4.13.0rc1.tar.asc
-/samba-4.13.0rc2.tar.xz
-/samba-4.13.0rc2.tar.asc
-/samba-4.13.0rc3.tar.xz
-/samba-4.13.0rc3.tar.asc
-/samba-4.13.0rc4.tar.xz
-/samba-4.13.0rc4.tar.asc
-/samba-4.13.0rc5.tar.xz
-/samba-4.13.0rc5.tar.asc
-/samba-4.13.0rc6.tar.xz
-/samba-4.13.0rc6.tar.asc
-/samba-4.13.0.tar.xz
-/samba-4.13.0.tar.asc
+/samba-*.tar.xz
+/samba-*.tar.asc
+/*.rpm
+/results_samba

filter-requires-samba.sh

@@ -1,3 +0,0 @@
-#!/bin/sh
-
-/usr/lib/rpm/perl.req $* | grep -E -v '(Net::LDAP|Crypt::SmbHash|CGI|Unicode::MapUTF8|smbldap_tools|Carp|Convert::ASN1|Getopt::Long|Getopt::Std|IO::Socket|POSIX|Time::Local|strict)'

gating.yaml

@@ -0,0 +1,6 @@
+--- !Policy
+product_versions:
+  - fedora-*
+decision_context: bodhi_update_push_stable
+rules:
+  - !PassingTestCaseRule {test_case_name: fedora-ci.koji-build.tier0.functional}

plans.fmf

@@ -0,0 +1,4 @@
+discover:
+    how: fmf
+execute:
+    how: tmt

rpminspect.yaml

@@ -0,0 +1,35 @@
+---
+inspections:
+    disttag: off
+
+badfuncs:
+    ignore:
+        - /usr/bin/nmbd
+        - /usr/bin/nmblookup
+        - /usr/bin/smbtorture
+        - /usr/lib*/libndr.so.*
+        - /usr/lib*/libsmbconf.so.*
+        - /usr/lib*/samba/libgse-private-samba.so
+        - /usr/lib*/samba/libsamba-sockets-private-samba.so
+        - /usr/lib*/samba/service/nbtd.so
+        - /usr/libexec/ctdb/smnotify
+        - /usr/sbin/nmbd
+
+runpath:
+    allowed_paths:
+        - /usr/lib/samba
+        - /usr/lib64/samba
+
+abidiff:
+    suppression_file: samba.abignore
+
+debuginfo:
+    ignore:
+        - /usr/lib*/libdcerpc-samr.so.*
+
+annocheck:
+    ignore:
+        - /usr/bin/gentest
+        - /usr/bin/locktest
+        - /usr/bin/masktest
+        - /usr/bin/smbtorture

samba-4.23-fix-cmocka.patch

@@ -0,0 +1,38 @@
+From b1ec803f420b2c6d3c5c83d70c6875a7f36b15fc Mon Sep 17 00:00:00 2001
+From: Andreas Schneider <asn@samba.org>
+Date: Fri, 21 Nov 2025 15:33:32 +0100
+Subject: [PATCH] s4:dsdb: Do not declare cm_print_error()
+
+This is part of the cmocka.h header file.
+
+Signed-off-by: Andreas Schneider <asn@samba.org>
+Reviewed-by: Martin Schwenke <martin@meltin.net>
+Reviewed-by: Volker Lendecke <vl@samba.org>
+
+Autobuild-User(master): Volker Lendecke <vl@samba.org>
+Autobuild-Date(master): Mon Nov 24 11:28:08 UTC 2025 on atb-devel-224
+
+(cherry picked from commit 5a981663e4f677042ba80191770100aecff2120a)
+---
+ source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c | 5 -----
+ 1 file changed, 5 deletions(-)
+
+diff --git a/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c b/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
+index f7075f3485e..12c464b49c7 100644
+--- a/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
++++ b/source4/dsdb/samdb/ldb_modules/tests/test_group_audit.c
+@@ -103,11 +103,6 @@ void audit_message_send(
+ 
+ #define check_group_change_message(m, u, a, e)                                 \
+ 	_check_group_change_message(m, u, a, e, __FILE__, __LINE__);
+-/*
+- * declare the internal cmocka cm_print_error so that we can output messages
+- * in sub unit format
+- */
+-void cm_print_error(const char * const format, ...);
+ 
+ /*
+  * Validate a group change JSON audit message
+-- 
+2.52.0
+

samba-systemd-sysusers.conf

@@ -0,0 +1,2 @@
+#Type Name       ID
+g     printadmin -

samba-usershares-systemd-sysusers.conf

@@ -0,0 +1,2 @@
+#Type Name       ID
+g     usershares -

samba-winbind-systemd-sysusers.conf

@@ -0,0 +1,2 @@
+#Type Name       ID
+g     wbpriv     88

samba.abignore

@@ -0,0 +1,5 @@
+#################################################
+# This is a grouping library without any code
+#################################################
+[suppress_file]
+file_name_regexp=.*libdcerpc-samr\\.so.*

samba.logrotate

@@ -1,4 +1,4 @@
-/var/log/samba/log.* {
+/var/log/samba/*log* {
     compress
     dateext
     maxage 365

smb.conf.example

@@ -269,6 +269,13 @@
 ;	map system = no
 ;	store dos attributes = yes
 
+# Turn on SMB 3.1.1 Unix Extensions by default
+#
+# Note: The Linux Kernel SMB3 client will negotiate unix extensions by default,
+# find more info in man mount.smb3(8). Linux 6.13 will finally support special
+# filetypes and symlink handling.
+
+	smb3 unix extensions = yes
 
 #============================ Share Definitions ==============================
 
@@ -281,7 +288,7 @@
 
 [printers]
 	comment = All Printers
-	path = /var/spool/samba
+	path = /var/tmp
 	browseable = no
 	guest ok = no
 	writable = no

smb.conf.vendor

@@ -18,6 +18,9 @@
 	load printers = yes
 	cups options = raw
 
+	# Install samba-usershares package for support
+	include = /etc/samba/usershares.conf
+
 [homes]
 	comment = Home Directories
 	valid users = %S, %D%w%S
@@ -35,7 +38,8 @@
 [print$]
 	comment = Printer Drivers
 	path = /var/lib/samba/drivers
-	write list = @printadmin root
-	force group = @printadmin
+	# printadmin is a local group
+	write list = printadmin root
+	force group = printadmin
 	create mask = 0664
 	directory mask = 0775

sources

@@ -1,2 +1,2 @@
-SHA512 (samba-4.13.0.tar.xz) = 38370adfad7b7a9a8633d48782f0bcf812299858be20770d2e3406c7f450a2fd1ae646e2a143d22ce3c5ac22d54c4a229b019686ff2f16ca503c958d4afed825
-SHA512 (samba-4.13.0.tar.asc) = 7f71d1402d752cbdb09ec9e2539d35347c4025c332c4acb8590d5cab190b2b23bc2b1f99f3d66c3488bbdb6898528dd78e3893c33c92e3d9167236e8048dfbf2
+SHA512 (samba-4.23.4.tar.xz) = 58979aa8a83e8210918f4f1adbcadff329e57a9cd25d7aba98d18f54a2e790a7ef3cc6b9fb3303d492d33d67f4a135849a419c95644d14e53a39654736d486ac
+SHA512 (samba-4.23.4.tar.asc) = 0981ce6a43202953cdc7ceae77fa0e3b4ab853991430dde4df6daa163984de6c7ca3f3a3037376659d3bdaedcc108cdd7a77ce0ac24d0a1add56c7103fca7dce

tests/deps-check.fmf

@@ -0,0 +1,22 @@
+summary: Check samba package dependency structure
+description: |
+    Verify that samba library packages maintain correct dependency hierarchy:
+    - samba-core-libs has no samba-*-libs dependencies
+    - samba-ndr-libs depends on samba-core-libs (not samba-client-libs or samba-libs)
+    - samba-client-libs depends on core-libs + ndr-libs (not samba-libs)
+    - samba-client depends on samba-client-libs (not samba-libs)
+    - samba-libs does not depend on samba-dc-libs
+    - libsmbclient depends on samba-client-libs (not samba-libs)
+    - libwbclient has no samba-*-libs dependencies
+    - libldb has no samba-*-libs dependencies
+test: ./deps-check.sh
+framework: shell
+require:
+  - samba-core-libs
+  - samba-ndr-libs
+  - samba-client-libs
+  - samba-libs
+  - samba-client
+  - libwbclient
+  - libsmbclient
+  - libldb

tests/deps-check.sh

@@ -0,0 +1,167 @@
+#!/bin/bash
+#
+# Samba package dependency structure verification
+#
+# This test ensures that the samba library package dependencies don't regress.
+# The expected hierarchy is:
+#
+#   samba-core-libs    (no samba-*-libs dependencies)
+#        ^
+#        |
+#   samba-ndr-libs     (depends on samba-core-libs only)
+#        ^
+#        |
+#   samba-client-libs  (depends on samba-core-libs + samba-ndr-libs)
+#
+#   libwbclient        (no samba-*-libs dependencies - only links to libc)
+#
+#   samba-client       (depends on samba-client-libs, NOT samba-libs)
+#   libsmbclient       (depends on samba-client-libs, NOT samba-libs)
+#
+# NOTE: This test checks RESOLVED dependencies, not just explicit Requires.
+# A library requirement like 'libfoo.so' is resolved to the package that
+# provides it, ensuring we catch indirect dependencies.
+#
+
+set -e
+
+ERRORS=0
+
+# Get all packages that a package depends on (resolved)
+# This resolves library deps like 'libfoo.so' to actual package names
+get_resolved_deps() {
+    local pkg="$1"
+
+    rpm --query --requires "$pkg" 2>/dev/null | while read -r req; do
+        # Skip rpmlib and config requirements
+        [[ "$req" =~ ^rpmlib ]] && continue
+        [[ "$req" =~ ^config ]] && continue
+        [[ "$req" =~ ^/ ]] && continue
+
+        # Get the package that provides this requirement
+        provider=$(rpm --query --whatprovides "$req" 2>/dev/null | head -1)
+        if [ -n "$provider" ] && [ "$provider" != "no package provides $req" ]; then
+            # Extract just the package name (remove version-release.arch)
+            echo "${provider%%-[0-9]*}"
+        fi
+    done | sort -u
+}
+
+# Check that a package does NOT depend on packages matching a pattern
+# This checks RESOLVED dependencies (what packages actually get pulled in)
+check_no_resolved_dep() {
+    local pkg="$1"
+    local pattern="$2"
+    local description="$3"
+
+    if ! rpm --query "$pkg" &>/dev/null; then
+        echo "SKIP: $pkg not installed"
+        return 0
+    fi
+
+    local bad_deps
+    # Exclude the package itself from the check
+    bad_deps=$(get_resolved_deps "$pkg" | grep -v "^${pkg}$" | grep -E "$pattern" || true)
+
+    if [ -n "$bad_deps" ]; then
+        echo "FAIL: $pkg depends on $description"
+        echo "  Found: $bad_deps"
+        ERRORS=$((ERRORS + 1))
+        return 1
+    fi
+    echo "PASS: $pkg does not depend on $description"
+    return 0
+}
+
+# Check that a package DOES depend on a specific package
+check_has_resolved_dep() {
+    local pkg="$1"
+    local expected="$2"
+
+    if ! rpm --query "$pkg" &>/dev/null; then
+        echo "SKIP: $pkg not installed"
+        return 0
+    fi
+
+    if get_resolved_deps "$pkg" | grep -qF "$expected"; then
+        echo "PASS: $pkg depends on $expected"
+        return 0
+    fi
+    echo "FAIL: $pkg does not depend on $expected"
+    ERRORS=$((ERRORS + 1))
+    return 1
+}
+
+echo "=== Samba Package Dependency Checks ==="
+echo ""
+echo "Checking resolved dependencies (library deps resolved to packages)"
+echo ""
+
+# 1. samba-core-libs must NOT depend on any samba-*-libs packages
+echo "--- samba-core-libs ---"
+check_no_resolved_dep samba-core-libs "^samba-.*-libs$" "any samba*-libs package"
+
+echo ""
+
+# 2. samba-ndr-libs must depend on samba-core-libs
+#    but NOT samba-client-libs or samba-libs
+echo "--- samba-ndr-libs ---"
+check_has_resolved_dep samba-ndr-libs "samba-core-libs"
+check_no_resolved_dep samba-ndr-libs "^samba-client-libs$" "samba-client-libs"
+check_no_resolved_dep samba-ndr-libs "^samba-libs$" "samba-libs"
+
+echo ""
+
+# 3. samba-client-libs must depend on samba-core-libs and samba-ndr-libs
+#    but NOT samba-libs
+echo "--- samba-client-libs ---"
+check_has_resolved_dep samba-client-libs "samba-core-libs"
+check_has_resolved_dep samba-client-libs "samba-ndr-libs"
+check_no_resolved_dep samba-client-libs "^samba-libs$" "samba-libs"
+
+echo ""
+
+# 4. libwbclient must NOT depend on any samba-*-libs packages
+echo "--- libwbclient ---"
+check_no_resolved_dep libwbclient "^samba-.*-libs$" "any samba*-libs package"
+
+echo ""
+
+# 5. samba-client must depend on samba-client-libs but NOT samba-libs
+#    (client tools should not pull in server libraries)
+echo "--- samba-client ---"
+check_has_resolved_dep samba-client "samba-client-libs"
+check_no_resolved_dep samba-client "^samba-libs$" "samba-libs"
+
+echo ""
+
+# 6. libsmbclient must depend on samba-client-libs but NOT samba-libs
+#    (SMB client library should not pull in server libraries)
+echo "--- libsmbclient ---"
+check_has_resolved_dep libsmbclient "samba-client-libs"
+check_no_resolved_dep libsmbclient "^samba-libs$" "samba-libs"
+
+echo ""
+
+# 7. libldb must NOT depend on any samba-*-libs packages
+#    (libldb is a standalone database library)
+echo "--- libldb ---"
+check_no_resolved_dep libldb "^samba-.*-libs$" "any samba*-libs package"
+
+echo ""
+
+# 8. samba-libs must NOT depend on samba-dc-libs
+#    (server libraries should not pull in DC-specific libraries)
+echo "--- samba-libs ---"
+check_no_resolved_dep samba-libs "^samba-dc-libs$" "samba-dc-libs"
+
+echo ""
+echo "=== Summary ==="
+
+if [ $ERRORS -gt 0 ]; then
+    echo "FAILED: $ERRORS dependency check(s) failed"
+    exit 1
+fi
+
+echo "All dependency checks passed"
+exit 0

usershares.conf.vendor

@@ -0,0 +1,3 @@
+[global]
+	usershare max shares = 100
+	usershare allow guests = yes