rpms/toolbox
3
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
The toolbox package
138 commits 18 branches 0 tags 355 KiB
Find a file
Adam Williamson ee2fa0eab4 tests: Ensure slirp4netns(1) is installed 
Podman 5.0 switched to using pasta(1), instead of slirp4netns(1), by
default for rootless containers.  This change has led to a regression
causing 'skopeo copy' to get stuck uploading an OCI image to the local
temporary Docker registry run by the tests as a Podman container [1],
which breaks the test suite on Fedora 40 onwards.

This was worked around by forcing the use of slirp4netns(1).

The slirp4nets package needs to be explicitly installed on Fedora 40
onwards, because the dependency in containers-common-extra changed from
Recommends to Suggests [2].  Otherwise, it led to:
  1..320
  # test suite: Set up
  # test suite: Tear down
  not ok 1 setup_suite
  # (from function `assert_success' in file
       ./libs/bats-assert/src/assert.bash, line 114,
  #  from function `_setup_docker_registry' in file ./libs/helpers.bash,
       line 208,
  #  from function `setup_suite' in test file ./setup_suite.bash, line
       59)
  #   `_setup_docker_registry' failed
  #
  # -- command failed --
  # status : 127
  # output : Error: could not find slirp4netns, the network namespace
      can't be configured: exec: "slirp4netns": executable file not
      found in $PATH
  # --
  #
  # Untagged: quay.io/toolbox_tests/registry:latest
  # Deleted: fea5a12cde107bb407bc44ede6dd9edea1d2b4171cd8e52b0cb330bf45e517e1
  # bats warning: Executed 1 instead of expected 320 tests

The missing dependency on the slirp4netns package in toolbox-tests
doesn't affect Podman's downstream Fedora CI, which runs toolbox-tests,
because it separately installs slirp4netns for other tests [3].

Fallout from d8388da39e

[1] https://github.com/containers/podman/issues/22575

[2] Fedora containers-common commit 17934d87b2686ab5
    Fedora containers-common commit 13c232f064113860
    https://src.fedoraproject.org/rpms/containers-common/c/17934d87b2686ab5
    https://src.fedoraproject.org/rpms/containers-common/c/13c232f064113860

[3] Fedora podman commit 9667d0f5b5069acb
    https://src.fedoraproject.org/rpms/podman/c/9667d0f5b5069acb

https://src.fedoraproject.org/rpms/toolbox/pull-request/20

Signed-off-by: Adam Williamson <awilliam@redhat.com>
2024-08-08 17:00:12 +02:00
tests tests: Ensure slirp4netns(1) is installed 2024-08-08 17:00:12 +02:00
.gitignore Update to 0.0.99.5 2023-12-19 13:28:45 +01:00
gating.yaml Added fedora gating 2021-08-18 12:41:51 +01:00
README.md Added the README 2019-03-01 16:46:10 +00:00
rpminspect.yaml Silence 'rpminspect --tests=stack-prot' 2024-07-11 10:58:36 +02:00
sources Update to 0.0.99.5 2023-12-19 13:28:45 +01:00
toolbox-Add-migration-paths-for-coreos-toolbox-users.patch Add missing files for RHEL builds 2023-06-26 15:08:36 +02:00
toolbox-Make-the-build-flags-match-Fedora-s-gobuild-for-PPC64.patch Update to 0.0.99.5 2023-12-19 13:28:45 +01:00
toolbox-Make-the-build-flags-match-Fedora-s-gobuild.patch Update to 0.0.99.5 2023-12-19 13:28:45 +01:00
toolbox-Make-the-build-flags-match-RHEL-s-gobuild-for-PPC64.patch Pull in the rest of the RHEL specific patches to further unify the build 2023-06-26 15:27:07 +02:00
toolbox-Make-the-build-flags-match-RHEL-s-gobuild.patch Pull in the rest of the RHEL specific patches to further unify the build 2023-06-26 15:27:07 +02:00
toolbox-playbooks-test-system-bats-1.11-podman-5.patch Unbreak the tests with Podman 5.0 2024-05-07 00:45:50 +02:00
toolbox-test-system-new.patch Unbreak Podman's downstream Fedora CI (part 2) 2024-02-27 16:12:07 +01:00
toolbox-test-system-Unbreak-Podman-s-downstream-Fedora-CI.patch Unbreak Podman's downstream Fedora CI (part 2) 2024-02-27 16:12:07 +01:00
toolbox.conf Add missing files for RHEL builds 2023-06-26 15:08:36 +02:00
toolbox.spec tests: Ensure slirp4netns(1) is installed 2024-08-08 17:00:12 +02:00

README.md

toolbox

The toolbox package