Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild

- Fix cloud init

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>

.gitignore

@@ -1 +1,2 @@
 /virt-manager-*.tar.gz
+/virt-manager-*.tar.xz

0001-virtinst-cloudinit-include-empty-meta-data-file.patch

@@ -0,0 +1,32 @@
+From ea71cf9a8a4161ce6e19eacf5f0d86d40ab74f23 Mon Sep 17 00:00:00 2001
+Message-ID: <ea71cf9a8a4161ce6e19eacf5f0d86d40ab74f23.1767794644.git.phrdina@redhat.com>
+From: Pavel Hrdina <phrdina@redhat.com>
+Date: Mon, 29 Sep 2025 16:14:35 +0200
+Subject: [PATCH] virtinst: cloudinit: include empty meta-data file
+
+Refactor creation of cloud-init config files introduced a bug where we
+stopped including empty meta-data file.
+
+Introduced-by: 5b2d0997a1d2d213b17c227169da64e2fa7d09a6
+Fixes: https://github.com/virt-manager/virt-manager/issues/975
+Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
+---
+ virtinst/install/cloudinit.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/virtinst/install/cloudinit.py b/virtinst/install/cloudinit.py
+index 3f565f399..b2378fbfa 100644
+--- a/virtinst/install/cloudinit.py
++++ b/virtinst/install/cloudinit.py
+@@ -36,7 +36,7 @@ class _CloudInitConfig:
+     def _create_file(self):
+         content = self._content()
+ 
+-        if not content:
++        if content is None:
+             return None
+ 
+         fileobj = tempfile.NamedTemporaryFile(
+-- 
+2.52.0
+

sources

@@ -1 +1 @@
-SHA512 (virt-manager-2.0.0.tar.gz) = 5d0eb65dceb5c913973edaa52414b1665d1ed9cd3f226e28a592decddec2acd8fdb589f60736edf9b7d95830893812f9aecca2cbdd715033ca7ea53a95472876
+SHA512 (virt-manager-5.1.0.tar.xz) = 6306500ae442a6ccb36d5f19bc26b0e32984ca145ee8d41a475e175ee4db6c0d253f0cf9d908c30e3269cf7aabdad4bbd30e84f3cd0477f233da1e43e0235e3c

virt-manager.spec

@@ -1,35 +1,33 @@
 # -*- rpm-spec -*-
 
-# RPM doesn't detect that code in /usr/share is python3, this forces it
-# https://fedoraproject.org/wiki/Changes/Avoid_usr_bin_python_in_RPM_Build#Python_bytecompilation
-%global __python %{__python3}
+%global default_hvs         "qemu,xen,lxc"
+%global have_spice          %{defined fedora}
 
 
-%global with_guestfs               0
-%global default_hvs                "qemu,xen,lxc"
-
 
 # End local config
 
 Name: virt-manager
-Version: 2.0.0
-Release: 1%{?dist}
+Version: 5.1.0
+Release: 5%{?dist}
 %global verrel %{version}-%{release}
 
 Summary: Desktop tool for managing virtual machines via libvirt
-Group: Applications/Emulators
-License: GPLv2+
+License: GPL-2.0-or-later
 BuildArch: noarch
 URL: https://virt-manager.org/
-Source0: https://virt-manager.org/download/sources/%{name}/%{name}-%{version}.tar.gz
+Source0: https://releases.pagure.org/%{name}/%{name}-%{version}.tar.xz
 
+Patch1: 0001-virtinst-cloudinit-include-empty-meta-data-file.patch
 
 Requires: virt-manager-common = %{verrel}
-Requires: python3-gobject
-Requires: gtk3
+Requires: python3-gobject >= 3.31.3
+Requires: gtk3 >= 3.22.0
 Requires: libvirt-glib >= 0.0.9
 Requires: gtk-vnc2
+%if %{have_spice}
 Requires: spice-gtk3
+%endif
 
 # virt-manager is one of those apps that people will often install onto
 # a headless machine for use over SSH. This means the virt-manager dep
@@ -37,7 +35,12 @@ Requires: spice-gtk3
 # Unfortunately nothing in our chain has an explicit dep on some kind
 # of usable gsettings backend, so we explicitly depend on dconf so that
 # user settings actually persist across app runs.
+#
+# That said, we skip this dep for flatpak, where dconf isn't used in
+# the runtime. gsettings defaults to ini file in that case
+%if ! 0%{?flatpak}
 Requires: dconf
+%endif
 
 # The vte291 package is actually the latest vte with API version 2.91, while
 # the vte3 package is effectively a compat package with API version 2.90.
@@ -45,13 +48,21 @@ Requires: dconf
 # no ambiguity.
 Requires: vte291
 
+# We can use GtkTextView, gtksourceview 3 or gtksourceview4, recommend
+# the latest one but don't make it a hard requirement
+Recommends: gtksourceview4
+
 # Weak dependencies for the common virt-manager usecase
 Recommends: (libvirt-daemon-kvm or libvirt-daemon-qemu)
 Recommends: libvirt-daemon-config-network
 
-BuildRequires: intltool
-BuildRequires: /usr/bin/pod2man
+# Optional inspection of guests
+Suggests: python3-libguestfs
+
+BuildRequires: gettext
 BuildRequires: python3-devel
+BuildRequires: python3-docutils
+BuildRequires: meson
 
 
 %description
@@ -64,16 +75,16 @@ management API.
 
 %package common
 Summary: Common files used by the different Virtual Machine Manager interfaces
-Group: Applications/Emulators
 
+Requires: python3-argcomplete
 Requires: python3-libvirt
 Requires: python3-libxml2
 Requires: python3-requests
 Requires: libosinfo >= 0.2.10
 # Required for gobject-introspection infrastructure
 Requires: python3-gobject-base
-# Required for pulling files from iso media with isoinfo
-Requires: genisoimage
+# Required for pulling files from iso media
+Requires: xorriso
 
 %description common
 Common files used by the different virt-manager interfaces, as well as
@@ -89,7 +100,6 @@ Requires: libvirt-client
 
 Provides: virt-install
 Provides: virt-clone
-Provides: virt-convert
 Provides: virt-xml
 
 %description -n virt-install
@@ -99,76 +109,244 @@ machine).
 
 
 %prep
-%setup -q
+%autosetup -p1
 
 
 %build
-%if %{default_hvs}
-%global _default_hvs --default-hvs %{default_hvs}
+%if ! %{have_spice}
+%global _default_graphics -Ddefault-graphics=vnc
 %endif
 
-./setup.py configure \
-    %{?_default_hvs}
-
+%meson \
+    -Ddefault-hvs=%{default_hvs} \
+    %{?_default_graphics} \
+    -Dupdate-icon-cache=false \
+    -Dcompile-schemas=false \
+    -Dtests=disabled
+%meson_build
 
 %install
-./setup.py \
-    --no-update-icon-cache --no-compile-schemas \
-    install -O1 --root=%{buildroot}
+%meson_install
+
 %find_lang %{name}
 
-# Replace '#!/usr/bin/env python3' with '#!/usr/bin/python3'
-# The format is ideal for upstream, but not a distro. See:
-# https://fedoraproject.org/wiki/Features/SystemPythonExecutablesUseSystemPython
-for f in $(find %{buildroot} -type f -executable -print); do
-    sed -i "1 s|^#!/usr/bin/env python3|#!%{__python3}|" $f || :
-done
+%if 0%{?py_byte_compile:1}
+# https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_Appendix/#manual-bytecompilation
+%py_byte_compile %{__python3} %{buildroot}%{_datadir}/virt-manager/
+%endif
+
 
 
 %files
-%doc README.md COPYING NEWS.md
 %{_bindir}/%{name}
 
 %{_mandir}/man1/%{name}.1*
 
-%{_datadir}/%{name}/ui/*.ui
-%{_datadir}/%{name}/virt-manager
+%{_datadir}/%{name}/ui
 %{_datadir}/%{name}/virtManager
 
 %{_datadir}/%{name}/icons
 %{_datadir}/icons/hicolor/*/apps/*
 
-%{_datadir}/appdata/%{name}.appdata.xml
 %{_datadir}/applications/%{name}.desktop
 %{_datadir}/glib-2.0/schemas/org.virt-manager.virt-manager.gschema.xml
+%{_datadir}/metainfo/%{name}.appdata.xml
 
 
 %files common -f %{name}.lang
-%dir %{_datadir}/%{name}
+%license COPYING
+%doc README.md NEWS.md
 
-%{_datadir}/%{name}/virtcli
-%{_datadir}/%{name}/virtconv
+%dir %{_datadir}/%{name}
 %{_datadir}/%{name}/virtinst
 
 
 %files -n virt-install
 %{_mandir}/man1/virt-install.1*
 %{_mandir}/man1/virt-clone.1*
-%{_mandir}/man1/virt-convert.1*
 %{_mandir}/man1/virt-xml.1*
 
-%{_datadir}/%{name}/virt-install
-%{_datadir}/%{name}/virt-clone
-%{_datadir}/%{name}/virt-convert
-%{_datadir}/%{name}/virt-xml
+%{_datadir}/bash-completion/completions/virt-install
+%{_datadir}/bash-completion/completions/virt-clone
+%{_datadir}/bash-completion/completions/virt-xml
 
 %{_bindir}/virt-install
 %{_bindir}/virt-clone
-%{_bindir}/virt-convert
 %{_bindir}/virt-xml
 
 
 %changelog
+* Fri Jul 17 2026 Fedora Release Engineering <releng@fedoraproject.org> - 5.1.0-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_45_Mass_Rebuild
+
+* Sat Jan 17 2026 Fedora Release Engineering <releng@fedoraproject.org> - 5.1.0-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_44_Mass_Rebuild
+
+* Wed Jan 07 2026 Pavel Hrdina <phrdina@redhat.com> - 5.1.0.3
+- Fix cloud init
+
+* Fri Sep 19 2025 Python Maint <python-maint@redhat.com> - 5.1.0-2
+- Rebuilt for Python 3.14.0rc3 bytecode
+
+* Tue Aug 26 2025 Pavel Hrdina <phrdina@redhat.com> - 5.1.0-1
+- Update to version 5.1.0
+
+* Fri Aug 15 2025 Python Maint <python-maint@redhat.com> - 5.0.0-4
+- Rebuilt for Python 3.14.0rc2 bytecode
+
+* Fri Jul 25 2025 Fedora Release Engineering <releng@fedoraproject.org> - 5.0.0-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild
+
+* Sun Jan 19 2025 Fedora Release Engineering <releng@fedoraproject.org> - 5.0.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild
+
+* Mon Dec 02 2024 Pavel Hrdina <phrdina@redhat.com> - 5.0.0-1
+- Update to version 5.0.0
+
+* Tue Sep 10 2024 Cole Robinson <crobinso@redhat.com> - 4.1.0-9
+- Add sev-snp changes for feature ConfidentialVirtHostAMDSEVSNP
+
+* Mon Aug 05 2024 Cole Robinson <crobinso@redhat.com> - 4.1.0-8
+- Fix flatpak build
+- Add /usr/share/virt-manager/ui/ to rpm db (bz 2283244)
+
+* Sat Jul 20 2024 Fedora Release Engineering <releng@fedoraproject.org> - 4.1.0-7
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild
+
+* Wed Jun 26 2024 Daniel. P. Berrange <berrange@redhat.com> - 4.1.0-6
+- Fix compat with latest python 3.13 (rhbz #2294201)
+
+* Sat Jan 27 2024 Fedora Release Engineering <releng@fedoraproject.org> - 4.1.0-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild
+
+* Fri Sep 29 2023 Sandro Bonazzola <sbonazzo@redhat.com> - 4.1.0-4
+- Drop spice-gtk3 on Fedora ELN as in CentOS Stream 9
+- Resolves: fedora#2237969
+
+* Sat Jul 22 2023 Fedora Release Engineering <releng@fedoraproject.org> - 4.1.0-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild
+
+* Sat Jan 21 2023 Fedora Release Engineering <releng@fedoraproject.org> - 4.1.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_38_Mass_Rebuild
+
+* Thu Aug 04 2022 Cole Robinson <crobinso@redhat.com> - 4.1.0-1
+- Update to version 4.1.0
+
+* Wed Aug  3 2022 Daniel. P. Berrange <berrange@redhat.com> - 4.0.0-3
+- Fix compat with setuptools >= 61 (rhbz#2113754)
+
+* Sat Jul 23 2022 Fedora Release Engineering <releng@fedoraproject.org> - 4.0.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_37_Mass_Rebuild
+
+* Wed Mar 02 2022 Cole Robinson <crobinso@redhat.com> - 4.0.0-1
+- Update to version 4.0.0
+
+* Sun Feb 20 2022 Cole Robinson <crobinso@redhat.com> - 3.2.0-6
+- Update to latest git snapshot
+
+* Sat Jan 22 2022 Fedora Release Engineering <releng@fedoraproject.org> - 3.2.0-5
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_36_Mass_Rebuild
+
+* Fri Jul 23 2021 Fedora Release Engineering <releng@fedoraproject.org> - 3.2.0-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_35_Mass_Rebuild
+
+* Wed Jan 27 2021 Fedora Release Engineering <releng@fedoraproject.org> - 3.2.0-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_34_Mass_Rebuild
+
+* Mon Jan 11 2021 Cole Robinson <crobinso@redhat.com> - 3.2.0-2
+- Fix 'domain not found' race (bz #1901081)
+
+* Sat Nov 14 2020 Cole Robinson <crobinso@redhat.com> - 3.2.0-1
+- Update to version 3.2.0
+- Slim down filesystem device editor UI
+- Fix TOCTTOU virt-install bugs (Martin Pitt)
+- Several other bug fixes
+
+* Wed Sep 30 2020 Cole Robinson <crobinso@redhat.com> - 3.1.0-1
+- Update to version 3.1.0
+
+* Tue Sep 15 2020 Cole Robinson <crobinso@redhat.com> - 3.0.0-1
+- Update to version 3.0.0
+
+* Mon Aug 31 2020 Cole Robinson <aintdiscole@gmail.com> - 2.2.1-6
+- spec: Switch to latest Fedora bytecompile macros
+
+* Sat Aug 01 2020 Fedora Release Engineering <releng@fedoraproject.org> - 2.2.1-5
+- Second attempt - Rebuilt for
+  https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
+
+* Wed Jul 29 2020 Fedora Release Engineering <releng@fedoraproject.org> - 2.2.1-4
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_33_Mass_Rebuild
+
+* Fri Jan 31 2020 Fedora Release Engineering <releng@fedoraproject.org> - 2.2.1-3
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
+
+* Sat Jul 27 2019 Fedora Release Engineering <releng@fedoraproject.org> - 2.2.1-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_31_Mass_Rebuild
+
+* Wed Jul 03 2019 Cole Robinson <crobinso@redhat.com> - 2.2.1-1
+- Rebased to version 2.2.1
+- CVE-2019-10183: Replace --unattended user-password and admin-password with
+  user-password-file and admin-password-file (Fabiano Fidêncio)
+- Consistent --memballoon default across non-x86 (Andrea Bolognani)
+- virt-install: add --numatune memnode.* (Athina Plaskasoviti)
+- Drop hard dep on gtksourceview4, gtksourceview3 is fine as well
+
+* Tue Jun 18 2019 Cole Robinson <crobinso@redhat.com> - 2.2.0-2
+- Add missing dep on gtksourceview
+
+* Mon Jun 17 2019 Cole Robinson <crobinso@redhat.com> - 2.2.0-1
+- Rebased to version 2.2.0
+- libvirt XML viewing and editing UI for new and existing domain, pools,
+  volumes, networks
+- virt-install: libosinfo --unattended support (Fabiano Fidêncio, Cole
+  Robinson)
+- Improve CPU model security defaults (Pavel Hrdina)
+- virt-install: new --install  option. Ex: virt-install --install fedora29
+- virt-install: new --install kernel=,initrd=
+- virt-install: --disk, --memory, --name defaults from libosinfo (Fabiano
+  Fidêncio, Cole Robinson)
+- virt-install: add device suboption aliases which consistently match
+  libvirt XML naming
+- virt-xml: new --start, --no-define options (Marc Hartmayer)
+- virt-install: Add driver_queues argument to --controller (Vasudeva Kamath)
+- RISC-V support (Andrea Bolognani)
+- Device default improvements for non-x86 KVM (Andrea Bolognani)
+- Redesigned 'New Network' wizard
+- libguestfs inspection improvements (Pino Toscano)
+- virt-install: Add support for xenbus controller (Jim Fehlig)
+- cli: Add --disk wwn=,rawio= (Athina Plaskasoviti)
+- cli: Add --memballoon autodeflate=,stats.period= (Athina Plaskasoviti)
+- cli: Add --iothreads (Athina Plaskasoviti)
+- cli: Add --numatune memory.placement (Athina Plaskasoviti)
+- cli: Add --launchSecurity option (Erik Skultety)
+- cli: Fill in --memorybacking options
+- cli: --smartcard: support database= and certificate[0-9]*=
+- cli: --sysinfo: Add chasis suboptions
+- cli: --metadata: add genid= and genid_enable=
+- cli: --vcpus: add vcpus.vcpu[0-9]* config
+- cli: fill in all common char source options for --serial, --parellel,
+  --console, --channel, --smartcard, --rng, --redirdev
+
+* Wed Apr 03 2019 Cole Robinson <crobinso@redhat.com> - 2.1.0-2
+- Fix --initrd-inject with f30 URLs (bz #1686464)
+
+* Sun Feb 03 2019 Cole Robinson <crobinso@redhat.com> - 2.1.0-1
+- Rebased to version 2.1.0
+- Bash autocompletion support (Lin Ma, Cole Robinson)
+- UI and command line --vsock support (Slavomir Kaslev)
+- virt-xml: Add --os-variant option (Andrea Bolognani)
+- virt-install: use libosinfo cpu, mem, disk size defaults (Fabiano
+  Fidencio)
+- virt-install: Better usage of libosinfo -unknown distro IDs (Fabiano
+  Fidencio)
+- virt-install: More usage of libosinfo for ISO --location detection
+- virt-install: Add --location LOCATION,kernel=X,initrd=Y for pointing to
+  kernel/initrd in media that virt-install/libosinfo fails to detect
+
+* Sun Feb 03 2019 Fedora Release Engineering <releng@fedoraproject.org> - 2.0.0-2
+- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
+
 * Mon Oct 15 2018 Cole Robinson <crobinso@redhat.com> - 2.0.0-1
 - Rebased to version 2.0.0
 - Finish port to Python 3
@@ -997,7 +1175,7 @@ done
 - Disable wizard sensitivity while creating VM
 
 * Thu Oct 19 2006 Daniel P. Berrange <berrange@redhat.com> - 0.2.5-1.fc7
-- Switch to use python-virtinst instead of python-xeninst due to 
+- Switch to use python-virtinst instead of python-xeninst due to
   renaming of original package
 - Disable keyboard accelerators when grabbing mouse to avoid things like
   Ctrl-W closing the local window, instead of remote window bz 210364