diff --git a/ypserv-4.0-headers.patch b/ypserv-4.0-headers.patch index 320558d..499af39 100644 --- a/ypserv-4.0-headers.patch +++ b/ypserv-4.0-headers.patch @@ -1,5 +1,5 @@ ---- makedbm/makedbm.c.headers 2017-02-21 13:57:23.933293831 +0100 -+++ makedbm/makedbm.c 2017-02-21 13:57:48.141286207 +0100 +--- ypserv-4.2/makedbm/makedbm.c.headers 2017-02-21 13:57:23.933293831 +0100 ++++ ypserv-4.2/makedbm/makedbm.c 2017-02-21 13:57:48.141286207 +0100 @@ -30,6 +30,7 @@ #include #include diff --git a/ypserv-4.2-uninitialized-int.patch b/ypserv-4.2-uninitialized-int.patch new file mode 100644 index 0000000..aa56a04 --- /dev/null +++ b/ypserv-4.2-uninitialized-int.patch @@ -0,0 +1,80 @@ +From 2bc35f9592c8abc850fc6d3343a29227b45eb054 Mon Sep 17 00:00:00 2001 +From: Ales Nezbeda +Date: Tue, 1 Oct 2024 14:40:26 +0200 +Subject: [PATCH] Fix use of uninitialized variable as an value for sock opt + +Since it is possible to listen to IPv4 via IPv6 socket by default, we +have to disable this feature due to 'Disallow v4-in-v6 to allow +host-based access checks'. This also allows us to use the same port for +IPv4 and IPv6 socket. + +Disabling this feature is done via `setsockopt()` function where we pass +flag that we want to set - `IPV6_V6ONLY` and value. For value, we should +pass pointer to value and size of the value. We were passing pointer to +uninitialized integer as a value. This resulted in undefined behavior. + +Most likely, this undefined behavior resulted in the flag being set to +false. This also resulted in IPv4 and IPv6 not being able to share +the same port. This caused use of two neighboring ports instead of one. +When user then tried to set port in config file and then use port one +above it was not possible as it was already used. +--- + rpc.yppasswdd/yppasswdd.c | 2 +- + rpc.ypxfrd/ypxfrd.c | 2 +- + yppush/yppush.c | 3 ++- + ypserv/ypserv.c | 2 +- + 4 files changed, 5 insertions(+), 4 deletions(-) + +diff --git a/rpc.yppasswdd/yppasswdd.c b/rpc.yppasswdd/yppasswdd.c +index f9609eb..d7f6050 100644 +--- a/rpc.yppasswdd/yppasswdd.c ++++ b/rpc.yppasswdd/yppasswdd.c +@@ -476,7 +476,7 @@ main (int argc, char **argv) + { + /* Disallow v4-in-v6 to allow host-based access checks */ + +- int i; ++ int i = 1; + + if (setsockopt (sock, IPPROTO_IPV6, IPV6_V6ONLY, + &i, sizeof(i)) == -1) +diff --git a/rpc.ypxfrd/ypxfrd.c b/rpc.ypxfrd/ypxfrd.c +index f605c84..469e0e5 100644 +--- a/rpc.ypxfrd/ypxfrd.c ++++ b/rpc.ypxfrd/ypxfrd.c +@@ -385,7 +385,7 @@ main (int argc, char **argv) + { + /* Disallow v4-in-v6 to allow host-based access checks */ + +- int i; ++ int i = 1; + + if (setsockopt (sock, IPPROTO_IPV6, IPV6_V6ONLY, + &i, sizeof(i)) == -1) +diff --git a/yppush/yppush.c b/yppush/yppush.c +index d937b84..a5916be 100644 +--- a/yppush/yppush.c ++++ b/yppush/yppush.c +@@ -430,7 +430,8 @@ yppush_foreach (const char *host) + struct timeval tv = {10, 0}; + u_int transid; + char server[YPMAXPEER + 2]; +- int i, sock; ++ int i = 1; ++ int sock; + struct sigaction sig; + struct netconfig *nconf; + struct sockaddr *sa; +diff --git a/ypserv/ypserv.c b/ypserv/ypserv.c +index d8876e9..e27c2a4 100644 +--- a/ypserv/ypserv.c ++++ b/ypserv/ypserv.c +@@ -497,7 +497,7 @@ main (int argc, char **argv) + if (family == AF_INET6) + { + /* Disallow v4-in-v6 to allow host-based access checks */ +- int i; ++ int i = 1; + + if (setsockopt (sock, IPPROTO_IPV6, IPV6_V6ONLY, + &i, sizeof(i)) == -1) diff --git a/ypserv.spec b/ypserv.spec index 47d994d..01a095e 100644 --- a/ypserv.spec +++ b/ypserv.spec @@ -1,9 +1,11 @@ Summary: The NIS (Network Information Service) server -Url: http://www.linux-nis.org/nis/ypserv/index.html + Name: ypserv Version: 4.2 -Release: 8%{?dist} -License: GPLv2 +Release: 15%{?dist} +License: GPL-2.0-only +URL: https://www.thkukuk.de/nis/nis/ypserv/ + Source0: https://github.com/thkukuk/%{name}/archive/v%{version}.tar.gz Source1: ypserv.service Source2: yppasswdd.service @@ -31,8 +33,10 @@ Patch10: ypserv-2.31-netgrprecur.patch Patch12: ypserv-4.0-headers.patch Patch14: ypserv-4.0-selinux-context.patch Patch15: ypserv-4.2-implicit-int.patch +Patch16: ypserv-4.2-uninitialized-int.patch BuildRequires: make +BuildRequires: libxcrypt-devel BuildRequires: gcc BuildRequires: tokyocabinet-devel BuildRequires: systemd @@ -61,21 +65,7 @@ need to install the yp-tools and ypbind packages on any NIS client machines. %prep - -%setup -q - -%patch0 -p1 -b .redhat -%patch2 -p1 -b .nfsnobody -%patch3 -p1 -b .respzero -%patch4 -p1 -b .nonedomain -%patch5 -p1 -b .slp-warning -%patch6 -p1 -b .manfix -%patch7 -p1 -b .aliases -%patch8 -p1 -b .confpost -%patch10 -p1 -b .netgrprecur -%patch12 -b .headers -%patch14 -p1 -b .selinux-context -%patch15 -p1 -b .implicit-int +%autosetup -n %{name}-%{version} -p1 # Delete generated man pages. They will be generated later from source. rm makedbm/makedbm.8 @@ -94,7 +84,7 @@ export CFLAGS="$RPM_OPT_FLAGS -fpic" %endif # Fix gcc12 issues (#2047138) -export CFLAGS="$CFLAGS -D_FORTIFY_SOURCE=2 -Wno-format-overflow" +export CFLAGS="$CFLAGS -Wno-format-overflow" %configure \ --enable-checkroot \ @@ -177,6 +167,28 @@ install -m 755 %{SOURCE4} $RPM_BUILD_ROOT%{_libexecdir}/rpc.yppasswdd.env %{_includedir}/rpcsvc %changelog +* Fri Jul 25 2025 Fedora Release Engineering - 4.2-15 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_43_Mass_Rebuild + +* Sat Feb 01 2025 Björn Esser - 4.2-14 +- Add explicit BR: libxcrypt-devel + +* Sun Jan 19 2025 Fedora Release Engineering - 4.2-13 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_42_Mass_Rebuild + +* Tue Jan 14 2025 Ales Nezbeda - 4.2-12 +- Fix uninitialized int causing different ports for IPv4 and IPv6 + +* Sat Jul 20 2024 Fedora Release Engineering - 4.2-11 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_41_Mass_Rebuild + +* Tue Jan 30 2024 Ondrej Sloup - 4.2-10 +- Don't hard code _FORTIFY_SOURCE=2 +- Update license tag to the SPDX format (GPL-2.0-only) + +* Sat Jan 27 2024 Fedora Release Engineering - 4.2-9 +- Rebuilt for https://fedoraproject.org/wiki/Fedora_40_Mass_Rebuild + * Sat Jul 22 2023 Fedora Release Engineering - 4.2-8 - Rebuilt for https://fedoraproject.org/wiki/Fedora_39_Mass_Rebuild