tests/python
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not skip a flag without -O, if the flag is checked explicitly

Browse source
This commit is contained in:
Miro Hrončok 2024-09-10 17:58:27 +02:00
commit 5ffff08833
2 changed files with 9 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
flags/assertflags.py
View file

@ -16,6 +16,10 @@ import sysconfig
# We will check all flags if none were requested
KEYS_TO_CHECK = sys.argv[2:] or list(sysconfig.get_config_vars().keys())
# For backwards compatibility, if no flags were provided, we assume flags without -O are to be skipped
# But when we provide explicit list of flags, we assert they get the options,
# so we can assert things like "CFLAGS has -O3" vs. "CFLAGS has no -O at all"
NO_FLAG_FAILS = bool(sys.argv[2:])
# The flags that currently don't have the -Og flag on the debug build
# and we consider it OK, because we don't know any better :)
@ -35,8 +39,8 @@ for key in KEYS_TO_CHECK:
flags = sysconfig.get_config_vars()[key]
if isinstance(flags, str):
oflags = [f for f in flags.split(' ') if f.startswith('-O')]
if oflags and oflags[-1] != sys.argv[1]:
print('Problem in {} -O flags: {}'.format(key, ' '.join(oflags)))
if (oflags and oflags[-1] != sys.argv[1]) or (not oflags and NO_FLAG_FAILS):
print('Problem in {} -O flags: {}'.format(key, ' '.join(oflags) or '<empty>'))
ret = 1
elif oflags:
print('{} are OK'.format(key))