Fix bash completion to look in the actual cows/ directory.
It appears that cowsay used to store its cows in
/usr/share/cowsay and that is where the cowsay.bashcomp
file also looked. However, cowsay now stores its cows in
/usr/share/cowsay/cows, so the bash completion should look
there as well.
Note that the bash completion should also look into
/usr/share/cowsay/site-cows/ and wherever else cowsay
looks for cows.
Upstream's "make install" does install an empty
/usr/share/cowsay/site-cows/
directory into which local site specific cows can be placed, so
reimplement *and* *package* that.
Change the name of the installed bash completion file from
"cowsay.bashcomp" to "cowsay".
Of the 1000+ files in /usr/share/bash-completion/completions/ on my
system, no other file is called "*.bashcomp". Most are just called
the same as their respective command.
We also let the filesystem package take care of owning the
directory /usr/share/bash-completion/ and its subdirectories.
Use "install" for installing all dirs and files.
As the name suggests, the "install" command is the program
for installing files (and directories), as it will e.g.
ignore the umask (unlike the "cp" command).
Ensure /usr/bin/animalsay mode is 0755 (not 0775).
File mode 0775 has happened at least for my mockbuild environment.
To achieve a certain file mode of 0755, we
* change the git permissions of animalsay from 0664 to 0644
* use "install" instead of "cp" for installing the file
* explicitly tell "install" to install with -m 0755
Fix mixed use of spaces and tabs in spec file.
rpmlint complains about it, and adapting that one line to use the
same formatting as all other lines do certainly does not hurt.
The cowsay code does not support cows in the *.pm format.
As "cowsay -r" occasionally selects one unsupported *.pm
format cow purely by chance, "cowsay -r" will produce an
error message instead of a cow in these occasions.
Not packaging the *.pm cows avoids the issue until upstream
either stops considering unsupported cows for random
selection or implements support for *.pm format cows.
The upstream bug is https://github.com/cowsay-org/cowsay/issues/22
and affects at least cowsay-3.7.0. It is currently marked
to be resolved in cowsay-3.8.0 (the random selection part,
not the *.pm implementation part).
The fox cow is included in the Debian/Ubuntu package of cowsay.
Author has released it under the same license as cowsay itself:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=888229
Tested:
```
$ cowsay -f fox 'Crazy like a fox!'
___________________
< Crazy like a fox! >
-------------------
\ ,-. .-,
\ |-.\ __ /.-|
\ \ ` ` /
/_ _ \
< _`q p _ >
<.._=/ \=_. >
{`\()/`}`\
{ } \
|{ } \
\ '--' .- \
|- / \
| | | | | ;
| | |.;.,..__ |
.-"";` `|
/ | /
`-../____,..---'`
```
