We replace every hardcoded path with an autotools variable @sbindir@
that is replaced at build time by the correct installation path.
This was tested on SLES and RHEL.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
Spec file had a bug where it would fail to package and install on
systems that don't have systemd, i.e. those who still use init scripts.
This patch applies a fix that verifies whether we are using systemd or
init files before installing the correct daemon starter.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
Some distros install ncurses headers in an unconventional path and this
stops autotools from automatically including them. This patch uses the
ncurses5-config script to discover the correct path to ncurses.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
Since we enhanced the retry logic for tool_init, it had the side
effect of adding a delay for iprutils when run if the ipr driver is
not loaded. Revert this behavior so we don't sit and sleep for an
extended period of time on systems with no ipr.
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
This patch fixes an issue when the ipr daemons are stopped when
tool_init() function is called on iprlib.c. When failing to open
scsi_host class or read the scsi device model, the function called
exit_on_error(), which killed the daemons in the process. This patch
changes it to warning messages while performs 4 attempts to open
scsi_host class or read the scsi device model.
Signed-off-by: Daniel Kreling <kreling@linux.vnet.ibm.com>
Reviewed-by: Gabriel K. Bertazi <krisman@linux.vnet.ibm.com>
Reviewed-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
The patch adds more checks when trying to create easy tier array.
Signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
When customers try to create the array, the box for displaying "create
RAID level" is empty. The patch fixes the issue.
Signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
Commit 2f183e5 introduced the script iprsos, but the latter commit
dd58951, which inserts autotools, won't install it. This patch adds
iprsos and iprsos.8 to the makefile.am, so autotools can correctly build
and install iprsos.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
The FRU and part number were being displayed swapped in the
disk unit details screen. This fixes this up.
Signed-off-by: Brian King <Brian King brking@linux.vnet.ibm.com>
This patch removes the old building system.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
This commit adapts the spec to use the autotools build system.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Update documentation. Include information on how to build and install
using autotools.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
This commit adds support to build iprutils using GNU Autools. It
replaces the old Makefile and version.mk file with Automake. Now, the
version information is available at the configure.ac file.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
This patch implements 'iprconfig -c dump' command which creates an sos-report
like file with log information about the adapters and the environment. It also
introduces a bash script "iprsos" that triggers the new command and creates
the log file at /var/log/iprsos.log
Signed-off-by: Daniel Kreling <kreling@linux.vnet.ibm.com>
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Improve support for saving device attributes such as queue depth
on SIS-64 adapters by fixing the attribute binding algorithm
to bind to the device_id value, which is immutable.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
When trying to add devices to a disks array, it failed. Added one more
reason for the failure. New adapters doesn't support this function.
Signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
The query-device iprconfig command currently returns the first
device found. Change to return the device under the primary adapter
if in a dual adapter configuration.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
This patch clarifies the documentation about the behavior of ipdump
utility when it is directly run by the user.
Signed-off-by: Daniel Kreling <kreling@linux.vnet.ibm.com>
Ensure the known zeroed state gets set via mode select for
all AF DASD after they have been formatted to speed up array
creation.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Customer uses iprconifg GUI interface to update adapter firmware.
If firmware format in /lib/firmware is pci.xxx, iprconfig can't find
firmware file. This patch fixes the issue.
Signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
The patch is to verify the cache hit on the SAS disk drive.
Signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
Signed-off-by: Mutali Lyer<mniyer@us.ibm.com>
This patch prevents tool_init to stop when there is no scsi host
on ipr device, thus allowing the ipr daemons to start later during
boot process.
signed-off-by: Daniel Kreling <dbkreling@linux.vnet.ibm.com>
This patch fixes the issue about capacity is not reported for Jbod drivers
greater than 2TB in iprconifg.
signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
With iprutils 2.4.2 in PowerNV system, sometime some of IOAs still showed
the wrong phyiscal location. This patch fixes the issue.
signed-off-by: Wen Xiong<wenxiong@linux.vnet.ibm.com>
When an array member has non-4K disks, the interface prints an extra
blank space on the device description. This patch fixes this issue,
making the final string have only one blank space between the
substrings.
Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
When using command line to rebuild an array with physical disks, iprconfig
throws Segmentation fault. The patch fixes the issue.
Signed-off-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
iprutils daemon files (iprdump.service, iprinit.service and
iprupdate.service) were created and housed on systemd directory.
In the file system, they should be sent to /usr/lib/systemd/system.
iprutils.spec was adapted to support the changes and manage
those service files.
Signed-off-by: Daniel Kreling <kreling@imap.linux.ibm.com>
After commit 9692360 (iprutils: Eliminate libsysfs dependency) iprconfig
is terminated if the sg module is not loaded. This patch fixes this
issue by recoving the previous behavior, which is just log a debug
message and call modprobe to load the module.
Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
The 'Download Microcode' screen presents all the devices that are
eligible for microcode download, not only adapters.
Signed-off-by: Kleber Sacilotto de Souza <klebers@linux.vnet.ibm.com>
The patch fixes the two issues. One issue is not able to create iprdump file.
Another issue is the size of dump file is less than 64K. We need 80M iprdump
file.
Signed-off-by: Wen Xiong <wenxiong@linux.vnet.ibm.com>
Criated iprinit.service, iprdump.service and iprupdate.service files to
provide support to distros using systemd instead of init.d. Also by doing
that, we're bumping to version 2.4.2.
Signed-off by: Daniel Kreling <dkreling@imap.linux.ibm.com>
query-array: Takes as an argument a platform location code. If the disk
at that location is in a RAID array, the device name of the RAID array is
returned.
query-device: Takes as an argument a platform location code. Prints
the device name of the device at that location.
query-location: Takes as an argument a device name. If the device specified is
a
disk, prints the physical location of the disk. If the device specified is a
single disk RAID 0 array, prints the physical location of the sole device in
the RAID 0 array.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
scsi_dev_data->device_id is a u64, so should be scanned with %llX rather
than %lX. On 32-bit big-endian systems I believe this will scan the
device_id into the wrong half of the 64-bit value.
Signed-off-by: Colin Watson <cjwatson@debian.org>
---
"command &> /dev/null" and "command >& /dev/null" are bashisms and will
fail on e.g. systems where /bin/sh is dash. Use POSIX-compatible
alternatives.
Signed-off-by : Colin Watson <cjwatson@debian.org>
---
On Ubuntu and Debian, the hardened build passes the following flags to the compilation
through env. variables.
Hence several formatting strings are mandatory. Also for that to work, the Makefile
needs to handle the env. variables.
$ dpkg-buildflags
CFLAGS=-g -O3 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security
CPPFLAGS=-D_FORTIFY_SOURCE=2
CXXFLAGS=-g -O3 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security
FFLAGS=-g -O3 -fstack-protector --param=ssp-buffer-size=4
GCJFLAGS=-g -O3 -fstack-protector --param=ssp-buffer-size=4
LDFLAGS=-Wl,-Bsymbolic-functions -Wl,-z,relro
Signed-off-by: Frédéric Bonnard <frediz@linux.vnet.ibm.com>
